RE: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW functions

On 21 June 2016 23:30, Rafael J. Wysocki wrote: > > This patch set converts the da7219 codec driver to use device/fwnode > > functions > > to access properties, instead of the DT only of_* functions, allowing ACPI > > to be used as well. > > > > The DT bindings for da7219 have a device node for

RE: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW functions

On 21 June 2016 23:30, Rafael J. Wysocki wrote: > > This patch set converts the da7219 codec driver to use device/fwnode > > functions > > to access properties, instead of the DT only of_* functions, allowing ACPI > > to be used as well. > > > > The DT bindings for da7219 have a device node for

RE: [RESEND PATCH v3 1/2] device property: Add function to search for named child of device

21 June 2016 12:42, Rafael J. Wysocki wrote: > > > +static inline bool acpi_data_node_match(struct fwnode_handle *fwnode, > > > + const char *name) > > > +{ > > > + return is_acpi_data_node(fwnode) ? > > > + (!strcasecmp(to_acpi_data_node(fwnode)->name,

RE: [RESEND PATCH v3 1/2] device property: Add function to search for named child of device

21 June 2016 12:42, Rafael J. Wysocki wrote: > > > +static inline bool acpi_data_node_match(struct fwnode_handle *fwnode, > > > + const char *name) > > > +{ > > > + return is_acpi_data_node(fwnode) ? > > > + (!strcasecmp(to_acpi_data_node(fwnode)->name,

RE: [RESEND PATCH v3 1/2] device property: Add function to search for named child of device

On 20 June 2016 12:39, Adam Thomson wrote: > For device nodes in both DT and ACPI, it possible to have named > child nodes which contain properties (an existing example being > gpio-leds). This adds a function to find a named child node for > a device which can be used by drivers for property

RE: [RESEND PATCH v3 1/2] device property: Add function to search for named child of device

On 20 June 2016 12:39, Adam Thomson wrote: > For device nodes in both DT and ACPI, it possible to have named > child nodes which contain properties (an existing example being > gpio-leds). This adds a function to find a named child node for > a device which can be used by drivers for property

RE: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

On 16 June 2016 02:15, Xing Zheng wrote: > >> + /* Enable Headset and 4 Buttons Jack detection */ > >> + ret = snd_soc_card_jack_new(rtd->card, "Headset Jack", > >> + SND_JACK_HEADSET | > > Should this also include SND_JACK_LINEOUT? da7219

RE: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

On 16 June 2016 02:15, Xing Zheng wrote: > >> + /* Enable Headset and 4 Buttons Jack detection */ > >> + ret = snd_soc_card_jack_new(rtd->card, "Headset Jack", > >> + SND_JACK_HEADSET | > > Should this also include SND_JACK_LINEOUT? da7219

RE: [RESEND PATCH v2 1/2] device property: Add function to search for named child of device

On 13 June 2016 20:33, Frank Rowand wrote: > > DT node names are case insensitive. The of.h header does provide a helper > > macro > > which is equivalent to this, but that macro is part of the '#ifdef > > CONFIG_OF' > > block. If I were to use it then it would cause non-DT builds to fail. I >

RE: [RESEND PATCH v2 1/2] device property: Add function to search for named child of device

On 13 June 2016 20:33, Frank Rowand wrote: > > DT node names are case insensitive. The of.h header does provide a helper > > macro > > which is equivalent to this, but that macro is part of the '#ifdef > > CONFIG_OF' > > block. If I were to use it then it would cause non-DT builds to fail. I >

RE: [RESEND PATCH v2 1/2] device property: Add function to search for named child of device

On 13 June 2016 09:47, Mark Brown wrote: > > That's strange. I'm not a subscriber to that mailing list, but I assume that > > shouldn't matter here? Strangely though the only mailing list these seem to > > have > > made it to is the ALSA one. :( Will see if I can find out why as I've not > >

RE: [RESEND PATCH v2 1/2] device property: Add function to search for named child of device

On 13 June 2016 09:47, Mark Brown wrote: > > That's strange. I'm not a subscriber to that mailing list, but I assume that > > shouldn't matter here? Strangely though the only mailing list these seem to > > have > > made it to is the ALSA one. :( Will see if I can find out why as I've not > >

RE: [PATCH 0/3] ASoC: da7219: Add ACPI initialisation support to driver

On 10 June 2016 11:16, Adam Thomson wrote: > This patch set updates the driver to use generic device property & fwnode > related functions to read in either DT and ACPI data for driver > initialisation. > > Changes are based on v4.6-rc6 Linux Kernel. > > Adam Thomson (3): > ASoC: da7219:

RE: [PATCH 0/3] ASoC: da7219: Add ACPI initialisation support to driver

On 10 June 2016 11:16, Adam Thomson wrote: > This patch set updates the driver to use generic device property & fwnode > related functions to read in either DT and ACPI data for driver > initialisation. > > Changes are based on v4.6-rc6 Linux Kernel. > > Adam Thomson (3): > ASoC: da7219:

RE: [RESEND PATCH v2 1/2] device property: Add function to search for named child of device

On 10 June 2016 00:11, Rafael J. Wysocki wrote: > For some reason that didn't make it into the linux-acpi list, or at > least I can't see it there. That's strange. I'm not a subscriber to that mailing list, but I assume that shouldn't matter here? Strangely though the only mailing list these

RE: [RESEND PATCH v2 1/2] device property: Add function to search for named child of device

On 10 June 2016 00:11, Rafael J. Wysocki wrote: > For some reason that didn't make it into the linux-acpi list, or at > least I can't see it there. That's strange. I'm not a subscriber to that mailing list, but I assume that shouldn't matter here? Strangely though the only mailing list these

RE: [PATCH 1/3] ASoC: da7219: Convert driver to use generic device/fwnode functions

On May 06, 2016, 17:06, Mark Brown wrote: > No, not really - your DT is fairly unusual in how it's done and the lack > of ACPI helpers is not a good sign on that side. The _DSD things are > really only supposed to work for simple properties on devices. It's unusual in that there's a child node

RE: [PATCH 1/3] ASoC: da7219: Convert driver to use generic device/fwnode functions

On May 06, 2016, 17:06, Mark Brown wrote: > No, not really - your DT is fairly unusual in how it's done and the lack > of ACPI helpers is not a good sign on that side. The _DSD things are > really only supposed to work for simple properties on devices. It's unusual in that there's a child node

RE: [PATCH 2/3] ASoC: da7219: Add ACPI parsing support

On May 06, 2016, 13:39, Mark Brown wrote: > > @@ -27,7 +28,6 @@ > > #include "da7219.h" > > #include "da7219-aad.h" > > > > - > > /* > > * Detection control > > */ > > Random whitespace change. Fair point. Will sort it. > > > static struct fwnode_handle

RE: [PATCH 2/3] ASoC: da7219: Add ACPI parsing support

On May 06, 2016, 13:39, Mark Brown wrote: > > @@ -27,7 +28,6 @@ > > #include "da7219.h" > > #include "da7219-aad.h" > > > > - > > /* > > * Detection control > > */ > > Random whitespace change. Fair point. Will sort it. > > > static struct fwnode_handle

RE: [PATCH 1/3] ASoC: da7219: Convert driver to use generic device/fwnode functions

On May 06, 2016, 13:27, Mark Brown wrote: > > This change converts the driver from using the of_* functions to using > > the device_* and fwnode_* functions for accssing DT related data. > > This is in preparation for updates to support ACPI based initialisation. > > Is this *really* sensible?

RE: [PATCH 1/3] ASoC: da7219: Convert driver to use generic device/fwnode functions

On May 06, 2016, 13:27, Mark Brown wrote: > > This change converts the driver from using the of_* functions to using > > the device_* and fwnode_* functions for accssing DT related data. > > This is in preparation for updates to support ACPI based initialisation. > > Is this *really* sensible?

RE: linux-next: build failure after merge of the sound-asoc tree

On May 06, 2016, 13:03, Mark Brown wrote: > > This patch was the 3rd in of a set of 3, and the header you added below was > > added as part of the 2nd patch of that set, hence why it is missing here. I > > assume the first 2 patches are still being reviewed by Mark. > > Yes. The ID patch should

RE: linux-next: build failure after merge of the sound-asoc tree

On May 06, 2016, 13:03, Mark Brown wrote: > > This patch was the 3rd in of a set of 3, and the header you added below was > > added as part of the 2nd patch of that set, hence why it is missing here. I > > assume the first 2 patches are still being reviewed by Mark. > > Yes. The ID patch should

RE: linux-next: build failure after merge of the sound-asoc tree

On May 06, 2016, 01:58, Stephen Rothwell wrote: > Hi all, > > After merging the sound-asoc tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > sound/soc/codecs/da7219.c:1964:23: error: implicit declaration of function > 'ACPI_PTR' [-Werror=implicit-function-declaration]

RE: linux-next: build failure after merge of the sound-asoc tree

On May 06, 2016, 01:58, Stephen Rothwell wrote: > Hi all, > > After merging the sound-asoc tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > sound/soc/codecs/da7219.c:1964:23: error: implicit declaration of function > 'ACPI_PTR' [-Werror=implicit-function-declaration]

RE: [PATCH] mfd: Allow i2c modular drivers to build with I2C=m

On January 21, 2016 00:50, Axel Lin wrote: > These drivers can be built as module, so make them depend on I2C rather > than I2C=y. > > Signed-off-by: Axel Lin For Dialog devices: Acked-by: Adam Thomson

RE: [PATCH] mfd: Allow i2c modular drivers to build with I2C=m

On January 21, 2016 00:50, Axel Lin wrote: > These drivers can be built as module, so make them depend on I2C rather > than I2C=y. > > Signed-off-by: Axel Lin For Dialog devices: Acked-by: Adam Thomson

RE: [PATCH 3/6] ASoC: da7219: Update REFERENCES reg default, in-line with HW

On December 23, 2015 00:10, Mark Brown wrote: > On Tue, Dec 22, 2015 at 06:27:53PM +, Adam Thomson wrote: > > In current AB silicon, BIAS_EN field is enabled by default in the > > REFERENCES register, so the regmap default value should reflect > > this. > > This is the sort of thing where a

RE: [PATCH 3/6] ASoC: da7219: Update REFERENCES reg default, in-line with HW

On December 23, 2015 00:10, Mark Brown wrote: > On Tue, Dec 22, 2015 at 06:27:53PM +, Adam Thomson wrote: > > In current AB silicon, BIAS_EN field is enabled by default in the > > REFERENCES register, so the regmap default value should reflect > > this. > > This is the sort of thing where a

RE: [PATCH] ASoC: da7218: Enable mic level detection reporting to user-space

On December 03, 2015 11:37, Takashi Iwai wrote: > > > > This patch adds support to the codec driver to handle mic level > > > > detect related IRQs, and report these to user-space using a uevent > > > > variable. > > > > > > Is the uevent the best way for this? > > > > > > > > > thanks, > > > > >

RE: [PATCH] ASoC: da7218: Enable mic level detection reporting to user-space

On December 03, 2015 10:56, Takashi Iwai wrote: > > This patch adds support to the codec driver to handle mic level > > detect related IRQs, and report these to user-space using a uevent > > variable. > > Is the uevent the best way for this? > > > thanks, > > Takashi Well originally I was

RE: [PATCH] ASoC: da7218: Enable mic level detection reporting to user-space

On December 03, 2015 10:56, Takashi Iwai wrote: > > This patch adds support to the codec driver to handle mic level > > detect related IRQs, and report these to user-space using a uevent > > variable. > > Is the uevent the best way for this? > > > thanks, > > Takashi Well originally I was

RE: [PATCH] ASoC: da7218: Enable mic level detection reporting to user-space

On December 03, 2015 11:37, Takashi Iwai wrote: > > > > This patch adds support to the codec driver to handle mic level > > > > detect related IRQs, and report these to user-space using a uevent > > > > variable. > > > > > > Is the uevent the best way for this? > > > > > > > > > thanks, > > > > >

RE: [PATCH v3 1/2] ASoC: da7218: Add bindings documentation for DA7218 audio codec

On November 20, 2015 15:54, Rob Herring wrote: > > +- dlg,micbias1-lvl-millivolt : Voltage (mV) for Mic Bias 1 > > + [<1200>, <1600>, <1800>, <2000>, <2200>, <2400>, <2600>, <2800>, > <3000>] > > +- dlg,micbias2-lvl-millivolt : Voltage (mV) for Mic Bias 2 > > + [<1200>, <1600>, <1800>,

RE: [PATCH v3 1/2] ASoC: da7218: Add bindings documentation for DA7218 audio codec

On November 20, 2015 15:54, Rob Herring wrote: > > +- dlg,micbias1-lvl-millivolt : Voltage (mV) for Mic Bias 1 > > + [<1200>, <1600>, <1800>, <2000>, <2200>, <2400>, <2600>, <2800>, > <3000>] > > +- dlg,micbias2-lvl-millivolt : Voltage (mV) for Mic Bias 2 > > + [<1200>, <1600>, <1800>,

RE: [PATCH v2 1/2] ASoC: da7218: Add bindings documentation for DA7218 audio codec

On November 17, 2015 17:54, Rob Herring wrote: > >> > +- dlg,micbias1-lvl : Voltage (mV) for Mic Bias 1 > >> > + [<1200>, <1600>, <1800>, <2000>, <2200>, <2400>, <2600>, <2800>, > >> <3000>] > >> > +- dlg,micbias2-lvl : Voltage (mV) for Mic Bias 2 > >> > + [<1200>, <1600>, <1800>, <2000>,

RE: [PATCH v2 1/2] ASoC: da7218: Add bindings documentation for DA7218 audio codec

On November 17, 2015 17:54, Rob Herring wrote: > >> > +- dlg,micbias1-lvl : Voltage (mV) for Mic Bias 1 > >> > + [<1200>, <1600>, <1800>, <2000>, <2200>, <2400>, <2600>, <2800>, > >> <3000>] > >> > +- dlg,micbias2-lvl : Voltage (mV) for Mic Bias 2 > >> > + [<1200>, <1600>, <1800>, <2000>,

RE: [PATCH v2 1/2] ASoC: da7218: Add bindings documentation for DA7218 audio codec

On November 11, 2015 20:20, Rob Herring wrote: > > +- dlg,micbias1-lvl : Voltage (mV) for Mic Bias 1 > > + [<1200>, <1600>, <1800>, <2000>, <2200>, <2400>, <2600>, <2800>, > <3000>] > > +- dlg,micbias2-lvl : Voltage (mV) for Mic Bias 2 > > + [<1200>, <1600>, <1800>, <2000>, <2200>, <2400>,

RE: [PATCH v2 1/2] ASoC: da7218: Add bindings documentation for DA7218 audio codec

On November 11, 2015 20:20, Rob Herring wrote: > > +- dlg,micbias1-lvl : Voltage (mV) for Mic Bias 1 > > + [<1200>, <1600>, <1800>, <2000>, <2200>, <2400>, <2600>, <2800>, > <3000>] > > +- dlg,micbias2-lvl : Voltage (mV) for Mic Bias 2 > > + [<1200>, <1600>, <1800>, <2000>, <2200>, <2400>,

RE: [PATCH 2/2] ASoC: codecs: Add da7218 codec driver

On November 10, 2015 15:45, Mark Brown wrote: > > It's to detect the noise level on a mic and raise an event if the captured > > sound is above a specific threshold level. Apologies if that wasn't clear. > > > In the driver code I'm using KEY_VOICECOMMAND, and simulating a press and > > release

RE: [PATCH 2/2] ASoC: codecs: Add da7218 codec driver

On November 10, 2015 14:15, Mark Brown wrote: > > > The general userspace expectation is that the detection is always active > > > and consistent rather than varying at runtime - runtime variability > > > might be a bit surprising for it, and even then variability in what is > > > detected based

RE: [PATCH 2/2] ASoC: codecs: Add da7218 codec driver

On November 9, 2015 14:02, Mark Brown wrote: > > > What I'm trying to figure out here is if this depends on the audio > > > routing at runtime or if it's got dedicated configuration? > > > This feature is available for any/all mics connected. Which mics are enabled > > is a runtime configuration

RE: [PATCH 2/2] ASoC: codecs: Add da7218 codec driver

On November 10, 2015 15:45, Mark Brown wrote: > > It's to detect the noise level on a mic and raise an event if the captured > > sound is above a specific threshold level. Apologies if that wasn't clear. > > > In the driver code I'm using KEY_VOICECOMMAND, and simulating a press and > > release

RE: [PATCH 2/2] ASoC: codecs: Add da7218 codec driver

On November 10, 2015 14:15, Mark Brown wrote: > > > The general userspace expectation is that the detection is always active > > > and consistent rather than varying at runtime - runtime variability > > > might be a bit surprising for it, and even then variability in what is > > > detected based

RE: [PATCH 2/2] ASoC: codecs: Add da7218 codec driver

On November 9, 2015 14:02, Mark Brown wrote: > > > What I'm trying to figure out here is if this depends on the audio > > > routing at runtime or if it's got dedicated configuration? > > > This feature is available for any/all mics connected. Which mics are enabled > > is a runtime configuration

RE: [PATCH 2/2] ASoC: codecs: Add da7218 codec driver

On November 8, 2015 10:34, Mark Brown wrote: > > > Hang on, is this just recording a DC value with the ADC and then looking > > > at that? > > > The RMS of the Mic signal is taken and compared to the trigger level set. If > > it's above that level then an IRQ is raised. > > What I'm trying to

RE: [PATCH 2/2] ASoC: codecs: Add da7218 codec driver

On November 8, 2015 10:34, Mark Brown wrote: > > > Hang on, is this just recording a DC value with the ADC and then looking > > > at that? > > > The RMS of the Mic signal is taken and compared to the trigger level set. If > > it's above that level then an IRQ is raised. > > What I'm trying to

RE: [PATCH 2/2] ASoC: codecs: Add da7218 codec driver

On November 6, 2015 11:55, Mark Brown wrote: > > > > I can envisage in a system you may want to choose which capture > > > > channels can > > > > trigger level detection (if any), and this may change depending on the > > > > use-case > > > > at the time, so having it as a control makes sense to

RE: [PATCH 2/2] ASoC: codecs: Add da7218 codec driver

On November 6, 2015 11:22, Mark Brown wrote: > > > > +static int da7218_mic_lvl_det_sw_put(struct snd_kcontrol *kcontrol, > > > > +struct snd_ctl_elem_value > > > > *ucontrol) > > > > +{ > > > > Why is this a user visible control? > > > I can envisage in a

RE: [PATCH 2/2] ASoC: codecs: Add da7218 codec driver

On November 5, 2015 15:28, Mark Brown wrote: > > +/* ALC */ > > +static void da7218_alc_calib(struct snd_soc_codec *codec) > > +{ > > + struct da7218_priv *da7218 = snd_soc_codec_get_drvdata(codec); > > + u8 calib_ctrl; > > + int i = 0; > > + bool calibrated = false; > > + > > + /*

RE: [PATCH 2/2] ASoC: codecs: Add da7218 codec driver

On November 5, 2015 15:28, Mark Brown wrote: > > +/* ALC */ > > +static void da7218_alc_calib(struct snd_soc_codec *codec) > > +{ > > + struct da7218_priv *da7218 = snd_soc_codec_get_drvdata(codec); > > + u8 calib_ctrl; > > + int i = 0; > > + bool calibrated = false; > > + > > + /*

RE: [PATCH 2/2] ASoC: codecs: Add da7218 codec driver

On November 6, 2015 11:22, Mark Brown wrote: > > > > +static int da7218_mic_lvl_det_sw_put(struct snd_kcontrol *kcontrol, > > > > +struct snd_ctl_elem_value > > > > *ucontrol) > > > > +{ > > > > Why is this a user visible control? > > > I can envisage in a

RE: [PATCH 2/2] ASoC: codecs: Add da7218 codec driver

On November 6, 2015 11:55, Mark Brown wrote: > > > > I can envisage in a system you may want to choose which capture > > > > channels can > > > > trigger level detection (if any), and this may change depending on the > > > > use-case > > > > at the time, so having it as a control makes sense to

RE: [PATCH 1/2] ASoC: da7218: Add bindings documentation for DA7218 audio codec

On November 05, 2015 14:59, Mark Brown wrote: > > +- dlg,ldo-lvl : Required internal LDO voltage (mV) level > > + [<1050>, <1100>, <1200>, <1400>] > > Why would this ever be anything other than the minimum voltage, and > might we not want to vary it at runtime? Normally you are correct and

RE: [PATCH 1/2] ASoC: da7218: Add bindings documentation for DA7218 audio codec

On November 05, 2015 14:59, Mark Brown wrote: > > +- dlg,ldo-lvl : Required internal LDO voltage (mV) level > > + [<1050>, <1100>, <1200>, <1400>] > > Why would this ever be anything other than the minimum voltage, and > might we not want to vary it at runtime? Normally you are correct and

RE: [PATCH v2 3/3] ASoC: da7213: Add bindings documentation for codec driver

On October 08, 2015 14:16, Rob Herring wrote: > >> > +- dlg,micbias1-lvl : Voltage (mV) for Mic Bias 1 > >> > + [<1600>, <2200>, <2500>, <3000>] > >> > +- dlg,micbias2-lvl : Voltage (mV) for Mic Bias 2 > >> > + [<1600>, <2200>, <2500>, <3000>] > >> > >> Please append the units

RE: [PATCH v2 3/3] ASoC: da7213: Add bindings documentation for codec driver

On October 07, 2015 17:22, Rob Herring wrote: > > +- dlg,micbias1-lvl : Voltage (mV) for Mic Bias 1 > > + [<1600>, <2200>, <2500>, <3000>] > > +- dlg,micbias2-lvl : Voltage (mV) for Mic Bias 2 > > + [<1600>, <2200>, <2500>, <3000>] > > Please append the units (-microvolt). Given

RE: [PATCH v2 3/3] ASoC: da7213: Add bindings documentation for codec driver

On October 07, 2015 17:22, Rob Herring wrote: > > +- dlg,micbias1-lvl : Voltage (mV) for Mic Bias 1 > > + [<1600>, <2200>, <2500>, <3000>] > > +- dlg,micbias2-lvl : Voltage (mV) for Mic Bias 2 > > + [<1600>, <2200>, <2500>, <3000>] > > Please append the units (-microvolt). Given

RE: [PATCH v2 3/3] ASoC: da7213: Add bindings documentation for codec driver

On October 08, 2015 14:16, Rob Herring wrote: > >> > +- dlg,micbias1-lvl : Voltage (mV) for Mic Bias 1 > >> > + [<1600>, <2200>, <2500>, <3000>] > >> > +- dlg,micbias2-lvl : Voltage (mV) for Mic Bias 2 > >> > + [<1600>, <2200>, <2500>, <3000>] > >> > >> Please append the units

RE: [PATCH v2 0/3] ASoC: da7213: Add DT support for codec

On October 07, 2015 15:11, Mark Brown wrote: > > Adam Thomson (3): > > ASoC: da7213: Add DT support to codec driver > > ASoC: da7213: Add support to handle mclk data provided to driver > > ASoC: da7213: Add bindings documentation for codec driver > > Please remember to send the DT binding

RE: [PATCH v2 0/3] ASoC: da7213: Add DT support for codec

On October 07, 2015 15:11, Mark Brown wrote: > > Adam Thomson (3): > > ASoC: da7213: Add DT support to codec driver > > ASoC: da7213: Add support to handle mclk data provided to driver > > ASoC: da7213: Add bindings documentation for codec driver > > Please remember to send the DT binding

RE: [PATCH 1/2] ASoC: da7213: Add DT support to codec driver

On October 05, 2015 16:56, Mark Brown wrote: > On Mon, Oct 05, 2015 at 04:40:18PM +0100, Adam Thomson wrote: > > > This patch adds support for DT bindings in the codec driver. > > As part of this support, the mclk data can now be provided and > > used to control the mclk during codec operation.

RE: [PATCH 1/2] ASoC: da7213: Add DT support to codec driver

On October 05, 2015 16:56, Mark Brown wrote: > On Mon, Oct 05, 2015 at 04:40:18PM +0100, Adam Thomson wrote: > > > This patch adds support for DT bindings in the codec driver. > > As part of this support, the mclk data can now be provided and > > used to control the mclk during codec operation.

RE: [PATCH v5 0/6] Add support for DA9150 Fuel-Gauge

On September 22, 2015 18:11, Lee Jones wrote: > On Tue, 22 Sep 2015, Sebastian Reichel wrote: > > On Fri, Sep 11, 2015 at 11:05:21AM +0100, Adam Thomson wrote: > > > This patch set adds support for the Dialog DA9150 Fuel-Gauge. > > > > > > [...] > > > > > > Adam Thomson (6): > > > mfd: da9150:

RE: [PATCH v5 0/6] Add support for DA9150 Fuel-Gauge

On September 22, 2015 18:11, Lee Jones wrote: > On Tue, 22 Sep 2015, Sebastian Reichel wrote: > > On Fri, Sep 11, 2015 at 11:05:21AM +0100, Adam Thomson wrote: > > > This patch set adds support for the Dialog DA9150 Fuel-Gauge. > > > > > > [...] > > > > > > Adam Thomson (6): > > > mfd: da9150:

RE: [PATCH 7/8] mfd: da9052: Simplify function return logic

On September 29, 2015 12:26, Javier Martinez Canillas wrote: > The invoked functions already return zero on success or a negative > errno code so there is no need to open code the logic in the caller. > > Signed-off-by: Javier Martinez Canillas > --- Acked-by: Adam Thomson

RE: [PATCH 6/8] mfd: da903x: Simplify function return logic

On September 29, 2015 12:26, Javier Martinez Canillas wrote: > The invoked function already returns zero on success or a negative > errno code so there is no need to open code the logic in the caller. > > Signed-off-by: Javier Martinez Canillas > --- Acked-by: Adam Thomson

RE: [PATCH 6/8] mfd: da903x: Simplify function return logic

On September 29, 2015 12:26, Javier Martinez Canillas wrote: > The invoked function already returns zero on success or a negative > errno code so there is no need to open code the logic in the caller. > > Signed-off-by: Javier Martinez Canillas > --- Acked-by: Adam

RE: [PATCH 7/8] mfd: da9052: Simplify function return logic

On September 29, 2015 12:26, Javier Martinez Canillas wrote: > The invoked functions already return zero on success or a negative > errno code so there is no need to open code the logic in the caller. > > Signed-off-by: Javier Martinez Canillas > --- Acked-by: Adam

RE: [PATCH 1/3] ASoC: codecs: Add da7219 codec driver

On September 21, 2015 18:11, Mark Brown wrote: > > In a system scenario the likelihood of that happening is small as you > > cannot use the mic or headphones until they've been inserted. The system is > > only likely to act after the jack insertion events have occurred. However, > > it > > This

RE: [PATCH 1/3] ASoC: codecs: Add da7219 codec driver

On September 21, 2015 18:11, Mark Brown wrote: > > In a system scenario the likelihood of that happening is small as you > > cannot use the mic or headphones until they've been inserted. The system is > > only likely to act after the jack insertion events have occurred. However, > > it > > This

RE: [PATCH 1/3] ASoC: codecs: Add da7219 codec driver

On September 19, 2015 18:44, Mark Brown wrote: > > + do { > > + statusa = snd_soc_read(codec, DA7219_ACCDET_STATUS_A); > > + if (statusa & DA7219_MICBIAS_UP_STS_MASK) > > + micbias_up = true; > > + } while (!micbias_up); > > This could go into an

RE: [PATCH 2/3] ASoC: da7219: Add bindings documentation for DA7219 audio codec

On September 19, 2015 18:10, Mark Brown wrote: > > +- dlg,io-lvl : Expected voltage level range for digital IO > > + ["2.5V_3.6V", "1.2V_2.8V"] > > If the driver needs to read or set the voltage a supply is at it should > do that via the regulator API. This would just be a read for the

RE: [PATCH 2/3] ASoC: da7219: Add bindings documentation for DA7219 audio codec

On September 19, 2015 18:10, Mark Brown wrote: > > +- dlg,io-lvl : Expected voltage level range for digital IO > > + ["2.5V_3.6V", "1.2V_2.8V"] > > If the driver needs to read or set the voltage a supply is at it should > do that via the regulator API. This would just be a read for the

RE: [PATCH 1/3] ASoC: codecs: Add da7219 codec driver

On September 19, 2015 18:44, Mark Brown wrote: > > + do { > > + statusa = snd_soc_read(codec, DA7219_ACCDET_STATUS_A); > > + if (statusa & DA7219_MICBIAS_UP_STS_MASK) > > + micbias_up = true; > > + } while (!micbias_up); > > This could go into an

RE: [PATCH 02/12] ASoC: da9055: Fix module autoload for OF platform driver

On September 03, 2015 11:56, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > Signed-off-by: Luis de Bethencourt > --- Acked-by: Adam Thomson

RE: [PATCH 02/12] ASoC: da9055: Fix module autoload for OF platform driver

On September 03, 2015 11:56, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > Signed-off-by: Luis de Bethencourt > --- Acked-by: Adam Thomson

RE: [PATCH v4 3/6] power: Add support for DA9150 Fuel-Gauge

On August 04, 2015 17:17, Adam Thomson wrote: > This adds power supply driver support for the Fuel-Gauge part of > the DA9150 combined Charger and Fuel-Gauge device. > > Signed-off-by: Adam Thomson > --- Hi Sebastian, Just wondered when you might be able to review the power-supply parts of

RE: [PATCH v4 3/6] power: Add support for DA9150 Fuel-Gauge

On August 04, 2015 17:17, Adam Thomson wrote: This adds power supply driver support for the Fuel-Gauge part of the DA9150 combined Charger and Fuel-Gauge device. Signed-off-by: Adam Thomson adam.thomson.opensou...@diasemi.com --- Hi Sebastian, Just wondered when you might be able to

RE: [PATCH V3] Watchdog: Fix parent of watchdog_devices

On August 19, 2015 04:28, Pratyush Anand wrote: > diff --git a/drivers/watchdog/da9052_wdt.c b/drivers/watchdog/da9052_wdt.c > index 2e9589652e1e..67e67977bd29 100644 > --- a/drivers/watchdog/da9052_wdt.c > +++ b/drivers/watchdog/da9052_wdt.c > @@ -195,6 +195,7 @@ static int

RE: [PATCH V3] Watchdog: Fix parent of watchdog_devices

On August 19, 2015 04:28, Pratyush Anand wrote: diff --git a/drivers/watchdog/da9052_wdt.c b/drivers/watchdog/da9052_wdt.c index 2e9589652e1e..67e67977bd29 100644 --- a/drivers/watchdog/da9052_wdt.c +++ b/drivers/watchdog/da9052_wdt.c @@ -195,6 +195,7 @@ static int da9052_wdt_probe(struct

RE: [PATCH v4 1/6] mfd: da9150: Add support for Fuel-Gauge

On August 10, 2015 14:54, Lee Jones wrote: > On Tue, 04 Aug 2015, Adam Thomson wrote: > > > Signed-off-by: Adam Thomson > > --- > > > > Changes in v4: > > - Update compatible string of fuel-gauge to "dlg, da9150-fuel-gauge". Also > >made similar change to driver name to keep things

RE: [PATCH v4 1/6] mfd: da9150: Add support for Fuel-Gauge

On August 10, 2015 14:54, Lee Jones wrote: On Tue, 04 Aug 2015, Adam Thomson wrote: Signed-off-by: Adam Thomson adam.thomson.opensou...@diasemi.com --- Changes in v4: - Update compatible string of fuel-gauge to dlg, da9150-fuel-gauge. Also made similar change to driver name to

RE: [PATCH v3 3/6] power: Add support for DA9150 Fuel-Gauge

On August 03, 2015 18:26, Sebastian Reichel wrote: > > > > +MODULE_LICENSE("GPL"); > > > > > > MODULE_LICENSE("GPL v2"); > > > > If I do this then I need to update the file license disclaimer at the top, > > as > > right now they match and are correct as far as I can tell. Is this change > >

RE: [PATCH v3 3/6] power: Add support for DA9150 Fuel-Gauge

On August 03, 2015 18:26, Sebastian Reichel wrote: +MODULE_LICENSE(GPL); MODULE_LICENSE(GPL v2); If I do this then I need to update the file license disclaimer at the top, as right now they match and are correct as far as I can tell. Is this change needed and if so is this

RE: [PATCH v3 4/6] power: da9150: Add DT bindings documentation for Fuel-Gauge

On July 24, 2015 23:01, Sebastian Reichel wrote: > Hi, > > On Tue, Jul 07, 2015 at 05:34:21PM +0100, Adam Thomson wrote: > > diff --git a/Documentation/devicetree/bindings/power/da9150-fg.txt > b/Documentation/devicetree/bindings/power/da9150-fg.txt > > new file mode 100644 > > index

RE: [PATCH v3 3/6] power: Add support for DA9150 Fuel-Gauge

On July 25, 2015 18:27, Sebastian Reichel wrote: > Hi Adam, > > The driver looks mostly fine. I have a few comments, though: > > On Tue, Jul 07, 2015 at 05:34:19PM +0100, Adam Thomson wrote: > > Signed-off-by: Adam Thomson > > Please add a short description to the commit message. > Ok, I

RE: [PATCH v3 4/6] power: da9150: Add DT bindings documentation for Fuel-Gauge

On July 24, 2015 23:01, Sebastian Reichel wrote: Hi, On Tue, Jul 07, 2015 at 05:34:21PM +0100, Adam Thomson wrote: diff --git a/Documentation/devicetree/bindings/power/da9150-fg.txt b/Documentation/devicetree/bindings/power/da9150-fg.txt new file mode 100644 index 000..c3c76eb

RE: [PATCH v3 3/6] power: Add support for DA9150 Fuel-Gauge

On July 25, 2015 18:27, Sebastian Reichel wrote: Hi Adam, The driver looks mostly fine. I have a few comments, though: On Tue, Jul 07, 2015 at 05:34:19PM +0100, Adam Thomson wrote: Signed-off-by: Adam Thomson adam.thomson.opensou...@diasemi.com Please add a short description to the

RE: [PATCH v2 3/4] power: Add support for DA9150 Fuel-Gauge

On July 3, 2015 16:22, Lee Jones wrote: > > +/* > > + * Function template to provide battery temperature. Should provide > > + * 0.1 degrees C resolution return values. > > + */ > > +typedef int (*da9150_read_temp_t)(void *context); > > + > > +/* Register temp callback function */ > > +void

RE: [PATCH v2 2/4] mfd: da9150: Update DT bindings for Fuel-Gauge support

On July 3, 2015 16:19, Lee Jones wrote: > > @@ -22,6 +23,7 @@ Required properties: > > Sub-devices: > > - da9150-gpadc: See Documentation/devicetree/bindings/iio/adc/da9150- > gpadc.txt > > - da9150-charger: See Documentation/devicetree/bindings/power/da9150- > charger.txt > > +- da9150-fg:

RE: [PATCH v2 1/4] mfd: da9150: Add support for Fuel-Gauge

On July 3, 2015 16:16, Lee Jones wrote: > > Changelog v1 => v2? Is described in the cover letter, but can move that information to the individual patches in the future, if that helps. > > > > +static struct resource da9150_fg_resources[] = { > > + { > > + .name = "FG", > > +

RE: [PATCH v2 1/4] mfd: da9150: Add support for Fuel-Gauge

On July 3, 2015 16:16, Lee Jones wrote: Changelog v1 = v2? Is described in the cover letter, but can move that information to the individual patches in the future, if that helps. +static struct resource da9150_fg_resources[] = { + { + .name = FG, + .start =

RE: [PATCH v2 3/4] power: Add support for DA9150 Fuel-Gauge

On July 3, 2015 16:22, Lee Jones wrote: +/* + * Function template to provide battery temperature. Should provide + * 0.1 degrees C resolution return values. + */ +typedef int (*da9150_read_temp_t)(void *context); + +/* Register temp callback function */ +void

RE: [PATCH v2 2/4] mfd: da9150: Update DT bindings for Fuel-Gauge support

On July 3, 2015 16:19, Lee Jones wrote: @@ -22,6 +23,7 @@ Required properties: Sub-devices: - da9150-gpadc: See Documentation/devicetree/bindings/iio/adc/da9150- gpadc.txt - da9150-charger: See Documentation/devicetree/bindings/power/da9150- charger.txt +- da9150-fg: See

RE: [PATCH 1/4] mfd: da9150: Add support for Fuel-Gauge

On June 22, 2015 17:48, Lee Jones wrote: > > > The pedant in me noticed that this function is actually added in 3/4. So > > > this chunk might be moved to 3/4, if you like to entertain pedantry like > > > that, that is. (But see my remark on 3/4 too.) > > > > This is true, but as the header is

RE: [PATCH 1/4] mfd: da9150: Add support for Fuel-Gauge

On June 22, 2015 17:48, Lee Jones wrote: The pedant in me noticed that this function is actually added in 3/4. So this chunk might be moved to 3/4, if you like to entertain pedantry like that, that is. (But see my remark on 3/4 too.) This is true, but as the header is part of MFD, I

RE: [PATCH 1/4] mfd: da9150: Add support for Fuel-Gauge

On June 19, 2015 17:48, Paul Bolle wrote: > On Thu, 2015-06-18 at 17:06 +0100, Adam Thomson wrote: > > --- /dev/null > > +++ b/include/linux/mfd/da9150/fg.h > > > +/* > > + * Function template to provide battery temperature. Should provide > > + * 0.1 degrees C resolution return values. > > + */

RE: [PATCH 3/4] power: Add support for DA9150 Fuel-Gauge

On June 19, 2015 17:52, Paul Bolle wrote: > On Thu, 2015-06-18 at 17:06 +0100, Adam Thomson wrote: > > --- /dev/null > > +++ b/drivers/power/da9150-fg.c > > > +/* Register external function to give battery temperature */ > > +void da9150_fg_register_temp_cb(struct power_supply *psy, >

  1   2   >