RE: [PATCH 1/2] dt: power: Add support for TI BQ24261 charger

2016-01-24 Thread Pallala, Ramakrishna
Hi Krzysztof, > 2015-10-30 1:37 GMT+09:00 Ramakrishna Pallala > : > > This patch adds the device tree documentation for TI BQ24261 charger. > > > > Signed-off-by: Ramakrishna Pallala > > Signed-off-by: Jenny TC > > --- > > .../devicetree/bindings/power/bq24261.txt | 34 >

RE: [PATCH 1/2] dt: power: Add support for TI BQ24261 charger

2016-01-24 Thread Pallala, Ramakrishna
Hi Krzysztof, > 2015-10-30 1:37 GMT+09:00 Ramakrishna Pallala > : > > This patch adds the device tree documentation for TI BQ24261 charger. > > > > Signed-off-by: Ramakrishna Pallala > > Signed-off-by: Jenny TC >

RE: [PATCH 0/2] power: Add support for TI BQ24261 charger

2015-12-06 Thread Pallala, Ramakrishna
Hi Sebastian, > On Thu, Oct 29, 2015 at 10:07:03PM +0530, Ramakrishna Pallala wrote: > > This patch series adds the support for TI BQ24261 charger driver. > > > > TI BQ24261 charger driver relies on extcon notifications to get the > > charger cable type and based on that it will set the charging

RE: [PATCH 0/2] power: Add support for TI BQ24261 charger

2015-12-06 Thread Pallala, Ramakrishna
Hi Sebastian, > On Thu, Oct 29, 2015 at 10:07:03PM +0530, Ramakrishna Pallala wrote: > > This patch series adds the support for TI BQ24261 charger driver. > > > > TI BQ24261 charger driver relies on extcon notifications to get the > > charger cable type and based on that it will set the charging

RE: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

2015-10-19 Thread Pallala, Ramakrishna
Hi Andreas, > Hi Ram, thanks for submitting this, please see some feedback inlined... > > On Sun, Sep 06, 2015 at 10:53:07PM +0530, Ramakrishna Pallala wrote: > > Add new charger driver support for BQ24261 charger IC. > > > > BQ24261 charger driver relies on extcon notifications to get the > >

RE: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

2015-10-19 Thread Pallala, Ramakrishna
Hi Andreas, > Hi Ram, thanks for submitting this, please see some feedback inlined... > > On Sun, Sep 06, 2015 at 10:53:07PM +0530, Ramakrishna Pallala wrote: > > Add new charger driver support for BQ24261 charger IC. > > > > BQ24261 charger driver relies on extcon notifications to get the > >

RE: [PATCH 1/2] extcon: Modify the id and name of external connector

2015-10-06 Thread Pallala, Ramakrishna
> >> diff --git a/include/linux/extcon.h b/include/linux/extcon.h index > >> c0f8c4fc5d45..c8dd881e2b8d 100644 > >> --- a/include/linux/extcon.h > >> +++ b/include/linux/extcon.h > >> @@ -31,32 +31,42 @@ > >> /* > >> * Define the unique id of supported external connectors > >> */ > >>

RE: [PATCH 1/2] extcon: Modify the id and name of external connector

2015-10-06 Thread Pallala, Ramakrishna
Hi Choi, > Subject: [PATCH 1/2] extcon: Modify the id and name of external connector > > This patch modifies the id and name of external connector with the additional > prefix to clarify both attribute and meaning of external connector as > following: > - EXTCON_CHG_* mean the charger

RE: [PATCH 1/2] extcon: Modify the id and name of external connector

2015-10-06 Thread Pallala, Ramakrishna
> >> diff --git a/include/linux/extcon.h b/include/linux/extcon.h index > >> c0f8c4fc5d45..c8dd881e2b8d 100644 > >> --- a/include/linux/extcon.h > >> +++ b/include/linux/extcon.h > >> @@ -31,32 +31,42 @@ > >> /* > >> * Define the unique id of supported external connectors > >> */ > >>

RE: [PATCH 1/2] extcon: Modify the id and name of external connector

2015-10-06 Thread Pallala, Ramakrishna
Hi Choi, > Subject: [PATCH 1/2] extcon: Modify the id and name of external connector > > This patch modifies the id and name of external connector with the additional > prefix to clarify both attribute and meaning of external connector as > following: > - EXTCON_CHG_* mean the charger

RE: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

2015-09-22 Thread Pallala, Ramakrishna
> Hi, > > On Fri, Sep 11, 2015 at 09:58:40AM +0900, Krzysztof Kozlowski wrote: > > On 11.09.2015 01:42, Andrew F. Davis wrote: > > > On 09/09/2015 06:47 PM, Krzysztof Kozlowski wrote: > > > +- ti,enable-user-write: boolean, if present driver will allow > > > +the > > > user space > >

RE: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

2015-09-22 Thread Pallala, Ramakrishna
> Hi, > > On Fri, Sep 11, 2015 at 09:58:40AM +0900, Krzysztof Kozlowski wrote: > > On 11.09.2015 01:42, Andrew F. Davis wrote: > > > On 09/09/2015 06:47 PM, Krzysztof Kozlowski wrote: > > > +- ti,enable-user-write: boolean, if present driver will allow > > > +the > > > user space > >

RE: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

2015-09-09 Thread Pallala, Ramakrishna
Hi, > From: k.kozlowsk...@gmail.com [mailto:k.kozlowsk...@gmail.com] On Behalf > Of Krzysztof Kozlowski > Sent: Monday, September 7, 2015 9:28 AM > To: Pallala, Ramakrishna > Cc: linux-kernel@vger.kernel.org; linux...@vger.kernel.org; > devicet...@vger.kernel.org; Sebastian

RE: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

2015-09-09 Thread Pallala, Ramakrishna
Hi, > From: k.kozlowsk...@gmail.com [mailto:k.kozlowsk...@gmail.com] On Behalf > Of Krzysztof Kozlowski > Sent: Monday, September 7, 2015 9:28 AM > To: Pallala, Ramakrishna > Cc: linux-kernel@vger.kernel.org; linux...@vger.kernel.org; > devicet...@vger.kernel.org; Sebastian

RE: [RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

2015-09-01 Thread Pallala, Ramakrishna
Hi Andreas, > On Wed, Aug 26, 2015 at 11:03:00AM +0000, Pallala, Ramakrishna wrote: > > Hi Andreas, > > > > I went on a unplanned leave and I came back to office recently. I will go > through your comments and get back to you. > > Hi Ram, > hope all is we

RE: [RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

2015-09-01 Thread Pallala, Ramakrishna
Hi Andreas, > On Wed, Aug 26, 2015 at 11:03:00AM +0000, Pallala, Ramakrishna wrote: > > Hi Andreas, > > > > I went on a unplanned leave and I came back to office recently. I will go > through your comments and get back to you. > > Hi Ram, > hope all is we

RE: [RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

2015-08-26 Thread Pallala, Ramakrishna
Hi Andreas, I went on a unplanned leave and I came back to office recently. I will go through your comments and get back to you. > Subject: Re: [RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 > charger > > Hi, > > On Tue, Aug 18, 2015 at 11:19:35PM +0530, Ramakrishna Pallala

RE: [RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

2015-08-26 Thread Pallala, Ramakrishna
Hi Andreas, I went on a unplanned leave and I came back to office recently. I will go through your comments and get back to you. Subject: Re: [RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 charger Hi, On Tue, Aug 18, 2015 at 11:19:35PM +0530, Ramakrishna Pallala wrote:

RE: [PATCH v2] power: max17042_battery: add HEALTH and TEMP_* properties support

2015-07-25 Thread Pallala, Ramakrishna
Hi Krzysztof Kozlowski, >On Tue, Jun 23, 2015 at 09:58:41AM +0900, Krzysztof Kozlowski wrote: >> 2015-06-08 10:22 GMT+09:00 Krzysztof Kozlowski : >> > 2015-05-24 12:41 GMT+09:00 Ramakrishna Pallala >> > : >> >> This patch adds the support for following battery properties to > >> max17042 fuel

RE: [PATCH v2] power: max17042_battery: add HEALTH and TEMP_* properties support

2015-07-25 Thread Pallala, Ramakrishna
Hi Krzysztof Kozlowski, On Tue, Jun 23, 2015 at 09:58:41AM +0900, Krzysztof Kozlowski wrote: 2015-06-08 10:22 GMT+09:00 Krzysztof Kozlowski k.kozlow...@samsung.com: 2015-05-24 12:41 GMT+09:00 Ramakrishna Pallala ramakrishna.pall...@intel.com: This patch adds the support for following

RE: [PATCH v1] power: max17042_battery: add HEALTH and TEMP_* properties support

2015-05-23 Thread Pallala, Ramakrishna
> Hi, > > On Tue, May 05, 2015 at 05:10:32AM +0530, Ramakrishna Pallala wrote: > > This patch adds the support for following battery properties to > > max17042 fuel gauge driver. > > > > POWER_SUPPLY_PROP_TEMP_ALERT_MIN > > POWER_SUPPLY_PROP_TEMP_ALERT_MAX > > POWER_SUPPLY_PROP_TEMP_MIN > >

RE: [PATCH v1] power: max17042_battery: add HEALTH and TEMP_* properties support

2015-05-23 Thread Pallala, Ramakrishna
Hi, On Tue, May 05, 2015 at 05:10:32AM +0530, Ramakrishna Pallala wrote: This patch adds the support for following battery properties to max17042 fuel gauge driver. POWER_SUPPLY_PROP_TEMP_ALERT_MIN POWER_SUPPLY_PROP_TEMP_ALERT_MAX POWER_SUPPLY_PROP_TEMP_MIN

RE: [PATCH v1] power: max17042_battery: add HEALTH and TEMP_* properties support

2015-05-21 Thread Pallala, Ramakrishna
Hi Sebastian, Any feedback on this patch? > This patch adds the support for following battery properties to max17042 fuel > gauge driver. > > POWER_SUPPLY_PROP_TEMP_ALERT_MIN > POWER_SUPPLY_PROP_TEMP_ALERT_MAX > POWER_SUPPLY_PROP_TEMP_MIN > POWER_SUPPLY_PROP_TEMP_MAX > POWER_SUPPLY_PROP_HEALTH

RE: [PATCH v1] power: axp288_charger: axp288 charger driver

2015-05-21 Thread Pallala, Ramakrishna
Hi Sebastian, Any feedback on this patch? > This patch adds new power supply charger driver support for X-Power AXP288 > PMIC integrated charger. > > This driver interfaces with the axp20x mfd driver as a cell and listens to > extcon > cable events for setting up charging. > > Signed-off-by:

RE: [PATCH v1] power: axp288_charger: axp288 charger driver

2015-05-21 Thread Pallala, Ramakrishna
Hi Sebastian, Any feedback on this patch? This patch adds new power supply charger driver support for X-Power AXP288 PMIC integrated charger. This driver interfaces with the axp20x mfd driver as a cell and listens to extcon cable events for setting up charging. Signed-off-by:

RE: [PATCH v1] power: max17042_battery: add HEALTH and TEMP_* properties support

2015-05-21 Thread Pallala, Ramakrishna
Hi Sebastian, Any feedback on this patch? This patch adds the support for following battery properties to max17042 fuel gauge driver. POWER_SUPPLY_PROP_TEMP_ALERT_MIN POWER_SUPPLY_PROP_TEMP_ALERT_MAX POWER_SUPPLY_PROP_TEMP_MIN POWER_SUPPLY_PROP_TEMP_MAX POWER_SUPPLY_PROP_HEALTH

RE: [PATCH 1/2] extcon: Use the unique id for external connector instead of string

2015-05-15 Thread Pallala, Ramakrishna
> This patch uses the unique id to identify the type of external connector > instead > of string name. The string name have the many potential issues. So, this patch > defines the 'extcon' enumeration which includes all supported external > connector > on EXTCON subsystem. If new external

RE: [PATCH 1/2] extcon: Use the unique id for external connector instead of string

2015-05-15 Thread Pallala, Ramakrishna
This patch uses the unique id to identify the type of external connector instead of string name. The string name have the many potential issues. So, this patch defines the 'extcon' enumeration which includes all supported external connector on EXTCON subsystem. If new external connector is

RE: [PATCH] power: max17042_battery: add HEALTH and TEMP_* properties support

2015-05-04 Thread Pallala, Ramakrishna
Hi, > W dniu 05.05.2015 o 07:18, Ramakrishna Pallala pisze: > > This patch adds the support for following battery properties to > > max17042 fuel gauge driver. > > The patchset itself looks good. Only minor nits and a question at the end. > > > > > POWER_SUPPLY_PROP_TEMP_ALERT_MIN > >

RE: [PATCH] power: max17042_battery: add HEALTH and TEMP_* properties support

2015-05-04 Thread Pallala, Ramakrishna
Hi, W dniu 05.05.2015 o 07:18, Ramakrishna Pallala pisze: This patch adds the support for following battery properties to max17042 fuel gauge driver. The patchset itself looks good. Only minor nits and a question at the end. POWER_SUPPLY_PROP_TEMP_ALERT_MIN

RE: [PATCH] axp288_fuel_gauge: Add original author details

2015-04-30 Thread Pallala, Ramakrishna
Thanks you. I will add linux-pm also in CC list going forward. > On Wed, Apr 29, 2015 at 06:09:29AM +0000, Pallala, Ramakrishna wrote: > > It's been almost 45 days since I submitted this patch and I did not > > receive any feedback from you. > > Can you take a look at this

RE: [PATCH v9] extcon-axp288: Add axp288 extcon driver support

2015-04-30 Thread Pallala, Ramakrishna
> Hi Ram, > > This patch has still one minor issue on below comment. > But I fix it and will apply it on extcon-next branch after discussing how to > apply > this patch with Lee Jones (MFD maintainer). Ok. Thanks. > Dear Lee, > Do you want to send pull request after I make the immutable branch

RE: [PATCH v8] extcon-axp288: Add axp288 extcon driver support

2015-04-30 Thread Pallala, Ramakrishna
Hi Choi, I think I missed some. I will fix them and submit the v9 patch. > Hi Ram, > > I added some comment. > If you fix minor issue according to comment, I'll apply it. > > On 04/30/2015 10:43 AM, Ramakrishna Pallala wrote: > > This patch adds the extcon support for AXP288 PMIC which has the

RE: [PATCH v9] extcon-axp288: Add axp288 extcon driver support

2015-04-30 Thread Pallala, Ramakrishna
Hi Ram, This patch has still one minor issue on below comment. But I fix it and will apply it on extcon-next branch after discussing how to apply this patch with Lee Jones (MFD maintainer). Ok. Thanks. Dear Lee, Do you want to send pull request after I make the immutable branch for this

RE: [PATCH v8] extcon-axp288: Add axp288 extcon driver support

2015-04-30 Thread Pallala, Ramakrishna
Hi Choi, I think I missed some. I will fix them and submit the v9 patch. Hi Ram, I added some comment. If you fix minor issue according to comment, I'll apply it. On 04/30/2015 10:43 AM, Ramakrishna Pallala wrote: This patch adds the extcon support for AXP288 PMIC which has the BC1.2

RE: [PATCH] axp288_fuel_gauge: Add original author details

2015-04-30 Thread Pallala, Ramakrishna
Thanks you. I will add linux-pm also in CC list going forward. On Wed, Apr 29, 2015 at 06:09:29AM +, Pallala, Ramakrishna wrote: It's been almost 45 days since I submitted this patch and I did not receive any feedback from you. Can you take a look at this patch now? Right, I forgot

RE: [PATCH v8] extcon-axp288: Add axp288 extcon driver support

2015-04-29 Thread Pallala, Ramakrishna
> > This patch adds the extcon support for AXP288 PMIC which has the BC1.2 > > charger detection capability. Additionally it also adds the USB mux > > switching support b/w SOC and PMIC based on GPIO control. > > > > Signed-off-by: Ramakrishna Pallala > > When you send next versions, the

RE: [PATCH v7] extcon-axp288: Add axp288 extcon driver support

2015-04-29 Thread Pallala, Ramakrishna
Hi Choi, Thank you for the comments. I will be fixing them and submit the v8 patch. > On Wed, Apr 29, 2015 at 11:22 AM, Ramakrishna Pallala > wrote: > > This patch adds the extcon support for AXP288 PMIC which has the BC1.2 > > charger detection capability. Additionally it also adds the USB mux

RE: [PATCH] axp288_fuel_gauge: Add original author details

2015-04-29 Thread Pallala, Ramakrishna
Hi Sebastian, It's been almost 45 days since I submitted this patch and I did not receive any feedback from you. Can you take a look at this patch now? > On Fri, Mar 13, 2015 at 09:49:09PM +0530, Ramakrishna Pallala wrote: > > Add the original author details of the axp288_fuel_gauge driver. >

RE: [PATCH] axp288_fuel_gauge: Add original author details

2015-04-29 Thread Pallala, Ramakrishna
Hi Sebastian, It's been almost 45 days since I submitted this patch and I did not receive any feedback from you. Can you take a look at this patch now? On Fri, Mar 13, 2015 at 09:49:09PM +0530, Ramakrishna Pallala wrote: Add the original author details of the axp288_fuel_gauge driver.

RE: [PATCH v7] extcon-axp288: Add axp288 extcon driver support

2015-04-29 Thread Pallala, Ramakrishna
Hi Choi, Thank you for the comments. I will be fixing them and submit the v8 patch. On Wed, Apr 29, 2015 at 11:22 AM, Ramakrishna Pallala ramakrishna.pall...@intel.com wrote: This patch adds the extcon support for AXP288 PMIC which has the BC1.2 charger detection capability. Additionally

RE: [PATCH v8] extcon-axp288: Add axp288 extcon driver support

2015-04-29 Thread Pallala, Ramakrishna
This patch adds the extcon support for AXP288 PMIC which has the BC1.2 charger detection capability. Additionally it also adds the USB mux switching support b/w SOC and PMIC based on GPIO control. Signed-off-by: Ramakrishna Pallala ramakrishna.pall...@intel.com When you send next

RE: [PATCH v6] extcon-axp288: Add axp288 extcon driver support

2015-04-28 Thread Pallala, Ramakrishna
Hi Lee Jones, I have agreed to move the AXP288_EXTCON_* macros to driver source file as Choi is going to submit another extcon class driver patch to fix the consumer driver access issue. I will submit the v7 patch now with this change. Thank you for your time. > > This patch adds the extcon

RE: [PATCH v5] extcon-axp288: Add axp288 extcon driver support

2015-04-28 Thread Pallala, Ramakrishna
> On Tue, Apr 28, 2015 at 9:17 PM, Pallala, Ramakrishna > wrote: > > Hi Choi, > > > >> On Tue, Apr 28, 2015 at 8:20 PM, Pallala, Ramakrishna > >> >> > > > diff --git a/include/linux/mfd/axp20x.h > >> >> > > > b/include/l

RE: [PATCH v5] extcon-axp288: Add axp288 extcon driver support

2015-04-28 Thread Pallala, Ramakrishna
Hi Choi, > On Tue, Apr 28, 2015 at 8:20 PM, Pallala, Ramakrishna > >> > > > diff --git a/include/linux/mfd/axp20x.h > >> > > > b/include/linux/mfd/axp20x.h index dfabd6d..81152e2 100644 > >> > > > --- a/include/linux/mfd/axp20x.h > &g

RE: [PATCH v5] extcon-axp288: Add axp288 extcon driver support

2015-04-28 Thread Pallala, Ramakrishna
> On Tue, 28 Apr 2015, Pallala, Ramakrishna wrote: > > > > > This patch adds the extcon support for AXP288 PMIC which has the > > > > BC1.2 charger detection capability. Additionally it also adds the > > > > USB mux switching support b/w SOC and PMIC bas

RE: [PATCH v5] extcon-axp288: Add axp288 extcon driver support

2015-04-28 Thread Pallala, Ramakrishna
> > This patch adds the extcon support for AXP288 PMIC which has the BC1.2 > > charger detection capability. Additionally it also adds the USB mux > > switching support b/w SOC and PMIC based on GPIO control. > > > > Signed-off-by: Ramakrishna Pallala > > --- > > drivers/extcon/Kconfig |

RE: [PATCH v4] extcon-axp288: Add axp288 extcon driver support

2015-04-28 Thread Pallala, Ramakrishna
> > Only a license nit. > > On Tue, 2015-04-28 at 04:02 +0530, Ramakrishna Pallala wrote: > > --- /dev/null > > +++ b/drivers/extcon/extcon-axp288.c > > > + * This program is free software; you can redistribute it and/or > > + modify > > + * it under the terms of the GNU General Public License

RE: [PATCH v5] extcon-axp288: Add axp288 extcon driver support

2015-04-28 Thread Pallala, Ramakrishna
On Tue, 28 Apr 2015, Pallala, Ramakrishna wrote: This patch adds the extcon support for AXP288 PMIC which has the BC1.2 charger detection capability. Additionally it also adds the USB mux switching support b/w SOC and PMIC based on GPIO control. Signed-off-by: Ramakrishna

RE: [PATCH v5] extcon-axp288: Add axp288 extcon driver support

2015-04-28 Thread Pallala, Ramakrishna
Hi Choi, On Tue, Apr 28, 2015 at 8:20 PM, Pallala, Ramakrishna diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h index dfabd6d..81152e2 100644 --- a/include/linux/mfd/axp20x.h +++ b/include/linux/mfd/axp20x.h @@ -275,4 +275,13 @@ struct axp20x_fg_pdata

RE: [PATCH v5] extcon-axp288: Add axp288 extcon driver support

2015-04-28 Thread Pallala, Ramakrishna
On Tue, Apr 28, 2015 at 9:17 PM, Pallala, Ramakrishna ramakrishna.pall...@intel.com wrote: Hi Choi, On Tue, Apr 28, 2015 at 8:20 PM, Pallala, Ramakrishna diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h index dfabd6d..81152e2 100644 --- a/include/linux

RE: [PATCH v4] extcon-axp288: Add axp288 extcon driver support

2015-04-28 Thread Pallala, Ramakrishna
Only a license nit. On Tue, 2015-04-28 at 04:02 +0530, Ramakrishna Pallala wrote: --- /dev/null +++ b/drivers/extcon/extcon-axp288.c + * This program is free software; you can redistribute it and/or + modify + * it under the terms of the GNU General Public License as published

RE: [PATCH v6] extcon-axp288: Add axp288 extcon driver support

2015-04-28 Thread Pallala, Ramakrishna
Hi Lee Jones, I have agreed to move the AXP288_EXTCON_* macros to driver source file as Choi is going to submit another extcon class driver patch to fix the consumer driver access issue. I will submit the v7 patch now with this change. Thank you for your time. This patch adds the extcon

RE: [PATCH v5] extcon-axp288: Add axp288 extcon driver support

2015-04-28 Thread Pallala, Ramakrishna
This patch adds the extcon support for AXP288 PMIC which has the BC1.2 charger detection capability. Additionally it also adds the USB mux switching support b/w SOC and PMIC based on GPIO control. Signed-off-by: Ramakrishna Pallala ramakrishna.pall...@intel.com ---

RE: [PATCH v3 2/2] extcon-axp288: Add axp288 extcon driver support

2015-04-27 Thread Pallala, Ramakrishna
Hi Choi, Please see my response below. > >> > >>> + ret = PTR_ERR(info->otg); > >>> + return ret; > >>> + } > >>> + > >>> + for (i = 0; i < EXTCON_IRQ_END; i++) { > >>> + pirq = platform_get_irq(pdev, i); > >>> + info->irq[i] =

RE: [PATCH v3 2/2] extcon-axp288: Add axp288 extcon driver support

2015-04-27 Thread Pallala, Ramakrishna
Hi Choi, Please find my response below. > On 04/09/2015 02:12 AM, Ramakrishna Pallala wrote: > > This patch adds the extcon support for AXP288 PMIC which has the BC1.2 > > charger detection capability. Additionally it also adds the USB mux > > switching support b/w SOC and PMIC based on GPIO

RE: [PATCH v3 2/2] extcon-axp288: Add axp288 extcon driver support

2015-04-27 Thread Pallala, Ramakrishna
Hi Choi, Please find my response below. On 04/09/2015 02:12 AM, Ramakrishna Pallala wrote: This patch adds the extcon support for AXP288 PMIC which has the BC1.2 charger detection capability. Additionally it also adds the USB mux switching support b/w SOC and PMIC based on GPIO control.

RE: [PATCH v3 2/2] extcon-axp288: Add axp288 extcon driver support

2015-04-27 Thread Pallala, Ramakrishna
Hi Choi, Please see my response below. + ret = PTR_ERR(info-otg); + return ret; + } + + for (i = 0; i EXTCON_IRQ_END; i++) { + pirq = platform_get_irq(pdev, i); + info-irq[i] = regmap_irq_get_virq(info-regmap_irqc, pirq); + if

RE: [PATCH] axp288_fuel_gauge: Add original author details

2015-04-09 Thread Pallala, Ramakrishna
Hi Sebastian, > -Original Message- > From: Todd E Brandt [mailto:todd.e.bra...@linux.intel.com] > Sent: Saturday, March 14, 2015 9:29 AM > To: Pallala, Ramakrishna > Cc: linux-kernel@vger.kernel.org; Sebastian Reichel; Brandt, Todd E; > Woodhouse, David >

RE: [PATCH] axp288_fuel_gauge: Add original author details

2015-04-09 Thread Pallala, Ramakrishna
Hi Sebastian, -Original Message- From: Todd E Brandt [mailto:todd.e.bra...@linux.intel.com] Sent: Saturday, March 14, 2015 9:29 AM To: Pallala, Ramakrishna Cc: linux-kernel@vger.kernel.org; Sebastian Reichel; Brandt, Todd E; Woodhouse, David Subject: Re: [PATCH] axp288_fuel_gauge

RE: [PATCH v3 1/2] mfd/axp20x: add support for extcon cell

2015-04-08 Thread Pallala, Ramakrishna
> When submitting patches, please observe the $SUBJECT line formatting of the > subsystem you're sending to. > > You can do so by: `git log --oneline -- drivers/` > > In the case of MFD it's: > > mfd: : > > Note the ':' separators and the capitalisation of the first letter of the >

RE: [PATCH v3 1/2] mfd/axp20x: add support for extcon cell

2015-04-08 Thread Pallala, Ramakrishna
When submitting patches, please observe the $SUBJECT line formatting of the subsystem you're sending to. You can do so by: `git log --oneline -- drivers/subsystem` In the case of MFD it's: mfd: device: Description Note the ':' separators and the capitalisation of the first letter of

RE: [PATCH v2 2/2] extcon-axp288: Add axp288 extcon driver support

2015-04-06 Thread Pallala, Ramakrishna
Hi Choi, > Hi Ramakrishna, > > When I apply this patch for build test on extcon-next branch, conflict happen. > you have to implement this patchset on latest extcon-next branch. Ok I will create the patches on git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git > Also, This patch

RE: [PATCH v2 2/2] extcon-axp288: Add axp288 extcon driver support

2015-04-06 Thread Pallala, Ramakrishna
Hi Choi, Hi Ramakrishna, When I apply this patch for build test on extcon-next branch, conflict happen. you have to implement this patchset on latest extcon-next branch. Ok I will create the patches on git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git Also, This patch must

RE: [PATCH v1 1/2] mfd/axp20x: add support for extcon cell

2015-04-02 Thread Pallala, Ramakrishna
> > > > diff --git a/include/linux/mfd/axp20x.h > > > > b/include/linux/mfd/axp20x.h index dfabd6d..4ed8071 100644 > > > > --- a/include/linux/mfd/axp20x.h > > > > +++ b/include/linux/mfd/axp20x.h > > > > @@ -275,4 +275,9 @@ struct axp20x_fg_pdata { > > > > int

RE: [PATCH v1 1/2] mfd/axp20x: add support for extcon cell

2015-04-02 Thread Pallala, Ramakrishna
Hi, > > diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h > > index dfabd6d..4ed8071 100644 > > --- a/include/linux/mfd/axp20x.h > > +++ b/include/linux/mfd/axp20x.h > > @@ -275,4 +275,9 @@ struct axp20x_fg_pdata { > > int thermistor_curve[MAX_THERM_CURVE_SIZE][2]; > > };

RE: [PATCH v1 1/2] mfd/axp20x: add support for extcon cell

2015-04-02 Thread Pallala, Ramakrishna
Hi, diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h index dfabd6d..4ed8071 100644 --- a/include/linux/mfd/axp20x.h +++ b/include/linux/mfd/axp20x.h @@ -275,4 +275,9 @@ struct axp20x_fg_pdata { int thermistor_curve[MAX_THERM_CURVE_SIZE][2]; }; +struct

RE: [PATCH v1 1/2] mfd/axp20x: add support for extcon cell

2015-04-02 Thread Pallala, Ramakrishna
diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h index dfabd6d..4ed8071 100644 --- a/include/linux/mfd/axp20x.h +++ b/include/linux/mfd/axp20x.h @@ -275,4 +275,9 @@ struct axp20x_fg_pdata { int thermistor_curve[MAX_THERM_CURVE_SIZE][2]; };

RE: [PATCH 1/2] mfd/axp20x: add support for extcon cell

2015-04-01 Thread Pallala, Ramakrishna
> On Thu, 02 Apr 2015, Ramakrishna Pallala wrote: > > > This patch adds the mfd cell info for axp288 extcon device. > > > > Signed-off-by: Ramakrishna Pallala > > --- > > drivers/mfd/axp20x.c | 28 > > include/linux/mfd/axp20x.h |5 + > > 2 files

RE: [PATCH 1/2] mfd/axp20x: add support for extcon cell

2015-04-01 Thread Pallala, Ramakrishna
On Thu, 02 Apr 2015, Ramakrishna Pallala wrote: This patch adds the mfd cell info for axp288 extcon device. Signed-off-by: Ramakrishna Pallala ramakrishna.pall...@intel.com --- drivers/mfd/axp20x.c | 28 include/linux/mfd/axp20x.h |5 +

RE: [PATCH v0 0/2] Add extcon support for AXP288 PMIC

2015-03-31 Thread Pallala, Ramakrishna
> > This patch series adds the support for axp288 extcon driver and also > > adds the cell info for extcon device in axp20x mfd driver. > > > > Ramakrishna Pallala (2): > > mfd/axp20x: add support for extcon cell > > extcon-axp288: Add axp288 extcon driver support > > > >

RE: [PATCH v0 0/2] Add extcon support for AXP288 PMIC

2015-03-31 Thread Pallala, Ramakrishna
This patch series adds the support for axp288 extcon driver and also adds the cell info for extcon device in axp20x mfd driver. Ramakrishna Pallala (2): mfd/axp20x: add support for extcon cell extcon-axp288: Add axp288 extcon driver support drivers/extcon/Kconfig |

RE: [PATCH 4/4] iio/adc/axp288: add support for axp288 gpadc

2014-09-09 Thread Pallala, Ramakrishna
Hi Jacob, > +#if defined(CONFIG_PM_SLEEP) || defined(CONFIG_PM_RUNTIME) static int > +axp288_gpadc_suspend(struct device *dev) { > + int ret; > + struct iio_dev *indio_dev = dev_get_drvdata(dev); > + struct gpadc_info *info = iio_priv(indio_dev); > + > + mutex_lock(_dev->mlock);

RE: [PATCH 4/4] iio/adc/axp288: add support for axp288 gpadc

2014-09-09 Thread Pallala, Ramakrishna
Hi Jacob, +#if defined(CONFIG_PM_SLEEP) || defined(CONFIG_PM_RUNTIME) static int +axp288_gpadc_suspend(struct device *dev) { + int ret; + struct iio_dev *indio_dev = dev_get_drvdata(dev); + struct gpadc_info *info = iio_priv(indio_dev); + + mutex_lock(indio_dev-mlock); +

RE: how to include already compiled object files to kernel

2014-04-28 Thread Pallala, Ramakrishna
guess the late Friday push was too hard). I promise to be more careful next time. Thanks & Regards, Ram -Original Message- From: Hohndel, Dirk Sent: Saturday, April 26, 2014 3:31 AM To: linux-kernel@vger.kernel.org Cc: Pallala, Ramakrishna Subject: Re: how to include already comp

RE: how to include already compiled object files to kernel

2014-04-28 Thread Pallala, Ramakrishna
guess the late Friday push was too hard). I promise to be more careful next time. Thanks Regards, Ram -Original Message- From: Hohndel, Dirk Sent: Saturday, April 26, 2014 3:31 AM To: linux-kernel@vger.kernel.org Cc: Pallala, Ramakrishna Subject: Re: how to include already compiled

how to include already compiled object files to kernel

2014-04-25 Thread Pallala, Ramakrishna
HI All, I have received few kernel library .o (object files) from third party and I am planning to include in our kernel tree. As the library contains some proprietary algorithms the sources are not shared. How can I include this library .o files to my kernel and if this kernel is release to

how to include already compiled object files to kernel

2014-04-25 Thread Pallala, Ramakrishna
HI All, I have received few kernel library .o (object files) from third party and I am planning to include in our kernel tree. As the library contains some proprietary algorithms the sources are not shared. How can I include this library .o files to my kernel and if this kernel is release to

RE: [Linaro-acpi] How to pass I2C platform_data under ACPI

2014-04-03 Thread Pallala, Ramakrishna
>> > > And initialize the platform data in either driver or in separate >> > > module which gets compiled along with driver? >> > >> > Typically it has been done in the same driver but I don't see any >> > problems having a separate module as well. >> > >> > > static const struct

RE: How to pass I2C platform_data under ACPI

2014-04-03 Thread Pallala, Ramakrishna
>> In non ACPI environment I used to initialize the platform_data under >> board or platforms files. Under ACPI how do I do that? > >If you can't extract that information from ACPI namespace, then one option is >to pass platform data along with the device ACPI ID: > >static const struct

How to pass I2C platform_data under ACPI

2014-04-03 Thread Pallala, Ramakrishna
Hi All, I am trying to enable a i2c client driver under ACPI. The device is being enumerated behind adapter device and I am getting IRQ resource as well. The problem I have now is, how do I pass the platform data to driver? struct i2c_board_info { chartype[I2C_NAME_SIZE];

RE: [Linaro-acpi] How to pass I2C platform_data under ACPI

2014-04-03 Thread Pallala, Ramakrishna
And initialize the platform data in either driver or in separate module which gets compiled along with driver? Typically it has been done in the same driver but I don't see any problems having a separate module as well. static const struct acpi_device_id my_acpi_match[] = {

How to pass I2C platform_data under ACPI

2014-04-03 Thread Pallala, Ramakrishna
Hi All, I am trying to enable a i2c client driver under ACPI. The device is being enumerated behind adapter device and I am getting IRQ resource as well. The problem I have now is, how do I pass the platform data to driver? struct i2c_board_info { chartype[I2C_NAME_SIZE];

RE: How to pass I2C platform_data under ACPI

2014-04-03 Thread Pallala, Ramakrishna
In non ACPI environment I used to initialize the platform_data under board or platforms files. Under ACPI how do I do that? If you can't extract that information from ACPI namespace, then one option is to pass platform data along with the device ACPI ID: static const struct acpi_device_id

RE: How to populate Battery information through ACPI tables

2013-02-19 Thread Pallala, Ramakrishna
> > Mika, _BIF method returns battery data/struct which is defined Table. > > 10-233. > > Yes, it was just an example. You can have your own custom method for that, > lets > say: > > BLAH() > > that then returns whatever you need. > > > If I want to pass some device specific data

RE: How to populate Battery information through ACPI tables

2013-02-19 Thread Pallala, Ramakrishna
> > Mika, I want to populate this characterization data as device > > specific/custom data which could be anything And may not be entirely > > related to battery. Is this is possible? > > Yes, for example you could have a custom ACPI method with your device which > then returns this information.

RE: How to populate Battery information through ACPI tables

2013-02-19 Thread Pallala, Ramakrishna
> > > > > > I am trying to populate battery related information through > > > > > > ACPI tables and do battery management through non acpi > > > > > > drivers. Can you tell or point me on how to populate the ACPI > > > > > > tables in FW/BIOS and get them in OS? I am new to ACPI world. > > > > >

RE: How to populate Battery information through ACPI tables

2013-02-19 Thread Pallala, Ramakrishna
> > > On Tue, Feb 19, 2013 at 03:07:57PM +, Pallala, Ramakrishna wrote: > > > > I am trying to populate battery related information through ACPI > > > > tables and do battery management through non acpi drivers. Can > > > > you tell or point me

RE: How to populate Battery information through ACPI tables

2013-02-19 Thread Pallala, Ramakrishna
> On Tue, Feb 19, 2013 at 03:07:57PM +0000, Pallala, Ramakrishna wrote: > > I am trying to populate battery related information through ACPI > > tables and do battery management through non acpi drivers. Can you > > tell or point me on how to populate the ACPI tables in FW/

RE: How to populate Battery information through ACPI tables

2013-02-19 Thread Pallala, Ramakrishna
On Tue, Feb 19, 2013 at 03:07:57PM +, Pallala, Ramakrishna wrote: I am trying to populate battery related information through ACPI tables and do battery management through non acpi drivers. Can you tell or point me on how to populate the ACPI tables in FW/BIOS and get them in OS? I

RE: How to populate Battery information through ACPI tables

2013-02-19 Thread Pallala, Ramakrishna
On Tue, Feb 19, 2013 at 03:07:57PM +, Pallala, Ramakrishna wrote: I am trying to populate battery related information through ACPI tables and do battery management through non acpi drivers. Can you tell or point me on how to populate the ACPI tables in FW/BIOS and get them

RE: How to populate Battery information through ACPI tables

2013-02-19 Thread Pallala, Ramakrishna
I am trying to populate battery related information through ACPI tables and do battery management through non acpi drivers. Can you tell or point me on how to populate the ACPI tables in FW/BIOS and get them in OS? I am new to ACPI world. You should start by

RE: How to populate Battery information through ACPI tables

2013-02-19 Thread Pallala, Ramakrishna
Mika, I want to populate this characterization data as device specific/custom data which could be anything And may not be entirely related to battery. Is this is possible? Yes, for example you could have a custom ACPI method with your device which then returns this information. See

RE: How to populate Battery information through ACPI tables

2013-02-19 Thread Pallala, Ramakrishna
Mika, _BIF method returns battery data/struct which is defined Table. 10-233. Yes, it was just an example. You can have your own custom method for that, lets say: BLAH() that then returns whatever you need. If I want to pass some device specific data seems like I can

RE: [PATCH 1/2] power_supply: Add charge control struct in power supply class

2013-01-06 Thread Pallala, Ramakrishna
> > > > > +struct power_supply_charger_control { > > > > > + const char *name; > > > > > + /* get charging status */ > > > > > + int (*is_charging_enabled)(void); > > > > > + int (*is_charger_enabled)(void); > > > > > + > > > > > + /* set charging parameters */ > > > > > +

RE: [PATCH 1/2] power_supply: Add charge control struct in power supply class

2013-01-06 Thread Pallala, Ramakrishna
> > > > +struct power_supply_charger_control { > > > > + const char *name; > > > > + /* get charging status */ > > > > + int (*is_charging_enabled)(void); > > > > + int (*is_charger_enabled)(void); > > > > + > > > > + /* set charging parameters */ > > > > + int

RE: [PATCH 1/2] power_supply: Add charge control struct in power supply class

2013-01-06 Thread Pallala, Ramakrishna
> > +struct power_supply_charger_control { > > + const char *name; > > + /* get charging status */ > > + int (*is_charging_enabled)(void); > > + int (*is_charger_enabled)(void); > > + > > + /* set charging parameters */ > > + int (*set_in_current_limit)(int uA); > > + int

RE: [PATCH 1/2] power_supply: Add charge control struct in power supply class

2013-01-06 Thread Pallala, Ramakrishna
+struct power_supply_charger_control { + const char *name; + /* get charging status */ + int (*is_charging_enabled)(void); + int (*is_charger_enabled)(void); + + /* set charging parameters */ + int (*set_in_current_limit)(int uA); + int (*set_charge_current)(int

RE: [PATCH 1/2] power_supply: Add charge control struct in power supply class

2013-01-06 Thread Pallala, Ramakrishna
+struct power_supply_charger_control { + const char *name; + /* get charging status */ + int (*is_charging_enabled)(void); + int (*is_charger_enabled)(void); + + /* set charging parameters */ + int (*set_in_current_limit)(int uA);

RE: [PATCH 1/2] power_supply: Add charge control struct in power supply class

2013-01-06 Thread Pallala, Ramakrishna
+struct power_supply_charger_control { + const char *name; + /* get charging status */ + int (*is_charging_enabled)(void); + int (*is_charger_enabled)(void); + + /* set charging parameters */ + int (*set_in_current_limit)(int uA);

  1   2   >