Re: [PATCH v2 2/5] of: Support hashtable lookups for phandles

2016-05-16 Thread Pantelis Antoniou
Hi Rob, > On May 16, 2016, at 22:37 , Rob Herring <robherri...@gmail.com> wrote: > > On Mon, May 16, 2016 at 11:52 AM, Pantelis Antoniou > <pantelis.anton...@konsulko.com> wrote: >> When a device tree contains a lot of phandles, resolving one >> takes t

Re: [PATCH v2 2/5] of: Support hashtable lookups for phandles

2016-05-16 Thread Pantelis Antoniou
Hi Rob, > On May 16, 2016, at 22:37 , Rob Herring wrote: > > On Mon, May 16, 2016 at 11:52 AM, Pantelis Antoniou > wrote: >> When a device tree contains a lot of phandles, resolving one >> takes time because the original method uses a search against >>

Re: [PATCH v2 4/5] of: overlay: Pick up label symbols from overlays.

2016-05-16 Thread Pantelis Antoniou
Hi Geert, > On May 16, 2016, at 22:06 , Geert Uytterhoeven <ge...@linux-m68k.org> wrote: > > On Mon, May 16, 2016 at 6:52 PM, Pantelis Antoniou > <pantelis.anton...@konsulko.com> wrote: >> Insert overlay symbols to the base tree when applied. >> This m

Re: [PATCH v2 4/5] of: overlay: Pick up label symbols from overlays.

2016-05-16 Thread Pantelis Antoniou
Hi Geert, > On May 16, 2016, at 22:06 , Geert Uytterhoeven wrote: > > On Mon, May 16, 2016 at 6:52 PM, Pantelis Antoniou > wrote: >> Insert overlay symbols to the base tree when applied. >> This makes it possible to apply an overlay that references a label >> that

[PATCH v2 2/5] of: Support hashtable lookups for phandles

2016-05-16 Thread Pantelis Antoniou
When a device tree contains a lot of phandles, resolving one takes time because the original method uses a search against all nodes (not just the ones with phandles). Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> --- drivers/of/base.c

[PATCH v2 5/5] of: overlay: Add pr_fmt for clarity

2016-05-16 Thread Pantelis Antoniou
There are a bunch of pr_.*() messages in the file, use a common pr_fmt for making them a little bit shorter. Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> --- drivers/of/overlay.c | 84 1 file changed, 38 insertions(

[PATCH v2 4/5] of: overlay: Pick up label symbols from overlays.

2016-05-16 Thread Pantelis Antoniou
Insert overlay symbols to the base tree when applied. This makes it possible to apply an overlay that references a label that a previously inserted overlay had. Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> --- drivers/of/overlay.

[PATCH v2 2/5] of: Support hashtable lookups for phandles

2016-05-16 Thread Pantelis Antoniou
When a device tree contains a lot of phandles, resolving one takes time because the original method uses a search against all nodes (not just the ones with phandles). Signed-off-by: Pantelis Antoniou --- drivers/of/base.c | 41 ++--- drivers

[PATCH v2 5/5] of: overlay: Add pr_fmt for clarity

2016-05-16 Thread Pantelis Antoniou
There are a bunch of pr_.*() messages in the file, use a common pr_fmt for making them a little bit shorter. Signed-off-by: Pantelis Antoniou --- drivers/of/overlay.c | 84 1 file changed, 38 insertions(+), 46 deletions(-) diff --git

[PATCH v2 4/5] of: overlay: Pick up label symbols from overlays.

2016-05-16 Thread Pantelis Antoniou
Insert overlay symbols to the base tree when applied. This makes it possible to apply an overlay that references a label that a previously inserted overlay had. Signed-off-by: Pantelis Antoniou --- drivers/of/overlay.c | 93 1 file changed

[PATCH v2 0/5] of: generic infrastructure fixes

2016-05-16 Thread Pantelis Antoniou
Pantelis Antoniou (5): of: rename *_node_sysfs to _node_post of: Support hashtable lookups for phandles of: unittest: hashed phandles unitest of: overlay: Pick up label symbols from overlays. of: overlay: Add pr_fmt for clarity drivers/of/base.c | 45 +++-- drivers

[PATCH v2 0/5] of: generic infrastructure fixes

2016-05-16 Thread Pantelis Antoniou
Pantelis Antoniou (5): of: rename *_node_sysfs to _node_post of: Support hashtable lookups for phandles of: unittest: hashed phandles unitest of: overlay: Pick up label symbols from overlays. of: overlay: Add pr_fmt for clarity drivers/of/base.c | 45 +++-- drivers

[PATCH v2 3/5] of: unittest: hashed phandles unitest

2016-05-16 Thread Pantelis Antoniou
-hashed lookup takes about 23us when the cash is hot, while the hash lookup takes about 3us. For those 1877 lookup we get a speedup in the boot sequence of 1877 * (23 - 3) = 37.5ms, which is not spectacular but there's no point in wasting cycles and energy. Signed-off-by: Pantelis Antoniou

[PATCH v2 1/5] of: rename *_node_sysfs to _node_post

2016-05-16 Thread Pantelis Antoniou
Renames the *_node_sysfs methods to _node_post which is more accurate when more work takes place besides sysfs tweaking (as in with phandle hash management). Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> --- drivers/of/base.c | 4 ++-- drivers/of/dynamic.c

[PATCH v2 3/5] of: unittest: hashed phandles unitest

2016-05-16 Thread Pantelis Antoniou
-hashed lookup takes about 23us when the cash is hot, while the hash lookup takes about 3us. For those 1877 lookup we get a speedup in the boot sequence of 1877 * (23 - 3) = 37.5ms, which is not spectacular but there's no point in wasting cycles and energy. Signed-off-by: Pantelis Antoniou

[PATCH v2 1/5] of: rename *_node_sysfs to _node_post

2016-05-16 Thread Pantelis Antoniou
Renames the *_node_sysfs methods to _node_post which is more accurate when more work takes place besides sysfs tweaking (as in with phandle hash management). Signed-off-by: Pantelis Antoniou --- drivers/of/base.c | 4 ++-- drivers/of/dynamic.c| 10 +- drivers/of/of_private.h

[PATCH v2 5/5] i2c: demux: Use changeset helpers for clarity

2016-05-16 Thread Pantelis Antoniou
The changeset helpers are easier to use, use them instead of using the static property. Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> --- drivers/i2c/muxes/i2c-demux-pinctrl.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/muxes/i2c

[PATCH v2 5/5] i2c: demux: Use changeset helpers for clarity

2016-05-16 Thread Pantelis Antoniou
The changeset helpers are easier to use, use them instead of using the static property. Signed-off-by: Pantelis Antoniou --- drivers/i2c/muxes/i2c-demux-pinctrl.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/muxes/i2c-demux-pinctrl.c b/drivers/i2c/muxes

[PATCH v2 0/5] of: dynamic: Changesets helpers & fixes

2016-05-16 Thread Pantelis Antoniou
that made sense into static inlines. * Split out of_changeset_node_move method into a seperate patch * Add in-kernel conversion i2c-demux patch Pantelis Antoniou (5): of: dynamic: Add __of_node_dupv() of: changesets: Introduce changeset helper methods of: changeset: Add of_changeset_node_move method

[PATCH v2 0/5] of: dynamic: Changesets helpers & fixes

2016-05-16 Thread Pantelis Antoniou
that made sense into static inlines. * Split out of_changeset_node_move method into a seperate patch * Add in-kernel conversion i2c-demux patch Pantelis Antoniou (5): of: dynamic: Add __of_node_dupv() of: changesets: Introduce changeset helper methods of: changeset: Add of_changeset_node_move method

[PATCH v2 3/5] of: changeset: Add of_changeset_node_move method

2016-05-16 Thread Pantelis Antoniou
Adds a changeset helper for moving a subtree to a different place in the running tree. This is useful in advances cases of dynamic device tree construction. Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> --- drivers/of/dynamic.

[PATCH v2 3/5] of: changeset: Add of_changeset_node_move method

2016-05-16 Thread Pantelis Antoniou
Adds a changeset helper for moving a subtree to a different place in the running tree. This is useful in advances cases of dynamic device tree construction. Signed-off-by: Pantelis Antoniou --- drivers/of/dynamic.c | 66 include/linux/of.h

[PATCH v2 4/5] of: unittest: changeset helpers

2016-05-16 Thread Pantelis Antoniou
Add a unitest specific for the new changeset helpers. Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> --- drivers/of/unittest.c | 54 +++ 1 file changed, 54 insertions(+) diff --git a/drivers/of/unittest.c b/drivers/of/unit

[PATCH v2 1/5] of: dynamic: Add __of_node_dupv()

2016-05-16 Thread Pantelis Antoniou
Add an __of_node_dupv() private method and make __of_node_dup() use it. This is required for the subsequent changeset accessors which will make use of it. Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> --- drivers/of/dynamic.c | 29 +++-- 1 file c

[PATCH v2 2/5] of: changesets: Introduce changeset helper methods

2016-05-16 Thread Pantelis Antoniou
atible", "foo,bar"); Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> --- drivers/of/dynamic.c | 226 +++ include/linux/of.h | 328 +++ 2 files chang

[PATCH v2 4/5] of: unittest: changeset helpers

2016-05-16 Thread Pantelis Antoniou
Add a unitest specific for the new changeset helpers. Signed-off-by: Pantelis Antoniou --- drivers/of/unittest.c | 54 +++ 1 file changed, 54 insertions(+) diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index e986e6e..ff6939b 100644

[PATCH v2 1/5] of: dynamic: Add __of_node_dupv()

2016-05-16 Thread Pantelis Antoniou
Add an __of_node_dupv() private method and make __of_node_dup() use it. This is required for the subsequent changeset accessors which will make use of it. Signed-off-by: Pantelis Antoniou --- drivers/of/dynamic.c | 29 +++-- 1 file changed, 23 insertions(+), 6 deletions

[PATCH v2 2/5] of: changesets: Introduce changeset helper methods

2016-05-16 Thread Pantelis Antoniou
atible", "foo,bar"); Signed-off-by: Pantelis Antoniou --- drivers/of/dynamic.c | 226 +++ include/linux/of.h | 328 +++ 2 files changed, 554 insertions(+) diff --git a/drive

Re: [PATCH 3/3] of: overlay: Pick up label symbols from overlays.

2016-05-10 Thread Pantelis Antoniou
Hi Rob, > On May 10, 2016, at 00:47 , Rob Herring <robherri...@gmail.com> wrote: > > On Mon, May 9, 2016 at 1:11 PM, Pantelis Antoniou > <pantelis.anton...@konsulko.com> wrote: >> Insert overlay symbols to the base tree when applied. >> This makes it possible

Re: [PATCH 3/3] of: overlay: Pick up label symbols from overlays.

2016-05-10 Thread Pantelis Antoniou
Hi Rob, > On May 10, 2016, at 00:47 , Rob Herring wrote: > > On Mon, May 9, 2016 at 1:11 PM, Pantelis Antoniou > wrote: >> Insert overlay symbols to the base tree when applied. >> This makes it possible to apply an overlay that references a label >> that a p

Re: [PATCH 3/6] doc: dt: Document the indirect overlay method.

2016-05-10 Thread Pantelis Antoniou
Hi Rob, > On May 10, 2016, at 00:59 , Rob Herring <robherri...@gmail.com> wrote: > > On Mon, May 9, 2016 at 1:05 PM, Pantelis Antoniou > <pantelis.anton...@konsulko.com> wrote: >> Add a description of the indirect overlay method to the overlay >> documenti

Re: [PATCH 3/6] doc: dt: Document the indirect overlay method.

2016-05-10 Thread Pantelis Antoniou
Hi Rob, > On May 10, 2016, at 00:59 , Rob Herring wrote: > > On Mon, May 9, 2016 at 1:05 PM, Pantelis Antoniou > wrote: >> Add a description of the indirect overlay method to the overlay >> documention file. > > Why? Please write some decent commit messages.

Re: [PATCH 2/3] of: Support hashtable lookups for phandles

2016-05-10 Thread Pantelis Antoniou
Hi Rob, > On May 10, 2016, at 00:21 , Rob Herring <robherri...@gmail.com> wrote: > > On Mon, May 9, 2016 at 1:11 PM, Pantelis Antoniou > <pantelis.anton...@konsulko.com> wrote: > > Why this is needed goes here. > > Any data on how much time the current c

Re: [PATCH 2/3] of: Support hashtable lookups for phandles

2016-05-10 Thread Pantelis Antoniou
Hi Rob, > On May 10, 2016, at 00:21 , Rob Herring wrote: > > On Mon, May 9, 2016 at 1:11 PM, Pantelis Antoniou > wrote: > > Why this is needed goes here. > > Any data on how much time the current code takes? > I’ll get some numbers. The current algorithm is exh

Re: [PATCH 1/3] of: rename *_node_sysfs to _node_post

2016-05-10 Thread Pantelis Antoniou
Hi Rob, > On May 10, 2016, at 00:49 , Rob Herring <robherri...@gmail.com> wrote: > > On Mon, May 9, 2016 at 1:11 PM, Pantelis Antoniou > <pantelis.anton...@konsulko.com> wrote: > > The "why" goes here. > OK. >> Signed-off-by:

Re: [PATCH 1/3] of: rename *_node_sysfs to _node_post

2016-05-10 Thread Pantelis Antoniou
Hi Rob, > On May 10, 2016, at 00:49 , Rob Herring wrote: > > On Mon, May 9, 2016 at 1:11 PM, Pantelis Antoniou > wrote: > > The "why" goes here. > OK. >> Signed-off-by: Pantelis Antoniou >> --- >> drivers/of/base.c | 4 ++-- >

Re: [PATCH 2/3] of: Support hashtable lookups for phandles

2016-05-10 Thread Pantelis Antoniou
Hi Rob, > On May 10, 2016, at 00:11 , Rob Herring <robherri...@gmail.com> wrote: > > On Mon, May 9, 2016 at 3:38 PM, Geert Uytterhoeven <ge...@linux-m68k.org> > wrote: >> Hi Pantelis, >> >> On Mon, May 9, 2016 at 8:11 PM, Pantelis Antoniou

Re: [PATCH 2/3] of: Support hashtable lookups for phandles

2016-05-10 Thread Pantelis Antoniou
Hi Rob, > On May 10, 2016, at 00:11 , Rob Herring wrote: > > On Mon, May 9, 2016 at 3:38 PM, Geert Uytterhoeven > wrote: >> Hi Pantelis, >> >> On Mon, May 9, 2016 at 8:11 PM, Pantelis Antoniou >> wrote: >>> --- a/drivers/of/base.c >>&g

[PATCH 2/3] of: Support hashtable lookups for phandles

2016-05-09 Thread Pantelis Antoniou
Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> --- drivers/of/base.c | 35 --- drivers/of/dynamic.c| 8 drivers/of/of_private.h | 31 +++ include/linux/of.h | 2 ++ 4 files chang

[PATCH 2/3] of: Support hashtable lookups for phandles

2016-05-09 Thread Pantelis Antoniou
Signed-off-by: Pantelis Antoniou --- drivers/of/base.c | 35 --- drivers/of/dynamic.c| 8 drivers/of/of_private.h | 31 +++ include/linux/of.h | 2 ++ 4 files changed, 73 insertions(+), 3 deletions(-) diff

[PATCH 1/3] of: rename *_node_sysfs to _node_post

2016-05-09 Thread Pantelis Antoniou
Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> --- drivers/of/base.c | 4 ++-- drivers/of/dynamic.c| 10 +- drivers/of/of_private.h | 4 ++-- drivers/of/unittest.c | 4 ++-- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/d

[PATCH 0/3] of: generic infrastructure fixes

2016-05-09 Thread Pantelis Antoniou
search which is not optimal at all. Finally, a long standing request of applied overlays populating the symbol list is implemented; this allows staggered overlay application with a symbol from a previous overlay being used by another after it. Pantelis Antoniou (3): of: rename *_node_sysfs

[PATCH 1/3] of: rename *_node_sysfs to _node_post

2016-05-09 Thread Pantelis Antoniou
Signed-off-by: Pantelis Antoniou --- drivers/of/base.c | 4 ++-- drivers/of/dynamic.c| 10 +- drivers/of/of_private.h | 4 ++-- drivers/of/unittest.c | 4 ++-- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index

[PATCH 0/3] of: generic infrastructure fixes

2016-05-09 Thread Pantelis Antoniou
search which is not optimal at all. Finally, a long standing request of applied overlays populating the symbol list is implemented; this allows staggered overlay application with a symbol from a previous overlay being used by another after it. Pantelis Antoniou (3): of: rename *_node_sysfs

[PATCH 3/3] of: overlay: Pick up label symbols from overlays.

2016-05-09 Thread Pantelis Antoniou
Insert overlay symbols to the base tree when applied. This makes it possible to apply an overlay that references a label that a previously inserted overlay had. Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> Tested-by: Geert Uytterhoeven <geert+rene...@glider.be>

[PATCH 3/3] of: overlay: Pick up label symbols from overlays.

2016-05-09 Thread Pantelis Antoniou
Insert overlay symbols to the base tree when applied. This makes it possible to apply an overlay that references a label that a previously inserted overlay had. Signed-off-by: Pantelis Antoniou Tested-by: Geert Uytterhoeven --- drivers/of/overlay.c | 102

[PATCH 5/6] of: unittest: Unit-tests for target root overlays.

2016-05-09 Thread Pantelis Antoniou
Add unittests for target-root based overlays. Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> --- drivers/of/unittest-data/testcases.dts | 5 + drivers/of/unittest-data/tests-overlay.dtsi | 48 +++ drivers/of/unittest.c

[PATCH 3/6] doc: dt: Document the indirect overlay method.

2016-05-09 Thread Pantelis Antoniou
Add a description of the indirect overlay method to the overlay documention file. Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> --- Documentation/devicetree/overlay-notes.txt | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/devicetree/o

[PATCH 6/6] doc: dt: Document the target root overlay method

2016-05-09 Thread Pantelis Antoniou
Add a description of the target root overlay method to the overlay documention file. Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> --- Documentation/devicetree/overlay-notes.txt | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/o

[PATCH 2/6] of: unittest: Add indirect overlay target test

2016-05-09 Thread Pantelis Antoniou
Add a unittest for the indirect overlay target case. Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> --- drivers/of/unittest-data/testcases.dts | 9 + drivers/of/unittest-data/tests-overlay.dtsi | 19 ++ drivers/of/unittest.c

[PATCH 5/6] of: unittest: Unit-tests for target root overlays.

2016-05-09 Thread Pantelis Antoniou
Add unittests for target-root based overlays. Signed-off-by: Pantelis Antoniou --- drivers/of/unittest-data/testcases.dts | 5 + drivers/of/unittest-data/tests-overlay.dtsi | 48 +++ drivers/of/unittest.c | 213 3 files changed, 266

[PATCH 3/6] doc: dt: Document the indirect overlay method.

2016-05-09 Thread Pantelis Antoniou
Add a description of the indirect overlay method to the overlay documention file. Signed-off-by: Pantelis Antoniou --- Documentation/devicetree/overlay-notes.txt | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/devicetree/overlay-notes.txt b/Documentation

[PATCH 6/6] doc: dt: Document the target root overlay method

2016-05-09 Thread Pantelis Antoniou
Add a description of the target root overlay method to the overlay documention file. Signed-off-by: Pantelis Antoniou --- Documentation/devicetree/overlay-notes.txt | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/overlay-notes.txt b/Documentation/devicetree

[PATCH 2/6] of: unittest: Add indirect overlay target test

2016-05-09 Thread Pantelis Antoniou
Add a unittest for the indirect overlay target case. Signed-off-by: Pantelis Antoniou --- drivers/of/unittest-data/testcases.dts | 9 + drivers/of/unittest-data/tests-overlay.dtsi | 19 ++ drivers/of/unittest.c | 59 + 3 files

[PATCH 1/6] of: overlay: Implement indirect target support

2016-05-09 Thread Pantelis Antoniou
}; Calling of_overlay_create_indirect() with a "foo" argument selects the foo_target and so on. Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> --- drivers/of/overlay.c | 126 +-- include/linux/of.h | 8 2 files ch

[PATCH 0/6] of: overlays: New target methods

2016-05-09 Thread Pantelis Antoniou
This patchset implement two new target methods. A target-indirect method which allows selecting different targets according to an argument using an extended API and a target root method that fences the target only to a specific given root. Documentation and unit-tests are included. Pantelis

[PATCH 1/6] of: overlay: Implement indirect target support

2016-05-09 Thread Pantelis Antoniou
}; Calling of_overlay_create_indirect() with a "foo" argument selects the foo_target and so on. Signed-off-by: Pantelis Antoniou --- drivers/of/overlay.c | 126 +-- include/linux/of.h | 8 2 files changed, 110 insertions(+), 24 deletions(-)

[PATCH 0/6] of: overlays: New target methods

2016-05-09 Thread Pantelis Antoniou
This patchset implement two new target methods. A target-indirect method which allows selecting different targets according to an argument using an extended API and a target root method that fences the target only to a specific given root. Documentation and unit-tests are included. Pantelis

[PATCH 4/6] of: overlay: Introduce target root capability.

2016-05-09 Thread Pantelis Antoniou
since the target node differs according to the bus the plugged device lies. Using an overlay creating method using a target root node allows us to use a single overlay for those cases. Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> --- drivers/of/overlay.c

[PATCH 4/6] of: overlay: Introduce target root capability.

2016-05-09 Thread Pantelis Antoniou
since the target node differs according to the bus the plugged device lies. Using an overlay creating method using a target root node allows us to use a single overlay for those cases. Signed-off-by: Pantelis Antoniou --- drivers/of/overlay.c | 101

Re: [PATCH 3/4] of: changesets: Introduce changeset helper methods

2016-05-09 Thread Pantelis Antoniou
Hi Rob, > On May 9, 2016, at 17:27 , Rob Herring <robherri...@gmail.com> wrote: > > On Mon, May 9, 2016 at 8:20 AM, Pantelis Antoniou > <pantelis.anton...@konsulko.com> wrote: >> Changesets are very powerful, but the lack of a helper API >> makes using them

Re: [PATCH 3/4] of: changesets: Introduce changeset helper methods

2016-05-09 Thread Pantelis Antoniou
Hi Rob, > On May 9, 2016, at 17:27 , Rob Herring wrote: > > On Mon, May 9, 2016 at 8:20 AM, Pantelis Antoniou > wrote: >> Changesets are very powerful, but the lack of a helper API >> makes using them cumbersome. Introduce a simple copy based >> API that ma

[PATCH 1/4] of: dynamic: changeset prop-update revert fix

2016-05-09 Thread Pantelis Antoniou
When reverting an update property changeset entry that created a property the reverse operation is a remove property and not an update. Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> --- drivers/of/dynamic.c | 5 + 1 file changed, 5 insertions(+) diff --git a/d

[PATCH 1/4] of: dynamic: changeset prop-update revert fix

2016-05-09 Thread Pantelis Antoniou
When reverting an update property changeset entry that created a property the reverse operation is a remove property and not an update. Signed-off-by: Pantelis Antoniou --- drivers/of/dynamic.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c

[PATCH 0/4] of: dynamic: Changesets helpers & fixes

2016-05-09 Thread Pantelis Antoniou
which contains the bulk of the changes. Finally the last patch adds a unittest for the changeset helpers. Pantelis Antoniou (4): of: dynamic: changeset prop-update revert fix of: dynamic: Add __of_node_dupv() of: changesets: Introduce changeset helper methods of: unittest: changeset helpers

[PATCH 4/4] of: unittest: changeset helpers

2016-05-09 Thread Pantelis Antoniou
Add a unitest specific for the new changeset helpers. Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> --- drivers/of/unittest.c | 54 +++ 1 file changed, 54 insertions(+) diff --git a/drivers/of/unittest.c b/drivers/of/unit

[PATCH 0/4] of: dynamic: Changesets helpers & fixes

2016-05-09 Thread Pantelis Antoniou
which contains the bulk of the changes. Finally the last patch adds a unittest for the changeset helpers. Pantelis Antoniou (4): of: dynamic: changeset prop-update revert fix of: dynamic: Add __of_node_dupv() of: changesets: Introduce changeset helper methods of: unittest: changeset helpers

[PATCH 4/4] of: unittest: changeset helpers

2016-05-09 Thread Pantelis Antoniou
Add a unitest specific for the new changeset helpers. Signed-off-by: Pantelis Antoniou --- drivers/of/unittest.c | 54 +++ 1 file changed, 54 insertions(+) diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index e986e6e..ff6939b 100644

[PATCH 3/4] of: changesets: Introduce changeset helper methods

2016-05-09 Thread Pantelis Antoniou
atible", "foo,bar"); Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> --- drivers/of/dynamic.c | 501 +++ include/linux/of.h | 143 +++ 2 files changed, 644 insertions(+) diff

[PATCH 3/4] of: changesets: Introduce changeset helper methods

2016-05-09 Thread Pantelis Antoniou
atible", "foo,bar"); Signed-off-by: Pantelis Antoniou --- drivers/of/dynamic.c | 501 +++ include/linux/of.h | 143 +++ 2 files changed, 644 insertions(+) diff --git a/drivers/of/dynamic.c

[PATCH 2/4] of: dynamic: Add __of_node_dupv()

2016-05-09 Thread Pantelis Antoniou
Add an __of_node_dupv() private method and make __of_node_dup() use it. This is required for the subsequent changeset accessors which will make use of it. Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> --- drivers/of/dynamic.c | 29 +++-- 1 file c

[PATCH 2/4] of: dynamic: Add __of_node_dupv()

2016-05-09 Thread Pantelis Antoniou
Add an __of_node_dupv() private method and make __of_node_dup() use it. This is required for the subsequent changeset accessors which will make use of it. Signed-off-by: Pantelis Antoniou --- drivers/of/dynamic.c | 29 +++-- 1 file changed, 23 insertions(+), 6 deletions

[PATCH v8 5/6] of: overlay: add per overlay sysfs attributes

2016-05-09 Thread Pantelis Antoniou
* A per overlay can_remove sysfs attribute that reports whether the overlay can be removed or not due to another overlapping overlay. * A target sysfs attribute listing the target of each fragment, in a group named after the name of the fragment. Signed-off-by: Pantelis Antoniou <pantelis.an

[PATCH v8 2/6] of: overlay: global sysfs enable attribute

2016-05-09 Thread Pantelis Antoniou
A throw once master enable switch to protect against any further overlay applications if the administrator desires so. A kernel command line option is provided as well. Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> Acked-by: Greg Kroah-Hartman <gre...@linuxfound

[PATCH v8 5/6] of: overlay: add per overlay sysfs attributes

2016-05-09 Thread Pantelis Antoniou
* A per overlay can_remove sysfs attribute that reports whether the overlay can be removed or not due to another overlapping overlay. * A target sysfs attribute listing the target of each fragment, in a group named after the name of the fragment. Signed-off-by: Pantelis Antoniou Acked-by: Greg

[PATCH v8 2/6] of: overlay: global sysfs enable attribute

2016-05-09 Thread Pantelis Antoniou
A throw once master enable switch to protect against any further overlay applications if the administrator desires so. A kernel command line option is provided as well. Signed-off-by: Pantelis Antoniou Acked-by: Greg Kroah-Hartman --- drivers/of/overlay.c | 50

[PATCH v8 3/6] Documentation: ABI: overlays - global attributes

2016-05-09 Thread Pantelis Antoniou
Documentation ABI entry for overlays sysfs entries. Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- .../ABI/testing/sysfs-firmware-devicetree-overlays | 24 ++ 1 file changed, 2

[PATCH v8 4/6] Documentation: document of_overlay_disable parameter

2016-05-09 Thread Pantelis Antoniou
Document the of_overlay_disable parameter. Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- Documentation/kernel-parameters.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Document

[PATCH v8 0/6] of: overlay: kobject & sysfs'ation

2016-05-09 Thread Pantelis Antoniou
. * Split the sysfs attribute patch to a global and a per-overlay patch. * Dropped binary attributes using textual kobj_attributes instead. Changes since v1: * Maintainer requested changes. * Documented the sysfs entries * Per overlay sysfs attributes. Pantelis Antoniou (6): of: overlay: kobjectify

[PATCH v8 3/6] Documentation: ABI: overlays - global attributes

2016-05-09 Thread Pantelis Antoniou
Documentation ABI entry for overlays sysfs entries. Signed-off-by: Pantelis Antoniou Acked-by: Greg Kroah-Hartman --- .../ABI/testing/sysfs-firmware-devicetree-overlays | 24 ++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-firmware

[PATCH v8 4/6] Documentation: document of_overlay_disable parameter

2016-05-09 Thread Pantelis Antoniou
Document the of_overlay_disable parameter. Signed-off-by: Pantelis Antoniou Acked-by: Greg Kroah-Hartman --- Documentation/kernel-parameters.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index 0b3de80

[PATCH v8 0/6] of: overlay: kobject & sysfs'ation

2016-05-09 Thread Pantelis Antoniou
. * Split the sysfs attribute patch to a global and a per-overlay patch. * Dropped binary attributes using textual kobj_attributes instead. Changes since v1: * Maintainer requested changes. * Documented the sysfs entries * Per overlay sysfs attributes. Pantelis Antoniou (6): of: overlay: kobjectify

[PATCH v8 6/6] Documentation: ABI: overlays - per overlay docs

2016-05-09 Thread Pantelis Antoniou
Documentation for the per-overlay attributes. Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- .../ABI/testing/sysfs-firmware-devicetree-overlays | 28 ++ 1 file changed, 28 inserti

[PATCH v8 1/6] of: overlay: kobjectify overlay objects

2016-05-09 Thread Pantelis Antoniou
. In a future more attributes can be added in a backwards compatible manner. Signed-off-by: Pantelis Antoniou <pantelis.anton...@konsulko.com> Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- drivers/of/base.c | 5 + drivers/of/of_private.h | 9 ++

[PATCH v8 6/6] Documentation: ABI: overlays - per overlay docs

2016-05-09 Thread Pantelis Antoniou
Documentation for the per-overlay attributes. Signed-off-by: Pantelis Antoniou Acked-by: Greg Kroah-Hartman --- .../ABI/testing/sysfs-firmware-devicetree-overlays | 28 ++ 1 file changed, 28 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-firmware-devicetree

[PATCH v8 1/6] of: overlay: kobjectify overlay objects

2016-05-09 Thread Pantelis Antoniou
. In a future more attributes can be added in a backwards compatible manner. Signed-off-by: Pantelis Antoniou Acked-by: Greg Kroah-Hartman --- drivers/of/base.c | 5 + drivers/of/of_private.h | 9 + drivers/of/overlay.c| 50

Re: [Question] refcount of DT node

2016-04-14 Thread Pantelis Antoniou
Hi Mark, > On Apr 14, 2016, at 13:10 , Mark Rutland wrote: > > On Thu, Apr 14, 2016 at 04:47:57PM +0900, Masahiro Yamada wrote: >> Hi experts. >> >> My understanding of refcount of DT node is poor. >> Please help me understand it correctly. >> >> Sorry if I am asking

Re: [Question] refcount of DT node

2016-04-14 Thread Pantelis Antoniou
Hi Mark, > On Apr 14, 2016, at 13:10 , Mark Rutland wrote: > > On Thu, Apr 14, 2016 at 04:47:57PM +0900, Masahiro Yamada wrote: >> Hi experts. >> >> My understanding of refcount of DT node is poor. >> Please help me understand it correctly. >> >> Sorry if I am asking stupid questions. >> >>

Re: [Question] refcount of DT node

2016-04-14 Thread Pantelis Antoniou
Hi Mark, > On Apr 14, 2016, at 12:59 , Mark Rutland wrote: > > On Thu, Apr 14, 2016 at 09:48:49AM +0100, Russell King - ARM Linux wrote: >> On Thu, Apr 14, 2016 at 04:47:57PM +0900, Masahiro Yamada wrote: >>> Hi experts. >>> >>> My understanding of refcount of DT node is

Re: [Question] refcount of DT node

2016-04-14 Thread Pantelis Antoniou
Hi Mark, > On Apr 14, 2016, at 12:59 , Mark Rutland wrote: > > On Thu, Apr 14, 2016 at 09:48:49AM +0100, Russell King - ARM Linux wrote: >> On Thu, Apr 14, 2016 at 04:47:57PM +0900, Masahiro Yamada wrote: >>> Hi experts. >>> >>> My understanding of refcount of DT node is poor. >> >> The

Re: [PATCH 1/1] of/overlay: of overlay callbacks

2016-02-22 Thread Pantelis Antoniou
Hi Rob, > On Feb 22, 2016, at 04:55 , Rob Herring wrote: > > On Wed, Feb 17, 2016 at 11:41:25AM -0600, Alan Tull wrote: >> Add overlay callback functionality. >> >> When DT overlays are being added, some drivers/subsystems >> will want to know about the changes before they go

Re: [PATCH 1/1] of/overlay: of overlay callbacks

2016-02-22 Thread Pantelis Antoniou
Hi Rob, > On Feb 22, 2016, at 04:55 , Rob Herring wrote: > > On Wed, Feb 17, 2016 at 11:41:25AM -0600, Alan Tull wrote: >> Add overlay callback functionality. >> >> When DT overlays are being added, some drivers/subsystems >> will want to know about the changes before they go into the >> live

Re: [PATCH v2] of: resolver: Add missing of_node_get and of_node_put

2016-02-11 Thread Pantelis Antoniou
Hi Rob, > On Feb 12, 2016, at 01:18 , Rob Herring wrote: > > On Wed, Feb 3, 2016 at 12:09 PM, Amitoj Kaur Chawla > wrote: >> In __of_find_node_by_full_name, add an of_node_get when detecting the >> desired element, to ensure that it ends up with a reference count that is >> one greater than on

Re: [PATCH v2] of: resolver: Add missing of_node_get and of_node_put

2016-02-11 Thread Pantelis Antoniou
Hi Rob, > On Feb 12, 2016, at 01:18 , Rob Herring wrote: > > On Wed, Feb 3, 2016 at 12:09 PM, Amitoj Kaur Chawla > wrote: >> In __of_find_node_by_full_name, add an of_node_get when detecting the >> desired element, to ensure that it ends up with a

Re: [PATCH] of: resolver: Add missing of_node_put

2016-01-29 Thread Pantelis Antoniou
Hi Rob, > On Jan 29, 2016, at 18:45 , Rob Herring wrote: > > On Wed, Jan 27, 2016 at 06:14:00PM +0200, Pantelis Antoniou wrote: >> Hi Mark, >> >>> On Jan 27, 2016, at 18:05 , Mark Rutland wrote: >>> >>> On Wed, Jan 27, 20

Re: [PATCH] of: resolver: Add missing of_node_put

2016-01-29 Thread Pantelis Antoniou
Hi Rob, > On Jan 29, 2016, at 18:45 , Rob Herring <r...@kernel.org> wrote: > > On Wed, Jan 27, 2016 at 06:14:00PM +0200, Pantelis Antoniou wrote: >> Hi Mark, >> >>> On Jan 27, 2016, at 18:05 , Mark Rutland <mark.rutl...@arm.com> wrote: >>> &

Re: [PATCH] of: resolver: Add missing of_node_put

2016-01-27 Thread Pantelis Antoniou
Hi Mark, > On Jan 27, 2016, at 18:21 , Mark Rutland wrote: > > On Wed, Jan 27, 2016 at 06:14:00PM +0200, Pantelis Antoniou wrote: >> Hi Mark, >> >>> On Jan 27, 2016, at 18:05 , Mark Rutland wrote: >>> >>> On Wed, Jan 27, 20

Re: [PATCH] of: resolver: Add missing of_node_put

2016-01-27 Thread Pantelis Antoniou
Hi Mark, > On Jan 27, 2016, at 18:05 , Mark Rutland wrote: > > On Wed, Jan 27, 2016 at 08:50:17PM +0530, Amitoj Kaur Chawla wrote: >> for_each_child_of_node performs an of_node_get on each iteration, so >> to break out of the loop an of_node_put is required. >> >> Found using Coccinelle. The

Re: [PATCH] of: resolver: Add missing of_node_put

2016-01-27 Thread Pantelis Antoniou
Hi Mark, > On Jan 27, 2016, at 18:05 , Mark Rutland wrote: > > On Wed, Jan 27, 2016 at 08:50:17PM +0530, Amitoj Kaur Chawla wrote: >> for_each_child_of_node performs an of_node_get on each iteration, so >> to break out of the loop an of_node_put is required. >> >> Found

Re: [PATCH] of: resolver: Add missing of_node_put

2016-01-27 Thread Pantelis Antoniou
Hi Mark, > On Jan 27, 2016, at 18:21 , Mark Rutland <mark.rutl...@arm.com> wrote: > > On Wed, Jan 27, 2016 at 06:14:00PM +0200, Pantelis Antoniou wrote: >> Hi Mark, >> >>> On Jan 27, 2016, at 18:05 , Mark Rutland <mark.rutl...@arm.com> wrote: >>

<    1   2   3   4   5   6   7   8   9   10   >