[PATCH BUGFIX RFC 2/2] Revert "bfq: calculate shallow depths at init time"

This reverts commit f0635b8a416e3b99dc6fd9ac3ce534764869d0c8. --- block/bfq-iosched.c | 117 +--- 1 file changed, 57 insertions(+), 60 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 8cc3032b66de..92214d58510c 100644 ---

[PATCH BUGFIX RFC 1/2] Revert "bfq-iosched: remove unused variable"

This reverts commit bd7d4ef6a4c9b3611fa487a0065bf042c71ce620. --- block/bfq-iosched.c | 15 --- block/bfq-iosched.h | 6 ++ 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index cd307767a134..8cc3032b66de 100644 ---

Re: [RFC PATCH 0/3] cgroup: fsio throttle controller

> Il giorno 18 gen 2019, alle ore 12:10, Andrea Righi > ha scritto: > > On Fri, Jan 18, 2019 at 12:04:17PM +0100, Paolo Valente wrote: >> >> >>> Il giorno 18 gen 2019, alle ore 11:31, Andrea Righi >>> ha scritto: >>> >>>

Re: [RFC PATCH 0/3] cgroup: fsio throttle controller

> Il giorno 18 gen 2019, alle ore 11:31, Andrea Righi > ha scritto: > > This is a redesign of my old cgroup-io-throttle controller: > https://lwn.net/Articles/330531/ > > I'm resuming this old patch to point out a problem that I think is still > not solved completely. > > = Problem = > >

Re: [PATCH BUGFIX 0/2] bfq: fix unbalanced decrements causing loss of throughput

> Il giorno 7 dic 2018, alle ore 15:40, Jens Axboe ha scritto: > > On 12/7/18 3:01 AM, Paolo Valente wrote: >> >> >>> Il giorno 7 dic 2018, alle ore 03:23, Jens Axboe ha >>> scritto: >>> >>> On 12/6/18 11:18 AM, Paolo Valente wrote

Re: [PATCH V2 00/10] unify the interface of the proportional-share policy in blkio/io

> Il giorno 2 gen 2019, alle ore 17:03, Tejun Heo ha scritto: > > Hello, Paolo. > > On Sun, Dec 30, 2018 at 11:25:25AM +0100, Paolo Valente wrote: >> What's the benefit of throwing away months of work, on which we agreed >> before starting it, and that solves a p

Re: [PATCH V2 00/10] unify the interface of the proportional-share policy in blkio/io

> Il giorno 28 dic 2018, alle ore 00:41, Tejun Heo ha scritto: > > Hello, Paolo. > > On Sun, Dec 23, 2018 at 12:00:14PM +0100, Paolo Valente wrote: >> 4.21 is coming ... and the legacy proportional share interface will >> be gone with cfq. This w

Re: [PATCH V2 00/10] unify the interface of the proportional-share policy in blkio/io

> Il giorno 18 dic 2018, alle ore 18:22, Paolo Valente > ha scritto: > > > >> Il giorno 18 dic 2018, alle ore 17:41, Tejun Heo ha >> scritto: >> >> Hello, Paolo. >> >> On Tue, Dec 18, 2018 at 08:48:10AM +0100, Paolo Valente wrote:

Re: [PATCH V2 00/10] unify the interface of the proportional-share policy in blkio/io

> Il giorno 18 dic 2018, alle ore 18:22, Paolo Valente > ha scritto: > > > >> Il giorno 18 dic 2018, alle ore 17:41, Tejun Heo ha >> scritto: >> >> Hello, Paolo. >> >> On Tue, Dec 18, 2018 at 08:48:10AM +0100, Paolo Valente wrote:

Re: [PATCH V2 00/10] unify the interface of the proportional-share policy in blkio/io

> Il giorno 18 dic 2018, alle ore 17:41, Tejun Heo ha scritto: > > Hello, Paolo. > > On Tue, Dec 18, 2018 at 08:48:10AM +0100, Paolo Valente wrote: >> If Tejun cannot see any solution to his concern, then can we just >> switch to this extension, considering tha

Re: [PATCH V2 00/10] unify the interface of the proportional-share policy in blkio/io

[RESENDING BECAUSE BOUNCED] > Il giorno 10 dic 2018, alle ore 14:45, Angelo Ruocco > ha scritto: > > 2018-11-30 19:53 GMT+01:00, Paolo Valente : >> >> >>> Il giorno 30 nov 2018, alle ore 19:42, Tejun Heo ha >>> scritto: >>> >>&g

Re: [PATCH BUGFIX 0/2] bfq: fix unbalanced decrements causing loss of throughput

> Il giorno 7 dic 2018, alle ore 03:23, Jens Axboe ha scritto: > > On 12/6/18 11:18 AM, Paolo Valente wrote: >> Hi Jens, >> the first patch in this series fixes an error in the decrementing of >> the counter of the number of groups with pending I/O. This wro

[PATCH BUGFIX 2/2] block, bfq: fix comments on __bfq_deactivate_entity

updates sched_data and service trees for the entity, so as to represent entity as inactive (which is only part of the steps needed for the deactivation of the entity). 2) The function must be invoked on every entity being deactivated. Signed-off-by: Paolo Valente --- block/bfq-wf2q.c | 11

[PATCH BUGFIX 1/2] block, bfq: fix decrement of num_active_groups

tt Tested-by: Lucjan Lucjanov Reviewed-by: Federico Motta Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 76 + block/bfq-iosched.h | 51 +-- block/bfq-wf2q.c| 5 +++- 3 files changed, 107 insertions(+

[PATCH BUGFIX 1/2] block, bfq: fix decrement of num_active_groups

tt Tested-by: Lucjan Lucjanov Reviewed-by: Federico Motta Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 76 + block/bfq-iosched.h | 51 +-- block/bfq-wf2q.c| 5 +++- 3 files changed, 107 insertions(+

[PATCH BUGFIX 0/2] bfq: fix unbalanced decrements causing loss of throughput

to making the above bug more difficult to find. Thanks, Paolo Paolo Valente (2): block, bfq: fix decrement of num_active_groups block, bfq: fix comments on __bfq_deactivate_entity block/bfq-iosched.c | 76 + block/bfq-iosched.h | 51

[PATCH V2 00/10] unify the interface of the proportional-share policy in blkio/io

cgroup: make all functions of all cftypes be invoked block, throttle: allow sharing cgroup statistic files Paolo Valente (5): cgroup: add hook seq_show_cft with also the owning cftype as parameter block, cgroup: pass cftype to functions that need to use it block, bfq: use standard file

[PATCH V2 00/10] unify the interface of the proportional-share policy in blkio/io

cgroup: make all functions of all cftypes be invoked block, throttle: allow sharing cgroup statistic files Paolo Valente (5): cgroup: add hook seq_show_cft with also the owning cftype as parameter block, cgroup: pass cftype to functions that need to use it block, bfq: use standard file

[PATCH V2 06/10] cgroup: make all functions of all cftypes be invoked

one of those operations is requested, the respective function of all the cftypes linked together. Signed-off-by: Angelo Ruocco Signed-off-by: Paolo Valente --- kernel/cgroup/cgroup.c | 181 - 1 file changed, 132 insertions(+), 49 deletions(-) diff

[PATCH V2 01/10] cgroup: add hook seq_show_cft with also the owning cftype as parameter

is the first one. This commit adds an additional seq_show_cft hook that has as a formal parameter also the cftype that owns the function. Signed-off-by: Angelo Ruocco Signed-off-by: Paolo Valente --- include/linux/cgroup-defs.h | 3 ++- kernel/cgroup/cgroup.c | 15 +-- 2 files changed

[PATCH V2 02/10] block, cgroup: pass cftype to functions that need to use it

Signed-off-by: Paolo Valente --- block/bfq-cgroup.c | 54 -- block/blk-cgroup.c | 22 --- block/blk-throttle.c | 8 +++ include/linux/blk-cgroup.h | 10 + 4 files changed, 52 insertions(+), 42 deletions

[PATCH V2 05/10] block, bfq: align min and default weights with the old cfq default

From: Angelo Ruocco bfq exposes a cgroup attribute, weight, with the same meaning as that exposed by cfq. This commit changes bfq default and min weights to match the ones set by cfq (before legacy blk was removed). Signed-off-by: Angelo Ruocco Signed-off-by: Paolo Valente --- block/bfq

[PATCH V2 04/10] cgroup: add owner name to cftypes

icitly set. Signed-off-by: Angelo Ruocco Signed-off-by: Paolo Valente --- include/linux/cgroup-defs.h | 2 ++ include/linux/cgroup.h | 13 + 2 files changed, 15 insertions(+) diff --git a/include/linux/cgroup-defs.h b/include/linux/cgroup-defs.h index d659763c7221..6e31f478c

[PATCH V2 06/10] cgroup: make all functions of all cftypes be invoked

one of those operations is requested, the respective function of all the cftypes linked together. Signed-off-by: Angelo Ruocco Signed-off-by: Paolo Valente --- kernel/cgroup/cgroup.c | 181 - 1 file changed, 132 insertions(+), 49 deletions(-) diff

[PATCH V2 01/10] cgroup: add hook seq_show_cft with also the owning cftype as parameter

is the first one. This commit adds an additional seq_show_cft hook that has as a formal parameter also the cftype that owns the function. Signed-off-by: Angelo Ruocco Signed-off-by: Paolo Valente --- include/linux/cgroup-defs.h | 3 ++- kernel/cgroup/cgroup.c | 15 +-- 2 files changed

[PATCH V2 02/10] block, cgroup: pass cftype to functions that need to use it

Signed-off-by: Paolo Valente --- block/bfq-cgroup.c | 54 -- block/blk-cgroup.c | 22 --- block/blk-throttle.c | 8 +++ include/linux/blk-cgroup.h | 10 + 4 files changed, 52 insertions(+), 42 deletions

[PATCH V2 05/10] block, bfq: align min and default weights with the old cfq default

From: Angelo Ruocco bfq exposes a cgroup attribute, weight, with the same meaning as that exposed by cfq. This commit changes bfq default and min weights to match the ones set by cfq (before legacy blk was removed). Signed-off-by: Angelo Ruocco Signed-off-by: Paolo Valente --- block/bfq

[PATCH V2 04/10] cgroup: add owner name to cftypes

icitly set. Signed-off-by: Angelo Ruocco Signed-off-by: Paolo Valente --- include/linux/cgroup-defs.h | 2 ++ include/linux/cgroup.h | 13 + 2 files changed, 15 insertions(+) diff --git a/include/linux/cgroup-defs.h b/include/linux/cgroup-defs.h index d659763c7221..6e31f478c

[PATCH V2 03/10] cgroup: link cftypes of the same subsystem with the same name

" operations. Signed-off-by: Angelo Ruocco Signed-off-by: Paolo Valente --- include/linux/cgroup-defs.h | 9 ++ kernel/cgroup/cgroup.c | 78 +++-- 2 files changed, 85 insertions(+), 2 deletions(-) diff --git a/include/linux/cgroup-defs.h b/inc

[PATCH V2 10/10] doc, bfq-iosched: make it consistent with the new cgroup interface

BFQ now shares interface files with CFQ, for the proportional-share policy. Make documentation consistent with that. Signed-off-by: Paolo Valente --- Documentation/block/bfq-iosched.txt | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git

[PATCH V2 07/10] block, bfq: use standard file names for the proportional-share policy

subsystem). So, for bfq, we had to add the prefix "bfq" to the names of its cgroup files. This commit renames the cgroup files of the bfq scheduler as those exposed by cfq, and makes bfq willing to share these files with any other future policy. Signed-off-by: Angelo Ruocco Signed-off

[PATCH V2 03/10] cgroup: link cftypes of the same subsystem with the same name

" operations. Signed-off-by: Angelo Ruocco Signed-off-by: Paolo Valente --- include/linux/cgroup-defs.h | 9 ++ kernel/cgroup/cgroup.c | 78 +++-- 2 files changed, 85 insertions(+), 2 deletions(-) diff --git a/include/linux/cgroup-defs.h b/inc

[PATCH V2 10/10] doc, bfq-iosched: make it consistent with the new cgroup interface

BFQ now shares interface files with CFQ, for the proportional-share policy. Make documentation consistent with that. Signed-off-by: Paolo Valente --- Documentation/block/bfq-iosched.txt | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git

[PATCH V2 07/10] block, bfq: use standard file names for the proportional-share policy

subsystem). So, for bfq, we had to add the prefix "bfq" to the names of its cgroup files. This commit renames the cgroup files of the bfq scheduler as those exposed by cfq, and makes bfq willing to share these files with any other future policy. Signed-off-by: Angelo Ruocco Signed-off

[PATCH V2 09/10] doc, bfq-iosched: fix a few clerical errors

This commit fixes a few clerical errors in Documentation/block/bfq-iosched.txt. Signed-off-by: Paolo Valente --- Documentation/block/bfq-iosched.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/block/bfq-iosched.txt b/Documentation/block/bfq

[PATCH V2 08/10] block, throttle: allow sharing cgroup statistic files

From: Angelo Ruocco Some of the cgroup files defined in the throttle policy have the same meaning as those defined in the proportional share policy. This commit uses the new file sharing interface in cgroup to share these files. Signed-off-by: Angelo Ruocco Signed-off-by: Paolo Valente

[PATCH V2 09/10] doc, bfq-iosched: fix a few clerical errors

This commit fixes a few clerical errors in Documentation/block/bfq-iosched.txt. Signed-off-by: Paolo Valente --- Documentation/block/bfq-iosched.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/block/bfq-iosched.txt b/Documentation/block/bfq

[PATCH V2 08/10] block, throttle: allow sharing cgroup statistic files

From: Angelo Ruocco Some of the cgroup files defined in the throttle policy have the same meaning as those defined in the proportional share policy. This commit uses the new file sharing interface in cgroup to share these files. Signed-off-by: Angelo Ruocco Signed-off-by: Paolo Valente

Re: [PATCH] block: BFQ default for single queue devices

> Il giorno 05 ott 2018, alle ore 00:42, Bart Van Assche > ha scritto: > > On Thu, 2018-10-04 at 22:39 +0200, Paolo Valente wrote: >> No, kernel build is, for evident reasons, one of the workloads I cared >> most about. Actually, I tried to focus on all my main >

Re: [PATCH] block: BFQ default for single queue devices

> Il giorno 05 ott 2018, alle ore 00:42, Bart Van Assche > ha scritto: > > On Thu, 2018-10-04 at 22:39 +0200, Paolo Valente wrote: >> No, kernel build is, for evident reasons, one of the workloads I cared >> most about. Actually, I tried to focus on all my main >

Re: [PATCH BUGFIX 0/3] three fixes for the function bfq_requests_merged

> Il giorno 31 mag 2018, alle ore 16:48, Jens Axboe ha > scritto: > > On 5/31/18 7:23 AM, Paolo Valente wrote: >> Hi Jens, >> this series fixes three bugs in bfq_requests_merged. In more detail: >> >> - two linked bugs, with the first (critical: wrong

Re: [PATCH BUGFIX 0/3] three fixes for the function bfq_requests_merged

> Il giorno 31 mag 2018, alle ore 16:48, Jens Axboe ha > scritto: > > On 5/31/18 7:23 AM, Paolo Valente wrote: >> Hi Jens, >> this series fixes three bugs in bfq_requests_merged. In more detail: >> >> - two linked bugs, with the first (critical: wrong

[PATCH BUGFIX/IMPROVEMENTS 3/4] block, bfq: increase weight-raising duration for interactive apps

, if constantly weight-raised. To address this issue, this commit conservatively sets the upper limit for weight-raising duration to 25 seconds. Signed-off-by: Davide Sapienza Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions

[PATCH BUGFIX/IMPROVEMENTS 2/4] block, bfq: remove slow-system class

to just confuse the class-detection mechanism, and, as we have verified experimentally, to cause BFQ to compute non-sensical weight-raising durations. This commit addresses this issue by removing the slow class and the class-detection mechanism. Signed-off-by: Paolo Valente --- block/bfq-iosched.c

[PATCH BUGFIX/IMPROVEMENTS 3/4] block, bfq: increase weight-raising duration for interactive apps

, if constantly weight-raised. To address this issue, this commit conservatively sets the upper limit for weight-raising duration to 25 seconds. Signed-off-by: Davide Sapienza Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions

[PATCH BUGFIX/IMPROVEMENTS 2/4] block, bfq: remove slow-system class

to just confuse the class-detection mechanism, and, as we have verified experimentally, to cause BFQ to compute non-sensical weight-raising durations. This commit addresses this issue by removing the slow class and the class-detection mechanism. Signed-off-by: Paolo Valente --- block/bfq-iosched.c

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 14 mag 2018, alle ore 19:31, Jens Axboe <ax...@kernel.dk> ha > scritto: > > On 5/14/18 11:16 AM, Paolo Valente wrote: >> >> >>> Il giorno 10 mag 2018, alle ore 18:14, Bart Van Assche >>> <bart.vanass...@wdc.com> ha scri

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 14 mag 2018, alle ore 19:31, Jens Axboe ha > scritto: > > On 5/14/18 11:16 AM, Paolo Valente wrote: >> >> >>> Il giorno 10 mag 2018, alle ore 18:14, Bart Van Assche >>> ha scritto: >>> >>> On Fri, 2018-05-04 at 19

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 10 mag 2018, alle ore 18:14, Bart Van Assche > <bart.vanass...@wdc.com> ha scritto: > > On Fri, 2018-05-04 at 19:17 +0200, Paolo Valente wrote: >> When invoked for an I/O request rq, [ ... ] > > Tested-by: Bart Van Assche <bart.vanass..

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 10 mag 2018, alle ore 18:14, Bart Van Assche > ha scritto: > > On Fri, 2018-05-04 at 19:17 +0200, Paolo Valente wrote: >> When invoked for an I/O request rq, [ ... ] > > Tested-by: Bart Van Assche > > > Any decision for this fix, Jens? Thanks, Paolo

Re: bug in tag handling in blk-mq?

> Il giorno 09 mag 2018, alle ore 06:11, Mike Galbraith ha > scritto: > > On Tue, 2018-05-08 at 19:09 -0600, Jens Axboe wrote: >> >> Alright, I managed to reproduce it. What I think is happening is that >> BFQ is limiting the inflight case to something less than the wake >>

Re: bug in tag handling in blk-mq?

> Il giorno 09 mag 2018, alle ore 06:11, Mike Galbraith ha > scritto: > > On Tue, 2018-05-08 at 19:09 -0600, Jens Axboe wrote: >> >> Alright, I managed to reproduce it. What I think is happening is that >> BFQ is limiting the inflight case to something less than the wake >> batch for

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 07 mag 2018, alle ore 12:01, Mike Galbraith <efa...@gmx.de> ha > scritto: > > On Mon, 2018-05-07 at 11:27 +0200, Paolo Valente wrote: >> >> >> Where is the bug? > > Hm, seems potent pain-killers and C don't mix all that well. >

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 07 mag 2018, alle ore 12:01, Mike Galbraith ha > scritto: > > On Mon, 2018-05-07 at 11:27 +0200, Paolo Valente wrote: >> >> >> Where is the bug? > > Hm, seems potent pain-killers and C don't mix all that well. > I'll try to keep it in

Re: bug in tag handling in blk-mq?

> Il giorno 07 mag 2018, alle ore 18:39, Jens Axboe <ax...@kernel.dk> ha > scritto: > > On 5/7/18 8:03 AM, Paolo Valente wrote: >> Hi Jens, Christoph, all, >> Mike Galbraith has been experiencing hangs, on blk_mq_get_tag, only >> with bfq [1]. Symptoms see

Re: bug in tag handling in blk-mq?

> Il giorno 07 mag 2018, alle ore 18:39, Jens Axboe ha > scritto: > > On 5/7/18 8:03 AM, Paolo Valente wrote: >> Hi Jens, Christoph, all, >> Mike Galbraith has been experiencing hangs, on blk_mq_get_tag, only >> with bfq [1]. Symptoms seem to clearly point to a

bug in tag handling in blk-mq?

Hi Jens, Christoph, all, Mike Galbraith has been experiencing hangs, on blk_mq_get_tag, only with bfq [1]. Symptoms seem to clearly point to a problem in I/O-tag handling, triggered by bfq because it limits the number of tags for async and sync write requests (in bfq_limit_depth). Fortunately, I

bug in tag handling in blk-mq?

Hi Jens, Christoph, all, Mike Galbraith has been experiencing hangs, on blk_mq_get_tag, only with bfq [1]. Symptoms seem to clearly point to a problem in I/O-tag handling, triggered by bfq because it limits the number of tags for async and sync write requests (in bfq_limit_depth). Fortunately, I

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 07 mag 2018, alle ore 05:23, Mike Galbraith <efa...@gmx.de> ha > scritto: > > On Mon, 2018-05-07 at 04:43 +0200, Mike Galbraith wrote: >> On Sun, 2018-05-06 at 09:42 +0200, Paolo Valente wrote: >>> >>> I've attached a compressed p

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 07 mag 2018, alle ore 05:23, Mike Galbraith ha > scritto: > > On Mon, 2018-05-07 at 04:43 +0200, Mike Galbraith wrote: >> On Sun, 2018-05-06 at 09:42 +0200, Paolo Valente wrote: >>> >>> I've attached a compressed patch (to avoid possible

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 07 mag 2018, alle ore 07:56, Mike Galbraith <efa...@gmx.de> ha > scritto: > > On Sun, 2018-05-06 at 09:42 +0200, Paolo Valente wrote: >> >> diff --git a/block/bfq-mq-iosched.c b/block/bfq-mq-iosched.c >> index 118f319af7c0..6662efe29b69 10

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 07 mag 2018, alle ore 07:56, Mike Galbraith ha > scritto: > > On Sun, 2018-05-06 at 09:42 +0200, Paolo Valente wrote: >> >> diff --git a/block/bfq-mq-iosched.c b/block/bfq-mq-iosched.c >> index 118f319af7c0..6662efe29b69 100644 >> --- a/block

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 05 mag 2018, alle ore 16:56, Mike Galbraith <efa...@gmx.de> ha > scritto: > > On Sat, 2018-05-05 at 12:39 +0200, Paolo Valente wrote: >> >> BTW, if you didn't run out of patience with this permanent issue yet, >> I was thinking of two o th

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 05 mag 2018, alle ore 16:56, Mike Galbraith ha > scritto: > > On Sat, 2018-05-05 at 12:39 +0200, Paolo Valente wrote: >> >> BTW, if you didn't run out of patience with this permanent issue yet, >> I was thinking of two o three changes to retry to tr

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 05 mag 2018, alle ore 10:19, Mike Galbraith ha > scritto: > > On Fri, 2018-05-04 at 21:46 +0200, Mike Galbraith wrote: >> Tentatively, I suspect you've just fixed the nasty stalls I reported a >> while back. > > Oh well, so much for optimism. It took a lot, but

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 05 mag 2018, alle ore 10:19, Mike Galbraith ha > scritto: > > On Fri, 2018-05-04 at 21:46 +0200, Mike Galbraith wrote: >> Tentatively, I suspect you've just fixed the nasty stalls I reported a >> while back. > > Oh well, so much for optimism. It took a lot, but just hung. Yep,

[PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

or merging, no lock needs to be grabbed any longer in the prepare_request hook, while the lock already taken to perform insertion or merging is used to preparare the request as well. Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> --- block/bfq-iosched.

[PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

or merging, no lock needs to be grabbed any longer in the prepare_request hook, while the lock already taken to perform insertion or merging is used to preparare the request as well. Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 86 +++-- 1

Re: testing io.low limit for blk-throttle

> Il giorno 26 apr 2018, alle ore 20:32, Tejun Heo <t...@kernel.org> ha scritto: > > Hello, > > On Tue, Apr 24, 2018 at 02:12:51PM +0200, Paolo Valente wrote: >> +Tejun (I guess he might be interested in the results below) > > Our experiments didn't work ou

Re: testing io.low limit for blk-throttle

> Il giorno 26 apr 2018, alle ore 20:32, Tejun Heo ha scritto: > > Hello, > > On Tue, Apr 24, 2018 at 02:12:51PM +0200, Paolo Valente wrote: >> +Tejun (I guess he might be interested in the results below) > > Our experiments didn't work out too well either. At t

Re: testing io.low limit for blk-throttle

> Il giorno 27 apr 2018, alle ore 05:27, Joseph Qi <jiangqi...@gmail.com> ha > scritto: > > Hi Paolo, > > On 18/4/27 01:27, Paolo Valente wrote: >> >> >>> Il giorno 25 apr 2018, alle ore 14:13, Joseph Qi <jiangqi...@gmail.com> ha &g

Re: testing io.low limit for blk-throttle

> Il giorno 27 apr 2018, alle ore 05:27, Joseph Qi ha > scritto: > > Hi Paolo, > > On 18/4/27 01:27, Paolo Valente wrote: >> >> >>> Il giorno 25 apr 2018, alle ore 14:13, Joseph Qi ha >>> scritto: >>> >>> Hi Paolo, &g

Re: testing io.low limit for blk-throttle

> Il giorno 23 apr 2018, alle ore 11:01, Joseph Qi <jiangqi...@gmail.com> ha > scritto: > > > > On 18/4/23 15:35, Paolo Valente wrote: >> >> >>> Il giorno 23 apr 2018, alle ore 08:05, Joseph Qi <jiangqi...@gmail.com> ha >>

Re: testing io.low limit for blk-throttle

> Il giorno 23 apr 2018, alle ore 11:01, Joseph Qi ha > scritto: > > > > On 18/4/23 15:35, Paolo Valente wrote: >> >> >>> Il giorno 23 apr 2018, alle ore 08:05, Joseph Qi ha >>> scritto: >>> >>> Hi Paolo, >> >

Re: usercopy whitelist woe in scsi_sense_cache

> Il giorno 20 apr 2018, alle ore 22:23, Kees Cook <keesc...@chromium.org> ha > scritto: > > On Thu, Apr 19, 2018 at 2:32 AM, Paolo Valente <paolo.vale...@linaro.org> > wrote: >> I'm missing something here. When the request gets complete

Re: usercopy whitelist woe in scsi_sense_cache

> Il giorno 20 apr 2018, alle ore 22:23, Kees Cook ha > scritto: > > On Thu, Apr 19, 2018 at 2:32 AM, Paolo Valente > wrote: >> I'm missing something here. When the request gets completed in the >> first place, the hook bfq_finish_requeue_request gets called, a

Re: usercopy whitelist woe in scsi_sense_cache

> Il giorno 18 apr 2018, alle ore 16:30, Jens Axboe <ax...@kernel.dk> ha > scritto: > > On 4/18/18 3:08 AM, Paolo Valente wrote: >> >> >>> Il giorno 18 apr 2018, alle ore 00:57, Jens Axboe <ax...@kernel.dk> ha >>> scritto: >>>

Re: usercopy whitelist woe in scsi_sense_cache

> Il giorno 18 apr 2018, alle ore 16:30, Jens Axboe ha > scritto: > > On 4/18/18 3:08 AM, Paolo Valente wrote: >> >> >>> Il giorno 18 apr 2018, alle ore 00:57, Jens Axboe ha >>> scritto: >>> >>> On 4/17/18 3:48 PM, Jens Axboe w

Re: [PATCH] blkcg: not hold blkcg lock when deactivating policy.

oblems with bfq, >> being the latter not protected by the queue lock as cfq? > Checked the bfq code, bfq seems never used blkcg lock derectly, and > update of blkg in the common code is protected by both queue and > blkcg locks, so IMHO this patch would not introduce any new problem > with b

Re: [PATCH] blkcg: not hold blkcg lock when deactivating policy.

ng the latter not protected by the queue lock as cfq? > Checked the bfq code, bfq seems never used blkcg lock derectly, and > update of blkg in the common code is protected by both queue and > blkcg locks, so IMHO this patch would not introduce any new problem > with bfq, even though bfq is not pro

Re: usercopy whitelist woe in scsi_sense_cache

> Il giorno 18 apr 2018, alle ore 00:57, Jens Axboe ha > scritto: > > On 4/17/18 3:48 PM, Jens Axboe wrote: >> On 4/17/18 3:47 PM, Kees Cook wrote: >>> On Tue, Apr 17, 2018 at 2:39 PM, Jens Axboe wrote: On 4/17/18 3:25 PM, Kees Cook wrote: > On Tue,

Re: usercopy whitelist woe in scsi_sense_cache

> Il giorno 18 apr 2018, alle ore 00:57, Jens Axboe ha > scritto: > > On 4/17/18 3:48 PM, Jens Axboe wrote: >> On 4/17/18 3:47 PM, Kees Cook wrote: >>> On Tue, Apr 17, 2018 at 2:39 PM, Jens Axboe wrote: On 4/17/18 3:25 PM, Kees Cook wrote: > On Tue, Apr 17, 2018 at 1:46 PM, Kees

Re: [PATCH] blk-mq: Clear out elevator private data

> Il giorno 17 apr 2018, alle ore 23:42, Kees Cook ha > scritto: > > Some elevators may not correctly check rq->rq_flags & RQF_ELVPRIV, and > may attempt to read rq->elv fields. When requests got reused, this > caused BFQ to think it already had a bfqq (rq->elv.priv[1])

Re: [PATCH] blk-mq: Clear out elevator private data

> Il giorno 17 apr 2018, alle ore 23:42, Kees Cook ha > scritto: > > Some elevators may not correctly check rq->rq_flags & RQF_ELVPRIV, and > may attempt to read rq->elv fields. When requests got reused, this > caused BFQ to think it already had a bfqq (rq->elv.priv[1]) allocated. Hi Kees,

Re: [PATCH] blkcg: not hold blkcg lock when deactivating policy.

> Il giorno 17 apr 2018, alle ore 09:10, Jiang Biao ha > scritto: > > As described in the comment of blkcg_activate_policy(), > *Update of each blkg is protected by both queue and blkcg locks so > that holding either lock and testing blkcg_policy_enabled() is > always

Re: [PATCH] blkcg: not hold blkcg lock when deactivating policy.

> Il giorno 17 apr 2018, alle ore 09:10, Jiang Biao ha > scritto: > > As described in the comment of blkcg_activate_policy(), > *Update of each blkg is protected by both queue and blkcg locks so > that holding either lock and testing blkcg_policy_enabled() is > always enough for dereferencing

Re: General protection fault with use_blk_mq=1.

> Il giorno 29 mar 2018, alle ore 05:22, Jens Axboe ha > scritto: > > On 3/28/18 9:13 PM, Zephaniah E. Loss-Cutler-Hull wrote: >> On 03/28/2018 06:02 PM, Jens Axboe wrote: >>> On 3/28/18 5:03 PM, Zephaniah E. Loss-Cutler-Hull wrote: I am not subscribed to any of the

Re: General protection fault with use_blk_mq=1.

> Il giorno 29 mar 2018, alle ore 05:22, Jens Axboe ha > scritto: > > On 3/28/18 9:13 PM, Zephaniah E. Loss-Cutler-Hull wrote: >> On 03/28/2018 06:02 PM, Jens Axboe wrote: >>> On 3/28/18 5:03 PM, Zephaniah E. Loss-Cutler-Hull wrote: I am not subscribed to any of the lists on the To list

Re: General protection fault with use_blk_mq=1.

> Il giorno 29 mar 2018, alle ore 03:02, Jens Axboe ha > scritto: > > On 3/28/18 5:03 PM, Zephaniah E. Loss-Cutler-Hull wrote: >> I am not subscribed to any of the lists on the To list here, please CC >> me on any replies. >> >> I am encountering a fairly consistent crash

Re: General protection fault with use_blk_mq=1.

> Il giorno 29 mar 2018, alle ore 03:02, Jens Axboe ha > scritto: > > On 3/28/18 5:03 PM, Zephaniah E. Loss-Cutler-Hull wrote: >> I am not subscribed to any of the lists on the To list here, please CC >> me on any replies. >> >> I am encountering a fairly consistent crash anywhere from 15

[PATCH BUGFIX] block, bfq: lower-bound the estimated peak rate to 1

. Adding and improving comments on the range of rates representable [1] https://www.spinics.net/lists/kernel/msg2739205.html Signed-off-by: Konstantin Khlebnikov <khlebni...@yandex-team.ru> Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> --- block/bfq-io

[PATCH BUGFIX] block, bfq: lower-bound the estimated peak rate to 1

. Adding and improving comments on the range of rates representable [1] https://www.spinics.net/lists/kernel/msg2739205.html Signed-off-by: Konstantin Khlebnikov Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 25 - block/bfq-iosched.h | 2 +- 2 files changed, 25

Re: [PATCH] block, bfq: keep peak_rate estimation within range 1..2^32-1

> Il giorno 26 mar 2018, alle ore 12:28, Konstantin Khlebnikov > <khlebni...@yandex-team.ru> ha scritto: > > > > On 26.03.2018 11:01, Paolo Valente wrote: >>> Il giorno 21 mar 2018, alle ore 00:49, Paolo Valente >>> <paolo.vale...@linaro.org>

Re: [PATCH] block, bfq: keep peak_rate estimation within range 1..2^32-1

> Il giorno 26 mar 2018, alle ore 12:28, Konstantin Khlebnikov > ha scritto: > > > > On 26.03.2018 11:01, Paolo Valente wrote: >>> Il giorno 21 mar 2018, alle ore 00:49, Paolo Valente >>> ha scritto: >>> >>> >>> &g

Re: [PATCH] block, bfq: keep peak_rate estimation within range 1..2^32-1

> Il giorno 21 mar 2018, alle ore 00:49, Paolo Valente > <paolo.vale...@linaro.org> ha scritto: > > > >> Il giorno 20 mar 2018, alle ore 15:41, Konstantin Khlebnikov >> <khlebni...@yandex-team.ru> ha scritto: >> >> On 20.03.2018 06:00, Pa

Re: [PATCH] block, bfq: keep peak_rate estimation within range 1..2^32-1

> Il giorno 21 mar 2018, alle ore 00:49, Paolo Valente > ha scritto: > > > >> Il giorno 20 mar 2018, alle ore 15:41, Konstantin Khlebnikov >> ha scritto: >> >> On 20.03.2018 06:00, Paolo Valente wrote: >>>> Il giorno 19 mar 2018, alle

Re: [PATCH] block, bfq: keep peak_rate estimation within range 1..2^32-1

> Il giorno 20 mar 2018, alle ore 15:41, Konstantin Khlebnikov > <khlebni...@yandex-team.ru> ha scritto: > > On 20.03.2018 06:00, Paolo Valente wrote: >>> Il giorno 19 mar 2018, alle ore 14:28, Konstantin Khlebnikov >>> <khlebni...@yandex-team.ru>

Re: [PATCH] block, bfq: keep peak_rate estimation within range 1..2^32-1

> Il giorno 20 mar 2018, alle ore 15:41, Konstantin Khlebnikov > ha scritto: > > On 20.03.2018 06:00, Paolo Valente wrote: >>> Il giorno 19 mar 2018, alle ore 14:28, Konstantin Khlebnikov >>> ha scritto: >>> >>> On 19.03.2018 09:03, Paolo

Re: [PATCH] block, bfq: keep peak_rate estimation within range 1..2^32-1

> Il giorno 19 mar 2018, alle ore 14:28, Konstantin Khlebnikov > <khlebni...@yandex-team.ru> ha scritto: > > On 19.03.2018 09:03, Paolo Valente wrote: >>> Il giorno 05 mar 2018, alle ore 04:48, Konstantin Khlebnikov >>> <khlebni...@yandex-team.ru&

Re: [PATCH] block, bfq: keep peak_rate estimation within range 1..2^32-1

> Il giorno 19 mar 2018, alle ore 14:28, Konstantin Khlebnikov > ha scritto: > > On 19.03.2018 09:03, Paolo Valente wrote: >>> Il giorno 05 mar 2018, alle ore 04:48, Konstantin Khlebnikov >>> ha scritto: >>> >>> Rate should never overf

<    1   2   3   4   5   6   7   8   9   10   >