Re: [PATCH] block, bfq: keep peak_rate estimation within range 1..2^32-1

> Il giorno 05 mar 2018, alle ore 04:48, Konstantin Khlebnikov > ha scritto: > > Rate should never overflow or become zero because it is used as divider. > This patch accumulates it with saturation. > > Signed-off-by: Konstantin Khlebnikov

Re: [PATCH] block, bfq: keep peak_rate estimation within range 1..2^32-1

> Il giorno 05 mar 2018, alle ore 04:48, Konstantin Khlebnikov > ha scritto: > > Rate should never overflow or become zero because it is used as divider. > This patch accumulates it with saturation. > > Signed-off-by: Konstantin Khlebnikov > --- > block/bfq-iosched.c |8 +--- > 1

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

> Il giorno 24 feb 2018, alle ore 13:05, Ming Lei <ming@redhat.com> ha > scritto: > > On Sat, Feb 24, 2018 at 08:54:31AM +0100, Paolo Valente wrote: >> >> >>> Il giorno 23 feb 2018, alle ore 17:17, Ming Lei <ming@redhat.com> ha >>&g

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

> Il giorno 24 feb 2018, alle ore 13:05, Ming Lei ha > scritto: > > On Sat, Feb 24, 2018 at 08:54:31AM +0100, Paolo Valente wrote: >> >> >>> Il giorno 23 feb 2018, alle ore 17:17, Ming Lei ha >>> scritto: >>> >>> Hi Paolo, >

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

> Il giorno 23 feb 2018, alle ore 17:17, Ming Lei <ming@redhat.com> ha > scritto: > > Hi Paolo, > > On Fri, Feb 23, 2018 at 04:41:36PM +0100, Paolo Valente wrote: >> >> >>> Il giorno 23 feb 2018, alle ore 16:07, Ming Lei <ming...

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

> Il giorno 23 feb 2018, alle ore 17:17, Ming Lei ha > scritto: > > Hi Paolo, > > On Fri, Feb 23, 2018 at 04:41:36PM +0100, Paolo Valente wrote: >> >> >>> Il giorno 23 feb 2018, alle ore 16:07, Ming Lei ha >>> scritto: >>> >&g

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

> Il giorno 23 feb 2018, alle ore 16:07, Ming Lei <ming@redhat.com> ha > scritto: > > Hi Paolo, > > On Wed, Feb 07, 2018 at 10:19:20PM +0100, Paolo Valente wrote: >> Commit 'a6a252e64914 ("blk-mq-sched: decide how to handle flush rq via >> RQF_FLU

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

> Il giorno 23 feb 2018, alle ore 16:07, Ming Lei ha > scritto: > > Hi Paolo, > > On Wed, Feb 07, 2018 at 10:19:20PM +0100, Paolo Valente wrote: >> Commit 'a6a252e64914 ("blk-mq-sched: decide how to handle flush rq via >> RQF_FLUSH_SEQ")' makes all non

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

> Il giorno 10 feb 2018, alle ore 09:29, Oleksandr Natalenko > ha scritto: > > Hi. > > On pátek 9. února 2018 18:29:39 CET Mike Galbraith wrote: >> On Fri, 2018-02-09 at 14:21 +0100, Oleksandr Natalenko wrote: >>> In addition to this I think it should be worth

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

> Il giorno 10 feb 2018, alle ore 09:29, Oleksandr Natalenko > ha scritto: > > Hi. > > On pátek 9. února 2018 18:29:39 CET Mike Galbraith wrote: >> On Fri, 2018-02-09 at 14:21 +0100, Oleksandr Natalenko wrote: >>> In addition to this I think it should be worth considering CC'ing Greg >>> to

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

> Il giorno 07 feb 2018, alle ore 23:18, Jens Axboe <ax...@kernel.dk> ha > scritto: > > On 2/7/18 2:19 PM, Paolo Valente wrote: >> Commit 'a6a252e64914 ("blk-mq-sched: decide how to handle flush rq via >> RQF_FLUSH_SEQ")' makes all non-flush re-prepared

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

> Il giorno 07 feb 2018, alle ore 23:18, Jens Axboe ha > scritto: > > On 2/7/18 2:19 PM, Paolo Valente wrote: >> Commit 'a6a252e64914 ("blk-mq-sched: decide how to handle flush rq via >> RQF_FLUSH_SEQ")' makes all non-flush re-prepared requests for a device &

[PATCH BUGFIX V3] block, bfq: add requeue-request hook

eys <alban.browa...@gmail.com> Tested-by: Mike Galbraith <efa...@gmx.de> Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> Signed-off-by: Serena Ziviani <ziviani.ser...@gmail.com> --- V2: contains fix to bug reported in [2] V3: implements the improvement suggested in [3]

[PATCH BUGFIX V3] block, bfq: add requeue-request hook

Galbraith Signed-off-by: Paolo Valente Signed-off-by: Serena Ziviani --- V2: contains fix to bug reported in [2] V3: implements the improvement suggested in [3] [2] https://lkml.org/lkml/2018/2/5/599 [3] https://lkml.org/lkml/2018/2/7/532 block/bfq-iosch

Re: [PATCH BUGFIX V2 1/1] block, bfq: add requeue-request hook

> Il giorno 07 feb 2018, alle ore 19:06, Jens Axboe <ax...@kernel.dk> ha > scritto: > > On 2/7/18 11:00 AM, Paolo Valente wrote: >> Commit 'a6a252e64914 ("blk-mq-sched: decide how to handle flush rq via >> RQF_FLUSH_SEQ")' makes all non-flush re-prepared

Re: [PATCH BUGFIX V2 1/1] block, bfq: add requeue-request hook

> Il giorno 07 feb 2018, alle ore 19:06, Jens Axboe ha > scritto: > > On 2/7/18 11:00 AM, Paolo Valente wrote: >> Commit 'a6a252e64914 ("blk-mq-sched: decide how to handle flush rq via >> RQF_FLUSH_SEQ")' makes all non-flush re-prepared requests for a device

[PATCH BUGFIX V2 1/1] block, bfq: add requeue-request hook

eys <alban.browa...@gmail.com> Tested-by: Mike Galbraith <efa...@gmx.de> Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> Signed-off-by: Serena Ziviani <ziviani.ser...@gmail.com> --- block/bfq-iosched.c | 109 1 file

[PATCH BUGFIX V2 1/1] block, bfq: add requeue-request hook

Galbraith Signed-off-by: Paolo Valente Signed-off-by: Serena Ziviani --- block/bfq-iosched.c | 109 1 file changed, 84 insertions(+), 25 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 47e6ec7427c4..21e6b9e45638 100644 -

[PATCH BUGFIX V2 0/1] block, bfq: handle requeues of I/O requests

Hi, fixed version, after bug reports and fixes in [1]. Thanks, Paolo [1] https://lkml.org/lkml/2018/2/5/599 Paolo Valente (1): block, bfq: add requeue-request hook block/bfq-iosched.c | 109 1 file changed, 84 insertions(+), 25 deletions

[PATCH BUGFIX V2 0/1] block, bfq: handle requeues of I/O requests

Hi, fixed version, after bug reports and fixes in [1]. Thanks, Paolo [1] https://lkml.org/lkml/2018/2/5/599 Paolo Valente (1): block, bfq: add requeue-request hook block/bfq-iosched.c | 109 1 file changed, 84 insertions(+), 25 deletions

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 07 feb 2018, alle ore 16:50, Oleksandr Natalenko > <oleksa...@natalenko.name> ha scritto: > > Hi. > > 07.02.2018 12:27, Paolo Valente wrote: >> Hi Oleksandr, Holger, >> before I prepare a V2 candidate patch, could you please test my >>

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 07 feb 2018, alle ore 16:50, Oleksandr Natalenko > ha scritto: > > Hi. > > 07.02.2018 12:27, Paolo Valente wrote: >> Hi Oleksandr, Holger, >> before I prepare a V2 candidate patch, could you please test my >> instrumentation patch too, w

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 07 feb 2018, alle ore 12:03, Mike Galbraith <efa...@gmx.de> ha > scritto: > > On Wed, 2018-02-07 at 11:27 +0100, Paolo Valente wrote: >> >> 2. Could you please turn that BUG_ON into: >> if (!(rq->rq_flags & RQF_ELVPRIV)) >>

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 07 feb 2018, alle ore 12:03, Mike Galbraith ha > scritto: > > On Wed, 2018-02-07 at 11:27 +0100, Paolo Valente wrote: >> >> 2. Could you please turn that BUG_ON into: >> if (!(rq->rq_flags & RQF_ELVPRIV)) >> return; >> and see

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 07 feb 2018, alle ore 11:15, Mike Galbraith <efa...@gmx.de> ha > scritto: > > On Wed, 2018-02-07 at 10:45 +0100, Paolo Valente wrote: >> >>> Il giorno 07 feb 2018, alle ore 10:23, Mike Galbraith <efa...@gmx.de> ha >>> scritto: &

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 07 feb 2018, alle ore 11:15, Mike Galbraith ha > scritto: > > On Wed, 2018-02-07 at 10:45 +0100, Paolo Valente wrote: >> >>> Il giorno 07 feb 2018, alle ore 10:23, Mike Galbraith ha >>> scritto: >>> >>>

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 06 feb 2018, alle ore 19:35, Oleksandr Natalenko > <oleksa...@natalenko.name> ha scritto: > > Hi. > > 06.02.2018 15:50, Paolo Valente wrote: >> Could you please do a >> gdb /block/bfq-iosched.o # or vmlinux.o if bfq is builtin >> list

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 06 feb 2018, alle ore 19:35, Oleksandr Natalenko > ha scritto: > > Hi. > > 06.02.2018 15:50, Paolo Valente wrote: >> Could you please do a >> gdb /block/bfq-iosched.o # or vmlinux.o if bfq is builtin >> list *(bfq_finish_requeue_request

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 06 feb 2018, alle ore 14:40, Holger Hoffstätte > ha scritto: > > > The plot thickens! > Yep, the culprit seems clearer, though ... > Just as I was about to post that I didn't have any problems - because > I didn't have any - I decided to do a

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 06 feb 2018, alle ore 14:40, Holger Hoffstätte > ha scritto: > > > The plot thickens! > Yep, the culprit seems clearer, though ... > Just as I was about to post that I didn't have any problems - because > I didn't have any - I decided to do a second test, activated bfq on my >

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 06 feb 2018, alle ore 15:07, Oleksandr Natalenko > ha scritto: > > Hi. > > 06.02.2018 14:46, Mike Galbraith wrote: >>> Sorry for the noise, but just to make it clear, are we talking about >>> "deadline" or "mq-deadline" now? >> mq-deadline. > > Okay,

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 06 feb 2018, alle ore 15:07, Oleksandr Natalenko > ha scritto: > > Hi. > > 06.02.2018 14:46, Mike Galbraith wrote: >>> Sorry for the noise, but just to make it clear, are we talking about >>> "deadline" or "mq-deadline" now? >> mq-deadline. > > Okay, I've spent a little bit more

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 06 feb 2018, alle ore 13:26, Paolo Valente > <paolo.vale...@linaro.org> ha scritto: > > > >> Il giorno 06 feb 2018, alle ore 12:57, Mike Galbraith <efa...@gmx.de> ha >> scritto: >> >> On Tue, 2018-02-06 at 10:38 +0100, Pa

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 06 feb 2018, alle ore 13:26, Paolo Valente > ha scritto: > > > >> Il giorno 06 feb 2018, alle ore 12:57, Mike Galbraith ha >> scritto: >> >> On Tue, 2018-02-06 at 10:38 +0100, Paolo Valente wrote: >>> >>> Hi Mike, &

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 06 feb 2018, alle ore 12:57, Mike Galbraith <efa...@gmx.de> ha > scritto: > > On Tue, 2018-02-06 at 10:38 +0100, Paolo Valente wrote: >> >> Hi Mike, >> as you can imagine, I didn't get any failure in my pre-submission >> tests on thi

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 06 feb 2018, alle ore 12:57, Mike Galbraith ha > scritto: > > On Tue, 2018-02-06 at 10:38 +0100, Paolo Valente wrote: >> >> Hi Mike, >> as you can imagine, I didn't get any failure in my pre-submission >> tests on this patch. In a

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 06 feb 2018, alle ore 08:56, Mike Galbraith ha > scritto: > > On Tue, 2018-02-06 at 08:44 +0100, Oleksandr Natalenko wrote: >> Hi, Paolo. >> >> I can confirm that this patch fixes cfdisk hang for me. I've also tried >> to trigger the issue Mike has encountered,

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 06 feb 2018, alle ore 08:56, Mike Galbraith ha > scritto: > > On Tue, 2018-02-06 at 08:44 +0100, Oleksandr Natalenko wrote: >> Hi, Paolo. >> >> I can confirm that this patch fixes cfdisk hang for me. I've also tried >> to trigger the issue Mike has encountered, but with no luck

Re: v4.15 and I/O hang with BFQ

> Il giorno 30 gen 2018, alle ore 16:40, Paolo Valente > <paolo.vale...@linaro.org> ha scritto: > > > >> Il giorno 30 gen 2018, alle ore 15:40, Ming Lei <ming@redhat.com> ha >> scritto: >> >> On Tue, Jan 30, 2018 at

Re: v4.15 and I/O hang with BFQ

> Il giorno 30 gen 2018, alle ore 16:40, Paolo Valente > ha scritto: > > > >> Il giorno 30 gen 2018, alle ore 15:40, Ming Lei ha >> scritto: >> >> On Tue, Jan 30, 2018 at 03:30:28PM +0100, Oleksandr Natalenko wrote: >>> Hi. >>>

[PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

eys <alban.browa...@gmail.com> Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> Signed-off-by: Serena Ziviani <ziviani.ser...@gmail.com> --- block/bfq-iosched.c | 101 +++- 1 file changed, 76 insertions(+), 25 deletions(-)

[PATCH BUGFIX 0/1] block, bfq: handle requeues of I/O requests

by the patch. This note is just to point out this unexpected fact (for me), in case it is not intentional. Thanks, Paolo Paolo Valente (1): block, bfq: add requeue-request hook block/bfq-iosched.c | 101 +++- 1 file changed, 76 insertions(+), 25

[PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

quest hook of the active elevator is invoked for these requests, if set. This commit then addresses the above issue by properly implementing the hook requeue_request in BFQ. [1] https://marc.info/?l=linux-block=15127608676 Reported-by: Ivan Kozik Reported-by: Alban Browaeys Signed-off-by: Pao

[PATCH BUGFIX 0/1] block, bfq: handle requeues of I/O requests

by the patch. This note is just to point out this unexpected fact (for me), in case it is not intentional. Thanks, Paolo Paolo Valente (1): block, bfq: add requeue-request hook block/bfq-iosched.c | 101 +++- 1 file changed, 76 insertions(+), 25

Re: v4.15 and I/O hang with BFQ

> Il giorno 30 gen 2018, alle ore 15:40, Ming Lei ha > scritto: > > On Tue, Jan 30, 2018 at 03:30:28PM +0100, Oleksandr Natalenko wrote: >> Hi. >> > ... >> systemd-udevd-271 [000] 4.311033: bfq_insert_requests: insert >> rq->0 >> systemd-udevd-271 [000]

Re: v4.15 and I/O hang with BFQ

> Il giorno 30 gen 2018, alle ore 15:40, Ming Lei ha > scritto: > > On Tue, Jan 30, 2018 at 03:30:28PM +0100, Oleksandr Natalenko wrote: >> Hi. >> > ... >> systemd-udevd-271 [000] 4.311033: bfq_insert_requests: insert >> rq->0 >> systemd-udevd-271 [000] ...1 4.311037:

Re: [PATCH BUGFIX/IMPROVEMENT 0/2] block, bfq: two pending patches

> Il giorno 13 gen 2018, alle ore 12:05, Paolo Valente > <paolo.vale...@linaro.org> ha scritto: > > Hi Jens, > here are again the two pending patches you asked me to resend [1]. One > of them, fixing read-starvation problems, was accompanied by a cover > lett

Re: [PATCH BUGFIX/IMPROVEMENT 0/2] block, bfq: two pending patches

> Il giorno 13 gen 2018, alle ore 12:05, Paolo Valente > ha scritto: > > Hi Jens, > here are again the two pending patches you asked me to resend [1]. One > of them, fixing read-starvation problems, was accompanied by a cover > letter. I'm pasting the content of th

[PATCH BUGFIX/IMPROVEMENT 1/2] block, bfq: limit tags for writes and async I/O

[1] https://github.com/Algodev-github/S Tested-by: Oleksandr Natalenko <oleksa...@natalenko.name> Tested-by: Holger Hoffstätte <hol...@applied-asynchrony.com> Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> --- block/bfq-iosched.c | 77

[PATCH BUGFIX/IMPROVEMENT 1/2] block, bfq: limit tags for writes and async I/O

[1] https://github.com/Algodev-github/S Tested-by: Oleksandr Natalenko Tested-by: Holger Hoffstätte Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 77 + block/bfq-iosched.h | 12 + 2 files changed, 89 insertions(+) diff --git a

[PATCH BUGFIX/IMPROVEMENT 0/2] block, bfq: two pending patches

to the other schedulers. Thanks, Paolo [1] https://www.spinics.net/lists/linux-block/msg21586.html Paolo Valente (2): block, bfq: limit tags for writes and async I/O block, bfq: limit sectors served with interactive weight raising block/bfq-iosched.c | 158

[PATCH BUGFIX/IMPROVEMENT 0/2] block, bfq: two pending patches

to the other schedulers. Thanks, Paolo [1] https://www.spinics.net/lists/linux-block/msg21586.html Paolo Valente (2): block, bfq: limit tags for writes and async I/O block, bfq: limit sectors served with interactive weight raising block/bfq-iosched.c | 158

[PATCH BUGFIX/IMPROVEMENT 2/2] block, bfq: limit sectors served with interactive weight raising

hrony.com> Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> --- block/bfq-iosched.c | 81 +++-- block/bfq-iosched.h | 5 block/bfq-wf2q.c| 3 ++ 3 files changed, 80 insertions(+), 9 deletions(-) diff --git a/block/bfq-ios

[PATCH BUGFIX/IMPROVEMENT 2/2] block, bfq: limit sectors served with interactive weight raising

the allowed weight-raising period finishes. Thus this early ending of weight-raising reduces the amount of time during which these applications cause the problems described above. Tested-by: Oleksandr Natalenko Tested-by: Holger Hoffstätte Signed-off-by: Paolo Valente --- block/bfq-iosched.c

Re: [PATCH IMPROVEMENT] block, bfq: limit sectors served with interactive weight raising

> Il giorno 12 gen 2018, alle ore 11:15, Holger Hoffstätte > <hol...@applied-asynchrony.com> ha scritto: > > On 01/12/18 06:58, Paolo Valente wrote: >> >> >>> Il giorno 28 dic 2017, alle ore 15:00, Holger Hoffstätte >>> <hol...@applied-as

Re: [PATCH IMPROVEMENT] block, bfq: limit sectors served with interactive weight raising

> Il giorno 12 gen 2018, alle ore 11:15, Holger Hoffstätte > ha scritto: > > On 01/12/18 06:58, Paolo Valente wrote: >> >> >>> Il giorno 28 dic 2017, alle ore 15:00, Holger Hoffstätte >>> ha scritto: >>> >>> >>>

Re: [PATCH IMPROVEMENT] block, bfq: limit sectors served with interactive weight raising

> Il giorno 28 dic 2017, alle ore 15:00, Holger Hoffstätte > <hol...@applied-asynchrony.com> ha scritto: > > > On 12/28/17 12:19, Paolo Valente wrote: > (snip half a tech report ;) > > So either this or the previous patch ("limit tags for writes

Re: [PATCH IMPROVEMENT] block, bfq: limit sectors served with interactive weight raising

> Il giorno 28 dic 2017, alle ore 15:00, Holger Hoffstätte > ha scritto: > > > On 12/28/17 12:19, Paolo Valente wrote: > (snip half a tech report ;) > > So either this or the previous patch ("limit tags for writes and async I/O" > can lead to a hard,

[PATCH BUGFIX 0/1] bloc, bfq: fix of a bug introduced by my last patch

nks, Paolo Paolo Valente (1): block, bfq: compile group put for oom queue only if BFQ_GROUP_IOSCHED is set block/bfq-iosched.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.15.1

[PATCH BUGFIX 0/1] bloc, bfq: fix of a bug introduced by my last patch

nks, Paolo Paolo Valente (1): block, bfq: compile group put for oom queue only if BFQ_GROUP_IOSCHED is set block/bfq-iosched.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.15.1

[PATCH BUGFIX 1/1] block, bfq: compile group put for oom queue only if BFQ_GROUP_IOSCHED is set

f to root group on exit") Reported-by: Jan Alexander Steffens <jan.steff...@gmail.com> Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> --- block/bfq-iosched.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index c

[PATCH BUGFIX 1/1] block, bfq: compile group put for oom queue only if BFQ_GROUP_IOSCHED is set

f to root group on exit") Reported-by: Jan Alexander Steffens Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index c56a495af2e8..93a97a7fe519 100644 --- a/block/bfq-iosch

Re: [PATCH BUGFIX V2 1/2] block, bfq: put async queues for root bfq groups too

> Il giorno 10 gen 2018, alle ore 02:41, Guoqing Jiang <gqji...@suse.com> ha > scritto: > > > > On 01/09/2018 05:27 PM, Paolo Valente wrote: >> For each pair [device for which bfq is selected as I/O scheduler, >> group in blkio/io], bfq maintains a corre

Re: [PATCH BUGFIX V2 1/2] block, bfq: put async queues for root bfq groups too

> Il giorno 10 gen 2018, alle ore 02:41, Guoqing Jiang ha > scritto: > > > > On 01/09/2018 05:27 PM, Paolo Valente wrote: >> For each pair [device for which bfq is selected as I/O scheduler, >> group in blkio/io], bfq maintains a corresponding bfq group. E

Re: unify the interface of the proportional-share policy in blkio/io

> Il giorno 09 gen 2018, alle ore 20:53, Jens Axboe <ax...@kernel.dk> ha > scritto: > > On 1/9/18 12:52 PM, Tejun Heo wrote: >> Hello, Paolo. >> >> On Thu, Jan 04, 2018 at 08:00:02PM +0100, Paolo Valente wrote: >>> The solution for the second typ

Re: unify the interface of the proportional-share policy in blkio/io

> Il giorno 09 gen 2018, alle ore 20:53, Jens Axboe ha > scritto: > > On 1/9/18 12:52 PM, Tejun Heo wrote: >> Hello, Paolo. >> >> On Thu, Jan 04, 2018 at 08:00:02PM +0100, Paolo Valente wrote: >>> The solution for the second type of parame

[PATCH BUGFIX V2 1/2] block, bfq: put async queues for root bfq groups too

com> Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> --- block/bfq-cgroup.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c index da1525ec4c87..d819dc77fe65 100644 --- a/block/bfq-cgroup.c +++ b/block/bfq-cgr

[PATCH BUGFIX V2 1/2] block, bfq: put async queues for root bfq groups too

for a root group. This commit fixes bfq_pd_offline so that the latter executes the above missing operations for a root group too. Reported-by: Holger Hoffstätte Reported-by: Guoqing Jiang Signed-off-by: Davide Ferrari Signed-off-by: Paolo Valente --- block/bfq-cgroup.c | 7 +-- 1 file changed, 5

[PATCH BUGFIX V2 0/2] block, bfq: fix two memory leaks related to cgroups

Paolo Valente (2): block, bfq: put async queues for root bfq groups too block, bfq: release oom-queue ref to root group on exit block/bfq-cgroup.c | 7 +-- block/bfq-iosched.c | 3 +++ 2 files changed, 8 insertions(+), 2 deletions(-) -- 2.15.1

[PATCH BUGFIX V2 0/2] block, bfq: fix two memory leaks related to cgroups

Paolo Valente (2): block, bfq: put async queues for root bfq groups too block, bfq: release oom-queue ref to root group on exit block/bfq-cgroup.c | 7 +-- block/bfq-iosched.c | 3 +++ 2 files changed, 8 insertions(+), 2 deletions(-) -- 2.15.1

[PATCH BUGFIX V2 2/2] block, bfq: release oom-queue ref to root group on exit

Ferrari <davideferra...@gmail.com> Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> --- block/bfq-iosched.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index ea48b5c8f088..c56a495af2e8 100644 --- a/block/bfq-iosched.c +++ b/block/b

[PATCH BUGFIX V2 2/2] block, bfq: release oom-queue ref to root group on exit

Ferrari Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index ea48b5c8f088..c56a495af2e8 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -5015,6 +5015,9 @@ static void bfq_exit_queue

[PATCH BUGFIX 1/2] block, bfq: put async queues for root bfq groups too

com> Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> --- block/bfq-cgroup.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c index da1525ec4c87..d819dc77fe65 100644 --- a/block/bfq-cgroup.c +++ b/block/bfq-cgr

[PATCH BUGFIX 1/2] block, bfq: put async queues for root bfq groups too

for a root group. This commit fixes bfq_pd_offline so that the latter executes the above missing operations for a root group too. Reported-by: Holger Hoffstätte Reported-by: Guoqing Jiang Signed-off-by: Davide Ferrari Signed-off-by: Paolo Valente --- block/bfq-cgroup.c | 7 +-- 1 file changed, 5

[PATCH BUGFIX 2/2] bfq-sq, bfq-mq: release oom-queue ref to root group on exit

Ferrari <davideferra...@gmail.com> Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> --- block/bfq-iosched.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index ea48b5c8f088..c56a495af2e8 100644 --- a/block/bfq-iosched.c +++ b/block/b

[PATCH BUGFIX 2/2] bfq-sq, bfq-mq: release oom-queue ref to root group on exit

Ferrari Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index ea48b5c8f088..c56a495af2e8 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -5015,6 +5015,9 @@ static void bfq_exit_queue

[PATCH BUGFIX 0/2] block, bfq: fix two memory leaks related to cgroups

Hi Jens, these two patches fix two related memory leaks, the first reported in [1], and the second found by ourselves while fixing the first. Thanks, Paolo [1] https://www.mail-archive.com/linux-block@vger.kernel.org/msg16258.html Paolo Valente (2): block, bfq: put async queues for root bfq

[PATCH BUGFIX 0/2] block, bfq: fix two memory leaks related to cgroups

Hi Jens, these two patches fix two related memory leaks, the first reported in [1], and the second found by ourselves while fixing the first. Thanks, Paolo [1] https://www.mail-archive.com/linux-block@vger.kernel.org/msg16258.html Paolo Valente (2): block, bfq: put async queues for root bfq

unify the interface of the proportional-share policy in blkio/io

Hi Tejun, Jens, all, the shares of storage resources are controlled through weights in the proportional-share policy of the blkio/io controllers of the cgroups subsystem. But, on blk-mq, this control doesn't work for any legacy application, service or tool. In a similar vein, in most of the

unify the interface of the proportional-share policy in blkio/io

Hi Tejun, Jens, all, the shares of storage resources are controlled through weights in the proportional-share policy of the blkio/io controllers of the cgroups subsystem. But, on blk-mq, this control doesn't work for any legacy application, service or tool. In a similar vein, in most of the

[PATCH IMPROVEMENT] block, bfq: limit sectors served with interactive weight raising

the allowed weight-raising period finishes. Thus this early ending of weight-raising reduces the amount of time during which these applications cause the problems described above. Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> --- block/bfq-iosched.

[PATCH IMPROVEMENT] block, bfq: limit sectors served with interactive weight raising

the allowed weight-raising period finishes. Thus this early ending of weight-raising reduces the amount of time during which these applications cause the problems described above. Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 81

[PATCH IMPROVEMENT/BUGFIX 0/1] block, bfq: address starvation caused by tag consumption

limits, to counter starvation also in cases not covered in kyber_limit_depth. If this solution proves to be effective, I'm willing to port it somehow to the other schedulers. Thanks, Paolo Paolo Valente (1): block, bfq: limit tags for writes and async I/O block/bfq-iosched.c | 77

[PATCH IMPROVEMENT/BUGFIX 0/1] block, bfq: address starvation caused by tag consumption

limits, to counter starvation also in cases not covered in kyber_limit_depth. If this solution proves to be effective, I'm willing to port it somehow to the other schedulers. Thanks, Paolo Paolo Valente (1): block, bfq: limit tags for writes and async I/O block/bfq-iosched.c | 77

[PATCH IMPROVEMENT/BUGFIX 1/1] block, bfq: limit tags for writes and async I/O

[1] https://github.com/Algodev-github/S Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> --- block/bfq-iosched.c | 77 + block/bfq-iosched.h | 12 + 2 files changed, 89 insertions(+) diff --git a/block/bfq-iosched.c b/block/bfq

[PATCH IMPROVEMENT/BUGFIX 1/1] block, bfq: limit tags for writes and async I/O

[1] https://github.com/Algodev-github/S Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 77 + block/bfq-iosched.h | 12 + 2 files changed, 89 insertions(+) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index e33c5c4c9856..6f

Re: severe regression with random I/O from (at least) 4.14?

> Il giorno 21 dic 2017, alle ore 11:57, Paolo Valente > <paolo.vale...@linaro.org> ha scritto: > > Hi, > a few minutes ago I bumped into this apparent severe regression, with > 4.15-rc4 and an SSD PLEXTOR PX-256M5S. If, with none as I/O scheduler, I do > fio

Re: severe regression with random I/O from (at least) 4.14?

> Il giorno 21 dic 2017, alle ore 11:57, Paolo Valente > ha scritto: > > Hi, > a few minutes ago I bumped into this apparent severe regression, with > 4.15-rc4 and an SSD PLEXTOR PX-256M5S. If, with none as I/O scheduler, I do > fio --name=global --rw=randread --size=51

severe regression with random I/O from (at least) 4.14?

Hi, a few minutes ago I bumped into this apparent severe regression, with 4.15-rc4 and an SSD PLEXTOR PX-256M5S. If, with none as I/O scheduler, I do fio --name=global --rw=randread --size=512m --name=job1 I get read : io=524288KB, bw=34402KB/s, iops=8600, runt= 15240msec This device had to

severe regression with random I/O from (at least) 4.14?

Hi, a few minutes ago I bumped into this apparent severe regression, with 4.15-rc4 and an SSD PLEXTOR PX-256M5S. If, with none as I/O scheduler, I do fio --name=global --rw=randread --size=512m --name=job1 I get read : io=524288KB, bw=34402KB/s, iops=8600, runt= 15240msec This device had to

[PATCH IMPROVEMENT] block, bfq: increase threshold to deem I/O as random

raises the threshold to such a higher value. [1] https://github.com/Algodev-github/S Signed-off-by: Angelo Ruocco <angeloruocc...@gmail.com> Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> --- block/bfq-iosched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH IMPROVEMENT] block, bfq: increase threshold to deem I/O as random

raises the threshold to such a higher value. [1] https://github.com/Algodev-github/S Signed-off-by: Angelo Ruocco Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index c66578592c9e

[PATCH IMPROVEMENT/BUGFIX 3/4] block, bfq: let a queue be merged only shortly after starting I/O

makes BFQ stop updating the data needed to handle merging for the queue. Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> Signed-off-by: Angelo Ruocco <angeloruocc...@gmail.com> --- block/bfq-iosched.c | 57 ++--- block/bfq-io

[PATCH IMPROVEMENT/BUGFIX 3/4] block, bfq: let a queue be merged only shortly after starting I/O

makes BFQ stop updating the data needed to handle merging for the queue. Signed-off-by: Paolo Valente Signed-off-by: Angelo Ruocco --- block/bfq-iosched.c | 57 ++--- block/bfq-iosched.h | 2 ++ block/bfq-wf2q.c| 4 3 files changed, 52

[PATCH IMPROVEMENT/BUGFIX 1/4] block, bfq: add missing rq_pos_tree update on rq removal

the queue did not remain empty. This commit adds the missing update. Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> Signed-off-by: Angelo Ruocco <angeloruocc...@gmail.com> --- block/bfq-iosched.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/bfq-iosched.c b/block/b

[PATCH IMPROVEMENT/BUGFIX 4/4] block, bfq: remove superfluous check in queue-merging setup

is also a queue in weight raising for too long to be merged. Accordingly, this commit removes the first check. Signed-off-by: Angelo Ruocco <angeloruocc...@gmail.com> Signed-off-by: Paolo Valente <paolo.vale...@linaro.com> --- block/bfq-iosched.c | 36 +---

[PATCH IMPROVEMENT/BUGFIX 1/4] block, bfq: add missing rq_pos_tree update on rq removal

the queue did not remain empty. This commit adds the missing update. Signed-off-by: Paolo Valente Signed-off-by: Angelo Ruocco --- block/bfq-iosched.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index a9e06217e64d..c6f0b93a769c 100644 --- a/block

[PATCH IMPROVEMENT/BUGFIX 4/4] block, bfq: remove superfluous check in queue-merging setup

r too long to be merged. Accordingly, this commit removes the first check. Signed-off-by: Angelo Ruocco Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 36 +--- 1 file changed, 5 insertions(+), 31 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq

[PATCH IMPROVEMENT/BUGFIX 0/4] remove start-up time outlier caused by wrong detection of cooperating processes

As a first step, I'll propose a fix for BFQ. If the fix is ok, I'm willing to port it to the other schedulers. Thanks, Paolo Angelo Ruocco (2): block, bfq: check low_latency flag in bfq_bfqq_save_state() block, bfq: remove superfluous check in queue-merging setup Paolo Valente (2): block

[PATCH IMPROVEMENT/BUGFIX 2/4] block, bfq: check low_latency flag in bfq_bfqq_save_state()

weight-raised, on queue splits, even if low_latency is off. This commit addresses this problem by adding the missing check. Signed-off-by: Angelo Ruocco <angeloruocc...@gmail.com> Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> --- block/bfq-iosched.c | 3 ++- 1 file changed,

<    1   2   3   4   5   6   7   8   9   10   >