[PATCH IMPROVEMENT/BUGFIX 0/4] remove start-up time outlier caused by wrong detection of cooperating processes

2017-12-20 Thread Paolo Valente
As a first step, I'll propose a fix for BFQ. If the fix is ok, I'm willing to port it to the other schedulers. Thanks, Paolo Angelo Ruocco (2): block, bfq: check low_latency flag in bfq_bfqq_save_state() block, bfq: remove superfluous check in queue-merging setup Paolo Valente (2): block

[PATCH IMPROVEMENT/BUGFIX 2/4] block, bfq: check low_latency flag in bfq_bfqq_save_state()

2017-12-20 Thread Paolo Valente
, even if low_latency is off. This commit addresses this problem by adding the missing check. Signed-off-by: Angelo Ruocco Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index

[PATCH IMPROVEMENT] block, bfq: consider also past I/O in soft real-time detection

2017-12-14 Thread Paolo Valente
from occasional outliers, caused by page-cache-management issues, which are out of the scope of this commit, and cannot be solved by an I/O scheduler). Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> Signed-off-by: Angelo Ruocco <angeloruocc...@gmail.com> --- block/bfq-ios

[PATCH IMPROVEMENT] block, bfq: consider recent past to reduce soft-real-time false positives

2017-12-14 Thread Paolo Valente
, Paolo Paolo Valente (1): block, bfq: consider also past I/O in soft real-time detection block/bfq-iosched.c | 115 1 file changed, 81 insertions(+), 34 deletions(-) -- 2.10.0

[PATCH IMPROVEMENT] block, bfq: consider also past I/O in soft real-time detection

2017-12-14 Thread Paolo Valente
from occasional outliers, caused by page-cache-management issues, which are out of the scope of this commit, and cannot be solved by an I/O scheduler). Signed-off-by: Paolo Valente Signed-off-by: Angelo Ruocco --- block/bfq-iosched.c | 115 1

[PATCH IMPROVEMENT] block, bfq: consider recent past to reduce soft-real-time false positives

2017-12-14 Thread Paolo Valente
, Paolo Paolo Valente (1): block, bfq: consider also past I/O in soft real-time detection block/bfq-iosched.c | 115 1 file changed, 81 insertions(+), 34 deletions(-) -- 2.10.0

Re: [PATCH V2] block, bfq: remove batches of confusing ifdefs

2017-12-13 Thread Paolo Valente
Hi Jens, do you think this version could be ok? Thanks, Paolo > Il giorno 04 dic 2017, alle ore 11:42, Paolo Valente > <paolo.vale...@linaro.org> ha scritto: > > Commit a33801e8b473 ("block, bfq: move debug blkio stats behind > CONFIG_DEBUG_BLK_CGROUP") intr

Re: [PATCH V2] block, bfq: remove batches of confusing ifdefs

2017-12-13 Thread Paolo Valente
Hi Jens, do you think this version could be ok? Thanks, Paolo > Il giorno 04 dic 2017, alle ore 11:42, Paolo Valente > ha scritto: > > Commit a33801e8b473 ("block, bfq: move debug blkio stats behind > CONFIG_DEBUG_BLK_CGROUP") introduced two batches of confusing ifd

[PATCH V2] block, bfq: remove batches of confusing ifdefs

2017-12-04 Thread Paolo Valente
ists/linux-block/msg20043.html Fixes: a33801e8b473 ("block, bfq: move debug blkio stats behind CONFIG_DEBUG_BLK_CGROUP") Reported-by: Linus Torvalds <torva...@linux-foundation.org> Tested-by: Luca Miccio <lucmic...@gmail.com> Signed-off-by: Paolo Valente <paolo.vale...@l

[PATCH V2] block, bfq: remove batches of confusing ifdefs

2017-12-04 Thread Paolo Valente
ists/linux-block/msg20043.html Fixes: a33801e8b473 ("block, bfq: move debug blkio stats behind CONFIG_DEBUG_BLK_CGROUP") Reported-by: Linus Torvalds Tested-by: Luca Miccio Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 127 +---

Re: [PATCH] block, bfq: remove batches of confusing ifdefs

2017-12-02 Thread Paolo Valente
> Il giorno 02 dic 2017, alle ore 17:06, Jens Axboe <ax...@kernel.dk> ha > scritto: > > On 12/02/2017 03:04 AM, Paolo Valente wrote: >> >>> Il giorno 30 nov 2017, alle ore 22:21, Jens Axboe <ax...@kernel.dk> ha >>> scritto: >>> >

Re: [PATCH] block, bfq: remove batches of confusing ifdefs

2017-12-02 Thread Paolo Valente
> Il giorno 02 dic 2017, alle ore 17:06, Jens Axboe ha > scritto: > > On 12/02/2017 03:04 AM, Paolo Valente wrote: >> >>> Il giorno 30 nov 2017, alle ore 22:21, Jens Axboe ha >>> scritto: >>> >>> On 11/28/2017 02:37 AM, Paolo Valente wr

Re: [PATCH] block, bfq: remove batches of confusing ifdefs

2017-12-02 Thread Paolo Valente
> Il giorno 30 nov 2017, alle ore 22:21, Jens Axboe <ax...@kernel.dk> ha > scritto: > > On 11/28/2017 02:37 AM, Paolo Valente wrote: >> Commit a33801e8b473 ("block, bfq: move debug blkio stats behind >> CONFIG_DEBUG_BLK_CGROUP") introduced two batches of

Re: [PATCH] block, bfq: remove batches of confusing ifdefs

2017-12-02 Thread Paolo Valente
> Il giorno 30 nov 2017, alle ore 22:21, Jens Axboe ha > scritto: > > On 11/28/2017 02:37 AM, Paolo Valente wrote: >> Commit a33801e8b473 ("block, bfq: move debug blkio stats behind >> CONFIG_DEBUG_BLK_CGROUP") introduced two batches of confusing ifdefs: >

[PATCH] block, bfq: remove batches of confusing ifdefs

2017-11-28 Thread Paolo Valente
ists/linux-block/msg20043.html Fixes: a33801e8b473 ("block, bfq: move debug blkio stats behind CONFIG_DEBUG_BLK_CGROUP") Reported-by: Linus Torvalds <torva...@linux-foundation.org> Tested-by: Luca Miccio <lucmic...@gmail.com> Signed-off-by: Paolo Valente <paolo.vale...@l

[PATCH] block, bfq: remove batches of confusing ifdefs

2017-11-28 Thread Paolo Valente
ists/linux-block/msg20043.html Fixes: a33801e8b473 ("block, bfq: move debug blkio stats behind CONFIG_DEBUG_BLK_CGROUP") Reported-by: Linus Torvalds Tested-by: Luca Miccio Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 127 +---

[PATCH IMPROVEMENT/BUGFIX 0/4] block, bfq: increase sustainable IOPS and fix a bug

2017-11-12 Thread Paolo Valente
github.com/Algodev-github/IOSpeed Luca Miccio (2): block, bfq: add missing invocations of bfqg_stats_update_io_add/remove block, bfq: move debug blkio stats behind CONFIG_DEBUG_BLK_CGROUP Paolo Valente (2): doc, block, bfq: update max IOPS sustainable with BFQ block, bfq: update blkio sta

[PATCH BUGFIX/IMPROVEMENT 2/4] block, bfq: add missing invocations of bfqg_stats_update_io_add/remove

2017-11-12 Thread Paolo Valente
invoke these functions for requests that are inserted into or extracted from its priority dispatch list. This commit fixes this mistake. Tested-by: Lee Tibbert <lee.tibb...@gmail.com> Tested-by: Oleksandr Natalenko <oleksa...@natalenko.name> Signed-off-by: Paolo Valente <paolo.vale...@l

[PATCH IMPROVEMENT/BUGFIX 0/4] block, bfq: increase sustainable IOPS and fix a bug

2017-11-12 Thread Paolo Valente
github.com/Algodev-github/IOSpeed Luca Miccio (2): block, bfq: add missing invocations of bfqg_stats_update_io_add/remove block, bfq: move debug blkio stats behind CONFIG_DEBUG_BLK_CGROUP Paolo Valente (2): doc, block, bfq: update max IOPS sustainable with BFQ block, bfq: update blkio sta

[PATCH BUGFIX/IMPROVEMENT 2/4] block, bfq: add missing invocations of bfqg_stats_update_io_add/remove

2017-11-12 Thread Paolo Valente
that are inserted into or extracted from its priority dispatch list. This commit fixes this mistake. Tested-by: Lee Tibbert Tested-by: Oleksandr Natalenko Signed-off-by: Paolo Valente Signed-off-by: Luca Miccio --- block/bfq-iosched.c | 21 ++--- 1 file changed, 18 insertions

[PATCH BUGFIX/IMPROVEMENT 4/4] block, bfq: move debug blkio stats behind CONFIG_DEBUG_BLK_CGROUP

2017-11-12 Thread Paolo Valente
sted-by: Ulf Hansson <ulf.hans...@linaro.org> Tested-by: Lee Tibbert <lee.tibb...@gmail.com> Tested-by: Oleksandr Natalenko <oleksa...@natalenko.name> Signed-off-by: Luca Miccio <lucmic...@gmail.com> Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> --- Documentation/bl

[PATCH BUGFIX/IMPROVEMENT 4/4] block, bfq: move debug blkio stats behind CONFIG_DEBUG_BLK_CGROUP

2017-11-12 Thread Paolo Valente
-by: Oleksandr Natalenko Signed-off-by: Luca Miccio Signed-off-by: Paolo Valente --- Documentation/block/bfq-iosched.txt | 38 +++-- block/bfq-cgroup.c | 148 block/bfq-iosched.c | 14 ++-- block/bfq-iosched.h

[PATCH BUGFIX/IMPROVEMENT 1/4] doc, block, bfq: update max IOPS sustainable with BFQ

2017-11-12 Thread Paolo Valente
<lee.tibb...@gmail.com> Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> Signed-off-by: Luca Miccio <lucmic...@gmail.com> --- Documentation/block/bfq-iosched.txt | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/Documentation/block/

[PATCH BUGFIX/IMPROVEMENT 1/4] doc, block, bfq: update max IOPS sustainable with BFQ

2017-11-12 Thread Paolo Valente
Signed-off-by: Paolo Valente Signed-off-by: Luca Miccio --- Documentation/block/bfq-iosched.txt | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/Documentation/block/bfq-iosched.txt b/Documentation/block/bfq-iosched.txt index 3d6951d..7a93615 100644

[PATCH BUGFIX/IMPROVEMENT 3/4] block, bfq: update blkio stats outside the scheduler lock

2017-11-12 Thread Paolo Valente
, by difference, that the serialization caused by this lock has a little impact (at most ~5% of throughput reduction). [1] https://github.com/Algodev-github/IOSpeed Tested-by: Lee Tibbert <lee.tibb...@gmail.com> Tested-by: Oleksandr Natalenko <oleksa...@natalenko.name> Signed-off-by: Paolo Valente

[PATCH BUGFIX/IMPROVEMENT 3/4] block, bfq: update blkio stats outside the scheduler lock

2017-11-12 Thread Paolo Valente
, by difference, that the serialization caused by this lock has a little impact (at most ~5% of throughput reduction). [1] https://github.com/Algodev-github/IOSpeed Tested-by: Lee Tibbert Tested-by: Oleksandr Natalenko Signed-off-by: Paolo Valente Signed-off-by: Luca Miccio --- Documentation/block/bfq

Re: [PATCH V5 00/14] blk-mq-sched: improve sequential I/O performance(part 1)

2017-10-10 Thread Paolo Valente
> Il giorno 10 ott 2017, alle ore 14:34, Johannes Thumshirn > ha scritto: > > Hi John, > > On Tue, Oct 10, 2017 at 01:24:52PM +0100, John Garry wrote: >> It's using cfq (for non-mq) and mq-deadline (obviously for mq). > > Please be aware that cfq and mq-deadline are _not_

Re: [PATCH V5 00/14] blk-mq-sched: improve sequential I/O performance(part 1)

2017-10-10 Thread Paolo Valente
> Il giorno 10 ott 2017, alle ore 14:34, Johannes Thumshirn > ha scritto: > > Hi John, > > On Tue, Oct 10, 2017 at 01:24:52PM +0100, John Garry wrote: >> It's using cfq (for non-mq) and mq-deadline (obviously for mq). > > Please be aware that cfq and mq-deadline are _not_ comparable, for a

[PATCH BUGFIX] block, bfq: fix bug related to the burst_size counter

2017-10-09 Thread Paolo Valente
fix right after the patch introducing the bug. Thanks, Paolo [1] https://lkml.org/lkml/2017/9/21/144 Paolo Valente (1): block, bfq: fix unbalanced decrements of burst size block/bfq-iosched.c | 59 +++-- 1 file changed, 57 insertions(+), 2

[PATCH BUGFIX] block, bfq: fix unbalanced decrements of burst size

2017-10-09 Thread Paolo Valente
e is sync, performed before checking whether the bfq_queue is in the burst list. This extra check is redundant, because only sync bfq_queues can be inserted into the burst list. Reported-by: Philip Müller <ph...@manjaro.org> Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> Signed-of

[PATCH BUGFIX] block, bfq: fix bug related to the burst_size counter

2017-10-09 Thread Paolo Valente
fix right after the patch introducing the bug. Thanks, Paolo [1] https://lkml.org/lkml/2017/9/21/144 Paolo Valente (1): block, bfq: fix unbalanced decrements of burst size block/bfq-iosched.c | 59 +++-- 1 file changed, 57 insertions(+), 2

[PATCH BUGFIX] block, bfq: fix unbalanced decrements of burst size

2017-10-09 Thread Paolo Valente
e is sync, performed before checking whether the bfq_queue is in the burst list. This extra check is redundant, because only sync bfq_queues can be inserted into the burst list. Reported-by: Philip Müller Signed-off-by: Paolo Valente Signed-off-by: Angelo Ruocco Tested-by: Philip Müller Tested-by:

Re: [PATCH V6 00/18] blk-throttle: add .low limit

2017-09-22 Thread Paolo Valente
> Il giorno 05 set 2017, alle ore 23:02, Shaohua Li <s...@kernel.org> ha > scritto: > > On Thu, Aug 31, 2017 at 09:24:23AM +0200, Paolo VALENTE wrote: >> >>> Il giorno 15 gen 2017, alle ore 04:42, Shaohua Li <s...@fb.com> ha scritto: >>> >>

Re: [PATCH V6 00/18] blk-throttle: add .low limit

2017-09-22 Thread Paolo Valente
> Il giorno 05 set 2017, alle ore 23:02, Shaohua Li ha > scritto: > > On Thu, Aug 31, 2017 at 09:24:23AM +0200, Paolo VALENTE wrote: >> >>> Il giorno 15 gen 2017, alle ore 04:42, Shaohua Li ha scritto: >>> >>> Hi, >>> >>> cgrou

[PATCH BUGFIX/IMPROVEMENT 2/4] block, bfq: check and switch back to interactive wr also on queue split

2017-09-21 Thread Paolo Valente
ive weight-raising period. This commit addresses this issue by adding the above missing check in bfq_queue splits, and restoring interactive weight raising if needed. Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> Tested-by: Angelo Ruocco <angeloruocc...@gmail.com> Test

[PATCH BUGFIX/IMPROVEMENT 2/4] block, bfq: check and switch back to interactive wr also on queue split

2017-09-21 Thread Paolo Valente
ive weight-raising period. This commit addresses this issue by adding the above missing check in bfq_queue splits, and restoring interactive weight raising if needed. Signed-off-by: Paolo Valente Tested-by: Angelo Ruocco Tested-by: Mirko Montanari Tested-by: Oleksandr Natalenko --- block/bfq-iosc

[PATCH BUGFIX/IMPROVEMENT 4/4] block, bfq: decrease burst size when queues in burst exit

2017-09-21 Thread Paolo Valente
decrease, relying of the fact that upstart is apparently unlikely to be used on systems running this and future versions of the kernel. Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> Signed-off-by: Mauro Andreolini <mauro.andreol...@unimore.it> Signed-off-by: Angelo Ruocco

[PATCH BUGFIX/IMPROVEMENT 1/4] block, bfq: fix wrong init of saved start time for weight raising

2017-09-21 Thread Paolo Valente
-Laptop Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> Signed-off-by: Angelo Ruocco <angeloruocc...@gmail.com> Tested-by: Oleksandr Natalenko <oleksa...@natalenko.name> Tested-by: Lee Tibbert <lee.tibb...@gmail.com> Tested-by: Mirko Montanari <mirkomontanar..

[PATCH BUGFIX/IMPROVEMENT 4/4] block, bfq: decrease burst size when queues in burst exit

2017-09-21 Thread Paolo Valente
decrease, relying of the fact that upstart is apparently unlikely to be used on systems running this and future versions of the kernel. Signed-off-by: Paolo Valente Signed-off-by: Mauro Andreolini Signed-off-by: Angelo Ruocco Tested-by: Mirko Montanari Tested-by: Oleksandr Natalenko --- block

[PATCH BUGFIX/IMPROVEMENT 1/4] block, bfq: fix wrong init of saved start time for weight raising

2017-09-21 Thread Paolo Valente
-Laptop Signed-off-by: Paolo Valente Signed-off-by: Angelo Ruocco Tested-by: Oleksandr Natalenko Tested-by: Lee Tibbert Tested-by: Mirko Montanari --- block/bfq-iosched.c | 50 +++--- 1 file changed, 31 insertions(+), 19 deletions(-) diff --git

[PATCH BUGFIX/IMPROVEMENT 3/4] block, bfq: let early-merged queues be weight-raised on split too

2017-09-21 Thread Paolo Valente
have been assigned to the bfq_queue if not early-merged. Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> Tested-by: Angelo Ruocco <angeloruocc...@gmail.com> Tested-by: Mirko Montanari <mirkomontanar...@gmail.com> Tested-by: Oleksandr Natalenko <oleksa...@natalenko

[PATCH BUGFIX/IMPROVEMENT 3/4] block, bfq: let early-merged queues be weight-raised on split too

2017-09-21 Thread Paolo Valente
have been assigned to the bfq_queue if not early-merged. Signed-off-by: Paolo Valente Tested-by: Angelo Ruocco Tested-by: Mirko Montanari Tested-by: Oleksandr Natalenko --- block/bfq-iosched.c | 28 +++- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/block

[PATCH BUGFIX/IMPROVEMENT 0/4] block, bfq: series of fixes of bugs affecting service guarantees

2017-09-21 Thread Paolo Valente
, Paolo [1] Background I/O Type: Random - Background I/O mix: Reads and writes - Application to start: LibreOffice Writer in http://www.phoronix.com/scan.php?page=news_item=Linux-4.13-IO-Laptop Paolo Valente (4): block, bfq: fix wrong init of saved start time for weight raising block, bfq

[PATCH BUGFIX/IMPROVEMENT 0/4] block, bfq: series of fixes of bugs affecting service guarantees

2017-09-21 Thread Paolo Valente
, Paolo [1] Background I/O Type: Random - Background I/O mix: Reads and writes - Application to start: LibreOffice Writer in http://www.phoronix.com/scan.php?page=news_item=Linux-4.13-IO-Laptop Paolo Valente (4): block, bfq: fix wrong init of saved start time for weight raising block, bfq

Re: [PATCH] block,bfq: Disable writeback throttling

2017-09-19 Thread Paolo Valente
write-throttling >> heuristics of a different nature. >> So this commit disables write-back throttling for a device if BFQ >> is used as I/O scheduler for that device. >> Signed-off-by: Luca Miccio <lucmic...@gmail.com> >> Signed-off-by: Paolo Valente <paolo.vale...@l

Re: [PATCH] block,bfq: Disable writeback throttling

2017-09-19 Thread Paolo Valente
s of a different nature. >> So this commit disables write-back throttling for a device if BFQ >> is used as I/O scheduler for that device. >> Signed-off-by: Luca Miccio >> Signed-off-by: Paolo Valente >> --- >> block/bfq-iosched.c | 3 ++- >> 1 file cha

Re: [PATCH BUGFIX/IMPROVEMENT V2 0/3] three bfq fixes restoring service guarantees with random sync writes in bg

2017-09-04 Thread Paolo Valente
> Il giorno 04 set 2017, alle ore 10:14, Mel Gorman > <mgor...@techsingularity.net> ha scritto: > > On Thu, Aug 31, 2017 at 03:42:57PM +0100, Mel Gorman wrote: >> On Thu, Aug 31, 2017 at 08:46:28AM +0200, Paolo Valente wrote: >>> [SECOND TAKE, with just th

Re: [PATCH BUGFIX/IMPROVEMENT V2 0/3] three bfq fixes restoring service guarantees with random sync writes in bg

2017-09-04 Thread Paolo Valente
> Il giorno 04 set 2017, alle ore 10:14, Mel Gorman > ha scritto: > > On Thu, Aug 31, 2017 at 03:42:57PM +0100, Mel Gorman wrote: >> On Thu, Aug 31, 2017 at 08:46:28AM +0200, Paolo Valente wrote: >>> [SECOND TAKE, with just the name of one of the tester fixed] >

[PATCH BUGFIX/IMPROVEMENT 0/2] doc, block, bfq: improve documentation on how to to properly configure bfq

2017-08-31 Thread Paolo Valente
provides some guidance on this task. The first patch fixes some issues that I have found while working on the file. Thanks, Paolo Paolo Valente (2): doc, block, bfq: fix some typos and remove stale stuff doc, block, bfq: better describe how to properly configure bfq Documentation/block/bfq

[PATCH BUGFIX/IMPROVEMENT 2/2] doc, block, bfq: better describe how to properly configure bfq

2017-08-31 Thread Paolo Valente
parameter descriptions to look at. This commit adds some simple direction. Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> Reviewed-by: Jeremy Hickman <jeremy...@gmail.com> Reviewed-by: Laurentiu Nicola <lnic...@dend.ro> --- Documentation/block/bf

[PATCH BUGFIX/IMPROVEMENT 0/2] doc, block, bfq: improve documentation on how to to properly configure bfq

2017-08-31 Thread Paolo Valente
provides some guidance on this task. The first patch fixes some issues that I have found while working on the file. Thanks, Paolo Paolo Valente (2): doc, block, bfq: fix some typos and remove stale stuff doc, block, bfq: better describe how to properly configure bfq Documentation/block/bfq

[PATCH BUGFIX/IMPROVEMENT 2/2] doc, block, bfq: better describe how to properly configure bfq

2017-08-31 Thread Paolo Valente
parameter descriptions to look at. This commit adds some simple direction. Signed-off-by: Paolo Valente Reviewed-by: Jeremy Hickman Reviewed-by: Laurentiu Nicola --- Documentation/block/bfq-iosched.txt | 78 + 1 file changed, 54 insertions(+), 24 deletions

[PATCH BUGFIX/IMPROVEMENT 1/2] doc, block, bfq: fix some typos and remove stale stuff

2017-08-31 Thread Paolo Valente
In addition to containing some typos and stale sentences, the file bfq-iosched.txt still mentioned a set of sysfs parameters that have been removed from this version of bfq. This commit fixes all these issues. Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> Reviewed-by: Jeremy H

[PATCH BUGFIX/IMPROVEMENT 1/2] doc, block, bfq: fix some typos and remove stale stuff

2017-08-31 Thread Paolo Valente
In addition to containing some typos and stale sentences, the file bfq-iosched.txt still mentioned a set of sysfs parameters that have been removed from this version of bfq. This commit fixes all these issues. Signed-off-by: Paolo Valente Reviewed-by: Jeremy Hickman Reviewed-by: Laurentiu

Re: [PATCH BUGFIX/IMPROVEMENT V2 0/3] three bfq fixes restoring service guarantees with random sync writes in bg

2017-08-31 Thread Paolo Valente
> Il giorno 31 ago 2017, alle ore 19:06, Mike Galbraith <efa...@gmx.de> ha > scritto: > > On Thu, 2017-08-31 at 15:42 +0100, Mel Gorman wrote: >> On Thu, Aug 31, 2017 at 08:46:28AM +0200, Paolo Valente wrote: >>> [SECOND TAKE, with just the name of one

Re: [PATCH BUGFIX/IMPROVEMENT V2 0/3] three bfq fixes restoring service guarantees with random sync writes in bg

2017-08-31 Thread Paolo Valente
> Il giorno 31 ago 2017, alle ore 19:06, Mike Galbraith ha > scritto: > > On Thu, 2017-08-31 at 15:42 +0100, Mel Gorman wrote: >> On Thu, Aug 31, 2017 at 08:46:28AM +0200, Paolo Valente wrote: >>> [SECOND TAKE, with just the name of one of the tester fixed] >

Re: [PATCH V6 00/18] blk-throttle: add .low limit

2017-08-31 Thread Paolo VALENTE
> Il giorno 15 gen 2017, alle ore 04:42, Shaohua Li ha scritto: > > Hi, > > cgroup still lacks a good iocontroller. CFQ works well for hard disk, but not > much for SSD. This patch set try to add a conservative limit for blk-throttle. > It isn't a proportional scheduling, but can

Re: [PATCH V6 00/18] blk-throttle: add .low limit

2017-08-31 Thread Paolo VALENTE
> Il giorno 15 gen 2017, alle ore 04:42, Shaohua Li ha scritto: > > Hi, > > cgroup still lacks a good iocontroller. CFQ works well for hard disk, but not > much for SSD. This patch set try to add a conservative limit for blk-throttle. > It isn't a proportional scheduling, but can help

[PATCH BUGFIX/IMPROVEMENT V2 2/3] block, bfq: remove direct switch to an entity in higher class

2017-08-31 Thread Paolo Valente
to anomalous schedules, because E may happen not be eligible for service, because its virtual start time is higher than the system virtual time for its service tree. This commit addresses this issue by simply removing this direct switch. Signed-off-by: Paolo Valente <paolo.vale...@linaro.org>

[PATCH BUGFIX/IMPROVEMENT V2 2/3] block, bfq: remove direct switch to an entity in higher class

2017-08-31 Thread Paolo Valente
to anomalous schedules, because E may happen not be eligible for service, because its virtual start time is higher than the system virtual time for its service tree. This commit addresses this issue by simply removing this direct switch. Signed-off-by: Paolo Valente Tested-by: Lee Tibbert Tested

[PATCH BUGFIX/IMPROVEMENT V2 0/3] three bfq fixes restoring service guarantees with random sync writes in bg

2017-08-31 Thread Paolo Valente
too), against the above background workload and, probably, against other similar workloads. Thanks, Paolo [1] https://lkml.org/lkml/2017/8/9/957 Paolo Valente (3): block, bfq: make lookup_next_entity push up vtime on expirations block, bfq: remove direct switch to an entity in higher class

[PATCH BUGFIX/IMPROVEMENT V2 0/3] three bfq fixes restoring service guarantees with random sync writes in bg

2017-08-31 Thread Paolo Valente
too), against the above background workload and, probably, against other similar workloads. Thanks, Paolo [1] https://lkml.org/lkml/2017/8/9/957 Paolo Valente (3): block, bfq: make lookup_next_entity push up vtime on expirations block, bfq: remove direct switch to an entity in higher class

[PATCH BUGFIX/IMPROVEMENT V2 3/3] block, bfq: guarantee update_next_in_service always returns an eligible entity

2017-08-31 Thread Paolo Valente
horter path is taken but fails to yield an eligible next-in-service entity. Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> Tested-by: Lee Tibbert <lee.tibb...@gmail.com> Tested-by: Oleksandr Natalenko <oleksa...@natalenko.name> --- block/bfq-wf2q.c | 14

[PATCH BUGFIX/IMPROVEMENT V2 1/3] block, bfq: make lookup_next_entity push up vtime on expirations

2017-08-31 Thread Paolo Valente
to serve after the expiration and the reinsertion into the active trees of the previously in-service entities. This commit addresses this issue by making __bfq_lookup_next_entity properly push up the system virtual time if an expiration is occurring. Signed-off-by: Paolo Valente <paolo.v

[PATCH BUGFIX/IMPROVEMENT V2 3/3] block, bfq: guarantee update_next_in_service always returns an eligible entity

2017-08-31 Thread Paolo Valente
horter path is taken but fails to yield an eligible next-in-service entity. Signed-off-by: Paolo Valente Tested-by: Lee Tibbert Tested-by: Oleksandr Natalenko --- block/bfq-wf2q.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/block/bfq-wf2q.c b/block/bfq-

[PATCH BUGFIX/IMPROVEMENT V2 1/3] block, bfq: make lookup_next_entity push up vtime on expirations

2017-08-31 Thread Paolo Valente
to serve after the expiration and the reinsertion into the active trees of the previously in-service entities. This commit addresses this issue by making __bfq_lookup_next_entity properly push up the system virtual time if an expiration is occurring. Signed-off-by: Paolo Valente Tested-by: Lee

Re: [PATCH BUGFIX/IMPROVEMENT 0/3] three bfq fixes restoring service guarantees with random sync writes in bg

2017-08-31 Thread Paolo Valente
> Il giorno 31 ago 2017, alle ore 08:41, oleksa...@natalenko.name ha scritto: > >> Tested-by: Oleksander Natalenko <oleksa...@natalenko.name> > > I'm "Oleksandr" :). > Sorry, resending ... Paolo > 31.08.2017 08:10, Paolo Valente wrote: >>

Re: [PATCH BUGFIX/IMPROVEMENT 0/3] three bfq fixes restoring service guarantees with random sync writes in bg

2017-08-31 Thread Paolo Valente
> Il giorno 31 ago 2017, alle ore 08:41, oleksa...@natalenko.name ha scritto: > >> Tested-by: Oleksander Natalenko > > I'm "Oleksandr" :). > Sorry, resending ... Paolo > 31.08.2017 08:10, Paolo Valente wrote: >> Hi, >> while testing the r

[PATCH BUGFIX/IMPROVEMENT 1/3] block, bfq: make lookup_next_entity push up vtime on expirations

2017-08-31 Thread Paolo Valente
to serve after the expiration and the reinsertion into the active trees of the previously in-service entities. This commit addresses this issue by making __bfq_lookup_next_entity properly push up the system virtual time if an expiration is occurring. Signed-off-by: Paolo Valente <paolo.v

[PATCH BUGFIX/IMPROVEMENT 1/3] block, bfq: make lookup_next_entity push up vtime on expirations

2017-08-31 Thread Paolo Valente
to serve after the expiration and the reinsertion into the active trees of the previously in-service entities. This commit addresses this issue by making __bfq_lookup_next_entity properly push up the system virtual time if an expiration is occurring. Signed-off-by: Paolo Valente Tested-by: Lee

[PATCH BUGFIX/IMPROVEMENT 3/3] block, bfq: guarantee update_next_in_service always returns an eligible entity

2017-08-31 Thread Paolo Valente
horter path is taken but fails to yield an eligible next-in-service entity. Signed-off-by: Paolo Valente <paolo.vale...@linaro.org> Tested-by: Lee Tibbert <lee.tibb...@gmail.com> Tested-by: Oleksander Natalenko <oleksa...@natalenko.name> --- block/bfq-wf2q.c | 14

[PATCH BUGFIX/IMPROVEMENT 3/3] block, bfq: guarantee update_next_in_service always returns an eligible entity

2017-08-31 Thread Paolo Valente
horter path is taken but fails to yield an eligible next-in-service entity. Signed-off-by: Paolo Valente Tested-by: Lee Tibbert Tested-by: Oleksander Natalenko --- block/bfq-wf2q.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/block/bfq-wf2q.c b/block/bfq-

[PATCH BUGFIX/IMPROVEMENT 2/3] block, bfq: remove direct switch to an entity in higher class

2017-08-31 Thread Paolo Valente
to anomalous schedules, because E may happen not be eligible for service, because its virtual start time is higher than the system virtual time for its service tree. This commit addresses this issue by simply removing this direct switch. Signed-off-by: Paolo Valente <paolo.vale...@linaro.org>

[PATCH BUGFIX/IMPROVEMENT 2/3] block, bfq: remove direct switch to an entity in higher class

2017-08-31 Thread Paolo Valente
to anomalous schedules, because E may happen not be eligible for service, because its virtual start time is higher than the system virtual time for its service tree. This commit addresses this issue by simply removing this direct switch. Signed-off-by: Paolo Valente Tested-by: Lee Tibbert Tested

[PATCH BUGFIX/IMPROVEMENT 0/3] three bfq fixes restoring service guarantees with random sync writes in bg

2017-08-31 Thread Paolo Valente
, against other similar workloads. Thanks, Paolo [1] https://lkml.org/lkml/2017/8/9/957 Paolo Valente (3): block, bfq: make lookup_next_entity push up vtime on expirations block, bfq: remove direct switch to an entity in higher class block, bfq: guarantee update_next_in_service always returns

[PATCH BUGFIX/IMPROVEMENT 0/3] three bfq fixes restoring service guarantees with random sync writes in bg

2017-08-31 Thread Paolo Valente
, against other similar workloads. Thanks, Paolo [1] https://lkml.org/lkml/2017/8/9/957 Paolo Valente (3): block, bfq: make lookup_next_entity push up vtime on expirations block, bfq: remove direct switch to an entity in higher class block, bfq: guarantee update_next_in_service always returns

Re: [PATCH BUGFIX/IMPROVEMENT V2 0/2] block, bfq: improve and refactor throughput-boosting logic

2017-08-10 Thread Paolo Valente
> Il giorno 04 ago 2017, alle ore 07:35, Paolo Valente > <paolo.vale...@linaro.org> ha scritto: > > Hi, > these two patches improve throughput-boosting logic in two > aspects. The first patch refactors the parts of the device-idling > logic, related to throughp

Re: [PATCH BUGFIX/IMPROVEMENT V2 0/2] block, bfq: improve and refactor throughput-boosting logic

2017-08-10 Thread Paolo Valente
> Il giorno 04 ago 2017, alle ore 07:35, Paolo Valente > ha scritto: > > Hi, > these two patches improve throughput-boosting logic in two > aspects. The first patch refactors the parts of the device-idling > logic, related to throughput boosting, that are still scattere

Re: Switching to MQ by default may generate some bug reports

2017-08-09 Thread Paolo Valente
> Il giorno 08 ago 2017, alle ore 19:33, Paolo Valente > <paolo.vale...@linaro.org> ha scritto: > >> >> Il giorno 08 ago 2017, alle ore 10:06, Paolo Valente >> <paolo.vale...@linaro.org> ha scritto: >> >>> >>> Il gio

Re: Switching to MQ by default may generate some bug reports

2017-08-09 Thread Paolo Valente
> Il giorno 08 ago 2017, alle ore 19:33, Paolo Valente > ha scritto: > >> >> Il giorno 08 ago 2017, alle ore 10:06, Paolo Valente >> ha scritto: >> >>> >>> Il giorno 07 ago 2017, alle ore 20:42, Paolo Valente >>> ha scritto:

Re: Switching to MQ by default may generate some bug reports

2017-08-08 Thread Paolo Valente
> Il giorno 08 ago 2017, alle ore 10:06, Paolo Valente > <paolo.vale...@linaro.org> ha scritto: > >> >> Il giorno 07 ago 2017, alle ore 20:42, Paolo Valente >> <paolo.vale...@linaro.org> ha scritto: >> >>> >>> Il gio

Re: Switching to MQ by default may generate some bug reports

2017-08-08 Thread Paolo Valente
> Il giorno 08 ago 2017, alle ore 10:06, Paolo Valente > ha scritto: > >> >> Il giorno 07 ago 2017, alle ore 20:42, Paolo Valente >> ha scritto: >> >>> >>> Il giorno 07 ago 2017, alle ore 19:32, Paolo Valente >>> ha scritto:

Re: Switching to MQ by default may generate some bug reports

2017-08-08 Thread Paolo Valente
> Il giorno 08 ago 2017, alle ore 12:30, Mel Gorman > <mgor...@techsingularity.net> ha scritto: > > On Mon, Aug 07, 2017 at 07:32:41PM +0200, Paolo Valente wrote: >>>> global-dhp__io-dbench4-fsync-ext4 was a universal loss across any >>>> machine te

Re: Switching to MQ by default may generate some bug reports

2017-08-08 Thread Paolo Valente
> Il giorno 08 ago 2017, alle ore 12:30, Mel Gorman > ha scritto: > > On Mon, Aug 07, 2017 at 07:32:41PM +0200, Paolo Valente wrote: >>>> global-dhp__io-dbench4-fsync-ext4 was a universal loss across any >>>> machine tested. This is global-dhp__io-dbench

Re: Switching to MQ by default may generate some bug reports

2017-08-08 Thread Paolo Valente
> Il giorno 07 ago 2017, alle ore 20:42, Paolo Valente > <paolo.vale...@linaro.org> ha scritto: > >> >> Il giorno 07 ago 2017, alle ore 19:32, Paolo Valente >> <paolo.vale...@linaro.org> ha scritto: >> >>> >>> Il gio

Re: Switching to MQ by default may generate some bug reports

2017-08-08 Thread Paolo Valente
> Il giorno 07 ago 2017, alle ore 20:42, Paolo Valente > ha scritto: > >> >> Il giorno 07 ago 2017, alle ore 19:32, Paolo Valente >> ha scritto: >> >>> >>> Il giorno 05 ago 2017, alle ore 00:05, Paolo Valente >>> ha scritto

Re: Switching to MQ by default may generate some bug reports

2017-08-07 Thread Paolo Valente
> Il giorno 07 ago 2017, alle ore 19:32, Paolo Valente > <paolo.vale...@linaro.org> ha scritto: > >> >> Il giorno 05 ago 2017, alle ore 00:05, Paolo Valente >> <paolo.vale...@linaro.org> ha scritto: >> >>> >>&g

Re: Switching to MQ by default may generate some bug reports

2017-08-07 Thread Paolo Valente
> Il giorno 07 ago 2017, alle ore 19:32, Paolo Valente > ha scritto: > >> >> Il giorno 05 ago 2017, alle ore 00:05, Paolo Valente >> ha scritto: >> >>> >>> Il giorno 04 ago 2017, alle ore 13:01, Mel Gorman >>> ha scritto: >

Re: Switching to MQ by default may generate some bug reports

2017-08-07 Thread Paolo Valente
> Il giorno 05 ago 2017, alle ore 13:54, Mel Gorman > ha scritto: > ... > >> In addition, as for coverage, we made the empiric assumption that >> start-up time measured with each of the above easy-to-benchmark >> applications gives an idea of the time that it would

Re: Switching to MQ by default may generate some bug reports

2017-08-07 Thread Paolo Valente
> Il giorno 05 ago 2017, alle ore 13:54, Mel Gorman > ha scritto: > ... > >> In addition, as for coverage, we made the empiric assumption that >> start-up time measured with each of the above easy-to-benchmark >> applications gives an idea of the time that it would take with any >> application

Re: Switching to MQ by default may generate some bug reports

2017-08-07 Thread Paolo Valente
> Il giorno 05 ago 2017, alle ore 00:05, Paolo Valente > <paolo.vale...@linaro.org> ha scritto: > >> >> Il giorno 04 ago 2017, alle ore 13:01, Mel Gorman >> <mgor...@techsingularity.net> ha scritto: >> >> On Fri, Aug 04, 2017 at

Re: Switching to MQ by default may generate some bug reports

2017-08-07 Thread Paolo Valente
> Il giorno 05 ago 2017, alle ore 00:05, Paolo Valente > ha scritto: > >> >> Il giorno 04 ago 2017, alle ore 13:01, Mel Gorman >> ha scritto: >> >> On Fri, Aug 04, 2017 at 09:26:20AM +0200, Paolo Valente wrote: >>>> I took tha

Re: Switching to MQ by default may generate some bug reports

2017-08-04 Thread Paolo Valente
> Il giorno 04 ago 2017, alle ore 13:01, Mel Gorman > <mgor...@techsingularity.net> ha scritto: > > On Fri, Aug 04, 2017 at 09:26:20AM +0200, Paolo Valente wrote: >>> I took that into account BFQ with low-latency was also tested and the >>> impact was not a u

Re: Switching to MQ by default may generate some bug reports

2017-08-04 Thread Paolo Valente
> Il giorno 04 ago 2017, alle ore 13:01, Mel Gorman > ha scritto: > > On Fri, Aug 04, 2017 at 09:26:20AM +0200, Paolo Valente wrote: >>> I took that into account BFQ with low-latency was also tested and the >>> impact was not a universal improvement

Re: Switching to MQ by default may generate some bug reports

2017-08-04 Thread Paolo Valente
> Il giorno 03 ago 2017, alle ore 13:01, Mel Gorman > <mgor...@techsingularity.net> ha scritto: > > On Thu, Aug 03, 2017 at 11:21:59AM +0200, Paolo Valente wrote: >>> For Paulo, if you want to try preemptively dealing with regression reports >>> bef

Re: Switching to MQ by default may generate some bug reports

2017-08-04 Thread Paolo Valente
> Il giorno 03 ago 2017, alle ore 13:01, Mel Gorman > ha scritto: > > On Thu, Aug 03, 2017 at 11:21:59AM +0200, Paolo Valente wrote: >>> For Paulo, if you want to try preemptively dealing with regression reports >>> before 4.13 releases then all the tests

[PATCH BUGFIX/IMPROVEMENT V2 1/2] block,bfq: refactor device-idling logic

2017-08-03 Thread Paolo Valente
-by: Paolo Valente <paolo.vale...@linaro.org> --- block/bfq-iosched.c | 117 +++- block/bfq-iosched.h | 12 +++--- 2 files changed, 67 insertions(+), 62 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 436b6ca..ccdc9e6

[PATCH BUGFIX/IMPROVEMENT V2 0/2] block, bfq: improve and refactor throughput-boosting logic

2017-08-03 Thread Paolo Valente
or three random readers in parallel. Thanks, Paolo Paolo Valente (2): block,bfq: refactor device-idling logic block, bfq: boost throughput with flash-based non-queueing devices block/bfq-iosched.c | 144 block/bfq-iosched.h | 12 ++--- 2

[PATCH BUGFIX/IMPROVEMENT V2 1/2] block,bfq: refactor device-idling logic

2017-08-03 Thread Paolo Valente
-by: Paolo Valente --- block/bfq-iosched.c | 117 +++- block/bfq-iosched.h | 12 +++--- 2 files changed, 67 insertions(+), 62 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 436b6ca..ccdc9e6 100644 --- a/block/bfq-iosched.c

[PATCH BUGFIX/IMPROVEMENT V2 0/2] block, bfq: improve and refactor throughput-boosting logic

2017-08-03 Thread Paolo Valente
or three random readers in parallel. Thanks, Paolo Paolo Valente (2): block,bfq: refactor device-idling logic block, bfq: boost throughput with flash-based non-queueing devices block/bfq-iosched.c | 144 block/bfq-iosched.h | 12 ++--- 2

<    1   2   3   4   5   6   7   8   9   10   >