On 2020-12-10 10:05, Madalin Bucur wrote:
-Original Message-
From: Patrick Havelange
[snipped]
But then that change would not be compatible with the existing device
trees in already existing hardware. I'm not sure how to handle that case
properly.
One needs to be backwards
On 2020-12-09 19:55, Madalin Bucur wrote:
-Original Message-
From: Patrick Havelange
Sent: 09 December 2020 16:17
To: Madalin Bucur ; David S. Miller
; Jakub Kicinski ;
net...@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 1/4] net: freescale/fman: Split the main
area. I'm assuming this is the problem you are trying to address here,
besides the stack corruption issue.
Yes exactly.
I did not add this behaviour (having a main region and subdrivers using
subregions), I'm just trying to correct what is already there.
For example: this is some content of
On 2020-12-03 16:47, Madalin Bucur wrote:
-Original Message-
From: Patrick Havelange
Sent: 03 December 2020 15:51
To: Madalin Bucur ; David S. Miller
; Jakub Kicinski ;
net...@vger.kernel.org; linux-kernel@vger.kernel.org
Cc: Patrick Havelange
Subject: [PATCH net 1/4] net: freescale
On 2020-12-03 09:44, Madalin Bucur wrote:
-Original Message-
From: Patrick Havelange
Sent: 02 December 2020 18:16
To: Madalin Bucur ; David S. Miller
; Jakub Kicinski ;
net...@vger.kernel.org; linux-kernel@vger.kernel.org
Cc: Patrick Havelange
Subject: [PATCH 2/4] net: freescale/fman
Since the main fman driver is no longer reserving the complete fman
memory region, it is no longer needed to use a custom call to
__devm_request_region, so replace it with devm_request_mem_region
Signed-off-by: Patrick Havelange
---
drivers/net/ethernet/freescale/fman/mac.c | 8 +++-
1 file
same time.
Signed-off-by: Patrick Havelange
---
drivers/net/ethernet/freescale/fman/fman_port.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fman/fman_port.c
b/drivers/net/ethernet/freescale/fman/fman_port.c
index d9baac0dbc7d..354974939
This function is no longer used, so we can remove it.
The pointer to the resource that was kept inside
struct fman_state_struct can also be removed for the same reason.
Signed-off-by: Patrick Havelange
---
drivers/net/ethernet/freescale/fman/fman.c | 17 -
drivers/net/ethernet
-by: Patrick Havelange
---
drivers/net/ethernet/freescale/fman/fman.c | 103 +
drivers/net/ethernet/freescale/fman/fman.h | 9 +-
2 files changed, 69 insertions(+), 43 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fman/fman.c
b/drivers/net/ethernet/freescale/fman/fman.c
ilar change, let's do it at the same time.
I think they all should be part of the same series.
Patrick Havelange (4):
net: freescale/fman: Split the main resource region reservation
net: freescale/fman-port: remove direct use of __devm_request_region
net: freescale/fman-mac: remove direct
This function is no longer used, so we can remove it.
The pointer to the resource that was kept inside
struct fman_state_struct can also be removed for the same reason.
Signed-off-by: Patrick Havelange
---
drivers/net/ethernet/freescale/fman/fman.c | 17 -
drivers/net/ethernet
Since the main fman driver is no longer reserving the complete fman
memory region, it is no longer needed to use a custom call to
__devm_request_region, so replace it with devm_request_mem_region
Signed-off-by: Patrick Havelange
---
drivers/net/ethernet/freescale/fman/mac.c | 8 +++-
1 file
same time.
Signed-off-by: Patrick Havelange
---
drivers/net/ethernet/freescale/fman/fman_port.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fman/fman_port.c
b/drivers/net/ethernet/freescale/fman/fman_port.c
index d9baac0dbc7d..354974939
-by: Patrick Havelange
---
drivers/net/ethernet/freescale/fman/fman.c | 103 +
drivers/net/ethernet/freescale/fman/fman.h | 9 +-
2 files changed, 69 insertions(+), 43 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fman/fman.c
b/drivers/net/ethernet/freescale/fman/fman.c
On Tue, Aug 13, 2019 at 8:02 AM Denis Efremov wrote:
>
> Fix typo (s/quadddec/quaddec/) in the path to the documentation.
>
> Cc: Patrick Havelange
> Cc: Jonathan Cameron
> Cc: linux-...@vger.kernel.org
> Fixes: 517b2d045aeb ("MAINTAINERS: add counter/ftm-quaddec d
On Fri, Jul 26, 2019 at 3:39 PM Chuhong Yuan wrote:
>
> Make use of devm_counter_register.
> Then we can remove redundant unregistration API
> usage to make code simpler.
>
> Signed-off-by: Chuhong Yuan
Reviewed-by: Patrick Havelange
Maybe a bit too late, sorry for that. Th
I don't know why, but I think it
should be looked into.
Otherwise, it's fine by me.
Regards,
Patrick Havelange
> - _remove() function is redundant now,
> delete it.
>
> drivers/counter/ftm-quaddec.c | 31 +++
> 1 file changed, 11 insertions(+), 20 dele
Hello,
Comments inline
On Thu, Jul 25, 2019 at 10:55 AM Chuhong Yuan wrote:
>
> Make use of devm_counter_register.
> Then we can remove redundant unregistration API
> usage to make code simpler.
>
> Signed-off-by: Chuhong Yuan
> ---
> drivers/counter/ftm-quaddec.c | 4 +---
> 1 file changed,
The last '>' chars were missing in the MODULE_AUTHOR entries.
Reported-by: Randy Dunlap
Fixes: a3b9a99980d9 ("counter: add FlexTimer Module Quadrature decoder counter
driver")
Signed-off-by: Patrick Havelange
---
drivers/counter/ftm-quaddec.c | 4 ++--
1 file changed, 2 ins
Adding myself as maintainer for this driver
Signed-off-by: Patrick Havelange
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 57f496cff999..6671854098d6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6218,6 +6218,14 @@ M: Philip
Modifying the prescaler or polarity value must be done with the
write protection disabled. Currently this is working by chance as
the write protection is in a disabled state by default.
This patch makes sure that we enable/disable the write protection
when needed.
Signed-off-by: Patrick Havelange
e following additional improvements:
- implement the new apply() method instead of the individual methods;
- return the exact used period/duty_cycle values;
- more coherent argument types for period, duty_cycle;
Signed-off-by: Patrick Havelange
---
drivers/pwm/pwm-fsl-ftm.c | 364 +++
This driver uses devm_ioremap and of* functions. This fixes a
linking failure with e.g. ARCH=um.
Reported-by: kbuild test robot
Signed-off-by: Patrick Havelange
---
drivers/counter/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
Signed-off-by: Patrick Havelange
---
Changes
v1 -> v2
[Peter
1. Fixed all space & 'return' related comments
2. Removed 'sysfs_create_group' api because
iio_device_register function is handling sysfs entry
3. Return -EIO if there is any fault
4
This patch introduces common thermocouple types used by various
temperature sensors. Also a brief documentation explaining this
"thermocouple-type" property.
Signed-off-by: Patrick Havelange
---
Changes v7
- Merge header and doc in same patch
- Doc:add it's a single cell entry
- D
From: Paresh Chaudhary
This patch added device tree binding info for MAX31856 driver.
Signed-off-by: Paresh Chaudhary
Signed-off-by: Matt Weber
Signed-off-by: Patrick Havelange
Reviewed-by: Rob Herring
---
Changes
v1 -> v2
[Matt
- Removed comment block and added possibilit
This patch introduces common thermocouple types used by various
temperature sensors.
Signed-off-by: Patrick Havelange
---
Changes v6
- Add this file
---
.../dt-bindings/iio/temperature/thermocouple.h | 16
1 file changed, 16 insertions(+)
create mode 100644 include/dt
Signed-off-by: Patrick Havelange
---
Changes
v1 -> v2
[Peter
1. Fixed all space & 'return' related comments
2. Removed 'sysfs_create_group' api because
iio_device_register function is handling sysfs entry
3. Return -EIO if there is any fault
4
This explains the new generic property "thermocouple-type" that
can be used with temperature sensors.
Signed-off-by: Patrick Havelange
---
Changes v6
- Add this file
---
.../bindings/iio/temperature/temperature-bindings.txt | 11 +++
1 file changed, 11 insertions(+)
create m
From: Paresh Chaudhary
This patch added device tree binding info for MAX31856 driver.
Signed-off-by: Paresh Chaudhary
Signed-off-by: Matt Weber
Signed-off-by: Patrick Havelange
---
Changes
v1 -> v2
[Matt
- Removed comment block and added possibilities of
thermocouple type in device t
This adds documentation for the specific prescaler entry.
Signed-off-by: Patrick Havelange
---
Changes v2
- Add doc for prescaler entry
---
.../ABI/testing/sysfs-bus-counter-ftm-quaddec| 16
1 file changed, 16 insertions(+)
create mode 100644 Documentation/ABI/testing
This also fixes the wrong value for the previously defined
FTM_MODE_INIT macro (it was not used).
Signed-off-by: Patrick Havelange
Reviewed-by: Esben Haabendal
---
Changes v2
- None
---
drivers/pwm/pwm-fsl-ftm.c | 44 +--
1 file changed, 1 insertion
Several files are/will be using the same #defines to use the Flextimer
module. Regroup them in a common file.
Signed-off-by: Patrick Havelange
Reviewed-by: Esben Haabendal
---
Changes v2
- Commit message
---
include/linux/fsl/ftm.h | 88 +
1 file
Common #defines have been moved to "linux/fsl/ftm.h". Thus making use of
this file.
Also FTM_SC_CLK_SHIFT has been renamed to FTM_SC_CLK_MASK_SHIFT.
Signed-off-by: Patrick Havelange
Reviewed-by: Esben Haabendal
---
Changes v2
- None
---
drivers/clocksource/timer-fsl-
of devm_* functions.
The polling/32bit signed version has been dropped, as not needed and
no other driver is doing that.
Patrick Havelange (7):
include/fsl: add common FlexTimer #defines in a separate header.
drivers/pwm: pwm-fsl-ftm: use common header for FlexTimer #defines
drivers
This driver exposes the counter for the quadrature decoder of the
FlexTimer Module, present in the LS1021A soc.
Signed-off-by: Patrick Havelange
---
Changes v2
- Rebased on new counter subsystem
- Cleaned up included headers
- Use devm_ioremap()
- Correct order of devm_ and unmanaged
Add the 4 Quadrature counters for this board.
Signed-off-by: Patrick Havelange
Reviewed-by: Esben Haabendal
---
Changes v2
- None
---
arch/arm/boot/dts/ls1021a.dtsi | 28
1 file changed, 28 insertions(+)
diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot
FlexTimer quadrature decoder driver.
Signed-off-by: Patrick Havelange
Reviewed-by: Esben Haabendal
---
Changes v2
- None
---
.../bindings/counter/ftm-quaddec.txt | 18 ++
1 file changed, 18 insertions(+)
create mode 100644 Documentation/devicetree/bindings
On Wed, Feb 20, 2019 at 5:42 PM Jonathan Cameron wrote:
[skipped]
> > +
> > +struct ftm_quaddec {
> > + struct platform_device *pdev;
> > + void __iomem *ftm_base;
> > + bool big_endian;
>
> I'm curious. What is the benefit of running in big endian mode?
It is based on the same
On Thu, Feb 28, 2019 at 12:59 AM Rob Herring wrote:
>
> On Tue, Feb 26, 2019 at 04:02:13PM +0100, Patrick Havelange wrote:
> > From: Paresh Chaudhary
> >
> > This patch added device tree binding info for MAX31856 driver.
> >
> > Signed-off-by: Paresh Chau
Signed-off-by: Patrick Havelange
---
Changes
v1 -> v2
[Peter
1. Fixed all space & 'return' related comments
2. Removed 'sysfs_create_group' api because
iio_device_register function is handling sysfs entry
3. Return -EIO if there is any fault
4
From: Paresh Chaudhary
This patch added device tree binding info for MAX31856 driver.
Signed-off-by: Paresh Chaudhary
Signed-off-by: Matt Weber
Signed-off-by: Patrick Havelange
---
Changes
v1 -> v2
[Matt
- Removed comment block and added possibilities of
thermocouple type in device t
Hi Jonathan,
Thanks for your comments, I'll make a new version of the patch based
on your input.
William, I'll rebase the next version on top of your branch.
I'm glad the counter subsystem effort is progressing :)
Patrick Havelange.
On Thu, Feb 21, 2019 at 9:27 AM William Breathitt Gray
Signed-off-by: Patrick Havelange
Reviewed-by: Esben Haabendal
---
include/linux/fsl/ftm.h | 88 +
1 file changed, 88 insertions(+)
create mode 100644 include/linux/fsl/ftm.h
diff --git a/include/linux/fsl/ftm.h b/include/linux/fsl/ftm.h
new file mode
FlexTimer quadrature decoder driver.
Signed-off-by: Patrick Havelange
Reviewed-by: Esben Haabendal
---
.../bindings/iio/counter/ftm-quaddec.txt | 18 ++
1 file changed, 18 insertions(+)
create mode 100644
Documentation/devicetree/bindings/iio/counter/ftm-quaddec.txt
r around 0), the interrupt will be triggering all the time. Thus,
polling is an easy way to handle overflow in a consistent way.
Polling can still be disabled by setting poll-interval to 0.
Signed-off-by: Patrick Havelange
Reviewed-by: Esben Haabendal
---
drivers/iio/counter/ftm-quadd
Add the 4 Quadrature counters for this board.
Signed-off-by: Patrick Havelange
Reviewed-by: Esben Haabendal
---
arch/arm/boot/dts/ls1021a.dtsi | 28
1 file changed, 28 insertions(+)
diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index
This also fixes the wrong value for the previously defined
FTM_MODE_INIT macro (it was not used).
Signed-off-by: Patrick Havelange
Reviewed-by: Esben Haabendal
---
drivers/pwm/pwm-fsl-ftm.c | 44 +--
1 file changed, 1 insertion(+), 43 deletions(-)
diff
Signed-off-by: Patrick Havelange
Reviewed-by: Esben Haabendal
---
drivers/clocksource/timer-fsl-ftm.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/clocksource/timer-fsl-ftm.c
b/drivers/clocksource/timer-fsl-ftm.c
index 846d18daf893..e1c34b2f53a5
This driver exposes the counter for the quadrature decoder of the
FlexTimer Module, present in the LS1021A soc.
Signed-off-by: Patrick Havelange
Reviewed-by: Esben Haabendal
---
drivers/iio/counter/Kconfig | 10 +
drivers/iio/counter/Makefile | 1 +
drivers/iio/counter/ftm
New optional parameter supported by updated driver.
Signed-off-by: Patrick Havelange
Reviewed-by: Esben Haabendal
---
.../devicetree/bindings/iio/counter/ftm-quaddec.txt | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/iio
The Freescale ddr driver also works on the LS1021A board.
Signed-off-by: Patrick Havelange
---
drivers/edac/fsl_ddr_edac.c | 4 ++--
drivers/edac/fsl_ddr_edac.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/edac/fsl_ddr_edac.c b/drivers/edac/fsl_ddr_edac.c
The LS1021A has a memory controller that supports EDAC. This commit
adds an entry for it.
Signed-off-by: Patrick Havelange
---
arch/arm/boot/dts/ls1021a.dtsi | 7 +++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index
The LS1021A has 8 possible PWMs, so adding them (disabled by default)
Signed-off-by: Patrick Havelange
---
arch/arm/boot/dts/ls1021a.dtsi | 96 ++
1 file changed, 96 insertions(+)
diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index
The LS1021A has 8 possible PWMs, so adding them (disabled by default)
Signed-off-by: Patrick Havelange
---
arch/arm/boot/dts/ls1021a.dtsi | 96 ++
1 file changed, 96 insertions(+)
diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index
55 matches
Mail list logo
