her
the `BriefDescription` ends with a period or not, and whether
there is an extra space at the end.
Regardless, LGTM.
Tested-by: Paul A. Clarke
Reviewed-by: Paul A. Clarke
PC
On Tue, Apr 06, 2021 at 12:02:36PM +0100, John Garry wrote:
> On 30/03/2021 07:41, kajoljain wrote:
> > On 3/30/21 2:37 AM, Paul A. Clarke wrote:
> > > On Fri, Mar 26, 2021 at 10:57:40AM +, John Garry wrote:
> > > > On 25/03/2021 20:39, Paul A. Clarke wrote:
On Fri, Mar 26, 2021 at 10:57:40AM +, John Garry wrote:
> On 25/03/2021 20:39, Paul A. Clarke wrote:
> > On Thu, Mar 25, 2021 at 06:33:12PM +0800, John Garry wrote:
> > > Metric reuse support is added for pmu-events parse metric testcase.
> > > This had been
On Fri, Mar 26, 2021 at 10:57:40AM +, John Garry wrote:
> On 25/03/2021 20:39, Paul A. Clarke wrote:
> > On Thu, Mar 25, 2021 at 06:33:12PM +0800, John Garry wrote:
> > > Metric reuse support is added for pmu-events parse metric testcase.
> > > This had been
On Thu, Mar 25, 2021 at 06:33:12PM +0800, John Garry wrote:
> Metric reuse support is added for pmu-events parse metric testcase.
> This had been broken on power9 recentlty:
> https://lore.kernel.org/lkml/20210324015418.gc8...@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com/
Much better. Before:
On Tue, Mar 23, 2021 at 03:15:16PM +, John Garry wrote:
> On 23/03/2021 15:06, Paul A. Clarke wrote:
> > On Mon, Mar 22, 2021 at 11:36:23AM +, John Garry wrote:
> > > On 01/08/2020 12:40, Paul A. Clarke wrote:
> > > > > v4 changes:
> > > > >
On Mon, Mar 22, 2021 at 11:36:23AM +, John Garry wrote:
> On 01/08/2020 12:40, Paul A. Clarke wrote:
> > > v4 changes:
> > >- removed acks from patch because it changed a bit
> > > with the last fixes:
> > >perf metric: Collect refer
Several metrics are defined based on unsupported / non-existent
events, and silently discarded. Remove them for good code hygiene
and to avoid confusion.
Signed-off-by: Paul A. Clarke
---
.../arch/powerpc/power9/metrics.json | 132 --
1 file changed, 132 deletions
On Thu, May 07, 2020 at 10:43:43PM -0700, Ian Rogers wrote:
> On Thu, May 7, 2020 at 2:47 PM Andi Kleen wrote:
> >
> > > > - without this change events within a metric may get scheduled
> > > > together, after they may appear as part of a larger group and be
> > > > multiplexed at different
On Wed, Aug 26, 2020 at 09:26:40AM -0700, Ian Rogers wrote:
> On Fri, Aug 14, 2020 at 5:43 AM Arnaldo Carvalho de Melo
> wrote:
> > Em Fri, Aug 14, 2020 at 11:20:42AM +0530, kajoljain escreveu:
> > > On 8/14/20 9:13 AM, Ian Rogers wrote:
> > > > On Thu, Aug 1
These changes take advantage of the new capability added in
merge commit 00e4db51259a5f936fec1424b884f029479d3981
"Allow using computed metrics in calculating other metrics".
The net is a simplification of the expressions for a handful
of metrics, but no functional change.
Signed-of
o's tmp.perf/core.
>
> v4 changes:
> - removed acks from patch because it changed a bit
> with the last fixes:
> perf metric: Collect referenced metrics in struct metric_ref_node
> - fixed runtime metrics [Kajol Jain]
> - increased recursion depth [Paul A. Cla
On Wed, Jul 22, 2020 at 08:11:58PM +0200, Jiri Olsa wrote:
> On Tue, Jul 21, 2020 at 09:48:48AM -0500, Paul A. Clarke wrote:
> > On Sun, Jul 19, 2020 at 08:13:01PM +0200, Jiri Olsa wrote:
> > > hi,
> > > this patchset is adding the support to reused met
On Wed, Jul 22, 2020 at 08:11:58PM +0200, Jiri Olsa wrote:
> On Tue, Jul 21, 2020 at 09:48:48AM -0500, Paul A. Clarke wrote:
> > On Sun, Jul 19, 2020 at 08:13:01PM +0200, Jiri Olsa wrote:
> > > hi,
> > > this patchset is adding the support to reused met
on Arnaldo's tmp.perf/core.
>
> v3 changes:
> - added some acks
> - some patches got merged
> - added missing zalloc include [John Garry]
> - added ids array outside the egroup object [Ian]
> - removed wrong m->has_constraint assignment [Ian]
> - renamed
On Wed, Jul 15, 2020 at 11:41:34PM +0200, Jiri Olsa wrote:
> On Wed, Jul 15, 2020 at 01:33:27PM -0500, Paul A. Clarke wrote:
> > On Sun, Jul 12, 2020 at 03:26:16PM +0200, Jiri Olsa wrote:
> > > hi,
> > > this patchset is adding the support to reused metric in anothe
On Sun, Jul 12, 2020 at 03:26:16PM +0200, Jiri Olsa wrote:
> hi,
> this patchset is adding the support to reused metric in another
> metric. The metric needs to be referenced by 'metric:' prefix.
>
> For example, to define IPC by using CPI with change like:
>
> "BriefDescription":
From: "Paul A. Clarke"
Add support for new "stat.big-num" boolean option.
This allows a user to set a default for "--no-big-num" for "perf stat"
commands.
--
$ perf config stat.big-num
$ perf stat --event cycles /bin/true
Performance counter st
From: "Paul A. Clarke"
Add support for new "stat.big-num" boolean option.
This allows a user to set a default for "--no-big-num" for "perf stat"
commands.
$ perf config stat.big-num
$ perf stat --event cycles /bin/true
Performance counter st
From: "Paul A. Clarke"
Uses of "ICT" and "Ict" are expanded to "Instruction Completion Table".
Signed-off-by: Paul A. Clarke
---
.../arch/powerpc/power9/metrics.json | 20 +--
1 file changed, 10 insertions(+), 10 deletions(-)
-level caches and NUMA hierarchies, some of these higher-level
metrics can involve a lot of hardware events.
Given the recent activity in this area, I'm curious if this has been
considered and already on a wish/to-do list, or found onerous.
Regards,
Paul Clarke
On Wed, May 13, 2020 at 06:28:31PM +1000, Michael Ellerman wrote:
> "Paul A. Clarke" writes:
> > Add the following metrics to the POWER9 'cpi_breakdown' metricgroup:
> > - ict_noslot_br_mpred_cpi
> > - ict_noslot_br_mpred_icmiss_cpi
> > - ict_noslot_cyc_oth
From: "Paul A. Clarke"
Add the following metrics to the POWER9 'cpi_breakdown' metricgroup:
- ict_noslot_br_mpred_cpi
- ict_noslot_br_mpred_icmiss_cpi
- ict_noslot_cyc_other_cpi
- ict_noslot_disp_held_cpi
- ict_noslot_disp_held_hb_full_cpi
- ict_noslot_disp_hel
From: "Paul A. Clarke"
The recent patches posted by Ian Rogers motivated a deeper dive into
the POWER9 perf metrics, which uncovered some additional issues:
- 'lsu_other_stall_cpi' doesn't work at all
- All of the "ICT" metrics are missing from the metricgroup
Paul A. Cla
From: "Paul A. Clarke"
The metric definition is too long for the current value of EXPR_MAX_OTHER.
Increase the value EXPR_MAX_OTHER sufficiently to allow
'lsu_other_stall_cpi' to build properly.
Before:
--
$ perf list | grep lsu_other
lsu_other_stall_cpi
# perf stat -a
25 matches
Mail list logo
