Re: [PATCH] Fix Alps Touchpad two finger scroll does not work on right side

2017-07-22 Thread Paul Donohue
Tested-by: Paul Donohue <linux-ker...@paulsd.com> On Fri, Jul 21, 2017 at 09:27:30AM +0900, Masaki Ota wrote: > From: Masaki Ota <masaki@jp.alps.com> > > Fixed the issue that two finger scroll does not work correctly > on V8 protocol. The cause is that V8 prot

Re: [PATCH] Fix Alps Touchpad two finger scroll does not work on right side

2017-07-22 Thread Paul Donohue
Tested-by: Paul Donohue On Fri, Jul 21, 2017 at 09:27:30AM +0900, Masaki Ota wrote: > From: Masaki Ota > > Fixed the issue that two finger scroll does not work correctly > on V8 protocol. The cause is that V8 protocol X-coordinate decode > is wrong at SS4 PLUS device. I added SS

Re: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS - fix V8+ protocol handling (73 03 28)")

2017-07-22 Thread Paul Donohue
age- > > From: Takashi Iwai [mailto:ti...@suse.de] > > Sent: Thursday, July 20, 2017 6:35 PM > > To: 太田 真喜 Masaki Ota <masaki@jp.alps.com> > > Cc: Paul Donohue <linux-ker...@paulsd.com>; Laura Abbott > > <labb...@redhat.com>; Dmitry Torokhov <dmitry.t

Re: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS - fix V8+ protocol handling (73 03 28)")

2017-07-22 Thread Paul Donohue
the original commit. > Actually, by fiddling with x_max (either less than 2200 or greater > than 3000), the two-finger scroll "works", although it shouldn't. > > > Takashi > > > > > Best Regards, > > Masaki Ota > > -Original Message----- >

Re: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS - fix V8+ protocol handling (73 03 28)")

2017-07-12 Thread Paul Donohue
On Wed, Jul 12, 2017 at 09:16:43AM +0200, Takashi Iwai wrote: > On Tue, 11 Jul 2017 21:58:21 +0200, > Paul Donohue wrote: > > > > On Tue, Jul 11, 2017 at 05:50:07PM +0200, Takashi Iwai wrote: > > > Hi, just joining to the party in the middle, as I'm also facing the

Re: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS - fix V8+ protocol handling (73 03 28)")

2017-07-12 Thread Paul Donohue
On Wed, Jul 12, 2017 at 09:16:43AM +0200, Takashi Iwai wrote: > On Tue, 11 Jul 2017 21:58:21 +0200, > Paul Donohue wrote: > > > > On Tue, Jul 11, 2017 at 05:50:07PM +0200, Takashi Iwai wrote: > > > Hi, just joining to the party in the middle, as I'm also facing the

Re: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS - fix V8+ protocol handling (73 03 28)")

2017-07-11 Thread Paul Donohue
On Tue, Jul 11, 2017 at 05:50:07PM +0200, Takashi Iwai wrote: > On Tue, 20 Jun 2017 01:20:26 +0200, > Paul Donohue wrote: > > > > On Mon, Jun 19, 2017 at 01:02:18PM -0700, Laura Abbott wrote: > > > On 06/19/2017 11:43 AM, Paul Donohue wrote: > > > > I get th

Re: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS - fix V8+ protocol handling (73 03 28)")

2017-07-11 Thread Paul Donohue
On Tue, Jul 11, 2017 at 05:50:07PM +0200, Takashi Iwai wrote: > On Tue, 20 Jun 2017 01:20:26 +0200, > Paul Donohue wrote: > > > > On Mon, Jun 19, 2017 at 01:02:18PM -0700, Laura Abbott wrote: > > > On 06/19/2017 11:43 AM, Paul Donohue wrote: > > > > I get th

Re: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS - fix V8+ protocol handling (73 03 28)")

2017-06-19 Thread Paul Donohue
On Mon, Jun 19, 2017 at 01:02:18PM -0700, Laura Abbott wrote: > On 06/19/2017 11:43 AM, Paul Donohue wrote: > > I get the same results as you - x_max and y_max affect cursor speed, and > > x_res and y_res seem to have no effect. I can't seem to come up with any > &

Re: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS - fix V8+ protocol handling (73 03 28)")

2017-06-19 Thread Paul Donohue
On Mon, Jun 19, 2017 at 01:02:18PM -0700, Laura Abbott wrote: > On 06/19/2017 11:43 AM, Paul Donohue wrote: > > I get the same results as you - x_max and y_max affect cursor speed, and > > x_res and y_res seem to have no effect. I can't seem to come up with any > &

Re: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS - fix V8+ protocol handling (73 03 28)")

2017-06-19 Thread Paul Donohue
here is no effect, even if I set an abnormal > value.(need this code?) > I don't understand why these values have to do with this issue. > > Can you guess the root cause of this issue? > > Best Regards, > Masaki Ota > -Original Message- > From: Laura Abbot

Re: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS - fix V8+ protocol handling (73 03 28)")

2017-06-19 Thread Paul Donohue
here is no effect, even if I set an abnormal > value.(need this code?) > I don't understand why these values have to do with this issue. > > Can you guess the root cause of this issue? > > Best Regards, > Masaki Ota > -Original Message- > From: Laura

Re: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS - fix V8+ protocol handling (73 03 28)")

2017-06-02 Thread Paul Donohue
Fixes: aeaa881f9b17 ("Input: ALPS - set DualPoint flag for 74 03 28 > devices") > Signed-off-by: Masaki Ota <masaki....@jp.alps.com> > Acked-by: Pali Rohar <pali.ro...@gmail.com> > Tested-by: Paul Donohue <linux-ker...@paulsd.com> > Tested-by: N

Re: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS - fix V8+ protocol handling (73 03 28)")

2017-06-02 Thread Paul Donohue
: ALPS - set DualPoint flag for 74 03 28 > devices") > Signed-off-by: Masaki Ota > Acked-by: Pali Rohar > Tested-by: Paul Donohue > Tested-by: Nick Fletcher > Cc: sta...@vger.kernel.org > Signed-off-by: Dmitry Torokhov > > I suspect this particular model needs special handling as well? > > Thanks, > Laura >

Re: [PATCH 2/2] Fix the issue that V8 Button pad Stick button does not work

2017-03-14 Thread Paul Donohue
ag from Stick button process. > > Signed-off-by: Masaki Ota <masaki@jp.alps.com> > > Acked-by: Pali Rohar <pali.ro...@gmail.com> Tested-by: Paul Donohue <linux-ker...@paulsd.com>

Re: [PATCH 2/2] Fix the issue that V8 Button pad Stick button does not work

2017-03-14 Thread Paul Donohue
t; Signed-off-by: Masaki Ota > > Acked-by: Pali Rohar Tested-by: Paul Donohue

Re: [PATCH 1/2] Fix V8 device information issue

2017-03-14 Thread Paul Donohue
ton pad, DualPoint > and Touchpad size. > -Deleted extra code from alps_v8_protocol_data decision process. > > Signed-off-by: Masaki Ota <masaki@jp.alps.com> > > Acked-by: Pali Rohar <pali.ro...@gmail.com> Tested-by: Paul Donohue <linux-ker...@paulsd.com>

Re: [PATCH 1/2] Fix V8 device information issue

2017-03-14 Thread Paul Donohue
ize. > -Deleted extra code from alps_v8_protocol_data decision process. > > Signed-off-by: Masaki Ota > > Acked-by: Pali Rohar Tested-by: Paul Donohue

Re: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag for 74 03 28 devices

2017-03-06 Thread Paul Donohue
03 28 device has to use below bit. > is_btnless = (otp[1][0] >> 1) & 0x01; > > I will check other parts of source code. > > Best Regards, > Masaki Ota > -Original Message- > From: Paul Donohue [mailto:linux-ker...@paulsd.com] > Sent: Monday, March 06,

Re: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag for 74 03 28 devices

2017-03-06 Thread Paul Donohue
03 28 device has to use below bit. > is_btnless = (otp[1][0] >> 1) & 0x01; > > I will check other parts of source code. > > Best Regards, > Masaki Ota > -Original Message- > From: Paul Donohue [mailto:linux-ker...@paulsd.com] > Sent: Monday, Ma

Re: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag for 74 03 28 devices

2017-03-05 Thread Paul Donohue
ouse serio1: alps: ALPS two-finger packet w/ button > (buttonpad: 0): d9 73 24 > > > Thank you for your help in this and thank you to Joseph for building all > the test kernels whilst attempting to find out which commit first caused my > issue. > > Cheers, > Nick. > > O

Re: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag for 74 03 28 devices

2017-03-05 Thread Paul Donohue
ouse serio1: alps: ALPS two-finger packet w/ button > (buttonpad: 0): d9 73 24 > > > Thank you for your help in this and thank you to Joseph for building all > the test kernels whilst attempting to find out which commit first caused my > issue. > > Cheers, > Nick. >