Re: [PATCH] tasklet: Remove tasklet_kill_immediate

2021-03-06 Thread Paul E. McKenney
On Sat, Mar 06, 2021 at 01:36:58PM -0800, Davidlohr Bueso wrote: > Ever since RCU was converted to softirq, it has no users. > > Signed-off-by: Davidlohr Bueso That was a long time ago... Acked-by: Paul E. McKenney > --- > include/linux/interrupt.h | 1 - > kernel/softi

Re: timer: Report ignored local enqueue in nohz mode?

2021-03-05 Thread Paul E. McKenney
On Fri, Mar 05, 2021 at 02:41:11PM +0100, Frederic Weisbecker wrote: > On Wed, Mar 03, 2021 at 11:49:45AM -0800, Paul E. McKenney wrote: > > Hello, Frederic! > > > > I don't see the following commit in mainline, but figured I should > > check with you guys to see if the

Re: [PATCH] tools/memory-model: Fix smp_mb__after_spinlock() spelling

2021-03-05 Thread Paul E. McKenney
On Fri, Mar 05, 2021 at 01:59:24PM -0500, Alan Stern wrote: > On Fri, Mar 05, 2021 at 10:26:50AM -0800, Paul E. McKenney wrote: > > On Fri, Mar 05, 2021 at 04:41:49PM +0100, Björn Töpel wrote: > > > On 2021-03-05 16:36, Alan Stern wrote: > > > > On Fri, Mar 05, 2

Re: [PATCH] tools/memory-model: Fix smp_mb__after_spinlock() spelling

2021-03-05 Thread Paul E. McKenney
txt; provide Linux-kernel memory model") [ paulmck: Apply Alan Stern commit-log feedback. ] Signed-off-by: Björn Töpel Signed-off-by: Paul E. McKenney diff --git a/tools/memory-model/Documentation/explanation.txt b/tools/memory-model/Documentation/explanation.txt index f9d61

Re: [PATCH] tools/memory-model: Fix smp_mb__after_spinlock() spelling

2021-03-05 Thread Paul E. McKenney
On Fri, Mar 05, 2021 at 11:28:23AM +0100, Björn Töpel wrote: > From: Björn Töpel > > A misspelled invokation of git-grep, revealed that > smp_mb__after_spinlock() was misspelled in explaination.txt. > > Add missing "_" to smp_mb__after_spinlock(). > > Fixes: 1c27b644c0fd ("Automate

Re: XDP socket rings, and LKMM litmus tests

2021-03-04 Thread Paul E. McKenney
On Thu, Mar 04, 2021 at 04:27:53PM -0500, Alan Stern wrote: > On Thu, Mar 04, 2021 at 11:05:15AM -0800, Paul E. McKenney wrote: > > On Thu, Mar 04, 2021 at 10:35:24AM -0500, Alan Stern wrote: > > > On Wed, Mar 03, 2021 at 09:04:07PM -0800, Paul E. McKenney wrote: > > > &

Re: [PATCH tip/core/rcu 02/12] timer: Report ignored local enqueue in nohz mode

2021-03-04 Thread Paul E. McKenney
l the next random interrupt. > > > > Perform sanity checks to report these situations. > > > > Cc: Peter Zijlstra > > Cc: Thomas Gleixner > > Cc: Ingo Molnar > > Cc: Rafael J. Wysocki > > Signed-off-by: Frederic Weisbecker > > Signed-o

Re: XDP socket rings, and LKMM litmus tests

2021-03-04 Thread Paul E. McKenney
On Thu, Mar 04, 2021 at 04:44:34PM +0100, maranget wrote: > > > > On 3 Mar 2021, at 21:22, Alan Stern wrote: > > > >>> > >>> Local variables absolutely should be treated just like CPU registers, if > >>> possible. In fact, the compiler has the option of keeping local > >>> variables stored

Re: XDP socket rings, and LKMM litmus tests

2021-03-04 Thread Paul E. McKenney
On Thu, Mar 04, 2021 at 10:35:24AM -0500, Alan Stern wrote: > On Wed, Mar 03, 2021 at 09:04:07PM -0800, Paul E. McKenney wrote: > > On Wed, Mar 03, 2021 at 10:21:01PM -0500, Alan Stern wrote: > > > On Wed, Mar 03, 2021 at 02:03:48PM -0800, Paul E. McKenney wrote: > > > &

Re: XDP socket rings, and LKMM litmus tests

2021-03-03 Thread Paul E. McKenney
On Wed, Mar 03, 2021 at 10:21:01PM -0500, Alan Stern wrote: > On Wed, Mar 03, 2021 at 02:03:48PM -0800, Paul E. McKenney wrote: > > On Wed, Mar 03, 2021 at 03:22:46PM -0500, Alan Stern wrote: > > > On Wed, Mar 03, 2021 at 09:40:22AM -0800, Paul E. McKenney wrote: > > > &

Re: linux-next: build warning after merge of the rcu tree

2021-03-03 Thread Paul E. McKenney
On Thu, Mar 04, 2021 at 12:41:05PM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the rcu tree, today's linux-next build (htmldocs) produced > this warning: > > kernel/rcu/tree.c:3824: warning: expecting prototype for > start_poll_state_synchronize_rcu(). Prototype was for >

[PATCH v5 clocksource] Do not mark clocks unstable due to delays for v5.13

2021-03-03 Thread Paul E. McKenney
Hello! If there is a sufficient delay between reading the watchdog clock and the clock under test, the clock under test will be marked unstable through no fault of its own. This series checks for this, doing limited retries to get a good set of clock reads. If the clock is marked unstable and

[PATCH memory-model 0/3] LKMM updates for v5.13

2021-03-03 Thread Paul E. McKenney
Hello! This series contains LKMM updates: 1. Update rcu_dereference.rst reference, courtesy of Mauro Carvalho Chehab. 2. tools/memory-model: Remove reference to atomic_ops.rst, courtesy of Akira Yokosawa. 3. tools/memory-model: Add access-marking documentation.

[PATCH kcsan 0/4] KCSAN updates for v5.13

2021-03-03 Thread Paul E. McKenney
Hello! This series contains KCSAN updates: 1. kcsan, debugfs: Move debugfs file creation out of early init, courtesy of Marco Elver. 2. Make test follow KUnit style recommendations, courtesy of Marco Elver. 3. Switch to KUNIT_CASE_PARAM for parameterized tests,

[PATCH tip/core/rcu 0/28] Torture-test scripting updates for v5.13

2021-03-03 Thread Paul E. McKenney
Hello! This series contains updates to the torture-test scripting, perhaps most notably the addition of kvm-again.sh, which allows rerunning an earlier test without having to rebuild all the kernels. 1. Don't rerun failed rcutorture builds. 2. Allow 1G of memory for torture.sh kvfree

[PATCH tip/core/rcu 0/2] Torture-test updates for v5.13

2021-03-03 Thread Paul E. McKenney
Hello! This series contains a couple of torture-test updates: 1. Replace torture_init_begin string with %s, courtesy of Stephen Zhang. 2. Replace rcu_torture_stall string with %s, courtesy of Stephen Zhang. Thanx, Paul

[PATCH tip/core/rcu 0/2] RCU Tasks updates for v5.13

2021-03-03 Thread Paul E. McKenney
Hello! This series contains a couple of updates for the RCU-tasks family: 1. rcu-tasks: Rectify kernel-doc for struct rcu_tasks, courtesy of Lukas Bulwahn. 2. rcu-tasks: Add block comment laying out RCU Tasks Trace design.

[PATCH tip/core/rcu 0/5] Realtime-related RCU updates for v5.13

2021-03-03 Thread Paul E. McKenney
Hello! These commits are related to RCU's realtime support, including better testing preemption, improving testing of RCU priority boosting, and ensuring that at least one rcutorture scenario tests use_softirq=0. 1. Expedite deboost in case of deferred quiescent state. 2. Make TREE03

[PATCH tip/core/rcu 0/3] Polling RCU grace-period interfaces for v5.13

2021-03-03 Thread Paul E. McKenney
Hello! This series provides additional polling interfaces for RCU, so that an updater may initiate and poll for completion of an RCU grace period despite never being invoked from a sleepable region of code. These are similar to the corresponding SRCU interfaces, give or take additional

[PATCH tip/core/rcu 0/12] NOCB updates for v5.13

2021-03-03 Thread Paul E. McKenney
Hello! This series contains updates for no-callbacks (NOCBs) CPUs: 1. Detect unsafe checks for offloaded rdp, courtesy of Frederic Weisbecker. 2. Report ignored local enqueue in nohz mode, courtesy of Frederic Weisbecker. 3. Comment the reason behind BH

[PATCH tip/core/rcu 0/6] kvfree_rcu() updates for v5.12-rc1

2021-03-03 Thread Paul E. McKenney
Hello! This series contains kvfree_rcu() updates, most notably surrounding GPF flags for memory allocation. 1. kvfree_rcu: Directly allocate page for single-argument case, courtesy of "Uladzislau Rezki (Sony)". 2. kvfree_rcu: Use __GFP_NOMEMALLOC for single-argument

[PATCH tip/core/rcu 0/9] Add bitmap (thus CPU) ranges

2021-03-03 Thread Paul E. McKenney
Hello! This series adds ranges to bitmaps, and thus to CPU numbers, so that a kernel boot parameter such as "rcu_nocbs=2-N" is now permitted. 1. test_bitmap: clearly separate ERANGE from EINVAL tests, courtesy of Paul Gortmaker. 2. test_bitmap: add tests to trigger ERANGE

[PATCH tip/core/rcu 0/10] Miscellaneous fixes for v5.13

2021-03-03 Thread Paul E. McKenney
Hello! This series contains miscellaneous fixes: 1. Remove superfluous rdp fetch, courtesy of Frederic Weisbecker. 2. Fix CPU-offline trace in rcutree_dying_cpu, courtesy of Neeraj Upadhyay. 3. Remove spurious instrumentation_end() in rcu_nmi_enter(), courtesy of

Re: XDP socket rings, and LKMM litmus tests

2021-03-03 Thread Paul E. McKenney
On Wed, Mar 03, 2021 at 03:22:46PM -0500, Alan Stern wrote: > On Wed, Mar 03, 2021 at 09:40:22AM -0800, Paul E. McKenney wrote: > > On Wed, Mar 03, 2021 at 12:12:21PM -0500, Alan Stern wrote: > > > > Local variables absolutely should be treated just like CPU register

Re: XDP socket rings, and LKMM litmus tests

2021-03-03 Thread Paul E. McKenney
On Wed, Mar 03, 2021 at 06:39:14PM +0100, maranget wrote: > > > > On 3 Mar 2021, at 18:37, maranget wrote: > > > > I have made a PR to herd7 that performs the change. The commit message > > states the new definition. > > For those who are interested >

timer: Report ignored local enqueue in nohz mode?

2021-03-03 Thread Paul E. McKenney
Signed-off-by: Frederic Weisbecker Signed-off-by: Paul E. McKenney diff --git a/kernel/sched/core.c b/kernel/sched/core.c index ca2bb62..4822371 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -674,6 +674,26 @@ int get_nohz_timer_target(void) return cpu; } +static void

Re: [PATCH drivers/net] #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend()

2021-03-03 Thread Paul E. McKenney
On Wed, Mar 03, 2021 at 06:04:22PM +, Russell King - ARM Linux admin wrote: > On Wed, Mar 03, 2021 at 09:53:38AM -0800, Paul E. McKenney wrote: > > drivers/net: #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend() > > > > The following build error is emitted by rcuto

Re: XDP socket rings, and LKMM litmus tests

2021-03-03 Thread Paul E. McKenney
On Wed, Mar 03, 2021 at 12:12:21PM -0500, Alan Stern wrote: > On Tue, Mar 02, 2021 at 03:50:19PM -0800, Paul E. McKenney wrote: > > On Tue, Mar 02, 2021 at 04:14:46PM -0500, Alan Stern wrote: > > > > This result is wrong, apparently because of a bug in herd7. There &g

[PATCH drivers/net] #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend()

2021-03-03 Thread Paul E. McKenney
will be used only in CONFIG_PM_SLEEP=y kernels. This commit therefore wraps them in #ifdef CONFIG_PM_SLEEP. Cc: Andrew Lunn Cc: Heiner Kallweit Cc: Russell King Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Signed-off-by: Paul E. McKenney diff --git a/drivers/net/phy/phy_device.c b/drive

Re: possible deadlock in sk_clone_lock

2021-03-03 Thread Paul E. McKenney
On Wed, Mar 03, 2021 at 09:03:27AM +0100, Michal Hocko wrote: > [Add Paul] > > On Tue 02-03-21 13:19:34, Mike Kravetz wrote: > > On 3/2/21 6:29 AM, Michal Hocko wrote: > > > On Tue 02-03-21 06:11:51, Shakeel Butt wrote: > > >> On Tue, Mar 2, 2021 at 1:44 AM Michal Hocko wrote: > > >>> > > >>> On

Re: XDP socket rings, and LKMM litmus tests

2021-03-03 Thread Paul E. McKenney
is confined to its "if" statement. Stores to and reloads from shared variables would be handled as they are now, correct? My guess is that this turns out to be equivalent to your intuition, but this stuff can be tricky. Thanx, Paul > —Luc

Re: [PATCH 01/13] rcu/nocb: Fix potential missed nocb_timer rearm

2021-03-03 Thread Paul E. McKenney
On Wed, Mar 03, 2021 at 02:35:33AM +0100, Frederic Weisbecker wrote: > On Tue, Mar 02, 2021 at 10:17:29AM -0800, Paul E. McKenney wrote: > > On Tue, Mar 02, 2021 at 01:34:44PM +0100, Frederic Weisbecker wrote: > > > > OK, how about if I queue a temporary commit (shown below

Re: [PATCH 10/13] rcu/nocb: Delete bypass_timer upon nocb_gp wakeup

2021-03-03 Thread Paul E. McKenney
On Tue, Feb 23, 2021 at 01:10:08AM +0100, Frederic Weisbecker wrote: > A NOCB-gp wake up can safely delete the nocb_bypass_timer. nocb_gp_wait() > is going to check again the bypass state and rearm the bypass timer if > necessary. > > Signed-off-by: Frederic Weisbecker > Cc: Josh Triplett > Cc:

Re: [PATCH 11/13] rcu/nocb: Only cancel nocb timer if not polling

2021-03-03 Thread Paul E. McKenney
On Tue, Feb 23, 2021 at 01:10:09AM +0100, Frederic Weisbecker wrote: > No need to disarm the nocb_timer if rcu_nocb is polling because it > shouldn't be armed either. > > Signed-off-by: Frederic Weisbecker > Cc: Josh Triplett > Cc: Lai Jiangshan > Cc: Joel Fernandes > Cc: Neeraj Upadhyay >

Re: [PATCH 05/13] rcu/nocb: Use the rcuog CPU's ->nocb_timer

2021-03-03 Thread Paul E. McKenney
On Tue, Feb 23, 2021 at 01:10:03AM +0100, Frederic Weisbecker wrote: > Currently each offline rdp has its own nocb_timer armed when the > nocb_gp wakeup must be deferred. This layout has many drawbacks, > compared to a solution based on a single timer per rdp group: > > * There are a lot of

Re: XDP socket rings, and LKMM litmus tests

2021-03-03 Thread Paul E. McKenney
On Tue, Mar 02, 2021 at 04:14:46PM -0500, Alan Stern wrote: > On Tue, Mar 02, 2021 at 07:46:27PM +0100, Björn Töpel wrote: > > Hi! > > > > Firstly; The long Cc-list is to reach the LKMM-folks. > > > > Some background; the XDP sockets use a ring-buffer to communicate > > between the kernel and

Re: XDP socket rings, and LKMM litmus tests

2021-03-02 Thread Paul E. McKenney
On Tue, Mar 02, 2021 at 09:24:04PM +0100, Björn Töpel wrote: > On Tue, 2 Mar 2021 at 20:57, Paul E. McKenney wrote: > > > > On Tue, Mar 02, 2021 at 07:46:27PM +0100, Björn Töpel wrote: > > [...] > > > > > Before digging in too deeply, does the following s

Re: XDP socket rings, and LKMM litmus tests

2021-03-02 Thread Paul E. McKenney
On Tue, Mar 02, 2021 at 11:57:58AM -0800, Paul E. McKenney wrote: > On Tue, Mar 02, 2021 at 07:46:27PM +0100, Björn Töpel wrote: > > Hi! > > > > Firstly; The long Cc-list is to reach the LKMM-folks. > > > > Some background; the XDP sockets use a ring-buffer to c

Re: XDP socket rings, and LKMM litmus tests

2021-03-02 Thread Paul E. McKenney
On Tue, Mar 02, 2021 at 07:46:27PM +0100, Björn Töpel wrote: > Hi! > > Firstly; The long Cc-list is to reach the LKMM-folks. > > Some background; the XDP sockets use a ring-buffer to communicate > between the kernel and userland. It's a > single-consumer/single-producer ring, and described in >

Re: [PATCH 01/13] rcu/nocb: Fix potential missed nocb_timer rearm

2021-03-02 Thread Paul E. McKenney
On Tue, Mar 02, 2021 at 01:34:44PM +0100, Frederic Weisbecker wrote: > On Mon, Mar 01, 2021 at 05:48:29PM -0800, Paul E. McKenney wrote: > > On Wed, Feb 24, 2021 at 11:06:06PM +0100, Frederic Weisbecker wrote: > > > On Wed, Feb 24, 2021 at 10:37:09AM -0800, Paul E. McKenney wro

Re: [PATCH 01/13] rcu/nocb: Fix potential missed nocb_timer rearm

2021-03-01 Thread Paul E. McKenney
On Wed, Feb 24, 2021 at 11:06:06PM +0100, Frederic Weisbecker wrote: > On Wed, Feb 24, 2021 at 10:37:09AM -0800, Paul E. McKenney wrote: > > On Tue, Feb 23, 2021 at 01:09:59AM +0100, Frederic Weisbecker wrote: > > > Two situations can cause a missed nocb timer rearm: >

Re: [PATCH 3/3] kernel/smp: add more data to CSD lock debugging

2021-03-01 Thread Paul E. McKenney
On Mon, Mar 01, 2021 at 04:53:27PM +0100, Jürgen Groß wrote: > On 01.03.21 16:45, Peter Zijlstra wrote: > > On Sun, Feb 28, 2021 at 04:07:04PM -0800, Paul E. McKenney wrote: > > > On Fri, Feb 26, 2021 at 10:05:51PM +0100, Peter Zijlstra wrote: > > > > On Fri, Feb 26,

Re: [PATCH 3/3] kernel/smp: add more data to CSD lock debugging

2021-02-28 Thread Paul E. McKenney
On Fri, Feb 26, 2021 at 10:05:51PM +0100, Peter Zijlstra wrote: > On Fri, Feb 26, 2021 at 10:12:05AM -0800, Paul E. McKenney wrote: > > On Fri, Feb 26, 2021 at 05:38:44PM +0100, Peter Zijlstra wrote: > > > > > > I hate all of this, but if this will finally catch the a

Re: hppa64-linux-ld: kernel/rcu/refscale.o(.init.text+0x228): cannot reach schedule_timeout_uninterruptible

2021-02-28 Thread Paul E. McKenney
On Sun, Feb 28, 2021 at 09:51:35PM +0100, Helge Deller wrote: > Adding parisc-parisc mailing list... > > On 2/28/21 6:05 AM, Paul E. McKenney wrote: > > On Sun, Feb 28, 2021 at 12:08:08PM +0800, kernel test robot wrote: > > > Hi Paul, > > > > >

Re: hppa64-linux-ld: kernel/rcu/refscale.o(.init.text+0x228): cannot reach schedule_timeout_uninterruptible

2021-02-27 Thread Paul E. McKenney
On Sun, Feb 28, 2021 at 12:08:08PM +0800, kernel test robot wrote: > Hi Paul, > > First bad commit (maybe != root cause): > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 5695e51619745d4fe3ec2506a2f0cd982c5e27a4 > commit:

Re: [PATCH] init: init_task.c: fixed two spaces coding style issue

2021-02-27 Thread Paul E. McKenney
On Sat, Feb 27, 2021 at 06:01:18PM +0100, Javier Contreras wrote: > Fixed two spaces coding style issue. > > Signed-off-by: Javier Contreras I am not maintainer for this code, and also wangjingyu beat you to this one. But one question: Given that this patch would cause "git blame" to list you

Re: [PATCH 3/3] kernel/smp: add more data to CSD lock debugging

2021-02-26 Thread Paul E. McKenney
On Fri, Feb 26, 2021 at 05:38:44PM +0100, Peter Zijlstra wrote: > > I hate all of this, but if this will finally catch the actual problem, > we can then revert all this, so sure. OK, I will bite... What exactly do you hate about it?

Re: tasks-trace RCU: question about grace period forward progress

2021-02-25 Thread Paul E. McKenney
On Thu, Feb 25, 2021 at 11:23:18PM +0100, Peter Zijlstra wrote: > On Thu, Feb 25, 2021 at 10:33:21AM -0800, Paul E. McKenney wrote: > > One question for Peter... Does each and every context switch imply a > > full barrier? > > Yes, also see the smp_mb__after_spinlock() in _

Re: tasks-trace RCU: question about grace period forward progress

2021-02-25 Thread Paul E. McKenney
On Thu, Feb 25, 2021 at 03:20:34PM -0500, Mathieu Desnoyers wrote: > - On Feb 25, 2021, at 1:33 PM, paulmck paul...@kernel.org wrote: > [...] > > commit 581f79546b6be406a9c7280b2d3511b60821efe0 > > Author: Paul E. McKenney > > Date: Thu Feb 25 10:26:00 2021 -0800 &g

Re: tasks-trace RCU: question about grace period forward progress

2021-02-25 Thread Paul E. McKenney
) reports > > failure, which is another path to the following paragraph. > > > > If the task could not be locked down due its currently running, > > then trc_wait_for_one_reader() attempts to send an IPI, which results in > > trc_read_check_handler() rechecking for a read-side cri

Re: tasks-trace RCU: question about grace period forward progress

2021-02-25 Thread Paul E. McKenney
On Thu, Feb 25, 2021 at 09:22:48AM -0500, Mathieu Desnoyers wrote: > Hi Paul, > > Answering a question from Peter on IRC got me to look at > rcu_read_lock_trace(), and I see this: > > static inline void rcu_read_lock_trace(void) > { > struct task_struct *t = current; > >

Re: [PATCH 01/13] rcu/nocb: Fix potential missed nocb_timer rearm

2021-02-24 Thread Paul E. McKenney
On Thu, Feb 25, 2021 at 01:48:13AM +0100, Frederic Weisbecker wrote: > On Wed, Feb 24, 2021 at 04:14:25PM -0800, Paul E. McKenney wrote: > > On Wed, Feb 24, 2021 at 11:06:06PM +0100, Frederic Weisbecker wrote: > > > I managed to recollect some pieces of my brain. So keep the abo

Re: [PATCH] rcu: make nocb_nobypass_lim_per_jiffy static

2021-02-24 Thread Paul E. McKenney
On Wed, Feb 24, 2021 at 04:30:29PM +0800, Jiapeng Chong wrote: > Fix the following sparse warning: > > kernel/rcu/tree_plugin.h:1497:5: warning: symbol > 'nocb_nobypass_lim_per_jiffy' was not declared. Should it be static? > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Queued

Re: [PATCH 01/13] rcu/nocb: Fix potential missed nocb_timer rearm

2021-02-24 Thread Paul E. McKenney
On Wed, Feb 24, 2021 at 11:06:06PM +0100, Frederic Weisbecker wrote: > On Wed, Feb 24, 2021 at 10:37:09AM -0800, Paul E. McKenney wrote: > > On Tue, Feb 23, 2021 at 01:09:59AM +0100, Frederic Weisbecker wrote: > > > Two situations can cause a missed nocb timer rearm: >

Re: [PATCH 01/13] rcu/nocb: Fix potential missed nocb_timer rearm

2021-02-24 Thread Paul E. McKenney
On Tue, Feb 23, 2021 at 01:09:59AM +0100, Frederic Weisbecker wrote: > Two situations can cause a missed nocb timer rearm: > > 1) rdp(CPU A) queues its nocb timer. The grace period elapses before >the timer get a chance to fire. The nocb_gp kthread is awaken by >rdp(CPU B). The nocb_cb

Re: [PATCH v5 0/8] support for bitmap (and hence CPU) list "N" abbreviation

2021-02-23 Thread Paul E. McKenney
quot;N" to be used anywhere in the region spec, i.e. "N-N:N/N" vs. > > just being allowed at end of range like "0-N". Add new self-tests. Drop > > "all" and "none" aliases as redundant and not worth the extra > > complication. ] > &

Re: [PATCH v5 0/8] support for bitmap (and hence CPU) list "N" abbreviation

2021-02-22 Thread Paul E. McKenney
uot;none" aliases as redundant and not worth the extra complication. ] > > https://lore.kernel.org/lkml/20210126171141.122639-1-paul.gortma...@windriver.com/ > > [v2: push code down from cpu subsys to core bitmap code as per > Yury's comments. Change "last" to simply be

Re: [PATCH] kprobes: Fix to delay the kprobes jump optimization

2021-02-22 Thread Paul E. McKenney
On Mon, Feb 22, 2021 at 08:07:03PM +0100, Uladzislau Rezki wrote: > On Mon, Feb 22, 2021 at 10:16:08AM -0800, Paul E. McKenney wrote: > > On Mon, Feb 22, 2021 at 06:16:05PM +0100, Uladzislau Rezki wrote: > > > On Mon, Feb 22, 2021 at 07:09:03AM -0800, Paul E. McKenney wrote: >

Re: [PATCH] kprobes: Fix to delay the kprobes jump optimization

2021-02-22 Thread Paul E. McKenney
On Mon, Feb 22, 2021 at 06:16:05PM +0100, Uladzislau Rezki wrote: > On Mon, Feb 22, 2021 at 07:09:03AM -0800, Paul E. McKenney wrote: > > On Mon, Feb 22, 2021 at 01:54:31PM +0100, Uladzislau Rezki wrote: > > > On Mon, Feb 22, 2021 at 11:21:04AM +0100, Sebastian And

Re: [PATCH] kprobes: Fix to delay the kprobes jump optimization

2021-02-22 Thread Paul E. McKenney
On Mon, Feb 22, 2021 at 01:54:31PM +0100, Uladzislau Rezki wrote: > On Mon, Feb 22, 2021 at 11:21:04AM +0100, Sebastian Andrzej Siewior wrote: > > On 2021-02-19 10:33:36 [-0800], Paul E. McKenney wrote: > > > For definiteness, here is the first part of the change, posted earlier

[PATCH RFC tools/memory-model] Add access-marking documentation

2021-02-19 Thread Paul E. McKenney
r feedback. ] Reviewed-by: Marco Elver Signed-off-by: Paul E. McKenney diff --git a/tools/memory-model/Documentation/access-marking.txt b/tools/memory-model/Documentation/access-marking.txt new file mode 100644 index 000..accb79f --- /dev/null +++ b/tools/memory-model/Documentation/access-m

Re: [PATCH 5.10 020/104] ARM: OMAP2+: Fix suspcious RCU usage splats for omap_enter_idle_coupled

2021-02-19 Thread Paul E. McKenney
On Fri, Feb 19, 2021 at 10:14:27PM +0100, Pavel Machek wrote: > Hi! > > > [ Upstream commit 06862d789ddde8a99c1e579e934ca17c15a84755 ] > > > > We get suspcious RCU usage splats with cpuidle in several places in > > omap_enter_idle_coupled() with the kernel debug options enabled: > > > > RCU

Re: [PATCH] kprobes: Fix to delay the kprobes jump optimization

2021-02-19 Thread Paul E. McKenney
On Fri, Feb 19, 2021 at 03:02:31PM -0500, Steven Rostedt wrote: > On Fri, 19 Feb 2021 10:33:36 -0800 > "Paul E. McKenney" wrote: > > > commit 4f659bf04fc4610523544493d6db92fc8670b086 > > Author: Paul E. McKenney > > Date: Fri Feb 12 16:20:40 2021 -0800 &

Re: [PATCH] kprobes: Fix to delay the kprobes jump optimization

2021-02-19 Thread Paul E. McKenney
On Fri, Feb 19, 2021 at 11:45:39AM -0800, Paul E. McKenney wrote: > On Fri, Feb 19, 2021 at 02:14:29PM -0500, Steven Rostedt wrote: > > On Fri, 19 Feb 2021 10:18:11 -0800 > > "Paul E. McKenney" wrote: > > > > > We can further prevent entry into dynt

Re: [PATCH] kprobes: Fix to delay the kprobes jump optimization

2021-02-19 Thread Paul E. McKenney
On Fri, Feb 19, 2021 at 02:58:30PM -0500, Steven Rostedt wrote: > On Fri, 19 Feb 2021 11:47:44 -0800 > "Paul E. McKenney" wrote: > > > Could you please add the following Reported-by tags? > > > > Reported-by: Sebastian Andrzej Siewior > > Reported-by:

Re: [PATCH] kprobes: Fix to delay the kprobes jump optimization

2021-02-19 Thread Paul E. McKenney
). > > > > To avoid this issue, make the kprobe optimization disabled in the > > early_initcall() and enables it in subsys_initcall(). > > > > Note that non-optimized kprobes is still available after > > early_initcall(). Only jump optimization is delayed. > >

Re: [PATCH] kprobes: Fix to delay the kprobes jump optimization

2021-02-19 Thread Paul E. McKenney
On Fri, Feb 19, 2021 at 02:14:29PM -0500, Steven Rostedt wrote: > On Fri, 19 Feb 2021 10:18:11 -0800 > "Paul E. McKenney" wrote: > > > We can further prevent entry into dyntick-idle state until > > the ksoftirqd kthreads have been spawned, which means th

Re: [PATCH] kprobes: Fix to delay the kprobes jump optimization

2021-02-19 Thread Paul E. McKenney
On Fri, Feb 19, 2021 at 10:33:36AM -0800, Paul E. McKenney wrote: > On Fri, Feb 19, 2021 at 10:18:11AM -0800, Paul E. McKenney wrote: > > On Fri, Feb 19, 2021 at 12:27:51PM +0100, Uladzislau Rezki wrote: > > > On Fri, Feb 19, 2021 at 12:23:57PM +0100, Uladzislau Rezki wrote: >

Re: [PATCH] kprobes: Fix to delay the kprobes jump optimization

2021-02-19 Thread Paul E. McKenney
On Fri, Feb 19, 2021 at 10:18:11AM -0800, Paul E. McKenney wrote: > On Fri, Feb 19, 2021 at 12:27:51PM +0100, Uladzislau Rezki wrote: > > On Fri, Feb 19, 2021 at 12:23:57PM +0100, Uladzislau Rezki wrote: > > > On Fri, Feb 19, 2021 at 12:17:38PM +0100, Sebastian And

Re: [PATCH] kprobes: Fix to delay the kprobes jump optimization

2021-02-19 Thread Paul E. McKenney
On Fri, Feb 19, 2021 at 12:27:51PM +0100, Uladzislau Rezki wrote: > On Fri, Feb 19, 2021 at 12:23:57PM +0100, Uladzislau Rezki wrote: > > On Fri, Feb 19, 2021 at 12:17:38PM +0100, Sebastian Andrzej Siewior wrote: > > > On 2021-02-19 12:13:01 [+0100], Uladzislau Rezki wrote: > > > > I or Paul will

Re: [PATCH] workqueue: Remove rcu_read_lock/unlock() in workqueue_congested()

2021-02-18 Thread Paul E. McKenney
On Thu, Feb 18, 2021 at 11:04:00AM +0800, Lai Jiangshan wrote: > +CC Paul > > > On Wed, Feb 17, 2021 at 7:58 PM wrote: > > > > From: Zqiang > > > > The RCU read critical area already by preempt_disable/enable() > > (equivalent to rcu_read_lock_sched/unlock_sched()) mark, so remove > >

Re: [PATCH] kprobes: Fix to delay the kprobes jump optimization

2021-02-18 Thread Paul E. McKenney
ables it in subsys_initcall(). > > Note that non-optimized kprobes is still available after > early_initcall(). Only jump optimization is delayed. > > Fixes: 36dadef23fcc ("kprobes: Init kprobes in early_initcall") > Reported-by: Paul E. McKenney Thank you, but th

Re: [PATCH v3 clocksource] Do not mark clocks unstable due to delays

2021-02-17 Thread Paul E. McKenney
Hello! If there is a sufficient delay between reading the watchdog clock and the clock under test, the clock under test will be marked unstable through no fault of its own. This series checks for this, doing limited retries to get a good set of clock reads. If the clock is marked unstable and

Re: [PATCH v3 1/1] rcuscale: add kfree_rcu() single-argument scale test

2021-02-17 Thread Paul E. McKenney
f both have the same value (false or true) > both are randomly tested, otherwise only the one with value true > is tested. The value of this is that it allows testing of both > options with one test. > > Suggested-by: Paul E. McKenney > Signed-off-by: Uladzislau Rezki (So

Re: Should RCU_BOOST kernels use hrtimers in GP kthread?

2021-02-17 Thread Paul E. McKenney
On Wed, Feb 17, 2021 at 07:01:59PM +0100, Sebastian Andrzej Siewior wrote: > On 2021-02-17 07:54:47 [-0800], Paul E. McKenney wrote: > > > I though boosting is accomplished by acquiring a rt_mutex in a > > > rcu_read() section. Do you have some code to point me to, to

Re: [PATCH 2/2] rcu-tasks: add RCU-tasks self tests

2021-02-17 Thread Paul E. McKenney
On Wed, Feb 17, 2021 at 11:47:59PM +0900, Masami Hiramatsu wrote: > On Tue, 16 Feb 2021 09:30:03 -0800 > "Paul E. McKenney" wrote: > > > On Mon, Feb 15, 2021 at 12:28:26PM +0100, Sebastian Andrzej Siewior wrote: > > > On 2021-02-13 08:45:54 [-0800], Paul E. McK

Re: Should RCU_BOOST kernels use hrtimers in GP kthread?

2021-02-17 Thread Paul E. McKenney
On Wed, Feb 17, 2021 at 07:54:47AM -0800, Paul E. McKenney wrote: > On Wed, Feb 17, 2021 at 04:32:53PM +0100, Sebastian Andrzej Siewior wrote: > > On 2021-02-16 10:36:09 [-0800], Paul E. McKenney wrote: > > > Hello, Sebastian, > > > > Hi Paul, > > > > &

Re: Should RCU_BOOST kernels use hrtimers in GP kthread?

2021-02-17 Thread Paul E. McKenney
On Wed, Feb 17, 2021 at 04:32:53PM +0100, Sebastian Andrzej Siewior wrote: > On 2021-02-16 10:36:09 [-0800], Paul E. McKenney wrote: > > Hello, Sebastian, > > Hi Paul, > > > I punted on this for the moment by making RCU priority boosting testing > > depend on CONFIG

Should RCU_BOOST kernels use hrtimers in GP kthread?

2021-02-16 Thread Paul E. McKenney
Hello, Sebastian, I punted on this for the moment by making RCU priority boosting testing depend on CONFIG_PREEMPT_RT, but longer term I am wondering if RCU's various timed delays and timeouts should use hrtimers rather than normal timers in kernels built with CONFIG_RCU_BOOST. As it is, RCU

Re: [PATCH 1/2] rcuscale: add kfree_rcu() single-argument scale test

2021-02-16 Thread Paul E. McKenney
On Mon, Feb 15, 2021 at 05:27:05PM +0100, Uladzislau Rezki wrote: > On Tue, Feb 09, 2021 at 05:00:52PM -0800, Paul E. McKenney wrote: > > On Tue, Feb 09, 2021 at 09:13:43PM +0100, Uladzislau Rezki wrote: > > > On Thu, Feb 04, 2021 at 01:46:48PM -0800, Paul E. McKenney wrote: >

Re: [PATCH 2/2] rcu-tasks: add RCU-tasks self tests

2021-02-16 Thread Paul E. McKenney
On Mon, Feb 15, 2021 at 12:28:26PM +0100, Sebastian Andrzej Siewior wrote: > On 2021-02-13 08:45:54 [-0800], Paul E. McKenney wrote: > > Glad you like it! But let's see which (if any) of these patches solves > > the problem for Sebastian. > > Looking at that, is there

[tip: core/rcu] docs: Remove redundant "``" from Requirements.rst

2021-02-15 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: be06c2577eca6d9dbf61985d4078eb904024380f Gitweb: https://git.kernel.org/tip/be06c2577eca6d9dbf61985d4078eb904024380f Author:Paul E. McKenney AuthorDate:Mon, 09 Nov 2020 08:22:16 -08:00

[tip: core/rcu] doc: Remove obsolete RCU-bh and RCU-sched update-side API members

2021-02-15 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 2c8bce609f095a8879d3948e0c18d629881518dd Gitweb: https://git.kernel.org/tip/2c8bce609f095a8879d3948e0c18d629881518dd Author:Paul E. McKenney AuthorDate:Tue, 10 Nov 2020 16:17:42 -08:00

[tip: core/rcu] doc: Remove obsolete rcutree.rcu_idle_lazy_gp_delay boot parameter

2021-02-15 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 2252ec1464730ce718dc8087c13a419b9aa58758 Gitweb: https://git.kernel.org/tip/2252ec1464730ce718dc8087c13a419b9aa58758 Author:Paul E. McKenney AuthorDate:Thu, 10 Dec 2020 09:53:50 -08:00

[tip: core/rcu] srcu: Provide polling interfaces for Tiny SRCU grace periods

2021-02-15 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 8b5bd67cf6422b63ee100d76d8de8960ca2df7f0 Gitweb: https://git.kernel.org/tip/8b5bd67cf6422b63ee100d76d8de8960ca2df7f0 Author:Paul E. McKenney AuthorDate:Fri, 13 Nov 2020 12:54:48 -08:00

[tip: core/rcu] srcu: Provide polling interfaces for Tree SRCU grace periods

2021-02-15 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 5358c9fa54b09b5d3d7811b033aa0838c1bbaaf2 Gitweb: https://git.kernel.org/tip/5358c9fa54b09b5d3d7811b033aa0838c1bbaaf2 Author:Paul E. McKenney AuthorDate:Fri, 13 Nov 2020 17:31:55 -08:00

[tip: core/rcu] rcutorture: Prepare for ->start_gp_poll and ->poll_gp_state

2021-02-15 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: fd56f64b4e3b9c53fbb12ef74c6f1f5fde4cc1c8 Gitweb: https://git.kernel.org/tip/fd56f64b4e3b9c53fbb12ef74c6f1f5fde4cc1c8 Author:Paul E. McKenney AuthorDate:Fri, 13 Nov 2020 20:14:27 -08:00

[tip: core/rcu] srcu: Add comment explaining cookie overflow/wrap

2021-02-15 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 4e7ccfae52b39aeee93ed39d4184d50ea201fbef Gitweb: https://git.kernel.org/tip/4e7ccfae52b39aeee93ed39d4184d50ea201fbef Author:Paul E. McKenney AuthorDate:Sun, 15 Nov 2020 20:33:38 -08:00

[tip: core/rcu] rcutorture: Add writer-side tests of polling grace-period API

2021-02-15 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 0fd0548db13346bfb3bb23860ab270a32d6e385a Gitweb: https://git.kernel.org/tip/0fd0548db13346bfb3bb23860ab270a32d6e385a Author:Paul E. McKenney AuthorDate:Fri, 13 Nov 2020 20:43:59 -08:00

[tip: locking/core] tools/memory-model: Tie acquire loads to reads-from

2021-02-15 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the locking/core branch of tip: Commit-ID: 8881e7a774a8d14088d6c6fde8730660f74a3642 Gitweb: https://git.kernel.org/tip/8881e7a774a8d14088d6c6fde8730660f74a3642 Author:Paul E. McKenney AuthorDate:Fri, 06 Nov 2020 09:58:01 -08:00

[tip: core/rcu] doc: Update RCU requirements RCU_INIT_POINTER() description

2021-02-15 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: d756c74e6f6e76e99f8bffcea57833816dd335b6 Gitweb: https://git.kernel.org/tip/d756c74e6f6e76e99f8bffcea57833816dd335b6 Author:Paul E. McKenney AuthorDate:Wed, 09 Dec 2020 16:54:41 -08:00

[tip: core/rcu] srcu: Make Tiny SRCU use multi-bit grace-period counter

2021-02-15 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 74612a07b83fc46c2b2e6f71a541d55b024ebefc Gitweb: https://git.kernel.org/tip/74612a07b83fc46c2b2e6f71a541d55b024ebefc Author:Paul E. McKenney AuthorDate:Thu, 12 Nov 2020 16:34:09 -08:00

[tip: core/rcu] srcu: Provide internal interface to start a Tiny SRCU grace period

2021-02-15 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 1a893c711a600ab57526619b56e6f6b7be00956e Gitweb: https://git.kernel.org/tip/1a893c711a600ab57526619b56e6f6b7be00956e Author:Paul E. McKenney AuthorDate:Fri, 13 Nov 2020 09:37:39 -08:00

[tip: core/rcu] srcu: Document polling interfaces for Tree SRCU grace periods

2021-02-15 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: ee7f4a87a18cd3bb141b38e2ef0c3e53253cdf63 Gitweb: https://git.kernel.org/tip/ee7f4a87a18cd3bb141b38e2ef0c3e53253cdf63 Author:Paul E. McKenney AuthorDate:Wed, 18 Nov 2020 16:01:32 -08:00

[tip: core/rcu] srcu: Provide internal interface to start a Tree SRCU grace period

2021-02-15 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 29d2bb94a8a126ce80ffbb433b648b32fdea524e Gitweb: https://git.kernel.org/tip/29d2bb94a8a126ce80ffbb433b648b32fdea524e Author:Paul E. McKenney AuthorDate:Fri, 13 Nov 2020 10:08:09 -08:00

[tip: core/rcu] rcutorture: Add reader-side tests of polling grace-period API

2021-02-15 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: bc480a6354ef2e15c26c3bdbd0db647026e788a7 Gitweb: https://git.kernel.org/tip/bc480a6354ef2e15c26c3bdbd0db647026e788a7 Author:Paul E. McKenney AuthorDate:Sun, 15 Nov 2020 12:45:57 -08:00

[tip: core/rcu] rcutorture: Add testing for RCU's global memory ordering

2021-02-15 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 00504537f44422a99d97f615f2b3ee17cfba194d Gitweb: https://git.kernel.org/tip/00504537f44422a99d97f615f2b3ee17cfba194d Author:Paul E. McKenney AuthorDate:Thu, 29 Oct 2020 15:08:57 -07:00

[tip: core/rcu] scftorture: Add debug output for wrong-CPU warning

2021-02-15 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: f3ea978b712f768a02137e867aced5bfdcea670e Gitweb: https://git.kernel.org/tip/f3ea978b712f768a02137e867aced5bfdcea670e Author:Paul E. McKenney AuthorDate:Wed, 11 Nov 2020 10:12:05 -08:00

[tip: core/rcu] rcu: Mark obtuse portion of stall warning as internal debug

2021-02-15 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: b08ea1de6a8f8929c7dafd6f708799365fa90c11 Gitweb: https://git.kernel.org/tip/b08ea1de6a8f8929c7dafd6f708799365fa90c11 Author:Paul E. McKenney AuthorDate:Fri, 06 Nov 2020 13:52:31 -08:00

[tip: core/rcu] rcu: For RCU grace-period kthread starvation, dump last CPU it ran on

2021-02-15 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 243027a3c80564bf96e40437ffac46efb9f5f2b5 Gitweb: https://git.kernel.org/tip/243027a3c80564bf96e40437ffac46efb9f5f2b5 Author:Paul E. McKenney AuthorDate:Wed, 11 Nov 2020 16:08:01 -08:00

<    1   2   3   4   5   6   7   8   9   10   >