Re: [QUICKLIST 0/4] Arch independent quicklists V2

2007-03-13 Thread Paul Mackerras
Andrew Morton writes: Plus, we can get in a situation where take a cache-cold, known-zero page from the pte quicklist when there is a cache-hot, non-zero page sitting in the page allocator. I suspect that zeroing the cache-hot page would take a similar amount of time to a single miss agains

Re: [QUICKLIST 0/6] Arch independent quicklists V1

2007-03-12 Thread Paul Mackerras
David Miller writes: > I ported this to sparc64 as per the patch below, tested on > UP SunBlade1500 and 24 cpu Niagara T1000. Did you see any performance improvement? We used to have quicklists on ppc, but I remain to be convinced that they actually help. Also, I didn't understand why we have

Re: [QUICKLIST 0/6] Arch independent quicklists V1

2007-03-12 Thread Paul Mackerras
David Miller writes: I ported this to sparc64 as per the patch below, tested on UP SunBlade1500 and 24 cpu Niagara T1000. Did you see any performance improvement? We used to have quicklists on ppc, but I remain to be convinced that they actually help. Also, I didn't understand why we have to

Re: [patch 2/6 -rt] powerpc 2.6.20-rt8: to convert spinlocks to raw ones.

2007-03-07 Thread Paul Mackerras
Bill Huey (hui) writes: > The places that need to be reverted to raw spinlocks are generally either > acquired by function calls that allocate the spinlock at a terminal of the > kernel's lock graph or isolated from other callers completely (parts of the > timer for logic for instance). It's all

Re: [patch 2/6 -rt] powerpc 2.6.20-rt8: to convert spinlocks to raw ones.

2007-03-07 Thread Paul Mackerras
Sergei Shtylyov writes: > I've floowed up to my patch with such explanation. In the context of > an-rt > patch itself, it was just too clear, hence I didn't go into explanations in > the patch itself. :-) Well, it might be clear, to you, now, with the context in your head. But if such a

Re: [patch 2/6 -rt] powerpc 2.6.20-rt8: to convert spinlocks to raw ones.

2007-03-07 Thread Paul Mackerras
Sergei Shtylyov writes: > As I said, this was intended for the -rt patch, hence the question was > for > Ingo. I CC'ed the list just to keep people here in a loop. OK, fair enough, but I still think the patch description was inadequate. In the -rt context, I would at least expect to see

Re: [patch 2/6 -rt] powerpc 2.6.20-rt8: to convert spinlocks to raw ones.

2007-03-07 Thread Paul Mackerras
Sergei Shtylyov writes: > I've already sent a patch fixing this one (along with many others) a > month > ago: > > http://ozlabs.org/pipermail/linuxppc-dev/2007-February/031164.html > > I wonder iof it was ever considered... :-/ The entire patch description was just this: > Convert

Re: [patch 2/6 -rt] powerpc 2.6.20-rt8: to convert spinlocks to raw ones.

2007-03-07 Thread Paul Mackerras
Sergei Shtylyov writes: I've already sent a patch fixing this one (along with many others) a month ago: http://ozlabs.org/pipermail/linuxppc-dev/2007-February/031164.html I wonder iof it was ever considered... :-/ The entire patch description was just this: Convert the

Re: [patch 2/6 -rt] powerpc 2.6.20-rt8: to convert spinlocks to raw ones.

2007-03-07 Thread Paul Mackerras
Sergei Shtylyov writes: As I said, this was intended for the -rt patch, hence the question was for Ingo. I CC'ed the list just to keep people here in a loop. OK, fair enough, but I still think the patch description was inadequate. In the -rt context, I would at least expect to see some

Re: [patch 2/6 -rt] powerpc 2.6.20-rt8: to convert spinlocks to raw ones.

2007-03-07 Thread Paul Mackerras
Sergei Shtylyov writes: I've floowed up to my patch with such explanation. In the context of an-rt patch itself, it was just too clear, hence I didn't go into explanations in the patch itself. :-) Well, it might be clear, to you, now, with the context in your head. But if such a patch

Re: [patch 2/6 -rt] powerpc 2.6.20-rt8: to convert spinlocks to raw ones.

2007-03-07 Thread Paul Mackerras
Bill Huey (hui) writes: The places that need to be reverted to raw spinlocks are generally either acquired by function calls that allocate the spinlock at a terminal of the kernel's lock graph or isolated from other callers completely (parts of the timer for logic for instance). It's all

Re: The performance and behaviour of the anti-fragmentation related patches

2007-03-05 Thread Paul Mackerras
Linus Torvalds writes: > The point being that in the guests, hotunplug is almost useless (for > bigger ranges), and we're much better off just telling the virtualization > hosts on a per-page level whether we care about a page or not, than to > worry about fragmentation. We don't have that

Re: The performance and behaviour of the anti-fragmentation related patches

2007-03-05 Thread Paul Mackerras
Linus Torvalds writes: The point being that in the guests, hotunplug is almost useless (for bigger ranges), and we're much better off just telling the virtualization hosts on a per-page level whether we care about a page or not, than to worry about fragmentation. We don't have that luxury

Re: [patch] Fixes and cleanups for earlyprintk aka boot console.

2007-03-04 Thread Paul Mackerras
Gerd Hoffmann writes: > This patch fixes the console selection code to *not* consider a boot > console a full-featured one, so the first non-boot console registering > will become the default console instead. This way the unregister call > for the boot console in the register_console() function

Re: [patch] Fixes and cleanups for earlyprintk aka boot console.

2007-03-04 Thread Paul Mackerras
Gerd Hoffmann writes: This patch fixes the console selection code to *not* consider a boot console a full-featured one, so the first non-boot console registering will become the default console instead. This way the unregister call for the boot console in the register_console() function

Re: [patch 02/11] syslets: add syslet.h include file, user API/ABI definitions

2007-02-18 Thread Paul Mackerras
Ingo Molnar writes: > add include/linux/syslet.h which contains the user-space API/ABI > declarations. Add the new header to include/linux/Kbuild as well. > +struct syslet_uatom { > + unsigned long flags; > + unsigned long nr; > +

Re: [patch 02/11] syslets: add syslet.h include file, user API/ABI definitions

2007-02-18 Thread Paul Mackerras
Ingo Molnar writes: add include/linux/syslet.h which contains the user-space API/ABI declarations. Add the new header to include/linux/Kbuild as well. +struct syslet_uatom { + unsigned long flags; + unsigned long nr; + long

Re: [patch 4/4] ipmi: add new IPMI nmi watchdog handling

2007-02-14 Thread Paul Mackerras
Andrew Morton writes: > This is all fairly unpleasant. > > What architecture is preventing us from using DIE_NMI_POST on all > architectures which support ipmi? ia64? > > It would be better to simply require that all ipmi-using architectures > implement notify_die(DIE_NMI_POST, ...). We're

Re: [patch 4/4] ipmi: add new IPMI nmi watchdog handling

2007-02-14 Thread Paul Mackerras
Andrew Morton writes: This is all fairly unpleasant. What architecture is preventing us from using DIE_NMI_POST on all architectures which support ipmi? ia64? It would be better to simply require that all ipmi-using architectures implement notify_die(DIE_NMI_POST, ...). We're starting

Re: [patch 4/9] Remove the TSC synchronization on SMP machines

2007-02-13 Thread Paul Mackerras
Andi Kleen writes: > Just to avoid spreading misinformation: modulo some new broken hardware > (which we always try to work around when found) i386/x86-64 gettimeofday > is monotonic. AFAIK on the currently known hardware it should be generally > ok. > > However ntpd can always screw you up,

Re: [patch 4/9] Remove the TSC synchronization on SMP machines

2007-02-13 Thread Paul Mackerras
Andi Kleen writes: Just to avoid spreading misinformation: modulo some new broken hardware (which we always try to work around when found) i386/x86-64 gettimeofday is monotonic. AFAIK on the currently known hardware it should be generally ok. However ntpd can always screw you up, but

Re: -mm merge plans for 2.6.21

2007-02-08 Thread Paul Mackerras
Andrew Morton writes: > Once a subsystem has a subsystem tree (git or quilt) I basically never > merge anything which belongs to that tree. It's always > > originator->mm->subsystemtree->Linus > > If the subsystem tree maintainer wants to tell me "I can't be bothered > setting up a git

Kbuild change breaks the ppc64 build

2007-02-08 Thread Paul Mackerras
Commit 5de043f4bd11a9e0a3e8daec7d1905da575a76b7 breaks the build on 64-bit powerpc because we no longer get the -m64 flag passed to gcc. There is code in arch/powerpc/Makefile which adds (or used to add) -m64 to AS, LD and CC if we are running on a 64-bit machine (which I am) and have a biarch

Kbuild change breaks the ppc64 build

2007-02-08 Thread Paul Mackerras
Commit 5de043f4bd11a9e0a3e8daec7d1905da575a76b7 breaks the build on 64-bit powerpc because we no longer get the -m64 flag passed to gcc. There is code in arch/powerpc/Makefile which adds (or used to add) -m64 to AS, LD and CC if we are running on a 64-bit machine (which I am) and have a biarch

Re: -mm merge plans for 2.6.21

2007-02-08 Thread Paul Mackerras
Andrew Morton writes: Once a subsystem has a subsystem tree (git or quilt) I basically never merge anything which belongs to that tree. It's always originator-mm-subsystemtree-Linus If the subsystem tree maintainer wants to tell me I can't be bothered setting up a git pull for

Re: [PATCH] Missing include in include/asm-powerpc/prom.h

2007-02-05 Thread Paul Mackerras
Mathieu Desnoyers writes: > * Benjamin Herrenschmidt ([EMAIL PROTECTED]) wrote: > > On Mon, 2007-02-05 at 09:29 -0500, Mathieu Desnoyers wrote: > > > Missing include in include/asm-powerpc/prom.h > > > > > > include/asm-powerpc/prom.h needs to include asm/irq.h because it uses > > >

Re: [RFC,PATCH] CELL PPU Oprofile SPU profiling updated patch

2007-02-05 Thread Paul Mackerras
Carl Love writes: > This is the first update to the patch previously posted by Maynard > Johnson as "PATCH 4/4. Add support to OProfile for profiling CELL". Is it really necessary to keep posting all these messages to three lists? Wouldn't cbe-oss-dev be sufficient? Paul. - To unsubscribe

Re: [RFC,PATCH] CELL PPU Oprofile SPU profiling updated patch

2007-02-05 Thread Paul Mackerras
Carl Love writes: This is the first update to the patch previously posted by Maynard Johnson as PATCH 4/4. Add support to OProfile for profiling CELL. Is it really necessary to keep posting all these messages to three lists? Wouldn't cbe-oss-dev be sufficient? Paul. - To unsubscribe from

Re: [PATCH] Missing include in include/asm-powerpc/prom.h

2007-02-05 Thread Paul Mackerras
Mathieu Desnoyers writes: * Benjamin Herrenschmidt ([EMAIL PROTECTED]) wrote: On Mon, 2007-02-05 at 09:29 -0500, Mathieu Desnoyers wrote: Missing include in include/asm-powerpc/prom.h include/asm-powerpc/prom.h needs to include asm/irq.h because it uses irq_of_parse_and_map and

Re: [PATCH 0/6] MSI portability cleanups

2007-01-29 Thread Paul Mackerras
Michael Ellerman writes: > You can read config space, but it's not clear to me if the HV is allowed > to filter it and hide things. It's also possible that the device It appears that the HV does not prevent us from reading or writing any config space registers for functions that are assigned to

Re: [PATCH 0/6] MSI portability cleanups

2007-01-29 Thread Paul Mackerras
Benjamin Herrenschmidt writes: > > I'd hate to hit a different Hypervisor that did something close but > > not quite the same and have the code fail then. So definitely > > avoiding touching pci config space at all in the calls seems to make a > > lot of sense. This includes avoiding

Re: [PATCH 0/6] MSI portability cleanups

2007-01-29 Thread Paul Mackerras
Benjamin Herrenschmidt writes: I'd hate to hit a different Hypervisor that did something close but not quite the same and have the code fail then. So definitely avoiding touching pci config space at all in the calls seems to make a lot of sense. This includes avoiding

Re: [PATCH 0/6] MSI portability cleanups

2007-01-29 Thread Paul Mackerras
Michael Ellerman writes: You can read config space, but it's not clear to me if the HV is allowed to filter it and hide things. It's also possible that the device It appears that the HV does not prevent us from reading or writing any config space registers for functions that are assigned to

Re: [PATCH 1/6] msi: Kill msi_lookup_irq

2007-01-28 Thread Paul Mackerras
Eric W. Biederman writes: > @@ -693,15 +664,14 @@ int pci_enable_msi(struct pci_dev* dev) > if (!pos) > return -EINVAL; > > - WARN_ON(!msi_lookup_irq(dev, PCI_CAP_ID_MSI)); > + WARN_ON(!!dev->msi_enabled); Minor nit: what's wrong with just WARN_ON(dev->msi_enabled)

Re: [PATCH 1/6] msi: Kill msi_lookup_irq

2007-01-28 Thread Paul Mackerras
Eric W. Biederman writes: @@ -693,15 +664,14 @@ int pci_enable_msi(struct pci_dev* dev) if (!pos) return -EINVAL; - WARN_ON(!msi_lookup_irq(dev, PCI_CAP_ID_MSI)); + WARN_ON(!!dev-msi_enabled); Minor nit: what's wrong with just WARN_ON(dev-msi_enabled) ? Also

Re: [PATCH 7/10] local_t : powerpc

2007-01-24 Thread Paul Mackerras
Mathieu Desnoyers writes: > +static __inline__ int local_dec_if_positive(local_t *l) > +{ > + int t; > + > + __asm__ __volatile__( > +"1: lwarx %0,0,%1 # local_dec_if_positive\n\ > + addic. %0,%0,-1\n\ > + blt-2f\n" > + PPC405_ERR77(0,%1) > +"stwcx.

Re: [PATCH 7/10] local_t : powerpc

2007-01-24 Thread Paul Mackerras
Mathieu Desnoyers writes: +static __inline__ int local_dec_if_positive(local_t *l) +{ + int t; + + __asm__ __volatile__( +1: lwarx %0,0,%1 # local_dec_if_positive\n\ + addic. %0,%0,-1\n\ + blt-2f\n + PPC405_ERR77(0,%1) +stwcx. %0,0,%1\n\ +

Re: [PATCH] ppc: cpm2_pic of_node_get cleanup

2007-01-08 Thread Paul Mackerras
Mariusz Kozlowski writes: > This patch removes redundant argument check for of_node_get(). > > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> > > arch/powerpc/sysdev/cpm2_pic.c |4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff -upr

Re: [PATCH] Clean up PPC code to use canonical alignment macros from kernel.h.

2007-01-08 Thread Paul Mackerras
Robert P. J. Day writes: > Clean up some PowerPC source files to use the canonical alignment > macros from kernel.h, and add an ALIGN_DOWN() macro to kernel.h for > symmetry. [snip] > and, no, i didn't test-compile this as i don't have a PPC > cross-compiler at the moment. sorry. Yeah. I

Re: [PATCH] Clean up PPC code to use canonical alignment macros from kernel.h.

2007-01-08 Thread Paul Mackerras
Robert P. J. Day writes: Clean up some PowerPC source files to use the canonical alignment macros from kernel.h, and add an ALIGN_DOWN() macro to kernel.h for symmetry. [snip] and, no, i didn't test-compile this as i don't have a PPC cross-compiler at the moment. sorry. Yeah. I

Re: [PATCH] ppc: cpm2_pic of_node_get cleanup

2007-01-08 Thread Paul Mackerras
Mariusz Kozlowski writes: This patch removes redundant argument check for of_node_get(). Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] arch/powerpc/sysdev/cpm2_pic.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff -upr

Re: [2.6 patch] powerpc: remove the broken Gemini support

2006-12-19 Thread Paul Mackerras
Roman Zippel writes: > Well, there are still patches umerged for over a year, they probably still > apply mostly. Please rebase and repost them, if you want them to go in. Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [PATCH] powerpc: use is_init()

2006-12-19 Thread Paul Mackerras
Akinobu Mita writes: > Use is_init() rather than hard coded pid comparison. What's the context of this patch? Why is this a good thing to do? Doing a git grep -w is_init on Linus' current git tree reveals an is_init() in arch/parisc/kernel/module.c, which looks to be something different, but

Re: [PATCH] powerpc: use is_init()

2006-12-19 Thread Paul Mackerras
Akinobu Mita writes: Use is_init() rather than hard coded pid comparison. What's the context of this patch? Why is this a good thing to do? Doing a git grep -w is_init on Linus' current git tree reveals an is_init() in arch/parisc/kernel/module.c, which looks to be something different, but no

Re: [2.6 patch] powerpc: remove the broken Gemini support

2006-12-19 Thread Paul Mackerras
Roman Zippel writes: Well, there are still patches umerged for over a year, they probably still apply mostly. Please rebase and repost them, if you want them to go in. Paul. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED]

Re: GPL only modules

2006-12-18 Thread Paul Mackerras
Linus Torvalds writes: > > > On Tue, 19 Dec 2006, Paul Mackerras wrote: > > > > There is in fact a pretty substantial non-technical difference between > > static and dynamic linking. If I create a binary by static linking > > and I include some library, and I

Re: GPL only modules

2006-12-18 Thread Paul Mackerras
Linus Torvalds writes: > "Derivation" has nothing to do with "linking". Either it's derived or it > is not, and "linking" simply doesn't matter. It doesn't matter whether > it's static or dynamic. That's a detail that simply doesn't have anythign > at all to do with "derivative work". There

Re: GPL only modules

2006-12-18 Thread Paul Mackerras
Junio C Hamano writes: > Excuse me, but are you two discussing "ld"? ;-) Oops. Yes. :) Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: GPL only modules

2006-12-18 Thread Paul Mackerras
Junio C Hamano writes: Excuse me, but are you two discussing ld? ;-) Oops. Yes. :) Paul. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: GPL only modules

2006-12-18 Thread Paul Mackerras
Linus Torvalds writes: Derivation has nothing to do with linking. Either it's derived or it is not, and linking simply doesn't matter. It doesn't matter whether it's static or dynamic. That's a detail that simply doesn't have anythign at all to do with derivative work. There is in fact a

Re: GPL only modules

2006-12-18 Thread Paul Mackerras
Linus Torvalds writes: On Tue, 19 Dec 2006, Paul Mackerras wrote: There is in fact a pretty substantial non-technical difference between static and dynamic linking. If I create a binary by static linking and I include some library, and I distribute that binary to someone else

Re: GPL only modules

2006-12-17 Thread Paul Mackerras
Linus Torvalds writes: > Why do people think that using "ln" is _any_ different from using > "mkisofs". Both create one file that contains multiple pieces. What's the > difference - really? The difference - really - at least for static linking - is that "ln" makes modifications to each piece

Re: GPL only modules

2006-12-17 Thread Paul Mackerras
Linus Torvalds writes: Why do people think that using ln is _any_ different from using mkisofs. Both create one file that contains multiple pieces. What's the difference - really? The difference - really - at least for static linking - is that ln makes modifications to each piece to make

Re: Bug: early_pfn_in_nid() called when not early

2006-12-13 Thread Paul Mackerras
Mike Kravetz writes: > Thanks for the debug work! Just curious if you really need > CONFIG_NODES_SPAN_OTHER_NODES defined for your platform? Can you get > those types of memory layouts? If not, an easy/immediate fix for you > might be to simply turn off the option. We really need

Re: Bug: early_pfn_in_nid() called when not early

2006-12-13 Thread Paul Mackerras
Mike Kravetz writes: Thanks for the debug work! Just curious if you really need CONFIG_NODES_SPAN_OTHER_NODES defined for your platform? Can you get those types of memory layouts? If not, an easy/immediate fix for you might be to simply turn off the option. We really need

Re: [PATCH 1/2] WorkStruct: Add assign_bits() to give an atomic-bitops safe assignment

2006-12-12 Thread Paul Mackerras
Russell King writes: > Why can't we just use atomic_t for this? On 64-bit platforms, atomic_t tends to be 4 bytes, whereas bitops work on arrays of unsigned long, i.e. multiples of 8 bytes. We could use atomic_long_t for this, however. Paul. - To unsubscribe from this list: send the line

Re: [PATCH 1/2] WorkStruct: Add assign_bits() to give an atomic-bitops safe assignment

2006-12-12 Thread Paul Mackerras
Russell King writes: Why can't we just use atomic_t for this? On 64-bit platforms, atomic_t tends to be 4 bytes, whereas bitops work on arrays of unsigned long, i.e. multiples of 8 bytes. We could use atomic_long_t for this, however. Paul. - To unsubscribe from this list: send the line

Re: 2.6.19-git13: uts banner changes break SLES9 (at least)

2006-12-11 Thread Paul Mackerras
Linus Torvalds writes: > On Mon, 11 Dec 2006, Olaf Hering wrote: > > > > arch/powerpc/boot/wrapper:156:version=`${CROSS}strings "$kernel" | grep > > '^Linux version [-0-9.]' | \ > > This is also obviously broken (and really sad), but actually ends up being > better than what

Re: 2.6.19-git13: uts banner changes break SLES9 (at least)

2006-12-11 Thread Paul Mackerras
Linus Torvalds writes: On Mon, 11 Dec 2006, Olaf Hering wrote: arch/powerpc/boot/wrapper:156:version=`${CROSS}strings $kernel | grep '^Linux version [-0-9.]' | \ This is also obviously broken (and really sad), but actually ends up being better than what get_kernel_version

Re: -mm merge plans for 2.6.20

2006-12-04 Thread Paul Mackerras
Andrew Morton writes: > ppc-m48t35-add-missing-bracket.patch > powerpc-replace-kmallocmemset-with-kzalloc.patch These are already in Linus' tree. > Am holding onto these until the powerpc git tree gets un-messied up. It should be fine now. Linus has pulled it, so there are currently no

Re: -mm merge plans for 2.6.20

2006-12-04 Thread Paul Mackerras
Andrew Morton writes: ppc-m48t35-add-missing-bracket.patch powerpc-replace-kmallocmemset-with-kzalloc.patch These are already in Linus' tree. Am holding onto these until the powerpc git tree gets un-messied up. It should be fine now. Linus has pulled it, so there are currently no changes

Re: [2.6 patch] arch/powerpc/Kconfig: fix the EMBEDDED6xx dependencies

2006-12-03 Thread Paul Mackerras
Adrian Bunk writes: > This patch changes the EMBEDDED6xx dependencies to the equivalent > dependency that seems to have been intended. Nack - CONFIG_EMBEDDED6xx is going away entirely, soon. Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [2.6 patch] arch/powerpc/Kconfig: fix the EMBEDDED6xx dependencies

2006-12-03 Thread Paul Mackerras
Adrian Bunk writes: This patch changes the EMBEDDED6xx dependencies to the equivalent dependency that seems to have been intended. Nack - CONFIG_EMBEDDED6xx is going away entirely, soon. Paul. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [PATCH 20/20] x86_64: Move CPU verification code to common file

2006-11-18 Thread Paul Mackerras
Andi Kleen writes: > On Friday 17 November 2006 23:59, Vivek Goyal wrote: > > > + * Copyright (c) 2006-2007 Vivek Goyal ([EMAIL PROTECTED]) > > Normally it's not ok to take sole copyright on code that you mostly copied ... Is this a case where the original had no copyright notice? If so,

Re: [PATCH 20/20] x86_64: Move CPU verification code to common file

2006-11-18 Thread Paul Mackerras
Andi Kleen writes: On Friday 17 November 2006 23:59, Vivek Goyal wrote: + * Copyright (c) 2006-2007 Vivek Goyal ([EMAIL PROTECTED]) Normally it's not ok to take sole copyright on code that you mostly copied ... Is this a case where the original had no copyright notice? If so, what do

Re: [PATCH consolidate sys_ptrace

2005-11-01 Thread Paul Mackerras
) > > > Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> Acked-by: Paul Mackerras <[EMAIL PROTECTED]>

Re: [PATCH consolidate sys_ptrace

2005-11-01 Thread Paul Mackerras
] Acked-by: Paul Mackerras [EMAIL PROTECTED]

Re: [PATCH 1/20] inflate: lindent and manual formatting changes

2005-10-31 Thread Paul Mackerras
Matt, My concern about this series of patches is that it will make it harder to keep the kernel zlib in sync with the upstream zlib. Are you signing up to track the upstream zlib and apply any changes made there to the kernel version, for the forseeable future? Paul.

Re: [PATCH 1/20] inflate: lindent and manual formatting changes

2005-10-31 Thread Paul Mackerras
Matt, My concern about this series of patches is that it will make it harder to keep the kernel zlib in sync with the upstream zlib. Are you signing up to track the upstream zlib and apply any changes made there to the kernel version, for the forseeable future? Paul.

Re: [PATCH 1/2] pci: Block config access during BIST (resend)

2005-09-07 Thread Paul Mackerras
Grant Grundler writes: > I would argue it more obvious. People looking at the code > are immediately going to realize it was a deliberate choice to > not use a spinlock. It achieves exactly the same effect as spin_lock/spin_unlock, just more verbosely. :) > > and it precludes the sorts of

Re: [PATCH 1/2] pci: Block config access during BIST (resend)

2005-09-07 Thread Paul Mackerras
Grant Grundler writes: I would argue it more obvious. People looking at the code are immediately going to realize it was a deliberate choice to not use a spinlock. It achieves exactly the same effect as spin_lock/spin_unlock, just more verbosely. :) and it precludes the sorts of

Re: [PATCH 1/2] pci: Block config access during BIST (resend)

2005-09-06 Thread Paul Mackerras
Grant Grundler writes: > Ok this is good example - I see what the problem is. > You could use the following sequence too then: > pci_block_user_cfg_access > pci_save_state > block_ucfg_access = 1 > mb() > while (spin_is_locked(_lock))

Re: [PATCH] PPC64: large INITRD causes kernel not to boot [UPDATE]

2005-09-06 Thread Paul Mackerras
Mark Bellon writes: > Simply put the existing code has a fixed reservation (claim) address and > once the kernel plus initrd image are large enough to pass this address > all sorts of bad things occur. The fix is the dynamically establish the > first claim address above the loaded kernel plus

Re: [PATCH] PPC64: large INITRD causes kernel not to boot [UPDATE]

2005-09-06 Thread Paul Mackerras
Mark Bellon writes: Simply put the existing code has a fixed reservation (claim) address and once the kernel plus initrd image are large enough to pass this address all sorts of bad things occur. The fix is the dynamically establish the first claim address above the loaded kernel plus

Re: [PATCH 1/2] pci: Block config access during BIST (resend)

2005-09-06 Thread Paul Mackerras
Grant Grundler writes: Ok this is good example - I see what the problem is. You could use the following sequence too then: pci_block_user_cfg_access pci_save_state block_ucfg_access = 1 mb() while (spin_is_locked(pci_lock))

[PATCH] Small rearrangement of PCI probing code

2005-09-05 Thread Paul Mackerras
to do on logically-partitioned pSeries systems. Signed-off-by: Paul Mackerras <[EMAIL PROTECTED]> --- drivers/pci/pci.h |1 - drivers/pci/probe.c | 50 +- include/linux/pci.h |3 +++ 3 files changed, 36 insertions(+), 18 deletions(-)

[PATCH] Small rearrangement of PCI probing code

2005-09-05 Thread Paul Mackerras
to do on logically-partitioned pSeries systems. Signed-off-by: Paul Mackerras [EMAIL PROTECTED] --- drivers/pci/pci.h |1 - drivers/pci/probe.c | 50 +- include/linux/pci.h |3 +++ 3 files changed, 36 insertions(+), 18 deletions(-) diff -urN

Re: [PATCH 1/2] pci: Block config access during BIST (resend)

2005-09-02 Thread Paul Mackerras
Grant Grundler writes: > On Fri, Sep 02, 2005 at 06:56:35PM -0500, Brian King wrote: > > Andrew Morton wrote: > > >Brian King <[EMAIL PROTECTED]> wrote: > > > > > >>+void pci_block_user_cfg_access(struct pci_dev *dev) > > >>+{ > > >>+ unsigned long flags; > > >>+ > > >>+ pci_save_state(dev); > >

Re: [PATCH 1/2] pci: Block config access during BIST (resend)

2005-09-02 Thread Paul Mackerras
Grant Grundler writes: On Fri, Sep 02, 2005 at 06:56:35PM -0500, Brian King wrote: Andrew Morton wrote: Brian King [EMAIL PROTECTED] wrote: +void pci_block_user_cfg_access(struct pci_dev *dev) +{ + unsigned long flags; + + pci_save_state(dev); + spin_lock_irqsave(pci_lock,

Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines

2005-08-29 Thread Paul Mackerras
Linas Vepstas writes: > > One way to clean this up would be to make rpaphp the driver for the > > EADS bridges (from the pci code's point of view). > > I guess I don't understand what that means. Are you suggesting moving > pSeries_pci.c into the rpaphp code directory? No, not at all. :)

Re: [PATCH] MPC8xx PCMCIA driver

2005-08-29 Thread Paul Mackerras
Marcelo Tosatti writes: > The memory map structure which contains device configuration/registers > is _always_ directly mapped with pte's (the 8xx is a chip with builtin > UART/network/etc functionality). > > I don't think there is a need to use read/write acessors. Generally on PowerPC you

Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines

2005-08-29 Thread Paul Mackerras
Linas Vepstas writes: > Actually, no. There are three issues: > 1) hotplug routines are called from within kernel. GregKH has stated on >multiple occasions that doing this is wrong/bad/evil. This includes >calling hot-unplug. > > 2) As a result, the code to call hot-unplug is a bit

Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines

2005-08-29 Thread Paul Mackerras
Linas Vepstas writes: Actually, no. There are three issues: 1) hotplug routines are called from within kernel. GregKH has stated on multiple occasions that doing this is wrong/bad/evil. This includes calling hot-unplug. 2) As a result, the code to call hot-unplug is a bit messy. In

Re: [PATCH] MPC8xx PCMCIA driver

2005-08-29 Thread Paul Mackerras
Marcelo Tosatti writes: The memory map structure which contains device configuration/registers is _always_ directly mapped with pte's (the 8xx is a chip with builtin UART/network/etc functionality). I don't think there is a need to use read/write acessors. Generally on PowerPC you need to

Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines

2005-08-29 Thread Paul Mackerras
Linas Vepstas writes: One way to clean this up would be to make rpaphp the driver for the EADS bridges (from the pci code's point of view). I guess I don't understand what that means. Are you suggesting moving pSeries_pci.c into the rpaphp code directory? No, not at all. :) I'm

Re: [PATCH] Remove race between con_open and con_close

2005-08-27 Thread Paul Mackerras
Russell King writes: > Have you looked at how serial_core handles this kind of problem in > its open and close methods? I put some comments in there because > of the issue, after thinking about it fairly carefully. Yes, albeit briefly; the problem in con_open is much simpler because we never

[PATCH] Remove race between con_open and con_close

2005-08-27 Thread Paul Mackerras
get a situation where con_open sees tty->driver_data != NULL and then con_close on a different fd clears tty->driver_data, because tty->count is incremented before con_open is called. Thus this patch eliminates the race, and in fact with this patch my laptop doesn't oops. Could this go into 2.6.1

[PATCH] Remove race between con_open and con_close

2005-08-27 Thread Paul Mackerras
and then con_close on a different fd clears tty-driver_data, because tty-count is incremented before con_open is called. Thus this patch eliminates the race, and in fact with this patch my laptop doesn't oops. Could this go into 2.6.13 please? Signed-off-by: Paul Mackerras [EMAIL PROTECTED

Re: [PATCH] Remove race between con_open and con_close

2005-08-27 Thread Paul Mackerras
Russell King writes: Have you looked at how serial_core handles this kind of problem in its open and close methods? I put some comments in there because of the issue, after thinking about it fairly carefully. Yes, albeit briefly; the problem in con_open is much simpler because we never need

Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines

2005-08-25 Thread Paul Mackerras
Benjamin Herrenschmidt writes: > Ok, so what is the problem then ? Why do we have to wait at all ? Why > not just unplug/replug right away ? We'd have to be absolutely certain that the driver could not possibly take another interrupt or try to access the device on behalf of the old instance of

Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines

2005-08-25 Thread Paul Mackerras
Benjamin Herrenschmidt writes: Ok, so what is the problem then ? Why do we have to wait at all ? Why not just unplug/replug right away ? We'd have to be absolutely certain that the driver could not possibly take another interrupt or try to access the device on behalf of the old instance of the

Re: cpu_exclusive sched domains fix broke ppc64

2005-08-24 Thread Paul Mackerras
Paul Jackson writes: > ... however ... question for Paul M. ... what version of gcc did this fail > on? The gcc-4.0.2 in Debian/ppc sid, which is biarch. > I finally got my crosstools setup working for me again, and building > a powerpc64 using gcc-3.4.0 on my Intel PC box does _not_ fail.

Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines

2005-08-24 Thread Paul Mackerras
Linas Vepstas writes: > The meta-issue that I'd like to reach consensus on first is whether > there should be any hot-plug recovery attempted at all. Removing > hot-plug-recovery support will make many of the issues you raise > to be moot. Yes, this probably the thorniest issue we have. My

Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines

2005-08-24 Thread Paul Mackerras
I wrote: > Linas Vepstas writes: > > In this patch at least, your mailer seems to have blanked out lines > that match ^[-+]$. Could you send them to me again with a different > mailer or put them on a web or ftp site somewhere? I got 3 copies of each of these mails, one directly, one through

Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines

2005-08-24 Thread Paul Mackerras
Linas Vepstas writes: The meta-issue that I'd like to reach consensus on first is whether there should be any hot-plug recovery attempted at all. Removing hot-plug-recovery support will make many of the issues you raise to be moot. Yes, this probably the thorniest issue we have. My

Re: cpu_exclusive sched domains fix broke ppc64

2005-08-24 Thread Paul Mackerras
Paul Jackson writes: ... however ... question for Paul M. ... what version of gcc did this fail on? The gcc-4.0.2 in Debian/ppc sid, which is biarch. I finally got my crosstools setup working for me again, and building a powerpc64 using gcc-3.4.0 on my Intel PC box does _not_ fail. That

Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines

2005-08-24 Thread Paul Mackerras
I wrote: Linas Vepstas writes: In this patch at least, your mailer seems to have blanked out lines that match ^[-+]$. Could you send them to me again with a different mailer or put them on a web or ftp site somewhere? I got 3 copies of each of these mails, one directly, one through

Re: [PATCH] (20/43) Kconfig fix (ppc32 SMP dependencies)

2005-08-23 Thread Paul Mackerras
Al Viro writes: > ppc SMP is supported only for 6xx/POWER3/POWER4 - i.e. ones that have > PPC_STD_MMU. Dependency fixed. > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> Acked-by: Paul Mackerras <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line &

Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines

2005-08-23 Thread Paul Mackerras
Linas Vepstas writes: In this patch at least, your mailer seems to have blanked out lines that match ^[-+]$. Could you send them to me again with a different mailer or put them on a web or ftp site somewhere? Thanks, Paul. - To unsubscribe from this list: send the line "unsubscribe

Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines

2005-08-23 Thread Paul Mackerras
Linas Vepstas writes: In this patch at least, your mailer seems to have blanked out lines that match ^[-+]$. Could you send them to me again with a different mailer or put them on a web or ftp site somewhere? Thanks, Paul. - To unsubscribe from this list: send the line unsubscribe linux-kernel

<    3   4   5   6   7   8   9   10   11   12   >