Re: [PATCH] fs: sync: fixed performance regression

2013-07-12 Thread Paul Taysom
`On Fri, Jul 12, 2013 at 8:43 AM, Jan Kara wrote: > On Thu 11-07-13 13:58:32, Jan Kara wrote: >> On Thu 11-07-13 12:53:46, Jan Kara wrote: >> > On Wed 10-07-13 16:12:36, Paul Taysom wrote: >> > > The following commit introduced a 10x regression for >> >

Re: [PATCH] fs: sync: fixed performance regression

2013-07-12 Thread Paul Taysom
`On Fri, Jul 12, 2013 at 8:43 AM, Jan Kara j...@suse.cz wrote: On Thu 11-07-13 13:58:32, Jan Kara wrote: On Thu 11-07-13 12:53:46, Jan Kara wrote: On Wed 10-07-13 16:12:36, Paul Taysom wrote: The following commit introduced a 10x regression for syncing inodes in ext4 with relatime

Re: [PATCH] fs: sync: fixed performance regression

2013-07-11 Thread Paul Taysom
On Thu, Jul 11, 2013 at 4:58 AM, Jan Kara wrote: > On Thu 11-07-13 12:53:46, Jan Kara wrote: >> On Wed 10-07-13 16:12:36, Paul Taysom wrote: >> > The following commit introduced a 10x regression for >> > syncing inodes in ext4 with relatime enabled where just >&

Re: [PATCH] fs: sync: fixed performance regression

2013-07-11 Thread Paul Taysom
On Thu, Jul 11, 2013 at 4:58 AM, Jan Kara j...@suse.cz wrote: On Thu 11-07-13 12:53:46, Jan Kara wrote: On Wed 10-07-13 16:12:36, Paul Taysom wrote: The following commit introduced a 10x regression for syncing inodes in ext4 with relatime enabled where just the atime had been modified

Re: [PATCH] fs: sync: fixed performance regression

2013-07-10 Thread Paul Taysom
Third time is the charm crbug.com/240411 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] fs: sync: fixed performance regression

2013-07-10 Thread Paul Taysom
On Wed, Jul 10, 2013 at 4:56 PM, Dave Jones wrote: > On Wed, Jul 10, 2013 at 04:12:36PM -0700, Paul Taysom wrote: > > > Note, when running the test, the slow down doesn't always happen > > but most of the tests will show a slow down. > > > > In response to crb

Re: [PATCH] fs: sync: fixed performance regression

2013-07-10 Thread Paul Taysom
On Wed, Jul 10, 2013 at 4:12 PM, Paul Taysom wrote: > The following commit introduced a 10x regression for > syncing inodes in ext4 with relatime enabled where just > the atime had been modified. > > commit 4ea425b63a3dfeb7707fc7cc7161c11a51e871ed > Author: Jan Kara >

[PATCH] fs: sync: fixed performance regression

2013-07-10 Thread Paul Taysom
. In response to crbug.com/240422 Signed-off-by: Paul Taysom --- fs/sync.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/fs/sync.c b/fs/sync.c index 905f3f6..55c3316 100644 --- a/fs/sync.c +++ b/fs/sync.c @@ -73,6 +73,12 @@ static void sync_inodes_one_sb(struct super_block *sb, void *arg

[PATCH] fs: sync: fixed performance regression

2013-07-10 Thread Paul Taysom
down. In response to crbug.com/240422 Signed-off-by: Paul Taysom tay...@chromium.org --- fs/sync.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/fs/sync.c b/fs/sync.c index 905f3f6..55c3316 100644 --- a/fs/sync.c +++ b/fs/sync.c @@ -73,6 +73,12 @@ static void sync_inodes_one_sb

Re: [PATCH] fs: sync: fixed performance regression

2013-07-10 Thread Paul Taysom
On Wed, Jul 10, 2013 at 4:12 PM, Paul Taysom tay...@chromium.org wrote: The following commit introduced a 10x regression for syncing inodes in ext4 with relatime enabled where just the atime had been modified. commit 4ea425b63a3dfeb7707fc7cc7161c11a51e871ed Author: Jan Kara j

Re: [PATCH] fs: sync: fixed performance regression

2013-07-10 Thread Paul Taysom
On Wed, Jul 10, 2013 at 4:56 PM, Dave Jones da...@redhat.com wrote: On Wed, Jul 10, 2013 at 04:12:36PM -0700, Paul Taysom wrote: Note, when running the test, the slow down doesn't always happen but most of the tests will show a slow down. In response to crbug.com/240422 Just

Re: [PATCH] fs: sync: fixed performance regression

2013-07-10 Thread Paul Taysom
Third time is the charm crbug.com/240411 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] drivers: mmc: reordered shutdown sequence in mmc_bld_remove_req

2013-06-10 Thread Paul Taysom
On Mon, Jun 10, 2013 at 2:44 AM, Ulf Hansson wrote: > On 4 June 2013 23:42, Paul Taysom wrote: >> We had a multi-partition SD-Card with two ext2 file systems. The partition >> table was getting overwritten by a race between the card removal and >> the unmount of t

Re: [PATCH] drivers: mmc: reordered shutdown sequence in mmc_bld_remove_req

2013-06-10 Thread Paul Taysom
On Mon, Jun 10, 2013 at 2:44 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 4 June 2013 23:42, Paul Taysom tay...@chromium.org wrote: We had a multi-partition SD-Card with two ext2 file systems. The partition table was getting overwritten by a race between the card removal and the unmount

[PATCH] drivers: mmc: reordered shutdown sequence in mmc_bld_remove_req

2013-06-04 Thread Paul Taysom
the device is removed but that is not always possible. The umount is still needed to cleanup other data structures. Addresses the problem described in http://crbug.com/240815 Signed-off-by: Paul Taysom --- drivers/mmc/card/block.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions

[PATCH] drivers: mmc: reordered shutdown sequence in mmc_bld_remove_req

2013-06-04 Thread Paul Taysom
the device is removed but that is not always possible. The umount is still needed to cleanup other data structures. Addresses the problem described in http://crbug.com/240815 Signed-off-by: Paul Taysom tay...@chromium.org --- drivers/mmc/card/block.c | 14 -- 1 file changed, 8 insertions

[PATCH] fs: ecryptfs: fixed msync to flush data

2013-05-23 Thread Paul Taysom
. Addresses the problem described in http://crbug.com/239536 Signed-off-by: Paul Taysom --- fs/ecryptfs/file.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ecryptfs/file.c b/fs/ecryptfs/file.c index 201f0a0..16f509d 100644 --- a/fs/ecryptfs/file.c +++ b/fs/ecryptfs/file.c @@ -295,6 +295,7

[PATCH] fs: ecryptfs: fixed msync to flush data

2013-05-23 Thread Paul Taysom
. Addresses the problem described in http://crbug.com/239536 Signed-off-by: Paul Taysom tay...@chromium.org --- fs/ecryptfs/file.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ecryptfs/file.c b/fs/ecryptfs/file.c index 201f0a0..16f509d 100644 --- a/fs/ecryptfs/file.c +++ b/fs/ecryptfs

Re: [PATCH] fs: ext4: Printing debug is now configurable

2013-05-22 Thread Paul Taysom
Ted, Do you have a status for this patch? Thanks, Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [PATCH] fs: ext4: Printing debug is now configurable

2013-05-22 Thread Paul Taysom
Ted, Do you have a status for this patch? Thanks, Paul -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] fs: ext4: Printing debug is now configurable

2013-04-30 Thread Paul Taysom
unlinking them, then crashing the system, rebooting the system and examining /var/log/messages. Addresses the problem described in http://crbug.com/220976 Signed-off-by: Paul Taysom --- fs/ext4/super.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/fs/ext4/super.c b/

[PATCH] fs: ext4: Printing debug is now configurable

2013-04-30 Thread Paul Taysom
, rebooting the system and examining /var/log/messages. Addresses the problem described in http://crbug.com/220976 Signed-off-by: Paul Taysom tay...@chromium.org --- fs/ext4/super.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-13 Thread Paul Taysom
On Tue, Mar 12, 2013 at 7:46 AM, Paul Taysom wrote: > Looks good to me. > > On Tue, Mar 5, 2013 at 3:30 PM, Paul Taysom wrote: >> seconds_kernel_to_login: 8.17s >> Passed all my other tests >> >> On Mon, Mar 4, 2013 at 2:15 PM, Mikulas Patocka wrote: >>&g

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-13 Thread Paul Taysom
On Tue, Mar 12, 2013 at 7:46 AM, Paul Taysom tay...@google.com wrote: Looks good to me. On Tue, Mar 5, 2013 at 3:30 PM, Paul Taysom tay...@google.com wrote: seconds_kernel_to_login: 8.17s Passed all my other tests On Mon, Mar 4, 2013 at 2:15 PM, Mikulas Patocka mpato...@redhat.com wrote

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-12 Thread Paul Taysom
Looks good to me. On Tue, Mar 5, 2013 at 3:30 PM, Paul Taysom wrote: > seconds_kernel_to_login: 8.17s > Passed all my other tests > > On Mon, Mar 4, 2013 at 2:15 PM, Mikulas Patocka wrote: >> >> >> On Mon, 4 Mar 2013, Paul Taysom wrote: >> >>> On M

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-12 Thread Paul Taysom
Looks good to me. On Tue, Mar 5, 2013 at 3:30 PM, Paul Taysom tay...@google.com wrote: seconds_kernel_to_login: 8.17s Passed all my other tests On Mon, Mar 4, 2013 at 2:15 PM, Mikulas Patocka mpato...@redhat.com wrote: On Mon, 4 Mar 2013, Paul Taysom wrote: On Mon, Mar 4, 2013 at 9:42 AM

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-05 Thread Paul Taysom
seconds_kernel_to_login: 8.17s Passed all my other tests On Mon, Mar 4, 2013 at 2:15 PM, Mikulas Patocka wrote: > > > On Mon, 4 Mar 2013, Paul Taysom wrote: > >> On Mon, Mar 4, 2013 at 9:42 AM, Alasdair G Kergon wrote: >> > On Mon, Mar 04, 2013 at 08:45:48

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-05 Thread Paul Taysom
seconds_kernel_to_login: 8.17s Passed all my other tests On Mon, Mar 4, 2013 at 2:15 PM, Mikulas Patocka mpato...@redhat.com wrote: On Mon, 4 Mar 2013, Paul Taysom wrote: On Mon, Mar 4, 2013 at 9:42 AM, Alasdair G Kergon a...@redhat.com wrote: On Mon, Mar 04, 2013 at 08:45:48AM -0800, Paul

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-04 Thread Paul Taysom
On Mon, Mar 4, 2013 at 9:42 AM, Alasdair G Kergon wrote: > On Mon, Mar 04, 2013 at 08:45:48AM -0800, Paul Taysom wrote: >> @@ -449,8 +468,14 @@ static void verity_prefetch_io(struct dm_verity *v, >> struct dm_verity_io *io) >> hash_block_end

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-04 Thread Paul Taysom
On Mon, Mar 4, 2013 at 9:19 AM, Paul Menzel wrote: > > Am Montag, den 04.03.2013, 08:45 -0800 schrieb Paul Taysom: > > Changed the dm-verity prefetching to use a worker thread to avoid > > a deadlock in dm-bufio. > > Do you know of any bug reports about this? Searching fo

[PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-04 Thread Paul Taysom
-bufio per thread. To do this, the prefetch requests were queued on worker threads. In addition to avoiding the deadlock, this fix made a slight improvement in performance. seconds_kernel_to_login: with prefetch:8.43s without prefetch: 9.2s worker prefetch: 8.28s Signed-off-by: Paul

[PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-04 Thread Paul Taysom
per thread. To do this, the prefetch requests were queued on worker threads. In addition to avoiding the deadlock, this fix made a slight improvement in performance. seconds_kernel_to_login: with prefetch:8.43s without prefetch: 9.2s worker prefetch: 8.28s Signed-off-by: Paul Taysom tay

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-04 Thread Paul Taysom
On Mon, Mar 4, 2013 at 9:19 AM, Paul Menzel pm.deb...@googlemail.com wrote: Am Montag, den 04.03.2013, 08:45 -0800 schrieb Paul Taysom: Changed the dm-verity prefetching to use a worker thread to avoid a deadlock in dm-bufio. Do you know of any bug reports about this? Searching for »dm

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-04 Thread Paul Taysom
On Mon, Mar 4, 2013 at 9:42 AM, Alasdair G Kergon a...@redhat.com wrote: On Mon, Mar 04, 2013 at 08:45:48AM -0800, Paul Taysom wrote: @@ -449,8 +468,14 @@ static void verity_prefetch_io(struct dm_verity *v, struct dm_verity_io *io) hash_block_end = v-hash_blocks