Re: [PATCH 00/13] [RFC] Rust support

2021-04-15 Thread Paul Zimmerman
On Fri, Apr 16, 2021 at 06:02:33 +0100, Wedson Almeida Filho wrote: > On Fri, Apr 16, 2021 at 04:25:34AM +, Al Viro wrote: > >>> Are you stating [what you perceive as] a fact or just venting? If the >>> former, >>> would you mind enlightening us with some evidence? >> >> How about "not

Re: Linux 5.11-rc4

2021-01-18 Thread Paul Zimmerman
On Mon, Jan 18, 2021 at 14:35:20 -0800, Guenter Roeck wrote: > On Sun, Jan 17, 2021 at 04:56:46PM -0800, Linus Torvalds wrote: >> Things continue to look fairly normal for this release: 5.11-rc4 is >> solidly average in size, and nothing particularly scary stands out. >> >> In the diff itself,

Re: Regression in suspend-to-ram (TPM related) with 5.1-rc1 (BISECTED)

2019-04-08 Thread Paul Zimmerman
On Sun, Apr 7, 2019 at 10:53 PM Martin Kepplinger wrote: > > On 21.03.19 14:41, Jarkko Sakkinen wrote: > > On Tue, Mar 19, 2019 at 04:03:37PM -0700, Paul Zimmerman wrote: > >> So I bisected this down to: > >> > >> # first bad commit: [a3fbfae82b4cb3ff9928e

Re: Regression in suspend-to-ram (TPM related) with 5.1-rc1 (BISECTED)

2019-03-19 Thread Paul Zimmerman
Zimmerman wrote: > > Hmm, looks like my original email didn't make it to the linux-integrity > list, maybe the two attachments were too big. You can read it on the > linux-kernel list here: > https://marc.info/?l=linux-kernel=155294522323580 > > On Mon, Mar 18, 2019 at 2:39 PM

Re: Regression in suspend-to-ram (TPM related) with 5.1-rc1

2019-03-18 Thread Paul Zimmerman
On Mon, Mar 18, 2019 at 2:39 PM Paul Zimmerman wrote: < snip > > It takes about 45 minutes to do a full kernel rebuild on this machine, > so doing a full bisection would be a little painful. Actually, that was because I had the Linux disk attached via USB. I have it connected in

Re: [PATCH v2 2/2] r8169: Avoid pointer aliasing

2019-02-05 Thread Paul Zimmerman
On Tue, 05 Feb 2019 18:52:18 -0800, Joe Perches wrote: > On Tue, 2019-02-05 at 19:27 -0700, Paul Zimmerman wrote: >> On Tue, 2019-02-05, Joe Perches wrote: >>> On Tue, 2019-02-05 at 12:04 -0800, Eric Dumazet wrote: >>> > On 02/05/2019 10:42 AM, Joe Perches wrot

Re: [PATCH v2 2/2] r8169: Avoid pointer aliasing

2019-02-05 Thread Paul Zimmerman
On Tue, 2019-02-05, Joe Perches wrote: > On Tue, 2019-02-05 at 12:04 -0800, Eric Dumazet wrote: >> >> On 02/05/2019 10:42 AM, Joe Perches wrote: >> > It's declared after a pointer so it is already is 2 byte aligned. >> > >> > A lot of drivers wouldn't work otherwise. >> >> Maybe these drivers

[PATCH RESEND] MAINTAINERS: update maintainer entry for dwc2 driver

2015-01-15 Thread Paul Zimmerman
Update the MAINTAINERS entry for the dwc2 driver to show John Youn as the new maintainer Signed-off-by: Paul Zimmerman --- Resending with linux-usb and linux-kernel in CC MAINTAINERS |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index

RE: [PATCH] MAINTAINERS: update maintainer entry for dwc2 driver

2015-01-15 Thread Paul Zimmerman
Adding linux-usb and linux-kernel to CC. -- Paul > -Original Message- > From: Paul Zimmerman > Sent: Thursday, January 15, 2015 11:44 AM > To: gre...@linuxfoundation.org; ba...@ti.com; John Youn > (johny...@synopsys.com) > Cc: 'r.bald...@samsung.com'; 'dingu...@ope

[PATCH] Revert "usb: dwc2: add bus suspend/resume for dwc2"

2015-01-15 Thread Paul Zimmerman
/resume on platforms where it does work correctly. Signed-off-by: Paul Zimmerman --- Based on Felipe's testing/next branch. drivers/usb/dwc2/hcd.c | 88 ++-- 1 files changed, 11 insertions(+), 77 deletions(-) diff --git a/drivers/usb/dwc2/hcd.c b

[PATCH] Revert usb: dwc2: add bus suspend/resume for dwc2

2015-01-15 Thread Paul Zimmerman
/resume on platforms where it does work correctly. Signed-off-by: Paul Zimmerman pa...@synopsys.com --- Based on Felipe's testing/next branch. drivers/usb/dwc2/hcd.c | 88 ++-- 1 files changed, 11 insertions(+), 77 deletions(-) diff --git a/drivers/usb

RE: [PATCH] MAINTAINERS: update maintainer entry for dwc2 driver

2015-01-15 Thread Paul Zimmerman
Adding linux-usb and linux-kernel to CC. -- Paul -Original Message- From: Paul Zimmerman Sent: Thursday, January 15, 2015 11:44 AM To: gre...@linuxfoundation.org; ba...@ti.com; John Youn (johny...@synopsys.com) Cc: 'r.bald...@samsung.com'; 'dingu...@opensource.altera.com'; 'Kever

[PATCH RESEND] MAINTAINERS: update maintainer entry for dwc2 driver

2015-01-15 Thread Paul Zimmerman
Update the MAINTAINERS entry for the dwc2 driver to show John Youn as the new maintainer Signed-off-by: Paul Zimmerman pa...@synopsys.com --- Resending with linux-usb and linux-kernel in CC MAINTAINERS |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/MAINTAINERS b

[PATCH] usb: phy: make GPIOs optional for the generic phy

2015-01-14 Thread Paul Zimmerman
>From 47bd18e210fecf701d493c27884e13c69bc449ea Mon Sep 17 00:00:00 2001 From: Paul Zimmerman Date: Wed, 14 Jan 2015 18:15:58 -0800 Subject: [PATCH] usb: phy: make GPIOs optional for the generic phy The use of GPIOs should be optional for the generic phy, otherwise the Altera SOCFPGA platf

RE: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-14 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Wednesday, January 14, 2015 2:50 PM > > On Wed, Jan 14, 2015 at 10:45:26PM +, Paul Zimmerman wrote: > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > Sent: Wednesday, January 14, 2015 2:40 PM > > > &

RE: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-14 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Wednesday, January 14, 2015 2:40 PM > > On Wed, Jan 14, 2015 at 10:28:54PM +, Paul Zimmerman wrote: > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > Sent: Wednesday, January 14, 2015 1:46 PM > > > &

RE: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-14 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Wednesday, January 14, 2015 1:46 PM > > On Wed, Jan 14, 2015 at 04:41:23PM -0500, Alan Stern wrote: > > > > > This is really, really odd. Register accesses are atomic, so the lock > > > > > isn't really doing anything. Besides, you're calling > >

RE: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-14 Thread Paul Zimmerman
issue, it's certainly a harmless patch, so Acked-by: Paul Zimmerman But I suspect Felipe will want a better changelog, I don't think just a URL is good enough. -- Paul > --- > > Changelog: > > v2: > - fixed comment from Paul Zimmerman > > v1: https://lkml.org/lkml/2015/1/

RE: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-14 Thread Paul Zimmerman
certainly a harmless patch, so Acked-by: Paul Zimmerman pa...@synopsys.com But I suspect Felipe will want a better changelog, I don't think just a URL is good enough. -- Paul --- Changelog: v2: - fixed comment from Paul Zimmerman v1: https://lkml.org/lkml/2015/1/13/186 drivers/usb

RE: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-14 Thread Paul Zimmerman
From: Felipe Balbi [mailto:ba...@ti.com] Sent: Wednesday, January 14, 2015 2:40 PM On Wed, Jan 14, 2015 at 10:28:54PM +, Paul Zimmerman wrote: From: Felipe Balbi [mailto:ba...@ti.com] Sent: Wednesday, January 14, 2015 1:46 PM On Wed, Jan 14, 2015 at 04:41:23PM -0500, Alan

RE: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-14 Thread Paul Zimmerman
From: Felipe Balbi [mailto:ba...@ti.com] Sent: Wednesday, January 14, 2015 1:46 PM On Wed, Jan 14, 2015 at 04:41:23PM -0500, Alan Stern wrote: This is really, really odd. Register accesses are atomic, so the lock isn't really doing anything. Besides, you're calling

RE: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-14 Thread Paul Zimmerman
From: Felipe Balbi [mailto:ba...@ti.com] Sent: Wednesday, January 14, 2015 2:50 PM On Wed, Jan 14, 2015 at 10:45:26PM +, Paul Zimmerman wrote: From: Felipe Balbi [mailto:ba...@ti.com] Sent: Wednesday, January 14, 2015 2:40 PM On Wed, Jan 14, 2015 at 10:28:54PM +, Paul

[PATCH] usb: phy: make GPIOs optional for the generic phy

2015-01-14 Thread Paul Zimmerman
From 47bd18e210fecf701d493c27884e13c69bc449ea Mon Sep 17 00:00:00 2001 From: Paul Zimmerman pa...@synopsys.com Date: Wed, 14 Jan 2015 18:15:58 -0800 Subject: [PATCH] usb: phy: make GPIOs optional for the generic phy The use of GPIOs should be optional for the generic phy, otherwise the Altera

RE: [PATCH] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-13 Thread Paul Zimmerman
> From: Robert Baldyga [mailto:r.bald...@samsung.com] > Sent: Tuesday, January 13, 2015 2:58 AM > > This patch fixes bug described here: > https://lkml.org/lkml/2014/12/22/185 > > Signed-off-by: Robert Baldyga > --- > drivers/usb/dwc2/core_intr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

RE: [PATCH] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-13 Thread Paul Zimmerman
From: Robert Baldyga [mailto:r.bald...@samsung.com] Sent: Tuesday, January 13, 2015 2:58 AM This patch fixes bug described here: https://lkml.org/lkml/2014/12/22/185 Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/dwc2/core_intr.c | 4 ++-- 1 file changed, 2

RE: New maintainer for dwc2

2015-01-12 Thread Paul Zimmerman
> From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > Sent: Monday, January 12, 2015 5:02 PM > > On Mon, Jan 12, 2015 at 11:14:54PM +, Paul Zimmerman wrote: > > Hi everyone, > > > > I will be leaving Synopsys on Friday, Jan 16th, so the d

RE: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-12 Thread Paul Zimmerman
> From: Paul Zimmerman > Sent: Saturday, January 10, 2015 3:52 PM > > > From: Yunzhi Li [mailto:l...@rock-chips.com] > > Sent: Saturday, January 10, 2015 8:07 AM > > > > 在 2015/1/9 10:15, Paul Zimmerman 写道: > > >> [...] > > >>

New maintainer for dwc2

2015-01-12 Thread Paul Zimmerman
Hi everyone, I will be leaving Synopsys on Friday, Jan 16th, so the dwc2 driver will need a new maintainer. I am recommending John Youn as the new maintainer. On the plus side, John has quite a bit of experience with the dwc2 controller, and has previous experience submitting kernel patches

RE: dwc2: problems with IN requests completion in linux-next

2015-01-12 Thread Paul Zimmerman
> From: Robert Baldyga [mailto:r.bald...@samsung.com] > Sent: Monday, December 22, 2014 6:13 AM > > I have recently noticed problem with DWC2 driver in latest linux-next. I > use it in gadget only mode at Samsung platform (Odroid U3) but I believe > the bug can be reproduced at another platforms.

RE: dwc2: problems with IN requests completion in linux-next

2015-01-12 Thread Paul Zimmerman
From: Robert Baldyga [mailto:r.bald...@samsung.com] Sent: Monday, December 22, 2014 6:13 AM I have recently noticed problem with DWC2 driver in latest linux-next. I use it in gadget only mode at Samsung platform (Odroid U3) but I believe the bug can be reproduced at another platforms.

RE: New maintainer for dwc2

2015-01-12 Thread Paul Zimmerman
From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] Sent: Monday, January 12, 2015 5:02 PM On Mon, Jan 12, 2015 at 11:14:54PM +, Paul Zimmerman wrote: Hi everyone, I will be leaving Synopsys on Friday, Jan 16th, so the dwc2 driver will need a new maintainer. I

RE: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-12 Thread Paul Zimmerman
From: Paul Zimmerman Sent: Saturday, January 10, 2015 3:52 PM From: Yunzhi Li [mailto:l...@rock-chips.com] Sent: Saturday, January 10, 2015 8:07 AM 在 2015/1/9 10:15, Paul Zimmerman 写道: [...] /* - * Attempt to find a generic PHY, then look for an old style

New maintainer for dwc2

2015-01-12 Thread Paul Zimmerman
Hi everyone, I will be leaving Synopsys on Friday, Jan 16th, so the dwc2 driver will need a new maintainer. I am recommending John Youn johny...@synopsys.com as the new maintainer. On the plus side, John has quite a bit of experience with the dwc2 controller, and has previous experience

RE: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-10 Thread Paul Zimmerman
> From: Yunzhi Li [mailto:l...@rock-chips.com] > Sent: Saturday, January 10, 2015 8:07 AM > > 在 2015/1/9 10:15, Paul Zimmerman 写道: > >> [...] > >>/* > >> - * Attempt to find a generic PHY, then look for an old style > >> - * USB PHY, finally

RE: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-10 Thread Paul Zimmerman
From: Yunzhi Li [mailto:l...@rock-chips.com] Sent: Saturday, January 10, 2015 8:07 AM 在 2015/1/9 10:15, Paul Zimmerman 写道: [...] /* - * Attempt to find a generic PHY, then look for an old style - * USB PHY, finally fall back to pdata + * If platform probe couldn't find

RE: [PATCH v3 00/30] usb: updates for dwc2 gadget driver

2015-01-09 Thread Paul Zimmerman
CCing more of the Samsung folks and linux-kernel. Robert, Marek, can you test this series on your platform, please? If I don't hear from you soon, I'll just ack it and we can deal with any breakage later. -- Paul > From: Mian Yousaf Kaukab [mailto:yousaf.kau...@intel.com] > Sent: Friday,

RE: [PATCH v3 00/30] usb: updates for dwc2 gadget driver

2015-01-09 Thread Paul Zimmerman
CCing more of the Samsung folks and linux-kernel. Robert, Marek, can you test this series on your platform, please? If I don't hear from you soon, I'll just ack it and we can deal with any breakage later. -- Paul From: Mian Yousaf Kaukab [mailto:yousaf.kau...@intel.com] Sent: Friday, January

RE: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-08 Thread Paul Zimmerman
> From: Yunzhi Li [mailto:l...@rock-chips.com] > Sent: Friday, December 12, 2014 7:10 AM > > Get PHY parameters from devicetree and power off usb PHY during > system suspend. > > Signed-off-by: Yunzhi Li > Acked-by: Paul Zimmerman > > --- > > Chang

RE: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-08 Thread Paul Zimmerman
From: Yunzhi Li [mailto:l...@rock-chips.com] Sent: Friday, December 12, 2014 7:10 AM Get PHY parameters from devicetree and power off usb PHY during system suspend. Signed-off-by: Yunzhi Li l...@rock-chips.com Acked-by: Paul Zimmerman pa...@synopsys.com --- Changes in v7: None

RE: [PATCH v3] usb: dwc2: add bus suspend/resume for dwc2

2015-01-05 Thread Paul Zimmerman
/patch/5325111/ > > Thanks, > > - Kever > On 01/06/2015 09:23 AM, Paul Zimmerman wrote: > >> From: Kever Yang [mailto:kever.y...@rock-chips.com] > >> Sent: Wednesday, November 12, 2014 4:42 PM > >> > >> On 11/13/2014 07:22 AM, Doug Anderson wrote: >

RE: [PATCH v3] usb: dwc2: add bus suspend/resume for dwc2

2015-01-05 Thread Paul Zimmerman
gt; >> We also update the lx_state for hsotg state. > >> > >> This patch has tested on rk3288 with suspend/resume. > >> > >> Signed-off-by: Kever Yang > >> Acked-by: Paul Zimmerman > >> --- > >> > >> Changes in v3: > &g

RE: [PATCH] drivers: usb: dwc2: remove 'force' parameter from kill_all_requests()

2015-01-05 Thread Paul Zimmerman
s3c_hsotg_core_connect(hsotg); > @@ -2588,7 +2581,7 @@ static int s3c_hsotg_ep_disable(struct usb_ep *ep) > > spin_lock_irqsave(>lock, flags); > /* terminate all requests with shutdown */ > - kill_all_requests(hsotg, hs_ep, -ESHUTDOWN,

RE: [PATCH v3] usb: dwc2: add bus suspend/resume for dwc2

2015-01-05 Thread Paul Zimmerman
/resume. Signed-off-by: Kever Yang kever.y...@rock-chips.com Acked-by: Paul Zimmerman pa...@synopsys.com --- Changes in v3: - remove CONFIG_PM macro for bus_suspend/resume - add PCGCTL operation for no device connect case Changes in v2: - update commit message - make dwc2 suspend

RE: [PATCH v3] usb: dwc2: add bus suspend/resume for dwc2

2015-01-05 Thread Paul Zimmerman
/06/2015 09:23 AM, Paul Zimmerman wrote: From: Kever Yang [mailto:kever.y...@rock-chips.com] Sent: Wednesday, November 12, 2014 4:42 PM On 11/13/2014 07:22 AM, Doug Anderson wrote: Kever, On Mon, Nov 10, 2014 at 5:09 AM, Kever Yang kever.y...@rock-chips.com wrote: Hcd controller

RE: [PATCH] drivers: usb: dwc2: remove 'force' parameter from kill_all_requests()

2015-01-05 Thread Paul Zimmerman
) spin_lock_irqsave(hsotg-lock, flags); /* terminate all requests with shutdown */ - kill_all_requests(hsotg, hs_ep, -ESHUTDOWN, false); + kill_all_requests(hsotg, hs_ep, -ESHUTDOWN); hsotg-fifo_map = ~(1hs_ep-fifo_index); hs_ep-fifo_index = 0; -- 1.9.1 Acked-by: Paul

RE: query on DWC3

2014-12-13 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of sundeep subbaraya > Sent: Friday, December 12, 2014 9:13 PM > > Hi Felipe, > > In DWC3 driver, for three stage Control OUT transfer there is a check: > >else if (!IS_ALIGNED(req->request.length,

RE: query on DWC3

2014-12-13 Thread Paul Zimmerman
From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of sundeep subbaraya Sent: Friday, December 12, 2014 9:13 PM Hi Felipe, In DWC3 driver, for three stage Control OUT transfer there is a check: else if (!IS_ALIGNED(req-request.length,

RE: [PATCH] usb: dwc2: gadget: kill requests with 'force' in s3c_hsotg_udc_stop()

2014-12-11 Thread Paul Zimmerman
. > @@ -2933,7 +2937,7 @@ static int s3c_hsotg_udc_stop(struct usb_gadget *gadget, > > /* all endpoints should be shutdown */ > for (ep = 1; ep < hsotg->num_of_eps; ep++) > - s3c_hsotg_ep_disable(>eps[ep].ep); > + s3c_hsotg_ep_dis

RE: [PATCH] usb: dwc2: gadget: kill requests with 'force' in s3c_hsotg_udc_stop()

2014-12-11 Thread Paul Zimmerman
++) - s3c_hsotg_ep_disable(hsotg-eps[ep].ep); + s3c_hsotg_ep_disable_force(hsotg-eps[ep].ep, true); spin_lock_irqsave(hsotg-lock, flags); Acked-by: Paul Zimmerman pa...@synopsys.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

RE: [PATCH v3 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-08 Thread Paul Zimmerman
C2_L0) > + return 0; > + phy_exit(dwc2->phy); > + phy_power_off(dwc2->phy); > + > + } > return ret; > } > > @@ -241,8 +268,13 @@ static int __maybe_unused dwc2_resume(struct device *dev) > struct dwc2_hsotg

RE: [PATCH v2 3/5] usb: dwc2: Add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-08 Thread Paul Zimmerman
> From: Yunzhi Li [mailto:l...@rock-chips.com] > Sent: Sunday, December 07, 2014 7:58 PM > > On 2014/12/6 3:04, Paul Zimmerman wrote: > >> From: Yunzhi Li [mailto:l...@rock-chips.com] > >> Sent: Friday, December 05, 2014 4:52 AM > >> > >> Get PHY

RE: [PATCH v2 3/5] usb: dwc2: Add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-08 Thread Paul Zimmerman
From: Yunzhi Li [mailto:l...@rock-chips.com] Sent: Sunday, December 07, 2014 7:58 PM On 2014/12/6 3:04, Paul Zimmerman wrote: From: Yunzhi Li [mailto:l...@rock-chips.com] Sent: Friday, December 05, 2014 4:52 AM Get PHY parameters from devicetree and power off usb PHY during system

RE: [PATCH v3 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-08 Thread Paul Zimmerman
; - if (dwc2_is_device_mode(dwc2)) + if (dwc2_is_device_mode(dwc2)) { ret = s3c_hsotg_resume(dwc2); + } else { + phy_power_on(dwc2-phy); + phy_init(dwc2-phy); + + } return ret; } Acked-by: Paul Zimmerman pa...@synopsys.com -- To unsubscribe from this list

RE: [PATCH v2 3/5] usb: dwc2: Add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-05 Thread Paul Zimmerman
> From: Yunzhi Li [mailto:l...@rock-chips.com] > Sent: Friday, December 05, 2014 4:52 AM > > Get PHY parameters from devicetree and power off usb PHY during > system suspend. > > Signed-off-by: Yunzhi Li > --- > > drivers/usb/dwc2/gadget.c | 33 - >

RE: [PATCH v2 3/5] usb: dwc2: Add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-05 Thread Paul Zimmerman
From: Yunzhi Li [mailto:l...@rock-chips.com] Sent: Friday, December 05, 2014 4:52 AM Get PHY parameters from devicetree and power off usb PHY during system suspend. Signed-off-by: Yunzhi Li l...@rock-chips.com --- drivers/usb/dwc2/gadget.c | 33 -

RE: [PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-18 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi > Sent: Tuesday, November 18, 2014 12:47 PM > > On Tue, Nov 18, 2014 at 03:41:43PM -0500, Jorge Ramirez-Ortiz wrote: > > > > notice that the original PLX driver was still far from the

RE: [PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-18 Thread Paul Zimmerman
From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi Sent: Tuesday, November 18, 2014 12:47 PM On Tue, Nov 18, 2014 at 03:41:43PM -0500, Jorge Ramirez-Ortiz wrote: notice that the original PLX driver was still far from the theoretical

RE: [PATCHv7 6/8] usb: dwc2: gadget: Do not fail probe if there isn't a clock node

2014-11-14 Thread Paul Zimmerman
> From: dingu...@opensource.altera.com [mailto:dingu...@opensource.altera.com] > Sent: Tuesday, November 11, 2014 9:14 AM > > From: Dinh Nguyen > > Since the dwc2 hcd driver is currently not looking for a clock node during > init, we should not completely fail if there isn't a clock provided. >

RE: [PATCHv7 7/8] usb: dwc2: move usb_disabled() call to host driver only

2014-11-14 Thread Paul Zimmerman
> @@ -157,9 +157,6 @@ static int dwc2_driver_probe(struct platform_device *dev) > int retval; > int irq; > > - if (usb_disabled()) > - return -ENODEV; > - > match = of_match_device(dwc2_of_match_table, >dev); > if (match &

RE: [PATCHv7 5/8] usb: dwc2: Update common interrupt handler to call gadget interrupt handler

2014-11-14 Thread Paul Zimmerman
; > + if (retval) > + return retval; > + > spin_lock_init(>lock); > retval = dwc2_hcd_init(hsotg, dev->irq, _module_params); > if (retval) { > diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c > index b94867b..3552602 100644

RE: [PATCHv7 3/8] usb: dwc2: convert to use dev_pm_ops API

2014-11-14 Thread Paul Zimmerman
> .driver = { > .name = dwc2_driver_name, > .of_match_table = dwc2_of_match_table, > + .pm = _dev_pm_ops, > }, > .probe = dwc2_driver_probe, > .remove = dwc2_driver_remove, > - .suspend = dwc2_suspend, > - .resu

RE: [PATCH v3] usb: dwc2: add bus suspend/resume for dwc2

2014-11-14 Thread Paul Zimmerman
> From: jwer...@google.com [mailto:jwer...@google.com] On Behalf Of Julius > Werner > Sent: Thursday, November 13, 2014 8:50 PM > > > I will figure out how to make dwc2 detect the device connect after auto > > suspend, > > or disable the auto suspend feature for the dwc2 hcd. > > I think

RE: [PATCH v3] usb: dwc2: add bus suspend/resume for dwc2

2014-11-14 Thread Paul Zimmerman
From: jwer...@google.com [mailto:jwer...@google.com] On Behalf Of Julius Werner Sent: Thursday, November 13, 2014 8:50 PM I will figure out how to make dwc2 detect the device connect after auto suspend, or disable the auto suspend feature for the dwc2 hcd. I think auto-suspend of

RE: [PATCHv7 3/8] usb: dwc2: convert to use dev_pm_ops API

2014-11-14 Thread Paul Zimmerman
, }, .probe = dwc2_driver_probe, .remove = dwc2_driver_remove, - .suspend = dwc2_suspend, - .resume = dwc2_resume, }; module_platform_driver(dwc2_platform_driver); Acked-by: Paul Zimmerman pa...@synopsys.com -- To unsubscribe from this list: send the line

RE: [PATCHv7 5/8] usb: dwc2: Update common interrupt handler to call gadget interrupt handler

2014-11-14 Thread Paul Zimmerman
, IORESOURCE_MEM, 0); hsotg-regs = devm_ioremap_resource(dev-dev, res); if (IS_ERR(hsotg-regs)) Acked-by: Paul Zimmerman pa...@synopsys.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

RE: [PATCHv7 7/8] usb: dwc2: move usb_disabled() call to host driver only

2014-11-14 Thread Paul Zimmerman
; - if (usb_disabled()) - return -ENODEV; - match = of_match_device(dwc2_of_match_table, dev-dev); if (match match-data) { params = match-data; This patch also fixes a minor buglet, in that we were missing the usb_disabled() check in pci.c. Acked-by: Paul

RE: [PATCHv7 6/8] usb: dwc2: gadget: Do not fail probe if there isn't a clock node

2014-11-14 Thread Paul Zimmerman
From: dingu...@opensource.altera.com [mailto:dingu...@opensource.altera.com] Sent: Tuesday, November 11, 2014 9:14 AM From: Dinh Nguyen dingu...@opensource.altera.com Since the dwc2 hcd driver is currently not looking for a clock node during init, we should not completely fail if there

RE: [PATCH v2] usb: dwc2: add bus suspend/resume for dwc2

2014-11-06 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Thursday, November 06, 2014 9:40 AM > > On Thu, Nov 06, 2014 at 06:21:42PM +0100, Romain Perier wrote: > > > > 2014-11-06 2:30 GMT+01:00 Kever Yang : > > > > > > +static int _dwc2_hcd_suspend(struct usb_hcd *hcd) > > > +{ > > > + struct

RE: [PATCH v2] usb: dwc2: add bus suspend/resume for dwc2

2014-11-06 Thread Paul Zimmerman
From: Felipe Balbi [mailto:ba...@ti.com] Sent: Thursday, November 06, 2014 9:40 AM On Thu, Nov 06, 2014 at 06:21:42PM +0100, Romain Perier wrote: 2014-11-06 2:30 GMT+01:00 Kever Yang kever.y...@rock-chips.com: +static int _dwc2_hcd_suspend(struct usb_hcd *hcd) +{ +

RE: [PATCHv6 4/8] usb: dwc2: Update common interrupt handler to call gadget interrupt handler

2014-10-31 Thread Paul Zimmerman
uplicate interrupt conditions that was in gadget, as those are > > handled > > by dwc2 common interrupt handler. > > > > Signed-off-by: Dinh Nguyen > > Acked-by: Paul Zimmerman > > --- > > v5: remove individual devm_request_irq from gadget and hcd, and plac

RE: [PATCH] usb: dwc2: add bus suspend/resume for dwc2

2014-10-31 Thread Paul Zimmerman
> From: Kever Yang [mailto:kever.y...@gmail.com] On Behalf Of Kever Yang > Sent: Friday, October 31, 2014 7:03 AM > > This patch adds suspend/resume for dwc2 hcd controller. > > Signed-off-by: Kever Yang > --- > > drivers/usb/dwc2/hcd.c | 74 >

RE: [PATCH] usb: dwc2: add bus suspend/resume for dwc2

2014-10-31 Thread Paul Zimmerman
From: Kever Yang [mailto:kever.y...@gmail.com] On Behalf Of Kever Yang Sent: Friday, October 31, 2014 7:03 AM This patch adds suspend/resume for dwc2 hcd controller. Signed-off-by: Kever Yang kever.y...@rock-chips.com --- drivers/usb/dwc2/hcd.c | 74

RE: [PATCHv6 4/8] usb: dwc2: Update common interrupt handler to call gadget interrupt handler

2014-10-31 Thread Paul Zimmerman
by dwc2 common interrupt handler. Signed-off-by: Dinh Nguyen dingu...@opensource.altera.com Acked-by: Paul Zimmerman pa...@synopsys.com --- v5: remove individual devm_request_irq from gadget and hcd, and place a single devm_request_irq in platform and pci. v2: Keep interrupt handler

RE: [PATCHv6 6/8] usb: dwc2: gadget: Do not fail probe if there isn't a clock node

2014-10-28 Thread Paul Zimmerman
> From: dingu...@opensource.altera.com [mailto:dingu...@opensource.altera.com] > Sent: Tuesday, October 28, 2014 4:26 PM > > Since the dwc2 hcd driver is currently not looking for a clock node during > init, we should not completely fail if there isn't a clock provided. > For dual-role mode, we

RE: [PATCHv6 8/8] usb: dwc2: move usb_disabled() call to host driver only

2014-10-28 Thread Paul Zimmerman
> From: dingu...@opensource.altera.com [mailto:dingu...@opensource.altera.com] > Sent: Tuesday, October 28, 2014 4:26 PM > > Now that platform.c will get built for both Host and Gadget, if we leave the > usb_disabled() call in platform.c, it results in the following build error > when (!USB &&

RE: [PATCH v3 01/19] usb: dwc3: enable hibernation if to be supported

2014-10-28 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Tuesday, October 28, 2014 12:01 PM > > On Tue, Oct 28, 2014 at 06:55:50PM +, Paul Zimmerman wrote: > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > Sent: Tuesday, October 28, 2014 11:51 AM > > > &

RE: [PATCH v3 01/19] usb: dwc3: enable hibernation if to be supported

2014-10-28 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Tuesday, October 28, 2014 11:51 AM > > On Tue, Oct 28, 2014 at 06:47:08PM +, Paul Zimmerman wrote: > > > From: Huang Rui [mailto:ray.hu...@amd.com] > > > Sent: Tuesday, October 28, 2014 4:54 AM >

RE: [PATCH v3 01/19] usb: dwc3: enable hibernation if to be supported

2014-10-28 Thread Paul Zimmerman
> From: Huang Rui [mailto:ray.hu...@amd.com] > Sent: Tuesday, October 28, 2014 4:54 AM > > It enables hibernation if the function is set in coreConsultant. > > Suggested-by: Felipe Balbi > Signed-off-by: Huang Rui > --- > drivers/usb/dwc3/core.c | 1 + > 1 file changed, 1 insertion(+) > >

RE: [PATCH v3 01/19] usb: dwc3: enable hibernation if to be supported

2014-10-28 Thread Paul Zimmerman
From: Huang Rui [mailto:ray.hu...@amd.com] Sent: Tuesday, October 28, 2014 4:54 AM It enables hibernation if the function is set in coreConsultant. Suggested-by: Felipe Balbi ba...@ti.com Signed-off-by: Huang Rui ray.hu...@amd.com --- drivers/usb/dwc3/core.c | 1 + 1 file changed, 1

RE: [PATCH v3 01/19] usb: dwc3: enable hibernation if to be supported

2014-10-28 Thread Paul Zimmerman
From: Felipe Balbi [mailto:ba...@ti.com] Sent: Tuesday, October 28, 2014 11:51 AM On Tue, Oct 28, 2014 at 06:47:08PM +, Paul Zimmerman wrote: From: Huang Rui [mailto:ray.hu...@amd.com] Sent: Tuesday, October 28, 2014 4:54 AM It enables hibernation if the function is set

RE: [PATCH v3 01/19] usb: dwc3: enable hibernation if to be supported

2014-10-28 Thread Paul Zimmerman
From: Felipe Balbi [mailto:ba...@ti.com] Sent: Tuesday, October 28, 2014 12:01 PM On Tue, Oct 28, 2014 at 06:55:50PM +, Paul Zimmerman wrote: From: Felipe Balbi [mailto:ba...@ti.com] Sent: Tuesday, October 28, 2014 11:51 AM On Tue, Oct 28, 2014 at 06:47:08PM +, Paul

RE: [PATCHv6 8/8] usb: dwc2: move usb_disabled() call to host driver only

2014-10-28 Thread Paul Zimmerman
From: dingu...@opensource.altera.com [mailto:dingu...@opensource.altera.com] Sent: Tuesday, October 28, 2014 4:26 PM Now that platform.c will get built for both Host and Gadget, if we leave the usb_disabled() call in platform.c, it results in the following build error when (!USB

RE: [PATCHv6 6/8] usb: dwc2: gadget: Do not fail probe if there isn't a clock node

2014-10-28 Thread Paul Zimmerman
From: dingu...@opensource.altera.com [mailto:dingu...@opensource.altera.com] Sent: Tuesday, October 28, 2014 4:26 PM Since the dwc2 hcd driver is currently not looking for a clock node during init, we should not completely fail if there isn't a clock provided. For dual-role mode, we will

RE: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

2014-10-23 Thread Paul Zimmerman
> From: Bartlomiej Zolnierkiewicz [mailto:b.zolnier...@samsung.com] > Sent: Wednesday, October 22, 2014 5:26 AM > > On Monday, October 20, 2014 01:52:06 PM dingu...@opensource.altera.com wrote: > > From: Dinh Nguyen > > > > config USB_DWC2_PLATFORM > > bool "DWC2 Platform" > > - depends

RE: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

2014-10-23 Thread Paul Zimmerman
From: Bartlomiej Zolnierkiewicz [mailto:b.zolnier...@samsung.com] Sent: Wednesday, October 22, 2014 5:26 AM On Monday, October 20, 2014 01:52:06 PM dingu...@opensource.altera.com wrote: From: Dinh Nguyen dingu...@opensource.altera.com config USB_DWC2_PLATFORM bool DWC2 Platform

RE: [PATCH] usb: serial: Fix indentation style issue

2014-10-22 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Greg KH > Sent: Wednesday, October 22, 2014 7:19 AM > > On Wed, Oct 22, 2014 at 11:51:12AM +0200, Johan Hovold wrote: > > On Sat, Oct 11, 2014 at 07:20:49AM -0700, Greg Kroah-Hartman wrote: > > > On

RE: [PATCHv5 2/7] usb: dwc2: Move gadget probe function into platform code

2014-10-22 Thread Paul Zimmerman
> From: Bartlomiej Zolnierkiewicz [mailto:b.zolnier...@samsung.com] > Sent: Wednesday, October 22, 2014 4:16 AM > > On Monday, October 20, 2014 01:52:01 PM dingu...@opensource.altera.com wrote: > > From: Dinh Nguyen > > > > This patch will aggregate the probing of gadget/hcd driver into

RE: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

2014-10-22 Thread Paul Zimmerman
> From: Dinh Nguyen [mailto:dingu...@opensource.altera.com] > Sent: Tuesday, October 21, 2014 1:48 PM > > diff --git a/drivers/usb/dwc2/Kconfig b/drivers/usb/dwc2/Kconfig > index f93807b..1ea702e 100644 > --- a/drivers/usb/dwc2/Kconfig > +++ b/drivers/usb/dwc2/Kconfig > @@ -1,5 +1,5 @@ > config

RE: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

2014-10-22 Thread Paul Zimmerman
From: Dinh Nguyen [mailto:dingu...@opensource.altera.com] Sent: Tuesday, October 21, 2014 1:48 PM diff --git a/drivers/usb/dwc2/Kconfig b/drivers/usb/dwc2/Kconfig index f93807b..1ea702e 100644 --- a/drivers/usb/dwc2/Kconfig +++ b/drivers/usb/dwc2/Kconfig @@ -1,5 +1,5 @@ config USB_DWC2

RE: [PATCHv5 2/7] usb: dwc2: Move gadget probe function into platform code

2014-10-22 Thread Paul Zimmerman
From: Bartlomiej Zolnierkiewicz [mailto:b.zolnier...@samsung.com] Sent: Wednesday, October 22, 2014 4:16 AM On Monday, October 20, 2014 01:52:01 PM dingu...@opensource.altera.com wrote: From: Dinh Nguyen dingu...@opensource.altera.com This patch will aggregate the probing of gadget/hcd

RE: [PATCH] usb: serial: Fix indentation style issue

2014-10-22 Thread Paul Zimmerman
From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Greg KH Sent: Wednesday, October 22, 2014 7:19 AM On Wed, Oct 22, 2014 at 11:51:12AM +0200, Johan Hovold wrote: On Sat, Oct 11, 2014 at 07:20:49AM -0700, Greg Kroah-Hartman wrote: On Sat, Oct

RE: [PATCH v2 16/16] usb: dwc3: enable usb suspend phy

2014-10-20 Thread Paul Zimmerman
> From: Huang Rui [mailto:ray.hu...@amd.com] > Sent: Monday, October 20, 2014 2:01 AM > > On Mon, Oct 20, 2014 at 04:41:54PM +0800, Huang Rui wrote: > > On Fri, Oct 17, 2014 at 01:48:19PM -0500, Felipe Balbi wrote: > > > Hi, > > > > > > On Fri, Oct

RE: [PATCH v2 16/16] usb: dwc3: enable usb suspend phy

2014-10-20 Thread Paul Zimmerman
From: Huang Rui [mailto:ray.hu...@amd.com] Sent: Monday, October 20, 2014 2:01 AM On Mon, Oct 20, 2014 at 04:41:54PM +0800, Huang Rui wrote: On Fri, Oct 17, 2014 at 01:48:19PM -0500, Felipe Balbi wrote: Hi, On Fri, Oct 17, 2014 at 06:41:04PM +, Paul Zimmerman wrote: From

RE: [PATCH v3 1/2] usb: dwc2: gadget: sparse warning of context imbalance

2014-10-17 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Friday, October 17, 2014 11:52 AM > > On Fri, Oct 17, 2014 at 06:50:19PM +, Paul Zimmerman wrote: > > > From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] > > > Sent: Thursday, October 16, 2014 9:44 PM

RE: [PATCH v3 2/2] usb: dwc2: gadget: modify return statement

2014-10-17 Thread Paul Zimmerman
> From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] > Sent: Thursday, October 16, 2014 9:44 PM > > modified the function to have a single return statement at the end > instead of multiple return statement in the middle of the function > to improve the readability of the code. > > This

RE: [PATCH v3 1/2] usb: dwc2: gadget: sparse warning of context imbalance

2014-10-17 Thread Paul Zimmerman
> > /* for non control endpoints, set PID to D0 */ > @@ -2579,6 +2581,7 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep, > /* enable the endpoint interrupt */ > s3c_hsotg_ctrl_epint(hsotg, index, dir_in, 1); > > +error: > spin_unlock_irqrestore(>lock, f

RE: [PATCH v2 16/16] usb: dwc3: enable usb suspend phy

2014-10-17 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Friday, October 17, 2014 8:00 AM > > On Fri, Oct 17, 2014 at 04:53:41PM +0800, Huang Rui wrote: > > AMD NL needs to suspend usb3 ss phy, but this doesn't enable on simulation > > board. > > > > Signed-off-by: Huang Rui > > --- > >

RE: [PATCH v3 2/2] usb: dwc2: gadget: modify return statement

2014-10-17 Thread Paul Zimmerman
> From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] > Sent: Friday, October 17, 2014 3:03 AM > > On Fri, Oct 17, 2014 at 09:02:00AM +, David Laight wrote: > > From: Of Sudip Mukherjee > > > modified the function to have a single return statement at the end > > > instead of multiple

RE: [PATCH v3 2/2] usb: dwc2: gadget: modify return statement

2014-10-17 Thread Paul Zimmerman
From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] Sent: Friday, October 17, 2014 3:03 AM On Fri, Oct 17, 2014 at 09:02:00AM +, David Laight wrote: From: Of Sudip Mukherjee modified the function to have a single return statement at the end instead of multiple return

RE: [PATCH v2 16/16] usb: dwc3: enable usb suspend phy

2014-10-17 Thread Paul Zimmerman
From: Felipe Balbi [mailto:ba...@ti.com] Sent: Friday, October 17, 2014 8:00 AM On Fri, Oct 17, 2014 at 04:53:41PM +0800, Huang Rui wrote: AMD NL needs to suspend usb3 ss phy, but this doesn't enable on simulation board. Signed-off-by: Huang Rui ray.hu...@amd.com ---

  1   2   3   >