Re: [PATCH v4 2/3] leds: sy7802: Add support for Silergy SY7802 flash LED controller

2024-06-17 Thread Pavel Machek
> https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/mutex.h#L196 This does not look like real improvement for code this trivial. BR, Pavel -- People of Russia, stop Putin before his war on Ukraine escalates. signature.asc Description: PGP signature

Re: [ANNOUNCE] 5.10.214-rt106

2024-04-19 Thread Pavel Machek
nting to a commit inside that branch, probably why your git > update didn't get the tag. You could try a > > git fetch --tags Aha, thanks for the pointer and sorry for the noise. Best regards, Pavel -- DENX Software

Re: [ANNOUNCE] 5.10.214-rt106

2024-04-19 Thread Pavel Machek
/scm/linux/kernel/git/rt/linux-stable-rt.git > > branch: v5.10-rt > Head SHA1: 3d208061796d4addeb543c78e0a4ec769b6ce6b2 Thank you. Could you also push v5.10.214-rt106-rebase tag to the repository for consistency? Best regards,

Re: [ANNOUNCE] 5.10.213-rt105

2024-04-15 Thread Pavel Machek
10.214-rt106 (which would be useful to me). Is it a mistake or should I plan for v5.10.215-rt107? Thanks and best regards, Pavel -- People of Russia, stop Putin before his war on Ukraine escalates. signature.asc Description: PGP signature

Re: [PATCHv3 2/2] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-04-09 Thread Pavel Machek
basic support > > in mainline is needed to be able to work on the other stuff > > (networking, cameras, power management). > > > > Signed-off-by: Ondrej Jirman > > Co-developed-by: Martijn Braam > > Co-developed-by: Samuel Holland > > Signed-off-by: Pave

Re: [PATCHv3 1/2] dt-bindings: usb: typec: anx7688: start a binding document

2024-04-08 Thread Pavel Machek
Hi! > > Add binding for anx7688 usb type-c bridge. I don't have a datasheet, > > but I did best I could. > > > > Signed-off-by: Pavel Machek > > ... > > > + cabledet-gpios: > > +maxItems: 1 > > +description: GPIO control

[PATCHv3 2/2] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-04-08 Thread Pavel Machek
is needed to be able to work on the other stuff (networking, cameras, power management). Signed-off-by: Ondrej Jirman Co-developed-by: Martijn Braam Co-developed-by: Samuel Holland Signed-off-by: Pavel Machek --- v2: Fix checkpatch stuff. Some cleanups, adapt to dts format in 1/2. v3: Turn down

[PATCHv3 1/2] dt-bindings: usb: typec: anx7688: start a binding document

2024-04-08 Thread Pavel Machek
Add binding for anx7688 usb type-c bridge. I don't have a datasheet, but I did best I could. Signed-off-by: Pavel Machek --- v2: implement review feedback v3: fix single character pointed by robot diff --git a/Documentation/devicetree/bindings/usb/analogix,anx7688.yaml b/Documentation

Re: [PATCHv2 2/2] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-03-21 Thread Pavel Machek
do); > > + unsigned int max_pow = pdo_max_power(pdo); > > + > > + dev_info(anx7688->dev, "SRC_CAP PDO_BATT > > (%umV-%umV %umW)\n", min_volt, max_volt, max_pow); > > Noise. That line also really should be split in two. > > I'm stopping my review here. This driver is too noisy. All dev_info > calls need to be dropped. If the driver is working correctly then it > needs to quiet. > > Most of those prints are useful for debugging only, so I think similar > debugfs log like the one tcpm.c uses could be a good idea for them > since you already use debugfs in this driver in any case. Ok, let me convert the non-error ones to dev_dbg() and split the long lines. Debug needs to be enabled, so it should not bother anyone, and it is easier than refactoring driver to use debugfs. Best regards, Pavel -- People of Russia, stop Putin before his war on Ukraine escalates. signature.asc Description: PGP signature

Re: [PATCHv2 2/2] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-03-11 Thread Pavel Machek
having basic support > in mainline is needed to be able to work on the other stuff > (networking, cameras, power management). > > Signed-off-by: Ondrej Jirman > Co-developed-by: Martijn Braam > Co-developed-by: Samuel Holland > Signed-off-by: Pavel

Re: [PATCHv2 1/2] dt-bindings: usb: typec: anx7688: start a binding document

2024-03-11 Thread Pavel Machek
Hi! > Add binding for anx7688 usb type-c bridge. I don't have a datasheet, > but I did best I could. > > Signed-off-by: Pavel Machek Any more comments here? Automatic system told me I need to replace one character...

[PATCHv2 2/2] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-02-23 Thread Pavel Machek
is needed to be able to work on the other stuff (networking, cameras, power management). Signed-off-by: Ondrej Jirman Co-developed-by: Martijn Braam Co-developed-by: Samuel Holland Signed-off-by: Pavel Machek --- v2: Fix checkpatch stuff. Some cleanups, adapt to dts format in 1/2. diff --git

[PATCHv2 1/2] dt-bindings: usb: typec: anx7688: start a binding document

2024-02-23 Thread Pavel Machek
Add binding for anx7688 usb type-c bridge. I don't have a datasheet, but I did best I could. Signed-off-by: Pavel Machek --- v2: implement review feedback diff --git a/Documentation/devicetree/bindings/usb/analogix,anx7688.yaml b/Documentation/devicetree/bindings/usb/analogix,anx7688.yaml

Re: [PATCH] dt-bindings: usb: typec: anx7688: start a binding document

2024-02-21 Thread Pavel Machek
> I don't understand why do you have here properties. Do you see any > binding like this? Well, it looks like I copied these mistakes from analogix,anx7411.yaml . > > + > > +required: > > + - compatible > > Drop, why is it needed? Again, copy from analogix,anx7

Re: [PATCH] dt-bindings: usb: typec: anx7688: start a binding document

2024-02-12 Thread Pavel Machek
Hi! > > Add binding for anx7688 usb type-c bridge. I don't have a datasheet, > > but I did best I could. > > > > Signed-off-by: Pavel Machek > > > > You miss proper diffstat which makes reviewing difficult. > Actually entire patch is corrupte

[PATCH] dt-bindings: usb: typec: anx7688: start a binding document

2024-02-09 Thread Pavel Machek
Add binding for anx7688 usb type-c bridge. I don't have a datasheet, but I did best I could. Signed-off-by: Pavel Machek diff --git a/Documentation/devicetree/bindings/usb/analogix,anx7688.yaml b/Documentation/devicetree/bindings/usb/analogix,anx7688.yaml new file mode 100644 index

Re: [PATCH] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-02-09 Thread Pavel Machek
ret; > > + } > > ^^^ The driver will need to follow usb-c-connector bindings and it will need > a bindings documentation for itself. > > That's one of the missing things that I did not implement, yet. Yep, I fought with device trees for few days. I should have yaml r

Re: [PATCH] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-02-02 Thread Pavel Machek
to go back and guess in the future, that isn't nice. Thanks for the review. Fixing checkpatch issues is easy, but it looks like closer look will be needed at the devicetree probing. Also, what are the authors preferences about the license? I'd prefer GPLv2+. Best regards, Pavel

[PATCH] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-02-01 Thread Pavel Machek
is needed to be able to work on the other stuff (networking, cameras, power management). Signed-off-by: Ondrej Jirman Signed-off-by: Martijn Braam Signed-off-by: Samuel Holland Signed-off-by: Pavel Machek diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig index 2f80c2792dbd

Re: [ANNOUNCE] 5.10.204-rt100

2024-01-31 Thread Pavel Machek
cal > popped up, but that was not the case. > > Sorry for the inconvenience, I do hope a release tomorrow or Friday does > not disrupt your workflow too much. No problem, thanks for the information, and looking forward to the release. Best regards,

Re: [ANNOUNCE] 5.10.204-rt100

2024-01-30 Thread Pavel Machek
Hi! We (as in cip project), are trying to do -cip-rt releases once a month. Are there any plans for 5.10-rt release any time soon? That would help us ;-). Best regards, Pavel -- DENX Software Engineering GmbH,Managing

Re: Front camera on pinephone

2024-01-24 Thread Pavel Machek
it looks someone did the work and patches are floating around. GOod :-). I'm fighting with kexec crashing as soon as I pass dtb. Do I need to modify the dtb somehow? Best regards, Pavel

Front camera on pinephone

2024-01-16 Thread Pavel Machek
with rather old 6.1 kernel on it, and lack of keyboard/ethernet makes things tricky.] Best regards, Pavel -- People of Russia, stop Putin before his war on Ukraine escalates. signature.asc Description: PGP signature

Re: [PATCH v3 0/3] media: i2c: gc2145: GC2145 sensor support

2023-11-11 Thread Pavel Machek
camera driver (front camera on PinePhone)". I've added some cc-s in case people wanted to comment on it. Best regards, Pavel -- People of Russia, stop Putin before his war on Ukraine escalates. signature.asc Description: PGP signature

Re: [ANNOUNCE] 5.10.199-rt97

2023-11-11 Thread Pavel Machek
T code. Thanks for the release. Do you plan 5.10.200-based one by chance? .199 is buggy on hardware we care about, so it would make our job a bit easier. Thanks and best regards, Pavel -- DENX Software Engineering GmbH,Managing Direct

Re: [PATCH 0/2] arm64: dts: qcom: longcheer l8910 and l9100: Enable RGB LED

2023-10-28 Thread Pavel Machek
egards, Pavel --

Re: droid4 -- weird behaviour when attempting to use usb host

2023-09-27 Thread Pavel Machek
t, too. > If you have, that should not be used as the pmic can feed vbus. Well, my plan was to use it as a desktop, and external power is useful that as Droid battery is not that big. Best regards, Pavel -- People of Russia, stop Putin before his war on Ukraine escalates. signature.asc Description: PGP signature

droid4 -- weird behaviour when attempting to use usb host

2023-09-25 Thread Pavel Machek
, Pavel --

Re: [PATCH 5.11 007/122] dmaengine: idxd: Fix clobbering of SWERR overflow bit on writeback

2021-04-20 Thread Pavel Machek
> + idxd->reg_base + IDXD_SWERR_OFFSET); Best regards, Pavel -- http://www.livejournal.com/~pavelmachek signature.asc Description: PGP signature

Re: RPi4 DWC2 gadget doesn't copy data to a buffer in ep0 SETUP + DATA OUT transaction

2021-04-20 Thread Pavel Hofman
Dne 19. 04. 21 v 18:30 Minas Harutyunyan napsal(a): > Hi Pavel, > > On 4/19/2021 5:22 PM, Pavel Hofman wrote: >> >> Dne 11. 02. 21 v 12:21 Minas Harutyunyan napsal(a): >>> Hi Ruslan, >>> >>> On 2/1/2021 3:44 AM, Ruslan Bilovol wrote: >>>

Re: [syzbot] INFO: task hung in __io_uring_cancel

2021-04-19 Thread Pavel Begunkov
f65d0 The repro looks pretty much like sqpoll-exit-hang test and issues that were just recently fixed. #syz test: git://git.kernel.dk/linux-block for-5.13/io_uring > > The issue was bisected to: > > commit d9d05217cb6990b9a56e13b56e7a1b71e2551f6c > Author: Pavel B

Re: [PATCH 5.10 043/103] net: tipc: Fix spelling errors in net/tipc module

2021-04-19 Thread Pavel Machek
Hi! > [ Upstream commit a79ace4b312953c5835fafb12adc3cb6878b26bd ] > > These patches fix a series of spelling errors in net/tipc module. This should not be in -stable, it just cleans up comments. Best regards,

Re: [PATCH 5.10 000/103] 5.10.32-rc1 review

2021-04-19 Thread Pavel Machek
Apr 2021 13:05:09 +. > Anything received after that time might be too late. CIP testing did not find any problems here: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y Tested-by: Pavel Machek

Re: [PATCH 5.10 042/103] net/rds: Avoid potential use after free in rds_send_remove_from_sock

2021-04-19 Thread Pavel Machek
patch is crazy. Take a look at Message-ID: <20210419084953.GA28564@amd>. Or just look at the patch :-). Best regards, Pavel > +++ b/net/rds/message.c > @@ -180,6 +180,7 @@ void rds_message_put(struct rds_message *rm) >

Re: [syzbot] KASAN: use-after-free Read in idr_for_each (2)

2021-04-19 Thread Pavel Begunkov
h: > > #syz fix: io_uring: Convert personality_idr to XArray > > For information about bisection process see: https://goo.gl/tpsmEJ#bisection #syz fix: io_uring: Convert personality_idr to XArray -- Pavel Begunkov

Re: [syzbot] WARNING in __percpu_ref_exit (2)

2021-04-19 Thread Pavel Begunkov
+0xa64/0x12d0 fs/io_uring.c:8620 > process_one_work+0x98d/0x1600 kernel/workqueue.c:2275 > worker_thread+0x64c/0x1120 kernel/workqueue.c:2421 > kthread+0x3b1/0x4a0 kernel/kthread.c:292 > ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294 > #syz test: git://git.kernel.dk/linux-block for-5.13/io_uring -- Pavel Begunkov

Re: [PATCH AUTOSEL 5.10 41/46] net/rds: Avoid potential use after free in rds_send_remove_from_sock

2021-04-19 Thread Pavel Machek
rds_message_put(rm); > - if (was_on_sock) > + if (was_on_sock && rm) > rds_message_put(rm); > } If rm was non-NULL calling first rds_message_put (and it was, otherwise we oopsed), it is still non-NULL in second test

Re: [PATCH] base: power: runtime.c: Remove a unnecessary space

2021-04-18 Thread Pavel Machek
ove extra space. No need to add it, either. Best regards, Pavel -- http://www.livejournal.com/~pavelmachek signature.asc Description: Digital signature

Re: [PATCH 2/8] usb: gadget: f_uac2/u_audio: add feedback endpoint support

2021-04-17 Thread Pavel Hofman
ing to Q16.16 */ - ff = DIV_ROUND_UP((freq << 13), (8*1000)) << 3; + //ff = DIV_ROUND_UP((freq << 13), (8*1000)) << 3; + ff = ((freq << 10) + 62) / 125; } *(__le32 *)buf = cpu_to_le32(ff); } Best regards, Pavel.

Re: [PATCH 4.19 00/13] 4.19.188-rc1 review

2021-04-15 Thread Pavel Machek
here: (some boards are unavailable) https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.19.y Tested-by: Pavel Machek (CIP) Best regards, Pavel

Re: [PATCH 5.10 00/25] 5.10.31-rc1 review

2021-04-15 Thread Pavel Machek
here: (some boards are unavailable) https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.4.y https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.19.y https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y Tested-by: Pavel

Re: [PATCH 4.4 00/38] 4.4.267-rc1 review

2021-04-15 Thread Pavel Machek
here: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.4.y Tested-by: Pavel Machek (CIP) Best regards, Pavel -- DENX Software Engineering GmbH,

memory leak in ext4_multi_mount_protect

2021-04-13 Thread Pavel Skripkin
I look forward to hearing your perspective on this patch :) With regards, Pavel Skripkin

Re: [PATCH 5.10 000/188] 5.10.30-rc1 review

2021-04-13 Thread Pavel Machek
here: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y Tested-by: Pavel Machek (CIP) Best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office:

Re: [PATCH 4.19 00/66] 4.19.187-rc1 review

2021-04-13 Thread Pavel Machek
here: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.19.y Tested-by: Pavel Machek (CIP) Best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office:

Re: [PATCH] net: mac802154: fix WARNING in ieee802154_del_device

2021-04-12 Thread Pavel Skripkin
Hi! On Mon, 2021-04-12 at 07:45 -0400, Alexander Aring wrote: > Hi, > > On Mon, 12 Apr 2021 at 06:58, Pavel Skripkin > wrote: > > > > syzbot reported WARNING in ieee802154_del_device. The problem > > was in uninitialized mutex. In case of NL802154_IFTYPE_MONITOR

[PATCH] net: mac802154: fix WARNING in ieee802154_del_device

2021-04-12 Thread Pavel Skripkin
syzbot reported WARNING in ieee802154_del_device. The problem was in uninitialized mutex. In case of NL802154_IFTYPE_MONITOR mutex won't be initialized, but ieee802154_del_device() accessing it. Reported-by: syzbot+bf8b5834b7ec22948...@syzkaller.appspotmail.com Signed-off-by: Pavel Skripkin

Re: BUG: unable to handle kernel NULL pointer dereference in io_uring_cancel_task_requests

2021-04-11 Thread Pavel Begunkov
On 11/04/2021 09:58, Hao Sun wrote: > Pavel Begunkov 于2021年4月11日周日 下午4:14写道: >> >> On 11/04/2021 04:08, Hao Sun wrote: >>> Hi >>> >>> When using Healer(https://github.com/SunHao-0/healer/tree/dev) to fuzz >>> the Linux kernel, I found a null

Re: BUG: unable to handle kernel NULL pointer dereference in io_uring_cancel_task_requests

2021-04-11 Thread Pavel Begunkov
R10: 0001 R11: 88804b8e0280 R12: > R13: 8880409d5140 R14: 88804b8e0280 R15: 8880481c1800 > FS: 7f046fa1a700() GS:88807ec0() knlGS: > CS: 0010 DS: ES: CR0: 80050033 > CR2: 0040 CR3: 479a5000 CR4: 00750ee0 > DR0: DR1: DR2: > DR3: DR6: fffe0ff0 DR7: 0400 > PKRU: 5554 > -- Pavel Begunkov

Re: [PATCH 4/4] rtc:abx80x: Enable xt digital calibration

2021-04-09 Thread Pavel Machek
32.768 kHz? > +{ > + int retval; > + long Adj; Adj -> adj. > + > +static DEVICE_ATTR_WO(xt_frequency); You are adding new user interface, you sould add documentation. Best regards, Pavel

Re: [PATCH 5.10 06/41] net: pxa168_eth: Fix a potential data race in pxa168_eth_remove

2021-04-09 Thread Pavel Machek
y don't want that to run with clock being disabled and DMA being unmapped. We certainly don't want phy_disconnect() being undone by phy_connect_direct() running in the workqueue. IOW this patch is not enough to fix the bugs, and at least fix below is needed to get something reasonable. Signed-off-by: P

Re: [PATCH v13 03/18] arm64: hyp-stub: Move el1_sync into the vectors

2021-04-08 Thread Pavel Tatashin
> > Thank you for noticing this. Not sure how this missmerge happened. I > > have added the missing case, and VHE is initialized correctly during > > boot. > > [ 14.698175] kvm [1]: VHE mode initialized successfully > > > > During normal boot, kexec reboot, and kdump reboot. I will respin the >

Re: [PATCH] net: sched: sch_teql: fix null-pointer dereference

2021-04-08 Thread Pavel Tikhomirov
On 4/8/21 6:26 PM, Eric Dumazet wrote: On 4/8/21 5:14 PM, Pavel Tikhomirov wrote: Reproduce: modprobe sch_teql tc qdisc add dev teql0 root teql0 This leads to (for instance in Centos 7 VM) OOPS: Null pointer dereference happens on master->slaves dereference in teql_dest

[PATCH] net: sched: sch_teql: fix null-pointer dereference

2021-04-08 Thread Pavel Tikhomirov
we get OOPS. Signed-off-by: Pavel Tikhomirov --- net/sched/sch_teql.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/sched/sch_teql.c b/net/sched/sch_teql.c index 2f1f0a378408..6af6b95bdb67 100644 --- a/net/sched/sch_teql.c +++ b/net/sched/sch_teql.c @@ -134,6 +134,9 @@ teql_

Re: [PATCH v13 03/18] arm64: hyp-stub: Move el1_sync into the vectors

2021-04-08 Thread Pavel Tatashin
On Thu, Apr 8, 2021 at 6:24 AM Marc Zyngier wrote: > > On 2021-04-08 05:05, Pavel Tatashin wrote: > > From: James Morse > > > > The hyp-stub's el1_sync code doesn't do very much, this can easily fit > > in the vectors. > > > > With this, all of the hyp-s

Re: [syzbot] INFO: task hung in io_ring_exit_work

2021-04-08 Thread Pavel Begunkov
?x=86318203e865a02b > dashboard link: https://syzkaller.appspot.com/bug?extid=93f72b3885406bb09e0d > compiler: > -- Pavel Begunkov

Re: [syzbot] INFO: task hung in io_ring_exit_work

2021-04-08 Thread Pavel Begunkov
On 08/04/2021 06:05, syzbot wrote: > Hello, > > syzbot has tested the proposed patch but the reproducer is still triggering > an issue: > INFO: task hung in io_ring_exit_work Ok, it's really fancy, we add task_work with TWA_SIGNAL to a guaranteed not exited/exec task, it succeeds, but the

[PATCH v13 14/18] arm64: kexec: install a copy of the linear-map

2021-04-07 Thread Pavel Tatashin
on the mapping it is executing from. The makes no difference yet as the relocation code runs with the MMU disabled. Co-developed-by: James Morse Signed-off-by: Pavel Tatashin --- arch/arm64/include/asm/assembler.h | 19 +++ arch/arm64/include/asm/kexec.h | 2 ++ arch/arm64

[PATCH v13 18/18] arm64/mm: remove useless trans_pgd_map_page()

2021-04-07 Thread Pavel Tatashin
message] Signed-off-by: Pavel Tatashin --- arch/arm64/include/asm/trans_pgd.h | 5 +-- arch/arm64/mm/trans_pgd.c | 57 -- 2 files changed, 1 insertion(+), 61 deletions(-) diff --git a/arch/arm64/include/asm/trans_pgd.h b/arch/arm64/include/asm/trans_pgd.h index

[PATCH v13 17/18] arm64: kexec: Remove cpu-reset.h

2021-04-07 Thread Pavel Tatashin
This header contains only cpu_soft_restart() which is never used directly anymore. So, remove this header, and rename the helper to be cpu_soft_restart(). Suggested-by: James Morse Signed-off-by: Pavel Tatashin --- arch/arm64/include/asm/kexec.h| 6 ++ arch/arm64/kernel/cpu-reset.S

[PATCH v13 13/18] arm64: kexec: use ld script for relocation function

2021-04-07 Thread Pavel Tatashin
Currently, relocation code declares start and end variables which are used to compute its size. The better way to do this is to use ld script incited, and put relocation function in its own section. Signed-off-by: Pavel Tatashin --- arch/arm64/include/asm/sections.h | 1 + arch/arm64/kernel

[PATCH v13 16/18] arm64: kexec: remove the pre-kexec PoC maintenance

2021-04-07 Thread Pavel Tatashin
Now that kexec does its relocations with the MMU enabled, we no longer need to clean the relocation data to the PoC. Co-developed-by: James Morse Signed-off-by: Pavel Tatashin --- arch/arm64/kernel/machine_kexec.c | 40 --- 1 file changed, 40 deletions(-) diff

[PATCH v13 15/18] arm64: kexec: keep MMU enabled during kexec relocation

2021-04-07 Thread Pavel Tatashin
a second. Signed-off-by: Pavel Tatashin --- arch/arm64/include/asm/kexec.h | 3 +++ arch/arm64/kernel/asm-offsets.c | 1 + arch/arm64/kernel/machine_kexec.c | 16 ++ arch/arm64/kernel/relocate_kernel.S | 33 +++-- 4 files changed, 38 insertions

[PATCH v13 12/18] arm64: kexec: relocate in EL1 mode

2021-04-07 Thread Pavel Tatashin
Since we are going to keep MMU enabled during relocation, we need to keep EL1 mode throughout the relocation. Keep EL1 enabled, and switch EL2 only before enterying the new world. Suggested-by: James Morse Signed-off-by: Pavel Tatashin --- arch/arm64/kernel/cpu-reset.h | 3 +-- arch

[PATCH v13 11/18] arm64: kexec: kexec may require EL2 vectors

2021-04-07 Thread Pavel Tatashin
If we have a EL2 mode without VHE, the EL2 vectors are needed in order to switch to EL2 and jump to new world with hypervisor privileges. In preporation to MMU enabled relocation, configure our EL2 table now. Suggested-by: James Morse Signed-off-by: Pavel Tatashin --- arch/arm64/Kconfig

[PATCH v13 10/18] arm64: kexec: pass kimage as the only argument to relocation function

2021-04-07 Thread Pavel Tatashin
more arguments: once we enable MMU we will need to pass information about page tables. Pass kimage to arm64_relocate_new_kernel, and teach it to get the required fields from kimage. Suggested-by: James Morse Signed-off-by: Pavel Tatashin --- arch/arm64/kernel/asm-offsets.c | 7 +++ arch

[PATCH v13 09/18] arm64: kexec: Use dcache ops macros instead of open-coding

2021-04-07 Thread Pavel Tatashin
on the eye. Code generated by the existing callers is unchanged. Signed-off-by: James Morse [Fixed merging issues] Signed-off-by: Pavel Tatashin --- arch/arm64/include/asm/assembler.h | 12 arch/arm64/kernel/relocate_kernel.S | 13 +++-- 2 files changed, 11 insertions

[PATCH v13 07/18] arm64: kexec: flush image and lists during kexec load time

2021-04-07 Thread Pavel Tatashin
Currently, during kexec load we are copying relocation function and flushing it. However, we can also flush kexec relocation buffers and if new kernel image is already in place (i.e. crash kernel), we can also flush the new kernel image itself. Signed-off-by: Pavel Tatashin --- arch/arm64

[PATCH v13 08/18] arm64: kexec: skip relocation code for inplace kexec

2021-04-07 Thread Pavel Tatashin
In case of kdump or when segments are already in place the relocation is not needed, therefore the setup of relocation function and call to it can be skipped. Signed-off-by: Pavel Tatashin Suggested-by: James Morse --- arch/arm64/kernel/machine_kexec.c | 34

[PATCH v13 06/18] arm64: hibernate: abstract ttrb0 setup function

2021-04-07 Thread Pavel Tatashin
Currently, only hibernate sets custom ttbr0 with safe idmaped function. Kexec, is also going to be using this functinality when relocation code is going to be idmapped. Move the setup seqeuence to a dedicated cpu_install_ttbr0() for custom ttbr0. Suggested-by: James Morse Signed-off-by: Pavel

[PATCH v13 05/18] arm64: trans_pgd: hibernate: Add trans_pgd_copy_el2_vectors

2021-04-07 Thread Pavel Tatashin
Users of trans_pgd may also need a copy of vector table because it is also may be overwritten if a linear map can be overwritten. Move setup of EL2 vectors from hibernate to trans_pgd, so it can be later shared with kexec as well. Suggested-by: James Morse Signed-off-by: Pavel Tatashin

[PATCH v13 04/18] arm64: kernel: add helper for booted at EL2 and not VHE

2021-04-07 Thread Pavel Tatashin
Replace places that contain logic like this: is_hyp_mode_available() && !is_kernel_in_hyp_mode() With a dedicated boolean function is_hyp_callable(). This will be needed later in kexec in order to sooner switch back to EL2. Suggested-by: James Morse Signed-off-by: Pavel

[PATCH v13 03/18] arm64: hyp-stub: Move el1_sync into the vectors

2021-04-07 Thread Pavel Tatashin
-off-by: James Morse [Fixed merging issues] Signed-off-by: Pavel Tatashin --- arch/arm64/kernel/hyp-stub.S | 59 ++-- 1 file changed, 29 insertions(+), 30 deletions(-) diff --git a/arch/arm64/kernel/hyp-stub.S b/arch/arm64/kernel/hyp-stub.S index ff329c5c074d

[PATCH v13 02/18] arm64: hyp-stub: Move invalid vector entries into the vectors

2021-04-07 Thread Pavel Tatashin
within its vectors. Signed-off-by: James Morse [Fixed merging issues] Signed-off-by: Pavel Tatashin --- arch/arm64/kernel/hyp-stub.S | 56 +++- 1 file changed, 23 insertions(+), 33 deletions(-) diff --git a/arch/arm64/kernel/hyp-stub.S b/arch/arm64/kernel/hyp

[PATCH v13 01/18] arm64: hyp-stub: Check the size of the HYP stub's vectors

2021-04-07 Thread Pavel Tatashin
a build check that we didn't overflow 2K. Signed-off-by: James Morse Signed-off-by: Pavel Tatashin --- arch/arm64/kernel/hyp-stub.S | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/kernel/hyp-stub.S b/arch/arm64/kernel/hyp-stub.S index 5eccbd62fec8

[PATCH v13 00/18] arm64: MMU enabled kexec relocation

2021-04-07 Thread Pavel Tatashin
Morse (4): arm64: hyp-stub: Check the size of the HYP stub's vectors arm64: hyp-stub: Move invalid vector entries into the vectors arm64: hyp-stub: Move el1_sync into the vectors arm64: kexec: Use dcache ops macros instead of open-coding Pavel Tatashin (13): arm64: kernel: add helper

Re: [syzbot] INFO: task hung in io_ring_exit_work

2021-04-07 Thread Pavel Begunkov
On 07/04/2021 20:51, Pavel Begunkov wrote: > On 05/04/2021 20:34, syzbot wrote: >> Hello, >> >> syzbot has tested the proposed patch but the reproducer is still triggering >> an issue: >> INFO: task hung in io_ring_exit_work > > Let's see if it's due to q

Re: [syzbot] INFO: task hung in io_ring_exit_work

2021-04-07 Thread Pavel Begunkov
k.c:294 > kthread+0x3b1/0x4a0 kernel/kthread.c:292 > ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294 > Sending NMI from CPU 1 to CPUs 0: > NMI backtrace for cpu 0 > CPU: 0 PID: 2124 Comm: kswapd1 Not tainted 5.12.0-rc2-syzkaller #0 > Hardware name: Google Google Comput

Re: [PATCH -next v3] bcache: use DEFINE_MUTEX() for mutex lock

2021-04-07 Thread Pavel Goran
__init bcache_init(void) > > check_module_parameters(); > > - mutex_init(_register_lock); > init_waitqueue_head(_wait); > register_reboot_notifier(); > Pavel Goran

Re: [PATCHv2] gnss: motmdm: Add support for Motorola Mapphone MDM6600 modem

2021-04-07 Thread Pavel Machek
of_platform_populate() > instead of walking the child nodes in gsm_serdev_register_tty_port(). I have "gsmmux,port" for that. And yes, I can take a look at of_platform_populate. But as I explained above, there's still problem with the parent devices. Best regards, Pavel -- http://www.livejournal.com/~pavelmachek signature.asc Description: Digital signature

Re: [PATCH 4.4 00/28] 4.4.265-rc1 review

2021-04-07 Thread Pavel Machek
here: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.4.y Tested-by: Pavel Machek (CIP) Best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kir

Re: [PATCH 4.19 00/56] 4.19.185-rc1 review

2021-04-07 Thread Pavel Machek
roblems here: (Siemens boards are unavailable) https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.19.y Tested-by: Pavel Machek (CIP) Best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: W

Re: [PATCH 5.10 000/126] 5.10.28-rc1 review

2021-04-07 Thread Pavel Machek
roblems here: (Siemens boards are unavailable) https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y Tested-by: Pavel Machek (CIP) Best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: W

Re: [PATCH 5.10 079/126] drm/tegra: sor: Grab runtime PM reference across reset

2021-04-06 Thread Pavel Machek
of this actually leaking are practically zero, so I > didn't want to bloat this bugfix with what's essentially dead code. I > can queue up your fix below for v5.14, though, since it's obviously > more correct from a theoretical point of view. Yes, that sounds like good solution, thanks! Best r

Re: [PATCH] net: fix shift-out-of-bounds in nl802154_new_interface

2021-04-06 Thread Pavel Skripkin
On Tue, 2021-04-06 at 08:21 -0400, Alexander Aring wrote: > Hi, > > On Mon, 5 Apr 2021 at 15:58, Pavel Skripkin > wrote: > > > > syzbot reported shift-out-of-bounds in nl802154_new_interface. > > The problem was in signed representation of enum nl802154_iftype

[PATCH] net: fix shift-out-of-bounds in nl802154_new_interface

2021-04-05 Thread Pavel Skripkin
of this type will be represented as signed integer. type = nla_get_u32(info->attrs[NL802154_ATTR_IFTYPE]); u32 will be casted to signed, which can cause negative value type. Reported-by: syzbot+7bf7b22759195c9a2...@syzkaller.appspotmail.com Signed-off-by: Pavel Skripkin --- net/ieee802154/nl802

Re: [syzbot] INFO: task hung in io_ring_exit_work

2021-04-05 Thread Pavel Begunkov
00 R09: 7ffe75923090 > R10: R11: 0246 R12: 7ffe758f7ce4 > R13: 7ffe758f7d40 R14: 028f R15: 7ffe758f7d20 > > > --- > This report is generated by a bot. It may contain errors. > See https://goo.gl/tpsmEJ for more information about syzbot. > syzbot engineers can be reached at syzkal...@googlegroups.com. > > syzbot will keep track of this issue. See: > https://goo.gl/tpsmEJ#status for how to communicate with syzbot. > syzbot can test patches for this issue, for details see: > https://goo.gl/tpsmEJ#testing-patches > -- Pavel Begunkov

Re: [PATCH 5.10 079/126] drm/tegra: sor: Grab runtime PM reference across reset

2021-04-05 Thread Pavel Machek
that the SOR > power domain is not powered off by holding on to a runtime PM reference > to that power domain across the reset assert/deassert operation. Yeah, but it should not leak the PM reference in the error handling. Signed-off-by: Pavel Machek (C

Re: [PATCH 5.10 048/126] net: ethernet: aquantia: Handle error cleanup of start on open

2021-04-05 Thread Pavel Machek
ok at the goto. Does not need to be there. Second check the crazy calling convention. If nic_start() fails, it should clean up after itself. Then, check the code. nic_stop() undoes initialization that was not even done in the nic_start(). This introduces more problems than it solves. Best regard

Re: [PATCH 5.10 047/126] ath10k: hold RCU lock when calling ieee80211_find_sta_by_ifaddr()

2021-04-05 Thread Pavel Machek
); > } The switch only takes the lock in 3 branches, but it is released unconditionally at the end. Something like this? Best regards, Pavel Signed-off-by: Pavel Machek (CIP) diff --git a/drivers/net/wireless/ath/ath10k/wmi-tl

Re: [PATCH 5.10 039/126] can: dev: move driver related infrastructure into separate subdir

2021-04-05 Thread Pavel Machek
ble. I don't think any of the follow up patches depend on it...? Best regards, Pavel > drivers/net/can/Makefile | 7 +-- > drivers/net/can/dev/Makefile | 7 +++ > drivers/net/can/{ => dev}/d

Re: [PATCH 5.10 004/126] ext4: shrink race window in ext4_should_retry_alloc()

2021-04-05 Thread Pavel Machek
ior. This adds new counter exported via sysfs, but no documentation of that counter... Best regards, Pavel > @@ -257,6 +259,7 @@ static struct attribute *ext4_attrs[] = { > ATTR_LIST(session_write_kbyte

Re: [PATCH v2] net: mac802154: Fix general protection fault

2021-04-04 Thread Pavel Skripkin
Hi! On Sun, 2021-04-04 at 20:43 -0400, Alexander Aring wrote: > Hi, > > On Thu, 4 Mar 2021 at 10:25, Pavel Skripkin > wrote: > > > > syzbot found general protection fault in crypto_destroy_tfm()[1]. > > It was caused by wrong clean up loop in llsec_key_alloc(

Re: [PATCH] net: netlink: fix error check in genl_family_rcv_msg_doit

2021-04-03 Thread Pavel Skripkin
Hi! On Sat, 2021-04-03 at 18:26 +0200, Johannes Berg wrote: > On Sat, 2021-04-03 at 15:13 +0000, Pavel Skripkin wrote: > > genl_family_rcv_msg_attrs_parse() can return NULL > > pointer: > > > > if (!ops->maxattr) > > return NULL; >

[PATCH] net: fix NULL ptr dereference in nl802154_del_llsec_key

2021-04-03 Thread Pavel Skripkin
328/0x580 net/netlink/genetlink.c:800 Reported-by: syzbot+ac5c11d2959a8b3c4...@syzkaller.appspotmail.com Signed-off-by: Pavel Skripkin --- net/ieee802154/nl802154.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c in

[PATCH] net: netlink: fix error check in genl_family_rcv_msg_doit

2021-04-03 Thread Pavel Skripkin
genl_family_rcv_msg_attrs_parse() can return NULL pointer: if (!ops->maxattr) return NULL; But this condition doesn't cause an error in genl_family_rcv_msg_doit Signed-off-by: Pavel Skripkin --- net/netlink/genetlink.c | 2 ++ 1 file changed, 2 insertions(+) d

[PATCH] clone3: add option to change owner of newly created namespaces

2021-04-02 Thread Pavel Tikhomirov
ids on each level of nested user and pid namespaces when used together with userns_fd: https://github.com/Snorch/clone3_owner_ns Signed-off-by: Pavel Tikhomirov --- include/linux/nsproxy.h| 3 ++- include/linux/sched/task.h | 1 + include/linux/user_namespace.h | 6 ++ include/uapi/l

Re: [PATCH] block: don't ignore REQ_NOWAIT for direct IO

2021-04-02 Thread Pavel Begunkov
On 20/11/2020 19:13, Jens Axboe wrote: > On 11/20/20 10:10 AM, Pavel Begunkov wrote: >> io_uring's direct nowait requests end up waiting on io_schedule() in >> sbitmap, that's seems to be so because blkdev_direct_IO() fails to >> propagate IOCB_NOWAIT to a bio and hence to blk

Re: [PATCH] mm/hugeltb: fix renaming of PF_MEMALLOC_NOCMA to PF_MEMALLOC_PIN

2021-04-01 Thread Pavel Tatashin
> > Andrew, since "mm cma: rename PF_MEMALLOC_NOCMA to PF_MEMALLOC_PIN" is > > not yet in the mainline, should I send a new version of this patch so > > we won't have bisecting problems in the future? > > I've already added Mike's fix, as >

[PATCH] drivers: net: fix memory leak in peak_usb_create_dev

2021-04-01 Thread Pavel Skripkin
can_usb_core.c:851 [inline] [1] [<c09f9057>] peak_usb_probe+0x389/0x490 drivers/net/can/usb/peak_usb/pcan_usb_core.c:949 Reported-by: syzbot+91adee8d9ebb9193d...@syzkaller.appspotmail.com Signed-off-by: Pavel Skripkin --- drivers/net/can/usb/peak_usb/pcan_usb_core.c | 6 +- 1 file

  1   2   3   4   5   6   7   8   9   10   >