From: Peng Fan
Use pr_err to print out error message without enabling DEBUG. This could
make people catch error easier.
Signed-off-by: Peng Fan
---
drivers/vhost/vhost.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h
index
> Subject: Re: [PATCH V3 8/8] remoteproc: imx_rproc: support i.MX8MN/P
Hi Mathieu,
Your all comments are good suggestion in the patchset, I not reply your
comment one by one for each patch. In V4 patchset, hope I have fixed
all the issues you pointed.
Thanks for your reviewing.
Thanks,
Peng.
On 2021/4/8 0:18, Mathieu Poirier wrote:
On Tue, Mar 30, 2021 at 05:12:46PM +0800, peng@oss.nxp.com wrote:
From: Peng Fan
V2:
Patch 1/8, use fsl as vendor, typo fix
Because patchset [1] has v2 version, patch 5,6,7,8 are adapted that change.
This patchset is to support
Hi Lucas,
On 2021/4/8 6:13, Lucas Stach wrote:
Hi Adrien,
I feel like I already mentioned to you some time ago that there is
already a much more complete patch series to add this functionality on
the list [1].
If you want this functionality to go upstream, please help test and
extend this
From: Peng Fan
Support remote cores booted before Linux Kernel booting.
Add rsc_table to hold the resource table published by remote cores
Add attach hook
Add imx_rproc_detect_mode to detect remote cores' working mode, and if
remote cores are booted before booting Linux Kernel, parse the memory
From: Peng Fan
8 is not enough when we need more, so enlarge IMX7D_RPROC_MEM_MAX to 32,
and also rename it to IMX_RPROC_MEM_MAX which make more sense.
Signed-off-by: Peng Fan
---
drivers/remoteproc/imx_rproc.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
Mathieu,
> Subject: Re: [PATCH V13 00/10] remoteproc: imx_rproc: support iMX8MQ/M
>
> On Sat, Mar 06, 2021 at 07:24:15PM +0800, peng@oss.nxp.com wrote:
> > From: Peng Fan
> >
> > V13:
> > Add R-b tag from Rob for patch 1.
> > Drop the reserved memory node from patch 2 per Rob's comment.
>
Hi Rob,
> Subject: [PATCH V12 01/10] dt-bindings: remoteproc: convert imx rproc
> bindings to json-schema
Are you fine with patch 1, 2?
Thanks,
Peng.
>
> From: Peng Fan
>
> Convert the imx rproc binding to DT schema format using json-schema.
>
> Signed-off-by: Peng Fan
> ---
>
Hi Shawn,
> Subject: Re: [PATCH V3 0/5] imx esdhc dt/driver update
>
> On Thu, 25 Feb 2021 at 04:22, wrote:
> >
> > From: Peng Fan
> >
> > V3:
> > Patch 1, drop unneeded pinctrl-0/1/2
> > Patch 2 is new to avoid break dt bindings check
> > V2:
> > patch 1, 2, 3 is new
> > patch 4 is not
From: Peng Fan
We are using Jailhouse Hypervsior which has virtual pci node that
use dt domains. so also use dt domains for pci node, this will avoid
conflict with Jailhouse Hypervisor to trigger the following error:
pr_err("Inconsistent \"linux,pci-domain\" property in DT\n");
From: Peng Fan
When imx_data->pinctrl is not a valid pointer, pinctrl_lookup_state
will trigger kernel panic.
When we boot Dual OS on Jailhouse hypervisor, we let the 1st Linux to
configure pinmux ready for the 2nd OS, so the 2nd OS not have pinctrl
settings.
Similar to this commit
From: Peng Fan
We might need to map an region multiple times, becaue the region might
be shared between remote processors, such i.MX8QM with dual M4 cores.
So use devm_ioremap, not devm_ioremap_resource.
Reviewed-by: Oleksij Rempel
Reviewed-by: Richard Zhu
Signed-off-by: Peng Fan
---
V4:
From: Peng Fan
V4:
According to Bjorn's comments, add is_iomem for da to va usage
1/8, 2/8 is new patch
3/8, follow Bjorn's comments to correct/update the err msg.
6/8, new patch
8/8, use dev_err_probe to simplify code, use queue_work instead
schedule_delayed_work
From: Peng Fan
Introduce is_iomem to indicate this piece memory is iomem or not.
Signed-off-by: Peng Fan
---
V4:
New patch
include/linux/remoteproc.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h
index
From: Peng Fan
The hook is used to parse memory-regions and load resource table
from the address the remote processor published.
Signed-off-by: Peng Fan
Reviewed-by: Richard Zhu
Reviewed-by: Mathieu Poirier
---
V4:
None
drivers/remoteproc/imx_rproc.c | 93
From: Peng Fan
Introduce an extra parameter is_iomem to da_to_va, then the caller
could take the memory as normal memory or io mapped memory.
Signed-off-by: Peng Fan
---
V4:
New patch
drivers/remoteproc/imx_rproc.c | 2 +-
drivers/remoteproc/ingenic_rproc.c | 2 +-
From: Peng Fan
vdev regions are vdev0vring0, vdev0vring1, vdevbuffer and similar.
They are handled by remoteproc common code, no need to map in imx
rproc driver.
Signed-off-by: Peng Fan
---
V4:
New
drivers/remoteproc/imx_rproc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
From: Peng Fan
It is using devm_ioremap, so not devm_ioremap_resource. Correct
the error message and print out sa/size.
Signed-off-by: Peng Fan
---
V4:
Drop the R-b tag
Follow Bjorn's comments, correct/update the err msg.
drivers/remoteproc/imx_rproc.c | 4 ++--
1 file changed, 2
From: Peng Fan
Use virtio/mailbox to build connection between Remote Proccessors
and Linux. Add work queue to handle incoming messages.
Reviewed-by: Richard Zhu
Signed-off-by: Peng Fan
---
V4:
Use dev_err_probe to simplify code
Use queue_work
drivers/remoteproc/imx_rproc.c | 115
From: Peng Fan
Add i.MX8MQ dev/sys addr map and configuration data structure
i.MX8MM share i.MX8MQ settings.
Reviewed-by: Richard Zhu
Signed-off-by: Peng Fan
Reviewed-by: Mathieu Poirier
---
V4:
None
drivers/remoteproc/imx_rproc.c | 39 ++
1 file changed,
From: Peng Fan
ZONE_DMA should not be disabled, otherwise arm64_dma_phys_limit is
left uninitialized and cause swiotlb have IO TLB above 4GB which
might crash some platforms
Signed-off-by: Peng Fan
---
Not sure whether need to address code to initialize the variables or
force select ZONE_DMA
From: Peng Fan
krealloc_array is used in drivers/vhost/vringh.c, add it to avoid build
failure.
Drop WARN_ON_ONCE, because duplicated with the one in bug.h
Signed-off-by: Peng Fan
---
tools/virtio/linux/kernel.h | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git
From: Peng Fan
Add barrier for aarch64 for cross compiling, and most are from Linux Kernel.
Signed-off-by: Peng Fan
---
tools/virtio/asm/barrier.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/tools/virtio/asm/barrier.h b/tools/virtio/asm/barrier.h
index
From: Peng Fan
WARN_ON is used in drivers/vhost/vringh.c, to avoid build failure,
need include asm/bug.h
Signed-off-by: Peng Fan
---
tools/virtio/linux/bug.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/virtio/linux/bug.h b/tools/virtio/linux/bug.h
index
From: Peng Fan
Not sure whether this is correct fix for aarch64 build, just a try.
I still need to drop -Werror to make it build, but not included in this
patchset.
Peng Fan (3):
tools/virtio: include asm/bug.h
tools/virtio: add krealloc_array
tools/virtio: add barrier for aarch64
From: Peng Fan
Use virtio/mailbox to build connection between Remote Proccessors
and Linux. Add work queue to handle incoming messages.
Reviewed-by: Richard Zhu
Signed-off-by: Peng Fan
---
drivers/remoteproc/imx_rproc.c | 133 -
1 file changed, 130
From: Peng Fan
The hook is used to parse memory-regions and load resource table
from the address the remote processor published.
Signed-off-by: Peng Fan
Reviewed-by: Richard Zhu
Reviewed-by: Mathieu Poirier
---
drivers/remoteproc/imx_rproc.c | 93 ++
1 file
From: Peng Fan
Add i.MX8MQ dev/sys addr map and configuration data structure
i.MX8MM share i.MX8MQ settings.
Reviewed-by: Richard Zhu
Signed-off-by: Peng Fan
Reviewed-by: Mathieu Poirier
---
drivers/remoteproc/imx_rproc.c | 40 ++
1 file changed, 40
From: Peng Fan
We might need to map an region multiple times, becaue the region might
be shared between remote processors, such i.MX8QM with dual M4 cores.
So use devm_ioremap, not devm_ioremap_resource.
Reviewed-by: Oleksij Rempel
Reviewed-by: Richard Zhu
Signed-off-by: Peng Fan
---
From: Peng Fan
It is using devm_ioremap, so not devm_ioremap_resource. Correct
the error message and print out sa/size.
Acked-by: Richard Zhu
Reviewed-by: Mathieu Poirier
Signed-off-by: Peng Fan
---
drivers/remoteproc/imx_rproc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
From: Peng Fan
To arm64, "dc zva, dst" is used in memset.
Per ARM DDI 0487A.j, chapter C5.3.8 DC ZVA, Data Cache Zero by VA,
"If the memory region being zeroed is any type of Device memory,
this instruction can give an alignment fault which is prioritized
in the same way as other alignment
From: Peng Fan
Add elf memory hooks according to elf_mem_hook setting in the platform
configuration dcfg.
Acked-by: Richard Zhu
Signed-off-by: Peng Fan
---
drivers/remoteproc/imx_rproc.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/remoteproc/imx_rproc.c
From: Peng Fan
V3:
Since I was quite busy in the past days, V3 is late
Rebased on Linux-next
Add R-b tags
1/7: Add R-b tag of Mathieu, add comments
4/7: Typo fix
5/7: Add R-b tag of Mathieu, drop index Per Mathieu's comments
6/7: Add R-b tag of Mathieu
7/7: Add comment for vqid << 16,
33 matches
Mail list logo
