Re: [PATCH v5 5/6] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node

On Tue, Aug 09, 2016 at 05:15:36PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-08-08 01:52:10) > > From: Peter Chen > > > > At device tree, we have no device node for chipidea core, > > the glue layer's node is the parent node for host and udc > &

Re: [PATCH v5 6/6] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property

On Tue, Aug 09, 2016 at 04:33:35PM -0700, Joshua Clayton wrote: > Hi Peter, > > On 08/08/2016 01:52 AM, Peter Chen wrote: > > The current dts describes USB HUB's property at USB controller's > > entry, it is improper. The USB HUB should be the child node > > unde

Re: [PATCH v5 6/6] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property

On Tue, Aug 09, 2016 at 04:33:35PM -0700, Joshua Clayton wrote: > Hi Peter, > > On 08/08/2016 01:52 AM, Peter Chen wrote: > > The current dts describes USB HUB's property at USB controller's > > entry, it is improper. The USB HUB should be the child node > > unde

RE: [PATCH v2 06/22] usb: chipidea: Add platform flag for wrapper phy management

>> On Fri, Aug 05, 2016 at 02:46:00PM -0700, Stephen Boyd wrote: >> > Quoting Peter Chen (2016-07-08 02:25:35) >> > > >> > > How you handle the code for PHY getting at probe? >> > > >> > >> > Which probe? Glue layer probe? In

RE: [PATCH v2 06/22] usb: chipidea: Add platform flag for wrapper phy management

>> On Fri, Aug 05, 2016 at 02:46:00PM -0700, Stephen Boyd wrote: >> > Quoting Peter Chen (2016-07-08 02:25:35) >> > > >> > > How you handle the code for PHY getting at probe? >> > > >> > >> > Which probe? Glue layer probe? In

Re: [RESEND PATCH] usb: hub: change CLEAR_FEATURE to SET_FEATURE

On Tue, Aug 9, 2016 at 4:25 PM, Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Tue, Aug 09, 2016 at 04:07:56PM +0800, yonglong.wu wrote: >> Hi, >> On Tue, 2016-08-09 at 14:29 +0800, Peter Chen wrote: >> >> On Tue, Aug 9, 2016 at 11:31 AM, Yong

Re: [RESEND PATCH] usb: hub: change CLEAR_FEATURE to SET_FEATURE

On Tue, Aug 9, 2016 at 4:25 PM, Greg Kroah-Hartman wrote: > On Tue, Aug 09, 2016 at 04:07:56PM +0800, yonglong.wu wrote: >> Hi, >> On Tue, 2016-08-09 at 14:29 +0800, Peter Chen wrote: >> >> On Tue, Aug 9, 2016 at 11:31 AM, Yonglong Wu >>

Re: [RESEND PATCH] usb: hub: change CLEAR_FEATURE to SET_FEATURE

On Tue, Aug 9, 2016 at 11:31 AM, Yonglong Wu wrote: > From: Yonglong Wu > > According to USB30 specification, the Function Remote Wakeup field can be > modified by the SetFeature() requests. SetFeature() is recommended to use. > >

Re: [RESEND PATCH] usb: hub: change CLEAR_FEATURE to SET_FEATURE

On Tue, Aug 9, 2016 at 11:31 AM, Yonglong Wu wrote: > From: Yonglong Wu > > According to USB30 specification, the Function Remote Wakeup field can be > modified by the SetFeature() requests. SetFeature() is recommended to use. > > Signed-off-by: Yonglong Wu > --- > drivers/usb/core/hub.c |

RE: [PATCH v2 08/22] usb: chipidea: Remove locking in ci_udc_start()

>Quoting Peter Chen (2016-08-06 00:54:35) >> On Fri, Aug 05, 2016 at 02:53:56PM -0700, Stephen Boyd wrote: >> > Quoting Peter Chen (2016-07-08 02:45:28) >> > > On Thu, Jul 07, 2016 at 03:20:59PM -0700, Stephen Boyd wrote: >> > > > We don't call

RE: [PATCH v2 08/22] usb: chipidea: Remove locking in ci_udc_start()

>Quoting Peter Chen (2016-08-06 00:54:35) >> On Fri, Aug 05, 2016 at 02:53:56PM -0700, Stephen Boyd wrote: >> > Quoting Peter Chen (2016-07-08 02:45:28) >> > > On Thu, Jul 07, 2016 at 03:20:59PM -0700, Stephen Boyd wrote: >> > > > We don't call

[PATCH v5 6/6] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property

The current dts describes USB HUB's property at USB controller's entry, it is improper. The USB HUB should be the child node under USB controller, and power sequence properties are under it. Signed-off-by: Peter Chen <peter.c...@nxp.com> --- arch/arm/boot/dts/imx6qdl-udoo.dts

[PATCH v5 6/6] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property

The current dts describes USB HUB's property at USB controller's entry, it is improper. The USB HUB should be the child node under USB controller, and power sequence properties are under it. Signed-off-by: Peter Chen --- arch/arm/boot/dts/imx6qdl-udoo.dtsi | 26 +- 1

[PATCH v5 1/6] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

Add binding doc for generic power sequence library. Signed-off-by: Peter Chen <peter.c...@nxp.com> Acked-by: Philipp Zabel <p.za...@pengutronix.de> Acked-by: Rob Herring <r...@kernel.org> --- .../bindings/power/pwrseq/pwrseq-generic.txt | 48 ++

[PATCH v5 1/6] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

Add binding doc for generic power sequence library. Signed-off-by: Peter Chen Acked-by: Philipp Zabel Acked-by: Rob Herring --- .../bindings/power/pwrseq/pwrseq-generic.txt | 48 ++ 1 file changed, 48 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v5 2/6] power: add power sequence library

and clocks currently, and can cover regulator and pinctrl in future. The host driver calls pwrseq_alloc_generic to create an generic pwrseq instance. Signed-off-by: Peter Chen <peter.c...@nxp.com> Tested-by Joshua Clayton <stillcompil...@gmail.com> --- MAINTAINERS

[PATCH v5 2/6] power: add power sequence library

and clocks currently, and can cover regulator and pinctrl in future. The host driver calls pwrseq_alloc_generic to create an generic pwrseq instance. Signed-off-by: Peter Chen Tested-by Joshua Clayton --- MAINTAINERS | 9 ++ drivers/power/Kconfig | 1

[PATCH v5 5/6] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node

From: Peter Chen <peter.c...@freescale.com> At device tree, we have no device node for chipidea core, the glue layer's node is the parent node for host and udc device. But in related driver, the parent device is chipidea core. So, in order to let the common driver get parent's node,

[PATCH v5 5/6] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node

From: Peter Chen At device tree, we have no device node for chipidea core, the glue layer's node is the parent node for host and udc device. But in related driver, the parent device is chipidea core. So, in order to let the common driver get parent's node, we let the core's device node equals

[PATCH v5 4/6] usb: core: add power sequence handling for USB devices

). At hub_disconnect, it will do power off sequence which is at powered on list. Signed-off-by: Peter Chen <peter.c...@nxp.com> Tested-by Joshua Clayton <stillcompil...@gmail.com> --- drivers/usb/core/Makefile | 1 + drivers/usb/core/hub.c| 12 -- drivers/usb/core/hu

[PATCH v5 3/6] binding-doc: usb: usb-device: add optional properties for power sequence

Add optional properties for power sequence. Signed-off-by: Peter Chen <peter.c...@nxp.com> Acked-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/usb/usb-device.txt | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Documentatio

[PATCH v5 4/6] usb: core: add power sequence handling for USB devices

). At hub_disconnect, it will do power off sequence which is at powered on list. Signed-off-by: Peter Chen Tested-by Joshua Clayton --- drivers/usb/core/Makefile | 1 + drivers/usb/core/hub.c| 12 -- drivers/usb/core/hub.h| 12 ++ drivers/usb/core/pwrseq.c | 100

[PATCH v5 3/6] binding-doc: usb: usb-device: add optional properties for power sequence

Add optional properties for power sequence. Signed-off-by: Peter Chen Acked-by: Rob Herring --- Documentation/devicetree/bindings/usb/usb-device.txt | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/usb/usb-device.txt b

[PATCH v5 0/6] power: add power sequence library

layer's at core's probe Peter Chen (6): binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library power: add power sequence library binding-doc: usb: usb-device: add optional properties for power sequence usb: core: add power sequence handling f

[PATCH v5 0/6] power: add power sequence library

layer's at core's probe Peter Chen (6): binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library power: add power sequence library binding-doc: usb: usb-device: add optional properties for power sequence usb: core: add power sequence handling f

Re: [PATCH v4 0/6] power: add power sequence library

On Sat, Aug 06, 2016 at 02:00:08PM +0200, Oscar wrote: > El 2016-08-02 05:30, Peter Chen escribió: > >Hi all, > > > >This is a follow-up for my last power sequence framework patch set > >[1]. > >According to Rob Herring and Ulf Hansson's comments[2], I use a >

Re: [PATCH v4 0/6] power: add power sequence library

On Sat, Aug 06, 2016 at 02:00:08PM +0200, Oscar wrote: > El 2016-08-02 05:30, Peter Chen escribió: > >Hi all, > > > >This is a follow-up for my last power sequence framework patch set > >[1]. > >According to Rob Herring and Ulf Hansson's comments[2], I use a >

Re: [PATCH v2 04/22] usb: chipidea: Only read/write OTGSC from one place

On Fri, Aug 05, 2016 at 02:41:37PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-07-08 02:14:57) > > On Thu, Jul 07, 2016 at 03:20:55PM -0700, Stephen Boyd wrote: > > > diff --git a/drivers/usb/chipidea/otg.c b/drivers/usb/chipidea/otg.c > > > index 03b674

Re: [PATCH v2 04/22] usb: chipidea: Only read/write OTGSC from one place

On Fri, Aug 05, 2016 at 02:41:37PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-07-08 02:14:57) > > On Thu, Jul 07, 2016 at 03:20:55PM -0700, Stephen Boyd wrote: > > > diff --git a/drivers/usb/chipidea/otg.c b/drivers/usb/chipidea/otg.c > > > index 03b674

Re: [PATCH v2 06/22] usb: chipidea: Add platform flag for wrapper phy management

On Fri, Aug 05, 2016 at 02:46:00PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-07-08 02:25:35) > > On Thu, Jul 07, 2016 at 03:20:57PM -0700, Stephen Boyd wrote: > > > The ULPI phy on qcom platforms needs to be initialized and > > > powered on after a USB

Re: [PATCH v2 06/22] usb: chipidea: Add platform flag for wrapper phy management

On Fri, Aug 05, 2016 at 02:46:00PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-07-08 02:25:35) > > On Thu, Jul 07, 2016 at 03:20:57PM -0700, Stephen Boyd wrote: > > > The ULPI phy on qcom platforms needs to be initialized and > > > powered on after a USB

Re: [PATCH v2 08/22] usb: chipidea: Remove locking in ci_udc_start()

On Fri, Aug 05, 2016 at 02:53:56PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-07-08 02:45:28) > > On Thu, Jul 07, 2016 at 03:20:59PM -0700, Stephen Boyd wrote: > > > We don't call hw_device_reset() with the ci->lock held, so it > > > doesn't seem lik

Re: [PATCH v2 08/22] usb: chipidea: Remove locking in ci_udc_start()

On Fri, Aug 05, 2016 at 02:53:56PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-07-08 02:45:28) > > On Thu, Jul 07, 2016 at 03:20:59PM -0700, Stephen Boyd wrote: > > > We don't call hw_device_reset() with the ci->lock held, so it > > > doesn't seem lik

Re: [PATCH v4 2/6] power: add power sequence library

On Wed, Aug 03, 2016 at 03:16:58PM -0700, Matthias Kaehlcke wrote: > El Tue, Aug 02, 2016 at 11:30:48AM +0800 Peter Chen ha dit: > > > diff --git a/drivers/power/pwrseq/core.c b/drivers/power/pwrseq/core.c > > > > ... > > > > +static DEFINE_MUTEX(pwrse

Re: [PATCH v4 2/6] power: add power sequence library

On Wed, Aug 03, 2016 at 03:16:58PM -0700, Matthias Kaehlcke wrote: > El Tue, Aug 02, 2016 at 11:30:48AM +0800 Peter Chen ha dit: > > > diff --git a/drivers/power/pwrseq/core.c b/drivers/power/pwrseq/core.c > > > > ... > > > > +static DEFINE_MUTEX(pwrse

[PATCH v4 6/6] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property

The current dts describes USB HUB's property at USB controller's entry, it is improper. The USB HUB should be the child node under USB controller, and power sequence properties are under it. Signed-off-by: Peter Chen <peter.c...@nxp.com> --- arch/arm/boot/dts/imx6qdl-udoo.dts

[PATCH v4 6/6] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property

The current dts describes USB HUB's property at USB controller's entry, it is improper. The USB HUB should be the child node under USB controller, and power sequence properties are under it. Signed-off-by: Peter Chen --- arch/arm/boot/dts/imx6qdl-udoo.dtsi | 26 +- 1

[PATCH v4 5/6] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node

From: Peter Chen <peter.c...@freescale.com> At device tree, we have no device node for chipidea core, the glue layer's node is the parent node for host and udc device. But in related driver, the parent device is chipidea core. So, in order to let the common driver get parent's node,

[PATCH v4 5/6] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node

From: Peter Chen At device tree, we have no device node for chipidea core, the glue layer's node is the parent node for host and udc device. But in related driver, the parent device is chipidea core. So, in order to let the common driver get parent's node, we let the core's device node equals

Re: [v3,2/6] power: add power sequence library

s flags; > >+int reset_gpio, ret = 0; > >+ > >+pwrseq_gen->clk = of_clk_get_by_name(np, NULL); > This only gets the first of potentially multiple clocks, is that intended? Matthias, I have added multiple input clocks support at v4 patch set, and you are at cc list. -- Best Regards, Peter Chen

Re: [v3,2/6] power: add power sequence library

s flags; > >+int reset_gpio, ret = 0; > >+ > >+pwrseq_gen->clk = of_clk_get_by_name(np, NULL); > This only gets the first of potentially multiple clocks, is that intended? Matthias, I have added multiple input clocks support at v4 patch set, and you are at cc list. -- Best Regards, Peter Chen

[PATCH v4 3/6] binding-doc: usb: usb-device: add optional properties for power sequence

Add optional properties for power sequence. Signed-off-by: Peter Chen <peter.c...@nxp.com> Acked-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/usb/usb-device.txt | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Documentatio

[PATCH v4 3/6] binding-doc: usb: usb-device: add optional properties for power sequence

Add optional properties for power sequence. Signed-off-by: Peter Chen Acked-by: Rob Herring --- Documentation/devicetree/bindings/usb/usb-device.txt | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/usb/usb-device.txt b

[PATCH v4 1/6] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

Add binding doc for generic power sequence library. Signed-off-by: Peter Chen <peter.c...@nxp.com> Acked-by: Philipp Zabel <p.za...@pengutronix.de> Acked-by: Rob Herring <r...@kernel.org> --- .../bindings/power/pwrseq/pwrseq-generic.txt | 48 ++

[PATCH v4 4/6] usb: core: add power sequence handling for USB devices

). At hub_disconnect, it will do power off sequence which is at powered on list. Signed-off-by: Peter Chen <peter.c...@nxp.com> Tested-by Joshua Clayton <stillcompil...@gmail.com> --- drivers/usb/core/Makefile | 1 + drivers/usb/core/hub.c| 12 -- drivers/usb/core/hu

[PATCH v4 1/6] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

Add binding doc for generic power sequence library. Signed-off-by: Peter Chen Acked-by: Philipp Zabel Acked-by: Rob Herring --- .../bindings/power/pwrseq/pwrseq-generic.txt | 48 ++ 1 file changed, 48 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v4 4/6] usb: core: add power sequence handling for USB devices

). At hub_disconnect, it will do power off sequence which is at powered on list. Signed-off-by: Peter Chen Tested-by Joshua Clayton --- drivers/usb/core/Makefile | 1 + drivers/usb/core/hub.c| 12 -- drivers/usb/core/hub.h| 12 ++ drivers/usb/core/pwrseq.c | 100

[PATCH v4 2/6] power: add power sequence library

and clocks currently, and can cover regulator and pinctrl in future. The host driver calls pwrseq_alloc_generic to create an generic pwrseq instance. Signed-off-by: Peter Chen <peter.c...@nxp.com> Tested-by Joshua Clayton <stillcompil...@gmail.com> --- MAINTAINERS

[PATCH v4 0/6] power: add power sequence library

erties at dt binding - Should use structure not but its pointer for kzalloc - Since chipidea core has no of_node, let core's of_node equals glue layer's at core's probe Peter Chen (6): binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library power: add po

[PATCH v4 0/6] power: add power sequence library

erties at dt binding - Should use structure not but its pointer for kzalloc - Since chipidea core has no of_node, let core's of_node equals glue layer's at core's probe Peter Chen (6): binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library power: add po

[PATCH v4 2/6] power: add power sequence library

and clocks currently, and can cover regulator and pinctrl in future. The host driver calls pwrseq_alloc_generic to create an generic pwrseq instance. Signed-off-by: Peter Chen Tested-by Joshua Clayton --- MAINTAINERS | 9 ++ drivers/power/Kconfig | 1

Re: [PATCH v3 0/6] power: add power sequence library

ches which is not upstreamed to workaround one SoC problem. http://www.spinics.net/lists/linux-usb/msg98682.html Try to implement the design for notify_suspend/resume at drivers/usb/phy/phy-mxs-usb.c and drivers/usb/chipidea/host.c You can refer to the code at: http://git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/tree/?h=imx_4.1.15_1.0.0_ga -- Best Regards, Peter Chen

Re: [PATCH v3 0/6] power: add power sequence library

ound one SoC problem. http://www.spinics.net/lists/linux-usb/msg98682.html Try to implement the design for notify_suspend/resume at drivers/usb/phy/phy-mxs-usb.c and drivers/usb/chipidea/host.c You can refer to the code at: http://git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/tree/?h=imx_4.1.15_1.0.0_ga -- Best Regards, Peter Chen

Re: [v3,2/6] power: add power sequence library

On Fri, Jul 29, 2016 at 01:06:48PM -0700, Matthias Kaehlcke wrote: > Hi Peter, > > Thanks for your work on this, a few comments inline > > > On 07/20/2016 02:40 AM, Peter Chen wrote: > > >... > > > >+static int pwrseq_generic_on(struct

Re: [v3,2/6] power: add power sequence library

On Fri, Jul 29, 2016 at 01:06:48PM -0700, Matthias Kaehlcke wrote: > Hi Peter, > > Thanks for your work on this, a few comments inline > > > On 07/20/2016 02:40 AM, Peter Chen wrote: > > >... > > > >+static int pwrseq_generic_on(struct

Re: [PATCH v3 1/6] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

On Wed, Jul 20, 2016 at 05:40:24PM +0800, Peter Chen wrote: > Add binding doc for generic power sequence library. > > Signed-off-by: Peter Chen <peter.c...@nxp.com> > Acked-by: Philipp Zabel <p.za...@pengutronix.de> > --- > .../bindings/power/pwrseq

Re: [PATCH v3 1/6] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

On Wed, Jul 20, 2016 at 05:40:24PM +0800, Peter Chen wrote: > Add binding doc for generic power sequence library. > > Signed-off-by: Peter Chen > Acked-by: Philipp Zabel > --- > .../bindings/power/pwrseq/pwrseq-generic.txt | 48 > ++ > 1 fil

Re: [PATCH v3 0/6] power: add power sequence library

On Thu, Jul 28, 2016 at 08:56:40AM -0700, Joshua Clayton wrote: > Hi, Peter > > On 07/20/2016 02:40 AM, Peter Chen wrote: > > Hi all, > > > > This is a follow-up for my last power sequence framework patch set [1]. > > According to Rob Herring and Ulf Hanss

Re: [PATCH v3 0/6] power: add power sequence library

On Thu, Jul 28, 2016 at 08:56:40AM -0700, Joshua Clayton wrote: > Hi, Peter > > On 07/20/2016 02:40 AM, Peter Chen wrote: > > Hi all, > > > > This is a follow-up for my last power sequence framework patch set [1]. > > According to Rob Herring and Ulf Hanss

Re: [PATCH v3 4/6] usb: core: add power sequence handling for USB devices

On Wed, Jul 27, 2016 at 09:25:11AM -0700, Joshua Clayton wrote: > > > On 07/20/2016 02:40 AM, Peter Chen wrote: > > Some hard-wired USB devices need to do power sequence to let the > > device work normally, the typical power sequence like: enable USB > > PHY c

Re: [PATCH v3 4/6] usb: core: add power sequence handling for USB devices

On Wed, Jul 27, 2016 at 09:25:11AM -0700, Joshua Clayton wrote: > > > On 07/20/2016 02:40 AM, Peter Chen wrote: > > Some hard-wired USB devices need to do power sequence to let the > > device work normally, the typical power sequence like: enable USB > > PHY c

Re: [PATCH] usb: gadget: remove redundant self assignment

-107,10 +107,8 @@ int usb_ep_enable(struct usb_ep *ep) > goto out; > > ret = ep->ops->enable(ep, ep->desc); > - if (ret) { > - ret = ret; > + if (ret) > goto out; > - } > > ep->enabled = true; > Reviewed-by: Peter Chen <peter.c...@nxp.com> -- Best Regards, Peter Chen

Re: [PATCH] usb: gadget: remove redundant self assignment

out; > > ret = ep->ops->enable(ep, ep->desc); > - if (ret) { > - ret = ret; > + if (ret) > goto out; > - } > > ep->enabled = true; > Reviewed-by: Peter Chen -- Best Regards, Peter Chen

Re: [PATCH v3 5/6] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node

On Thu, Jul 21, 2016 at 10:41:28AM +0100, Russell King - ARM Linux wrote: > On Thu, Jul 21, 2016 at 05:20:12PM +0800, Peter Chen wrote: > > On Thu, Jul 21, 2016 at 10:14:38AM +0100, Russell King - ARM Linux wrote: > > > On Wed, Jul 20, 2016 at 05:40:28PM +0800, Peter Chen wrote:

Re: [PATCH v3 5/6] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node

On Thu, Jul 21, 2016 at 10:41:28AM +0100, Russell King - ARM Linux wrote: > On Thu, Jul 21, 2016 at 05:20:12PM +0800, Peter Chen wrote: > > On Thu, Jul 21, 2016 at 10:14:38AM +0100, Russell King - ARM Linux wrote: > > > On Wed, Jul 20, 2016 at 05:40:28PM +0800, Peter Chen wrote:

Re: [PATCH v3 5/6] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node

On Thu, Jul 21, 2016 at 10:14:38AM +0100, Russell King - ARM Linux wrote: > On Wed, Jul 20, 2016 at 05:40:28PM +0800, Peter Chen wrote: > > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c > > index 69426e6..0d05812 100644 > > --- a/drivers/usb/chip

Re: [PATCH v3 5/6] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node

On Thu, Jul 21, 2016 at 10:14:38AM +0100, Russell King - ARM Linux wrote: > On Wed, Jul 20, 2016 at 05:40:28PM +0800, Peter Chen wrote: > > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c > > index 69426e6..0d05812 100644 > > --- a/drivers/usb/chip

[PATCH v3 1/6] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

Add binding doc for generic power sequence library. Signed-off-by: Peter Chen <peter.c...@nxp.com> Acked-by: Philipp Zabel <p.za...@pengutronix.de> --- .../bindings/power/pwrseq/pwrseq-generic.txt | 48 ++ 1 file changed, 48 insertions(+) create

[PATCH v3 6/6] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property

The current dts describes USB HUB's property at USB controller's entry, it is improper. The USB HUB should be the child node under USB controller, and power sequence properties are under it. Signed-off-by: Peter Chen <peter.c...@nxp.com> --- arch/arm/boot/dts/imx6qdl-udoo.dts

[PATCH v3 1/6] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

Add binding doc for generic power sequence library. Signed-off-by: Peter Chen Acked-by: Philipp Zabel --- .../bindings/power/pwrseq/pwrseq-generic.txt | 48 ++ 1 file changed, 48 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/pwrseq/pwrseq

[PATCH v3 6/6] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property

The current dts describes USB HUB's property at USB controller's entry, it is improper. The USB HUB should be the child node under USB controller, and power sequence properties are under it. Signed-off-by: Peter Chen --- arch/arm/boot/dts/imx6qdl-udoo.dtsi | 26 +- 1

[PATCH v3 5/6] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node

From: Peter Chen <peter.c...@freescale.com> At device tree, we have no device node for chipidea core, the glue layer's node is the parent node for host and udc device. But in related driver, the parent device is chipidea core. So, in order to let the common driver get parent's node,

[PATCH v3 4/6] usb: core: add power sequence handling for USB devices

). At hub_disconnect, it will do power off sequence which is at powered on list. Signed-off-by: Peter Chen <peter.c...@nxp.com> --- drivers/usb/core/Makefile | 1 + drivers/usb/core/hub.c| 12 -- drivers/usb/core/hub.h| 12 ++ drivers/usb/core/pwrseq.c

[PATCH v3 3/6] binding-doc: usb: usb-device: add optional properties for power sequence

Add optional properties for power sequence. Signed-off-by: Peter Chen <peter.c...@nxp.com> --- Documentation/devicetree/bindings/usb/usb-device.txt | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/usb/usb-device.txt b/Documen

[PATCH v3 5/6] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node

From: Peter Chen At device tree, we have no device node for chipidea core, the glue layer's node is the parent node for host and udc device. But in related driver, the parent device is chipidea core. So, in order to let the common driver get parent's node, we let the core's device node equals

[PATCH v3 4/6] usb: core: add power sequence handling for USB devices

). At hub_disconnect, it will do power off sequence which is at powered on list. Signed-off-by: Peter Chen --- drivers/usb/core/Makefile | 1 + drivers/usb/core/hub.c| 12 -- drivers/usb/core/hub.h| 12 ++ drivers/usb/core/pwrseq.c | 100

[PATCH v3 3/6] binding-doc: usb: usb-device: add optional properties for power sequence

Add optional properties for power sequence. Signed-off-by: Peter Chen --- Documentation/devicetree/bindings/usb/usb-device.txt | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/usb/usb-device.txt b/Documentation/devicetree/bindings

[PATCH v3 0/6] power: add power sequence library

erties at dt binding - Should use structure not but its pointer for kzalloc - Since chipidea core has no of_node, let core's of_node equals glue layer's at core's probe Peter Chen (6): binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library power: add power sequen

[PATCH v3 0/6] power: add power sequence library

erties at dt binding - Should use structure not but its pointer for kzalloc - Since chipidea core has no of_node, let core's of_node equals glue layer's at core's probe Peter Chen (6): binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library power: add power sequen

[PATCH v3 2/6] power: add power sequence library

and clocks currently, and can cover regulator and pinctrl in future. The host driver calls pwrseq_alloc_generic to create an generic pwrseq instance. Signed-off-by: Peter Chen <peter.c...@nxp.com> --- MAINTAINERS | 9 ++ drivers/power/Kconfig

[PATCH v3 2/6] power: add power sequence library

and clocks currently, and can cover regulator and pinctrl in future. The host driver calls pwrseq_alloc_generic to create an generic pwrseq instance. Signed-off-by: Peter Chen --- MAINTAINERS | 9 ++ drivers/power/Kconfig | 1 + drivers/power/Makefile

Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

On Mon, Jul 18, 2016 at 07:57:34AM +0200, Rafał Miłecki wrote: > On 18 July 2016 at 07:40, Peter Chen <hzpeterc...@gmail.com> wrote: > > On Mon, Jul 18, 2016 at 06:44:49AM +0200, Rafał Miłecki wrote: > >> On 18 July 2016 at 04:31, Peter Chen <hzpeterc...@gmail.com>

Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

On Mon, Jul 18, 2016 at 07:57:34AM +0200, Rafał Miłecki wrote: > On 18 July 2016 at 07:40, Peter Chen wrote: > > On Mon, Jul 18, 2016 at 06:44:49AM +0200, Rafał Miłecki wrote: > >> On 18 July 2016 at 04:31, Peter Chen wrote: > >> > On Fri, Jul 15, 2016 at 11:10:4

Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

On Mon, Jul 18, 2016 at 06:44:49AM +0200, Rafał Miłecki wrote: > On 18 July 2016 at 04:31, Peter Chen <hzpeterc...@gmail.com> wrote: > > On Fri, Jul 15, 2016 at 11:10:45PM +0200, Rafał Miłecki wrote: > >> + > >> +usbport trigger: > >> +- usb-ports : List

Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

On Mon, Jul 18, 2016 at 06:44:49AM +0200, Rafał Miłecki wrote: > On 18 July 2016 at 04:31, Peter Chen wrote: > > On Fri, Jul 15, 2016 at 11:10:45PM +0200, Rafał Miłecki wrote: > >> + > >> +usbport trigger: > >> +- usb-ports : List of USB ports that

Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

+ * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or (at > + * your option) any later version. > + */ GPL v2 only. > +MODULE_AUTHOR("Rafał Miłecki <rafal.mile...@gmail.com>"); > +MODULE_DESCRIPTION("USB port trigger"); > +MODULE_LICENSE("GPL"); GPL v2 After you fix above, feel free to add: Reviewed-by: Peter Chen <peter.c...@nxp.com> -- Best Regards, Peter Chen

Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or (at > + * your option) any later version. > + */ GPL v2 only. > +MODULE_AUTHOR("Rafał Miłecki "); > +MODULE_DESCRIPTION("USB port trigger"); > +MODULE_LICENSE("GPL"); GPL v2 After you fix above, feel free to add: Reviewed-by: Peter Chen -- Best Regards, Peter Chen

[PATCH v2 1/1] memory: emif: add missing of_node_put after calling of_parse_phandle

of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen <peter.c...@nxp.com> --- Changes for v2: - %s/of_put_node/of_node_put drivers/memory/emif.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/

[PATCH v2 1/1] memory: emif: add missing of_node_put after calling of_parse_phandle

of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- Changes for v2: - %s/of_put_node/of_node_put drivers/memory/emif.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/memory/emif.c b/drivers

[PATCH 1/1] memory: emif: add missing of_node_put after calling of_parse_phandle

of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen <peter.c...@nxp.com> --- drivers/memory/emif.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c index 0

[PATCH 1/1] memory: emif: add missing of_node_put after calling of_parse_phandle

of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/memory/emif.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c index 04644e7..c5ec77d 100644

[PATCH 1/1] mfd: qcom_rpm: add missing of_node_put after calling of_parse_phandle

of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Cc: Bjorn Andersson <bjorn.anders...@sonymobile.com> Cc: Lee Jones <lee.jo...@linaro.org> Signed-off-by: Peter Chen <peter.c...@nxp.com> --- drivers/mfd/qcom_rpm.c | 1 +

[PATCH 1/1] mfd: qcom_rpm: add missing of_node_put after calling of_parse_phandle

of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Cc: Bjorn Andersson Cc: Lee Jones Signed-off-by: Peter Chen --- drivers/mfd/qcom_rpm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c

Re: [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0 controller

On Tue, Jul 12, 2016 at 03:59:14AM +, Rajesh Bhagat wrote: > > > > -Original Message- > > From: Peter Chen [mailto:hzpeterc...@gmail.com] > > Sent: Monday, July 11, 2016 12:19 PM > > To: Rajesh Bhagat <rajesh.bha...@nxp.com> > > C

Re: [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0 controller

On Tue, Jul 12, 2016 at 03:59:14AM +, Rajesh Bhagat wrote: > > > > -Original Message- > > From: Peter Chen [mailto:hzpeterc...@gmail.com] > > Sent: Monday, July 11, 2016 12:19 PM > > To: Rajesh Bhagat > > Cc: linux-...@vger.kernel.org; linux

Re: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver

> > We do have multiple clocks, but currently one is integrated in code. Hence > created > the APIs for future use. If you could not integrate one more clocks, I suggest not creating dedicated API until you need in future. -- Best Regards, Peter Chen

Re: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver

> > We do have multiple clocks, but currently one is integrated in code. Hence > created > the APIs for future use. If you could not integrate one more clocks, I suggest not creating dedicated API until you need in future. -- Best Regards, Peter Chen

RE: [lkp] [usb] 9696ef14de: WARNING: CPU: 0 PID: 1 at lib/list_debug.c:36 __list_add+0x104/0x188

>-Original Message- >From: lkp-requ...@eclists.intel.com [mailto:lkp-requ...@eclists.intel.com] On >Behalf >Of kernel test robot >Sent: Wednesday, July 13, 2016 9:28 AM >To: Peter Chen <peter.c...@nxp.com> >Cc: 0day robot <fengguang...@intel.com>; L

RE: [lkp] [usb] 9696ef14de: WARNING: CPU: 0 PID: 1 at lib/list_debug.c:36 __list_add+0x104/0x188

>-Original Message- >From: lkp-requ...@eclists.intel.com [mailto:lkp-requ...@eclists.intel.com] On >Behalf >Of kernel test robot >Sent: Wednesday, July 13, 2016 9:28 AM >To: Peter Chen >Cc: 0day robot ; LKML ; >l...@01.org >Subject: [lkp] [usb] 9696ef1

Re: [PATCH v2 18/22] usb: chipidea: msm: Add reset controller for PHY POR bit

On Mon, Jul 11, 2016 at 03:07:24PM -0700, Stephen Boyd wrote: > On 10 July 2016 at 22:32, Peter Chen <hzpeterc...@gmail.com> wrote: > > On Thu, Jul 07, 2016 at 03:21:09PM -0700, Stephen Boyd wrote: > >> @@ -40,11 +43,38 @@ struct ci_hdrc_msm { > >> struct

<    5   6   7   8   9   10   11   12   13   14   >