s quality.
I reviewed all 6 patches.
Reviewed-by: Peter Feuerer
Please also add CC: Boris Petkov for review.
[...]
--
kind regards,
--peter;
s quality.
I reviewed all 6 patches.
Reviewed-by: Peter Feuerer
Please also add CC: Boris Petkov for review.
[...]
--
kind regards,
--peter;
equal to the old one (which, however, wasn't notified to the cooling device)
> and
> will therefore skip the update.
>
> CC: Zhang Rui <rui.zh...@intel.com>
> CC: Eduardo Valentin <edubez...@gmail.com>
> CC: Peter Feuerer <pe...@piie.net>
Acked-by: Peter Feuere
t; This may lead to a situation where a thermal governor never updates the
> cooling
> device. For example, this is the case for the step_wise governor: when calling
> the function thermal_zone_trip_update(), the governor may always get a new
> state
> equal to the old one (which, ho
ccess permission have had the
> corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <chuansheng@intel.com>
> Signed-off-by: Baole Ni &
t; corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu
> Signed-off-by: Baole Ni
Acked-by: Peter Feuerer
> ---
> drivers/platform/x86
>
>> Cc: Darren Hart <dvh...@infradead.org>
>> Cc: Zhang Rui <rui.zh...@intel.com>
>> Cc: Keerthy <j-keer...@ti.com>
>> Cc: linux-kernel@vger.kernel.org
>> Cc: linux-o...@vger.kernel.org
>> Cc: platform-driver-...@vger.kernel.org
>> Cc:
x-kernel@vger.kernel.org
>> Cc: linux-o...@vger.kernel.org
>> Cc: platform-driver-...@vger.kernel.org
>> Cc: linux...@vger.kernel.org
>> Signed-off-by: Eduardo Valentin
>
> +Peter Feuerer
>
> Peter, any concerns regarding the acerhdf driver?
Yes, please see below
Hi,
24. Mai 2016 15:06 Uhr, "Javi Merino" <javi.mer...@arm.com> schrieb:
> Ccing Peter Feuerer, author of the bang bang governor.
>
> On Tue, May 03, 2016 at 05:33:32PM +0800, Caesar Wang wrote:
>
>> From: Sascha Hauer <s.ha...@pengutronix.de>
>>
Hi,
24. Mai 2016 15:06 Uhr, "Javi Merino" schrieb:
> Ccing Peter Feuerer, author of the bang bang governor.
>
> On Tue, May 03, 2016 at 05:33:32PM +0800, Caesar Wang wrote:
>
>> From: Sascha Hauer
>>
>> With interrupt driven thermal zones we pass the
Hi,
24. Mai 2016 15:06 Uhr, "Javi Merino" <javi.mer...@arm.com> schrieb:
> Ccing Peter Feuerer, author of the bang bang governor.
thanks, will take care today in the evening.
--peter;
>
> On Tue, May 03, 2016 at 05:33:32PM +0800, Caesar Wang wrote:
>
Hi,
24. Mai 2016 15:06 Uhr, "Javi Merino" schrieb:
> Ccing Peter Feuerer, author of the bang bang governor.
thanks, will take care today in the evening.
--peter;
>
> On Tue, May 03, 2016 at 05:33:32PM +0800, Caesar Wang wrote:
>
>> From: Sascha Hauer
>>
t;
> CC: Zhang Rui <rui.zh...@intel.com>
> CC: Eduardo Valentin <edubez...@gmail.com>
> CC: Peter Feuerer <pe...@piie.net>
> Signed-off-by: Michele Di Giorgio <michele.digior...@arm.com>
Acked-by: Peter Feuerer <pe...@piie.net>
Thanks.
--
kind regards
need to check whether the
> function pointer is valid or not.
>
> If it is not available, we assume the hysteresis to be zero. Consequently, a
> highly varying temperature will make the governor continuosly switch a cooling
> device ON and OFF.
>
> CC: Zhang Rui
> CC: E
@vger.kernel.org
Cc: Jean Delvare
Cc: Peter Feuerer
Cc: Heiko Stuebner
Cc: Lukasz Majewski
Cc: Stephen Warren
Cc: Thierry Reding
Cc: linux-a...@vger.kernel.org
Cc: platform-driver-...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-o...@vger.kernel.org
Cc: linux-samsung
...@gmail.com
Cc: linux...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Jean Delvare jdelv...@suse.de
Cc: Peter Feuerer pe...@piie.net
Cc: Heiko Stuebner he...@sntech.de
Cc: Lukasz Majewski l.majew...@samsung.com
Cc: Stephen Warren swar...@wwwdotorg.org
Cc: Thierry Reding thierry.red
'
drivers/built-in.o: In function `acerhdf_unregister_thermal':
acerhdf.c:(.text.unlikely+0x3c67): undefined reference to
`thermal_cooling_device_unregister'
acerhdf.c:(.text.unlikely+0x3c91): undefined reference to
`thermal_zone_device_unregister'
Signed-off-by: Randy Dunlap
Cc: Peter Feuerer
Cc
...@infradead.org
Cc: Peter Feuerer pe...@piie.net
Cc: Darren Hart dvh...@infradead.org
---
drivers/platform/x86/Kconfig |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20141215.orig/drivers/platform/x86/Kconfig
+++ linux-next-20141215/drivers/platform/x86/Kconfig
@@ -38,8
Hi Darren,
I know you are busy and I don't want to stress you, but have you had time to
look to this? I'd be really happy to solve all issues in time and have
those patches finally applied.
kind regards,
--peter;
Peter Feuerer writes:
Hi again,
Peter Feuerer writes:
Hi Darren,
thank
Hi Darren,
I know you are busy and I don't want to stress you, but have you had time to
look to this? I'd be really happy to solve all issues in time and have
those patches finally applied.
kind regards,
--peter;
Peter Feuerer writes:
Hi again,
Peter Feuerer writes:
Hi Darren,
thank
Hi again,
Peter Feuerer writes:
Hi Darren,
thank you very much for your reply.
Darren Hart writes:
On Fri, Nov 28, 2014 at 03:20:50PM +0100, Peter Feuerer wrote:
acerhdf has been doing an on-off fan control using hysteresis by
post-manipulating the outcome of thermal subsystem trip point
Hi Darren,
thank you very much for your reply.
Darren Hart writes:
On Fri, Nov 28, 2014 at 03:20:50PM +0100, Peter Feuerer wrote:
acerhdf has been doing an on-off fan control using hysteresis by
post-manipulating the outcome of thermal subsystem trip point handling.
This patch enables
Hi Darren / platform-driver-x86 list,
Peter Feuerer writes:
please apply this series of patches.
did you find time for my patchseries already?
Is there any problem with it?
--
kind regards,
--peter;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" i
Hi Darren / platform-driver-x86 list,
Peter Feuerer writes:
please apply this series of patches.
did you find time for my patchseries already?
Is there any problem with it?
--
kind regards,
--peter;
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
Hi Darren,
thank you very much for your reply.
Darren Hart writes:
On Fri, Nov 28, 2014 at 03:20:50PM +0100, Peter Feuerer wrote:
acerhdf has been doing an on-off fan control using hysteresis by
post-manipulating the outcome of thermal subsystem trip point handling.
This patch enables
Hi again,
Peter Feuerer writes:
Hi Darren,
thank you very much for your reply.
Darren Hart writes:
On Fri, Nov 28, 2014 at 03:20:50PM +0100, Peter Feuerer wrote:
acerhdf has been doing an on-off fan control using hysteresis by
post-manipulating the outcome of thermal subsystem trip point
Morton
Cc: Andreas Mohr
Acked-by: Borislav Petkov
Signed-off-by: Peter Feuerer
---
drivers/platform/x86/acerhdf.c | 186 ++---
1 file changed, 102 insertions(+), 84 deletions(-)
diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
ind
added critical trip point which represents the temperature limit.
Added return -EINVAL in case wrong trip point is provided.
Cc: platform-driver-...@vger.kernel.org
Cc: Darren Hart
Cc: Andrew Morton
Cc: Andreas Mohr
Cc: Borislav Petkov
Cc: Javi Merino
Signed-off-by: Peter Feuerer
- adding second trip point for critical temperature (Patch 4)
- removing _t suffix from struct which isn't typedef and replace unsigned
char by u8 (Patch 5)
Thanks and kind regards,
peter
Peter Feuerer (5):
acerhdf: Adding support for "manual mode"
acerhdf: Addin
Cc: Andrew Morton
CC: Zhang Rui
Cc: Andreas Mohr
Cc: Javi Merino
Acked-and-tested-by: Borislav Petkov
Signed-off-by: Peter Feuerer
---
drivers/platform/x86/Kconfig | 3 ++-
drivers/platform/x86/acerhdf.c | 36 +++-
2 files changed, 33 insertions(+), 6
-by: Peter Feuerer
---
drivers/platform/x86/acerhdf.c | 25 -
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
index 2c58f10..f30767f 100644
--- a/drivers/platform/x86/acerhdf.c
+++ b/drivers
* renamed bios_settings_t to bios_settings, as it is no typedef
* replaced "unsigned char" by u8 in bios_settings struct for better
readability.
Cc: platform-driver-...@vger.kernel.org
Cc: Darren Hart
Cc: Andrew Morton
Cc: Andreas Mohr
Acked-by: Borislav Petkov
Signed-off
a...@lisas.de
Acked-by: Borislav Petkov b...@suse.de
Signed-off-by: Peter Feuerer pe...@piie.net
---
drivers/platform/x86/acerhdf.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
index 91b16c8..c07623c 100644
: Andreas Mohr a...@lisas.de
Acked-by: Borislav Petkov b...@suse.de
Signed-off-by: Peter Feuerer pe...@piie.net
---
drivers/platform/x86/acerhdf.c | 25 -
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
dvh...@infradead.org
Cc: Andrew Morton a...@linux-foundation.org
CC: Zhang Rui rui.zh...@intel.com
Cc: Andreas Mohr a...@lisas.de
Cc: Javi Merino javi.mer...@arm.com
Acked-and-tested-by: Borislav Petkov b...@suse.de
Signed-off-by: Peter Feuerer pe...@piie.net
---
drivers/platform/x86/Kconfig | 3
trip point for critical temperature (Patch 4)
- removing _t suffix from struct which isn't typedef and replace unsigned
char by u8 (Patch 5)
Thanks and kind regards,
peter
Peter Feuerer (5):
acerhdf: Adding support for manual mode
acerhdf: Adding support for new models
acerhdf
b...@suse.de
Cc: Javi Merino javi.mer...@arm.com
Signed-off-by: Peter Feuerer pe...@piie.net
---
drivers/platform/x86/acerhdf.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
index 7fe7dbf..91b16c8 100644
: Andrew Morton a...@linux-foundation.org
Cc: Andreas Mohr a...@lisas.de
Acked-by: Borislav Petkov b...@suse.de
Signed-off-by: Peter Feuerer pe...@piie.net
---
drivers/platform/x86/acerhdf.c | 186 ++---
1 file changed, 102 insertions(+), 84 deletions(-)
diff --git
Hi Javi,
Javi Merino writes:
On Tue, Oct 28, 2014 at 07:33:39PM +, Peter Feuerer wrote:
Hi Rui,
I wonder whether you've had time to apply my set of patches already? Would
you please be so kind to just send me a short reply?
The bang-bang governor was merged and is part of v3.18-rc2
Hi Javi,
Javi Merino writes:
On Tue, Oct 28, 2014 at 07:33:39PM +, Peter Feuerer wrote:
Hi Rui,
I wonder whether you've had time to apply my set of patches already? Would
you please be so kind to just send me a short reply?
The bang-bang governor was merged and is part of v3.18-rc2
Hi Rui,
I wonder whether you've had time to apply my set of patches already? Would
you please be so kind to just send me a short reply?
thanks and kind regards,
--peter;
Peter Feuerer writes:
Hi Rui,
Zhang Rui writes:
On Sat, 2014-07-26 at 16:14 +0200, Peter Feuerer wrote:
Hi Rui
Hi Rui,
I wonder whether you've had time to apply my set of patches already? Would
you please be so kind to just send me a short reply?
thanks and kind regards,
--peter;
Peter Feuerer writes:
Hi Rui,
Zhang Rui writes:
On Sat, 2014-07-26 at 16:14 +0200, Peter Feuerer wrote:
Hi Rui
Hi Rui,
Zhang Rui writes:
On Sat, 2014-07-26 at 16:14 +0200, Peter Feuerer wrote:
Hi Rui,
Peter Feuerer writes:
> The bang-bang thermal governor uses a hysteresis to switch abruptly on
> or off a cooling device. It is intended to control fans, which can
> not be throttled but just
Hi Rui,
Zhang Rui writes:
On Sat, 2014-07-26 at 16:14 +0200, Peter Feuerer wrote:
Hi Rui,
Peter Feuerer writes:
The bang-bang thermal governor uses a hysteresis to switch abruptly on
or off a cooling device. It is intended to control fans, which can
not be throttled but just switched
Zhang Rui writes:
On Tue, 2014-07-22 at 17:37 +0200, Peter Feuerer wrote:
acerhdf has been doing an on-off fan control using hysteresis by
post-manipulating the outcome of thermal subsystem trip point handling.
This patch enables acerhdf to use the bang-bang governor, which is
intended
Zhang Rui writes:
On Tue, 2014-07-22 at 17:37 +0200, Peter Feuerer wrote:
acerhdf has been doing an on-off fan control using hysteresis by
post-manipulating the outcome of thermal subsystem trip point handling.
This patch enables acerhdf to use the bang-bang governor, which is
intended
Hi Boris,
Peter Feuerer writes:
added critical trip point which represents the temperature limit.
Added return -EINVAL in case wrong trip point is provided.
Cc: Andrew Morton
Cc: Andreas Mohr
Cc: Borislav Petkov
Any concerns regarding this patch?
--
--peter;
--
To unsubscribe from
Hi Rui,
Peter Feuerer writes:
The bang-bang thermal governor uses a hysteresis to switch abruptly on
or off a cooling device. It is intended to control fans, which can
not be throttled but just switched on or off.
Bang-bang cannot be set as default governor as it is intended for
special
Hi Rui,
Peter Feuerer writes:
The bang-bang thermal governor uses a hysteresis to switch abruptly on
or off a cooling device. It is intended to control fans, which can
not be throttled but just switched on or off.
Bang-bang cannot be set as default governor as it is intended for
special
Hi Boris,
Peter Feuerer writes:
added critical trip point which represents the temperature limit.
Added return -EINVAL in case wrong trip point is provided.
Cc: Andrew Morton a...@linux-foundation.org
Cc: Andreas Mohr a...@lisas.de
Cc: Borislav Petkov b...@suse.de
Any concerns regarding
* renamed bios_settings_t to bios_settings, as it is no typedef
* replaced "unsigned char" by u8 in bios_settings struct for better
readability.
Cc: Andrew Morton
Cc: Andreas Mohr
Acked-by: Borislav Petkov
Signed-off-by: Peter Feuerer
---
drivers/platform/x86/acer
devices the driver needs to
explicitely request it.
Cc: Andrew Morton
Cc: Zhang Rui
Cc: Andreas Mohr
Cc: Borislav Petkov
Cc: Javi Merino
Cc: linux...@vger.kernel.org
Signed-off-by: Peter Feuerer
---
drivers/thermal/Kconfig | 10 +++
drivers/thermal/Makefile| 1 +
drivers/thermal
added following new models:
* Aspire 5755G
* AO521
* AO751h
* Aspire One 753
* Extensa 5420
* Aspire 5315
* Aspire 5739G
* TravelMate TM8573T
Cc: Andrew Morton
Cc: Andreas Mohr
Acked-by: Borislav Petkov
Signed-off-by: Peter Feuerer
---
drivers/platform/x86/acerhdf.c
added critical trip point which represents the temperature limit.
Added return -EINVAL in case wrong trip point is provided.
Cc: Andrew Morton
Cc: Andreas Mohr
Cc: Borislav Petkov
Cc: Javi Merino
Signed-off-by: Peter Feuerer
---
drivers/platform/x86/acerhdf.c | 10 +-
1 file changed
: Javi Merino
Acked-and-tested-by: Borislav Petkov
Signed-off-by: Peter Feuerer
---
drivers/platform/x86/Kconfig | 3 ++-
drivers/platform/x86/acerhdf.c | 36 +++-
2 files changed, 33 insertions(+), 6 deletions(-)
diff --git a/drivers/platform/x86/Kconfig b
point for critical temperature (Patch 5)
- removing _t suffix from struct which isn't typedef and replace unsigned
char by u8 (Patch 6)
Thanks and kind regards,
peter
Peter Feuerer (6):
acerhdf: Adding support for "manual mode"
acerhdf: Adding support for new model
Signed-off-by: Peter Feuerer
---
drivers/platform/x86/acerhdf.c | 186 ++---
1 file changed, 102 insertions(+), 84 deletions(-)
diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
index f94467c..2c58f10 100644
--- a/drivers/platform/x86/acerh
Hi,
Zhang Rui writes:
On Mon, 2014-07-21 at 11:29 +0200, Borislav Petkov wrote:
On Sun, Jul 20, 2014 at 02:51:17AM +0200, Peter Feuerer wrote:
> The bang-bang thermal governor uses a hysteresis to switch abruptly on
> or off a cooling device. It is intended to control fans, whi
Hi,
Zhang Rui writes:
On Mon, 2014-07-21 at 11:29 +0200, Borislav Petkov wrote:
On Sun, Jul 20, 2014 at 02:51:17AM +0200, Peter Feuerer wrote:
The bang-bang thermal governor uses a hysteresis to switch abruptly on
or off a cooling device. It is intended to control fans, which can
-by: Borislav Petkov b...@suse.de
Signed-off-by: Peter Feuerer pe...@piie.net
---
drivers/platform/x86/acerhdf.c | 186 ++---
1 file changed, 102 insertions(+), 84 deletions(-)
diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
index f94467c
temperature (Patch 5)
- removing _t suffix from struct which isn't typedef and replace unsigned
char by u8 (Patch 6)
Thanks and kind regards,
peter
Peter Feuerer (6):
acerhdf: Adding support for manual mode
acerhdf: Adding support for new models
thermal: Added Bang-bang thermal
Rui rui.zh...@intel.com
Cc: Andreas Mohr a...@lisas.de
Cc: Javi Merino javi.mer...@arm.com
Acked-and-tested-by: Borislav Petkov b...@suse.de
Signed-off-by: Peter Feuerer pe...@piie.net
---
drivers/platform/x86/Kconfig | 3 ++-
drivers/platform/x86/acerhdf.c | 36
added critical trip point which represents the temperature limit.
Added return -EINVAL in case wrong trip point is provided.
Cc: Andrew Morton a...@linux-foundation.org
Cc: Andreas Mohr a...@lisas.de
Cc: Borislav Petkov b...@suse.de
Cc: Javi Merino javi.mer...@arm.com
Signed-off-by: Peter Feuerer
-by: Peter Feuerer pe...@piie.net
---
drivers/platform/x86/acerhdf.c | 25 -
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
index 2c58f10..f30767f 100644
--- a/drivers/platform/x86/acerhdf.c
+++ b
* renamed bios_settings_t to bios_settings, as it is no typedef
* replaced unsigned char by u8 in bios_settings struct for better
readability.
Cc: Andrew Morton a...@linux-foundation.org
Cc: Andreas Mohr a...@lisas.de
Acked-by: Borislav Petkov b...@suse.de
Signed-off-by: Peter Feuerer pe
devices the driver needs to
explicitely request it.
Cc: Andrew Morton a...@linux-foundation.org
Cc: Zhang Rui rui.zh...@intel.com
Cc: Andreas Mohr a...@lisas.de
Cc: Borislav Petkov b...@suse.de
Cc: Javi Merino javi.mer...@arm.com
Cc: linux...@vger.kernel.org
Signed-off-by: Peter Feuerer pe...@piie.net
Hi Andreas,
Andreas Mohr writes:
Hi
On Sun, Jul 20, 2014 at 02:51:15AM +0200, Peter Feuerer wrote:
@@ -127,105 +138,107 @@ struct bios_settings_t {
unsigned char fanreg;
unsigned char tempreg;
struct fancmd cmd;
+ int mcmd_enable;
};
+
/* Register addresses
Hi Andreas,
Andreas Mohr writes:
Hi
On Sun, Jul 20, 2014 at 02:51:15AM +0200, Peter Feuerer wrote:
@@ -127,105 +138,107 @@ struct bios_settings_t {
unsigned char fanreg;
unsigned char tempreg;
struct fancmd cmd;
+ int mcmd_enable;
};
+
/* Register addresses
devices the driver needs to
explicitely request it.
Cc: Andrew Morton
Cc: Zhang Rui
Cc: Andreas Mohr
Cc: Borislav Petkov
Cc: Javi Merino
Signed-off-by: Peter Feuerer
---
drivers/thermal/Kconfig | 10 +++
drivers/thermal/Makefile| 1 +
drivers/thermal/gov_bang_bang.c | 131
added critical trip point which represents the temperature limit.
Added return -EINVAL in case wrong trip point is provided.
Cc: Andrew Morton
Cc: Andreas Mohr
Cc: Borislav Petkov
Cc: Javi Merino
Signed-off-by: Peter Feuerer
---
drivers/platform/x86/acerhdf.c | 10 +-
1 file changed
point for critical temperature (Patch 5)
- removing _t suffix from struct which isn't typedef and replace unsigned
char by u8 (Patch 6)
Thanks and kind regards,
peter
Peter Feuerer (6):
acerhdf: Adding support for "manual mode"
acerhdf: Adding support for new model
* renamed bios_settings_t to bios_settings, as it is no typedef
* replaced "unsigned char" by u8 in bios_settings struct for better
readability.
Cc: Andrew Morton
Cc: Andreas Mohr
Acked-by: Borislav Petkov
Signed-off-by: Peter Feuerer
---
drivers/platform/x86/acer
: Borislav Petkov
Cc: Javi Merino
Signed-off-by: Peter Feuerer
---
drivers/platform/x86/Kconfig | 2 +-
drivers/platform/x86/acerhdf.c | 36 +++-
2 files changed, 32 insertions(+), 6 deletions(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86
Signed-off-by: Peter Feuerer
---
drivers/platform/x86/acerhdf.c | 187 +++--
1 file changed, 103 insertions(+), 84 deletions(-)
diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
index f94467c..dd63e93 100644
--- a/drivers/platform/x86/acerh
added following new models:
* Aspire 5755G
* AO521
* AO751h
* Aspire One 753
* Extensa 5420
* Aspire 5315
* Aspire 5739G
* TravelMate TM8573T
Cc: Andrew Morton
Cc: Andreas Mohr
Acked-by: Borislav Petkov
Signed-off-by: Peter Feuerer
---
drivers/platform/x86/acerhdf.c
Rui rui.zh...@intel.com
Cc: Andreas Mohr a...@lisas.de
Cc: Borislav Petkov b...@suse.de
Cc: Javi Merino javi.mer...@arm.com
Signed-off-by: Peter Feuerer pe...@piie.net
---
drivers/platform/x86/Kconfig | 2 +-
drivers/platform/x86/acerhdf.c | 36 +++-
2 files changed
-by: Borislav Petkov b...@suse.de
Signed-off-by: Peter Feuerer pe...@piie.net
---
drivers/platform/x86/acerhdf.c | 187 +++--
1 file changed, 103 insertions(+), 84 deletions(-)
diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
index f94467c
* renamed bios_settings_t to bios_settings, as it is no typedef
* replaced unsigned char by u8 in bios_settings struct for better
readability.
Cc: Andrew Morton a...@linux-foundation.org
Cc: Andreas Mohr a...@lisas.de
Acked-by: Borislav Petkov b...@suse.de
Signed-off-by: Peter Feuerer pe
-by: Peter Feuerer pe...@piie.net
---
drivers/platform/x86/acerhdf.c | 25 -
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
index dd63e93..176edbd 100644
--- a/drivers/platform/x86/acerhdf.c
+++ b
added critical trip point which represents the temperature limit.
Added return -EINVAL in case wrong trip point is provided.
Cc: Andrew Morton a...@linux-foundation.org
Cc: Andreas Mohr a...@lisas.de
Cc: Borislav Petkov b...@suse.de
Cc: Javi Merino javi.mer...@arm.com
Signed-off-by: Peter Feuerer
temperature (Patch 5)
- removing _t suffix from struct which isn't typedef and replace unsigned
char by u8 (Patch 6)
Thanks and kind regards,
peter
Peter Feuerer (6):
acerhdf: Adding support for manual mode
acerhdf: Adding support for new models
thermal: Added Bang-bang thermal
devices the driver needs to
explicitely request it.
Cc: Andrew Morton a...@linux-foundation.org
Cc: Zhang Rui rui.zh...@intel.com
Cc: Andreas Mohr a...@lisas.de
Cc: Borislav Petkov b...@suse.de
Cc: Javi Merino javi.mer...@arm.com
Signed-off-by: Peter Feuerer pe...@piie.net
---
drivers/thermal/Kconfig
Borislav Petkov writes:
The major 0 is just from the ages, when all cool projects used to have a 0
in front.
Maybe it would be a good idea to go for 1.0 when I implemented a better
handling for the huge bios table.
Probably. You could at least increment it to 0.6 when you switch to the
Borislav Petkov writes:
On Sat, May 03, 2014 at 07:59:23PM +0200, Peter Feuerer wrote:
The bang-bang thermal governor uses a hysteresis to switch abruptly on
or off a cooling device. It is intended to control fans, which can
not be throttled but just switched on or off.
Bang-bang cannot
Borislav Petkov writes:
On Sat, May 03, 2014 at 07:59:22PM +0200, Peter Feuerer wrote:
added following new models:
* Aspire 5755G
* AO521
* AO751h
* Aspire One 753
* Extensa 5420
* Aspire 5315
* Aspire 5739G
* TravelMate TM8573T
Cc: Andrew Morton
Cc: Andreas Mohr
Cc
Borislav Petkov writes:
On Sat, May 03, 2014 at 07:59:22PM +0200, Peter Feuerer wrote:
added following new models:
* Aspire 5755G
* AO521
* AO751h
* Aspire One 753
* Extensa 5420
* Aspire 5315
* Aspire 5739G
* TravelMate TM8573T
Cc: Andrew Morton a...@linux
Borislav Petkov writes:
On Sat, May 03, 2014 at 07:59:23PM +0200, Peter Feuerer wrote:
The bang-bang thermal governor uses a hysteresis to switch abruptly on
or off a cooling device. It is intended to control fans, which can
not be throttled but just switched on or off.
Bang-bang cannot
Borislav Petkov writes:
The major 0 is just from the ages, when all cool projects used to have a 0
in front.
Maybe it would be a good idea to go for 1.0 when I implemented a better
handling for the huge bios table.
Probably. You could at least increment it to 0.6 when you switch to the
Hi Boris,
nice to hear from you.
Borislav Petkov writes:
Hi Peter,
On Sat, May 03, 2014 at 07:59:20PM +0200, Peter Feuerer wrote:
This patch series is intended to:
* Introduce "manual mode" support (Patch 1 & 2), which is needed to control
the fan of a few new mo
Hi Boris,
nice to hear from you.
Borislav Petkov writes:
Hi Peter,
On Sat, May 03, 2014 at 07:59:20PM +0200, Peter Feuerer wrote:
This patch series is intended to:
* Introduce manual mode support (Patch 1 2), which is needed to control
the fan of a few new models.
* Add
Hi Eduardo,
Eduardo Valentin writes:
Hello Peter,
On Sat, May 03, 2014 at 07:59:20PM +0200, Peter Feuerer wrote:
Hi,
This patch series is intended to:
* Introduce "manual mode" support (Patch 1 & 2), which is needed to control
the fan of a few new models.
* Add
Hi Eduardo,
Eduardo Valentin writes:
Hello Peter,
On Sat, May 03, 2014 at 07:59:20PM +0200, Peter Feuerer wrote:
Hi,
This patch series is intended to:
* Introduce manual mode support (Patch 1 2), which is needed to control
the fan of a few new models.
* Add an appropriate
Hi Javi,
Javi Merino writes:
Hi Peter,
On Sat, May 03, 2014 at 06:59:24PM +0100, Peter Feuerer wrote:
acerhdf has been doing an on-off fan control using hysteresis by
post-manipulating the outcome of thermal subsystem trip point handling.
This patch enables acerhdf to use the bang-bang
Hi Javi,
Javi Merino writes:
Hi Peter,
On Sat, May 03, 2014 at 06:59:24PM +0100, Peter Feuerer wrote:
acerhdf has been doing an on-off fan control using hysteresis by
post-manipulating the outcome of thermal subsystem trip point handling.
This patch enables acerhdf to use the bang-bang
added critical trip point which represents the temperature limit.
Cc: Andrew Morton
Cc: Andreas Mohr
Cc: Borislav Petkov
Cc: Javi Merino
Signed-off-by: Peter Feuerer
---
drivers/platform/x86/acerhdf.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/platform
devices the driver needs to
explicitely request it.
Cc: Andrew Morton
Cc: Zhang Rui
Cc: Andreas Mohr
Cc: Borislav Petkov
Cc: Javi Merino
Signed-off-by: Peter Feuerer
---
drivers/thermal/Kconfig | 10 +++
drivers/thermal/Makefile| 1 +
drivers/thermal/gov_bang_bang.c | 131
: Borislav Petkov
Cc: Javi Merino
Signed-off-by: Peter Feuerer
---
drivers/platform/x86/Kconfig | 2 +-
drivers/platform/x86/acerhdf.c | 34 +-
2 files changed, 30 insertions(+), 6 deletions(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86
point for critical temperature (Patch 5)
- removing _t suffix from struct which isn't typedef and replace unsigned
char by u8 (Patch 6)
Thanks and kind regards,
peter
Cc: Andrew Morton
Cc: Andreas Mohr
Cc: Borislav Petkov
Cc: Zhang Rui
Cc: Javi Merino
Peter Feuerer (6):
Some Acer models require an additional command to turn off the fan after
bios mode has been enabled. Adding new section in bios table to allow
support for those models, by writing an extra "manual mode" register.
Cc: Andrew Morton
Cc: Andreas Mohr
Cc: Borislav Petkov
Signed-off
added following new models:
* Aspire 5755G
* AO521
* AO751h
* Aspire One 753
* Extensa 5420
* Aspire 5315
* Aspire 5739G
* TravelMate TM8573T
Cc: Andrew Morton
Cc: Andreas Mohr
Cc: Borislav Petkov
Signed-off-by: Peter Feuerer
---
drivers/platform/x86/acerhdf.c | 25
1 - 100 of 156 matches
Mail list logo
