Re: general protection fault in __bfs (2)

2020-06-19 Thread Petr Machata
syzbot writes: > syzbot suspects this bug was fixed by commit: > > commit 46ca11177ed593f39d534f8d2c74ec5344e90c11 > Author: Amit Cohen > Date: Thu May 21 12:11:45 2020 + > > selftests: mlxsw: qos_mc_aware: Specify arping timeout as an integer That does not sound right. The

Re: [PATCH][net-next][V2] mlxsw: spectrum_ptp: fix duplicated check on orig_egr_types

2019-07-30 Thread Petr Machata
Colin King writes: > From: Colin Ian King > > Currently are duplicated checks on orig_egr_types which are > redundant, I believe this is a typo and should actually be > orig_ing_types || orig_egr_types instead of the expression > orig_egr_types || orig_egr_types. Fix these. > >

Re: [PATCH][next] mlxsw: spectrum_ptp: fix duplicated check on orig_egr_types

2019-07-30 Thread Petr Machata
Petr Machata writes: > Colin King writes: > >> From: Colin Ian King >> >> Currently there is a duplicated check on orig_egr_types which is >> redundant, I believe this is a typo and should actually be >> orig_ing_types || orig_egr_types instead

Re: [PATCH][next] mlxsw: spectrum_ptp: fix duplicated check on orig_egr_types

2019-07-30 Thread Petr Machata
Petr Machata writes: > Colin King writes: > >> From: Colin Ian King >> >> Currently there is a duplicated check on orig_egr_types which is >> redundant, I believe this is a typo and should actually be >> orig_ing_types || orig_egr_types instead

Re: [PATCH][next] mlxsw: spectrum_ptp: fix duplicated check on orig_egr_types

2019-07-30 Thread Petr Machata
this. Good catch, yes, there's a typo. Thanks for the fix! > Addresses-Coverity: ("Same on both sides") > Fixes: c6b36bdd04b5 ("mlxsw: spectrum_ptp: Increase parsing depth when PTP is > enabled") > Signed-off-by: Colin Ian King Reviewed-by: Petr Mach

Re: mlxsw: spectrum: PTP: Support timestamping on Spectrum-1 - potential null ptr dereference

2019-07-02 Thread Petr Machata
Colin Ian King writes: > Hi, > > Static analysis with Coverity on today's linux-next has found a > potential null pointer dereference bug with the following commit: > > commit d92e4e6e33c8b19635be70fb8935b627d2e4f8fe > Author: Petr Machata > Date: Sun Ju

Re: [PATCH net-next] net: dsa: fix added_by_user switchdev notification

2018-05-09 Thread Petr Machata
Vivien Didelot writes: > @petr I expect the same issue with Rocker, but I haven't tested it. Yeah, pretty sure. Such an obvious bug, sorry about that :-/ I'll send a rocker patch later today. Thanks, Petr

Re: [PATCH net-next] net: dsa: fix added_by_user switchdev notification

2018-05-09 Thread Petr Machata
Vivien Didelot writes: > @petr I expect the same issue with Rocker, but I haven't tested it. Yeah, pretty sure. Such an obvious bug, sorry about that :-/ I'll send a rocker patch later today. Thanks, Petr

Re: linux-next: manual merge of the ipsec tree with the net tree

2018-03-27 Thread Petr Machata
next time they rebase on top of net...? Let me know what to do, please. Thanks, Petr >From 2c2210e59cd94571ac67d491026d6ea0f4d69ae4 Mon Sep 17 00:00:00 2001 Message-Id: <2c2210e59cd94571ac67d491026d6ea0f4d69ae4.1522155963.git.pe...@mellanox.com> From: Petr Machata <pe...@mellanox.com> Date: Tue,

Re: linux-next: manual merge of the ipsec tree with the net tree

2018-03-27 Thread Petr Machata
ime they rebase on top of net...? Let me know what to do, please. Thanks, Petr >From 2c2210e59cd94571ac67d491026d6ea0f4d69ae4 Mon Sep 17 00:00:00 2001 Message-Id: <2c2210e59cd94571ac67d491026d6ea0f4d69ae4.1522155963.git.pe...@mellanox.com> From: Petr Machata Date: Tue, 27 Mar 2018 16:00:38 +0300 Subject: [PATCH linux-ne

[tip:perf/core] perf python: Reference Py_None before returning it

2018-03-25 Thread tip-bot for Petr Machata
Commit-ID: 83428f2fad48e16fddff0cb445cb4fedf5afe4ab Gitweb: https://git.kernel.org/tip/83428f2fad48e16fddff0cb445cb4fedf5afe4ab Author: Petr Machata <pe...@mellanox.com> AuthorDate: Thu, 22 Mar 2018 00:57:32 +0100 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> CommitD

[tip:perf/core] perf python: Reference Py_None before returning it

2018-03-25 Thread tip-bot for Petr Machata
Commit-ID: 83428f2fad48e16fddff0cb445cb4fedf5afe4ab Gitweb: https://git.kernel.org/tip/83428f2fad48e16fddff0cb445cb4fedf5afe4ab Author: Petr Machata AuthorDate: Thu, 22 Mar 2018 00:57:32 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 23 Mar 2018 16:45:20 -0300 perf python

[PATCH] perf: python: Reference Py_None before returning it

2018-03-21 Thread Petr Machata
Python None objects are handled just like all the other objects with respect to their reference counting. Before returning Py_None, its reference count thus needs to be bumped. Signed-off-by: Petr Machata <pe...@mellanox.com> --- tools/perf/util/python.c | 4 +++- 1 file changed, 3 inse

[PATCH] perf: python: Reference Py_None before returning it

2018-03-21 Thread Petr Machata
Python None objects are handled just like all the other objects with respect to their reference counting. Before returning Py_None, its reference count thus needs to be bumped. Signed-off-by: Petr Machata --- tools/perf/util/python.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion

Re: linux-next: manual merge of the net-next tree with the net tree

2018-03-13 Thread Petr Machata
Stephen Rothwell writes: > Today's linux-next merge of the net-next tree got conflicts in: > > drivers/net/ethernet/mellanox/mlxsw/spectrum.h > drivers/net/ethernet/mellanox/mlxsw/spectrum.c > > between commit: > > 663f1b26f9c1 ("mlxsw: spectrum: Prevent duplicate

Re: linux-next: manual merge of the net-next tree with the net tree

2018-03-13 Thread Petr Machata
Stephen Rothwell writes: > Today's linux-next merge of the net-next tree got conflicts in: > > drivers/net/ethernet/mellanox/mlxsw/spectrum.h > drivers/net/ethernet/mellanox/mlxsw/spectrum.c > > between commit: > > 663f1b26f9c1 ("mlxsw: spectrum: Prevent duplicate mirrors") > > from the

Re: linux-next: manual merge of the net-next tree with the net tree

2018-02-28 Thread Petr Machata
Stephen Rothwell writes: > Today's linux-next merge of the net-next tree got a conflict in: > > net/ipv4/ip_tunnel.c > > between commit: > > 4e994776e7bd ("ip_tunnel: Do not use mark in skb by default") > > from the net tree and commit: > > b0066da52ea5 ("ip_tunnel:

Re: linux-next: manual merge of the net-next tree with the net tree

2018-02-28 Thread Petr Machata
Stephen Rothwell writes: > Today's linux-next merge of the net-next tree got a conflict in: > > net/ipv4/ip_tunnel.c > > between commit: > > 4e994776e7bd ("ip_tunnel: Do not use mark in skb by default") > > from the net tree and commit: > > b0066da52ea5 ("ip_tunnel: Rename & publish