Re: [PATCH v7 05/16] module: make module_memory_{alloc,free} more self-contained

2024-04-30 Thread Philippe Mathieu-Daudé
ain.c | 64 +++- 1 file changed, 39 insertions(+), 25 deletions(-) Nice code simplification. Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v5 11/15] arch: make execmem setup available regardless of CONFIG_MODULES

2024-04-22 Thread Philippe Mathieu-Daudé
| 29 +++ 23 files changed, 463 insertions(+), 445 deletions(-) create mode 100644 arch/sparc/mm/execmem.c Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 2/4] KVM: remove unused argument of kvm_handle_hva_range()

2024-04-08 Thread Philippe Mathieu-Daudé
On 5/4/24 13:58, Paolo Bonzini wrote: The only user was kvm_mmu_notifier_change_pte(), which is now gone. Signed-off-by: Paolo Bonzini --- virt/kvm/kvm_main.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 4/4] mm: replace set_pte_at_notify() with just set_pte_at()

2024-04-08 Thread Philippe Mathieu-Daudé
-- kernel/events/uprobes.c | 5 ++--- mm/ksm.c | 4 ++-- mm/memory.c | 7 +-- mm/migrate_device.c | 8 ++-- 5 files changed, 7 insertions(+), 19 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] arch: mips: bcm63xx: Spello fix in the file clk.c

2021-03-08 Thread Philippe Mathieu-Daudé
Hi Bhaskar, On Fri, Mar 5, 2021 at 3:06 AM Bhaskar Chowdhury wrote: > > > > s/revelant/relevant/ Let me recommend you this great post explaining why and how you could improve your patch subject and description:

Re: [PATCH V2 mips/linux.git] firmware: bcm47xx_nvram: refactor finding & reading NVRAM

2021-03-05 Thread Philippe Mathieu-Daudé
On Fri, Mar 5, 2021 at 11:16 AM Rafał Miłecki wrote: > > Hi, > > On 05.03.2021 10:58, Philippe Mathieu-Daudé wrote: > > On Fri, Mar 5, 2021 at 6:55 AM Rafał Miłecki wrote: > >> > >> From: Rafał Miłecki > >> > >> 1. Use meaningful

Re: [PATCH 2/2] MIPS: Loongson64: Move loongson_system_configuration to loongson.h

2021-03-05 Thread Philippe Mathieu-Daudé
Hi, On Thu, Mar 4, 2021 at 5:35 PM Qing Zhang wrote: > > The purpose of separating loongson_system_configuration from boot_param.h > is to keep the other structure consistent with the firmware. This is supposed to be a trivial patch, but the description actually confuses me. Why is the move

Re: [PATCH V2 mips/linux.git] firmware: bcm47xx_nvram: refactor finding & reading NVRAM

2021-03-05 Thread Philippe Mathieu-Daudé
Hi Rafał, On Fri, Mar 5, 2021 at 6:55 AM Rafał Miłecki wrote: > > From: Rafał Miłecki > > 1. Use meaningful variable names (e.g. "flash_start", "res_size" instead >of e.g. "iobase", "end") > 2. Always operate on "offset" instead of mix of start, end, size, etc. "instead of a mix" > 3. Add

Re: [PATCH] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute

2021-02-25 Thread Philippe Mathieu-Daudé
/github.com/ClangBuiltLinux/linux/issues/1299 > Signed-off-by: Nathan Chancellor > --- > drivers/firmware/qemu_fw_cfg.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 5/5] MIPS: SGI-IP27: fix spelling in Copyright

2021-02-23 Thread Philippe Mathieu-Daudé
On Tue, Feb 23, 2021 at 1:33 PM Maciej W. Rozycki wrote: > On Tue, 23 Feb 2021, Philippe Mathieu-Daudé wrote: > > > > diff --git a/arch/mips/sgi-ip27/ip27-timer.c > > > b/arch/mips/sgi-ip27/ip27-timer.c > > > index 79c434fece52..444b5e0e935f 100644 > >

Re: [PATCH 4/5] arch: mips: remove dead references

2021-02-23 Thread Philippe Mathieu-Daudé
On Mon, Feb 22, 2021 at 5:22 PM Lukas Bulwahn wrote: > > The domain lookup for linux-mips.org fails for quite some time now. > Further, the two links: > > http://decstation.unix-ag.org/ https://web.archive.org/web/20070609185805/http://decstation.unix-ag.org/ >

Re: [PATCH 5/5] MIPS: SGI-IP27: fix spelling in Copyright

2021-02-23 Thread Philippe Mathieu-Daudé
On Mon, Feb 22, 2021 at 5:22 PM Lukas Bulwahn wrote: > > This is a Copyright line, and just a typo slipped through. > > Signed-off-by: Lukas Bulwahn > --- > arch/mips/sgi-ip27/ip27-timer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH 3/5] arch: mips: update references to current linux-mips list

2021-02-23 Thread Philippe Mathieu-Daudé
+- > arch/mips/sgi-ip32/ip32-irq.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 2/5] MAINTAINERS: remove linux-mips.org references

2021-02-23 Thread Philippe Mathieu-Daudé
On Mon, Feb 22, 2021 at 5:22 PM Lukas Bulwahn wrote: > > The domain lookup for linux-mips.org fails for quite some time now. Hence, > webpages, the patchwork instance and Ralf Baechle's email there is not > reachable anymore. > > Remove all references of webpages from linux-mips.org in

Re: [PATCH] MIPS: boot: Fix unaligned access with CONFIG_MIPS_RAW_APPENDED_DTB

2020-12-17 Thread Philippe Mathieu-Daudé
t; --- > arch/mips/boot/compressed/decompress.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] MIPS: Kconfig: fix a few trivial spelling mistakes

2020-10-31 Thread Philippe Mathieu-Daudé
On Wed, Oct 28, 2020 at 9:01 PM Colin King wrote: > > From: Colin Ian King > > There are a few spelling mistakes in the Kconfig, fix these. > > Signed-off-by: Colin Ian King > --- > arch/mips/Kconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Re

Re: [PATCH] MIPS: malta: remove unused header file

2020-09-22 Thread Philippe Mathieu-Daudé
On Sun, Sep 20, 2020 at 11:09 PM Thomas Bogendoerfer wrote: > > Remove unused heasder file asm/mach-malta/malta-pm.h. Typo "header". > > Signed-off-by: Thomas Bogendoerfer > --- > arch/mips/include/asm/mach-malta/malta-pm.h | 33 > - > 1 file changed, 33

Re: [PATCH v3 06/15] MIPS: generic: Allow boards to set system type

2020-09-08 Thread Philippe Mathieu-Daudé
On Sun, Sep 6, 2020 at 9:31 PM Paul Cercueil wrote: > > Check for the (already existing) "system_type" variable in the > get_system_type() function. If non-NULL, return it as the system type. Nitpick: It is not already "existing", simply declared in asm/bootinfo.h. > > Signed-off-by: Paul

Re: [PATCH 4.19 66/81] MIPS: Disable Loongson MMI instructions for kernel build

2020-09-06 Thread Philippe Mathieu-Daudé
On Thu, Sep 3, 2020 at 11:28 AM Greg Kroah-Hartman wrote: > > On Wed, Aug 26, 2020 at 02:06:28PM -0700, Guenter Roeck wrote: > > Hi, > > > > On Wed, Oct 16, 2019 at 02:51:17PM -0700, Greg Kroah-Hartman wrote: > > > From: Paul Burton > > > > > > commit 2f2b4fd674cadd8c6b40eb629e140a14db4068fd

Re: [PATCH v4 4/5] MIPS: BCM63xx: refactor board declarations

2020-08-13 Thread Philippe Mathieu-Daudé
On Wed, Aug 12, 2020 at 9:53 AM Álvaro Fernández Rojas wrote: > > Current board declarations are a mess. Let's put some order and make them > follow the same structure. What a mess indeed. Patch easier to review using 'git-diff --ignore-all-space'. Reviewed-by: Philippe Math

Re: [PATCH v4 3/5] MIPS: BCM63xx: enable EHCI for DWV-S0 board

2020-08-12 Thread Philippe Mathieu-Daudé
dy reviewed, again: Reviewed-by: Philippe Mathieu-Daudé > --- > v4: no changes. > v3: Reword commit description to avoid possible confusions. > v2: no changes. > > arch/mips/bcm63xx/boards/board_bcm963xx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/m

Re: [PATCH v4 2/5] MIPS: BCM63xx: remove EHCI from BCM6348 boards

2020-08-12 Thread Philippe Mathieu-Daudé
On Wed, Aug 12, 2020 at 9:53 AM Álvaro Fernández Rojas wrote: > > There's no EHCI controller on BCM6348. > > Signed-off-by: Álvaro Fernández Rojas > Acked-by: Florian Fainelli v3 already reviewed, again: Reviewed-by: Philippe Mathieu-Daudé > --- > v4: no changes. >

Re: [PATCH v3 4/4] MIPS: BCM63xx: refactor board declarations

2020-08-11 Thread Philippe Mathieu-Daudé
On Tue, Aug 11, 2020 at 6:48 PM Philippe Mathieu-Daudé wrote: > On Tue, Aug 11, 2020 at 5:01 PM Álvaro Fernández Rojas > wrote: > > > > Current board declarations are a mess. Let's put some order and make them > > follow the same structure. Also board declarations

Re: [PATCH v3 4/4] MIPS: BCM63xx: refactor board declarations

2020-08-11 Thread Philippe Mathieu-Daudé
On Tue, Aug 11, 2020 at 5:01 PM Álvaro Fernández Rojas wrote: > > Current board declarations are a mess. Let's put some order and make them > follow the same structure. Also board declarations tabs. > Switch to SPDX license identifier. > > Signed-off-by: Álvaro Fernández Rojas > Acked-by:

Re: [PATCH v3 2/4] MIPS: BCM63xx: remove EHCI from BCM6348 boards

2020-08-11 Thread Philippe Mathieu-Daudé
On Tue, Aug 11, 2020 at 5:05 PM Álvaro Fernández Rojas wrote: > > There's no EHCI controller on BCM6348. > > Signed-off-by: Álvaro Fernández Rojas > Acked-by: Florian Fainelli Reviewed-by: Philippe Mathieu-Daudé > --- > v3: no changes. > v2: no changes. >

Re: [PATCH v3 3/4] MIPS: BCM63xx: enable EHCI for DWV-S0 board

2020-08-11 Thread Philippe Mathieu-Daudé
iewed-by: Philippe Mathieu-Daudé > --- > v3: Reword commit description to avoid possible confusions. Thanks! > v2: no changes. > > arch/mips/bcm63xx/boards/board_bcm963xx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/mips/bcm63xx/boards/board_bcm963xx.c >

Re: [PATCH v2 3/4] MIPS: BCM63xx: enable EHCI for DWV-S0 board

2020-08-11 Thread Philippe Mathieu-Daudé
Hi Florian, On Tue, Aug 11, 2020 at 4:33 AM Florian Fainelli wrote: > On 8/9/2020 11:49 AM, Philippe Mathieu-Daudé wrote: > > Hi Álvaro, > > > > On Fri, Aug 7, 2020 at 12:05 PM Álvaro Fernández Rojas > > wrote: > >> > >> EHCI and OHCI share the sam

Re: [PATCH v2 3/4] MIPS: BCM63xx: enable EHCI for DWV-S0 board

2020-08-09 Thread Philippe Mathieu-Daudé
Hi Álvaro, On Fri, Aug 7, 2020 at 12:05 PM Álvaro Fernández Rojas wrote: > > EHCI and OHCI share the same USB ports. Therefore, if the board has OHCI > it should also have EHCI. This statement isn't correct. OHCI doesn't imply EHCI... (although the opposite is almost always true). Now per

Re: [PATCH v2 1/4] MIPS: BCM63xx: remove duplicated new lines

2020-08-09 Thread Philippe Mathieu-Daudé
On Fri, Aug 7, 2020 at 12:06 PM Álvaro Fernández Rojas wrote: > > There are 3 duplicated new lines, let's remove them. > > Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Philippe Mathieu-Daudé =) > --- > v2: no changes. > > arch/mips/bcm63xx/boards/board_bcm9

Re: [PATCH] CREDITS: remove link: http://www.andante.org

2020-07-15 Thread Philippe Mathieu-Daudé
Hi Alexander, On Tue, Jul 14, 2020 at 10:18 PM Alexander A. Klimov wrote: > > Rationale: > A completely white page with just an in the . > > Signed-off-by: Alexander A. Klimov > --- > Yes, I noted that some of the links removed by these "CREDITS: remove link:" > patches have email addresses

Re: [PATCH] CREDITS: remove link http://www.mathematik.uni-stuttgart.de/~floeff

2020-07-15 Thread Philippe Mathieu-Daudé
Hi Alexander, On Tue, Jul 14, 2020 at 10:18 PM Alexander A. Klimov wrote: > > Rationale: > The way it redirects looks like a fallback from a dead URL to a generic one. > > Signed-off-by: Alexander A. Klimov > --- > Yes, I noted that some of the links removed by these "CREDITS: remove link:" >

Re: [PATCH 2/2] clk: bcm63xx-gate: add BCM6318 support

2020-06-13 Thread Philippe Mathieu-Daudé
On Wed, Jun 10, 2020 at 5:32 PM Florian Fainelli wrote: > On 6/10/2020 1:29 AM, Philippe Mathieu-Daudé wrote: > > Hi, > > > > On Wed, Jun 10, 2020 at 8:13 AM Álvaro Fernández Rojas > > wrote: > >> > >> Hi Florian, > >> > >>

Re: [PATCH 2/2] clk: bcm63xx-gate: add BCM6318 support

2020-06-10 Thread Philippe Mathieu-Daudé
Hi, On Wed, Jun 10, 2020 at 8:13 AM Álvaro Fernández Rojas wrote: > > Hi Florian, > > > El 10 jun 2020, a las 4:27, Florian Fainelli > > escribió: > > > > > > > > On 6/9/2020 4:30 AM, Álvaro Fernández Rojas wrote: > >> +static const struct clk_bcm63xx_table_entry bcm6318_clocks[] = { > >> +

Re: clean up kernel_{read,write} & friends v2

2020-06-05 Thread Philippe Mathieu-Daudé
Hi Linus, On 5/29/20 9:19 PM, Linus Torvalds wrote: > On Fri, May 29, 2020 at 6:08 AM David Laight wrote: >> >> A wide monitor is for looking at lots of files. > > Not necessarily. > > Excessive line breaks are BAD. They cause real and every-day problems. > > They cause problems for things

Re: [PATCH] MIPS: ingenic: Add missing include

2020-05-20 Thread Philippe Mathieu-Daudé
On Wed, May 20, 2020 at 11:28 AM Thomas Bogendoerfer wrote: > > On Wed, May 20, 2020 at 11:19:49AM +0200, Philippe Mathieu-Daudé wrote: > > Hi Thomas, > > > > On Wed, May 20, 2020 at 8:50 AM Thomas Bogendoerfer > > wrote: > > > > > > On Tue, May 1

Re: [PATCH] MIPS: ingenic: Add missing include

2020-05-20 Thread Philippe Mathieu-Daudé
Hi Thomas, On Wed, May 20, 2020 at 8:50 AM Thomas Bogendoerfer wrote: > > On Tue, May 19, 2020 at 11:22:30PM +0200, Paul Cercueil wrote: > > Add missing include which adds the prototype to plat_time_init(). > > > > Fixes: f932449c11da ("MIPS: ingenic: Drop obsolete code, merge the rest in > >

Re: [PATCH] MIPS: include: Mark __xchg as __always_inline

2019-10-09 Thread Philippe Mathieu-Daudé
long __xchg(volatile void *ptr, unsigned long x, int size) { switch (size) { case 1: Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v8 1/5] nvmem: core: add nvmem_device_find

2019-10-09 Thread Philippe Mathieu-Daudé
+} + #endif /* CONFIG_NVMEM */ #if IS_ENABLED(CONFIG_NVMEM) && IS_ENABLED(CONFIG_OF) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v4 8/9] MIPS: SGI-IP27: fix readb/writeb addressing

2019-08-13 Thread Philippe Mathieu-Daudé
Hi Thomas, On 8/11/19 9:29 AM, Greg Kroah-Hartman wrote: > On Sat, Aug 10, 2019 at 04:22:23PM +0300, Andy Shevchenko wrote: >> On Fri, Aug 9, 2019 at 1:34 PM Thomas Bogendoerfer >> wrote: >>> >>> Our chosen byte swapping, which is what firmware already uses, is to >>> do readl/writel by normal

Re: [PATCH] MIPS: OCTEON: octeon-usb: Mark expected switch fall-through

2019-08-06 Thread Philippe Mathieu-Daudé
rough. > > Cc: Gustavo A. R. Silva > Signed-off-by: Guenter Roeck Reviewed-by: Philippe Mathieu-Daudé > --- > arch/mips/cavium-octeon/octeon-usb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/mips/cavium-octeon/octeon-usb.c > b/arch/mips/cavium-octeon/oct

Re: [Qemu-devel] Running linux on qemu omap

2019-05-27 Thread Philippe Mathieu-Daudé
On 5/27/19 5:56 PM, Guenter Roeck wrote: > On 5/26/19 11:32 PM, Tony Lindgren wrote: >> Hi, >> >> * Philippe Mathieu-Daudé [190523 12:01]: >>> What I use as reference for testing ARM boards [*] is the work of >>> Guenter Roeck: >>> https://github.co

Re: [Qemu-devel] Running linux on qemu omap

2019-05-23 Thread Philippe Mathieu-Daudé
On 5/23/19 1:27 PM, Thomas Huth wrote: > On 22/05/2019 20.19, Aaro Koskinen wrote: >> Hi, >> >> On Wed, May 22, 2019 at 11:33:41AM +0200, Corentin Labbe wrote: >>> qemu-system-arm -M help |grep OMAP >>> cheetah Palm Tungsten|E aka. Cheetah PDA (OMAP310) >>> n800 Nokia

Re: [PATCH v2 1/2] firmware: bcm47xx_nvram: Correct size_t printf format

2019-05-14 Thread Philippe Mathieu-Daudé
if (nvram_len >= NVRAM_SPACE) { > - pr_err("nvram on flash (%i bytes) is bigger than the > reserved space in memory, will just copy the first %i bytes\n", > + pr_err("nvram on flash (%zu bytes) is bigger than the > reserved space in memory, will just copy the first %i bytes\n", > header.len, NVRAM_SPACE); Ditto. Regardless: Reviewed-by: Philippe Mathieu-Daudé > nvram_len = NVRAM_SPACE - 1; > } >

Re: [PATCH] MIPS: scall64-o32: Fix indirect syscall number load

2019-04-14 Thread Philippe Mathieu-Daudé
l at offset 0 */ > - lw a1, PT_R4(sp) /* Arg1 for __NR_syscall case */ > + ld a1, PT_R4(sp) /* Arg1 for __NR_syscall case */ > .setpop > > 1: jal syscall_trace_enter > > Reviewed-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH] fw_cfg: use __ATTR_RO_MODE to define rev sysfs

2019-02-26 Thread Philippe Mathieu-Daudé
On 2/26/19 5:10 PM, Michael S. Tsirkin wrote: > On Tue, Feb 26, 2019 at 03:31:59PM +0800, Wei Yang wrote: >> Leverage __ATTR_RO_MODE to define rev sysfs instead of using open code >> to define the attribute. >> >> Signed-off-by: Wei Yang >> --- >> drivers/firmware/qemu_fw_cfg.c | 13

Re: [Qemu-devel] [PATCH] fw_cfg: use __ATTR_RO_MODE to define rev sysfs

2019-02-26 Thread Philippe Mathieu-Daudé
Hi Wei, On 2/26/19 8:31 AM, Wei Yang wrote: > Leverage __ATTR_RO_MODE to define rev sysfs instead of using open code > to define the attribute. > > Signed-off-by: Wei Yang > --- > drivers/firmware/qemu_fw_cfg.c | 13 - > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff

Re: [v2,08/12] hwrng: bcm2835-rng: Abstract I/O accessors

2017-11-12 Thread Philippe Mathieu-Daudé
..@anholt.net> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > drivers/char/hw_random/bcm2835-rng.c | 27 +++ > 1 file changed, 19 insertions(+), 8 deletions(-) > > diff --git a/drivers/char/hw_random/bcm2835-rng.c > b/driver

Re: [v2,08/12] hwrng: bcm2835-rng: Abstract I/O accessors

2017-11-12 Thread Philippe Mathieu-Daudé
On 11/07/2017 09:44 PM, Florian Fainelli wrote: > In preparation for allowing BCM63xx to use this driver, we abstract I/O > accessors such that we can easily change those later on. > > Signed-off-by: Florian Fainelli > Reviewed-by: Eric Anholt Reviewed-by: Philipp