...
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/mediatek/mt8173/mt8173-afe-pcm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c
b/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c
index 685f4074b4e0..6350390414d4 100644
--- a/sound/soc
,
^
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/mediatek/mt2701/mt2701-afe-clock-ctrl.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/mediatek/mt2701/mt2701-afe-clock-ctrl.h
b/sound/soc/mediatek/mt2701/mt2701-afe-clock-ctrl.h
index
There should be no functionality change, this patchset only fixes
shadowed variables, prototypes and removes a useless assignment.
Pierre-Louis Bossart (4):
ASoC: mediatek: mtk-btcvsd: remove useless assignment
ASoC: mediatek: mt2701: align function prototype
ASoC: mediatek: mt2701: rename
cppcheck warning:
sound/soc/mediatek/common/mtk-btcvsd.c:783:34: style: Variable 'avail'
is assigned a value that is never used. [unreadVariable]
int written_size = count, avail = 0, cur_write_idx, write_size, cont;
^
Signed-off-by: Pierre-Louis Bossart
it in the ASoC core.
Fixes: c014170408bc ("ASoC: soc-core: Prevent warning if no DMI table is
present")
Signed-off-by: Pierre-Louis Bossart
---
drivers/firmware/dmi_scan.c | 1 +
sound/soc/soc-core.c| 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/firmware/
Build time dependencies aren't going to help anything, arm64 (and to my
understanding some future x86 systems, LynxPoint IIRC) supports both DT
and ACPI and so you have kernels built with support for both.
well, that's what I suggested initially:
if (is_of_node(card->dev->fwnode))
On 3/10/21 10:52 AM, Mark Brown wrote:
On Wed, Mar 10, 2021 at 10:41:18AM -0600, Pierre-Louis Bossart wrote:
would this work?
if (!IS_ENABLED(CONFIG_DMI))
return 0;
Build time dependencies aren't going to help anything, arm64 (and to my
understanding some future x86 systems
On 3/10/21 10:37 AM, Takashi Iwai wrote:
On Wed, 10 Mar 2021 17:18:14 +0100,
Mark Brown wrote:
On Wed, Mar 10, 2021 at 09:44:07AM -0600, Pierre-Louis Bossart wrote:
On 3/10/21 7:35 AM, Mark Brown wrote:
Just change it to a system level check for ACPI, checking for OF would
leave
On 3/9/21 8:15 AM, Srinivas Kandagatla wrote:
currently the internal bitmask used for allocating ports starts with offset 0.
This is bit confusing as data port numbers on Qualcomm controller are valid
from 1 to 14. So adjust this bit mask accordingly, this will also help while
adding static
list_for_each_entry(m_rt, >m_rt_list, bus_node) {
@@ -473,8 +475,13 @@ static int qcom_swrm_compute_params(struct sdw_bus *bus)
}
list_for_each_entry(s_rt, _rt->slave_rt_list, m_rt_node) {
+ slave = s_rt->slave;
On 3/10/21 7:35 AM, Mark Brown wrote:
On Tue, Mar 09, 2021 at 01:41:45PM -0600, Pierre-Louis Bossart wrote:
The problem is that the cards are platform devices created by the parent
(which itself may be a PCI or ACPI device) and have nothing to do with ACPI.
Could we flip the logic
On 3/3/21 5:55 AM, Jon Hunter wrote:
Many systems do not use ACPI and hence do not provide a DMI table. On
non-ACPI systems a warning, such as the following, is printed on boot.
WARNING KERN tegra-audio-graph-card sound: ASoC: no DMI vendor name!
The variable 'dmi_available' is not
+++ b/sound/soc/amd/Kconfig
@@ -5,14 +5,15 @@ config SND_SOC_AMD_ACP
This option enables ACP DMA support on AMD platform.
config SND_SOC_AMD_CZ_DA7219MX98357_MACH
- tristate "AMD CZ support for DA7219 and MAX9835"
+ tristate "AMD CZ support for DA7219, RT5682 and
module_param(force_rfkill, bool, 0444);
MODULE_PARM_DESC(force_rfkill, "enable rfkill on non whitelisted
models");
+
spurious line change
I just want to make them separate with more space .
If it cause concern, I will remote the line in V5.
it's fine to improve spaces/alignment,
+static int qcom_swrm_enumerate(struct sdw_bus *bus)
+{
+ struct qcom_swrm_ctrl *ctrl = to_qcom_sdw(bus);
+ struct sdw_slave *slave, *_s;
+ struct sdw_slave_id id;
+ u32 val1, val2;
+ bool found;
+ u64 addr;
+ int i;
+ char *buf1 = (char *),
e bus but not on device list"?
if yes, the first part is ambiguous in its wording, the enumeration
completes by programming a device number. At this point the device is
only 'attached'.
The fix is correct otherwise, please add my tag if you change the commit
message in a v2.
Reviewed-by: Pi
@@ -38,6 +39,15 @@ struct cs_spec {
/* for MBP SPDIF control */
int (*spdif_sw_put)(struct snd_kcontrol *kcontrol,
struct snd_ctl_elem_value *ucontrol);
+
+ unsigned int cs42l42_hp_jack_in:1;
+ unsigned int cs42l42_mic_jack_in:1;
+
+
On 3/6/21 5:19 AM, Vitaly Rodionov wrote:
From: Stefan Binding
CS8409 does not support Volume Control for NIDs 0x24 (the Headphones),
or 0x34 (The Headset Mic).
However, CS42L42 codec does support gain control for both.
Volume Control for both
We can add support for Volume Controls, by
+/* Enable I2C clocks */
+static void cs8409_enable_i2c_clock(struct hda_codec *codec, unsigned int flag)
+{
+ unsigned int retval = 0;
+ unsigned int newval = 0;
initializations not needed
+ retval = cs_vendor_coef_get(codec, 0x0);
+ newval = (flag) ? (retval |
+ if (!val1 && !val2)
+ break;
+
+ addr = buf2[1] | (buf2[0] << 8) | (buf1[3] << 16) |
+ ((u64)buf1[2] << 24) | ((u64)buf1[1] << 32) |
+ ((u64)buf1[0] << 40);
+
+ sdw_extract_slave_id(bus, addr, );
+ /* Now compare with entries */
Hi,
Our SOF/audio CI shows an across-the-board regression when we try
v5.12-rc1, specifically on pause/resume tests with an interactive
terminal running 'aplay -i' commands managed by expect to simulate the
user pressing the space bar to pause/unpause. It turns out the processes
are not
On 3/3/21 3:38 AM, Srinivas Kandagatla wrote:
On 02/03/2021 14:34, Pierre-Louis Bossart wrote:
+ if (!val1 && !val2)
+ break;
+
+ addr = buf2[1] | (buf2[0] << 8) | (buf1[3] << 16) |
+ ((u64)buf1[2] << 24) | ((u64)buf1[1] &
soundwire-controller@321 {
reg = <0 0x321 0 0x2000>;
compatible = "qcom,soundwire-v1.5.1";
interrupts = ;
clocks = <>;
clock-names = "iface";
qcom,clock-stop-mode0;
qcom,din-ports = <0>;
qcom,dout-ports = <5>;
qcom,ports-sinterval-low =
for (i = 0; i < nports; i++) {
ctrl->pconfig[i].si = si[i];
ctrl->pconfig[i].off1 = off1[i];
ctrl->pconfig[i].off2 = off2[i];
ctrl->pconfig[i].bp_mode = bp_mode[i];
+ ctrl->pconfig[i].hstart = hstart[i];
+ ctrl->pconfig[i].hstop =
+ if (!val1 && !val2)
+ break;
+
+ addr = buf2[1] | (buf2[0] << 8) | (buf1[3] << 16) |
+ ((u64)buf1[2] << 24) | ((u64)buf1[1] << 32) |
+ ((u64)buf1[0] << 40);
+
+ sdw_extract_slave_id(bus, addr, );
+ /* Now compare with entries */
+
An unsigned long variable should rely on '%lu' format strings, not '%zd'
Fixes: a1a6a4cf49ece ("iwlwifi: pnvm: implement reading PNVM from UEFI")
Signed-off-by: Pierre-Louis Bossart
---
warnings found with v5.12-rc1 and next-20210301
drivers/net/wireless/intel/iwlwifi/fw/pnvm.c |
On 3/1/21 3:38 AM, Perry Yuan wrote:
From: Perry Yuan
Some new Dell system is going to support audio internal micphone
privacy setting from hardware level with micmute led state changing
When micmute hotkey pressed by user, soft mute will need to be enabled
firstly in case of pop noise, and
diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile
index 581475f59819..18c430456de7 100644
--- a/drivers/platform/x86/Makefile
+++ b/drivers/platform/x86/Makefile
@@ -51,7 +51,9 @@ obj-$(CONFIG_DELL_WMI_DESCRIPTOR) += dell-wmi-descriptor.o
.
Addresses-Coverity: ("Unchecked return value")
Fixes: f139546fb7d4 ("ASoC: Intel: boards: sof-wm8804: support for Hifiberry
Digiplus boards")
Signed-off-by: Colin Ian King
Acked-by: Pierre-Louis Bossart
---
sound/soc/intel/boards/sof_wm8804.c | 6 +-
1 file c
+static int qcom_swrm_enumerate(struct sdw_bus *bus)
+{
+ struct qcom_swrm_ctrl *ctrl = to_qcom_sdw(bus);
+ struct sdw_slave *slave, *_s;
+ struct sdw_slave_id id;
+ u32 val1, val2;
+ u64 addr;
+ int i;
+ char *buf1 = (char *), *buf2 = (char *)
+
+
+ pm_runtime_get_sync(ctrl->dev);
if this fails you've got to do a put_noidle().
we use this for Intel:
ret = pm_runtime_get_sync(cdns->dev);
if (ret < 0 && ret != -EACCES) {
dev_err_ratelimited(cdns->dev,
On 2/26/21 9:58 AM, Srinivas Kandagatla wrote:
Some of the transport parameters derived from device tree
are not fully parsed by the driver.
This patch adds support to parse those missing parameters.
Signed-off-by: Srinivas Kandagatla
---
drivers/soundwire/qcom.c | 99
10: note: ret is initialized
int ret = -ENODEV;
^
sound/soc/fsl/p1022_ds.c:344:6: note: ret is overwritten
ret = fsl_asoc_get_dma_channel(np, "fsl,playback-dma", >dai[0],
^
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/p1022_ds.c | 2 +-
1 file changed, 1 inserti
cppcheck warning:
sound/soc/fsl/imx-hdmi.c:21:16: style: struct member
'cpu_priv::sysclk_freq' is never used. [unusedStructMember]
unsigned long sysclk_freq[2];
^
Additional checks show the sysclk_dir member is also not used.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc
missing parentheses reported by checkpatch.pl
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/mpc5200_dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/mpc5200_dma.c b/sound/soc/fsl/mpc5200_dma.c
index 231984882176..6c65cd858b0b 100644
--- a/sound/so
note: ret is initialized
int ret = -ENODEV;
^
sound/soc/fsl/mpc8610_hpcd.c:333:6: note: ret is overwritten
ret = fsl_asoc_get_dma_channel(np, "fsl,playback-dma",
^
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/mpc8610_hpcd.c | 2 +-
1 file changed, 1 insertion(+), 1 del
cppcheck warning:
sound/soc/fsl/fsl_esai.c:307:16: style: Clarify calculation precedence
for '%' and '?'. [clarifyCalculation]
clk_id % 2 ? "extal" : "fsys");
^
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl_esai.c | 2 +-
1 file change
: Variable 'size' is assigned
a value that is never used. [unreadVariable]
int size = 0;
^
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl_easrc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/fsl/fsl_easrc.c b/sound/soc/fsl/fsl_easrc.c
index
modified. All the tests can be removed.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl_ssi.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index 57811743c294..c57d0428c0a3 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b
cppcheck warning:
sound/soc/fsl/fsl_asrc.c:613:8: style: Variable 'i' is assigned a
value that is never used. [unreadVariable]
int i = 0, j = 0;
^
The same issue occurs for the 'j' variable.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl_asrc.c | 2 +-
1 file changed, 1
Nothing critical and no functional changes.
The only change that needs attention if the 'fsl_ssi: remove
unnecessary tests' patch, where variables are to zero, then tested to
set register fields. Either the tests are indeed redundant or the
entire programming sequence is incorrect.
Pierre-Louis
ion as well.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl_dma.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/sound/soc/fsl/fsl_dma.c b/sound/soc/fsl/fsl_dma.c
index e0c39c5f4854..84bd8a5356eb 100644
--- a/sound/soc/fsl/fsl_dma.c
+++ b/sound/soc/fsl/fsl_dma.c
@@ -392,7 +39
It seems you are in a different solution-space, where the codec driver
needs to notify the master of which ports it needs to use?
Correct! As Codec is the place where we have mixer controls ant it can
clearly tell which master ports should be used for that particular
configuration.
And that
On 2/17/21 6:47 AM, Perry Yuan wrote:
Hi Pierre:
On 2021/2/16 22:56, Pierre-Louis Bossart wrote:
+static const struct acpi_device_id privacy_acpi_device_ids[] = {
+ {"PNP0C09", 0},
+ { },
+};
+MODULE_DEVICE_TABLE(acpi, privacy_acpi_device_ids);
+
+static struct platf
+static const struct acpi_device_id privacy_acpi_device_ids[] = {
+ {"PNP0C09", 0},
+ { },
+};
+MODULE_DEVICE_TABLE(acpi, privacy_acpi_device_ids);
+
+static struct platform_driver dell_privacy_platform_drv = {
+ .driver = {
+ .name = PRIVACY_PLATFORM_NAME,
+
On 2/9/21 4:23 PM, Mark Brown wrote:
On Mon, Feb 08, 2021 at 09:06:44AM -0600, Pierre-Louis Bossart wrote:
If you demote this to dev_dbg, we'll have to ask every single user who
reports 'sound is broken' to enable dynamic debug traces. I really don't see
the benefit, this is a clear case
On 2/8/21 2:12 AM, Shengjiu Wang wrote:
This log message should be a debug message, because it
doesn't return directly but continue next loop.
Signed-off-by: Shengjiu Wang
---
sound/soc/soc-pcm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/soc-pcm.c
generates interrupt after it successfully finishes. This is really
overhead, limiting and not really necessary unless we are doing
something special.
We can simply read/write the fifo that should also give exactly
what we need! This will also allow to read/write registers in
interrupt
On 2/1/21 10:39 PM, Vinod Koul wrote:
On 01-02-21, 10:18, Pierre-Louis Bossart wrote:
On 2/1/21 4:38 AM, Vinod Koul wrote:
On 01-02-21, 15:58, Vinod Koul wrote:
On 26-01-21, 16:37, Bard Liao wrote:
struct sdw_master_prop {
u32 revision;
@@ -421,8 +422,11 @@ struct
+ prop->quirks = SDW_MASTER_QUIRKS_CLEAR_INITIAL_CLASH;
Should this not be last 'enabling' the quirk patch in series :)
Sorry, I don't understand the comment. Do you mind clarifying Vinod?
Sure, I would like to series built as, first defining the quirk
along/followed by bus
On 2/1/21 10:18 PM, Vinod Koul wrote:
On 01-02-21, 10:10, Pierre-Louis Bossart wrote:
On 2/1/21 4:14 AM, Vinod Koul wrote:
On 21-01-21, 17:23, Srinivas Kandagatla wrote:
On 21/01/2021 15:12, Pierre-Louis Bossart wrote:
On 1/21/21 6:03 AM, Srinivas Kandagatla wrote:
I totally agree
On 2/1/21 4:42 AM, Vinod Koul wrote:
On 26-01-21, 16:37, Bard Liao wrote:
There is nothing we can do to handle the bus clash interrupt before
interrupt mask is enabled.
Signed-off-by: Bard Liao
Reviewed-by: Rander Wang
Reviewed-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 2
* Set SCP_INT1_MASK register, typically bus clash and
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
index f7ba1a77a1df..c1fdc85d0a74 100644
--- a/drivers/soundwire/intel.c
+++ b/drivers/soundwire/intel.c
@@ -1286,7 +1286,8 @@ static int
struct qcom_swrm_port_config {
u8 si;
u8 off1;
u8 off2;
u8 bp_mode;
+ u8 hstart;
+ u8 hstop;
+ u8 word_length;
+ u8 bgp_count;
I couldn't figure out what 'bgp' was and had to search. Not sure how
you came up with this abbreviation of
On 2/1/21 9:50 AM, Srinivas Kandagatla wrote:
On 29/01/2021 19:33, Pierre-Louis Bossart wrote:
On 1/29/21 11:32 AM, Srinivas Kandagatla wrote:
In the existing code every soundwire register read and register write
are kinda blocked. Each of these are using a special command id
On 2/1/21 4:38 AM, Vinod Koul wrote:
On 01-02-21, 15:58, Vinod Koul wrote:
On 26-01-21, 16:37, Bard Liao wrote:
struct sdw_master_prop {
u32 revision;
@@ -421,8 +422,11 @@ struct sdw_master_prop {
u32 err_threshold;
u32 mclk_freq;
bool hw_disabled;
+
On 2/1/21 4:14 AM, Vinod Koul wrote:
On 21-01-21, 17:23, Srinivas Kandagatla wrote:
On 21/01/2021 15:12, Pierre-Louis Bossart wrote:
On 1/21/21 6:03 AM, Srinivas Kandagatla wrote:
On 19/01/2021 19:09, Pierre-Louis Bossart wrote:
currently we have
/sys/kernel/debug/soundwire/master
On 1/29/21 11:32 AM, Srinivas Kandagatla wrote:
Add support to new interrupts and update irq routine in a way
to deal with multiple pending interrupts with in a single interrupt!
I can't parse the wording after 'update irq routine'.
+ swrm->reg_write(swrm, SWRM_INTERRUPT_CLEAR,
On 1/29/21 11:32 AM, Srinivas Kandagatla wrote:
In the existing code every soundwire register read and register write
are kinda blocked. Each of these are using a special command id that
what does 'kinda blocked' mean?
generates interrupt after it successfully finishes. This is really
On 1/29/21 11:32 AM, Srinivas Kandagatla wrote:
version 1.5.1 and higher IPs of this controller required to set
continue execution on ingored command flag. This patch sets this flag.
typo: ignored.
struct qcom_swrm_port_config {
u8 si;
u8 off1;
u8 off2;
u8 bp_mode;
+ u8 hstart;
+ u8 hstop;
+ u8 word_length;
+ u8 bgp_count;
I couldn't figure out what 'bgp' was and had to search. Not sure how you
came up with this abbreviation of
No, what I was saying is that you need to define multiple streams e.g.
- headset capture (configured with or without click suppression)
- mic capture (configured with AMICs or DMICs)
- playback (or possibly different endpoint specific streams depending
on whether concurrency between endpoint
On 1/22/21 1:05 AM, Srinivas Kandagatla wrote:
On 21/01/2021 21:30, Pierre-Louis Bossart wrote:
Am looking at intel_hw_params(). Isn't sdw_stream_add_master() called
for every dai in the dai link.
Yes, that's correct, but again a dai may use one or more ports.
if you defined each port
[SLAVE]---[MASTER]
NA-Port 1: PCM
Port 1-Port 2: ADC 1 & 2
Port 2-Port 3: ADC 3 & 4
Port 3-Port 4: DMIC-0, DMIC-1, DIMC-2 , DMIC-3 and MBHC
Port 4-Port 5: DMIC-4, DMIC-5, DMIC-6 and DMIC-7
Mapping is still static however Number of ports
diff --git a/drivers/soundwire/debugfs.c b/drivers/soundwire/debugfs.c
index b6cad0d59b7b..f22868614f09 100644
--- a/drivers/soundwire/debugfs.c
+++ b/drivers/soundwire/debugfs.c
@@ -19,13 +19,14 @@ void sdw_bus_debugfs_init(struct sdw_bus *bus)
return;
/* create
On 1/21/21 9:41 AM, Srinivas Kandagatla wrote:
On 21/01/2021 14:56, Pierre-Louis Bossart wrote:
Port allocations are something like this:
RX: (Simple)
Port 1 -> HPH L/R
Port 2 -> CLASS H Amp
Port 3 -> COMP
Port 4 -> DSD.
TX: (This get bit more complicated)
Port 1: PCM
P
On 1/21/21 6:03 AM, Srinivas Kandagatla wrote:
On 19/01/2021 19:09, Pierre-Louis Bossart wrote:
currently we have
/sys/kernel/debug/soundwire/master-*
Are you suggesting that we have something like this:
/sys/kernel/debug/soundwire/xyz-controller/master- ??
Yes this is what I
Port allocations are something like this:
RX: (Simple)
Port 1 -> HPH L/R
Port 2 -> CLASS H Amp
Port 3 -> COMP
Port 4 -> DSD.
TX: (This get bit more complicated)
Port 1: PCM
Port 2: ADC 1 & 2
Port 3: ADC 3 & 4
Port 4: DMIC-0, DMIC-1, DIMC-2 , DMIC-3 and MBHC
Port 5: DMIC-4, DMIC-5, DMIC-6
On 1/20/21 12:01 PM, Srinivas Kandagatla wrote:
Some of the soundwire controllers can have static functions assigned
to each port, like some ports can only do PCM or PDM. This is the situation
with some of the Qualcomm Controllers.
In such cases its not correct to assign/map any free port on
On 1/20/21 9:49 AM, Łukasz Majczak wrote:
Hi Pierre,
Is there anything more to do to get the ACK for this patch?
Adding Cezary and Amadeusz for feedback, I can't pretend having any sort
of knowledge on the Skylake driver internals and topology usage.
Best regards,
Lukasz
wt., 12 sty
link_id can be zero and if we have multiple controller instances
in a system like Qualcomm debugfs will end-up with duplicate namespace
resulting in incorrect debugfs entries.
Using id should give a unique debugfs directory entry and should fix
below
warning too.
"debugfs: Directory
On 1/19/21 8:52 AM, Vinod Koul wrote:
On 15-01-21, 16:25, Srinivas Kandagatla wrote:
link_id can be zero and if we have multiple controller instances
in a system like Qualcomm debugfs will end-up with duplicate namespace
resulting in incorrect debugfs entries.
Using id should give a unique
On 1/14/21 3:19 PM, Arnd Bergmann wrote:
On Thu, Jan 14, 2021 at 7:07 PM Pierre-Louis Bossart
wrote:
On 1/14/21 9:09 AM, Arnd Bergmann wrote:
On Tue, Jan 12, 2021 at 9:32 PM Arnd Bergmann wrote:
---
v2: fix various build issues in the first version, now passes
all randconfig builds
On 1/14/21 9:09 AM, Arnd Bergmann wrote:
On Tue, Jan 12, 2021 at 9:32 PM Arnd Bergmann wrote:
---
v2: fix various build issues in the first version, now passes
all randconfig builds I tried
Please disregard this version, while I have a tree that passes
the randconfig builds now,
uld
be a no-op. I agree with @Pierre-Louis Bossart in this case, we should just be
running it whether or not dell-privacy is compiled in. If another vendor
chooses to add LED support they'll just need to set up their ledtrig supported
backend and not change codec code.
Hi @Pierre-Louis Bossart
Since this is going to be a really invasive change, and past
experience shows that mucking with Kconfigs will invariably raise a
number of broken corner cases, if there is support from
Mark/Takashi/Jaroslav on this idea, we should first test it in the SOF
tree so that we get a good test
On 1/12/21 2:32 PM, Arnd Bergmann wrote:
From: Arnd Bergmann
The Kconfig logic around SND_SOC_SOF_INTEL_SOUNDWIRE tries to
ensure that all sound modules can be built with the minimal
dependencies, but this fails in some configurations:
x86_64-linux-ld: sound/hda/intel-dsp-config.o: in
On 1/12/21 11:17 AM, Perry Yuan wrote:
From: Perry Yuan
add support for dell privacy driver for the dell units equipped
hardware privacy design, which protect users privacy of audio and
camera from hardware level. once the audio or camera privacy mode
enabled, any applications will not get
On 1/5/21 1:07 PM, Arnd Bergmann wrote:
From: Arnd Bergmann
The SOF-ACPI driver is backwards from the normal Linux model, it has a
generic driver that knows about all the specific drivers, as opposed to
having hardware specific drivers that link against a common framework.
This requires
@@ -268,6 +269,7 @@ static int rt715_sdca_put_volsw(struct snd_kcontrol
*kcontrol,
unsigned int reg2 = mc->rreg;
unsigned int reg = mc->reg;
unsigned int max = mc->max;
+ unsigned int val0, val1;
int err;
val = ucontrol->value.integer.value[0];
despite being
non CR does not work
3. Despite 1. and 2. still have their IPC IRQ at index 0 rather then 5
Add a DMI quirk table to check for the few known models with this issue,
so that the right IPC IRQ index is used on these systems.
Signed-off-by: Hans de Goede
Acked-by: Pierre-Louis
+ return ret;
+ }
+
+ ret = snd_soc_component_set_sysclk(codec_component, ARIZONA_CLK_OPCLK,
0,
+ rate * sr_mult, SND_SOC_CLOCK_OUT);
+ if (ret) {
+ dev_err(codec_component->dev, "Error setting OPCLK:
On 12/15/20 10:16 PM, Chris Chiu wrote:
DeeQ X5-Z8300 is a laptop empowered by Intel Atom Cherry Trail. Add
quirks to select the correct input map, jack-detect options to enable
jack sensing and internal/headset microphones.
Signed-off-by: Chris Chiu
You probably need to re-send and CC:
.
This device uses IN1 for its internal MIC and JD2 for jack-detect.
Signed-off-by: Chris Chiu
Acked-by: Pierre-Louis Bossart
---
sound/soc/intel/boards/bytcr_rt5640.c | 12
1 file changed, 12 insertions(+)
diff --git a/sound/soc/intel/boards/bytcr_rt5640.c
b/sound/soc/intel/boards
On 12/6/20 10:43 PM, Vinod Koul wrote:
On 05-12-20, 08:59, Pierre-Louis Bossart wrote:
Thanks for the review Vinod.
On 12/5/20 1:45 AM, Vinod Koul wrote:
On 03-12-20, 04:46, Bard Liao wrote:
From: Pierre-Louis Bossart
When a Slave device is resumed, it may resume the bus and restart
Thanks for the review Vinod.
On 12/5/20 1:45 AM, Vinod Koul wrote:
On 03-12-20, 04:46, Bard Liao wrote:
From: Pierre-Louis Bossart
When a Slave device is resumed, it may resume the bus and restart the
enumeration. During that process, we absolutely don't want to call
regular read/write
-static int sdw_write_no_pm(struct sdw_slave *slave, u32 addr, u8 value)
+int sdw_write_no_pm(struct sdw_slave *slave, u32 addr, u8 value)
{
return sdw_nwrite_no_pm(slave, addr, 1, );
}
+EXPORT_SYMBOL(sdw_write_no_pm);
Why not export this is patch 1..?
yes, good point. I guess
MODULE_DESCRIPTION("Regmap SoundWire MBQ Module");
-MODULE_LICENSE("GPL v2");
+MODULE_LICENSE("GPL");
Why do you want to change this ?
We only use MODULE_LICENSE("GPL") for new contributions since 'GPL v2'
does not bring any information on the license, is equivalent to 'GPL'
and only
-by: Pierre-Louis Bossart
---
drivers/acpi/fan.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c
index 66c3983f0ccc..9cab806298ff 100644
--- a/drivers/acpi/fan.c
+++ b/drivers/acpi/fan.c
@@ -357,6 +357,7 @@ static int acpi_fan_get_fps(struct acpi_device *device
"soundwire: intel: add pm_runtime support")
Signed-off-by: Arnd Bergmann
Thanks for the patch Arnd, indeed that's a miss.
Reviewed-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/soundwi
-by: Pierre-Louis Bossart
+struct {
+ unsigned int tx;
+ unsigned int rx;
+} rt1011_tdm_mask[] = {
+ {.tx = 0x4, .rx = 0x1},
+ {.tx = 0x8, .rx = 0x2},
+};
as noted in the GitHub review this should be static and possibly const.
On 11/30/20 10:11 PM, Vinod Koul wrote:
On 01-12-20, 02:42, Liao, Bard wrote:
Hi Vinod/Mark,
Could we take this series into Vinod's tree with Mark's Acked-by?
It failed to build on Mark's tree.
I see Mark has already applied 1-3 ..
Sorry, I thought Mark had reversed the entire series.
.
The test covers a very unlikely error scenario but nevertheless not a
zero probability so the suggested fix makes sense to me.
Reviewed-by: Pierre-Louis Bossart
---
drivers/soundwire/generic_bandwidth_allocation.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers
On 11/30/20 12:17 PM, Mark Brown wrote:
On Wed, Nov 04, 2020 at 01:22:26AM +0800, Bard Liao wrote:
From: Shuming Fan
This is the initial codec driver for rt711 SDCA version.
This and the rt1316 change are failing to build for me on both the
regmap tree and a merge of this branch into the
I'll drop this, hopefully it can be re-added in future.
We fixed this problem in October, must be a patch that wasn't merged while
upstreaming. If you give me 2-3 hours I can send the fix.
I already pushed out the revert (but we can re-apply), and I'm also
about to send another mail
On 11/30/20 11:59 AM, Mark Brown wrote:
On Fri, Nov 27, 2020 at 06:24:11PM +1100, Stephen Rothwell wrote:
Caused by commit
6f4a038b9967 ("ASoC/SoundWire: rt715-sdca: First version of rt715 sdw sdca codec
driver")
I have reverted that commit for today.
I'll drop this, hopefully it can
on x86_64:
ld: sound/soc/sof/sof-pci-dev.o: in function `sof_pci_probe':
sof-pci-dev.c:(.text+0x5c): undefined reference to `snd_intel_dsp_driver_probe'
Full randconfig file is attached.
Nice catch, thanks Randy! Looks like we put the select
SND_INTEL_DSP_CONFIG in the wrong place, it's
+module_init(auxiliary_bus_init);
+module_exit(auxiliary_bus_exit);
+
+MODULE_LICENSE("GPL");
Per above SPDX is v2 only, so...
MODULE_LICENSE("GPL v2");
added v2.
"GPL v2" is the same as "GPL" here, it does not have any additional meaning.
.
For the series,
Reviewed-by: Pierre-Louis Bossart
101 - 200 of 1453 matches
Mail list logo
