On 9/16/19 2:23 PM, Pierre-Louis Bossart wrote:
These patches were originally submitted as '[RFC PATCH 00/11]
soundwire: intel: simplify DAI/PDI handling'. There were no comments
received.
This series only provides the PDI changes, which makes it simpler to
review. The DAI changes
On 10/14/19 4:04 AM, Srinivas Kandagatla wrote:
Thanks Pierre for taking time to review the patch.
On 11/10/2019 18:50, Pierre-Louis Bossart wrote:
+static int qcom_swrm_cmd_fifo_wr_cmd(struct qcom_swrm_ctrl *ctrl, u8
cmd_data,
+ u8 dev_addr, u16 reg_addr
'
Reported-by: Hulk Robot
Fixes: 5d43001ae436 ("ASoC: SOF: acpi led support for switch controls")
Signed-off-by: YueHaibing
Thanks for the fix.
Acked-by: Pierre-Louis Bossart
---
sound/soc/sof/control.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/sof/control.c b/sou
+static int qcom_swrm_cmd_fifo_wr_cmd(struct qcom_swrm_ctrl *ctrl, u8 cmd_data,
+u8 dev_addr, u16 reg_addr)
+{
+ DECLARE_COMPLETION_ONSTACK(comp);
+ unsigned long flags;
+ u32 val;
+ int ret;
+
+ spin_lock_irqsave(>comp_lock,
I still need to figure out prefixing multiple instances of this
Amplifier controls with "Left" and "Right"
FWIW we use the "snd_codec_conf" stuff to add a prefix for each
amplifier, so that the controls are not mixed up between instances of
the same amp, see e.g.
static struct
It's been a while since this thread started, and I still don't
quite get the concepts or logic.
First, I don't understand what the problem with "aux" devices is.
All the SoundWire stuff is based on the concept of DAI, so I guess
I am
That is the actual problem! Some aux devices does not
On 10/9/19 11:01 AM, Srinivas Kandagatla wrote:
On 09/10/2019 15:29, Pierre-Louis Bossart wrote:
On 10/9/19 3:32 AM, Srinivas Kandagatla wrote:
Hi Pierre,
On 14/08/2019 15:09, Pierre-Louis Bossart wrote:
On 8/13/19 11:11 PM, Vinod Koul wrote:
On 13-08-19, 20:58, Mark Brown wrote
On 10/9/19 3:32 AM, Srinivas Kandagatla wrote:
Hi Pierre,
On 14/08/2019 15:09, Pierre-Louis Bossart wrote:
On 8/13/19 11:11 PM, Vinod Koul wrote:
On 13-08-19, 20:58, Mark Brown wrote:
On Tue, Aug 13, 2019 at 02:38:53PM -0500, Pierre-Louis Bossart wrote:
Indeed. I don't have a full
On 10/2/19 3:33 AM, Michal Suchanek wrote:
Now devicetree is supposrted for probing sondwire as well.
typos...
also it'd be simpler to squash the two patches together and add in the
commit message a mention that the s390 builds without ACPI and without OF.
Fixes: a2e484585ad3
On 10/1/19 10:41 AM, Arnd Bergmann wrote:
On Tue, Oct 1, 2019 at 5:32 PM Pierre-Louis Bossart
wrote:
On 10/1/19 9:20 AM, Arnd Bergmann wrote:
CONFIG_SND_SOC_SOF_IMX depends on CONFIG_SND_SOC_SOF, but is in
turn referenced by the sof-of-dev driver. This creates a reverse
dependency
On 10/1/19 9:20 AM, Arnd Bergmann wrote:
CONFIG_SND_SOC_SOF_IMX depends on CONFIG_SND_SOC_SOF, but is in
turn referenced by the sof-of-dev driver. This creates a reverse
dependency that manifests in a link error when CONFIG_SND_SOC_SOF_OF
is built-in but CONFIG_SND_SOC_SOF_IMX=m:
On 9/27/19 3:39 PM, Andy Shevchenko wrote:
On Fri, Sep 27, 2019 at 7:39 PM Pierre-Louis Bossart
wrote:
The problem with solution #1 is freeing orphaned pointer. It will work,
but it's simple is not okay from object life time prospective.
?? I don't get your point at all Andy.
Two allocations
The problem with solution #1 is freeing orphaned pointer. It will work,
but it's simple is not okay from object life time prospective.
?? I don't get your point at all Andy.
Two allocations happens in a loop and if the second fails, you free the
first and then jump to free everything
On 9/26/19 9:55 PM, Navid Emamdoost wrote:
On Wed, Sep 25, 2019 at 12:05:28PM -0500, Pierre-Louis Bossart wrote:
On 9/25/19 11:19 AM, Navid Emamdoost wrote:
In snd_skl_parse_uuids if allocation for module->instance_id fails, the
allocated memory for module shoulde be released. I chan
On 9/25/19 11:19 AM, Navid Emamdoost wrote:
In snd_skl_parse_uuids if allocation for module->instance_id fails, the
allocated memory for module shoulde be released. I changes the
allocation for module to use devm_kzalloc to be resource_managed
allocation and avoid the release in error path.
if
On 9/18/19 8:54 AM, Greg KH wrote:
On Wed, Sep 18, 2019 at 03:53:02PM +0200, Greg KH wrote:
On Wed, Sep 18, 2019 at 08:48:33AM -0500, Pierre-Louis Bossart wrote:
On 9/18/19 7:06 AM, Greg KH wrote:
On Tue, Sep 17, 2019 at 09:29:52AM -0500, Pierre-Louis Bossart wrote:
On 9/17/19 12:55 AM, Greg
On 9/18/19 7:06 AM, Greg KH wrote:
On Tue, Sep 17, 2019 at 09:29:52AM -0500, Pierre-Louis Bossart wrote:
On 9/17/19 12:55 AM, Greg KH wrote:
On Mon, Sep 16, 2019 at 04:23:41PM -0500, Pierre-Louis Bossart wrote:
+/**
+ * sdw_intel_probe() - SoundWire Intel probe routine
+ * @parent_handle
On 9/17/19 5:38 AM, Mark Brown wrote:
After merging the sound-current tree, today's linux-next build for x86
allmodconfig failed like this:
In file included from
/home/broonie/next/next/sound/soc/intel/boards/sof_rt5682.c:23:
On 9/17/19 12:55 AM, Greg KH wrote:
On Mon, Sep 16, 2019 at 04:23:41PM -0500, Pierre-Louis Bossart wrote:
+/**
+ * sdw_intel_probe() - SoundWire Intel probe routine
+ * @parent_handle: ACPI parent handle
+ * @res: resource data
+ *
+ * This creates SoundWire Master and Slave devices below
From: Rander Wang
Make sure all calls to the SoundWire stream API are done and involve
callback
Signed-off-by: Rander Wang
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 21 +++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/drivers
These callbacks are invoked when a matching hw_params/hw_free() DAI
operation takes place, and will result in IPC operations with the SOF
firmware.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/sof/intel/hda.c | 70 +++
1 file changed, 70 insertions
From: Rander Wang
The sdw stream is allocated and stored in dai to share the sdw runtime
information.
Signed-off-by: Rander Wang
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 65 +++
1 file changed, 65 insertions(+)
diff --git
ALH was inserted in the wrong place during integration, add after DMIC
to mirror the file used by SOF firmware.
No functional change, just text move in the same file to better track
changes, if any.
Signed-off-by: Pierre-Louis Bossart
---
include/sound/sof/dai-intel.h | 18
Select SoundWire capabilities on newer Intel platforms, starting with
CannonLake/CoffeeLake/CometLake.
As done for HDaudio, the SoundWire link is an opt-in capability. We
explicitly test for ACPI to avoid warnings on unmet dependencies on
the SoundWire side.
Signed-off-by: Pierre-Louis Bossart
From: Rander Wang
Sdw stream is enabled and disabled in trigger function.
Signed-off-by: Rander Wang
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 39 +++
1 file changed, 39 insertions(+)
diff --git a/drivers/soundwire/intel.c b
since we don't know when those devices might become attached, so will
only be only be looked at if we see limitations with static methods
and the usual quirks based e.g. on DMI information.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/sof/intel/hda.c | 58
being
the default is to startup the IP after the firmware is downloaded.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/sof/intel/hda-loader.c | 9 ++
sound/soc/sof/intel/hda.c| 155 +++
sound/soc/sof/intel/hda.h| 36 +++
3 files changed, 200
From: Rander Wang
It gets sdw runtime information from dai to prepare stream.
Signed-off-by: Rander Wang
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire
For cases where an interface can be pin-muxed, we need to assess at
probe time which configuration should be used. In cases such as
SoundWire, we need to maintain an alternate list of machines and walk
through them when the primary detection based on ACPI _HID fails.
Signed-off-by: Pierre-Louis
the link_id and alh_stream_id parameters which are needed to align
with firmware IPC needs.
Signed-off-by: Rander Wang
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 39 +++-
drivers/soundwire/intel_init.c | 2 +-
include/linux/soundwire
that configurations where multiple links are
required need to be checked first.
Additional criteria will be needed later, such as which SoundWire
Slave devices are actually enabled, but for now this helps detect
between basic configurations.
Signed-off-by: Pierre-Louis Bossart
---
include/sound/soc
on CML/ICL, initialization and
playback/capture worked fine, but we observed a reproducible system
freeze while doing load/unload tests, so likely an initialization
missing or a leak to be fixed.
Comments and feedback welcome.
Pierre-Louis Bossart (7):
ASoC: soc-acpi: add link_mask field
ASoC
From: Bard Liao
Setting an device driver is necessary for ASoC to register DAI
components.
Signed-off-by: Bard Liao
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 4
drivers/soundwire/master.c| 2 ++
include/linux/soundwire/sdw.h | 1 +
3 files changed, 7
Since we want an explicit support for the SoundWire Master device, add
the definitions, following the Grey Bus example.
Open: do we need to set a variable when dealing with the master uevent?
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/Makefile | 2 +-
drivers/soundwire
ster setup.
The data structures are also consolidated in a single file and
comments added to help follow what is used for what.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 90 +
drivers/soundwire/intel.h | 22 +--
drivers/soundwire/intel_init.c
There are too many fields called 'res' so add prefix to make it easier
to track what the structures are.
Pure rename, no functionality change
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 37 +++--
1 file changed, 19 insertions(+), 18
Currently the bus does not have any explicit support for master
devices. Add explicit support for sdw_slave_type, so that in
follow-up patches we can add support for the sdw_md_type (md==Master
Device), following the Grey Bus example.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire
Before we add master driver support, make sure there is no ambiguity
and no occirrences of sdw_drv_ functions.
No functionality change.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus_type.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers
Add clearer references to sdw_slave_driver for internal macros
No change for sdw_driver and module_sdw_driver to avoid compatibility
issues with existing codec devices
No functionality change.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus_type.c | 21
Align with previous renames and shorten macro
No functionality change
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus_type.c | 9 -
include/linux/soundwire/sdw_type.h | 3 ++-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/soundwire
Since we want to introduce master devices, rename macro so that we
have consistency between slave and master device access, following the
Grey Bus example.
Signed-off-by: Pierre-Louis Bossart
---
drivers/base/regmap/regmap-sdw.c | 4 ++--
drivers/soundwire/bus.c | 2 +-
drivers
as there is a means to clearly
identify what is specific to a SoundWire Master I am fine.
Feedback and reviews welcome.
Bard Liao (1):
soundwire: add device driver to sdw_md_driver
Pierre-Louis Bossart (8):
soundwire: renames to prepare support for master drivers/devices
soundwire: rename dev_to_sdw_dev
From: Bard Liao
PDI number should match dai->id, there is no need to track if a PDI is
allocated or not.
Signed-off-by: Bard Liao
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/cadence_master.c | 27 ++-
drivers/soundwire/cadence_master.h | 4 +---
driv
From: Bard Liao
We will create dai widget in SOF.
Signed-off-by: Bard Liao
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 17 -
1 file changed, 17 deletions(-)
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
index c158a1d19a05
for further simplifications where the PDIs are
not dynamically allocated but instead described in a topology file.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/cadence_master.c | 110
drivers/soundwire/cadence_master.h | 32 ++-
drivers/soundwire/intel.c
unless we have to remove the smarts.
This patch requires a topology change to use PDIs starting at offset 2
explicitly.
Note that there is a known discrepancy between hardware documentation
and what ALH stream works in practice, future fixes are likely.
Signed-off-by: Pierre-Louis Bossart
integration, which is a larger change.
Bard Liao (3):
soundwire: intel: fix intel_register_dai PDI offsets and numbers
soundwire: intel: remove playback/capture stream_name
soundwire: cadence_master: improve PDI allocation
Pierre-Louis Bossart (3):
soundwire: remove DAI_ID_RANGE definitions
There is no reason to reserve a range of DAI IDs for SoundWire. This
is not scalable and it's better to let the ASoC core allocate the
dai->id when registering a component.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 2 --
include/linux/soundwire/sdw.h | 3 ---
DIs. Again this was not detected since PDM was not supported earlier.
Reported-by: Ranjani Sridharan
Signed-off-by: Bard Liao
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/intel.c b/driv
Prepare for future PM support and fix error handling by disabling
interrupts as needed.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/cadence_master.c | 18 --
drivers/soundwire/cadence_master.h | 2 +-
drivers/soundwire/intel.c | 12 +++-
3 files
Move code to helper for reuse in power management routines
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
index 57e599919479
. flush command FIFOs
Better error handling will be provided after interrupt disable is
provided in follow-up patches.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/cadence_master.c | 80 +-
drivers/soundwire/cadence_master.h | 1 +
drivers/soundwire/intel.c
-Louis Bossart
---
drivers/soundwire/cadence_master.c | 15 ---
drivers/soundwire/cadence_master.h | 2 +-
drivers/soundwire/intel.c | 2 +-
3 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/soundwire/cadence_master.c
b/drivers/soundwire/cadence_master.c
interrupts when exit_reset fails, updated error handling
returned -EINVAL on debugfs invalid parameter
Pierre-Louis Bossart (5):
soundwire: intel/cadence: fix startup sequence
soundwire: cadence_master: add hw_reset capability in debugfs
soundwire: intel: add helper for initialization
Provide debugfs capability to kick link and devices into hard-reset
(as defined by MIPI). This capability is really useful when some
devices are no longer responsive and/or to check the software handling
of resynchronization.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire
This is not needed and may generate unmet dependencies when
COMPILE_TEST is used for SOF.
ACPI is required, and should be tested when selecting this option.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
readl/writel and ioread32 are used without the relevant headers, fix.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 1 +
drivers/soundwire/intel_init.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
index
The Intel kbuild test reported issues with COMPILE_TEST or
cross-compilation when SOF is enabled, fix. This has no functional
impact.
Pierre-Louis Bossart (2):
soundwire: intel: add missing headers for cross-compilation
soundwire: intel: remove X86 dependency
drivers/soundwire/Kconfig
@@ -1043,8 +1043,6 @@ static int intel_probe(struct platform_device
*pdev)
if (ret)
goto err_init;
- ret = sdw_cdns_enable_interrupt(>cdns);
-
/* Read the PDI config and initialize cadence PDI */
intel_pdi_init(sdw, );
ret = sdw_cdns_pdi_init(>cdns,
error and if yes can you share more information to help check
where the problem happens, topology maybe?
Pierre-Louis Bossart <mailto:pierre-louis.boss...@linux.intel.com>> 於 2019年9月12日 週四 下
午9:02寫道：
On 9/11/19 9:27 PM, Yu-Hsuan Hsu wrote:
> 24 bits recordi
On 9/12/19 1:00 AM, Lu, Brent wrote:
The story is Chrome has a tool called alsa_conformance_test which runs
capture or playback against a PCM port with all possible
configurations (channel, format, rate) then measure if the sample rate
is correct. Since the channel max number reported is 4, it
On 9/11/19 9:27 PM, Yu-Hsuan Hsu wrote:
24 bits recording from DMIC is not supported for KBL platform because
the TDM slot between PCH and codec is 16 bits only. We should add a
constraint to remove that unsupported format.
Humm, when you use DMICs they are directly connected to the PCH with a
I also don't see any case where we support 4 channels in any broadwell
machine driver?
It's the bdw-rt5650.c which only exists in chrome's 3.14 branch supporting Buddy
project. They submitted the machine driver but not yet merged.
https://patchwork.kernel.org/patch/11050985/
So again can
On 9/9/19 2:51 PM, Arnd Bergmann wrote:
When CONFIG_SND_HDA_ALIGNED_MMIO is selected by another driver
(i.e. Tegra) that selects CONFIG_SND_HDA_CORE as a loadable
module, but SND_SOC_SOF_HDA_COMMON is built-in, we get a
link failure from some functions that access the hda register:
hange older
platforms when there is evidence that a change is needed.
-Pierre
Regards,
Brent Lu
-Original Message-----
From: Pierre-Louis Bossart [mailto:pierre-louis.boss...@linux.intel.com]
Sent: Friday, September 6, 2019 10:21 PM
To: Lu, Brent ; alsa-de...@alsa-project.org
Cc: Rojewski,
On 9/5/19 8:24 PM, Brent Lu wrote:
BDW boards using this machine driver supports only stereo capture and
playback. Implement a constraint to enforce it.
Humm, can you clarify what problem/error this patch fixes?
There are already constraints on the hsw_dais[] where the channels are
stereo
;ASoC: SOF: imx: Add i.MX8 HW support")
Signed-off-by: YueHaibing
Reviewed-by: Pierre-Louis Bossart
---
sound/soc/sof/imx/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/sof/imx/Kconfig b/sound/soc/sof/imx/Kconfig
index fd73d84..5acae75 100644
-
On 9/4/19 11:55 AM, Vinod Koul wrote:
On 04-09-19, 08:31, Pierre-Louis Bossart wrote:
On 9/4/19 2:35 AM, Vinod Koul wrote:
On 22-08-19, 08:53, Pierre-Louis Bossart wrote:
Thanks for the review Guennadi
+static int sdw_config_stream(void *arg, void *s, void *dai
On 9/4/19 11:51 AM, Vinod Koul wrote:
On 04-09-19, 08:25, Pierre-Louis Bossart wrote:
On 9/4/19 2:21 AM, Vinod Koul wrote:
On 21-08-19, 15:17, Pierre-Louis Bossart wrote:
The Core0 needs to be powered before the SoundWire IP is initialized.
Call sdw_intel_init/exit and store the context
On 9/4/19 11:49 AM, Vinod Koul wrote:
On 04-09-19, 08:18, Pierre-Louis Bossart wrote:
On 9/4/19 2:13 AM, Vinod Koul wrote:
On 13-08-19, 16:32, Pierre-Louis Bossart wrote:
Provide debugfs capability to kick link and devices into hard-reset
(as defined by MIPI). This capability is really
On 9/4/19 4:28 AM, Vinod Koul wrote:
On 13-08-19, 09:35, Srinivas Kandagatla wrote:
From: Vinod Koul
This callback allows masters to compute the bus parameters required.
Applied this to help manage cross dependencies with various folks better, thanks
Meh. doesn't really help, see my
On 9/4/19 2:35 AM, Vinod Koul wrote:
On 22-08-19, 08:53, Pierre-Louis Bossart wrote:
Thanks for the review Guennadi
+static int sdw_config_stream(void *arg, void *s, void *dai,
+void *params, int link_id, int alh_stream_id)
I realise, that these function
On 9/4/19 2:21 AM, Vinod Koul wrote:
On 21-08-19, 15:17, Pierre-Louis Bossart wrote:
The Core0 needs to be powered before the SoundWire IP is initialized.
Call sdw_intel_init/exit and store the context. We only have one
context, but depending on the hardware capabilities and BIOS settings
may
On 9/4/19 2:13 AM, Vinod Koul wrote:
On 13-08-19, 16:32, Pierre-Louis Bossart wrote:
Provide debugfs capability to kick link and devices into hard-reset
(as defined by MIPI). This capability is really useful when some
devices are no longer responsive and/or to check the software handling
On 9/4/19 2:11 AM, Vinod Koul wrote:
On 13-08-19, 16:32, Pierre-Louis Bossart wrote:
Multiple changes squashed in single patch to avoid tick-tock effect.
1. Per the hardware documentation, all changes to MCP_CONFIG,
MCP_CONTROL, MCP_CMDCTRL and MCP_PHYCTRL need to be validated with a
self
On 8/29/19 1:11 PM, Bard liao wrote:
From: Bard Liao
port_status[port_num] are assigned for each port_num in some if
conditions. So some of the port_status may not be initialized.
Reviewed-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 2 +-
1 file
ve udelay explicitly set here instead of in
the caller below for consistency with the comments.
+ wsa881x_ramp_pa_gain(comp, min_gain, max_gain, 1000);
But apart from that I didn't see anything blatantly wrong, so
Reviewed-by: Pierre-Louis Bossart
On 8/29/19 10:08 AM, Takashi Iwai wrote:
On Thu, 29 Aug 2019 00:45:05 +0200,
Pierre-Louis Bossart wrote:
I just checked with Mark Brown's for-next tree
8aceffa09b4b9867153bfe0ff6f40517240cee12
and things are fine in i386 mode, see below.
next-20190828 also works fine for me in i386 mode
I just checked with Mark Brown's for-next tree
8aceffa09b4b9867153bfe0ff6f40517240cee12
and things are fine in i386 mode, see below.
next-20190828 also works fine for me in i386 mode.
if you can point me to a tree and configuration that don't work I'll
look into this, I'd need more info to
On 8/28/19 4:06 PM, Randy Dunlap wrote:
On 8/28/19 12:28 PM, Pierre-Louis Bossart wrote:
On 8/28/19 1:30 PM, Randy Dunlap wrote:
(from linux-next tree, but problem found/seen in mmotm)
Sorry, I don't know who is responsible for this driver.
That would be me.
I just checked
On 8/28/19 1:30 PM, Randy Dunlap wrote:
On 8/27/19 8:40 PM, a...@linux-foundation.org wrote:
The mm-of-the-moment snapshot 2019-08-27-20-39 has been uploaded to
http://www.ozlabs.org/~akpm/mmotm/
mmotm-readme.txt says
README for mm-of-the-moment:
http://www.ozlabs.org/~akpm/mmotm/
: Intel: NHLT: Fix debug print format
LGTM
Reviewed-by: Pierre-Louis Bossart
include/sound/soc-dapm.h | 3 +++
sound/soc/intel/common/sst-ipc.c | 2 ++
sound/soc/intel/skylake/skl-debug.c| 2 +-
sound/soc/intel/skylake/skl-messages.c | 5 +++--
sound/soc/intel
+title: SoundWire Controller Generic Binding
+
+maintainers:
+ - Srinivas Kandagatla
+
+description: |
+ SoundWire busses can be described with a node for the SoundWire
controller
+ device and a set of child nodes for each SoundWire slave on the
bus.
+
+properties:
+ $nodename:
+
On 8/23/19 10:57 AM, Srinivas Kandagatla wrote:
On 23/08/2019 16:41, Pierre-Louis Bossart wrote:
On 8/22/19 6:37 PM, Srinivas Kandagatla wrote:
This patch adds bindings for Soundwire Slave devices that includes how
SoundWire enumeration address and Link ID are used to represented
+void intel_shutdown(struct snd_pcm_substream *substream,
+ struct snd_soc_dai *dai)
+{
+ struct sdw_cdns_dma_data *dma;
+
+ dma = snd_soc_dai_get_dma_data(dai, substream);
+ if (!dma)
+ return;
+
+ snd_soc_dai_set_dma_data(dai, substream, NULL);
+ kfree(dma);
On 8/22/19 6:37 PM, Srinivas Kandagatla wrote:
This patch adds support to parsing device tree based
SoundWire slave devices.
Signed-off-by: Srinivas Kandagatla
---
drivers/soundwire/bus.c | 2 ++
drivers/soundwire/bus.h | 1 +
drivers/soundwire/slave.c | 52
On 8/22/19 6:37 PM, Srinivas Kandagatla wrote:
This patch adds bindings for Soundwire Slave devices that includes how
SoundWire enumeration address and Link ID are used to represented in
SoundWire slave device tree nodes.
Signed-off-by: Srinivas Kandagatla
---
On 8/23/19 1:34 AM, Vinod Koul wrote:
On 21-08-19, 13:58, Pierre-Louis Bossart wrote:
This patchset enables debugfs support and corrects all the feedback
provided on an earlier RFC ('soundwire: updates for 5.4')
There is one remaining hard-coded value in intel.c that will need to
be fixed
21, 2019 at 03:17:15PM -0500, Pierre-Louis Bossart wrote:
This RFC is the companion of the other RFC 'soundwire: intel: simplify
DAI/PDI handling'. Our purpose at this point is to gather feedback on
the interfaces between the Intel SOF parts and the SoundWire code.
The suggested solution
Thanks for the review Guennadi
+static int sdw_config_stream(void *arg, void *s, void *dai,
+void *params, int link_id, int alh_stream_id)
I realise, that these function prototypes aren't being introduced by these
patches, but just wondering whether such overly
Somehow the core0 needs to be on to set-up the interrupts and power-up
the SoundWire IP.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/sof/intel/hda-dsp.c | 11 +++
sound/soc/sof/intel/hda.c | 2 +-
sound/soc/sof/intel/hda.h | 5 +
3 files changed, 17 insertions(+), 1
ALH was inserted in the wrong place during integration, add after DMIC
to mirror the file used by SOF firmware.
No functional change, just text move in the same file to better track
changes, if any.
Signed-off-by: Pierre-Louis Bossart
---
include/sound/sof/dai-intel.h | 18
.SNDW field
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/sof/intel/hda.c | 63 +++
sound/soc/sof/intel/hda.h | 1 +
2 files changed, 64 insertions(+)
diff --git a/sound/soc/sof/intel/hda.c b/sound/soc/sof/intel/hda.c
index c72e9a09eee1..a968890d0754
The Core0 needs to be powered before the SoundWire IP is initialized.
Call sdw_intel_init/exit and store the context. We only have one
context, but depending on the hardware capabilities and BIOS settings
may enable multiple SoundWire links.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc
.
This solution was tested on IceLake and CometLake, and captures the
feedback from SOF contributors on an initial integration that was
deemed too complicated (and rightly so).
Pierre-Louis Bossart (5):
ASoC: SOF: IPC: dai-intel: move ALH declarations in header file
ASoC: SOF: Intel: hda: add
These callbacks are invoked when a matching hw_params/hw_free() DAI
operation takes place, and will result in IPC operations with the SOF
firmware.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/sof/intel/hda.c | 66 +++
1 file changed, 66 insertions
From: Rander Wang
It gets sdw runtime information from dai to prepare stream.
Signed-off-by: Rander Wang
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire
From: Bard Liao
We will create dai widget in SOF.
Signed-off-by: Bard Liao
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 17 -
1 file changed, 17 deletions(-)
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
index d5563cfc6549
From: Bard Liao
PDI number should match dai->id, there is no need to track if a PDI is
allocated or not.
Signed-off-by: Bard Liao
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/cadence_master.c | 27 ++-
drivers/soundwire/cadence_master.h | 4 +---
driv
for further simplifications where the PDIs are
not dynamically allocated but instead described in a topology file.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/cadence_master.c | 110
drivers/soundwire/cadence_master.h | 32 ++-
drivers/soundwire/intel.c
501 - 600 of 1453 matches
Mail list logo
