Re: [patch 0/6] [RFC] Add MMC Password Protection (lock/unlock) support V6

2006-11-18 Thread Pierre Ossman
). This sounds like policy though, so it is something user space should concern itself with. We should just provide the infrastructure. Rgds -- -- Pierre Ossman Linux kernel, MMC maintainerhttp://www.kernel.org PulseAudio, core developer http://pulseaudio.org rdesktop

Re: [PATCH] trivial change for mmc/Kconfig: MMC_PXA does not mean only PXA255

2006-11-17 Thread Pierre Ossman
Marcin Juszkiewicz wrote: > PXA MMC driver supports not only PXA255 but also PXA250 and newer ones > > Signed-off-by: Marcin Juszkiewicz <[EMAIL PROTECTED]> > Thanks. Applied. Rgds -- -- Pierre Ossman Linux kernel, MMC maintainerhttp://www.kernel.org

Re: [patch 1/6] [RFC] Add MMC Password Protection (lock/unlock) support V6

2006-11-17 Thread Pierre Ossman
out a new patch set. This just creates extra work for us. Rgds -- -- Pierre Ossman Linux kernel, MMC maintainerhttp://www.kernel.org PulseAudio, core developer http://pulseaudio.org rdesktop, core developer http://www.rdesktop.org - To unsubscribe from this list: se

Re: [patch 1/6] [RFC] Add MMC Password Protection (lock/unlock) support V6

2006-11-17 Thread Pierre Ossman
of this capability. If the host can do BYTEBLOCK transfers it can send the password commands. This has been pointed out in the past. Anderson, please make sure you address all the previous concerns before sending out a new patch set. This just creates extra work for us. Rgds -- -- Pierre Ossman

Re: [PATCH] trivial change for mmc/Kconfig: MMC_PXA does not mean only PXA255

2006-11-17 Thread Pierre Ossman
Marcin Juszkiewicz wrote: PXA MMC driver supports not only PXA255 but also PXA250 and newer ones Signed-off-by: Marcin Juszkiewicz [EMAIL PROTECTED] Thanks. Applied. Rgds -- -- Pierre Ossman Linux kernel, MMC maintainerhttp://www.kernel.org PulseAudio, core developer

Re: swsusp doesn't suspend devices

2005-09-07 Thread Pierre Ossman
Rafael J. Wysocki wrote: >On Wednesday, 7 of September 2005 13:20, Pierre Ossman wrote: > > >>It would seem that swsusp doesn't properly suspend devices, or more >>precisely it wakes them up again before suspending the machine. >> >> > >Yes, it does.

swsusp doesn't suspend devices

2005-09-07 Thread Pierre Ossman
It would seem that swsusp doesn't properly suspend devices, or more precisely it wakes them up again before suspending the machine. The problem is in swsusp_suspend(). It is designed as if swsusp_arch_suspend() would suspend the hardware, when in fact all it does is prepare for a suspend. The

swsusp doesn't suspend devices

2005-09-07 Thread Pierre Ossman
It would seem that swsusp doesn't properly suspend devices, or more precisely it wakes them up again before suspending the machine. The problem is in swsusp_suspend(). It is designed as if swsusp_arch_suspend() would suspend the hardware, when in fact all it does is prepare for a suspend. The

Re: swsusp doesn't suspend devices

2005-09-07 Thread Pierre Ossman
Rafael J. Wysocki wrote: On Wednesday, 7 of September 2005 13:20, Pierre Ossman wrote: It would seem that swsusp doesn't properly suspend devices, or more precisely it wakes them up again before suspending the machine. Yes, it does. By design. That seems counter-productive, so

Re: [PATCH] ISA DMA suspend for i386

2005-09-05 Thread Pierre Ossman
Jeff Garzik wrote: > > Where is CONFIG_PM? > > Jeff I'm not sure you're receiving my mails, but I'll give it a try anyway. It would also seem that my MTA is choking on your MX entries. I'll look into that once I get home. CONFIG_PM is missing because of consistency with i8259.c, on which

Re: [PATCH] ISA DMA suspend for i386

2005-09-05 Thread Pierre Ossman
Jeff Garzik wrote: Where is CONFIG_PM? Jeff I'm not sure you're receiving my mails, but I'll give it a try anyway. It would also seem that my MTA is choking on your MX entries. I'll look into that once I get home. CONFIG_PM is missing because of consistency with i8259.c, on which the

[PATCH] 8139cp: Catch all interrupts

2005-09-01 Thread Pierre Ossman
Register interrupt handler when net device is registered. Avoids missing interrupts if the interrupt mask gets out of sync. Signed-off-by: Pierre Ossman <[EMAIL PROTECTED]> --- The reason this patch is needed for me is that the resume function is broken. It enables interrupts unconditi

Re: reboot vs poweroff

2005-09-01 Thread Pierre Ossman
Eric W. Biederman wrote: >Thanks. > >This is clearly a code path I missed when I was fixing things. > >When I made the final acpi change I checked for any other users >of device_suspend and it seems I was blind and missed this one. >Looking again... > >The patch in the bug report looks correct.

Re: reboot vs poweroff

2005-09-01 Thread Pierre Ossman
Eric W. Biederman wrote: >Hmm. Looking at that bug report it specifies 2.6.11. Does this >problem really happen in 2.6.13? > > > I first noticed it in 2.6.11. It was fixed sometime during 2.6.13-rc only to be killed of again in 2.6.13-rc7. The bugzilla now has a patch for 2.6.13 which fixes

Re: reboot vs poweroff (was: Linux 2.6.13)

2005-09-01 Thread Pierre Ossman
Meelis Roos wrote: > > It's OK then - I'm not using any suspend and I had a problem that my > machine powered down instead of reboot. The patch that went into 2.6.13 > after rc7 fixed it for me. So the current tree is OK for me and if it's > OK for you too after suspend2 changes then this case

Re: reboot vs poweroff (was: Linux 2.6.13)

2005-09-01 Thread Pierre Ossman
Meelis Roos wrote: It's OK then - I'm not using any suspend and I had a problem that my machine powered down instead of reboot. The patch that went into 2.6.13 after rc7 fixed it for me. So the current tree is OK for me and if it's OK for you too after suspend2 changes then this case can

Re: reboot vs poweroff

2005-09-01 Thread Pierre Ossman
Eric W. Biederman wrote: Hmm. Looking at that bug report it specifies 2.6.11. Does this problem really happen in 2.6.13? I first noticed it in 2.6.11. It was fixed sometime during 2.6.13-rc only to be killed of again in 2.6.13-rc7. The bugzilla now has a patch for 2.6.13 which fixes the

Re: reboot vs poweroff

2005-09-01 Thread Pierre Ossman
Eric W. Biederman wrote: Thanks. This is clearly a code path I missed when I was fixing things. When I made the final acpi change I checked for any other users of device_suspend and it seems I was blind and missed this one. Looking again... The patch in the bug report looks correct. However

[PATCH] 8139cp: Catch all interrupts

2005-09-01 Thread Pierre Ossman
Register interrupt handler when net device is registered. Avoids missing interrupts if the interrupt mask gets out of sync. Signed-off-by: Pierre Ossman [EMAIL PROTECTED] --- The reason this patch is needed for me is that the resume function is broken. It enables interrupts unconditionally

[PATCH] mmc: conditional scr sysfs entry

2005-08-30 Thread Pierre Ossman
Only show the scr file in sysfs for SD cards. Previously this was present for all cards but had a contents of 0 for MMC cards. Signed-off-by: Pierre Ossman <[EMAIL PROTECTED]> Index: linux-wbsd/drivers/mmc/mmc_sysfs.c === ---

[PATCH] mmc: conditional scr sysfs entry

2005-08-30 Thread Pierre Ossman
Only show the scr file in sysfs for SD cards. Previously this was present for all cards but had a contents of 0 for MMC cards. Signed-off-by: Pierre Ossman [EMAIL PROTECTED] Index: linux-wbsd/drivers/mmc/mmc_sysfs.c === --- linux

[PATCH 2/2] support for mmc chip select in wbsd

2005-08-29 Thread Pierre Ossman
Use the chip select ios in the wbsd driver. Signed-off-by: Pierre Ossman <[EMAIL PROTECTED]> Index: linux/drivers/mmc/wbsd.c === --- linux/drivers/mmc/wbsd.c (revision 161) +++ linux/drivers/mmc/wbsd.c (working copy) @@ -42,7

[PATCH 1/2] ios for mmc chip select

2005-08-29 Thread Pierre Ossman
Adds a new ios for setting the chip select pin on MMC cards. Needed on SD controllers which use this pin for other things and therefore cannot have it pulled high at all times. Signed-off-by: Pierre Ossman <[EMAIL PROTECTED]> Index: linux/drivers/mmc

[PATCH 2/2] support for mmc chip select in wbsd

2005-08-29 Thread Pierre Ossman
Use the chip select ios in the wbsd driver. Signed-off-by: Pierre Ossman [EMAIL PROTECTED] Index: linux/drivers/mmc/wbsd.c === --- linux/drivers/mmc/wbsd.c (revision 161) +++ linux/drivers/mmc/wbsd.c (working copy) @@ -42,7 +42,7

Re: [2.6 patch] fs/adfs/adfs.h: "extern inline" doesn't make sense

2005-08-21 Thread Pierre Ossman
Adrian Bunk wrote: > [ this time with a better subject ] > > "extern inline" doesn't make sense. > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > Isn't 'extern inline' an old gcc trick to force inlining? (instead of just hinting) - To unsubscribe from this list: send the line

Re: [2.6 patch] fs/adfs/adfs.h: extern inline doesn't make sense

2005-08-21 Thread Pierre Ossman
Adrian Bunk wrote: [ this time with a better subject ] extern inline doesn't make sense. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Isn't 'extern inline' an old gcc trick to force inlining? (instead of just hinting) - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] mmc: Multi-sector writes

2005-08-19 Thread Pierre Ossman
Pavel Machek wrote: > >Maybe the card is pretty close to going to crash, but... two disk >successive disk errors still should not be cause for journal >corruption. > >[Also errors could be corelated. Imagine severe overheat. You'll >successive failing writes, but if you let cool it down, you'll

Re: [PATCH] MMC host class

2005-08-19 Thread Pierre Ossman
Russell King wrote: > >Hmm, I think I've gone back to preferring something similar to your >original approach actually. I've also included the IDR patch. > > > Ok. Just as long as it works. :) My two concerns are: * Things that assume there's a name for every kobject. * Things that assume

Re: [PATCH] MMC host class

2005-08-19 Thread Pierre Ossman
Russell King wrote: Hmm, I think I've gone back to preferring something similar to your original approach actually. I've also included the IDR patch. Ok. Just as long as it works. :) My two concerns are: * Things that assume there's a name for every kobject. * Things that assume that a

Re: [PATCH] mmc: Multi-sector writes

2005-08-19 Thread Pierre Ossman
Pavel Machek wrote: Maybe the card is pretty close to going to crash, but... two disk successive disk errors still should not be cause for journal corruption. [Also errors could be corelated. Imagine severe overheat. You'll successive failing writes, but if you let cool it down, you'll still

Re: [PATCH] mmc: Multi-sector writes

2005-08-18 Thread Pierre Ossman
Pavel Machek wrote: >>* Transport problem. The driver will report back a CRC error, timeout or >>whatnot and break. We might not know how many sectors survived so we try >>again, going sector-by-sector. We might get a transfer error again, >>possibly even before the previous one. But at this

Re: [PATCH] mmc: Multi-sector writes

2005-08-18 Thread Pierre Ossman
Alan Cox wrote: >On Iau, 2005-08-18 at 09:26 +0200, Pierre Ossman wrote: > > >>everything out first and then fall back on sector-by-sector to determine >>where an error occurs. This will only break if the problematic sector >>keeps shifting around, but at that point

Re: [PATCH] mmc: Multi-sector writes

2005-08-18 Thread Pierre Ossman
Russell King wrote: >On Thu, Aug 18, 2005 at 09:26:03AM +0200, Pierre Ossman wrote: > > >>We had this discussion on LKML and Alan Cox' comment on it was that a >>solution like this would be acceptable, where we try and shove >>everything out first and then fa

Re: [PATCH] mmc: Multi-sector writes

2005-08-18 Thread Pierre Ossman
Russell King wrote: > >I'd rather not. The problem is that we have a host (thanks Intel) >which is unable to report how many bytes were transferred before an >error occurs. My fear is that doing anything other than sector by >sector write will lead to corruption should an error occur. >

Re: [PATCH] mmc: Multi-sector writes

2005-08-18 Thread Pierre Ossman
Russell King wrote: I'd rather not. The problem is that we have a host (thanks Intel) which is unable to report how many bytes were transferred before an error occurs. My fear is that doing anything other than sector by sector write will lead to corruption should an error occur. However, I've

Re: [PATCH] mmc: Multi-sector writes

2005-08-18 Thread Pierre Ossman
Russell King wrote: On Thu, Aug 18, 2005 at 09:26:03AM +0200, Pierre Ossman wrote: We had this discussion on LKML and Alan Cox' comment on it was that a solution like this would be acceptable, where we try and shove everything out first and then fall back on sector-by-sector to determine

Re: [PATCH] mmc: Multi-sector writes

2005-08-18 Thread Pierre Ossman
Alan Cox wrote: On Iau, 2005-08-18 at 09:26 +0200, Pierre Ossman wrote: everything out first and then fall back on sector-by-sector to determine where an error occurs. This will only break if the problematic sector keeps shifting around, but at that point the card is probably toast anyway

Re: [PATCH] mmc: Multi-sector writes

2005-08-18 Thread Pierre Ossman
Pavel Machek wrote: * Transport problem. The driver will report back a CRC error, timeout or whatnot and break. We might not know how many sectors survived so we try again, going sector-by-sector. We might get a transfer error again, possibly even before the previous one. But at this point the

Re: [PATCH] mmc: Multi-sector writes

2005-08-17 Thread Pierre Ossman
Andrew Morton wrote: >The fact that this is enabled under the experimental >CONFIG_MMC_BULKTRANSFER seems unfortunate. I mean, if the code works OK >then we should just enable it unconditionally, no? > > > It was made this way to make Russell more open to it. I have since not recieved any

Re: Flash erase groups and filesystems

2005-08-17 Thread Pierre Ossman
Jörn Engel wrote: >On Tue, 16 August 2005 20:13:36 +0200, Jörn Engel wrote: > > >>Yes. Most filesystems expect to find either 1) old data or 2) new >>data. Blocks full of 0xff are non-expected. >> >> > >Maybe this isn't obvious. Because of this expectation, it is >absolutely not safe to

Re: Flash erase groups and filesystems

2005-08-17 Thread Pierre Ossman
Jörn Engel wrote: On Tue, 16 August 2005 20:13:36 +0200, Jörn Engel wrote: Yes. Most filesystems expect to find either 1) old data or 2) new data. Blocks full of 0xff are non-expected. Maybe this isn't obvious. Because of this expectation, it is absolutely not safe to pre-erase

Re: [PATCH] mmc: Multi-sector writes

2005-08-17 Thread Pierre Ossman
Andrew Morton wrote: The fact that this is enabled under the experimental CONFIG_MMC_BULKTRANSFER seems unfortunate. I mean, if the code works OK then we should just enable it unconditionally, no? It was made this way to make Russell more open to it. I have since not recieved any more

Re: Flash erase groups and filesystems

2005-08-16 Thread Pierre Ossman
Jörn Engel wrote: >Question came up before, albeit with a different phrasing. One >possible approach to benefit from this ability would be to create a >"forget" operation. When a filesystem already knows that some data is >unneeded (after a truncate or erase operation), it will ask the device

Re: Flash erase groups and filesystems

2005-08-16 Thread Pierre Ossman
Jörn Engel wrote: Question came up before, albeit with a different phrasing. One possible approach to benefit from this ability would be to create a forget operation. When a filesystem already knows that some data is unneeded (after a truncate or erase operation), it will ask the device to

[PATCH] mmc: Multi-sector writes

2005-08-14 Thread Pierre Ossman
with no side-effects found. Signed-off-by: Pierre Ossman <[EMAIL PROTECTED]> --- Previously submitted: 2005-03-16 Previously submitted: 2004-12-03 Index: linux-wbsd/drivers/mmc/mmc_block.c === --- linux-wbsd/drivers/mmc/mmc_block.c (re

[PATCH] mmc: Multi-sector writes

2005-08-14 Thread Pierre Ossman
with no side-effects found. Signed-off-by: Pierre Ossman [EMAIL PROTECTED] --- Previously submitted: 2005-03-16 Previously submitted: 2004-12-03 Index: linux-wbsd/drivers/mmc/mmc_block.c === --- linux-wbsd/drivers/mmc/mmc_block.c (revision

Re: 8139cp misses interrupts during resume

2005-08-10 Thread Pierre Ossman
Pierre Ossman wrote: > Pierre Ossman wrote: > >>I'm having problem with the interrupt getting killed after suspend with >>my 8139cp controller. The problem only appears if the cable is connected >>during resume (before suspend is irrelevant) and the interface is down. &

Re: 8139cp misses interrupts during resume

2005-08-10 Thread Pierre Ossman
Pierre Ossman wrote: Pierre Ossman wrote: I'm having problem with the interrupt getting killed after suspend with my 8139cp controller. The problem only appears if the cable is connected during resume (before suspend is irrelevant) and the interface is down. Both suspend-to-disk and suspend

Re: [PATCH] MMC host class

2005-08-08 Thread Pierre Ossman
Russell King wrote: > >I still don't like the needless duplication. How about doing it this >way (see the attached patch.) > >Note: I also intend to move MMC over to using an IDR for the host >numbers, which is why we need to setup the name at registration >time, not allocation time. > > >

Re: [PATCH] MMC host class

2005-08-08 Thread Pierre Ossman
Russell King wrote: I still don't like the needless duplication. How about doing it this way (see the attached patch.) Note: I also intend to move MMC over to using an IDR for the host numbers, which is why we need to setup the name at registration time, not allocation time. This patch

Re: [patch] Fix a bit/byte counting error in the MMC/SD code

2005-08-05 Thread Pierre Ossman
Richard Purdie wrote: > This fixes what looks like a bit/byte counting error in the MMC/SD code > which was causing data corruption (in the -mm tree). > > Signed-off-by: Richard Purdie <[EMAIL PROTECTED]> Ooops... Must have been late in the evening. Sorry about that blunder. Rgds Pierre - To

Re: [patch] Fix a bit/byte counting error in the MMC/SD code

2005-08-05 Thread Pierre Ossman
Richard Purdie wrote: This fixes what looks like a bit/byte counting error in the MMC/SD code which was causing data corruption (in the -mm tree). Signed-off-by: Richard Purdie [EMAIL PROTECTED] Ooops... Must have been late in the evening. Sorry about that blunder. Rgds Pierre - To

Re: 8139cp misses interrupts during resume

2005-08-04 Thread Pierre Ossman
Pierre Ossman wrote: > I'm having problem with the interrupt getting killed after suspend with > my 8139cp controller. The problem only appears if the cable is connected > during resume (before suspend is irrelevant) and the interface is down. > > Both suspend-to-disk and suspend

Re: [PATCH] 8139cp - redetect link after suspend

2005-08-04 Thread Pierre Ossman
John W. Linville wrote: >On Mon, Jul 04, 2005 at 12:22:53AM +0200, Pierre Ossman wrote: > > >>After suspend the driver needs to retest link status in case the cable >>has been inserted or removed during the suspend. >> >>Signed-off-by: Pierre Ossman <[EMAIL

Re: [PATCH] 8139cp - redetect link after suspend

2005-08-04 Thread Pierre Ossman
John W. Linville wrote: On Mon, Jul 04, 2005 at 12:22:53AM +0200, Pierre Ossman wrote: After suspend the driver needs to retest link status in case the cable has been inserted or removed during the suspend. Signed-off-by: Pierre Ossman [EMAIL PROTECTED] Please copy netdev

Re: 8139cp misses interrupts during resume

2005-08-04 Thread Pierre Ossman
Pierre Ossman wrote: I'm having problem with the interrupt getting killed after suspend with my 8139cp controller. The problem only appears if the cable is connected during resume (before suspend is irrelevant) and the interface is down. Both suspend-to-disk and suspend-to-ram exhibit

Re: IRQ routing problem in 2.6.10-rc2

2005-07-24 Thread Pierre Ossman
Jesper Juhl wrote: > >Have you tried the suggestion given "... As a temporary workaround, >the "pci=routeirq" argument..." ? >You could also try the pci=noacpi boot option to see if that changes anything. > > No, I missed that one. The machine works fine with either of those two options. I

Re: IRQ routing problem in 2.6.10-rc2

2005-07-24 Thread Pierre Ossman
Pierre Ossman wrote: > ** PCI interrupts are no longer routed automatically. If this > ** causes a device to stop working, it is probably because the > ** driver failed to call pci_enable_device(). As a temporary > ** workaround, the "pci=routeirq" argument restores

IRQ routing problem in 2.6.10-rc2

2005-07-24 Thread Pierre Ossman
Sorry about reporting this error so late but the machine in question had gone some time without upgrades. The problem I'm seeing is that IRQs stop working for one of the IRQ slots on the machine. It's only that slot, not the entire IRQ, since the two slots (it's a small machine) both get routed

Re: IRQ routing problem in 2.6.10-rc2

2005-07-24 Thread Pierre Ossman
Pierre Ossman wrote: ** PCI interrupts are no longer routed automatically. If this ** causes a device to stop working, it is probably because the ** driver failed to call pci_enable_device(). As a temporary ** workaround, the pci=routeirq argument restores the old ** behavior

Re: IRQ routing problem in 2.6.10-rc2

2005-07-24 Thread Pierre Ossman
Jesper Juhl wrote: Have you tried the suggestion given ... As a temporary workaround, the pci=routeirq argument... ? You could also try the pci=noacpi boot option to see if that changes anything. No, I missed that one. The machine works fine with either of those two options. I sent a

Re: [PATCH] MMC host class

2005-07-18 Thread Pierre Ossman
Russell King wrote: >On Fri, Jul 15, 2005 at 10:21:43PM +0200, Pierre Ossman wrote: > > >>Russell King wrote: >> >> >>>Also note that since we have a class_dev, the mmc_host 'dev' field can >>>be removed. However, we'll probably have to update

Re: [PATCH] MMC host class

2005-07-18 Thread Pierre Ossman
Russell King wrote: On Fri, Jul 15, 2005 at 10:21:43PM +0200, Pierre Ossman wrote: Russell King wrote: Also note that since we have a class_dev, the mmc_host 'dev' field can be removed. However, we'll probably have to update the host drivers to do this, so it should be a separate patch

Re: [PATCH] MMC host class

2005-07-15 Thread Pierre Ossman
Russell King wrote: >The allocation function should initialise class_dev as much as possible. >The registration function should add the class device with the class >model. The unregistration should remove the class device from the class >model, but _not_ free it. The free function should drop

Re: [PATCH] MMC host class

2005-07-15 Thread Pierre Ossman
Russell King wrote: >No no no no no. Repeat after me ten times. Empty or non-existant release >functions are bad and cause oopsen. I will not create code which does >this. > > Sorry. I thought it was a generic cleanup function and since nothing was allocated in the register function I

Re: [PATCH] MMC host class

2005-07-15 Thread Pierre Ossman
Russell King wrote: No no no no no. Repeat after me ten times. Empty or non-existant release functions are bad and cause oopsen. I will not create code which does this. Sorry. I thought it was a generic cleanup function and since nothing was allocated in the register function I didn't

Re: [PATCH] MMC host class

2005-07-15 Thread Pierre Ossman
Russell King wrote: The allocation function should initialise class_dev as much as possible. The registration function should add the class device with the class model. The unregistration should remove the class device from the class model, but _not_ free it. The free function should drop the

[PATCH] MMC host class

2005-07-13 Thread Pierre Ossman
Create a mmc_host class to allow enumeration of MMC host controllers even though they have no card(s) inserted. Signed-off-by: Pierre Ossman <[EMAIL PROTECTED]> (This will also allow cards to be enumerated by being able to find the hosts.) Index: linux-wbsd/drivers/mmc

[PATCH] MMC host class

2005-07-13 Thread Pierre Ossman
Create a mmc_host class to allow enumeration of MMC host controllers even though they have no card(s) inserted. Signed-off-by: Pierre Ossman [EMAIL PROTECTED] (This will also allow cards to be enumerated by being able to find the hosts.) Index: linux-wbsd/drivers/mmc/mmc.h

[PATCH] Fix whitespace in wbsd

2005-07-11 Thread Pierre Ossman
Remove lots of trailing whitespace caused by not-so-great editor. Signed-off-by: Pierre Ossman <[EMAIL PROTECTED]> --- linux/drivers/mmc/wbsd.c.orig 2005-07-11 14:26:40.0 +0200 +++ linux/drivers/mmc/wbsd.c 2005-07-11 14:27:02.0 +0200 @@ -93,7 +93,7 @@ static inlin

[PATCH] wbsd version bump

2005-07-11 Thread Pierre Ossman
Version increase of the wbsd driver. Signed-off-by: Pierre Ossman <[EMAIL PROTECTED]> Even though the changes are minor for the next release an increasing version number simplifies my support issues. Index: linux/drivers/mmc/

[PATCH] wbsd version bump

2005-07-11 Thread Pierre Ossman
Version increase of the wbsd driver. Signed-off-by: Pierre Ossman [EMAIL PROTECTED] Even though the changes are minor for the next release an increasing version number simplifies my support issues. Index: linux/drivers/mmc/wbsd.c

[PATCH] Fix whitespace in wbsd

2005-07-11 Thread Pierre Ossman
Remove lots of trailing whitespace caused by not-so-great editor. Signed-off-by: Pierre Ossman [EMAIL PROTECTED] --- linux/drivers/mmc/wbsd.c.orig 2005-07-11 14:26:40.0 +0200 +++ linux/drivers/mmc/wbsd.c 2005-07-11 14:27:02.0 +0200 @@ -93,7 +93,7 @@ static inline void

Kernel panic with dc395x in 2.6.12.2

2005-07-09 Thread Pierre Ossman
I upgraded a machine from 2.6.11.7 to 2.6.12.2 today and the only thanks I got was a brand new kernel panic. From the backtrace it seems that the dc395x driver is the culprit. From what I can tell it hasn't undergone any changes between the two versions. Image of kernel panic:

Kernel panic with dc395x in 2.6.12.2

2005-07-09 Thread Pierre Ossman
I upgraded a machine from 2.6.11.7 to 2.6.12.2 today and the only thanks I got was a brand new kernel panic. From the backtrace it seems that the dc395x driver is the culprit. From what I can tell it hasn't undergone any changes between the two versions. Image of kernel panic:

Re: [PATCH] ISA DMA API documentation

2005-07-04 Thread Pierre Ossman
Documentation for how the ISA DMA controller is handled in the kernel. Signed-off-by: Pierre Ossman <[EMAIL PROTECTED]> New version after feedback from Randy Dunlap. Index: linux-wbsd/Documentation/DMA-ISA-LPC.txt === ---

Re: [PATCH] ISA DMA API documentation

2005-07-04 Thread Pierre Ossman
randy_dunlap wrote: >+The DMA:able address space is the lowest 16 MB of _physical_ memory. > The DMA-able >+Also the transfer block may not cross page boundaries (which are 64k). > I would write:(which are 64 KB). > >if I knew that was correct, but I don't.

Re: [PATCH] ISA DMA API documentation

2005-07-04 Thread Pierre Ossman
randy_dunlap wrote: +The DMA:able address space is the lowest 16 MB of _physical_ memory. The DMA-able +Also the transfer block may not cross page boundaries (which are 64k). I would write:(which are 64 KB). if I knew that was correct, but I don't. Does

Re: [PATCH] ISA DMA API documentation

2005-07-04 Thread Pierre Ossman
Documentation for how the ISA DMA controller is handled in the kernel. Signed-off-by: Pierre Ossman [EMAIL PROTECTED] New version after feedback from Randy Dunlap. Index: linux-wbsd/Documentation/DMA-ISA-LPC.txt === --- linux-wbsd

Re: [PATCH] wbsd update

2005-03-31 Thread Pierre Ossman
*dev) -{ -} +static struct platform_device *wbsd_device; -static struct platform_device wbsd_device = { - .name = DRIVER_NAME, - .id = -1, - .dev= { - .release = wbsd_release, - }, -}; - static struct device_driver wbsd_driver

Re: [PATCH] wbsd update

2005-03-31 Thread Pierre Ossman
, DRIVER_VERSION \n); printk(KERN_INFO DRIVER_NAME : Copyright(c) Pierre Ossman\n); + +#ifdef CONFIG_PNP + + if (!nopnp) + { + result = pnp_register_driver(wbsd_pnp_driver); + if (result 0) + return result

[PATCH] wbsd update

2005-03-22 Thread Pierre Ossman
down(>dev, 1); } +#endif /* CONFIG_PNP */ + /* * Power management */ @@ -1581,7 +1895,7 @@ #define wbsd_resume NULL #endif -static void wbsd_release(struct device *dev) +static void wbsd_release_dev(struct device *dev) { } @@ -1589,7 +1903,7 @@ .name = DRIVER_NAME, .id

Re: [PATCH][MMC] Bulk transfers (round 2)

2005-03-16 Thread Pierre Ossman
it might help if I include the actual patch... Index: linux-wbsd/drivers/mmc/mmc_block.c === --- linux-wbsd/drivers/mmc/mmc_block.c (revision 77) +++ linux-wbsd/drivers/mmc/mmc_block.c (working copy) @@ -166,9 +166,25 @@ struct

[PATCH][MMC] Bulk transfers (round 2)

2005-03-16 Thread Pierre Ossman
I didn't get any response for this one either ;) This is only a performance boost so it is less critical. It is very nice to have though since the performance gain is substancial (>100%). It should not pose any problems with data loss, which was your primary concern. It backs down to single

[PATCH][MMC] Power cycle (round 2)

2005-03-16 Thread Pierre Ossman
I didn't get any response from you the last time I submitted this so I'm going to nag you some more ;) This patch is vital for one of my MMC cards. The only other way I've found to get it working is by changing the OCR. And that would cause problems on other controllers so it was not an option.

[PATCH][MMC] Power cycle (round 2)

2005-03-16 Thread Pierre Ossman
I didn't get any response from you the last time I submitted this so I'm going to nag you some more ;) This patch is vital for one of my MMC cards. The only other way I've found to get it working is by changing the OCR. And that would cause problems on other controllers so it was not an option.

[PATCH][MMC] Bulk transfers (round 2)

2005-03-16 Thread Pierre Ossman
I didn't get any response for this one either ;) This is only a performance boost so it is less critical. It is very nice to have though since the performance gain is substancial (100%). It should not pose any problems with data loss, which was your primary concern. It backs down to single block

Re: [PATCH][MMC] Bulk transfers (round 2)

2005-03-16 Thread Pierre Ossman
it might help if I include the actual patch... Index: linux-wbsd/drivers/mmc/mmc_block.c === --- linux-wbsd/drivers/mmc/mmc_block.c (revision 77) +++ linux-wbsd/drivers/mmc/mmc_block.c (working copy) @@ -166,9 +166,25 @@ struct

Re: [PATCH][MMC][7/6] Secure Digital (SD) support : Copyright

2005-03-12 Thread Pierre Ossman
Pierre Ossman, All Rights Reserved. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as

Re: [PATCH][MMC][7/6] Secure Digital (SD) support : Copyright

2005-03-12 Thread Pierre Ossman
Pierre Ossman, All Rights Reserved. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as

Re: [Alsa-devel] Re: intel 8x0 went silent in 2.6.11

2005-03-08 Thread Pierre Ossman
Takashi Iwai wrote: At Tue, 08 Mar 2005 02:10:06 +0100, Pierre Ossman wrote: Takashi Iwai wrote: Look at /etc/asound.state whether it contains the value of "Headphone Jack Sense" control true or false. It saves the setting once I've been in 2.6.11. From an earl

Re: [Alsa-devel] Re: intel 8x0 went silent in 2.6.11

2005-03-08 Thread Pierre Ossman
Takashi Iwai wrote: At Tue, 08 Mar 2005 02:10:06 +0100, Pierre Ossman wrote: Takashi Iwai wrote: Look at /etc/asound.state whether it contains the value of Headphone Jack Sense control true or false. It saves the setting once I've been in 2.6.11. From an earlier kernel

Re: [Alsa-devel] Re: intel 8x0 went silent in 2.6.11

2005-03-07 Thread Pierre Ossman
Lee Revell wrote: >So is there a bug or not? Mark seems to be the only one affected. > >It's important to follow up, because these so-called "ALSA regressions" >are generating bad press. > >Lee > > > I can generate the error using the following procedure: 1. Boot in 2.6.10. Remove

Re: [Alsa-devel] Re: intel 8x0 went silent in 2.6.11

2005-03-07 Thread Pierre Ossman
Takashi Iwai wrote: Look at /etc/asound.state whether it contains the value of "Headphone Jack Sense" control true or false. It saves the setting once I've been in 2.6.11. From an earlier kernel there is no such entry. Of course, the earlier version didn't have this. And did you take a

Re: [Alsa-devel] Re: intel 8x0 went silent in 2.6.11

2005-03-07 Thread Pierre Ossman
Takashi Iwai wrote: >At Fri, 04 Mar 2005 22:16:03 +0100, >Pierre Ossman wrote: > > >>It seems I spoke too soon. The defaults picked by the driver are >>actually fine. It seems to be alsactl store/restore that did something >>strange when coming from an older

Re: [Alsa-devel] Re: intel 8x0 went silent in 2.6.11

2005-03-07 Thread Pierre Ossman
Takashi Iwai wrote: At Fri, 04 Mar 2005 22:16:03 +0100, Pierre Ossman wrote: It seems I spoke too soon. The defaults picked by the driver are actually fine. It seems to be alsactl store/restore that did something strange when coming from an older kernel. My guess is that kmix

Re: [Alsa-devel] Re: intel 8x0 went silent in 2.6.11

2005-03-07 Thread Pierre Ossman
Takashi Iwai wrote: Look at /etc/asound.state whether it contains the value of Headphone Jack Sense control true or false. It saves the setting once I've been in 2.6.11. From an earlier kernel there is no such entry. Of course, the earlier version didn't have this. And did you take a

Re: [Alsa-devel] Re: intel 8x0 went silent in 2.6.11

2005-03-07 Thread Pierre Ossman
Lee Revell wrote: So is there a bug or not? Mark seems to be the only one affected. It's important to follow up, because these so-called ALSA regressions are generating bad press. Lee I can generate the error using the following procedure: 1. Boot in 2.6.10. Remove /etc/asound.conf and

Re: [PATCH][MMC][6/6] Secure Digital (SD) support : wide bus

2005-03-05 Thread Pierre Ossman
Wide bus support. This adds 4-bit bus support to the MMC layer. It is designed to (hopefully) be compatible with a future 4-bit MMC implementation. This is done by seperating the three different instances of bus width defines: * Protocol definition: SD_BUS_WIDTH_x * SCR contents:

Re: [PATCH][MMC][5/6] Secure Digital (SD) support : sysfs

2005-03-05 Thread Pierre Ossman
SCR sysfs access. This provides access to the SCR register via sysfs. Since the latest bk contains some changes to the sysfs part this probably needs updating. The patch is trivial though so it should be easy. Index: linux-sd/drivers/mmc/mmc_sysfs.c

<    4   5   6   7   8   9   10   >