s/ns1": File exists
It might affect the outcome of other tests as well.
Move the netns cleanup code into an exit trap so that we can ensure
these namespace files will be removed after the test.
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/xfrm_policy.sh | 7 +--
1 file
-Hsu Lin
---
tools/testing/selftests/net/udpgro.sh | 34 ++
1 file changed, 34 insertions(+)
diff --git a/tools/testing/selftests/net/udpgro.sh
b/tools/testing/selftests/net/udpgro.sh
index ac2a30b..f8a19f5 100755
--- a/tools/testing/selftests/net/udpgro.sh
+++ b
when the next test calls check_xfrm().
With this fix, the final return value will be 1. Make it easier for
testers to spot this failure.
Fixes: 39aa6928d462d0 ("xfrm: policy: fix netlink/pf_key policy lookups")
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/xfrm_policy.sh
The == operand is a bash extension, thus this will fail on Ubuntu with
As the /bin/sh on Ubuntu is pointed to DASH.
Use -eq to fix this posix compatibility issue.
Fixes: 996f9e0f93f162 ("selftests/powerpc: Fix eeh-basic.sh exit codes")
Signed-off-by: Po-Hsu Lin
---
tools/testing
ectory
Cannot remove namespace file "/run/netns/vm-2": No such file or directory
Redirect it to /dev/null like other commands in the cleanup function
to reduce confusion.
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/test_vxlan_under_vrf.sh | 2 +-
1 file changed, 1 insertion
ectory
Cannot remove namespace file "/run/netns/vm-2": No such file or directory
Redirect it to /dev/null like other commands in the cleanup function
to reduce confusion.
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/test_vxlan_under_vrf.sh | 2 +-
1 file changed, 1 insertion
It looks like the C15B laptop got another vendor: ByteSpeed LLC.
Avoid AUX loopback on this touchpad as well, thus input subsystem will
be able to recognize a Synaptics touchpad in the AUX port.
BugLink: https://bugs.launchpad.net/bugs/1906128
Signed-off-by: Po-Hsu Lin
---
drivers/input/serio
Hello,
any update on this patch?
Or do we want to increase the timeout here?
Thanks!
On Fri, Oct 23, 2020 at 10:45 AM Po-Hsu Lin wrote:
>
> The eeh-basic test got its own 60 seconds timeout (defined in commit
> 414f50434aa2 "selftests/eeh: Bump EEH wait time to 60s") per
This test uses return code 2 as a hard-coded skipped state, let's use
the kselftest framework skip code variable $ksft_skip instead to make
it more readable and easier to maintain.
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/pmtu.sh | 64 ++---
1
, the test will be marked as PASSED
if nothing goes wrong and not all the tests were skipped.
Po-Hsu Lin (2):
selftests: pmtu.sh: use $ksft_skip for skipped return code
selftests: pmtu.sh: improve the test result processing
tools/testing/selftests/net/pmtu.sh | 79
either passed or skipped, the overall
result will be PASS
* If any of them has failed with return code 1 or anything bad
happened (e.g. return code 127 for command not found), the
overall result will be FAIL
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/pmtu.sh | 15
On Tue, Nov 10, 2020 at 2:09 AM Jakub Kicinski wrote:
>
> On Mon, 9 Nov 2020 11:42:33 +0800 Po-Hsu Lin wrote:
> > On Sun, Nov 8, 2020 at 7:02 AM Jakub Kicinski wrote:
> > >
> > > On Thu, 5 Nov 2020 18:50:51 +0800 Po-Hsu Lin wrote:
> > > > This
On Sun, Nov 8, 2020 at 7:02 AM Jakub Kicinski wrote:
>
> On Thu, 5 Nov 2020 18:50:51 +0800 Po-Hsu Lin wrote:
> > This test will treat all non-zero return codes as failures, it will
> > make the pmtu.sh test script being marked as FAILED when some
> > sub-test got
This test uses return code 2 as a hard-coded skipped state, let's use
the kselftest framework skip code variable $ksft_skip instead to make
it more readable and easier to maintain.
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/pmtu.sh | 64 ++---
1
, the test will be marked as PASSED
if nothing goes wrong and not all the tests were skipped.
Po-Hsu Lin (2):
selftests: pmtu.sh: use $ksft_skip for skipped return code
selftests: pmtu.sh: improve the test result processing
tools/testing/selftests/net/pmtu.sh | 83
either passed or skipped, the overall
result will be PASS
* If any of them has failed, the overall result will be FAIL
* Treat other return codes (e.g. 127 for command not found) as FAIL
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/pmtu.sh | 19 ++-
1 file
35
seconds. In our test pool it will take about 30 seconds to run on a
Power8 system that with 5 breakable devices, 60 seconds to run on a
Power9 system that with 4 breakable devices.
Extend the timeout setting in the kselftest framework to 5 minutes
to give it a chance to finish.
Signed-off-by:
On Fri, Oct 23, 2020 at 10:07 AM Michael Ellerman wrote:
>
> Po-Hsu Lin writes:
> > The eeh-basic test got its own 60 seconds timeout (defined in commit
> > 414f50434aa2 "selftests/eeh: Bump EEH wait time to 60s") per breakable
> > device.
> >
&g
h. And let the
test to take care of the timeout control.
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/powerpc/eeh/Makefile | 2 +-
tools/testing/selftests/powerpc/eeh/settings | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
create mode 100644 tools/testing/selftests/powerpc/ee
IG_NET_FOU into the config file as well. Which needs at
least to be set as a loadable module.
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/config | 1 +
tools/testing/selftests/net/rtnetlink.sh | 5 +
2 files changed, 6 insertions(+)
diff --git a/tools/testing/selftests/net/confi
On Sat, Oct 17, 2020 at 7:32 AM Jakub Kicinski wrote:
>
> On Fri, 16 Oct 2020 12:12:11 +0800 Po-Hsu Lin wrote:
> > The kci_test_encap_fou() test from kci_test_encap() in rtnetlink.sh
> > needs the fou module to work. Otherwise it will fail with:
> >
> > $ ip netns
IG_NET_FOU into the config file as well. Which needs at
least to be set as a loadable module.
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/config | 1 +
tools/testing/selftests/net/rtnetlink.sh | 5 +
2 files changed, 6 insertions(+)
diff --git a/tools/testing/selftests/net/confi
On Mon, Oct 12, 2020 at 11:28 PM Jakub Kicinski wrote:
>
> On Mon, 12 Oct 2020 13:56:15 +0800 Po-Hsu Lin wrote:
> > Is there any update on this patch?
>
> You received feedback. Don't remove modules after tests, something else
> could be using them.
Hello Jakub,
I have my fe
Hello,
Is there any update on this patch?
Thanks!
PHLin
On Fri, Sep 18, 2020 at 6:39 PM Po-Hsu Lin wrote:
>
> Hello folks,
>
> any thoughts on this patch?
> It can make the test pass and reduce the failure numbers in
> kselftests, it will be great to have this applied.
Hello folks,
any thoughts on this patch?
It can make the test pass and reduce the failure numbers in
kselftests, it will be great to have this applied.
Thanks
PHLin
On Tue, Sep 8, 2020 at 2:57 PM Po-Hsu Lin wrote:
>
> On Tue, Sep 8, 2020 at 4:12 AM Jakub Kicinski wrote:
> >
&g
On Tue, Sep 8, 2020 at 4:12 AM Jakub Kicinski wrote:
>
> On Mon, 7 Sep 2020 11:50:10 +0800 Po-Hsu Lin wrote:
> > The kci_test_encap_fou() test from kci_test_encap() in rtnetlink.sh
> > needs the fou module to work. Otherwise it will fail with:
> >
> > $ ip netns
IG_NET_FOU into the config file as well. Which needs at
least to be set as a loadable module.
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/config | 1 +
tools/testing/selftests/net/rtnetlink.sh | 6 ++
2 files changed, 7 insertions(+)
diff --git a/tools/testing/selftests/net/confi
Hello David,
do you need more information for this V2 patch?
Thank you
PHLin
On Mon, Aug 17, 2020 at 10:53 AM Po-Hsu Lin wrote:
>
> The kci_test_encap_fou() test from kci_test_encap() in rtnetlink.sh
> needs the fou module to work. Otherwise it will fail with:
>
> $ ip netn
Before changing this it's a bit confusing to read test output:
raw csum_off with bad offset (fails)
./psock_snd: write: Invalid argument
Change "fails" in the test case description to "expected to fail", so
that the test output can be more understandable.
Signe
On Sat, Aug 15, 2020 at 7:43 AM David Miller wrote:
>
> From: Po-Hsu Lin
> Date: Thu, 13 Aug 2020 12:44:22 +0800
>
> > diff --git a/tools/testing/selftests/net/config
> > b/tools/testing/selftests/net/config
> > index 3b42c06b..96d2763 100644
> > ---
IG_NET_FOU into the config file as well. Which needs at
least to be set as a loadable module.
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/config | 1 +
tools/testing/selftests/net/rtnetlink.sh | 6 ++
2 files changed, 7 insertions(+)
diff --git a/tools/testing/selftests/net/confi
IG_NET_FOU into the config file as well.
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/config | 1 +
tools/testing/selftests/net/rtnetlink.sh | 6 ++
2 files changed, 7 insertions(+)
diff --git a/tools/testing/selftests/net/config
b/tools/testing/selftests/net/config
index 3b42c06
quot;ret" become a local variable for all sub-tests.
Also, check the sub-test results in kci_test_rtnl() and return the
final result for this test.
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/rtnetlink.sh | 65 +---
1 file changed, 43 insertio
: bridge setup
PASS: ipv6 addrlabel
PASS: set ifalias 5b193daf-0a08-46d7-af2c-e7aadd422ded for test-dummy0
PASS: vrf
PASS: vxlan
FAIL: can't add fou port , skipping test
PASS: macsec
PASS: bridge fdb get
PASS: neigh get
$ echo $?
0
Signed-off-by: Po-Hsu Lin
assed.
2. The test result from two sub-tests in kci_test_encap() were not
being processed, thus they will not affect the final test result
of this test.
Po-Hsu Lin (2):
selftests: rtnetlink: correct the final return value for the test
selftests: rtnetlink: make kci_test_encap()
(Adding Shuah's linuxfoundation mail)
Hello,
do you need more changes / tests for this test?
Thanks!
Po-Hsu
On Wed, Mar 18, 2020 at 10:42 AM Po-Hsu Lin wrote:
>
> The following 4 tests in timers can take longer than the default 45
> seconds that added in commit 852c8cbf34d3 (&
On Tue, May 5, 2020 at 9:09 PM Steven Rostedt wrote:
>
>
> You keep forgetting to Cc Shuah's other email.
Thanks!
I got the recipients list from the get_mainter.pl.
>
> On Tue, 5 May 2020 18:14:45 +0800
> Po-Hsu Lin wrote:
>
> > The UNRESOLVED state is much more app
installed properly, in this case we
cannot call this as UNSUPPORTED.
This change also make it consistent with other module-related tests
in ftrace.
Signed-off-by: Po-Hsu Lin
---
.../testing/selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc | 9 -
1 file changed, 8 insertions(+), 1 deletio
On Fri, May 1, 2020 at 9:59 AM Masami Hiramatsu wrote:
>
> Hi,
>
> On Wed, 29 Apr 2020 17:50:44 +0800
> Po-Hsu Lin wrote:
>
> > When the required module for the test does not exist, use
> > exit_unsupported instead of exit_unresolved to indicate this test
On Thu, Apr 30, 2020 at 12:29 AM Steven Rostedt wrote:
>
> On Wed, 29 Apr 2020 17:50:44 +0800
> Po-Hsu Lin wrote:
>
> > When the required module for the test does not exist, use
> > exit_unsupported instead of exit_unresolved to indicate this test is
> > not suppo
ests/ftrace: Add function filter on module testcase")
Fixes: af2a0750f374 ("selftests/ftrace: Improve kprobe on module testcase to
load/unload module")
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/ftrace/test.d/direct/ftrace-direct.tc | 2 +-
tools/testing/selftests/ft
Hello,
Thanks all for your feedback!
On Wed, Jul 3, 2019 at 8:11 AM Masami Hiramatsu wrote:
>
> Hi Po-Hsu Lin,
>
> On Tue, 2 Jul 2019 13:22:26 -0600
> shuah wrote:
>
> > Hi Po-Hsu Lin,
> >
> > On 7/2/19 12:23 AM, Po-Hsu Lin wrote:
> > > The ftrace
1..1 selftests: ftrace: ftracetest [FAIL]
To:
selftests: ftrace: ftracetest
CONFIG_FTRACE was not enabled, test skipped.
not ok 1..1 selftests: ftrace: ftracetest [SKIP]
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/ftrace
-positive test result when testing it directly with the
following commad against a kernel that have CONFIG_KALLSYMS disabled:
make -C tools/testing/selftests TARGETS=net run_tests
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/config| 1 +
tools/testing/selftests/net
in the ftrace
kprobe_args_symbol test.
I can send V2 along with CONFIG_KALLSYMS appended to the "config" file
if you agree with this.
Thanks
On Thu, Jun 13, 2019 at 12:27 AM David Miller wrote:
>
> From: Po-Hsu Lin
> Date: Wed, 12 Jun 2019 14:47:52 +0800
>
> > The
The psock_tpacket test will need to access /proc/kallsyms, this would
require the kernel config CONFIG_KALLSYMS to be enabled first.
Check the file existence to determine if we can run this test.
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/run_afpackettests | 14 +-
1
Hello,
Commit f8a0590f fix some part of this issue.
I will send out V3 base on this commit in linux-kselftest next branch.
Thank you.
On Fri, Apr 19, 2019 at 9:20 PM shuah wrote:
>
> On 4/19/19 7:12 AM, Po-Hsu Lin wrote:
> > Test files created by test_create*() tes
n(O_WRONLY): Operation not permitted
[FAIL]
Create a file_cleanup() to remove those test files in the end of each
test to solve this issue.
Also, use this function to replace the existing file removal code.
Link: https://bugs.launchpad.net/bugs/1809704
Signed-off-by:
move those test files in the end of each
test to solve this issue.
For the test_create_read, we can move the clean up task to the end of
the test to ensure the system is clean.
Also, use this function to replace the existing file removal code.
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftest
When the CONFIG_HOTPLUG_CPU is not set, there won't be a "hotplug"
directory in /sys/devices/system/cpu/. Make use of this fact to check
if we need to skip this test.
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh | 5 +
1 file changed, 5
ssion denied" noises and a false-positive test
result to the test_create_read() test.
Remove those test files in the end of each test to solve this issue.
Link: https://bugs.launchpad.net/bugs/1809704
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/efivarfs/efivarfs.sh | 18 +++
gable memory in offline state:
offline->online memory1
offline->online memory100
offline->online memory101
skip extra tests: debugfs is not mounted
$ echo $?
0
Signed-off-by: Po-Hsu Lin <po-hsu@canonical.com>
---
.../selftests/memory-hotplug/mem-on-off-test.sh| 70 +
Typo fixed for hotpluggable_offline_memory() in memory-hotplug test.
Signed-off-by: Po-Hsu Lin <po-hsu@canonical.com>
---
.../selftests/memory-hotplug/mem-on-off-test.sh| 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/testing/selftests/memory-h
gable memory in offline state:
offline->online memory1
offline->online memory100
offline->online memory101
skip extra tests: debugfs is not mounted
$ echo $?
0
Signed-off-by: Po-Hsu Lin
---
.../selftests/memory-hotplug/mem-on-off-test.sh| 70 +++-
1 file changed,
Typo fixed for hotpluggable_offline_memory() in memory-hotplug test.
Signed-off-by: Po-Hsu Lin
---
.../selftests/memory-hotplug/mem-on-off-test.sh| 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
b
Check the precentage range for -r flag in memory-hotplug test.
Signed-off-by: Po-Hsu Lin <po-hsu@canonical.com>
---
.../selftests/memory-hotplug/mem-on-off-test.sh|4
1 file changed, 4 insertions(+)
diff --git a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
b
Check for hot-pluggable memory availability in prerequisite() of the
memory-hotplug test.
Signed-off-by: Po-Hsu Lin <po-hsu@canonical.com>
---
.../selftests/memory-hotplug/mem-on-off-test.sh|5 +
1 file changed, 5 insertions(+)
diff --git a/tools/testing/selftests/memory-h
Check the precentage range for -r flag in memory-hotplug test.
Signed-off-by: Po-Hsu Lin
---
.../selftests/memory-hotplug/mem-on-off-test.sh|4
1 file changed, 4 insertions(+)
diff --git a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
b/tools/testing/selftests/memory
Check for hot-pluggable memory availability in prerequisite() of the
memory-hotplug test.
Signed-off-by: Po-Hsu Lin
---
.../selftests/memory-hotplug/mem-on-off-test.sh|5 +
1 file changed, 5 insertions(+)
diff --git a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
b
This patchset will fix a typo, print the name of the memory notifier
error injection test, add two extra checks and fixes the online /
offline memory test in the memory-hotplug test.
Po-Hsu Lin (5):
selftests: typo correction for memory-hotplug test
selftests: check hot-pluggagble memory
This patchset will fix a typo, print the name of the memory notifier
error injection test, add two extra checks and fixes the online /
offline memory test in the memory-hotplug test.
Po-Hsu Lin (5):
selftests: typo correction for memory-hotplug test
selftests: check hot-pluggagble memory
There is no prompt for testing memory notifier error injection,
added with the same echo format of other tests above.
Signed-off-by: Po-Hsu Lin <po-hsu@canonical.com>
---
.../selftests/memory-hotplug/mem-on-off-test.sh|1 +
1 file changed, 1 insertion(+)
diff --git a/tools/t
There is no prompt for testing memory notifier error injection,
added with the same echo format of other tests above.
Signed-off-by: Po-Hsu Lin
---
.../selftests/memory-hotplug/mem-on-off-test.sh|1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/memory-hotplug
Hello Shuah,
thanks for the feedback, I will send v2 for these.
Cheers
On Sat, Jun 24, 2017 at 12:03 AM, Shuah Khan <sh...@kernel.org> wrote:
> Hi Po-Hsu Lin,
>
> On 06/18/2017 09:04 PM, Po-Hsu Lin wrote:
>
> Please split the typo correction and fixes. Please send a patch
Hello Shuah,
thanks for the feedback, I will send v2 for these.
Cheers
On Sat, Jun 24, 2017 at 12:03 AM, Shuah Khan wrote:
> Hi Po-Hsu Lin,
>
> On 06/18/2017 09:04 PM, Po-Hsu Lin wrote:
>
> Please split the typo correction and fixes. Please send a patch
> for each individua
y101
skip extra tests: debugfs is not mounted
PHLin@Latitude:~$ echo $?
0
Signed-off-by: Po-Hsu Lin <po-hsu@canonical.com>
---
.../selftests/memory-hotplug/mem-on-off-test.sh| 86 +++-
1 file changed, 67 insertions(+), 19 deletions(-)
diff --git a/tools/testing/selftest
y101
skip extra tests: debugfs is not mounted
PHLin@Latitude:~$ echo $?
0
Signed-off-by: Po-Hsu Lin
---
.../selftests/memory-hotplug/mem-on-off-test.sh| 86 +++-
1 file changed, 67 insertions(+), 19 deletions(-)
diff --git a/tools/testing/selftests/memory-hotplug/mem-on-off-tes
67 matches
Mail list logo
