[PATCH] spi: qup: Fix runtime and system PM callbacks.

2017-01-26 Thread Pramod Gurav
The SPI clocks were being turned on every suspend/resume cycle. This was increamenting the prepare/enable count after every resume. Fix the same. Signed-off-by: Pramod Gurav <pramod.gu...@linaro.org> --- Tested on db410c drivers/spi/spi-qup.c | 18 +- 1 file chan

[PATCH] spi: qup: Fix runtime and system PM callbacks.

2017-01-26 Thread Pramod Gurav
The SPI clocks were being turned on every suspend/resume cycle. This was increamenting the prepare/enable count after every resume. Fix the same. Signed-off-by: Pramod Gurav --- Tested on db410c drivers/spi/spi-qup.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions

[PATCH v5] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-10-21 Thread Pramod Gurav
arjani <rite...@codeaurora.org> Signed-off-by: Pramod Gurav <pramod.gu...@linaro.org> --- Tested on DB410C. Changes in v5: - Added pm_runtime_mark_last_busy in probe before calling autosuspend - included clock names in error logs - Used micro instead of constant for aut

[PATCH v5] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-10-21 Thread Pramod Gurav
Provides runtime PM callbacks to enable and disable clock resources when idle. Also support system PM callbacks to be called during system suspend and resume. Reviewed-by: Ritesh Harjani Reviewed-by: Georgi Djakov Tested-by: Ritesh Harjani Signed-off-by: Pramod Gurav --- Tested on DB410C

Re: [PATCH v4] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-10-20 Thread Pramod Gurav
g. > > > > On 10/18/2016 3:46 PM, Pramod Gurav wrote: >> >> Provides runtime PM callbacks to enable and disable clock resources >> when idle. Also support system PM callbacks to be called during system >> suspend and resume. >> >> Signed-off-

Re: [PATCH v4] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-10-20 Thread Pramod Gurav
Hi Ritesh, On 20 October 2016 at 20:20, Ritesh Harjani wrote: > Hi Pramod, > > Thanks for this patch. Few minor comments. > > I have tested your patch on db410c and 8996 based internal platform and it > works fine. Thanks for the review and testing. > > > > On 10

Re: [PATCH v4] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-10-20 Thread Pramod Gurav
Thanks Georgi for the review. On 20 October 2016 at 18:38, Georgi Djakov <georgi.dja...@linaro.org> wrote: > Hi Pramod, > > Thanks for the patch! > > On 10/18/2016 01:16 PM, Pramod Gurav wrote: >> >> Provides runtime PM callbacks to enable and disable clock res

Re: [PATCH v4] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-10-20 Thread Pramod Gurav
Thanks Georgi for the review. On 20 October 2016 at 18:38, Georgi Djakov wrote: > Hi Pramod, > > Thanks for the patch! > > On 10/18/2016 01:16 PM, Pramod Gurav wrote: >> >> Provides runtime PM callbacks to enable and disable clock resources >> when idle.

[PATCH v4] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-10-18 Thread Pramod Gurav
Provides runtime PM callbacks to enable and disable clock resources when idle. Also support system PM callbacks to be called during system suspend and resume. Signed-off-by: Pramod Gurav <pramod.gu...@linaro.org> --- Tested on DB410C. Changes in v4: - Remove calls to sdhci_runtime_resum

[PATCH v4] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-10-18 Thread Pramod Gurav
Provides runtime PM callbacks to enable and disable clock resources when idle. Also support system PM callbacks to be called during system suspend and resume. Signed-off-by: Pramod Gurav --- Tested on DB410C. Changes in v4: - Remove calls to sdhci_runtime_resume_host/sdhci_runtime_suspend_host

Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-23 Thread Pramod Gurav
Hi Ritesh, Thanks for the inputs. On 22 September 2016 at 20:02, Ritesh Harjani wrote: > Hi Pramod, >> Thanks Ulf for the comments. Will check this and see if there is >> something of this sort we have to do to achieve auto tuning. >> Adding Ritesh who has been

Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-23 Thread Pramod Gurav
Hi Ritesh, Thanks for the inputs. On 22 September 2016 at 20:02, Ritesh Harjani wrote: > Hi Pramod, >> Thanks Ulf for the comments. Will check this and see if there is >> something of this sort we have to do to achieve auto tuning. >> Adding Ritesh who has been posting some SDHCI MSM patches

Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-15 Thread Pramod Gurav
On 15 September 2016 at 15:49, Ulf Hansson <ulf.hans...@linaro.org> wrote: > On 15 September 2016 at 09:59, Pramod Gurav <pramod.gu...@linaro.org> wrote: >> On 9 September 2016 at 15:48, Georgi Djakov <georgi.dja...@linaro.org> wrote: >>> On 09/0

Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-15 Thread Pramod Gurav
On 15 September 2016 at 15:49, Ulf Hansson wrote: > On 15 September 2016 at 09:59, Pramod Gurav wrote: >> On 9 September 2016 at 15:48, Georgi Djakov wrote: >>> On 09/08/2016 11:02 AM, Adrian Hunter wrote: >>>> >>>> On 01/09/16 17:23, Pramod Gu

Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-15 Thread Pramod Gurav
On 9 September 2016 at 15:48, Georgi Djakov <georgi.dja...@linaro.org> wrote: > On 09/08/2016 11:02 AM, Adrian Hunter wrote: >> >> On 01/09/16 17:23, Pramod Gurav wrote: >>> >>> Provides runtime PM callbacks to enable and disable clock resources >>

Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-15 Thread Pramod Gurav
On 9 September 2016 at 15:48, Georgi Djakov wrote: > On 09/08/2016 11:02 AM, Adrian Hunter wrote: >> >> On 01/09/16 17:23, Pramod Gurav wrote: >>> >>> Provides runtime PM callbacks to enable and disable clock resources >>> when idle. Also support syst

Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-12 Thread Pramod Gurav
On 9 September 2016 at 15:30, Tummala, Sahitya wrote: > Hi Pramod, >> + ret = clk_prepare_enable(msm_host->clk); >> + if (ret) { >> + dev_err(dev, "clk_enable failed: %d\n", ret); > > A minor comment - Both error prints related to clock enable

Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-12 Thread Pramod Gurav
On 9 September 2016 at 15:30, Tummala, Sahitya wrote: > Hi Pramod, >> + ret = clk_prepare_enable(msm_host->clk); >> + if (ret) { >> + dev_err(dev, "clk_enable failed: %d\n", ret); > > A minor comment - Both error prints related to clock enable are same. Better > to

[PATCH] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-01 Thread Pramod Gurav
Provides runtime PM callbacks to enable and disable clock resources when idle. Also support system PM callbacks to be called during system suspend and resume. Signed-off-by: Pramod Gurav <pramod.gu...@linaro.org> --- Changes in v1: - Added CONFIG_PM around runtime pm function. - Replac

[PATCH] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-01 Thread Pramod Gurav
Provides runtime PM callbacks to enable and disable clock resources when idle. Also support system PM callbacks to be called during system suspend and resume. Signed-off-by: Pramod Gurav --- Changes in v1: - Added CONFIG_PM around runtime pm function. - Replaced msm suspend/resume with generic

[PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-01 Thread Pramod Gurav
Provides runtime PM callbacks to enable and disable clock resources when idle. Also support system PM callbacks to be called during system suspend and resume. Signed-off-by: Pramod Gurav <pramod.gu...@linaro.org> --- Changes in v3: - Added CONFIG_PM around runtime pm function. - Replac

[PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-01 Thread Pramod Gurav
Provides runtime PM callbacks to enable and disable clock resources when idle. Also support system PM callbacks to be called during system suspend and resume. Signed-off-by: Pramod Gurav --- Changes in v3: - Added CONFIG_PM around runtime pm function. - Replaced msm suspend/resume with generic

Re: [PATCH v2] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-01 Thread Pramod Gurav
On 1 September 2016 at 19:38, Ulf Hansson wrote: > [...] > >>> + >>> +static const struct dev_pm_ops sdhci_msm_pm_ops = { >>> + SET_LATE_SYSTEM_SLEEP_PM_OPS(sdhci_msm_suspend, sdhci_msm_resume) > > One more thing. Why do you need the late versions of the system PM

Re: [PATCH v2] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-01 Thread Pramod Gurav
On 1 September 2016 at 19:38, Ulf Hansson wrote: > [...] > >>> + >>> +static const struct dev_pm_ops sdhci_msm_pm_ops = { >>> + SET_LATE_SYSTEM_SLEEP_PM_OPS(sdhci_msm_suspend, sdhci_msm_resume) > > One more thing. Why do you need the late versions of the system PM callbacks? > > I think

[PATCH v2] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-01 Thread Pramod Gurav
Provides runtime PM callbacks to enable and disable clock resources when idle. Also support system PM callbacks to be called during system suspend and resume. Signed-off-by: Pramod Gurav <pramod.gu...@linaro.org> --- Changes in v2: - Moved pm_rutime enabling before adding host - Handled pm_

[PATCH v2] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-01 Thread Pramod Gurav
Provides runtime PM callbacks to enable and disable clock resources when idle. Also support system PM callbacks to be called during system suspend and resume. Signed-off-by: Pramod Gurav --- Changes in v2: - Moved pm_rutime enabling before adding host - Handled pm_rutime in remove - Changed

Re: [PATCH] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-08-30 Thread Pramod Gurav
Thanks Ulf for the review. On 29 August 2016 at 19:50, Ulf Hansson <ulf.hans...@linaro.org> wrote: > On 16 June 2016 at 14:35, Pramod Gurav <pramod.gu...@linaro.org> wrote: >> + platform_set_drvdata(pdev, msm_host); >> + >> +

Re: [PATCH] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-08-30 Thread Pramod Gurav
Thanks Ulf for the review. On 29 August 2016 at 19:50, Ulf Hansson wrote: > On 16 June 2016 at 14:35, Pramod Gurav wrote: >> + platform_set_drvdata(pdev, msm_host); >> + >> + pm_runtime_set_active(>dev); >> + pm_runtime_enable(>dev); > &g

Re: [PATCH] tty: serial: msm: Add runtime PM and system sleep support

2016-08-29 Thread Pramod Gurav
Hi Stephen, Thanks for having a look. On 26 August 2016 at 04:20, Stephen Boyd <sb...@codeaurora.org> wrote: > On 06/17, Pramod Gurav wrote: >> @@ -1220,12 +1293,26 @@ static void msm_power(struct uart_port *port, >> unsigned int state, >> >>

Re: [PATCH] tty: serial: msm: Add runtime PM and system sleep support

2016-08-29 Thread Pramod Gurav
Hi Stephen, Thanks for having a look. On 26 August 2016 at 04:20, Stephen Boyd wrote: > On 06/17, Pramod Gurav wrote: >> @@ -1220,12 +1293,26 @@ static void msm_power(struct uart_port *port, >> unsigned int state, >> >> switc

Re: [PATCH] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-08-29 Thread Pramod Gurav
Hi Ulf, On 16 June 2016 at 18:05, Pramod Gurav <pramod.gu...@linaro.org> wrote: > Provides runtime PM callbacks to enable and disable clock resources > when idle. Also support system PM callbacks to be called during system > suspend and resume. > > Signed-off-by: Pr

Re: [PATCH] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-08-29 Thread Pramod Gurav
Hi Ulf, On 16 June 2016 at 18:05, Pramod Gurav wrote: > Provides runtime PM callbacks to enable and disable clock resources > when idle. Also support system PM callbacks to be called during system > suspend and resume. > > Signed-off-by: Pramod Gurav Any comment

Re: [PATCH] tty: serial: msm: Add runtime PM and system sleep support

2016-08-24 Thread Pramod Gurav
Hi, On 17 June 2016 at 15:46, Pramod Gurav <pramod.gu...@linaro.org> wrote: > Add runtime pm and suspend/resume callback support to serial msm > driver so that clock resources are managed runtime to save power. > Any comments on this patch? > Signed-off-by: Pramod Gurav <pr

Re: [PATCH] tty: serial: msm: Add runtime PM and system sleep support

2016-08-24 Thread Pramod Gurav
Hi, On 17 June 2016 at 15:46, Pramod Gurav wrote: > Add runtime pm and suspend/resume callback support to serial msm > driver so that clock resources are managed runtime to save power. > Any comments on this patch? > Signed-off-by: Pramod Gurav > --- > drivers/tty/serial/

Re: [PATCH] tty: serial: msm: Add runtime PM and system sleep support

2016-08-24 Thread Pramod Gurav
On 25 August 2016 at 10:05, Andy Gross <andy.gr...@linaro.org> wrote: > On 17 June 2016 at 05:16, Pramod Gurav <pramod.gu...@linaro.org> wrote: > >> + if (msm_port->is_uartdm) { >> + ret = clk_enable(msm_port->pclk); > > Ditto

Re: [PATCH] tty: serial: msm: Add runtime PM and system sleep support

2016-08-24 Thread Pramod Gurav
On 25 August 2016 at 10:05, Andy Gross wrote: > On 17 June 2016 at 05:16, Pramod Gurav wrote: > >> + if (msm_port->is_uartdm) { >> + ret = clk_enable(msm_port->pclk); > > Ditto here. Thanks Andy, will include these two changes in v2. > >> + if (ret)

[PATCH v4] dmaengine: qcom-bam-dma: Add pm_runtime support

2016-06-17 Thread Pramod Gurav
Adds pm_runtime support for BAM DMA so that clock is enabled only when there is a transaction going on to help save power. Signed-off-by: Pramod Gurav <pramod.gu...@linaro.org> --- Changes in v3: - pm_runtime_get_sync returns < 0 on error hence chech for return < 0 - Move pm_runtime_

[PATCH v4] dmaengine: qcom-bam-dma: Add pm_runtime support

2016-06-17 Thread Pramod Gurav
Adds pm_runtime support for BAM DMA so that clock is enabled only when there is a transaction going on to help save power. Signed-off-by: Pramod Gurav --- Changes in v3: - pm_runtime_get_sync returns < 0 on error hence chech for return < 0 - Move pm_runtime_get_sync/put in bam_start_dma -

[PATCH] tty: serial: msm: Add runtime PM and system sleep support

2016-06-17 Thread Pramod Gurav
Add runtime pm and suspend/resume callback support to serial msm driver so that clock resources are managed runtime to save power. Signed-off-by: Pramod Gurav <pramod.gu...@linaro.org> --- drivers/tty/serial/msm_serial.c | 183 1 file change

[PATCH] tty: serial: msm: Add runtime PM and system sleep support

2016-06-17 Thread Pramod Gurav
Add runtime pm and suspend/resume callback support to serial msm driver so that clock resources are managed runtime to save power. Signed-off-by: Pramod Gurav --- drivers/tty/serial/msm_serial.c | 183 1 file changed, 168 insertions(+), 15 deletions

[PATCH] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-06-16 Thread Pramod Gurav
Provides runtime PM callbacks to enable and disable clock resources when idle. Also support system PM callbacks to be called during system suspend and resume. Signed-off-by: Pramod Gurav <pramod.gu...@linaro.org> --- drivers/mmc/host/sdhci-msm.

[PATCH] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-06-16 Thread Pramod Gurav
Provides runtime PM callbacks to enable and disable clock resources when idle. Also support system PM callbacks to be called during system suspend and resume. Signed-off-by: Pramod Gurav --- drivers/mmc/host/sdhci-msm.c | 57 1 file changed, 57

Re: [RFC PATCH] tty: serial: msm_serial: Don't reset uart on set_termios

2016-06-15 Thread Pramod Gurav
> 1 file changed, 18 deletions(-) Thanks for the patch. I no longer see these corruptions with this patch. This is what I used to see on my DB410C with debain FS: http://paste.ubuntu.com/17319106/ Tested-by: Pramod Gurav <pramod.gu...@linaro.org> Regards, Pramod

Re: [RFC PATCH] tty: serial: msm_serial: Don't reset uart on set_termios

2016-06-15 Thread Pramod Gurav
tions with this patch. This is what I used to see on my DB410C with debain FS: http://paste.ubuntu.com/17319106/ Tested-by: Pramod Gurav Regards, Pramod

Re: [PATCH] serial_core: Change UART PM state to OFF on failure

2016-06-09 Thread Pramod Gurav
Hi Peter, On 8 June 2016 at 22:17, Peter Hurley <pe...@hurleysoftware.com> wrote: > Hi Pramod, > > On 05/06/2016 02:46 AM, Pramod Gurav wrote: >> uart_change_pm is used to turn on the UART controller resources and >> change UART's PM status. On failure to allocate page

Re: [PATCH] serial_core: Change UART PM state to OFF on failure

2016-06-09 Thread Pramod Gurav
Hi Peter, On 8 June 2016 at 22:17, Peter Hurley wrote: > Hi Pramod, > > On 05/06/2016 02:46 AM, Pramod Gurav wrote: >> uart_change_pm is used to turn on the UART controller resources and >> change UART's PM status. On failure to allocate pages the controller &

Re: [PATCH] serial_core: Change UART PM state to OFF on failure

2016-06-06 Thread Pramod Gurav
On 6 May 2016 at 15:16, Pramod Gurav <pramod.gu...@linaro.org> wrote: > uart_change_pm is used to turn on the UART controller resources and > change UART's PM status. On failure to allocate pages the controller > be left in ON state. This will change the state to OFF on failure.

Re: [PATCH] serial_core: Change UART PM state to OFF on failure

2016-06-06 Thread Pramod Gurav
On 6 May 2016 at 15:16, Pramod Gurav wrote: > uart_change_pm is used to turn on the UART controller resources and > change UART's PM status. On failure to allocate pages the controller > be left in ON state. This will change the state to OFF on failure. > > Signed-off-b

Re: [PATCH] usb: echi-hcd: Add ehci_setup check before echi_shutdown

2016-05-30 Thread Pramod Gurav
ing a reboot on db410c which is fixed with this patch: Tested-by: Pramod Gurav <pramod.gu...@linaro.org>

Re: [PATCH] usb: echi-hcd: Add ehci_setup check before echi_shutdown

2016-05-30 Thread Pramod Gurav
On 19 May 2016 at 15:42, Srinivas Kandagatla wrote: > Fixes 4bb3cad7125b ("usb: host: ehci-msm: Register usb shutdown function") > Signed-off-by: Srinivas Kandagatla Was seeing this crash while doing a reboot on db410c which is fixed with this patch: Tested-by: Pramod Gurav

Re: [PATCH] usb: host: ehci-msm: Conditionally call ehci suspend/resume

2016-05-26 Thread Pramod Gurav
006] task: 800039abd780 ti: 80003928c000 task.ti: 80003928c000 [ 22.556870] PC is at ehci_suspend+0x34/0xe4 [ 22.564240] LR is at ehci_msm_pm_suspend+0x2c/0x34 [ 22.568232] pc : [] lr : [] pstate: a0000145 Tested-by: Pramod Gurav <pramod.gu...@linaro.org> > --- > drivers/us

Re: [PATCH] usb: host: ehci-msm: Conditionally call ehci suspend/resume

2016-05-26 Thread Pramod Gurav
: 80003928c000 [ 22.556870] PC is at ehci_suspend+0x34/0xe4 [ 22.564240] LR is at ehci_msm_pm_suspend+0x2c/0x34 [ 22.568232] pc : [] lr : [] pstate: a0000145 Tested-by: Pramod Gurav > --- > drivers/usb/host/ehci-msm.c | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) > Regards, Pramod

Re: [PATCH] tty: serial: msm: Remove duplicate handling of clocks

2016-05-16 Thread Pramod Gurav
On 11 May 2016 at 14:30, Pramod Gurav <pramod.gu...@linaro.org> wrote: > msm_serial driver provides a .pm callback to the serial core to enable > and disable clock resource in suspend/resume path. This function is > also called before msm_startup. msm_startup also enables t

Re: [PATCH] tty: serial: msm: Remove duplicate handling of clocks

2016-05-16 Thread Pramod Gurav
On 11 May 2016 at 14:30, Pramod Gurav wrote: > msm_serial driver provides a .pm callback to the serial core to enable > and disable clock resource in suspend/resume path. This function is > also called before msm_startup. msm_startup also enables the clocks which > is not needed.

Re: [PATCH] tty: serial: msm: Remove duplicate handling of clocks

2016-05-11 Thread Pramod Gurav
On 12 May 2016 at 05:48, Stephen Boyd <sb...@codeaurora.org> wrote: > On 05/11, Pramod Gurav wrote: >> msm_serial driver provides a .pm callback to the serial core to enable >> and disable clock resource in suspend/resume path. This function is >> also called before ms

Re: [PATCH] tty: serial: msm: Remove duplicate handling of clocks

2016-05-11 Thread Pramod Gurav
On 12 May 2016 at 05:48, Stephen Boyd wrote: > On 05/11, Pramod Gurav wrote: >> msm_serial driver provides a .pm callback to the serial core to enable >> and disable clock resource in suspend/resume path. This function is >> also called before msm_startup. msm_startup al

[PATCH] tty: serial: msm: Remove duplicate handling of clocks

2016-05-11 Thread Pramod Gurav
and msm_shutdown. Same is done in console setup to get rid of duplicate clock operation. Tested on DB410C console. Signed-off-by: Pramod Gurav <pramod.gu...@linaro.org> --- drivers/tty/serial/msm_serial.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/tty/

[PATCH] tty: serial: msm: Remove duplicate handling of clocks

2016-05-11 Thread Pramod Gurav
and msm_shutdown. Same is done in console setup to get rid of duplicate clock operation. Tested on DB410C console. Signed-off-by: Pramod Gurav --- drivers/tty/serial/msm_serial.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/tty/serial/msm_serial.c b/drivers

[PATCH] serial_core: Change UART PM state to OFF on failure

2016-05-06 Thread Pramod Gurav
uart_change_pm is used to turn on the UART controller resources and change UART's PM status. On failure to allocate pages the controller be left in ON state. This will change the state to OFF on failure. Signed-off-by: Pramod Gurav <pramod.gu...@linaro.org> --- drivers/tty/serial/serial_

[PATCH] serial_core: Change UART PM state to OFF on failure

2016-05-06 Thread Pramod Gurav
uart_change_pm is used to turn on the UART controller resources and change UART's PM status. On failure to allocate pages the controller be left in ON state. This will change the state to OFF on failure. Signed-off-by: Pramod Gurav --- drivers/tty/serial/serial_core.c | 5 +++-- 1 file changed

[PATCH v3 2/2] MAINTAINERS: Update the files to include the Qualcomm DMA folder

2016-05-04 Thread Pramod Gurav
Recently all qcom dma drivers were moved a separate directory. Update the files to include the same Signed-off-by: Pramod Gurav <pramod.gu...@linaro.org> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index d826f1b..2327f92 100644 --- a/MAINT

[PATCH v3 2/2] MAINTAINERS: Update the files to include the Qualcomm DMA folder

2016-05-04 Thread Pramod Gurav
Recently all qcom dma drivers were moved a separate directory. Update the files to include the same Signed-off-by: Pramod Gurav --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index d826f1b..2327f92 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH v3 1/2] dmaengine: qcom-bam-dma: Add pm_runtime support

2016-05-04 Thread Pramod Gurav
Adds pm_runtime support for BAM DMA so that clock is enabled only when there is a transaction going on to help save power. Signed-off-by: Pramod Gurav <pramod.gu...@linaro.org> --- Changes in v2: - Handled return values of pm_runtime_get_sync to return error - Rework remove function drive

[PATCH v3 1/2] dmaengine: qcom-bam-dma: Add pm_runtime support

2016-05-04 Thread Pramod Gurav
Adds pm_runtime support for BAM DMA so that clock is enabled only when there is a transaction going on to help save power. Signed-off-by: Pramod Gurav --- Changes in v2: - Handled return values of pm_runtime_get_sync to return error - Rework remove function drivers/dma/qcom/bam_dma.c | 98

Re: [PATCH v2 1/2] dmaengine: qcom-bam-dma: Add pm_runtime support

2016-05-03 Thread Pramod Gurav
Hi Manish, Thanks for review. On 3 May 2016 at 15:21, Manish Badarkhe wrote: > Hi Pramod > >> @@ -715,10 +724,13 @@ static int bam_resume(struct dma_chan *chan) >> struct bam_device *bdev = bchan->bdev; >> unsigned long flag; >> >> +

Re: [PATCH v2 1/2] dmaengine: qcom-bam-dma: Add pm_runtime support

2016-05-03 Thread Pramod Gurav
Hi Manish, Thanks for review. On 3 May 2016 at 15:21, Manish Badarkhe wrote: > Hi Pramod > >> @@ -715,10 +724,13 @@ static int bam_resume(struct dma_chan *chan) >> struct bam_device *bdev = bchan->bdev; >> unsigned long flag; >> >> + pm_runtime_get_sync(bdev->dev); >>

[PATCH v2 1/2] dmaengine: qcom-bam-dma: Add pm_runtime support

2016-05-03 Thread Pramod Gurav
Adds pm_runtime support for BAM DMA so that clock is enabled only when there is a transaction going on to help save power. Signed-off-by: Pramod Gurav <pramod.gu...@linaro.org> --- Changes since v1: - Removed unnecessary extra line additions and remavals drivers/dma/qcom/bam_dma.

[PATCH v2 2/2] MAINTAINERS: Update the files to include the Qualcomm DMA folder

2016-05-03 Thread Pramod Gurav
Recently all qcom dma drivers were moved a separate directory. Update the files to include the same Signed-off-by: Pramod Gurav <pramod.gu...@linaro.org> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index d826f1b..2327f92 100644 --- a/MAINT

[PATCH v2 1/2] dmaengine: qcom-bam-dma: Add pm_runtime support

2016-05-03 Thread Pramod Gurav
Adds pm_runtime support for BAM DMA so that clock is enabled only when there is a transaction going on to help save power. Signed-off-by: Pramod Gurav --- Changes since v1: - Removed unnecessary extra line additions and remavals drivers/dma/qcom/bam_dma.c | 86

[PATCH v2 2/2] MAINTAINERS: Update the files to include the Qualcomm DMA folder

2016-05-03 Thread Pramod Gurav
Recently all qcom dma drivers were moved a separate directory. Update the files to include the same Signed-off-by: Pramod Gurav --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index d826f1b..2327f92 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

Re: [PATCH 1/2] dmaengine: qcom-bam-dma: Add pm_runtime support

2016-05-02 Thread Pramod Gurav
Hi Kedar, Thanks for having a look and comments. On 2 May 2016 at 17:58, Appana Durga Kedareswara Rao <appana.durga@xilinx.com> wrote: > > Hi, > > > -Original Message- > > From: dmaengine-ow...@vger.kernel.org [mailto:dmaengine- > > ow...@vger.kern

Re: [PATCH 1/2] dmaengine: qcom-bam-dma: Add pm_runtime support

2016-05-02 Thread Pramod Gurav
Hi Kedar, Thanks for having a look and comments. On 2 May 2016 at 17:58, Appana Durga Kedareswara Rao wrote: > > Hi, > > > -Original Message- > > From: dmaengine-ow...@vger.kernel.org [mailto:dmaengine- > > ow...@vger.kernel.org] On Behalf Of Pramod Gurav >

[PATCH 2/2] MAINTAINERS: Update the files to include the Qualcomm DMA folder

2016-05-02 Thread Pramod Gurav
Recently all qcom dma drivers were moved a separate directory. Update the files to include the same Signed-off-by: Pramod Gurav <pramod.gu...@linaro.org> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index d826f1b..2327f92 100644 --- a/MAINT

[PATCH 2/2] MAINTAINERS: Update the files to include the Qualcomm DMA folder

2016-05-02 Thread Pramod Gurav
Recently all qcom dma drivers were moved a separate directory. Update the files to include the same Signed-off-by: Pramod Gurav --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index d826f1b..2327f92 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH 1/2] dmaengine: qcom-bam-dma: Add pm_runtime support

2016-05-02 Thread Pramod Gurav
Adds pm_runtime support for BAM DMA so that clock is enabled only when there is a transaction going on to help save power. Signed-off-by: Pramod Gurav <pramod.gu...@linaro.org> --- drivers/dma/qcom/bam_dma.c | 88 +- 1 file changed, 87 insertions

[PATCH 1/2] dmaengine: qcom-bam-dma: Add pm_runtime support

2016-05-02 Thread Pramod Gurav
Adds pm_runtime support for BAM DMA so that clock is enabled only when there is a transaction going on to help save power. Signed-off-by: Pramod Gurav --- drivers/dma/qcom/bam_dma.c | 88 +- 1 file changed, 87 insertions(+), 1 deletion(-) diff --git

[PATCH 1/2] spi: qup: Handle clocks in pm_runtime suspend and resume

2016-05-02 Thread Pramod Gurav
Clocks must ne disabled in pm_runtime to achieve some power saving. Enable the clocks when the device is runtime resumed during a transfer. Signed-off-by: Pramod Gurav <pramod.gu...@linaro.org> --- drivers/spi/spi-qup.c | 13 + 1 file changed, 13 insertions(+) diff --git a/d

[PATCH 1/2] spi: qup: Handle clocks in pm_runtime suspend and resume

2016-05-02 Thread Pramod Gurav
Clocks must ne disabled in pm_runtime to achieve some power saving. Enable the clocks when the device is runtime resumed during a transfer. Signed-off-by: Pramod Gurav --- drivers/spi/spi-qup.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/spi/spi-qup.c b/drivers

[PATCH 2/2] spi: qup: Add spi_master_put in remove function

2016-05-02 Thread Pramod Gurav
Release memory allocated for spi master by calling spi_master_put in .remove function. Signed-off-by: Pramod Gurav <pramod.gu...@linaro.org> --- drivers/spi/spi-qup.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c index e42ff61..c338ef1

[PATCH 2/2] spi: qup: Add spi_master_put in remove function

2016-05-02 Thread Pramod Gurav
Release memory allocated for spi master by calling spi_master_put in .remove function. Signed-off-by: Pramod Gurav --- drivers/spi/spi-qup.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c index e42ff61..c338ef1 100644 --- a/drivers/spi/spi

[PATCH 2/2] dmaengine: qcom_bam_dma: Bypass BAM init if not managed locally

2016-03-22 Thread Pramod Gurav
for all platforms. Signed-off-by: Pramod Gurav <gpra...@codeaurora.org> --- Documentation/devicetree/bindings/dma/qcom_bam_dma.txt | 3 +++ drivers/dma/qcom/bam_dma.c | 18 +++--- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/Documen

[PATCH 2/2] dmaengine: qcom_bam_dma: Bypass BAM init if not managed locally

2016-03-22 Thread Pramod Gurav
for all platforms. Signed-off-by: Pramod Gurav --- Documentation/devicetree/bindings/dma/qcom_bam_dma.txt | 3 +++ drivers/dma/qcom/bam_dma.c | 18 +++--- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/dma

[PATCH 1/2] dmaengine: qcom_bam_dma: Clear IRQ only if its set

2016-03-22 Thread Pramod Gurav
Clear the BAM IRQ bit only if there is a BAM interrupt. Signed-off-by: Pramod Gurav <gpra...@codeaurora.org> --- drivers/dma/qcom/bam_dma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c index d5e0a9c..0880345

[PATCH 1/2] dmaengine: qcom_bam_dma: Clear IRQ only if its set

2016-03-22 Thread Pramod Gurav
Clear the BAM IRQ bit only if there is a BAM interrupt. Signed-off-by: Pramod Gurav --- drivers/dma/qcom/bam_dma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c index d5e0a9c..0880345 100644 --- a/drivers/dma/qcom

[PATCH 0/2] Bypass BAM init if Remotely controlled

2016-03-22 Thread Pramod Gurav
on these targets which uses BAM as DMA controller. Pramod Gurav (2): dmaengine: qcom_bam_dma: Clear IRQ only if its set dmaengine: qcom_bam_dma: Bypass BAM init if not managed locally .../devicetree/bindings/dma/qcom_bam_dma.txt| 3 +++ drivers/dma/qcom/bam_dma.c

[PATCH 0/2] Bypass BAM init if Remotely controlled

2016-03-22 Thread Pramod Gurav
on these targets which uses BAM as DMA controller. Pramod Gurav (2): dmaengine: qcom_bam_dma: Clear IRQ only if its set dmaengine: qcom_bam_dma: Bypass BAM init if not managed locally .../devicetree/bindings/dma/qcom_bam_dma.txt| 3 +++ drivers/dma/qcom/bam_dma.c

Re: [PATCH] drivers: i2c: Fix qup fifo handling

2016-02-29 Thread Pramod Gurav
in to 'PAUSE' state and data has to written to fifo. Then > should be put in to 'RUN' state separately. > > Signed-off-by: Sricharan R <sricha...@codeaurora.org> Tested-by: Pramod Gurav <gpra...@codeaurora.org> Regards, Pramod > ---

Re: [PATCH] drivers: i2c: Fix qup fifo handling

2016-02-29 Thread Pramod Gurav
in to 'PAUSE' state and data has to written to fifo. Then > should be put in to 'RUN' state separately. > > Signed-off-by: Sricharan R Tested-by: Pramod Gurav Regards, Pramod > --- > drivers/i2c/busses/i2c-qup.c | 46 > +--- > 1

Re: [PATCH v3 2/3] tty: serial: msm: Remove duplicate operations on clocks in startup/shutdown

2015-04-29 Thread Pramod Gurav
Thanks Stephen for review. On Fri, April 10, 2015 11:33 pm, Stephen Boyd wrote: > On 04/10/15 05:19, Pramod Gurav wrote: >> @@ -683,8 +679,7 @@ static void msm_power(struct uart_port *port, >> unsigned int state, >> >> switch (state) { >> case 0: &

Re: [PATCH v3 2/3] tty: serial: msm: Remove duplicate operations on clocks in startup/shutdown

2015-04-29 Thread Pramod Gurav
Thanks Stephen for review. On Fri, April 10, 2015 11:33 pm, Stephen Boyd wrote: On 04/10/15 05:19, Pramod Gurav wrote: @@ -683,8 +679,7 @@ static void msm_power(struct uart_port *port, unsigned int state, switch (state) { case 0: -clk_prepare_enable(msm_port-clk

Re: [PATCH v2 2/2] tty: serial: msm: Disable pclk when port is closed

2015-04-08 Thread Pramod Gurav
On Thu, April 9, 2015 5:21 am, Stephen Boyd wrote: > On 04/08/15 06:28, Pramod Gurav wrote: >> Disable the pclk when tty port is closed by user space. >> >> Signed-off-by: Pramod Gurav >> --- >> drivers/tty/serial/msm_serial.c | 1 + >> 1 file changed, 1

[PATCH v2 2/2] tty: serial: msm: Disable pclk when port is closed

2015-04-08 Thread Pramod Gurav
Disable the pclk when tty port is closed by user space. Signed-off-by: Pramod Gurav --- drivers/tty/serial/msm_serial.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c index 4c1e9ea..f38565c 100644 --- a/drivers/tty/serial

[PATCH v2 1/2] tty: serial: msm: Add mask value for UART_DM registers

2015-04-08 Thread Pramod Gurav
so do it only for UART core. Signed-off-by: Pramod Gurav --- Changes since last version: - Added new macro fo UART_DM_MR1_AUTO_RFR_LEVEL1 instead of modifying existing. - Added a new macro for IPR register as it is also different in UART_DM - Changed subject line - Removed change log from

[PATCH 2/2] tty: serial: msm: Disable pclk when port is closed

2015-04-08 Thread Pramod Gurav
Disable the pclk when tty port is closed by user space. Signed-off-by: Pramod Gurav --- drivers/tty/serial/msm_serial.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c index 4c1e9ea..f38565c 100644 --- a/drivers/tty/serial

[PATCH 1/2] tty: serial: msm: Add mask value for UART_DM registers

2015-04-08 Thread Pramod Gurav
so do it only for UART core. Signed-off-by: Pramod Gurav -- Changes since last version: - Added new macro fo UART_DM_MR1_AUTO_RFR_LEVEL1 instead of modifying existing. - Added a new macro for IPR register as it is also different in UART_DM - Changed subject line --- drivers/tty/serial

[PATCH v2 1/2] tty: serial: msm: Add mask value for UART_DM registers

2015-04-08 Thread Pramod Gurav
so do it only for UART core. Signed-off-by: Pramod Gurav gpra...@codeaurora.org --- Changes since last version: - Added new macro fo UART_DM_MR1_AUTO_RFR_LEVEL1 instead of modifying existing. - Added a new macro for IPR register as it is also different in UART_DM - Changed subject line

[PATCH v2 2/2] tty: serial: msm: Disable pclk when port is closed

2015-04-08 Thread Pramod Gurav
Disable the pclk when tty port is closed by user space. Signed-off-by: Pramod Gurav gpra...@codeaurora.org --- drivers/tty/serial/msm_serial.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c index 4c1e9ea..f38565c 100644

[PATCH 2/2] tty: serial: msm: Disable pclk when port is closed

2015-04-08 Thread Pramod Gurav
Disable the pclk when tty port is closed by user space. Signed-off-by: Pramod Gurav gpra...@codeaurora.org --- drivers/tty/serial/msm_serial.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c index 4c1e9ea..f38565c 100644

[PATCH 1/2] tty: serial: msm: Add mask value for UART_DM registers

2015-04-08 Thread Pramod Gurav
so do it only for UART core. Signed-off-by: Pramod Gurav gpra...@codeaurora.org -- Changes since last version: - Added new macro fo UART_DM_MR1_AUTO_RFR_LEVEL1 instead of modifying existing. - Added a new macro for IPR register as it is also different in UART_DM - Changed subject line

Re: [PATCH v2 2/2] tty: serial: msm: Disable pclk when port is closed

2015-04-08 Thread Pramod Gurav
On Thu, April 9, 2015 5:21 am, Stephen Boyd wrote: On 04/08/15 06:28, Pramod Gurav wrote: Disable the pclk when tty port is closed by user space. Signed-off-by: Pramod Gurav gpra...@codeaurora.org --- drivers/tty/serial/msm_serial.c | 1 + 1 file changed, 1 insertion(+) diff --git

  1   2   3   4   5   6   >