[PATCH] networking: fm10k: Fix build failure

2014-10-09 Thread Pranith Kumar
`fm10k_ptp_unregister': (.text+0x12e7dc): undefined reference to `ptp_clock_unregister' Makefile:930: recipe for target 'vmlinux' failed Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- drivers/net/ethernet/intel/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net

[PATCH v2] networking: fm10k: Fix build failure

2014-10-09 Thread Pranith Kumar
`fm10k_ptp_unregister': (.text+0x12e7dc): undefined reference to `ptp_clock_unregister' Makefile:930: recipe for target 'vmlinux' failed Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- drivers/net/ethernet/intel/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/Kconfig

[PATCH] powerpc: Wire up sys_bpf() syscall

2014-10-09 Thread Pranith Kumar
This patch wires up the new syscall sys_bpf() on powerpc. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- arch/powerpc/include/asm/systbl.h | 1 + arch/powerpc/include/asm/unistd.h | 2 +- arch/powerpc/include/uapi/asm/unistd.h | 1 + 3 files changed, 3 insertions(+), 1 deletion

[PATCH] rcutorture: Remove obsolete kversion param in kvm.sh

2014-10-04 Thread Pranith Kumar
Now that we have removed configs based on kernel version, we can also remove the kversion parameter in kvm.sh. Signed-off-by: Pranith Kumar --- .../selftests/rcutorture/bin/kvm-test-1-run.sh| 2 +- tools/testing/selftests/rcutorture/bin/kvm.sh | 19 +-- 2 files

Re: [PATCH] rcutorture: Remove stale test configurations

2014-10-04 Thread Pranith Kumar
2014-10-04 6:56 GMT-04:00 Paul E. McKenney : > On Thu, Oct 02, 2014 at 11:33:48PM -0400, Pranith Kumar wrote: >> Remove rcutorture configuration files which are no longer necessary. >> >> Signed-off-by: Pranith Kumar > > Queued for 3.19, thank you!

Re: [PATCH] rcutorture: Remove stale test configurations

2014-10-04 Thread Pranith Kumar
2014-10-04 6:56 GMT-04:00 Paul E. McKenney paul...@linux.vnet.ibm.com: On Thu, Oct 02, 2014 at 11:33:48PM -0400, Pranith Kumar wrote: Remove rcutorture configuration files which are no longer necessary. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com Queued for 3.19, thank you

[PATCH] rcutorture: Remove obsolete kversion param in kvm.sh

2014-10-04 Thread Pranith Kumar
Now that we have removed configs based on kernel version, we can also remove the kversion parameter in kvm.sh. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- .../selftests/rcutorture/bin/kvm-test-1-run.sh| 2 +- tools/testing/selftests/rcutorture/bin/kvm.sh | 19

Re: [PATCH v2 2/3] doc: Document RCU self test boot params

2014-10-03 Thread Pranith Kumar
On Thu, Oct 2, 2014 at 3:52 PM, Paul E. McKenney wrote: > On Fri, Sep 19, 2014 at 11:32:30AM -0400, Pranith Kumar wrote: >> Document the RCU self test boot parameters in kernel-parameters.txt. >> >> Signed-off-by: Pranith Kumar > > I have this one queued, please let m

Re: [PATCH v2 2/3] doc: Document RCU self test boot params

2014-10-03 Thread Pranith Kumar
On Thu, Oct 2, 2014 at 3:52 PM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: On Fri, Sep 19, 2014 at 11:32:30AM -0400, Pranith Kumar wrote: Document the RCU self test boot parameters in kernel-parameters.txt. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com I have this one queued

[tip:locking/arch] locking,arch: Use ACCESS_ONCE() instead of cast to volatile in atomic_read()

2014-10-02 Thread tip-bot for Pranith Kumar
Commit-ID: 2291059c852706c6f5ffb400366042b7625066cd Gitweb: http://git.kernel.org/tip/2291059c852706c6f5ffb400366042b7625066cd Author: Pranith Kumar AuthorDate: Tue, 23 Sep 2014 10:29:50 -0400 Committer: Ingo Molnar CommitDate: Fri, 3 Oct 2014 06:06:23 +0200 locking,arch: Use

[PATCH] rcutorture: Remove stale test configurations

2014-10-02 Thread Pranith Kumar
Remove rcutorture configuration files which are no longer necessary. Signed-off-by: Pranith Kumar --- .../selftests/rcutorture/configs/rcu/v0.0/CFLIST | 14 -- .../configs/rcu/v0.0/N1-S-T-NH-SD-SMP-HP | 18 --- .../configs/rcu/v0.0/N2-2-t-nh-sd-SMP-hp | 20

[PATCH] rcutorture: Remove stale test configurations

2014-10-02 Thread Pranith Kumar
Remove rcutorture configuration files which are no longer necessary. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- .../selftests/rcutorture/configs/rcu/v0.0/CFLIST | 14 -- .../configs/rcu/v0.0/N1-S-T-NH-SD-SMP-HP | 18 --- .../configs/rcu/v0.0/N2-2-t-nh-sd-SMP-hp

[tip:locking/arch] locking,arch: Use ACCESS_ONCE() instead of cast to volatile in atomic_read()

2014-10-02 Thread tip-bot for Pranith Kumar
Commit-ID: 2291059c852706c6f5ffb400366042b7625066cd Gitweb: http://git.kernel.org/tip/2291059c852706c6f5ffb400366042b7625066cd Author: Pranith Kumar bobby.pr...@gmail.com AuthorDate: Tue, 23 Sep 2014 10:29:50 -0400 Committer: Ingo Molnar mi...@kernel.org CommitDate: Fri, 3 Oct 2014 06:06

[PATCH] cmpxchg: Discard unnecessary cast to volatile

2014-10-01 Thread Pranith Kumar
Generating a volatile pointer is really not necessary here. This is the only location where a volatile pointer is being generated for use in asm. This commit removes the unnecessary volatile pointer being created. Signed-off-by: Pranith Kumar --- arch/x86/include/asm/cmpxchg.h | 12

[PATCH] cmpxchg: Discard unnecessary cast to volatile

2014-10-01 Thread Pranith Kumar
Generating a volatile pointer is really not necessary here. This is the only location where a volatile pointer is being generated for use in asm. This commit removes the unnecessary volatile pointer being created. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- arch/x86/include/asm

[RESEND PATCH] drivers/md: Use rcu_dereference() for accessing rcu pointer

2014-09-28 Thread Pranith Kumar
Got Paul's email wrong the first time. The map field in 'struct mapped_device' is an rcu pointer. Use rcu_dereference() while accessing it. Signed-off-by: Pranith Kumar --- drivers/md/dm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/md/dm.c b/drivers/md

[PATCH] drivers/md: Use rcu_dereference() for accessing rcu pointer

2014-09-28 Thread Pranith Kumar
The map field in 'struct mapped_device' is an rcu pointer. Use rcu_dereference() while accessing it. Signed-off-by: Pranith Kumar --- drivers/md/dm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/md/dm.c b/drivers/md/dm.c index 746411b..fbdf0bb 100644

[PATCH] drivers/md: Use rcu_dereference() for accessing rcu pointer

2014-09-28 Thread Pranith Kumar
The map field in 'struct mapped_device' is an rcu pointer. Use rcu_dereference() while accessing it. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- drivers/md/dm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/md/dm.c b/drivers/md/dm.c index 746411b

[RESEND PATCH] drivers/md: Use rcu_dereference() for accessing rcu pointer

2014-09-28 Thread Pranith Kumar
Got Paul's email wrong the first time. The map field in 'struct mapped_device' is an rcu pointer. Use rcu_dereference() while accessing it. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- drivers/md/dm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers

[tip:perf/core] perf tools: Use ACCESS_ONCE() instead of volatile cast

2014-09-27 Thread tip-bot for Pranith Kumar
Commit-ID: 1da34daf24823f19cfd56c97973334cd95635926 Gitweb: http://git.kernel.org/tip/1da34daf24823f19cfd56c97973334cd95635926 Author: Pranith Kumar AuthorDate: Tue, 23 Sep 2014 10:55:08 -0400 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 26 Sep 2014 12:36:03 -0300 perf tools

[tip:perf/core] perf tools: Use ACCESS_ONCE() instead of volatile cast

2014-09-27 Thread tip-bot for Pranith Kumar
Commit-ID: 1da34daf24823f19cfd56c97973334cd95635926 Gitweb: http://git.kernel.org/tip/1da34daf24823f19cfd56c97973334cd95635926 Author: Pranith Kumar bobby.pr...@gmail.com AuthorDate: Tue, 23 Sep 2014 10:55:08 -0400 Committer: Arnaldo Carvalho de Melo a...@redhat.com CommitDate: Fri, 26

[PATCH] dm: sparse: Annotate field with __rcu for checking

2014-09-25 Thread Pranith Kumar
Annotate the map field with __rcu since this is a rcu pointer which is checked by sparse. Signed-off-by: Pranith Kumar --- drivers/md/dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm.c b/drivers/md/dm.c index 32b958d..746411b 100644 --- a/drivers/md/dm.c

Re: [RFC PATCH] rcu: Add sparse check for RCU_INIT_POINTER()

2014-09-25 Thread Pranith Kumar
On Thu, Sep 25, 2014 at 2:10 PM, wrote: > On Thu, Sep 25, 2014 at 02:03:34PM -0400, Pranith Kumar wrote: >> Add a sparse check when RCU_INIT_POINTER() is used to assign a non __rcu >> annotated pointer. >> >> Signed-off-by: Pranith Kumar > > Have you checked

[RFC PATCH] rcu: Add sparse check for RCU_INIT_POINTER()

2014-09-25 Thread Pranith Kumar
Add a sparse check when RCU_INIT_POINTER() is used to assign a non __rcu annotated pointer. Signed-off-by: Pranith Kumar --- include/linux/rcupdate.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h index a4a819f..a033d8b 100644

[RFC PATCH] rcu: Add sparse check for RCU_INIT_POINTER()

2014-09-25 Thread Pranith Kumar
Add a sparse check when RCU_INIT_POINTER() is used to assign a non __rcu annotated pointer. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- include/linux/rcupdate.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h index a4a819f

Re: [RFC PATCH] rcu: Add sparse check for RCU_INIT_POINTER()

2014-09-25 Thread Pranith Kumar
On Thu, Sep 25, 2014 at 2:10 PM, j...@joshtriplett.org wrote: On Thu, Sep 25, 2014 at 02:03:34PM -0400, Pranith Kumar wrote: Add a sparse check when RCU_INIT_POINTER() is used to assign a non __rcu annotated pointer. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com Have you checked

[PATCH] dm: sparse: Annotate field with __rcu for checking

2014-09-25 Thread Pranith Kumar
Annotate the map field with __rcu since this is a rcu pointer which is checked by sparse. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- drivers/md/dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm.c b/drivers/md/dm.c index 32b958d..746411b 100644

[PATCH] perf: Use ACCESS_ONCE() instead of volatile cast

2014-09-23 Thread Pranith Kumar
Use ACCESS_ONCE() instead of the cast to volatile and read. This is just a style change which is reader friendly. Signed-off-by: Pranith Kumar --- tools/perf/util/session.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/session.h b/tools/perf/util/session.h

Re: [RFC PATCH] x86: Use ACCESS_ONCE() for atomic_read()

2014-09-23 Thread Pranith Kumar
On Mon, Sep 22, 2014 at 4:07 PM, Peter Zijlstra wrote: > On Mon, Sep 22, 2014 at 03:53:09PM -0400, Pranith Kumar wrote: >> Use the much easier to read ACCESS_ONCE() which is basically the same thing >> as >> the cast to volatile. >> >> Please note the chang

Re: [RFC PATCH] x86: Use ACCESS_ONCE() for atomic_read()

2014-09-23 Thread Pranith Kumar
On Mon, Sep 22, 2014 at 4:07 PM, Peter Zijlstra pet...@infradead.org wrote: On Mon, Sep 22, 2014 at 03:53:09PM -0400, Pranith Kumar wrote: Use the much easier to read ACCESS_ONCE() which is basically the same thing as the cast to volatile. Please note the change in volatile cast

[PATCH] perf: Use ACCESS_ONCE() instead of volatile cast

2014-09-23 Thread Pranith Kumar
Use ACCESS_ONCE() instead of the cast to volatile and read. This is just a style change which is reader friendly. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- tools/perf/util/session.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/session.h b/tools

Re: [RFC PATCH] x86: Use volatile semantics for atomic_set()

2014-09-22 Thread Pranith Kumar
On Mon, Sep 22, 2014 at 4:08 PM, Peter Zijlstra wrote: > On Mon, Sep 22, 2014 at 03:39:21PM -0400, Pranith Kumar wrote: >> All the atomic operations have volatile semantics to prevent compiler >> reordering. Enforce the same semantics for atomic_set() too. > > To w

Re: [RFC PATCH] x86: Use ACCESS_ONCE() for atomic_read()

2014-09-22 Thread Pranith Kumar
On Mon, Sep 22, 2014 at 4:07 PM, Peter Zijlstra wrote: > On Mon, Sep 22, 2014 at 03:53:09PM -0400, Pranith Kumar wrote: >> Use the much easier to read ACCESS_ONCE() which is basically the same thing >> as >> the cast to volatile. >> >> Please note the chang

[RFC PATCH] x86: Use ACCESS_ONCE() for atomic_read()

2014-09-22 Thread Pranith Kumar
Use the much easier to read ACCESS_ONCE() which is basically the same thing as the cast to volatile. Please note the change in volatile cast: ACCESS_ONCE(v)->counter to ACCESS_ONCE(v->counter). Signed-off-by: Pranith Kumar --- arch/x86/include/asm/atomic.h | 2 +- 1 file changed, 1 ins

[RFC PATCH] x86: Use volatile semantics for atomic_set()

2014-09-22 Thread Pranith Kumar
All the atomic operations have volatile semantics to prevent compiler reordering. Enforce the same semantics for atomic_set() too. Signed-off-by: Pranith Kumar --- arch/x86/include/asm/atomic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/atomic.h b

[PATCH] rcu: Remove redundant TREE_PREEMPT_RCU config option

2014-09-22 Thread Pranith Kumar
. Signed-off-by: Pranith Kumar --- Documentation/RCU/rcu.txt | 4 ++-- Documentation/RCU/stallwarn.txt| 8 Documentation/RCU/trace.txt| 4 ++-- Documentation/RCU/whatisRCU.txt| 2 +- include/linux

Re: [PATCH] rcu: Remove redundant CONFIG_PREEMPT_RCU option

2014-09-22 Thread Pranith Kumar
On Mon, Sep 22, 2014 at 1:01 PM, Paul E. McKenney wrote: > On Mon, Sep 22, 2014 at 12:49:24PM -0400, Pranith Kumar wrote: >> On Mon, Sep 22, 2014 at 12:25 PM, Josh Triplett >> wrote: >> > >> > I think it would actually make more sense to do this the other

Re: [PATCH] rcu: Remove redundant CONFIG_PREEMPT_RCU option

2014-09-22 Thread Pranith Kumar
On Mon, Sep 22, 2014 at 12:25 PM, Josh Triplett wrote: > On Sun, Sep 21, 2014 at 12:49:54PM -0400, Pranith Kumar wrote: >> PREEMPT_RCU and TREE_PREEMPT_RCU serve the same function after >> TINY_PREEMPT_RCU >> has been removed. This patch removes CONFIG

Re: [PATCH] rcu: Remove redundant CONFIG_PREEMPT_RCU option

2014-09-22 Thread Pranith Kumar
On Mon, Sep 22, 2014 at 12:25 PM, Josh Triplett j...@joshtriplett.org wrote: On Sun, Sep 21, 2014 at 12:49:54PM -0400, Pranith Kumar wrote: PREEMPT_RCU and TREE_PREEMPT_RCU serve the same function after TINY_PREEMPT_RCU has been removed. This patch removes CONFIG_PREEMPT_RCU and uses

Re: [PATCH] rcu: Remove redundant CONFIG_PREEMPT_RCU option

2014-09-22 Thread Pranith Kumar
On Mon, Sep 22, 2014 at 1:01 PM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: On Mon, Sep 22, 2014 at 12:49:24PM -0400, Pranith Kumar wrote: On Mon, Sep 22, 2014 at 12:25 PM, Josh Triplett j...@joshtriplett.org wrote: I think it would actually make more sense to do this the other way

[PATCH] rcu: Remove redundant TREE_PREEMPT_RCU config option

2014-09-22 Thread Pranith Kumar
. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- Documentation/RCU/rcu.txt | 4 ++-- Documentation/RCU/stallwarn.txt| 8 Documentation/RCU/trace.txt| 4 ++-- Documentation/RCU/whatisRCU.txt| 2

[RFC PATCH] x86: Use volatile semantics for atomic_set()

2014-09-22 Thread Pranith Kumar
All the atomic operations have volatile semantics to prevent compiler reordering. Enforce the same semantics for atomic_set() too. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- arch/x86/include/asm/atomic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86

[RFC PATCH] x86: Use ACCESS_ONCE() for atomic_read()

2014-09-22 Thread Pranith Kumar
Use the much easier to read ACCESS_ONCE() which is basically the same thing as the cast to volatile. Please note the change in volatile cast: ACCESS_ONCE(v)-counter to ACCESS_ONCE(v-counter). Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- arch/x86/include/asm/atomic.h | 2 +- 1 file

Re: [RFC PATCH] x86: Use ACCESS_ONCE() for atomic_read()

2014-09-22 Thread Pranith Kumar
On Mon, Sep 22, 2014 at 4:07 PM, Peter Zijlstra pet...@infradead.org wrote: On Mon, Sep 22, 2014 at 03:53:09PM -0400, Pranith Kumar wrote: Use the much easier to read ACCESS_ONCE() which is basically the same thing as the cast to volatile. Please note the change in volatile cast

Re: [RFC PATCH] x86: Use volatile semantics for atomic_set()

2014-09-22 Thread Pranith Kumar
On Mon, Sep 22, 2014 at 4:08 PM, Peter Zijlstra pet...@infradead.org wrote: On Mon, Sep 22, 2014 at 03:39:21PM -0400, Pranith Kumar wrote: All the atomic operations have volatile semantics to prevent compiler reordering. Enforce the same semantics for atomic_set() too. To what point

[PATCH] rcu: Remove redundant CONFIG_PREEMPT_RCU option

2014-09-21 Thread Pranith Kumar
PREEMPT_RCU and TREE_PREEMPT_RCU serve the same function after TINY_PREEMPT_RCU has been removed. This patch removes CONFIG_PREEMPT_RCU and uses CONFIG_TREE_PREEMPT_RCU in its place. Signed-off-by: Pranith Kumar --- arch/xtensa/configs/s6105_defconfig | 2 +- include/linux

[PATCH] rcu: Remove redundant CONFIG_PREEMPT_RCU option

2014-09-21 Thread Pranith Kumar
PREEMPT_RCU and TREE_PREEMPT_RCU serve the same function after TINY_PREEMPT_RCU has been removed. This patch removes CONFIG_PREEMPT_RCU and uses CONFIG_TREE_PREEMPT_RCU in its place. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- arch/xtensa/configs/s6105_defconfig

Re: [RFC PATCH] rcu: Change use of __this_cpu ops on a bool type

2014-09-19 Thread Pranith Kumar
On Fri, Sep 19, 2014 at 4:57 PM, Josh Triplett wrote: > On Fri, Sep 19, 2014 at 01:26:03PM -0400, Pranith Kumar wrote: >> __this_cpu_{read/write}() uses sizeof() to determine the size of the >> variable. >> Using this operation on a bool type causes sparse to comp

[RFC PATCH] rcu: Change use of __this_cpu ops on a bool type

2014-09-19 Thread Pranith Kumar
, but let us silence it anyways. Signed-off-by: Pranith Kumar --- kernel/rcu/tree.c| 12 kernel/rcu/tree_plugin.h | 6 -- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index bc085e5..85f228a 100644 --- a/kernel/rcu/tree.c

[PATCH v2 2/3] doc: Document RCU self test boot params

2014-09-19 Thread Pranith Kumar
Document the RCU self test boot parameters in kernel-parameters.txt. Signed-off-by: Pranith Kumar --- Documentation/kernel-parameters.txt | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index c403957

[PATCH v2 0/3] Early boot self tests for RCU

2014-09-19 Thread Pranith Kumar
. I enabled the selftests in a few rcutorture configurations. Thanks! -- Pranith v2: removed srcu tests and updated according to feedback Pranith Kumar (3): rcu: Add early boot self tests doc: Document RCU self test boot params rcutorture: Enable RCU self test in configs Documentation

[PATCH v2 1/1] rcu: Add early boot self tests

2014-09-19 Thread Pranith Kumar
Add early boot self tests for RCU under CONFIG_PROVE_RCU. Currently the only test is adding a dummy callback which increments a counter which we then later verify after calling rcu_barrier*(). Signed-off-by: Pranith Kumar --- kernel/rcu/rcu.h| 2 ++ kernel/rcu/tiny.c | 4 ++- kernel

[PATCH v2 3/3] rcutorture: Enable RCU self test in configs

2014-09-19 Thread Pranith Kumar
Add config and boot parameters to enable the self tests in rcutorture testing. Signed-off-by: Pranith Kumar --- tools/testing/selftests/rcutorture/configs/rcu/TINY02 | 2 ++ tools/testing/selftests/rcutorture/configs/rcu/TINY02.boot | 2 ++ tools/testing/selftests/rcutorture/configs/rcu

[PATCH v2 1/1] rcu: Add early boot self tests

2014-09-19 Thread Pranith Kumar
Add early boot self tests for RCU under CONFIG_PROVE_RCU. Currently the only test is adding a dummy callback which increments a counter which we then later verify after calling rcu_barrier*(). Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- kernel/rcu/rcu.h| 2 ++ kernel/rcu/tiny.c

[PATCH v2 3/3] rcutorture: Enable RCU self test in configs

2014-09-19 Thread Pranith Kumar
Add config and boot parameters to enable the self tests in rcutorture testing. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- tools/testing/selftests/rcutorture/configs/rcu/TINY02 | 2 ++ tools/testing/selftests/rcutorture/configs/rcu/TINY02.boot | 2 ++ tools/testing/selftests

[PATCH v2 2/3] doc: Document RCU self test boot params

2014-09-19 Thread Pranith Kumar
Document the RCU self test boot parameters in kernel-parameters.txt. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- Documentation/kernel-parameters.txt | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt

[PATCH v2 0/3] Early boot self tests for RCU

2014-09-19 Thread Pranith Kumar
. I enabled the selftests in a few rcutorture configurations. Thanks! -- Pranith v2: removed srcu tests and updated according to feedback Pranith Kumar (3): rcu: Add early boot self tests doc: Document RCU self test boot params rcutorture: Enable RCU self test in configs Documentation

[RFC PATCH] rcu: Change use of __this_cpu ops on a bool type

2014-09-19 Thread Pranith Kumar
, but let us silence it anyways. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- kernel/rcu/tree.c| 12 kernel/rcu/tree_plugin.h | 6 -- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index bc085e5..85f228a 100644

Re: [RFC PATCH] rcu: Change use of __this_cpu ops on a bool type

2014-09-19 Thread Pranith Kumar
On Fri, Sep 19, 2014 at 4:57 PM, Josh Triplett j...@joshtriplett.org wrote: On Fri, Sep 19, 2014 at 01:26:03PM -0400, Pranith Kumar wrote: __this_cpu_{read/write}() uses sizeof() to determine the size of the variable. Using this operation on a bool type causes sparse to complain. I checked

Re: BUG in ext4_setattr

2014-09-18 Thread Pranith Kumar
On Thu, Sep 18, 2014 at 2:19 PM, Theodore Ts'o wrote: > On Thu, Sep 18, 2014 at 12:01:00PM -0400, Pranith Kumar wrote: >> >> The following splat occurs in the latest rc5+ kernel. I am not sure >> this is enough information. Please let me know what options to enable >>

Re: [RFC PATCH 1/3] rcu: Add early boot self tests

2014-09-18 Thread Pranith Kumar
On Thu, Sep 18, 2014 at 5:29 PM, Paul E. McKenney wrote: >> +static int rcu_self_test_counter; >> +static struct rcu_head head; > > This needs to be within the individual functions, because otherwise the > lists get messed up when you to multiple tests during the same boot... > Hmm, I thought

BUG in ext4_setattr

2014-09-18 Thread Pranith Kumar
Hi, The following splat occurs in the latest rc5+ kernel. I am not sure this is enough information. Please let me know what options to enable to get more meaningful info. Thanks! [ 6382.247836] [ cut here ] [ 6382.248011] Kernel BUG at c00b1a70 [verbose debug info

Re: [RFC PATCH 1/3] rcu: Add early boot self tests

2014-09-18 Thread Pranith Kumar
On Thu, Sep 18, 2014 at 5:29 PM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: +static int rcu_self_test_counter; +static struct rcu_head head; This needs to be within the individual functions, because otherwise the lists get messed up when you to multiple tests during the same boot...

Re: BUG in ext4_setattr

2014-09-18 Thread Pranith Kumar
On Thu, Sep 18, 2014 at 2:19 PM, Theodore Ts'o ty...@mit.edu wrote: On Thu, Sep 18, 2014 at 12:01:00PM -0400, Pranith Kumar wrote: The following splat occurs in the latest rc5+ kernel. I am not sure this is enough information. Please let me know what options to enable to get more meaningful

BUG in ext4_setattr

2014-09-18 Thread Pranith Kumar
Hi, The following splat occurs in the latest rc5+ kernel. I am not sure this is enough information. Please let me know what options to enable to get more meaningful info. Thanks! [ 6382.247836] [ cut here ] [ 6382.248011] Kernel BUG at c00b1a70 [verbose debug info

[RFC PATCH 0/3] Early boot self tests for RCU

2014-09-17 Thread Pranith Kumar
if they occur in the future. I enabled the selftests in a few rcutorture configurations. Thanks! -- Pranith Pranith Kumar (3): rcu: Add early boot self tests doc: Document RCU self test boot params rcutorture: Enable RCU self test in configs Documentation/kernel-parameters.txt

[RFC PATCH 0/3] Early boot self tests for RCU

2014-09-17 Thread Pranith Kumar
if they occur in the future. I enabled the selftests in a few rcutorture configurations. Thanks! -- Pranith Pranith Kumar (3): rcu: Add early boot self tests doc: Document RCU self test boot params rcutorture: Enable RCU self test in configs Documentation/kernel-parameters.txt

[RFC PATCH 3/3] rcutorture: Enable RCU self test in configs

2014-09-17 Thread Pranith Kumar
Add config and boot parameters to enable the self tests in rcutorture testing. Signed-off-by: Pranith Kumar --- tools/testing/selftests/rcutorture/configs/rcu/TINY02 | 2 ++ tools/testing/selftests/rcutorture/configs/rcu/TINY02.boot | 2 ++ tools/testing/selftests/rcutorture/configs/rcu

[RFC PATCH 2/3] doc: Document RCU self test boot params

2014-09-17 Thread Pranith Kumar
Document the RCU self test boot parameters in kernel-parameters.txt. Signed-off-by: Pranith Kumar --- Documentation/kernel-parameters.txt | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index c403957

[RFC PATCH 1/3] rcu: Add early boot self tests

2014-09-17 Thread Pranith Kumar
Add early boot self tests for RCU under CONFIG_PROVE_RCU. Currently the only test is adding a dummy callback which increments a counter which we then later verify after calling rcu_barrier*(). Signed-off-by: Pranith Kumar --- kernel/rcu/rcu.h| 2 ++ kernel/rcu/tiny.c | 4 ++- kernel

Re: [PATCH] selftests/memfd: Run test on all architectures

2014-09-17 Thread Pranith Kumar
On Wed, Sep 17, 2014 at 11:36 AM, Shuah Khan wrote: > Hmm. I am seeing failures on x86_64 on top of Linus's tree > (without this patch) > > make -C tools/testing/selftests/memfd/make: Entering directory > `/lkml/linus_git_3.14/tools/testing/selftests/memfd' > gcc -D_FILE_OFFSET_BITS=64 >

Re: [PATCH] selftests/memfd: Run test on all architectures

2014-09-17 Thread Pranith Kumar
On Wed, Sep 17, 2014 at 11:36 AM, Shuah Khan shua...@osg.samsung.com wrote: Hmm. I am seeing failures on x86_64 on top of Linus's tree (without this patch) make -C tools/testing/selftests/memfd/make: Entering directory `/lkml/linus_git_3.14/tools/testing/selftests/memfd' gcc

[RFC PATCH 1/3] rcu: Add early boot self tests

2014-09-17 Thread Pranith Kumar
Add early boot self tests for RCU under CONFIG_PROVE_RCU. Currently the only test is adding a dummy callback which increments a counter which we then later verify after calling rcu_barrier*(). Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- kernel/rcu/rcu.h| 2 ++ kernel/rcu/tiny.c

[RFC PATCH 2/3] doc: Document RCU self test boot params

2014-09-17 Thread Pranith Kumar
Document the RCU self test boot parameters in kernel-parameters.txt. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- Documentation/kernel-parameters.txt | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel

[RFC PATCH 3/3] rcutorture: Enable RCU self test in configs

2014-09-17 Thread Pranith Kumar
Add config and boot parameters to enable the self tests in rcutorture testing. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- tools/testing/selftests/rcutorture/configs/rcu/TINY02 | 2 ++ tools/testing/selftests/rcutorture/configs/rcu/TINY02.boot | 2 ++ tools/testing/selftests

[RFC PATCH 0/3] Early boot self tests for RCU

2014-09-17 Thread Pranith Kumar
if they occur in the future. I enabled the selftests in a few rcutorture configurations. Thanks! -- Pranith Pranith Kumar (3): rcu: Add early boot self tests doc: Document RCU self test boot params rcutorture: Enable RCU self test in configs Documentation/kernel-parameters.txt

[RFC PATCH 0/3] Early boot self tests for RCU

2014-09-17 Thread Pranith Kumar
if they occur in the future. I enabled the selftests in a few rcutorture configurations. Thanks! -- Pranith Pranith Kumar (3): rcu: Add early boot self tests doc: Document RCU self test boot params rcutorture: Enable RCU self test in configs Documentation/kernel-parameters.txt

[PATCH] selftests/memfd: Run test on all architectures

2014-09-15 Thread Pranith Kumar
Remove the dependence on x86 to run the memfd test. Verfied on 32-bit powerpc. Signed-off-by: Pranith Kumar --- tools/testing/selftests/memfd/Makefile | 21 - 1 file changed, 21 deletions(-) diff --git a/tools/testing/selftests/memfd/Makefile b/tools/testing/selftests

[PATCH] selftests/memfd: Run test on all architectures

2014-09-15 Thread Pranith Kumar
Remove the dependence on x86 to run the memfd test. Verfied on 32-bit powerpc. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- tools/testing/selftests/memfd/Makefile | 21 - 1 file changed, 21 deletions(-) diff --git a/tools/testing/selftests/memfd/Makefile b/tools

Re: [rcu] BUG: unable to handle kernel NULL pointer dereference at 000000da

2014-09-12 Thread Pranith Kumar
On Fri, Sep 12, 2014 at 3:02 PM, Paul E. McKenney wrote: > On Mon, Sep 01, 2014 at 04:44:04PM +0800, Fengguang Wu wrote: >> Greetings, >> >> 0day kernel testing robot got the below dmesg and the first bad commit is >> >> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master >>

Re: [rcu] BUG: unable to handle kernel NULL pointer dereference at 000000da

2014-09-12 Thread Pranith Kumar
On Fri, Sep 12, 2014 at 3:02 PM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: On Mon, Sep 01, 2014 at 04:44:04PM +0800, Fengguang Wu wrote: Greetings, 0day kernel testing robot got the below dmesg and the first bad commit is

Re: [PATCH tip/core/rcu 1/3] memory-barriers: Fix control-ordering no-transitivity example

2014-09-07 Thread Pranith Kumar
On Thu, Aug 28, 2014 at 2:12 PM, Paul E. McKenney wrote: > From: "Paul E. McKenney" > > The control-ordering example demonstrating lack of transitivity had > multiple problems. This commit fixes them. > > Reported-by: Nikolay Samofatov > Signed-off-by: Paul E.

Re: [PATCH tip/core/rcu 0/11] Torture-test changes for 3.18

2014-09-07 Thread Pranith Kumar
On Thu, Aug 28, 2014 at 3:12 PM, Paul E. McKenney wrote: > Hello! > > This series contains torture-test updates: > > 1. Fix sparse warning by making boost_mutex static, courtesy of > Pranith Kumar. > > 2. Use bash shell for all torture test scri

Re: [PATCH tip/core/rcu 0/11] Torture-test changes for 3.18

2014-09-07 Thread Pranith Kumar
On Thu, Aug 28, 2014 at 3:12 PM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: Hello! This series contains torture-test updates: 1. Fix sparse warning by making boost_mutex static, courtesy of Pranith Kumar. 2. Use bash shell for all torture test scripts, courtesy

Re: [PATCH tip/core/rcu 1/3] memory-barriers: Fix control-ordering no-transitivity example

2014-09-07 Thread Pranith Kumar
...@gmail.com Signed-off-by: Paul E. McKenney paul...@linux.vnet.ibm.com Reviewed-by: Pranith Kumar bobby.pr...@gmail.com --- Documentation/memory-barriers.txt | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/Documentation/memory-barriers.txt

Question reg. asm/qrwlock.h

2014-09-05 Thread Pranith Kumar
Hi Waiman, I see that in arch/x86/include/asm/qrwlock.h, there is this snippet within #ifndef CONFIG_X86_PPRO_FENCE #define queue_write_unlock queue_write_unlock static inline void queue_write_unlock(struct qrwlock *lock) { barrier(); ACCESS_ONCE(*(u8 *)>cnts) = 0; } #endif

Question reg. asm/qrwlock.h

2014-09-05 Thread Pranith Kumar
Hi Waiman, I see that in arch/x86/include/asm/qrwlock.h, there is this snippet within #ifndef CONFIG_X86_PPRO_FENCE #define queue_write_unlock queue_write_unlock static inline void queue_write_unlock(struct qrwlock *lock) { barrier(); ACCESS_ONCE(*(u8 *)lock-cnts) = 0; } #endif

[PATCH Resend] memfd_test: Add missing argument to printf()

2014-09-04 Thread Pranith Kumar
Add a missing path argument buf to printf() Signed-off-by: Pranith Kumar Reviewed-by: David Herrmann --- tools/testing/selftests/memfd/memfd_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests/memfd

Re: [PATCH] selftests/memfd: fix mfd_fail_open() to pass in buf to printf

2014-09-04 Thread Pranith Kumar
On Thu, Sep 4, 2014 at 11:07 AM, Shuah Khan wrote: > mfd_fail_open() doesn't pass in the buffer to printf resulting > in the following warning: > > memfd_test.c: In function ‘mfd_fail_open’: > memfd_test.c:208:3: warning: format ‘%s’ expects a matching ‘char *’ argument > [-Wformat=] >

Re: [PATCH] selftests/memfd: fix mfd_fail_open() to pass in buf to printf

2014-09-04 Thread Pranith Kumar
On Thu, Sep 4, 2014 at 11:07 AM, Shuah Khan shua...@osg.samsung.com wrote: mfd_fail_open() doesn't pass in the buffer to printf resulting in the following warning: memfd_test.c: In function ‘mfd_fail_open’: memfd_test.c:208:3: warning: format ‘%s’ expects a matching ‘char *’ argument

[PATCH Resend] memfd_test: Add missing argument to printf()

2014-09-04 Thread Pranith Kumar
Add a missing path argument buf to printf() Signed-off-by: Pranith Kumar bobby.pr...@gmail.com Reviewed-by: David Herrmann dh.herrm...@gmail.com --- tools/testing/selftests/memfd/memfd_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/memfd

Re: Bogus error in checkpatch.pl

2014-09-03 Thread Pranith Kumar
On 09/03/2014 01:34 AM, Joe Perches wrote: > Maybe. Suggest a modified message. > How about the following? diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index b602ed2..bcc384e 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2143,7 +2143,7 @@ sub process {

Re: [PATCH v2] memfd_test: Make it work on 32-bit systems

2014-09-03 Thread Pranith Kumar
On Wed, Sep 3, 2014 at 1:53 AM, David Herrmann wrote: > Sorry for the bike-shedding. Patch looks good, otherwise. With, or > without, this changed, this is: > > Reviewed-by: David Herrmann > Thank you for the review David. I will send in a new patch with your suggested changes. -- Pranith --

[PATCH v3] memfd_test: Make it work on 32-bit systems

2014-09-03 Thread Pranith Kumar
This test currently fails on 32-bit systems since we use u64 type to pass the flags to fcntl. This commit changes this to use 'unsigned int' type for flags to fcntl making it work on 32-bit systems. Signed-off-by: Pranith Kumar Reviewed-by: David Herrmann --- tools/testing/selftests/memfd

[PATCH v3] memfd_test: Make it work on 32-bit systems

2014-09-03 Thread Pranith Kumar
This test currently fails on 32-bit systems since we use u64 type to pass the flags to fcntl. This commit changes this to use 'unsigned int' type for flags to fcntl making it work on 32-bit systems. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com Reviewed-by: David Herrmann dh.herrm

Re: [PATCH v2] memfd_test: Make it work on 32-bit systems

2014-09-03 Thread Pranith Kumar
On Wed, Sep 3, 2014 at 1:53 AM, David Herrmann dh.herrm...@gmail.com wrote: Sorry for the bike-shedding. Patch looks good, otherwise. With, or without, this changed, this is: Reviewed-by: David Herrmann dh.herrm...@gmail.com Thank you for the review David. I will send in a new patch with

Re: Bogus error in checkpatch.pl

2014-09-03 Thread Pranith Kumar
On 09/03/2014 01:34 AM, Joe Perches wrote: Maybe. Suggest a modified message. How about the following? diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index b602ed2..bcc384e 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2143,7 +2143,7 @@ sub process {

Re: Bogus error in checkpatch.pl

2014-09-02 Thread Pranith Kumar
Hi Joe, On Wed, Sep 3, 2014 at 12:25 AM, Joe Perches wrote: > > You need to use parentheses around the description like: > commit ("commit description") > > For your case: > > Commit 615cc2c9cf95 ("Documentation/memory-barriers.txt: fix important > typo re memory barriers") > Ah, OK.

Bogus error in checkpatch.pl

2014-09-02 Thread Pranith Kumar
I receive an ERROR when running checkpatch.pl on a patch containing the following line: Commit 615cc2c9cf95 "Documentation/memory-barriers.txt: fix important typo re saying that the commit ID should be 12 or more characters when the commit ID is indeed 12 characters. I tried fixing it, but my

[PATCH v2] doc: memory-barriers.txt: Correct example for reorderings

2014-09-02 Thread Pranith Kumar
Correct the example of memory orderings in memory-barriers.txt Commit 615cc2c9cf95 "Documentation/memory-barriers.txt: fix important typo re memory barriers" changed the assignment to x and y. Change the rest of the example to match this change. Reported-by: Ganesh Rapolu Signed-off-b

<    1   2   3   4   5   6   7   8   9   10   >