Re: [PATCH] doc: memory-barriers.txt: Correct example for reorderings

2014-09-02 Thread Pranith Kumar
On Tue, Sep 2, 2014 at 12:08 PM, Paul E. McKenney wrote: > Could you please adjust in this way? Again, the point is to be the > first few items in a full set of permutations, not to illustrate selected > orderings/outcomes. > OK, if that is the case then replacing x with y is much easier. I

[PATCH] sh: Fix build error caused by missing dependencies

2014-09-02 Thread Pranith Kumar
] These errors are caused by missing dependencies on UNCACHED_MAPPING and MMU. Reported-by: Geert Uytterhoeven Signed-off-by: Pranith Kumar --- arch/sh/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig index 244fb4c..619d5eb 100644 --- a/arch/sh/Kconfig

[PATCH] sh: Fix build error caused by missing dependencies

2014-09-02 Thread Pranith Kumar
] These errors are caused by missing dependencies on UNCACHED_MAPPING and MMU. Reported-by: Geert Uytterhoeven ge...@linux-m68k.org Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- arch/sh/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig index 244fb4c

Re: [PATCH] doc: memory-barriers.txt: Correct example for reorderings

2014-09-02 Thread Pranith Kumar
On Tue, Sep 2, 2014 at 12:08 PM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: Could you please adjust in this way? Again, the point is to be the first few items in a full set of permutations, not to illustrate selected orderings/outcomes. OK, if that is the case then replacing x with

[PATCH v2] doc: memory-barriers.txt: Correct example for reorderings

2014-09-02 Thread Pranith Kumar
Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- Documentation/memory-barriers.txt | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt index a4de88f..02f5de8 100644

Bogus error in checkpatch.pl

2014-09-02 Thread Pranith Kumar
I receive an ERROR when running checkpatch.pl on a patch containing the following line: Commit 615cc2c9cf95 Documentation/memory-barriers.txt: fix important typo re saying that the commit ID should be 12 or more characters when the commit ID is indeed 12 characters. I tried fixing it, but my

Re: Bogus error in checkpatch.pl

2014-09-02 Thread Pranith Kumar
Hi Joe, On Wed, Sep 3, 2014 at 12:25 AM, Joe Perches j...@perches.com wrote: You need to use parentheses around the description like: commit commitid (commit description) For your case: Commit 615cc2c9cf95 (Documentation/memory-barriers.txt: fix important typo re memory barriers)

[PATCH] powerpc: Wire up three sys calls

2014-09-01 Thread Pranith Kumar
This patch wires up three new syscalls for powerpc. The three new syscalls are seccomp, getrandom and memfd_create. Signed-off-by: Pranith Kumar Reviewed-by: David Herrmann --- arch/powerpc/include/asm/systbl.h | 3 +++ arch/powerpc/include/asm/unistd.h | 2 +- arch/powerpc/include

Re: [RFC PATCH] powerpc: Wire up three syscalls

2014-09-01 Thread Pranith Kumar
On Mon, Sep 1, 2014 at 11:31 AM, David Herrmann wrote: > > Btw., the original patch (wire up syscalls) can be applied unchanged. > Great! Can I use that as an Ack-by? I will send in the patch with updated changelog. -- Pranith -- To unsubscribe from this list: send the line "unsubscribe

[PATCH v2] memfd_test: Make it work on 32-bit systems

2014-09-01 Thread Pranith Kumar
This test currently fails on 32-bit systems since we use u64 type to pass the flags to fcntl. This commit changes this to use 'unsigned int' type for flags to fcntl making it work on 32-bit systems. Signed-off-by: Pranith Kumar --- v2: use 'unsigned int' instead of u32 tools/testing/selftests

Re: [RFC PATCH] powerpc: Wire up three syscalls

2014-09-01 Thread Pranith Kumar
Hi David, On Mon, Sep 1, 2014 at 7:33 AM, David Herrmann wrote: > > Nice catch. We changed 'flags' from u64 to "unsigned int" in the last > revision of the series. Patch looks good, but I'd prefer using > "unsigned int" as type, instead of __u32. Just to be consistent with > the syscall

Re: [RFC PATCH] powerpc: Wire up three syscalls

2014-09-01 Thread Pranith Kumar
Hi David, On Mon, Sep 1, 2014 at 7:33 AM, David Herrmann dh.herrm...@gmail.com wrote: Nice catch. We changed 'flags' from u64 to unsigned int in the last revision of the series. Patch looks good, but I'd prefer using unsigned int as type, instead of __u32. Just to be consistent with the

[PATCH v2] memfd_test: Make it work on 32-bit systems

2014-09-01 Thread Pranith Kumar
This test currently fails on 32-bit systems since we use u64 type to pass the flags to fcntl. This commit changes this to use 'unsigned int' type for flags to fcntl making it work on 32-bit systems. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- v2: use 'unsigned int' instead of u32

Re: [RFC PATCH] powerpc: Wire up three syscalls

2014-09-01 Thread Pranith Kumar
On Mon, Sep 1, 2014 at 11:31 AM, David Herrmann dh.herrm...@gmail.com wrote: Btw., the original patch (wire up syscalls) can be applied unchanged. Great! Can I use that as an Ack-by? I will send in the patch with updated changelog. -- Pranith -- To unsubscribe from this list: send the line

[PATCH] powerpc: Wire up three sys calls

2014-09-01 Thread Pranith Kumar
This patch wires up three new syscalls for powerpc. The three new syscalls are seccomp, getrandom and memfd_create. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com Reviewed-by: David Herrmann dh.herrm...@gmail.com --- arch/powerpc/include/asm/systbl.h | 3 +++ arch/powerpc/include/asm

[PATCH] memfd_test: Add missing argument to printf()

2014-08-31 Thread Pranith Kumar
Add a missing path argument buf to printf() Signed-off-by: Pranith Kumar --- tools/testing/selftests/memfd/memfd_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests/memfd/memfd_test.c index 3634c90

Re: [RFC PATCH] powerpc: Wire up three syscalls

2014-08-31 Thread Pranith Kumar
Thanks! -- Pranith From: Pranith Kumar Date: Sun, 31 Aug 2014 13:38:07 -0400 Subject: [PATCH] memfd_test: Make it work on 32-bit systems This test currently fails on 32-bit systems since we use u64 type to pass the flags to fcntl. This commit changes this to use u32 type for flags to fcntl

Re: [RFC PATCH] powerpc: Wire up three syscalls

2014-08-31 Thread Pranith Kumar
Hi Geert, On Sun, Aug 31, 2014 at 4:53 AM, Geert Uytterhoeven wrote: > Hi Pranith, > > On Sat, Aug 30, 2014 at 5:36 AM, Pranith Kumar wrote: >> I see that the three syscalls seccomp, getrandom and memfd_create are not >> wired >> because of which we get a warning wh

Re: [RFC PATCH] powerpc: Wire up three syscalls

2014-08-31 Thread Pranith Kumar
Hi Geert, On Sun, Aug 31, 2014 at 4:53 AM, Geert Uytterhoeven ge...@linux-m68k.org wrote: Hi Pranith, On Sat, Aug 30, 2014 at 5:36 AM, Pranith Kumar bobby.pr...@gmail.com wrote: I see that the three syscalls seccomp, getrandom and memfd_create are not wired because of which we get

Re: [RFC PATCH] powerpc: Wire up three syscalls

2014-08-31 Thread Pranith Kumar
on 32-bit systems. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- tools/testing/selftests/memfd/memfd_test.c | 32 +++--- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests/memfd

[PATCH] memfd_test: Add missing argument to printf()

2014-08-31 Thread Pranith Kumar
Add a missing path argument buf to printf() Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- tools/testing/selftests/memfd/memfd_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests/memfd

[RFC PATCH] powerpc: Wire up three syscalls

2014-08-29 Thread Pranith Kumar
for this to work? Any advice is really appreciated! :) Signed-off-by: Pranith Kumar --- arch/powerpc/include/asm/systbl.h | 3 +++ arch/powerpc/include/asm/unistd.h | 2 +- arch/powerpc/include/uapi/asm/unistd.h | 3 +++ 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/powerpc

[RFC PATCH] powerpc: Wire up three syscalls

2014-08-29 Thread Pranith Kumar
for this to work? Any advice is really appreciated! :) Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- arch/powerpc/include/asm/systbl.h | 3 +++ arch/powerpc/include/asm/unistd.h | 2 +- arch/powerpc/include/uapi/asm/unistd.h | 3 +++ 3 files changed, 7 insertions(+), 1 deletion(-) diff

Re: [PATCH] doc: memory-barriers.txt: Correct example for reorderings

2014-08-28 Thread Pranith Kumar
On Thu, Aug 28, 2014 at 5:39 PM, Paul E. McKenney wrote: > On Thu, Aug 28, 2014 at 05:15:50PM -0400, Pranith Kumar wrote: >> On Thu, Aug 28, 2014 at 5:00 PM, Paul E. McKenney >> wrote: >> > >> > I am really confused by the ordering of the new lines, as I

Re: [PATCH] doc: memory-barriers.txt: Correct example for reorderings

2014-08-28 Thread Pranith Kumar
On Thu, Aug 28, 2014 at 5:00 PM, Paul E. McKenney wrote: > > I am really confused by the ordering of the new lines, as I would have > expected the "x"s to be replaced with "y"s and vice versa. But the > ordering of the various combinations does not matter, and each line > looks OK. > Since x =

Re: [PATCH] doc: memory-barriers.txt: Correct example for reorderings

2014-08-28 Thread Pranith Kumar
On Thu, Aug 28, 2014 at 5:00 PM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: I am really confused by the ordering of the new lines, as I would have expected the xs to be replaced with ys and vice versa. But the ordering of the various combinations does not matter, and each line looks

Re: [PATCH] doc: memory-barriers.txt: Correct example for reorderings

2014-08-28 Thread Pranith Kumar
On Thu, Aug 28, 2014 at 5:39 PM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: On Thu, Aug 28, 2014 at 05:15:50PM -0400, Pranith Kumar wrote: On Thu, Aug 28, 2014 at 5:00 PM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: I am really confused by the ordering of the new lines, as I

Re: [PATCH] rcu: Make nocb leader kthreads process pending callbacks after spawning

2014-08-27 Thread Pranith Kumar
On Wed, Aug 27, 2014 at 5:47 PM, Paul E. McKenney wrote: > > Thank you, Pranith, queued. I have also backported to v3.17-rc2, > and am testing both. A sneak preview of the backport is shown below, > please let me know if you see any problems with it. (The reason for > the backport is to submit

[PATCH] rcu: Make nocb leader kthreads process pending callbacks after spawning

2014-08-27 Thread Pranith Kumar
ads to run immediately after spawning instead of waiting. This is done by inverting the logic of nocb_leader_wake tests to nocb_leader_sleep which allows us to use the default initialization of this flag to 0 to let the kthreads run. Reported-by: Amit Shah Signed-off-by: Pranith Kumar

Re: [PATCH tip/core/rcu 1/2] rcu: Parallelize and economize NOCB kthread wakeups

2014-08-27 Thread Pranith Kumar
On Wed, Aug 27, 2014 at 12:21 PM, Paul E. McKenney wrote: > On Wed, Aug 27, 2014 at 10:13:50AM +0530, Amit Shah wrote: >> >> Yes, this patch helps my case as well. > > Very good!!! > > Pranith, I can take this patch, but would you be willing to invert > the sense of ->nocb_leader_wake (e.g.,

Re: [PATCH tip/core/rcu 1/2] rcu: Parallelize and economize NOCB kthread wakeups

2014-08-27 Thread Pranith Kumar
On Wed, Aug 27, 2014 at 12:21 PM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: On Wed, Aug 27, 2014 at 10:13:50AM +0530, Amit Shah wrote: Yes, this patch helps my case as well. Very good!!! Pranith, I can take this patch, but would you be willing to invert the sense of

[PATCH] rcu: Make nocb leader kthreads process pending callbacks after spawning

2014-08-27 Thread Pranith Kumar
immediately after spawning instead of waiting. This is done by inverting the logic of nocb_leader_wake tests to nocb_leader_sleep which allows us to use the default initialization of this flag to 0 to let the kthreads run. Reported-by: Amit Shah amit.s...@redhat.com Signed-off-by: Pranith Kumar

Re: [PATCH] rcu: Make nocb leader kthreads process pending callbacks after spawning

2014-08-27 Thread Pranith Kumar
On Wed, Aug 27, 2014 at 5:47 PM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: Thank you, Pranith, queued. I have also backported to v3.17-rc2, and am testing both. A sneak preview of the backport is shown below, please let me know if you see any problems with it. (The reason for the

Re: [PATCH 00/16] rcu: Some minor fixes and cleanups

2014-08-26 Thread Pranith Kumar
On Wed, Jul 23, 2014 at 10:45 AM, Paul E. McKenney wrote: > On Wed, Jul 23, 2014 at 01:09:37AM -0400, Pranith Kumar wrote: >> Hi Paul, >> >> This is a series of minor fixes and cleanup patches which I found while >> studying >> the code. All my previous pen

Re: [PATCH 00/16] rcu: Some minor fixes and cleanups

2014-08-26 Thread Pranith Kumar
On Wed, Jul 23, 2014 at 10:45 AM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: On Wed, Jul 23, 2014 at 01:09:37AM -0400, Pranith Kumar wrote: Hi Paul, This is a series of minor fixes and cleanup patches which I found while studying the code. All my previous pending (but not rejected

Re: [PATCH] serial: Fix build failure caused by missing header file

2014-08-25 Thread Pranith Kumar
On Mon, Aug 25, 2014 at 4:13 PM, Greg Kroah-Hartman wrote: > Where is this failing? What arch? What kernel version did it show up > in (i.e. what commit caused this problem?) > This was a randconfig on powerpc. I did not bisect as to which commit introduced this since it is a simple missing

[PATCH] doc: memory-barriers.txt: Correct example for reorderings

2014-08-25 Thread Pranith Kumar
Correct the example of memory orderings in memory-barriers.txt Commit 615cc2c9cf95 "Documentation/memory-barriers.txt: fix important typo re memory barriers" changed the assignment to x and y. Change the rest of the example to match this change. Reported-by: Ganesh Rapolu Signed-off-b

[PATCH] doc: memory-barriers.txt: Correct example for reorderings

2014-08-25 Thread Pranith Kumar
Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- Documentation/memory-barriers.txt | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt index a4de88f..cf31875 100644

Re: [PATCH] serial: Fix build failure caused by missing header file

2014-08-25 Thread Pranith Kumar
On Mon, Aug 25, 2014 at 4:13 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: Where is this failing? What arch? What kernel version did it show up in (i.e. what commit caused this problem?) This was a randconfig on powerpc. I did not bisect as to which commit introduced this since

Re: [PATCH tip/core/rcu 1/2] rcu: Parallelize and economize NOCB kthread wakeups

2014-08-23 Thread Pranith Kumar
On Sat, Aug 23, 2014 at 11:23 PM, Paul E. McKenney wrote: > On Sat, Aug 23, 2014 at 08:26:10PM -0400, Pranith Kumar wrote: >> On Sat, Aug 23, 2014 at 12:51 PM, Paul E. McKenney >> wrote: >> >> > It might well! Another possibility is that the earl

Re: [PATCH tip/core/rcu 1/2] rcu: Parallelize and economize NOCB kthread wakeups

2014-08-23 Thread Pranith Kumar
On Sat, Aug 23, 2014 at 12:51 PM, Paul E. McKenney wrote: > It might well! Another possibility is that the early_initcall function > doing the synchronize_rcu() is happening before the early_initcall > creating the RCU grace-period kthreads. > > Seems like we need to close both holes. Let's

Re: [PATCH tip/core/rcu 1/2] rcu: Parallelize and economize NOCB kthread wakeups

2014-08-23 Thread Pranith Kumar
On Fri, Aug 22, 2014 at 5:53 PM, Paul E. McKenney wrote: > > Hmmm... Please try replacing the synchronize_rcu() in > __sysrq_swap_key_ops() with (say) schedule_timeout_interruptible(HZ / 10). > I bet that gets rid of the hang. (And also introduces a low-probability > bug, but should be OK for

Re: [PATCH tip/core/rcu 1/2] rcu: Parallelize and economize NOCB kthread wakeups

2014-08-23 Thread Pranith Kumar
On Fri, Aug 22, 2014 at 5:53 PM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: Hmmm... Please try replacing the synchronize_rcu() in __sysrq_swap_key_ops() with (say) schedule_timeout_interruptible(HZ / 10). I bet that gets rid of the hang. (And also introduces a low-probability bug,

Re: [PATCH tip/core/rcu 1/2] rcu: Parallelize and economize NOCB kthread wakeups

2014-08-23 Thread Pranith Kumar
On Sat, Aug 23, 2014 at 12:51 PM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: It might well! Another possibility is that the early_initcall function doing the synchronize_rcu() is happening before the early_initcall creating the RCU grace-period kthreads. Seems like we need to close

Re: [PATCH tip/core/rcu 1/2] rcu: Parallelize and economize NOCB kthread wakeups

2014-08-23 Thread Pranith Kumar
On Sat, Aug 23, 2014 at 11:23 PM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: On Sat, Aug 23, 2014 at 08:26:10PM -0400, Pranith Kumar wrote: On Sat, Aug 23, 2014 at 12:51 PM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: It might well! Another possibility

[PATCH] powerpc: edac: Fix build error

2014-08-21 Thread Pranith Kumar
for the relevant headers to be included. Also if PPC_DCR_MMIO=n the build fails. So make PPC_DCR depend on both these options. This is compile tested only. Signed-off-by: Pranith Kumar CC: Andrew Morton --- arch/powerpc/Kconfig | 6 +++--- drivers/edac/ppc4xx_edac.c | 8 2 files changed, 7

Re: [PATCH] edac: Fix build error caused by wrong member access

2014-08-21 Thread Pranith Kumar
On Thu, Aug 21, 2014 at 5:28 PM, Andrew Morton wrote: > > This driver seems pretty unhealthy and I suspect it has been > broken for quite a while. > > drivers/edac/ppc4xx_edac.c: In function 'mfsdram': > drivers/edac/ppc4xx_edac.c:249: error: implicit declaration of function > '__mfdcri' >

[PATCH] powerpc: Fix build failure when CONFIG_USB=y

2014-08-21 Thread Pranith Kumar
-by: Pranith Kumar --- arch/powerpc/platforms/44x/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig index 3e7deb2..82f2da2 100644 --- a/arch/powerpc/platforms/44x/Kconfig +++ b/arch/powerpc/platforms/44x

[PATCH] powerpc: Fix build failure

2014-08-21 Thread Pranith Kumar
-by: Pranith Kumar --- arch/powerpc/platforms/44x/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig index 4d88f6a..3e7deb2 100644 --- a/arch/powerpc/platforms/44x/Kconfig +++ b/arch/powerpc/platforms/44x

[PATCH] fbdev: Remove __init from chips_hw_init() to fix build failure

2014-08-21 Thread Pranith Kumar
chips_hw_init(). The other thing that could have been done was annotating chipsfb_pci_init(). But that cannot be done since chipsfb_pci_init() is called from non __init functions. Signed-off-by: Pranith Kumar --- drivers/video/fbdev/chipsfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] fbdev: Remove __init from chips_hw_init() to fix build failure

2014-08-21 Thread Pranith Kumar
chips_hw_init(). The other thing that could have been done was annotating chipsfb_pci_init(). But that cannot be done since chipsfb_pci_init() is called from non __init functions. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- drivers/video/fbdev/chipsfb.c | 2 +- 1 file changed, 1

[PATCH] powerpc: Fix build failure

2014-08-21 Thread Pranith Kumar
-by: Pranith Kumar bobby.pr...@gmail.com --- arch/powerpc/platforms/44x/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig index 4d88f6a..3e7deb2 100644 --- a/arch/powerpc/platforms/44x/Kconfig +++ b/arch

[PATCH] powerpc: Fix build failure when CONFIG_USB=y

2014-08-21 Thread Pranith Kumar
-by: Pranith Kumar bobby.pr...@gmail.com --- arch/powerpc/platforms/44x/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig index 3e7deb2..82f2da2 100644 --- a/arch/powerpc/platforms/44x/Kconfig +++ b/arch

Re: [PATCH] edac: Fix build error caused by wrong member access

2014-08-21 Thread Pranith Kumar
On Thu, Aug 21, 2014 at 5:28 PM, Andrew Morton a...@linux-foundation.org wrote: This driver seems pretty unhealthy and I suspect it has been broken for quite a while. drivers/edac/ppc4xx_edac.c: In function 'mfsdram': drivers/edac/ppc4xx_edac.c:249: error: implicit declaration of function

[PATCH] powerpc: edac: Fix build error

2014-08-21 Thread Pranith Kumar
for the relevant headers to be included. Also if PPC_DCR_MMIO=n the build fails. So make PPC_DCR depend on both these options. This is compile tested only. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com CC: Andrew Morton a...@linux-foundation.org --- arch/powerpc/Kconfig | 6 +++--- drivers/edac

Re: [PATCH v2] powerpc: booke_wdt: Fix build error as a module

2014-08-20 Thread Pranith Kumar
On Wed, Aug 20, 2014 at 4:10 PM, Guenter Roeck wrote: > On Wed, Aug 20, 2014 at 03:26:46PM -0400, Pranith Kumar wrote: >> Building booke_wdt fails when trying to build as a module as there is no >> early_param() in module. Fix by using module_param() instead of >> early_para

[PATCH v2] powerpc: booke_wdt: Fix build error as a module

2014-08-20 Thread Pranith Kumar
Building booke_wdt fails when trying to build as a module as there is no early_param() in module. Fix by using module_param() instead of early_param(). Signed-off-by: Pranith Kumar CC: Guenter Roeck --- drivers/watchdog/booke_wdt.c | 28 +--- 1 file changed, 5

Re: [PATCH] powerpc: booke_wdt: Fix build error as a module

2014-08-20 Thread Pranith Kumar
On Wed, Aug 20, 2014 at 3:18 PM, Pranith Kumar wrote: > On Wed, Aug 20, 2014 at 2:59 PM, Guenter wrote: >> >> Any reason for changing the default from false to true ? >> Unless you have a reaslly good reason, I don't think that is a good idea. > > I don't see wher

Re: [PATCH] powerpc: booke_wdt: Fix build error as a module

2014-08-20 Thread Pranith Kumar
On Wed, Aug 20, 2014 at 2:59 PM, Guenter wrote: > On Wed, Aug 20, 2014 at 12:55:44PM -0400, Pranith Kumar wrote: >> Building booke_wdt fails when trying to build as a module as there is no >> early_param() in module. Fix by using module_param() instead of >> early_para

[PATCH] serial: Fix build failure caused by missing header file

2014-08-20 Thread Pranith Kumar
Fix build failure caused by missing header file: drivers/tty/serial/nwpserial.c: In function 'wait_for_bits': drivers/tty/serial/nwpserial.c:53:3: error: implicit declaration of function 'udelay' [-Werror=implicit-function-declaration] Signed-off-by: Pranith Kumar --- drivers/tty/serial

[PATCH] powerpc: booke_wdt: Fix build error as a module

2014-08-20 Thread Pranith Kumar
Building booke_wdt fails when trying to build as a module as there is no early_param() in module. Fix by using module_param() instead of early_param(). Signed-off-by: Pranith Kumar CC: Guenter Roeck --- drivers/watchdog/booke_wdt.c | 28 +--- 1 file changed, 5

Re: [PATCH] booke_wdt: Fix build failure as a module

2014-08-20 Thread Pranith Kumar
On Wed, Aug 20, 2014 at 9:25 AM, Guenter Roeck wrote: > On Tue, Aug 19, 2014 at 11:12:07PM -0400, Pranith Kumar wrote: >> Building booke_wdt fails when trying to build as a module as there is no >> early_param() in module. Fix by enclosing within MODULE check. >> &g

Re: [RFC PATCH] powerpc: Make SPU_FS depend on SPARSEMEM

2014-08-20 Thread Pranith Kumar
On Wed, Aug 20, 2014 at 3:49 AM, Geert Uytterhoeven wrote: > Is this a randconfig kernel? Yes, randconfig with ARCH=powerpc. > > config ARCH_SPARSEMEM_DEFAULT >def_bool y >depends on (SMP && PPC_PSERIES) || PPC_PS3 > > Why is this not enabled? !SMP? !PPC_PSERIES? !PPC_PS3?

Re: [PATCH] powerpc: Fix build failure when MEMORY_HOTPLUG=y

2014-08-20 Thread Pranith Kumar
On Wed, Aug 20, 2014 at 4:00 AM, Geert Uytterhoeven wrote: >> 1.9.1 > > In light of my investigation for your spufs patch, I guess this is a non-SMP > PSERIES config? So what happens is SELECT_MEMORY_MODEL choses FLATMEM_MANUAL because of which SPARSEMEM is not enabled despite having

[tip:sched/core] sched: Match declaration with definition

2014-08-20 Thread tip-bot for Pranith Kumar
Commit-ID: 8b06c55bdb8b402cb4814e83dc4b1cb245fcc9f5 Gitweb: http://git.kernel.org/tip/8b06c55bdb8b402cb4814e83dc4b1cb245fcc9f5 Author: Pranith Kumar AuthorDate: Wed, 13 Aug 2014 13:28:12 -0400 Committer: Ingo Molnar CommitDate: Wed, 20 Aug 2014 09:47:19 +0200 sched: Match declaration

[tip:sched/core] sched: Match declaration with definition

2014-08-20 Thread tip-bot for Pranith Kumar
Commit-ID: 8b06c55bdb8b402cb4814e83dc4b1cb245fcc9f5 Gitweb: http://git.kernel.org/tip/8b06c55bdb8b402cb4814e83dc4b1cb245fcc9f5 Author: Pranith Kumar bobby.pr...@gmail.com AuthorDate: Wed, 13 Aug 2014 13:28:12 -0400 Committer: Ingo Molnar mi...@kernel.org CommitDate: Wed, 20 Aug 2014 09

Re: [RFC PATCH] powerpc: Make SPU_FS depend on SPARSEMEM

2014-08-20 Thread Pranith Kumar
On Wed, Aug 20, 2014 at 3:49 AM, Geert Uytterhoeven ge...@linux-m68k.org wrote: Is this a randconfig kernel? Yes, randconfig with ARCH=powerpc. config ARCH_SPARSEMEM_DEFAULT def_bool y depends on (SMP PPC_PSERIES) || PPC_PS3 Why is this not enabled? !SMP? !PPC_PSERIES?

Re: [PATCH] powerpc: Fix build failure when MEMORY_HOTPLUG=y

2014-08-20 Thread Pranith Kumar
On Wed, Aug 20, 2014 at 4:00 AM, Geert Uytterhoeven ge...@linux-m68k.org wrote: 1.9.1 In light of my investigation for your spufs patch, I guess this is a non-SMP PSERIES config? So what happens is SELECT_MEMORY_MODEL choses FLATMEM_MANUAL because of which SPARSEMEM is not enabled despite

Re: [PATCH] booke_wdt: Fix build failure as a module

2014-08-20 Thread Pranith Kumar
On Wed, Aug 20, 2014 at 9:25 AM, Guenter Roeck li...@roeck-us.net wrote: On Tue, Aug 19, 2014 at 11:12:07PM -0400, Pranith Kumar wrote: Building booke_wdt fails when trying to build as a module as there is no early_param() in module. Fix by enclosing within MODULE check. Might make more sense

[PATCH] serial: Fix build failure caused by missing header file

2014-08-20 Thread Pranith Kumar
Fix build failure caused by missing header file: drivers/tty/serial/nwpserial.c: In function 'wait_for_bits': drivers/tty/serial/nwpserial.c:53:3: error: implicit declaration of function 'udelay' [-Werror=implicit-function-declaration] Signed-off-by: Pranith Kumar bobby.pr...@gmail.com

[PATCH] powerpc: booke_wdt: Fix build error as a module

2014-08-20 Thread Pranith Kumar
Building booke_wdt fails when trying to build as a module as there is no early_param() in module. Fix by using module_param() instead of early_param(). Signed-off-by: Pranith Kumar bobby.pr...@gmail.com CC: Guenter Roeck li...@roeck-us.net --- drivers/watchdog/booke_wdt.c | 28

Re: [PATCH] powerpc: booke_wdt: Fix build error as a module

2014-08-20 Thread Pranith Kumar
On Wed, Aug 20, 2014 at 2:59 PM, Guenter li...@roeck-us.net wrote: On Wed, Aug 20, 2014 at 12:55:44PM -0400, Pranith Kumar wrote: Building booke_wdt fails when trying to build as a module as there is no early_param() in module. Fix by using module_param() instead of early_param(). Signed

Re: [PATCH] powerpc: booke_wdt: Fix build error as a module

2014-08-20 Thread Pranith Kumar
On Wed, Aug 20, 2014 at 3:18 PM, Pranith Kumar bobby.pr...@gmail.com wrote: On Wed, Aug 20, 2014 at 2:59 PM, Guenter li...@roeck-us.net wrote: Any reason for changing the default from false to true ? Unless you have a reaslly good reason, I don't think that is a good idea. I don't see where

[PATCH v2] powerpc: booke_wdt: Fix build error as a module

2014-08-20 Thread Pranith Kumar
Building booke_wdt fails when trying to build as a module as there is no early_param() in module. Fix by using module_param() instead of early_param(). Signed-off-by: Pranith Kumar bobby.pr...@gmail.com CC: Guenter Roeck li...@roeck-us.net --- drivers/watchdog/booke_wdt.c | 28

Re: [PATCH v2] powerpc: booke_wdt: Fix build error as a module

2014-08-20 Thread Pranith Kumar
On Wed, Aug 20, 2014 at 4:10 PM, Guenter Roeck li...@roeck-us.net wrote: On Wed, Aug 20, 2014 at 03:26:46PM -0400, Pranith Kumar wrote: Building booke_wdt fails when trying to build as a module as there is no early_param() in module. Fix by using module_param() instead of early_param

[PATCH] powerpc: fsl_pamu_domain: Fix build error

2014-08-19 Thread Pranith Kumar
identifier is reported only once for each function it appears in make[2]: *** [drivers/iommu/fsl_pamu_domain.o] Error 1 make[1]: *** [drivers/iommu] Error 2 make: *** [drivers] Error 2 We fix this by trying to dereference pci_bus_type only if CONFIG_PCI is defined. Signed-off-by: Pranith Kumar

[PATCH] powerpc: Export dcr_ind_lock to fix build error

2014-08-19 Thread Pranith Kumar
Fix build error caused by missing export: ERROR: "dcr_ind_lock" [drivers/net/ethernet/ibm/emac/ibm_emac.ko] undefined! Signed-off-by: Pranith Kumar --- arch/powerpc/sysdev/dcr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/sysdev/dcr.c b/arch/powerpc/sysdev/d

[PATCH] booke_wdt: Fix build failure as a module

2014-08-19 Thread Pranith Kumar
Building booke_wdt fails when trying to build as a module as there is no early_param() in module. Fix by enclosing within MODULE check. Also remove notrace attribute as it is implicit in the __init attribute. Signed-off-by: Pranith Kumar --- drivers/watchdog/booke_wdt.c | 5 - 1 file

Re: [PATCH] powerpc: Make 256k pages depend on PPC32=n

2014-08-19 Thread Pranith Kumar
On Tue, Aug 19, 2014 at 6:19 PM, Scott Wood wrote: >> config PPC_256K_PAGES >> bool "256k page size" if 44x >> - depends on !STDBINUTILS >> + depends on !PPC32 && !STDBINUTILS >> help >> Make the page size 256k. >> > > How will this ever be selected then? 44x is

[PATCH] powerpc: Make 256k pages depend on PPC32=n

2014-08-19 Thread Pranith Kumar
256k pages are not tested on PPC32. On a randconfig I got the following error: arch/powerpc/kernel/misc_32.S:1171: Error: operand out of range (0x0001 is not between 0x8000 and 0x7fff) Disable 256K pages if PPC32=y Signed-off-by: Pranith Kumar --- arch

[RFC PATCH] powerpc: Make SPU_FS depend on SPARSEMEM

2014-08-19 Thread Pranith Kumar
SPU_FS unconditionally enables MEMORY_HOTPLUG, which will fail to build if SPARSEMEM=n. Make SPU_FS depend on SPARSEMEM so that hotplug-memory.c does not fail to compile. Signed-off-by: Pranith Kumar --- arch/powerpc/platforms/cell/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] edac: Fix build error caused by wrong member access

2014-08-19 Thread Pranith Kumar
Fix the following error drivers/edac/ppc4xx_edac.c:977:45: error: request for member 'dimm' in something not a structure or union by changing member access to pointer dereference Signed-off-by: Pranith Kumar CC: Andre Morton --- drivers/edac/ppc4xx_edac.c | 2 +- 1 file changed, 1 insertion

[PATCH] powerpc: Fix build failure when MEMORY_HOTPLUG=y

2014-08-19 Thread Pranith Kumar
/hotplug-memory.c:98:34: error: 'SECTION_SIZE_BITS' undeclared (first use in this function) make[2]: *** [arch/powerpc/platforms/pseries/hotplug-memory.o] Error 1 Signed-off-by: Pranith Kumar CC: Andew Morton --- arch/powerpc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc

[PATCH] powerpc: Fix build failure when MEMORY_HOTPLUG=y

2014-08-19 Thread Pranith Kumar
/hotplug-memory.c:98:34: error: 'SECTION_SIZE_BITS' undeclared (first use in this function) make[2]: *** [arch/powerpc/platforms/pseries/hotplug-memory.o] Error 1 Signed-off-by: Pranith Kumar bobby.pr...@gmail.com CC: Andew Morton a...@linux-foundation.org --- arch/powerpc/Kconfig | 1 + 1 file

[PATCH] edac: Fix build error caused by wrong member access

2014-08-19 Thread Pranith Kumar
Fix the following error drivers/edac/ppc4xx_edac.c:977:45: error: request for member 'dimm' in something not a structure or union by changing member access to pointer dereference Signed-off-by: Pranith Kumar bobby.pr...@gmail.com CC: Andre Morton a...@linux-foundation.org --- drivers/edac

[RFC PATCH] powerpc: Make SPU_FS depend on SPARSEMEM

2014-08-19 Thread Pranith Kumar
SPU_FS unconditionally enables MEMORY_HOTPLUG, which will fail to build if SPARSEMEM=n. Make SPU_FS depend on SPARSEMEM so that hotplug-memory.c does not fail to compile. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- arch/powerpc/platforms/cell/Kconfig | 2 +- 1 file changed, 1

[PATCH] powerpc: Make 256k pages depend on PPC32=n

2014-08-19 Thread Pranith Kumar
256k pages are not tested on PPC32. On a randconfig I got the following error: arch/powerpc/kernel/misc_32.S:1171: Error: operand out of range (0x0001 is not between 0x8000 and 0x7fff) Disable 256K pages if PPC32=y Signed-off-by: Pranith Kumar bobby.pr

Re: [PATCH] powerpc: Make 256k pages depend on PPC32=n

2014-08-19 Thread Pranith Kumar
On Tue, Aug 19, 2014 at 6:19 PM, Scott Wood scottw...@freescale.com wrote: config PPC_256K_PAGES bool 256k page size if 44x - depends on !STDBINUTILS + depends on !PPC32 !STDBINUTILS help Make the page size 256k. How will this ever be selected then? 44x is

[PATCH] booke_wdt: Fix build failure as a module

2014-08-19 Thread Pranith Kumar
Building booke_wdt fails when trying to build as a module as there is no early_param() in module. Fix by enclosing within MODULE check. Also remove notrace attribute as it is implicit in the __init attribute. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- drivers/watchdog/booke_wdt.c

[PATCH] powerpc: Export dcr_ind_lock to fix build error

2014-08-19 Thread Pranith Kumar
Fix build error caused by missing export: ERROR: dcr_ind_lock [drivers/net/ethernet/ibm/emac/ibm_emac.ko] undefined! Signed-off-by: Pranith Kumar bobby.pr...@gmail.com --- arch/powerpc/sysdev/dcr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/sysdev/dcr.c b/arch/powerpc

[PATCH] powerpc: fsl_pamu_domain: Fix build error

2014-08-19 Thread Pranith Kumar
identifier is reported only once for each function it appears in make[2]: *** [drivers/iommu/fsl_pamu_domain.o] Error 1 make[1]: *** [drivers/iommu] Error 2 make: *** [drivers] Error 2 We fix this by trying to dereference pci_bus_type only if CONFIG_PCI is defined. Signed-off-by: Pranith Kumar bobby.pr

[PATCH] powerpc: Fix build error caused by vga16fb

2014-08-18 Thread Pranith Kumar
It was noted by Geert that in PPC, no one is setting vgacon_remap_base because of which it working on PPC is suspect. Fix the build failure by disabling vga16fb on PPC. Signed-off-by: Pranith Kumar Reported-by: Geert Uytterhoeven CC: Andrew Morton --- drivers/video/fbdev/Kconfig | 2 +- 1 file changed

Re: [PATCH] powerpc: Fix build error for vga16fb

2014-08-18 Thread Pranith Kumar
On Mon, Aug 18, 2014 at 5:28 PM, Geert Uytterhoeven wrote: > Digging a bit deeper: There's no code left in arch/powerpc that actually > sets vgacon_remap_base, so it's not gonna work anyway. > It seems vga16 support on PPC died with the removal of arch/ppc/. OK. I will remove the dependency on

[PATCH] powerpc: Fix build error for vga16fb

2014-08-18 Thread Pranith Kumar
as vgacon_remap_base is exported only when CONFIG_VGA_CONSOLE=y. Fix the error by making FB_VBA16 depend on CONFIG_VGA_CONSOLE. Signed-off-by: Pranith Kumar Reported-by: Geert Uytterhoeven CC: Andrew Morton --- drivers/video/fbdev/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2] ppc: Fix build error with CONFIG_PCI=n

2014-08-18 Thread Pranith Kumar
which depends on ARCH_MAY_HAVE_PC_FDC which is in-turn enabled if PPC_PSERIES=n. The following commit changes the dependency so that ARCH_MAY_HAVE_PC_FDC is dependent exclusively on PCI since otherwise it will not compile. Signed-off-by: Pranith Kumar Reported-by: Geert Uytterhoeven CC: Andrew

Re: [PATCH] powerpc: Fix build failure for PPC_32

2014-08-18 Thread Pranith Kumar
On Mon, Aug 18, 2014 at 4:57 PM, Geert Uytterhoeven wrote: > > Note that PowerPC supports multi-platform kernels. > A kernel with PPC_PSERIES and something else with PCI may still want to > have floppy support. OK, I tested with your change and it works. I needed to make one more change for it

Re: [PATCH] powerpc: Fix build failure for PPC_32

2014-08-18 Thread Pranith Kumar
On Mon, Aug 18, 2014 at 3:28 PM, Geert Uytterhoeven wrote: > > Hi Pranith, > > On Mon, Aug 18, 2014 at 9:01 PM, Pranith Kumar wrote: > > Fix ppc 32 build failure as reported here: > > > > http://kisskb.ellerman.id.au/kisskb/buildresult/11663513/ > > | arch

[PATCH] powerpc: Fix build failure for PPC_32

2014-08-18 Thread Pranith Kumar
Fix ppc 32 build failure as reported here: http://kisskb.ellerman.id.au/kisskb/buildresult/11663513/ The error is that pci_32.o was not being built for PPC_32. Fix error by adding it in the Makefile. Tested using the ppc cross compiler. Signed-off-by: Pranith Kumar Reported-by: Geert

[PATCH v2] flush_icache_range: Export symbol to fix build errors

2014-08-18 Thread Pranith Kumar
Fix building errors occuring due to a missing export of flush_icache_range() in kisskb.ellerman.id.au/kisskb/buildresult/11677809/ ERROR: "flush_icache_range" [drivers/misc/lkdtm.ko] undefined! Signed-off-by: Pranith Kumar Reported-by: Geert Uytterhoeven CC: Andrew Morton --- a

[PATCH v2] flush_icache_range: Export symbol to fix build errors

2014-08-18 Thread Pranith Kumar
Fix building errors occuring due to a missing export of flush_icache_range() in kisskb.ellerman.id.au/kisskb/buildresult/11677809/ ERROR: flush_icache_range [drivers/misc/lkdtm.ko] undefined! Signed-off-by: Pranith Kumar bobby.pr...@gmail.com Reported-by: Geert Uytterhoeven ge...@linux-m68k.org

<    1   2   3   4   5   6   7   8   9   10   >