[PATCH 1/3] drivers/base, Combine topology.c and cpu.c

2015-10-30 Thread Prarit Bhargava
Anvin" Cc: x...@kernel.org Cc: Greg Kroah-Hartman Cc: Len Brown Cc: Borislav Petkov Cc: Andy Lutomirski Cc: Zhu Guihua Cc: Denys Vlasenko Cc: "Jan H. Schönherr" Cc: Boris Ostrovsky Cc: "Paul E. McKenney" Signed-off-by: Prarit Bhargava --- drivers/base/Makefile

[PATCH 2/3] cpu hotplug, add CONFIG_PERMANENT_CPU_TOPOLOGY

2015-10-30 Thread Prarit Bhargava
The information in /sys/devices/system/cpu/cpuX/topology directory is useful for userspace monitoring applications and in-tree utilities like cpupower & turbostat. When down'ing a CPU the /sys/devices/system/cpu/cpuX/topology directory is removed during the CPU_DEAD hotplug callback in the

[PATCH 0/3 v3] Add CONFIG_PERMANENT_CPU_TOPOLOGY

2015-10-30 Thread Prarit Bhargava
l They must be zero'd out when the CPU is offline. Patch 1/3 simply combines topology.c and cpu.c and introduces no new functionality. It is a staging patch for 2/3. Patch 3/3 is a simple cleanup. Prarit Bhargava (3): drivers/base, Combine topology.c and cpu.c cpu hotplug, add CONFIG_PERMANE

Re: [PATCH 1/2] cpu hotplug, add CONFIG_PERMANENT_CPU_TOPOLOGY and keep topology directory for lifetime of CPU [v2]

2015-10-30 Thread Prarit Bhargava
On 10/27/2015 11:50 AM, Thomas Renninger wrote: > On Wednesday, October 21, 2015 12:06:37 PM Prarit Bhargava wrote: > > ... > >> +config PERMANENT_CPU_TOPOLOGY >> +bool "Permanent CPU Topology" >> +depends on HOTPLUG_CPU >> +d

Re: [PATCH 1/2] cpu hotplug, add CONFIG_PERMANENT_CPU_TOPOLOGY and keep topology directory for lifetime of CPU [v2]

2015-10-30 Thread Prarit Bhargava
On 10/27/2015 11:50 AM, Thomas Renninger wrote: > On Wednesday, October 21, 2015 12:06:37 PM Prarit Bhargava wrote: > > ... > >> +config PERMANENT_CPU_TOPOLOGY >> +bool "Permanent CPU Topology" >> +depends on HOTPLUG_CPU >> +d

[PATCH 3/3] drivers/base, cpu, remove hotplugable_cpu_attr_groups

2015-10-30 Thread Prarit Bhargava
hotplugable_cpu_attr_groups is not different from common_cpu_attr_groups, and can be removed. This patchset renames common_cpu_attr_groups to cpu_attr_groups. Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: Thomas Renninger <tr...@suse.de> Signed-off-by: Prarit B

[PATCH 1/3] drivers/base, Combine topology.c and cpu.c

2015-10-30 Thread Prarit Bhargava
Cc: Zhu Guihua <zhugh.f...@cn.fujitsu.com> Cc: Denys Vlasenko <dvlas...@redhat.com> Cc: "Jan H. Schönherr" <jscho...@amazon.de> Cc: Boris Ostrovsky <boris.ostrov...@oracle.com> Cc: "Paul E. McKenney" <paul...@linux.vnet.ibm.com> Signed-off-by: Prar

[PATCH 2/3] cpu hotplug, add CONFIG_PERMANENT_CPU_TOPOLOGY

2015-10-30 Thread Prarit Bhargava
The information in /sys/devices/system/cpu/cpuX/topology directory is useful for userspace monitoring applications and in-tree utilities like cpupower & turbostat. When down'ing a CPU the /sys/devices/system/cpu/cpuX/topology directory is removed during the CPU_DEAD hotplug callback in the

[PATCH 0/3 v3] Add CONFIG_PERMANENT_CPU_TOPOLOGY

2015-10-30 Thread Prarit Bhargava
l They must be zero'd out when the CPU is offline. Patch 1/3 simply combines topology.c and cpu.c and introduces no new functionality. It is a staging patch for 2/3. Patch 3/3 is a simple cleanup. Prarit Bhargava (3): drivers/base, Combine topology.c and cpu.c cpu hotplug, add CONFIG_PERMANE

[PATCH] intel_pstate, decrease number of "HWP enabled" messages

2015-10-22 Thread Prarit Bhargava
ccardi Cc: "Rafael J. Wysocki" Cc: Viresh Kumar Cc: linux...@vger.kernel.org Signed-off-by: Prarit Bhargava --- drivers/cpufreq/intel_pstate.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_ps

Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

2015-10-22 Thread Prarit Bhargava
On 10/22/2015 08:06 AM, Michal Marek wrote: > On 2015-10-22 13:31, Prarit Bhargava wrote: >> >> >> On 10/21/2015 03:52 PM, Michal Marek wrote: >>> Dne 21.10.2015 v 21:27 Prarit Bhargava napsal(a): >>>> On 10/15/2015 04:16 PM, Michal Marek wrote:

Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

2015-10-22 Thread Prarit Bhargava
On 10/21/2015 03:52 PM, Michal Marek wrote: > Dne 21.10.2015 v 21:27 Prarit Bhargava napsal(a): >> On 10/15/2015 04:16 PM, Michal Marek wrote: >>> Otherwise make tags can't parse them: >>> >>> ctags: Warning: arch/ia64/kernel/smp.c:60: null expansion of name

Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

2015-10-22 Thread Prarit Bhargava
On 10/21/2015 03:52 PM, Michal Marek wrote: > Dne 21.10.2015 v 21:27 Prarit Bhargava napsal(a): >> On 10/15/2015 04:16 PM, Michal Marek wrote: >>> Otherwise make tags can't parse them: >>> >>> ctags: Warning: arch/ia64/kernel/smp.c:60: null expansion of name

Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

2015-10-22 Thread Prarit Bhargava
On 10/22/2015 08:06 AM, Michal Marek wrote: > On 2015-10-22 13:31, Prarit Bhargava wrote: >> >> >> On 10/21/2015 03:52 PM, Michal Marek wrote: >>> Dne 21.10.2015 v 21:27 Prarit Bhargava napsal(a): >>>> On 10/15/2015 04:16 PM, Michal Marek wrote:

[PATCH] intel_pstate, decrease number of "HWP enabled" messages

2015-10-22 Thread Prarit Bhargava
ardi <kris...@linux.intel.com> Cc: "Rafael J. Wysocki" <r...@rjwysocki.net> Cc: Viresh Kumar <viresh.ku...@linaro.org> Cc: linux...@vger.kernel.org Signed-off-by: Prarit Bhargava <pra...@redhat.com> --- drivers/cpufreq/intel_pstate.c | 10 ++ 1 file ch

Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

2015-10-21 Thread Prarit Bhargava
On 10/15/2015 04:16 PM, Michal Marek wrote: > Otherwise make tags can't parse them: > > ctags: Warning: arch/ia64/kernel/smp.c:60: null expansion of name pattern "\1" > ctags: Warning: drivers/xen/events/events_2l.c:41: null expansion of name > pattern "\1" > ctags: Warning:

[PATCH 2/2] base, cpu, remove hotplugable_cpu_attr_groups

2015-10-21 Thread Prarit Bhargava
hotplugable_cpu_attr_groups is not different from common_cpu_attr_groups, and can be removed. This patchset renames common_cpu_attr_groups to cpu_attr_groups. Cc: Greg Kroah-Hartman CC: Thomas Renninger Signed-off-by: Prarit Bhargava --- drivers/base/cpu.c | 16 ++-- 1 file

[PATCH 0/2] Add CONFIG_PERMANENT_CPU_TOPOLOGY [v2]

2015-10-21 Thread Prarit Bhargava
adds an additional minor cleanup to drivers/base/cpu.c. [v2]: core_siblings, and thread_siblings are "numa siblings that are online" and "thread siblings that are online" and are used as such within the kernel. They must be zero'd out when the CPU is offline. Prarit Bhargava

[PATCH 1/2] cpu hotplug, add CONFIG_PERMANENT_CPU_TOPOLOGY and keep topology directory for lifetime of CPU [v2]

2015-10-21 Thread Prarit Bhargava
Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: x...@kernel.org Cc: Greg Kroah-Hartman Cc: Borislav Petkov Cc: Len Brown Cc: Andy Lutomirski Cc: Zhu Guihua Cc: Denys Vlasenko Cc: "Jan H. Schönherr" Cc: Boris Ostrovsky Cc: Prarit Bhargava Cc: "Paul E. McKenney

[PATCH 1/2] cpu hotplug, add CONFIG_PERMANENT_CPU_TOPOLOGY and keep topology directory for lifetime of CPU [v2]

2015-10-21 Thread Prarit Bhargava
el.com> Cc: Andy Lutomirski <l...@amacapital.net> Cc: Zhu Guihua <zhugh.f...@cn.fujitsu.com> Cc: Denys Vlasenko <dvlas...@redhat.com> Cc: "Jan H. Schönherr" <jscho...@amazon.de> Cc: Boris Ostrovsky <boris.ostrov...@oracle.com> Cc: Prarit Bhargava <pra...@redhat.com&g

[PATCH 0/2] Add CONFIG_PERMANENT_CPU_TOPOLOGY [v2]

2015-10-21 Thread Prarit Bhargava
adds an additional minor cleanup to drivers/base/cpu.c. [v2]: core_siblings, and thread_siblings are "numa siblings that are online" and "thread siblings that are online" and are used as such within the kernel. They must be zero'd out when the CPU is offline. Prarit Bhargava

[PATCH 2/2] base, cpu, remove hotplugable_cpu_attr_groups

2015-10-21 Thread Prarit Bhargava
hotplugable_cpu_attr_groups is not different from common_cpu_attr_groups, and can be removed. This patchset renames common_cpu_attr_groups to cpu_attr_groups. Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> CC: Thomas Renninger <tr...@suse.de> Signed-off-by: Prarit B

Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

2015-10-21 Thread Prarit Bhargava
On 10/15/2015 04:16 PM, Michal Marek wrote: > Otherwise make tags can't parse them: > > ctags: Warning: arch/ia64/kernel/smp.c:60: null expansion of name pattern "\1" > ctags: Warning: drivers/xen/events/events_2l.c:41: null expansion of name > pattern "\1" > ctags: Warning:

Re: [PATCH 1/2] cpu hotplug, add CONFIG_PERMANENT_CPU_TOPOLOGY and keep topology directory for lifetime of CPU

2015-10-19 Thread Prarit Bhargava
On 10/19/2015 11:04 AM, Prarit Bhargava wrote: > The information in /sys/devices/system/cpu/cpuX/topology > directory is useful for userspace monitoring applications and in-tree > utilities like cpupower & turbostat. > > When down'ing a CPU the /sys/devices/system/cpu/cpuX

[PATCH 2/2] base, cpu, remove hotplugable_cpu_attr_groups

2015-10-19 Thread Prarit Bhargava
hotplugable_cpu_attr_groups is not different from common_cpu_attr_groups, and can be removed. This patchset renames common_cpu_attr_groups to cpu_attr_groups. Cc: Greg Kroah-Hartman CC: Thomas Renninger Signed-off-by: Prarit Bhargava --- drivers/base/cpu.c | 16 ++-- 1 file

[PATCH 0/2] Add CONFIG_PERMANENT_CPU_TOPOLOGY

2015-10-19 Thread Prarit Bhargava
cket group and didn't see any issues. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: x...@kernel.org Cc: Greg Kroah-Hartman Cc: Borislav Petkov Cc: Len Brown Cc: Andy Lutomirski Cc: Zhu Guihua Cc: Denys Vlasenko Cc: "Jan H. Schönherr" Cc: Boris Ostrovsky Cc

[PATCH 1/2] cpu hotplug, add CONFIG_PERMANENT_CPU_TOPOLOGY and keep topology directory for lifetime of CPU

2015-10-19 Thread Prarit Bhargava
ar Cc: "H. Peter Anvin" Cc: x...@kernel.org Cc: Greg Kroah-Hartman Cc: Borislav Petkov Cc: Len Brown Cc: Andy Lutomirski Cc: Zhu Guihua Cc: Denys Vlasenko Cc: "Jan H. Schönherr" Cc: Boris Ostrovsky Cc: Prarit Bhargava Cc: "Paul E. McKenney" Cc: Thomas R

[PATCH 1/2] cpu hotplug, add CONFIG_PERMANENT_CPU_TOPOLOGY and keep topology directory for lifetime of CPU

2015-10-19 Thread Prarit Bhargava
acapital.net> Cc: Zhu Guihua <zhugh.f...@cn.fujitsu.com> Cc: Denys Vlasenko <dvlas...@redhat.com> Cc: "Jan H. Schönherr" <jscho...@amazon.de> Cc: Boris Ostrovsky <boris.ostrov...@oracle.com> Cc: Prarit Bhargava <pra...@redhat.com> Cc: "Paul E. McKe

[PATCH 0/2] Add CONFIG_PERMANENT_CPU_TOPOLOGY

2015-10-19 Thread Prarit Bhargava
Brown <len.br...@intel.com> Cc: Andy Lutomirski <l...@amacapital.net> Cc: Zhu Guihua <zhugh.f...@cn.fujitsu.com> Cc: Denys Vlasenko <dvlas...@redhat.com> Cc: "Jan H. Schönherr" <jscho...@amazon.de> Cc: Boris Ostrovsky <boris.ostrov...@oracle.com> Cc: Pr

[PATCH 2/2] base, cpu, remove hotplugable_cpu_attr_groups

2015-10-19 Thread Prarit Bhargava
hotplugable_cpu_attr_groups is not different from common_cpu_attr_groups, and can be removed. This patchset renames common_cpu_attr_groups to cpu_attr_groups. Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> CC: Thomas Renninger <tr...@suse.de> Signed-off-by: Prarit B

Re: [PATCH 1/2] cpu hotplug, add CONFIG_PERMANENT_CPU_TOPOLOGY and keep topology directory for lifetime of CPU

2015-10-19 Thread Prarit Bhargava
On 10/19/2015 11:04 AM, Prarit Bhargava wrote: > The information in /sys/devices/system/cpu/cpuX/topology > directory is useful for userspace monitoring applications and in-tree > utilities like cpupower & turbostat. > > When down'ing a CPU the /sys/devices/system/cpu/cpuX

[PATCH v2] cpufreq, intel_pstate, Fix intel_pstate powersave min_perf_pct value

2015-10-15 Thread Prarit Bhargava
gi?id=1271225 against Fedora to remove the 94cpufreq file that causes the problem. It should be noted that pm-utils is obsoleted with newer versions of systemd. Cc: Kristen Carlson Accardi Cc: "Rafael J. Wysocki" Cc: Viresh Kumar Cc: linux...@vger.kernel.org Cc: Doug Smythies Signed-

[PATCH v2] cpufreq, intel_pstate, Fix intel_pstate powersave min_perf_pct value

2015-10-15 Thread Prarit Bhargava
<viresh.ku...@linaro.org> Cc: linux...@vger.kernel.org Cc: Doug Smythies <dsmyth...@telus.net> Signed-off-by: Prarit Bhargava <pra...@redhat.com> --- drivers/cpufreq/intel_pstate.c | 142 - 1 file changed, 85 insertions(+), 57 deletions(-)

Re: [PATCH] cpufreq, intel_pstate, Fix intel_pstate powersave min_perf_pct value

2015-10-14 Thread Prarit Bhargava
On 10/14/2015 08:29 PM, Rafael J. Wysocki wrote: > On Wednesday, October 14, 2015 07:59:38 PM Prarit Bhargava wrote: >> >> On 10/14/2015 05:09 PM, Kristen Carlson Accardi wrote: >>> On Wed, 14 Oct 2015 07:41:59 -0400 >>> Prarit Bhargava wrote: &g

Re: [PATCH] cpufreq, intel_pstate, Fix intel_pstate powersave min_perf_pct value

2015-10-14 Thread Prarit Bhargava
On 10/14/2015 05:09 PM, Kristen Carlson Accardi wrote: > On Wed, 14 Oct 2015 07:41:59 -0400 > Prarit Bhargava wrote: > >> On systems that initialize the intel_pstate driver with the performance >> governor, and then switch to the powersave governor will not trans

[PATCH] cpufreq, intel_pstate, Fix intel_pstate powersave min_perf_pct value

2015-10-14 Thread Prarit Bhargava
c: "Rafael J. Wysocki" Cc: Viresh Kumar Cc: linux...@vger.kernel.org Cc: Doug Smythies Signed-off-by: Prarit Bhargava --- drivers/cpufreq/intel_pstate.c | 120 +--- 1 file changed, 75 insertions(+), 45 deletions(-) diff --git a/drivers/cpuf

[PATCH] cpufreq, intel_pstate, Fix intel_pstate powersave min_perf_pct value

2015-10-14 Thread Prarit Bhargava
ardi <kris...@linux.intel.com> Cc: "Rafael J. Wysocki" <r...@rjwysocki.net> Cc: Viresh Kumar <viresh.ku...@linaro.org> Cc: linux...@vger.kernel.org Cc: Doug Smythies <dsmyth...@telus.net> Signed-off-by: Prarit Bhargava <pra...@redhat.

Re: [PATCH] cpufreq, intel_pstate, Fix intel_pstate powersave min_perf_pct value

2015-10-14 Thread Prarit Bhargava
On 10/14/2015 08:29 PM, Rafael J. Wysocki wrote: > On Wednesday, October 14, 2015 07:59:38 PM Prarit Bhargava wrote: >> >> On 10/14/2015 05:09 PM, Kristen Carlson Accardi wrote: >>> On Wed, 14 Oct 2015 07:41:59 -0400 >>> Prarit Bhargava <pra...@re

Re: [PATCH] cpufreq, intel_pstate, Fix intel_pstate powersave min_perf_pct value

2015-10-14 Thread Prarit Bhargava
On 10/14/2015 05:09 PM, Kristen Carlson Accardi wrote: > On Wed, 14 Oct 2015 07:41:59 -0400 > Prarit Bhargava <pra...@redhat.com> wrote: > >> On systems that initialize the intel_pstate driver with the performance >> governor, and then switch to the powersave g

Re: [PATCH] Fix cpupower reporting uninitialized values for offline cpus

2015-10-09 Thread Prarit Bhargava
eck on if the cpu was online. Thomas, any comment? Looks good to me. The description could be cleaned up a bit but I'll let the maintainer decide if they want a new one. Reviewed-by: Prarit Bhargava P. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH] Fix cpupower reporting uninitialized values for offline cpus

2015-10-09 Thread Prarit Bhargava
eck on if the cpu was online. Thomas, any comment? Looks good to me. The description could be cleaned up a bit but I'll let the maintainer decide if they want a new one. Reviewed-by: Prarit Bhargava <pra...@redhat.com> P. -- To unsubscribe from this list: send the line "unsubscribe linux-k

Re: [PATCH] x86, bitops, variable_test_bit should return 1 not -1 on a match

2015-10-08 Thread Prarit Bhargava
On 08/21/2015 04:08 AM, H. Peter Anvin wrote: > Wrong fix, though. Instead we should change it to use the set instruction, > which would also make it easier to use the CC_SET/CC_OUT proposed macros to > use assembly out in the future. > > The downside with set is that it only sets a single

Re: [PATCH] x86, bitops, variable_test_bit should return 1 not -1 on a match

2015-10-08 Thread Prarit Bhargava
On 08/21/2015 04:08 AM, H. Peter Anvin wrote: > Wrong fix, though. Instead we should change it to use the set instruction, > which would also make it easier to use the CC_SET/CC_OUT proposed macros to > use assembly out in the future. > > The downside with set is that it only sets a single

Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-07 Thread Prarit Bhargava
On 10/07/2015 06:26 PM, Doug Smythies wrote: > On 2015.10.07 15:06 Rafael J. Wysocki wrote: >> On Wednesday, October 07, 2015 05:31:25 PM Prarit Bhargava wrote: >>> On 10/07/2015 02:52 PM, Doug Smythies wrote: >>>> On 2015.10.07 08:46 Prarit Bhargava wrote: >

Re: [PATCH v2] x86, bitops, variable_test_bit should return 1 not -1 on a match

2015-10-07 Thread Prarit Bhargava
re-ping on this. Just making sure this wasn't dropped on the floor. P. On 08/24/2015 02:22 PM, Prarit Bhargava wrote: > This issue was noticed while debugging a CPU hotplug issue. On x86 > with (NR_CPUS > 1) the cpu_online() define is cpumask_test_cpu(). > cpumask_test_cpu() sho

Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-07 Thread Prarit Bhargava
On 10/07/2015 06:26 PM, Doug Smythies wrote: > On 2015.10.07 15:06 Rafael J. Wysocki wrote: >> On Wednesday, October 07, 2015 05:31:25 PM Prarit Bhargava wrote: >>> On 10/07/2015 02:52 PM, Doug Smythies wrote: >>>> On 2015.10.07 08:46 Prarit Bhargava wrote: >

Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-07 Thread Prarit Bhargava
On 10/07/2015 06:05 PM, Rafael J. Wysocki wrote: > On Wednesday, October 07, 2015 05:31:25 PM Prarit Bhargava wrote: >> >> On 10/07/2015 02:52 PM, Doug Smythies wrote: >>> On 2015.10.07 08:46 Prarit Bhargava wrote: >>>> On 10/07/2015 11:40 AM, Doug Smy

Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-07 Thread Prarit Bhargava
On 10/07/2015 02:52 PM, Doug Smythies wrote: > On 2015.10.07 08:46 Prarit Bhargava wrote: >> On 10/07/2015 11:40 AM, Doug Smythies wrote: >>> >>> Do we agree or disagree that the root issue seems to be (from your test)?: >>> >>> \# echo 100 > /

Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-07 Thread Prarit Bhargava
On 10/07/2015 02:52 PM, Doug Smythies wrote: > On 2015.10.07 08:46 Prarit Bhargava wrote: >> On 10/07/2015 11:40 AM, Doug Smythies wrote: >>> >>> Do we agree or disagree that the root issue seems to be (from your test)?: >>> >>> \# echo 100 > /

Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-07 Thread Prarit Bhargava
On 10/07/2015 11:40 AM, Doug Smythies wrote: > > Do we agree or disagree that the root issue seems to be (from your test)?: > > \# echo 100 > /sys/devices/system/cpu/intel_pstate/min_perf_pct > > [ 21.483436] store_min_perf_pct[453] min_sysfs_pct = 100 > [ 21.489373]

Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-07 Thread Prarit Bhargava
On 10/07/2015 08:18 AM, Prarit Bhargava wrote: > > > On 10/06/2015 07:06 PM, Rafael J. Wysocki wrote: >> On Wednesday, October 07, 2015 12:43:55 AM Rafael J. Wysocki wrote: >>> On Tuesday, October 06, 2015 05:49:07 PM Prarit Bhargava wrote: > > > >&

RE: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-07 Thread Prarit Bhargava
Doug, please apply and test. My result is: \# initial load of driver, set to PERFORMANCE governor by default. [ 21.406525] intel_pstate_set_policy[1001] min_perf_pct = 100 [ 21.421288] intel_pstate_set_policy[1001] min_perf_pct = 100 [ 21.436038] intel_pstate_set_policy[1001] min_perf_pct

Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-07 Thread Prarit Bhargava
On 10/07/2015 10:04 AM, Doug Smythies wrote: > > On 2015.10.07 03:00 Prarit Bhargava wrote: >> On 10/07/2015 02:51 AM, Doug Smythies wrote: >>> >>> And before patch I get, using primitives and not cpupower: >>> Executive Summary: Everythi

Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-07 Thread Prarit Bhargava
On 10/06/2015 07:06 PM, Rafael J. Wysocki wrote: > On Wednesday, October 07, 2015 12:43:55 AM Rafael J. Wysocki wrote: >> On Tuesday, October 06, 2015 05:49:07 PM Prarit Bhargava wrote: >>> >>> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel

Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-07 Thread Prarit Bhargava
On 10/06/2015 07:06 PM, Rafael J. Wysocki wrote: > On Wednesday, October 07, 2015 12:43:55 AM Rafael J. Wysocki wrote: >> On Tuesday, October 06, 2015 05:49:07 PM Prarit Bhargava wrote: >>> Intel CPUs will not enter higher p-states when after switching from the >&g

Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-07 Thread Prarit Bhargava
On 10/07/2015 02:51 AM, Doug Smythies wrote: > > And before patch I get, using primitives and not cpupower: > Executive Summary: Everything works fine (or at least as I thought it was > supposed to). > > root@s15:/home/doug/temp# grep . >

Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-07 Thread Prarit Bhargava
On 10/07/2015 06:26 PM, Doug Smythies wrote: > On 2015.10.07 15:06 Rafael J. Wysocki wrote: >> On Wednesday, October 07, 2015 05:31:25 PM Prarit Bhargava wrote: >>> On 10/07/2015 02:52 PM, Doug Smythies wrote: >>>> On 2015.10.07 08:46 Prarit Bhargava wrote: >

Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-07 Thread Prarit Bhargava
On 10/07/2015 02:52 PM, Doug Smythies wrote: > On 2015.10.07 08:46 Prarit Bhargava wrote: >> On 10/07/2015 11:40 AM, Doug Smythies wrote: >>> >>> Do we agree or disagree that the root issue seems to be (from your test)?: >>> >>> \# echo 100 > /

Re: [PATCH v2] x86, bitops, variable_test_bit should return 1 not -1 on a match

2015-10-07 Thread Prarit Bhargava
re-ping on this. Just making sure this wasn't dropped on the floor. P. On 08/24/2015 02:22 PM, Prarit Bhargava wrote: > This issue was noticed while debugging a CPU hotplug issue. On x86 > with (NR_CPUS > 1) the cpu_online() define is cpumask_test_cpu(). > cpumask_test_cpu() sho

Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-07 Thread Prarit Bhargava
On 10/07/2015 02:52 PM, Doug Smythies wrote: > On 2015.10.07 08:46 Prarit Bhargava wrote: >> On 10/07/2015 11:40 AM, Doug Smythies wrote: >>> >>> Do we agree or disagree that the root issue seems to be (from your test)?: >>> >>> \# echo 100 > /

Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-07 Thread Prarit Bhargava
On 10/07/2015 06:05 PM, Rafael J. Wysocki wrote: > On Wednesday, October 07, 2015 05:31:25 PM Prarit Bhargava wrote: >> >> On 10/07/2015 02:52 PM, Doug Smythies wrote: >>> On 2015.10.07 08:46 Prarit Bhargava wrote: >>>> On 10/07/2015 11:40 AM, Doug Smy

Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-07 Thread Prarit Bhargava
On 10/07/2015 06:26 PM, Doug Smythies wrote: > On 2015.10.07 15:06 Rafael J. Wysocki wrote: >> On Wednesday, October 07, 2015 05:31:25 PM Prarit Bhargava wrote: >>> On 10/07/2015 02:52 PM, Doug Smythies wrote: >>>> On 2015.10.07 08:46 Prarit Bhargava wrote: >

Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-07 Thread Prarit Bhargava
On 10/07/2015 02:51 AM, Doug Smythies wrote: > > And before patch I get, using primitives and not cpupower: > Executive Summary: Everything works fine (or at least as I thought it was > supposed to). > > root@s15:/home/doug/temp# grep . >

Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-07 Thread Prarit Bhargava
On 10/06/2015 07:06 PM, Rafael J. Wysocki wrote: > On Wednesday, October 07, 2015 12:43:55 AM Rafael J. Wysocki wrote: >> On Tuesday, October 06, 2015 05:49:07 PM Prarit Bhargava wrote: >>> Intel CPUs will not enter higher p-states when after switching from the >&g

Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-07 Thread Prarit Bhargava
On 10/06/2015 07:06 PM, Rafael J. Wysocki wrote: > On Wednesday, October 07, 2015 12:43:55 AM Rafael J. Wysocki wrote: >> On Tuesday, October 06, 2015 05:49:07 PM Prarit Bhargava wrote: >>> >>> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel

Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-07 Thread Prarit Bhargava
On 10/07/2015 10:04 AM, Doug Smythies wrote: > > On 2015.10.07 03:00 Prarit Bhargava wrote: >> On 10/07/2015 02:51 AM, Doug Smythies wrote: >>> >>> And before patch I get, using primitives and not cpupower: >>> Executive Summary: Everythi

Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-07 Thread Prarit Bhargava
On 10/07/2015 08:18 AM, Prarit Bhargava wrote: > > > On 10/06/2015 07:06 PM, Rafael J. Wysocki wrote: >> On Wednesday, October 07, 2015 12:43:55 AM Rafael J. Wysocki wrote: >>> On Tuesday, October 06, 2015 05:49:07 PM Prarit Bhargava wrote: > > > >&

RE: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-07 Thread Prarit Bhargava
Doug, please apply and test. My result is: \# initial load of driver, set to PERFORMANCE governor by default. [ 21.406525] intel_pstate_set_policy[1001] min_perf_pct = 100 [ 21.421288] intel_pstate_set_policy[1001] min_perf_pct = 100 [ 21.436038] intel_pstate_set_policy[1001] min_perf_pct

Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-07 Thread Prarit Bhargava
On 10/07/2015 11:40 AM, Doug Smythies wrote: > > Do we agree or disagree that the root issue seems to be (from your test)?: > > \# echo 100 > /sys/devices/system/cpu/intel_pstate/min_perf_pct > > [ 21.483436] store_min_perf_pct[453] min_sysfs_pct = 100 > [ 21.489373]

[PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-06 Thread Prarit Bhargava
04759924e25 ("[cpufreq] intel_pstate: honor user space min_perf_pct override on resume") Cc: Kristen Carlson Accardi Cc: "Rafael J. Wysocki" Cc: Viresh Kumar Cc: linux...@vger.kernel.org Signed-off-by: Prarit Bhargava --- drivers/cpufreq/intel_pstate.c |7 +-- 1 file chan

Re: [PATCH] PCI: prevent out of bounds access in numa_node override

2015-10-06 Thread Prarit Bhargava
On 10/06/2015 03:36 PM, Bjorn Helgaas wrote: > Hi Sasha, > > On Sun, Oct 04, 2015 at 05:49:29PM -0400, Sasha Levin wrote: >> Commit 63692df1 ("PCI: Allow numa_node override via sysfs") didn't check that >> the numa node provided by userspace is valid. Passing a node number too high >> would

Re: [PATCH] PCI: prevent out of bounds access in numa_node override

2015-10-06 Thread Prarit Bhargava
On 10/06/2015 03:36 PM, Bjorn Helgaas wrote: > Hi Sasha, > > On Sun, Oct 04, 2015 at 05:49:29PM -0400, Sasha Levin wrote: >> Commit 63692df1 ("PCI: Allow numa_node override via sysfs") didn't check that >> the numa node provided by userspace is valid. Passing a node number too high >> would

[PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch

2015-10-06 Thread Prarit Bhargava
04759924e25 ("[cpufreq] intel_pstate: honor user space min_perf_pct override on resume") Cc: Kristen Carlson Accardi <kris...@linux.intel.com> Cc: "Rafael J. Wysocki" <r...@rjwysocki.net> Cc: Viresh Kumar <viresh.ku...@linaro.org> Cc: linux...@vger.kernel.org Sig

Re: Fwd: [PATCH] x86: Use larger chunks in mtrr_cleanup

2015-09-03 Thread Prarit Bhargava
On 09/03/2015 01:59 PM, Luis R. Rodriguez wrote: > On Thu, Sep 03, 2015 at 08:17:02AM -0400, Prarit Bhargava wrote: >> >> >> On 09/02/2015 10:45 PM, Luis R. Rodriguez wrote: >>> On Mon, Aug 31, 2015 at 11:05:33AM -0500, Stuart Hayes wrote: >>>&g

Re: Fwd: [PATCH] x86: Use larger chunks in mtrr_cleanup

2015-09-03 Thread Prarit Bhargava
On 09/02/2015 10:45 PM, Luis R. Rodriguez wrote: > On Mon, Aug 31, 2015 at 11:05:33AM -0500, Stuart Hayes wrote: >> Increase the range of chunk sizes tried in mtrr_cleanup() so it is able >> to map large memory configs into MTRRs. >> >> Currently, mtrr_cleanup() will fail with large memory

Re: Fwd: [PATCH] x86: Use larger chunks in mtrr_cleanup

2015-09-03 Thread Prarit Bhargava
On 09/03/2015 01:59 PM, Luis R. Rodriguez wrote: > On Thu, Sep 03, 2015 at 08:17:02AM -0400, Prarit Bhargava wrote: >> >> >> On 09/02/2015 10:45 PM, Luis R. Rodriguez wrote: >>> On Mon, Aug 31, 2015 at 11:05:33AM -0500, Stuart Hayes wrote: >>>&g

Re: Fwd: [PATCH] x86: Use larger chunks in mtrr_cleanup

2015-09-03 Thread Prarit Bhargava
On 09/02/2015 10:45 PM, Luis R. Rodriguez wrote: > On Mon, Aug 31, 2015 at 11:05:33AM -0500, Stuart Hayes wrote: >> Increase the range of chunk sizes tried in mtrr_cleanup() so it is able >> to map large memory configs into MTRRs. >> >> Currently, mtrr_cleanup() will fail with large memory

Re: [PATCH] mei, make modules.alias UUID information easier to read

2015-08-31 Thread Prarit Bhargava
On 08/29/2015 05:21 PM, Winkler, Tomas wrote: >> >> Hi Prarit, >> >> On Fri, Aug 28, 2015 at 07:50:52AM -0400, Prarit Bhargava wrote: >>> Heikki, Tomas? >> >> I'm afraid I don't know much about Intel's Management Engine >> Interface. Looks li

Re: [PATCH] mei, make modules.alias UUID information easier to read

2015-08-31 Thread Prarit Bhargava
On 08/29/2015 05:21 PM, Winkler, Tomas wrote: >> >> Hi Prarit, >> >> On Fri, Aug 28, 2015 at 07:50:52AM -0400, Prarit Bhargava wrote: >>> Heikki, Tomas? >> >> I'm afraid I don't know much about Intel's Management Engine >> Interface. Looks li

Re: [PATCH] mei, make modules.alias UUID information easier to read

2015-08-30 Thread Prarit Bhargava
On 08/29/2015 05:21 PM, Winkler, Tomas wrote: >> >> Hi Prarit, >> >> On Fri, Aug 28, 2015 at 07:50:52AM -0400, Prarit Bhargava wrote: >>> Heikki, Tomas? >> >> I'm afraid I don't know much about Intel's Management Engine >> Interface. Looks li

Re: [PATCH] mei, make modules.alias UUID information easier to read

2015-08-30 Thread Prarit Bhargava
On 08/29/2015 05:21 PM, Winkler, Tomas wrote: Hi Prarit, On Fri, Aug 28, 2015 at 07:50:52AM -0400, Prarit Bhargava wrote: Heikki, Tomas? I'm afraid I don't know much about Intel's Management Engine Interface. Looks like the driver is from Samuel (CC'd) so I'm guessing he is the person

Re: [PATCH] mei, make modules.alias UUID information easier to read

2015-08-28 Thread Prarit Bhargava
Heikki, Tomas? P. On 08/14/2015 09:05 AM, Prarit Bhargava wrote: > 2nd try on this ... > > P. > > ---8<--- > > scripts/mod/file2alias.c:add_uuid() munges a UUID into a single string > which does not conform to the standard little endian UUID. This patch > chan

Re: [PATCH] mei, make modules.alias UUID information easier to read

2015-08-28 Thread Prarit Bhargava
Heikki, Tomas? P. On 08/14/2015 09:05 AM, Prarit Bhargava wrote: 2nd try on this ... P. ---8--- scripts/mod/file2alias.c:add_uuid() munges a UUID into a single string which does not conform to the standard little endian UUID. This patch changes add_uuid() to use the UUID correctly

[PATCH] Documentation, add kernel-parameters.txt entry for dis_ucode_ldr

2015-08-25 Thread Prarit Bhargava
Signed-off-by: Prarit Bhargava --- Documentation/kernel-parameters.txt |2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index 1d6f045..34f2afb 100644 --- a/Documentation/kernel-parameters.txt +++ b/Documentat

[PATCH] Documentation, add kernel-parameters.txt entry for dis_ucode_ldr

2015-08-25 Thread Prarit Bhargava
-...@vger.kernel.org Signed-off-by: Prarit Bhargava pra...@redhat.com --- Documentation/kernel-parameters.txt |2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index 1d6f045..34f2afb 100644 --- a/Documentation/kernel-parameters.txt

[PATCH v2] x86, bitops, variable_test_bit should return 1 not -1 on a match

2015-08-24 Thread Prarit Bhargava
etc, (Set if Carry, "Sets the byte in the operand to 1 if the Carry Flag is set, otherwise sets the operand to 0.") instead of !! Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: x...@kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Prarit Bhargava ---

[PATCH v2] x86, bitops, variable_test_bit should return 1 not -1 on a match

2015-08-24 Thread Prarit Bhargava
the byte in the operand to 1 if the Carry Flag is set, otherwise sets the operand to 0.) instead of !! Cc: Thomas Gleixner t...@linutronix.de Cc: Ingo Molnar mi...@redhat.com Cc: H. Peter Anvin h...@zytor.com Cc: x...@kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Prarit Bhargava pra

Re: [PATCH] x86, bitops, variable_test_bit should return 1 not -1 on a match

2015-08-21 Thread Prarit Bhargava
On 08/21/2015 04:08 AM, H. Peter Anvin wrote: > Wrong fix, though. Instead we should change it to use the set instruction, > which would also make it easier to use the CC_SET/CC_OUT proposed macros to > use assembly out in the future. > > The downside with set is that it only sets a single

Re: [PATCH] x86, bitops, variable_test_bit should return 1 not -1 on a match

2015-08-21 Thread Prarit Bhargava
On 08/21/2015 02:51 AM, Ingo Molnar wrote: > > * Prarit Bhargava wrote: > >> This issue was noticed while debugging a CPU hotplug issue. On x86 >> with (NR_CPUS > 1) the cpu_online() define is cpumask_test_cpu(). >> cpumask_test_cpu() should return 1 if the

Re: [PATCH] x86, bitops, variable_test_bit should return 1 not -1 on a match

2015-08-21 Thread Prarit Bhargava
On 08/21/2015 02:51 AM, Ingo Molnar wrote: * Prarit Bhargava pra...@redhat.com wrote: This issue was noticed while debugging a CPU hotplug issue. On x86 with (NR_CPUS 1) the cpu_online() define is cpumask_test_cpu(). cpumask_test_cpu() should return 1 if the cpu is set in cpumask

Re: [PATCH] x86, bitops, variable_test_bit should return 1 not -1 on a match

2015-08-21 Thread Prarit Bhargava
On 08/21/2015 04:08 AM, H. Peter Anvin wrote: Wrong fix, though. Instead we should change it to use the set instruction, which would also make it easier to use the CC_SET/CC_OUT proposed macros to use assembly out in the future. The downside with set is that it only sets a single byte,

[PATCH] x86, bitops, variable_test_bit should return 1 not -1 on a match

2015-08-19 Thread Prarit Bhargava
xample, (test_bit() == 1) so this change should not have any impact. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: x...@kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Prarit Bhargava --- arch/x86/include/asm/bitops.h |2 +- 1 file changed, 1 insertion(+)

[PATCH] x86, bitops, variable_test_bit should return 1 not -1 on a match

2015-08-19 Thread Prarit Bhargava
should not have any impact. Cc: Thomas Gleixner t...@linutronix.de Cc: Ingo Molnar mi...@redhat.com Cc: H. Peter Anvin h...@zytor.com Cc: x...@kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Prarit Bhargava pra...@redhat.com --- arch/x86/include/asm/bitops.h |2 +- 1 file changed, 1

[PATCH] mei, make modules.alias UUID information easier to read

2015-08-14 Thread Prarit Bhargava
er Cc: David Cohen Cc: Felipe Balbi Cc: Ralf Baechle Signed-off-by: Prarit Bhargava --- drivers/misc/mei/bus.c |6 ++ include/linux/mod_devicetable.h |4 scripts/mod/file2alias.c|9 ++--- 3 files changed, 8 insertions(+), 11 deletions(-) diff --git a

[PATCH] mei, make modules.alias UUID information easier to read

2015-08-14 Thread Prarit Bhargava
: Felipe Balbi ba...@ti.com Cc: Ralf Baechle r...@linux-mips.org Signed-off-by: Prarit Bhargava pra...@redhat.com --- drivers/misc/mei/bus.c |6 ++ include/linux/mod_devicetable.h |4 scripts/mod/file2alias.c|9 ++--- 3 files changed, 8 insertions(+), 11

[PATCH] mei, make modules.alias UUID information easier to read

2015-08-07 Thread Prarit Bhargava
with those changes. Cc: Tomas Winkler Cc: Greg Kroah-Hartman Signed-off-by: Prarit Bhargava --- drivers/misc/mei/bus.c |6 ++ include/linux/mod_devicetable.h |4 scripts/mod/file2alias.c|9 ++--- 3 files changed, 8 insertions(+), 11 deletions(-) diff --git

[PATCH] mei, make modules.alias UUID information easier to read

2015-08-07 Thread Prarit Bhargava
with those changes. Cc: Tomas Winkler tomas.wink...@intel.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Prarit Bhargava pra...@redhat.com --- drivers/misc/mei/bus.c |6 ++ include/linux/mod_devicetable.h |4 scripts/mod/file2alias.c|9

[PATCH] tools, Add CFLAGS_SECURITY for RELRO and PIE

2015-07-15 Thread Prarit Bhargava
p;& PIE=yes printf "RELRO=%s\nPIE=%s\n\n" $RELRO $PIE done; unset f and also used 'LD_DEBUG=statistics ' to check to see if there were any serious performance issues. Signed-off-by: Prarit Bhargava --- tools/cgroup/Makefile |2 +- tools/firewire

[PATCH] tools, Add CFLAGS_SECURITY for RELRO and PIE

2015-07-15 Thread Prarit Bhargava
PIE=dso [[ $PIE = dso ]] grep -m1 -F -q '(DEBUG)' dynamic_section PIE=yes printf RELRO=%s\nPIE=%s\n\n $RELRO $PIE done; unset f and also used 'LD_DEBUG=statistics executable' to check to see if there were any serious performance issues. Signed-off-by: Prarit Bhargava pra

Re: [PATCH 2/2] serial: 8250: Allow to skip autoconfig_irq() for a console

2015-07-08 Thread Prarit Bhargava
On 07/08/2015 09:51 AM, Peter Hurley wrote: > Hi Prarit, > > On 07/08/2015 08:53 AM, Prarit Bhargava wrote: >> >> >> On 07/08/2015 07:55 AM, Peter Hurley wrote: >>> Hi Taichi, >>> >>> On 06/05/2015 06:03 AM, Taichi Kageyama wrote: &g

<    5   6   7   8   9   10   11   12   13   14   >