Re: [PATCH 1/3] cpuidle: coupled: disable interrupts after entering safe state

2013-08-29 Thread Prashant Gaikwad
On Saturday 24 August 2013 01:15 AM, Colin Cross wrote: Calling cpuidle_enter_state is expected to return with interrupts enabled, but interrupts must be disabled before starting the ready loop synchronization stage. Call local_irq_disable after each call to cpuidle_enter_state for the safe

Re: [PATCH 1/3] cpuidle: coupled: disable interrupts after entering safe state

2013-08-29 Thread Prashant Gaikwad
On Saturday 24 August 2013 01:15 AM, Colin Cross wrote: Calling cpuidle_enter_state is expected to return with interrupts enabled, but interrupts must be disabled before starting the ready loop synchronization stage. Call local_irq_disable after each call to cpuidle_enter_state for the safe

Re: [PATCH] clk: tegra30: Don't wait for PLL_U lock bit

2013-08-05 Thread Prashant Gaikwad
On Thursday 01 August 2013 02:34 AM, Stephen Warren wrote: On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: The lock bit on PLL_U does not seem to be working correctly and sometimes never gets set when waiting for the PLL to come up. Remove the TEGRA_PLL_USE_LOCK flag to use a constant delay.

Re: [PATCH] clk: tegra30: Don't wait for PLL_U lock bit

2013-08-05 Thread Prashant Gaikwad
On Thursday 01 August 2013 02:34 AM, Stephen Warren wrote: On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: The lock bit on PLL_U does not seem to be working correctly and sometimes never gets set when waiting for the PLL to come up. Remove the TEGRA_PLL_USE_LOCK flag to use a constant delay.

Re: [PATCH 3/3] clk: tegra: T114: add DFLL DVCO reset control

2013-06-11 Thread Prashant Gaikwad
not implement these APIs in DFLL clock driver itself and pass RST address register to driver? The reset assert/de-assert functions at least might be worth exposing using the new generic module reset API. I believe Prashant Gaikwad is working on converting the Tegra clock driver to be a module

Re: [PATCH v2] clk: tegra: Use common of_clk_init function

2013-06-11 Thread Prashant Gaikwad
On Tuesday 28 May 2013 08:46 PM, Stephen Warren wrote: On 05/27/2013 01:40 AM, Prashant Gaikwad wrote: Use common of_clk_init() function for clocks initialization. Mike, Please merge this patch in your tree. Thanks, PrashantG Acked-by: Stephen Warren -- To unsubscribe from this list

Re: [PATCH v2] clk: tegra: Use common of_clk_init function

2013-06-11 Thread Prashant Gaikwad
On Tuesday 28 May 2013 08:46 PM, Stephen Warren wrote: On 05/27/2013 01:40 AM, Prashant Gaikwad wrote: Use common of_clk_init() function for clocks initialization. Mike, Please merge this patch in your tree. Thanks, PrashantG Acked-by: Stephen Warren swar...@nvidia.com -- To unsubscribe

Re: [PATCH 3/3] clk: tegra: T114: add DFLL DVCO reset control

2013-06-11 Thread Prashant Gaikwad
already ;-) Why not implement these APIs in DFLL clock driver itself and pass RST address register to driver? The reset assert/de-assert functions at least might be worth exposing using the new generic module reset API. I believe Prashant Gaikwad is working on converting the Tegra clock driver

[PATCH v2] clk: tegra: Use common of_clk_init function

2013-05-27 Thread Prashant Gaikwad
Use common of_clk_init() function for clocks initialization. Signed-off-by: Prashant Gaikwad --- Included initialization for T114 in V2. --- arch/arm/mach-tegra/common.c |4 ++-- drivers/clk/tegra/clk-tegra114.c |3 ++- drivers/clk/tegra/clk-tegra20.c |3 ++- drivers/clk

[PATCH v2] clk: tegra: Use common of_clk_init function

2013-05-27 Thread Prashant Gaikwad
Use common of_clk_init() function for clocks initialization. Signed-off-by: Prashant Gaikwad pgaik...@nvidia.com --- Included initialization for T114 in V2. --- arch/arm/mach-tegra/common.c |4 ++-- drivers/clk/tegra/clk-tegra114.c |3 ++- drivers/clk/tegra/clk-tegra20.c |3

[PATCH] clk: tegra: Use common of_clk_init() function

2013-04-04 Thread Prashant Gaikwad
Use common of_clk_init() function for clocks initialization. Signed-off-by: Prashant Gaikwad --- Stephen, if T114 clock series is not going to make in 3.10 then I would like Mike to take this patch. If T114 clock series makes it then I have to rebase this patch on top of it. --- arch/arm/mach

[PATCH] clk: tegra: Add missing cdev1 and cdev2 clocks

2013-04-04 Thread Prashant Gaikwad
Register cdev1 and cdev2 peripheral clocks. Signed-off-by: Prashant Gaikwad --- drivers/clk/tegra/clk-tegra30.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/drivers/clk/tegra/clk-tegra30.c b/drivers/clk/tegra/clk-tegra30.c index 0681935..0e362ea

[PATCH] clk: tegra: Fix cdev1 and cdev2 IDs

2013-04-04 Thread Prashant Gaikwad
Correct IDs for cdev1 and cdev2 are 94 and 93 respectively. Signed-off-by: Prashant Gaikwad --- Stephen, tested this patch on Ventana and Cardhu, please verify if I am not missing any platform which uses cdev1/cdev2. --- .../bindings/clock/nvidia,tegra20-car.txt |4 ++-- arch/arm

Re: [PATCH v8 10/14] ARM: tegra: Define Tegra114 CAR binding

2013-04-04 Thread Prashant Gaikwad
On Wednesday 03 April 2013 07:49 PM, Peter De Schrijver wrote: On Mon, Mar 25, 2013 at 12:15:47PM +0100, Prashant Gaikwad wrote: On Friday 22 March 2013 06:09 PM, Peter De Schrijver wrote: The device tree binding models Tegra114 CAR (Clock And Reset) as a single monolithic clock provider

Re: [PATCH v8 10/14] ARM: tegra: Define Tegra114 CAR binding

2013-04-04 Thread Prashant Gaikwad
On Wednesday 03 April 2013 07:49 PM, Peter De Schrijver wrote: On Mon, Mar 25, 2013 at 12:15:47PM +0100, Prashant Gaikwad wrote: On Friday 22 March 2013 06:09 PM, Peter De Schrijver wrote: The device tree binding models Tegra114 CAR (Clock And Reset) as a single monolithic clock provider

[PATCH] clk: tegra: Fix cdev1 and cdev2 IDs

2013-04-04 Thread Prashant Gaikwad
Correct IDs for cdev1 and cdev2 are 94 and 93 respectively. Signed-off-by: Prashant Gaikwad pgaik...@nvidia.com --- Stephen, tested this patch on Ventana and Cardhu, please verify if I am not missing any platform which uses cdev1/cdev2. --- .../bindings/clock/nvidia,tegra20-car.txt

[PATCH] clk: tegra: Add missing cdev1 and cdev2 clocks

2013-04-04 Thread Prashant Gaikwad
Register cdev1 and cdev2 peripheral clocks. Signed-off-by: Prashant Gaikwad pgaik...@nvidia.com --- drivers/clk/tegra/clk-tegra30.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/drivers/clk/tegra/clk-tegra30.c b/drivers/clk/tegra/clk-tegra30.c index

[PATCH] clk: tegra: Use common of_clk_init() function

2013-04-04 Thread Prashant Gaikwad
Use common of_clk_init() function for clocks initialization. Signed-off-by: Prashant Gaikwad pgaik...@nvidia.com --- Stephen, if T114 clock series is not going to make in 3.10 then I would like Mike to take this patch. If T114 clock series makes it then I have to rebase this patch on top

Re: [PATCH V3] clk: Add composite clock type

2013-03-25 Thread Prashant Gaikwad
Mike, Please merge this patch. Thanks & Regards, PrashantG On Wednesday 20 March 2013 05:30 PM, Prashant Gaikwad wrote: Not all clocks are required to be decomposed into basic clock types but at the same time want to use the functionality provided by these basic clock types ins

Re: [PATCH v8 10/14] ARM: tegra: Define Tegra114 CAR binding

2013-03-25 Thread Prashant Gaikwad
On Friday 22 March 2013 06:09 PM, Peter De Schrijver wrote: The device tree binding models Tegra114 CAR (Clock And Reset) as a single monolithic clock provider. Signed-off-by: Peter De Schrijver --- + 263 cclk_lp + 264 dfll_ref + 265 dfll_soc + Peter, Please remove following

Re: [PATCH] clk: tegra: Don't enable PLLs during early boot

2013-03-25 Thread Prashant Gaikwad
On Monday 25 March 2013 03:45 PM, Peter De Schrijver wrote: On Fri, Mar 22, 2013 at 04:48:11PM +0100, Stephen Warren wrote: On 03/22/2013 05:54 AM, Peter De Schrijver wrote: The PLL code relies on udelay() which is not available when CCF is initialized. Hence we can't enable any PLL during

Re: [PATCH] clk: tegra: Don't enable PLLs during early boot

2013-03-25 Thread Prashant Gaikwad
On Monday 25 March 2013 03:45 PM, Peter De Schrijver wrote: On Fri, Mar 22, 2013 at 04:48:11PM +0100, Stephen Warren wrote: On 03/22/2013 05:54 AM, Peter De Schrijver wrote: The PLL code relies on udelay() which is not available when CCF is initialized. Hence we can't enable any PLL during

Re: [PATCH v8 10/14] ARM: tegra: Define Tegra114 CAR binding

2013-03-25 Thread Prashant Gaikwad
On Friday 22 March 2013 06:09 PM, Peter De Schrijver wrote: The device tree binding models Tegra114 CAR (Clock And Reset) as a single monolithic clock provider. Signed-off-by: Peter De Schrijver pdeschrij...@nvidia.com --- snip + 263 cclk_lp + 264 dfll_ref + 265 dfll_soc + Peter,

Re: [PATCH V3] clk: Add composite clock type

2013-03-25 Thread Prashant Gaikwad
Mike, Please merge this patch. Thanks Regards, PrashantG On Wednesday 20 March 2013 05:30 PM, Prashant Gaikwad wrote: Not all clocks are required to be decomposed into basic clock types but at the same time want to use the functionality provided by these basic clock types instead

[PATCH V3] clk: Add composite clock type

2013-03-20 Thread Prashant Gaikwad
e-uses the functionality of basic clock types and not limited to basic clock types but any hardware-specific implementation. Signed-off-by: Prashant Gaikwad --- Changes from V2: - Move clk_ops inside clk_composite instead of dynamically allocation. --- drivers/clk/Makefile |1 + drivers/c

[PATCH V3] clk: Add composite clock type

2013-03-20 Thread Prashant Gaikwad
the functionality of basic clock types and not limited to basic clock types but any hardware-specific implementation. Signed-off-by: Prashant Gaikwad pgaik...@nvidia.com --- Changes from V2: - Move clk_ops inside clk_composite instead of dynamically allocation. --- drivers/clk/Makefile |1 + drivers

Re: [PATCH V2] clk: Add composite clock type

2013-03-19 Thread Prashant Gaikwad
On Wednesday 13 March 2013 10:00 PM, Tomasz Figa wrote: Hi Prashant, On Thursday 28 of February 2013 11:20:31 Stephen Warren wrote: On 02/28/2013 12:58 AM, Prashant Gaikwad wrote: On Wednesday 06 February 2013 03:36 PM, Tomasz Figa wrote: On Wednesday 06 of February 2013 08:34:32 Prashant

Re: [PATCH V2] clk: Add composite clock type

2013-03-19 Thread Prashant Gaikwad
On Wednesday 13 March 2013 10:00 PM, Tomasz Figa wrote: Hi Prashant, On Thursday 28 of February 2013 11:20:31 Stephen Warren wrote: On 02/28/2013 12:58 AM, Prashant Gaikwad wrote: On Wednesday 06 February 2013 03:36 PM, Tomasz Figa wrote: On Wednesday 06 of February 2013 08:34:32 Prashant

Re: [PATCH V2] clk: Add composite clock type

2013-02-27 Thread Prashant Gaikwad
On Wednesday 06 February 2013 03:36 PM, Tomasz Figa wrote: On Wednesday 06 of February 2013 08:34:32 Prashant Gaikwad wrote: On Tuesday 05 February 2013 03:45 PM, Tomasz Figa wrote: Hi Prashant, Thank you for your patch. Please see some comments inline. On Monday 04 of February 2013 13:41:22

Re: [PATCH V2] clk: Add composite clock type

2013-02-27 Thread Prashant Gaikwad
On Wednesday 06 February 2013 03:36 PM, Tomasz Figa wrote: On Wednesday 06 of February 2013 08:34:32 Prashant Gaikwad wrote: On Tuesday 05 February 2013 03:45 PM, Tomasz Figa wrote: Hi Prashant, Thank you for your patch. Please see some comments inline. On Monday 04 of February 2013 13:41:22

Re: [PATCH v7 00/12] Tegra114 clockframework

2013-02-21 Thread Prashant Gaikwad
branch for me to merge, obviously after 3.9-rc1 is out. Thanks. Prashant, could you provide a review/ack for this series too. For the series Reviewed-by: Prashant Gaikwad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH v7 00/12] Tegra114 clockframework

2013-02-21 Thread Prashant Gaikwad
branch for me to merge, obviously after 3.9-rc1 is out. Thanks. Prashant, could you provide a review/ack for this series too. For the series Reviewed-by: Prashant Gaikwad pgaik...@nvidia.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH] clk: tegra: Add missing spinlock for hclk and pclk

2013-02-07 Thread Prashant Gaikwad
On Thursday 07 February 2013 10:07 PM, Peter De Schrijver wrote: The hclk and pclk clocks are controlled by the same register. Hence a lock is required to avoid corruption. Signed-off-by: Peter De Schrijver Reviewed-by: Prashant Gaikwad --- drivers/clk/tegra/clk-tegra20.c | 11

Re: [PATCH] clk: tegra: local arrays should be static

2013-02-07 Thread Prashant Gaikwad
On Thursday 07 February 2013 10:00 PM, Peter De Schrijver wrote: cclk_g_parents, cclk_lp_parents and sclk_parents are only accessed from within clk-tegra30.c. Declare them static to avoid namespace polution. Signed-off-by: Peter De Schrijver Reviewed-by: Prashant Gaikwad --- drivers/clk

Re: [PATCH] clk: tegra: Implement locking for super clock

2013-02-07 Thread Prashant Gaikwad
On Thursday 07 February 2013 09:54 PM, Peter De Schrijver wrote: Although tegra_clk_register_super_mux() has a lock parameter, the lock is not actually used by the code. Fixed with this patch. Signed-off-by: Peter De Schrijver Reviewed-by: Prashant Gaikwad --- drivers/clk/tegra/clk

Re: [PATCH] clk: tegra: Implement locking for super clock

2013-02-07 Thread Prashant Gaikwad
On Thursday 07 February 2013 09:54 PM, Peter De Schrijver wrote: Although tegra_clk_register_super_mux() has a lock parameter, the lock is not actually used by the code. Fixed with this patch. Signed-off-by: Peter De Schrijver pdeschrij...@nvidia.com Reviewed-by: Prashant Gaikwad pgaik

Re: [PATCH] clk: tegra: local arrays should be static

2013-02-07 Thread Prashant Gaikwad
On Thursday 07 February 2013 10:00 PM, Peter De Schrijver wrote: cclk_g_parents, cclk_lp_parents and sclk_parents are only accessed from within clk-tegra30.c. Declare them static to avoid namespace polution. Signed-off-by: Peter De Schrijver pdeschrij...@nvidia.com Reviewed-by: Prashant

Re: [PATCH] clk: tegra: Add missing spinlock for hclk and pclk

2013-02-07 Thread Prashant Gaikwad
On Thursday 07 February 2013 10:07 PM, Peter De Schrijver wrote: The hclk and pclk clocks are controlled by the same register. Hence a lock is required to avoid corruption. Signed-off-by: Peter De Schrijver pdeschrij...@nvidia.com Reviewed-by: Prashant Gaikwad pgaik...@nvidia.com

Re: [PATCH V2] clk: Add composite clock type

2013-02-06 Thread Prashant Gaikwad
On Wednesday 06 February 2013 11:40 AM, Hiroshi Doyu wrote: Prashant Gaikwad wrote @ Wed, 6 Feb 2013 03:55:00 +0100: No, clk_ops depends on the clocks you are using. There could be a clock with mux and gate while another one with mux and div. You are right. What about the following? We don't

Re: [PATCH V2] clk: Add composite clock type

2013-02-06 Thread Prashant Gaikwad
On Wednesday 06 February 2013 11:40 AM, Hiroshi Doyu wrote: Prashant Gaikwad pgaik...@nvidia.com wrote @ Wed, 6 Feb 2013 03:55:00 +0100: No, clk_ops depends on the clocks you are using. There could be a clock with mux and gate while another one with mux and div. You are right. What about

Re: [PATCH] clk: Fix build for Allwinner A1X SoCs

2013-02-05 Thread Prashant Gaikwad
On Tuesday 05 February 2013 08:35 PM, Thierry Reding wrote: Commit 85a1819 (clk: sunxi: Use common of_clk_init() function) removed the source file but didn't update the Makefile, therefore causing the build to break on Allwinner A1X SoCs. Signed-off-by: Thierry Reding Thanks Thierry!! ---

Re: [PATCH V2] clk: Add composite clock type

2013-02-05 Thread Prashant Gaikwad
On Tuesday 05 February 2013 03:45 PM, Tomasz Figa wrote: Hi Prashant, Thank you for your patch. Please see some comments inline. On Monday 04 of February 2013 13:41:22 Prashant Gaikwad wrote: Not all clocks are required to be decomposed into basic clock types but at the same time want to use

Re: [PATCH V2] clk: Add composite clock type

2013-02-05 Thread Prashant Gaikwad
On Tuesday 05 February 2013 03:52 PM, Hiroshi Doyu wrote: Prashant Gaikwad wrote @ Tue, 5 Feb 2013 09:33:41 +0100: The members of "clk_composite_ops" seems to be always assigned statically. Istead of dynamically allocating/assigning, can't we just have "clk_composite_ops"

Re: [PATCH V2] clk: Add composite clock type

2013-02-05 Thread Prashant Gaikwad
On Monday 04 February 2013 03:07 PM, Hiroshi Doyu wrote: Hi Prashant, Prashant Gaikwad wrote @ Mon, 4 Feb 2013 09:11:22 +0100: +struct clk *clk_register_composite(struct device *dev, const char *name, + const char **parent_names, int num_parents

Re: [PATCH V2] clk: Add composite clock type

2013-02-05 Thread Prashant Gaikwad
On Monday 04 February 2013 03:07 PM, Hiroshi Doyu wrote: Hi Prashant, Prashant Gaikwad pgaik...@nvidia.com wrote @ Mon, 4 Feb 2013 09:11:22 +0100: +struct clk *clk_register_composite(struct device *dev, const char *name, + const char **parent_names, int num_parents

Re: [PATCH V2] clk: Add composite clock type

2013-02-05 Thread Prashant Gaikwad
On Tuesday 05 February 2013 03:52 PM, Hiroshi Doyu wrote: Prashant Gaikwad pgaik...@nvidia.com wrote @ Tue, 5 Feb 2013 09:33:41 +0100: The members of clk_composite_ops seems to be always assigned statically. Istead of dynamically allocating/assigning, can't we just have clk_composite_ops

Re: [PATCH V2] clk: Add composite clock type

2013-02-05 Thread Prashant Gaikwad
On Tuesday 05 February 2013 03:45 PM, Tomasz Figa wrote: Hi Prashant, Thank you for your patch. Please see some comments inline. On Monday 04 of February 2013 13:41:22 Prashant Gaikwad wrote: Not all clocks are required to be decomposed into basic clock types but at the same time want to use

Re: [PATCH] clk: Fix build for Allwinner A1X SoCs

2013-02-05 Thread Prashant Gaikwad
On Tuesday 05 February 2013 08:35 PM, Thierry Reding wrote: Commit 85a1819 (clk: sunxi: Use common of_clk_init() function) removed the source file but didn't update the Makefile, therefore causing the build to break on Allwinner A1X SoCs. Signed-off-by: Thierry Reding

Re: [PATCH v5 09/10] clk: tegra: Implement clocks for Tegra114

2013-02-04 Thread Prashant Gaikwad
On Monday 04 February 2013 08:04 PM, Peter De Schrijver wrote: On Mon, Feb 04, 2013 at 08:08:55AM +0100, Prashant Gaikwad wrote: On Friday 01 February 2013 03:48 PM, Peter De Schrijver wrote: ... + /* xusb_hs_src */ + val = readl(clk_base + CLK_SOURCE_XUSB_SS_SRC); + val

Re: [PATCH v5 01/10] clk: tegra: Refactor PLL programming code

2013-02-04 Thread Prashant Gaikwad
On Monday 04 February 2013 08:02 PM, Peter De Schrijver wrote: On Mon, Feb 04, 2013 at 07:06:47AM +0100, Prashant Gaikwad wrote: On Friday 01 February 2013 03:48 PM, Peter De Schrijver wrote: ... -static int clk_pll_wait_for_lock(struct tegra_clk_pll *pll

[PATCH V2] clk: Add composite clock type

2013-02-04 Thread Prashant Gaikwad
e-uses the functionality of basic clock types and not limited to basic clock types but any hardware-specific implementation. Signed-off-by: Prashant Gaikwad --- Changes from V1: - 2nd patch dropped as the concept is acked by Mike. - Fixed comments from Stephen. --- drivers/clk/Makefile |1 + drive

[PATCH V2] clk: Add composite clock type

2013-02-04 Thread Prashant Gaikwad
the functionality of basic clock types and not limited to basic clock types but any hardware-specific implementation. Signed-off-by: Prashant Gaikwad pgaik...@nvidia.com --- Changes from V1: - 2nd patch dropped as the concept is acked by Mike. - Fixed comments from Stephen. --- drivers/clk/Makefile

Re: [PATCH v5 01/10] clk: tegra: Refactor PLL programming code

2013-02-04 Thread Prashant Gaikwad
On Monday 04 February 2013 08:02 PM, Peter De Schrijver wrote: On Mon, Feb 04, 2013 at 07:06:47AM +0100, Prashant Gaikwad wrote: On Friday 01 February 2013 03:48 PM, Peter De Schrijver wrote: ... -static int clk_pll_wait_for_lock(struct tegra_clk_pll *pll

Re: [PATCH v5 09/10] clk: tegra: Implement clocks for Tegra114

2013-02-04 Thread Prashant Gaikwad
On Monday 04 February 2013 08:04 PM, Peter De Schrijver wrote: On Mon, Feb 04, 2013 at 08:08:55AM +0100, Prashant Gaikwad wrote: On Friday 01 February 2013 03:48 PM, Peter De Schrijver wrote: ... + /* xusb_hs_src */ + val = readl(clk_base + CLK_SOURCE_XUSB_SS_SRC); + val

Re: [PATCH v5 10/10] clk: tegra: devicetree match for nvidia,tegra114-car

2013-02-03 Thread Prashant Gaikwad
On Friday 01 February 2013 03:48 PM, Peter De Schrijver wrote: Signed-off-by: Peter De Schrijver --- Reviewed-by: Prashant Gaikwad drivers/clk/tegra/clk.c |1 + drivers/clk/tegra/clk.h |7 +++ 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/clk/tegra

Re: [PATCH v5 09/10] clk: tegra: Implement clocks for Tegra114

2013-02-03 Thread Prashant Gaikwad
On Friday 01 February 2013 03:48 PM, Peter De Schrijver wrote: Implement most clocks for Tegra114. The super clocks for the CPU complex are still missing and will be implemented in a future version. Signed-off-by: Peter De Schrijver --- drivers/clk/tegra/Makefile |1 +

Re: [PATCH v5 08/10] ARM: dt: Add references to tegra_car clocks

2013-02-03 Thread Prashant Gaikwad
On Friday 01 February 2013 03:48 PM, Peter De Schrijver wrote: Add references to tegra_car clocks for the basic device nodes. Signed-off-by: Peter De Schrijver --- Reviewed-by: Prashant Gaikwad arch/arm/boot/dts/tegra114.dtsi |7 ++- 1 files changed, 6 insertions(+), 1

Re: [PATCH v5 06/10] clk: tegra: Workaround for Tegra114 MSENC problem

2013-02-03 Thread Prashant Gaikwad
GRA_PERIPH_NO_RESET BIT(0) #define TEGRA_PERIPH_MANUAL_RESET BIT(1) #define TEGRA_PERIPH_ON_APB BIT(2) +#define TEGRA_PERIPH_WAR_1005168 BIT(3) Comment for this flag, otherwise Reviewed-by: Prashant Gaikwad void tegra_periph_reset(struct tegra_clk_periph_gate *gate, bool assert); ex

Re: [PATCH v5 04/10] clk: tegra: Add new fields and PLL types for Tegra114

2013-02-03 Thread Prashant Gaikwad
On Saturday 02 February 2013 01:10 AM, Rhyland Klein wrote: On 2/1/2013 5:18 AM, Peter De Schrijver wrote: Tegra114 introduces new PLL types. This requires new clocktypes as well as some new fields in the pll structure. Signed-off-by: Peter De Schrijver --- drivers/clk/tegra/clk-pll.c |

Re: [PATCH v5 05/10] clk: tegra: Add flags to tegra_clk_periph()

2013-02-03 Thread Prashant Gaikwad
On Friday 01 February 2013 03:48 PM, Peter De Schrijver wrote: We will need some tegra peripheral clocks with the CLK_IGNORE_UNUSED flag, most notably mselect, which is a bridge between AXI and most peripherals. Signed-off-by: Peter De Schrijver --- Looks good to me. Reviewed-by: Prashant

Re: [PATCH v5 03/10] clk: tegra: Add PLL post divider table

2013-02-03 Thread Prashant Gaikwad
On Friday 01 February 2013 03:48 PM, Peter De Schrijver wrote: Some PLLs in Tegra114 don't use a power of 2 mapping for the post divider. Introduce a table based approach and switch PLLU to it. Signed-off-by: Peter De Schrijver --- Looks good to me. Reviewed-by: Prashant Gaikwad

Re: [PATCH v5 02/10] clk: tegra: Add TEGRA_PLL_BYPASS flag

2013-02-03 Thread Prashant Gaikwad
On Friday 01 February 2013 03:48 PM, Peter De Schrijver wrote: Not all PLLs in Tegra114 have a bypass bit. Adapt the common code to only use this bit when available. Signed-off-by: Peter De Schrijver --- Looks good to me. Reviewed-by: Prashant Gaikwad drivers/clk/tegra/clk-pll.c | 15

Re: [PATCH v5 01/10] clk: tegra: Refactor PLL programming code

2013-02-03 Thread Prashant Gaikwad
On Friday 01 February 2013 03:48 PM, Peter De Schrijver wrote: Refactor the PLL programming code to make it useable by the new PLL types introduced by Tegra114. The following changes were done: * Split programming the PLL into updating m,n,p and updating cpcon * Move locking from

Re: [PATCH v5 01/10] clk: tegra: Refactor PLL programming code

2013-02-03 Thread Prashant Gaikwad
On Friday 01 February 2013 03:48 PM, Peter De Schrijver wrote: Refactor the PLL programming code to make it useable by the new PLL types introduced by Tegra114. The following changes were done: * Split programming the PLL into updating m,n,p and updating cpcon * Move locking from

Re: [PATCH v5 02/10] clk: tegra: Add TEGRA_PLL_BYPASS flag

2013-02-03 Thread Prashant Gaikwad
On Friday 01 February 2013 03:48 PM, Peter De Schrijver wrote: Not all PLLs in Tegra114 have a bypass bit. Adapt the common code to only use this bit when available. Signed-off-by: Peter De Schrijver pdeschrij...@nvidia.com --- Looks good to me. Reviewed-by: Prashant Gaikwad pgaik

Re: [PATCH v5 03/10] clk: tegra: Add PLL post divider table

2013-02-03 Thread Prashant Gaikwad
-by: Prashant Gaikwad pgaik...@nvidia.com drivers/clk/tegra/clk-pll.c | 38 -- drivers/clk/tegra/clk-tegra20.c |7 +++ drivers/clk/tegra/clk-tegra30.c |7 +++ drivers/clk/tegra/clk.h | 13 + 4 files changed, 59 insertions

Re: [PATCH v5 05/10] clk: tegra: Add flags to tegra_clk_periph()

2013-02-03 Thread Prashant Gaikwad
. Reviewed-by: Prashant Gaikwad pgaik...@nvidia.com drivers/clk/tegra/clk-periph.c | 11 ++- drivers/clk/tegra/clk-tegra20.c |2 +- drivers/clk/tegra/clk-tegra30.c |2 +- drivers/clk/tegra/clk.h |9 ++--- 4 files changed, 14 insertions(+), 10 deletions

Re: [PATCH v5 04/10] clk: tegra: Add new fields and PLL types for Tegra114

2013-02-03 Thread Prashant Gaikwad
On Saturday 02 February 2013 01:10 AM, Rhyland Klein wrote: On 2/1/2013 5:18 AM, Peter De Schrijver wrote: Tegra114 introduces new PLL types. This requires new clocktypes as well as some new fields in the pll structure. Signed-off-by: Peter De Schrijver pdeschrij...@nvidia.com ---

Re: [PATCH v5 06/10] clk: tegra: Workaround for Tegra114 MSENC problem

2013-02-03 Thread Prashant Gaikwad
TEGRA_PERIPH_NO_RESET BIT(0) #define TEGRA_PERIPH_MANUAL_RESET BIT(1) #define TEGRA_PERIPH_ON_APB BIT(2) +#define TEGRA_PERIPH_WAR_1005168 BIT(3) Comment for this flag, otherwise Reviewed-by: Prashant Gaikwad pgaik...@nvidia.com void tegra_periph_reset(struct tegra_clk_periph_gate *gate, bool

Re: [PATCH v5 08/10] ARM: dt: Add references to tegra_car clocks

2013-02-03 Thread Prashant Gaikwad
On Friday 01 February 2013 03:48 PM, Peter De Schrijver wrote: Add references to tegra_car clocks for the basic device nodes. Signed-off-by: Peter De Schrijver pdeschrij...@nvidia.com --- Reviewed-by: Prashant Gaikwad pgaik...@nvidia.com arch/arm/boot/dts/tegra114.dtsi |7 ++- 1

Re: [PATCH v5 09/10] clk: tegra: Implement clocks for Tegra114

2013-02-03 Thread Prashant Gaikwad
On Friday 01 February 2013 03:48 PM, Peter De Schrijver wrote: Implement most clocks for Tegra114. The super clocks for the CPU complex are still missing and will be implemented in a future version. Signed-off-by: Peter De Schrijver pdeschrij...@nvidia.com --- drivers/clk/tegra/Makefile

Re: [PATCH v5 10/10] clk: tegra: devicetree match for nvidia,tegra114-car

2013-02-03 Thread Prashant Gaikwad
On Friday 01 February 2013 03:48 PM, Peter De Schrijver wrote: Signed-off-by: Peter De Schrijver pdeschrij...@nvidia.com --- Reviewed-by: Prashant Gaikwad pgaik...@nvidia.com drivers/clk/tegra/clk.c |1 + drivers/clk/tegra/clk.h |7 +++ 2 files changed, 8 insertions(+), 0

Re: [PATCH 2/7] clk: tegra: Use common of_clk_init() function

2013-01-31 Thread Prashant Gaikwad
On Friday 25 January 2013 10:14 AM, Stephen Warren wrote: On 01/24/2013 04:57 PM, Mike Turquette wrote: Quoting Stephen Warren (2013-01-24 11:32:37) On 01/24/2013 11:20 AM, Mike Turquette wrote: Quoting Prashant Gaikwad (2013-01-04 18:44:48) On Friday 04 January 2013 10:00 PM, Stephen Warren

Re: [PATCH 2/7] clk: tegra: Use common of_clk_init() function

2013-01-31 Thread Prashant Gaikwad
On Friday 25 January 2013 10:14 AM, Stephen Warren wrote: On 01/24/2013 04:57 PM, Mike Turquette wrote: Quoting Stephen Warren (2013-01-24 11:32:37) On 01/24/2013 11:20 AM, Mike Turquette wrote: Quoting Prashant Gaikwad (2013-01-04 18:44:48) On Friday 04 January 2013 10:00 PM, Stephen Warren

[PATCH v4 4/9] ARM: tegra: Define Tegra20 CAR binding

2013-01-10 Thread Prashant Gaikwad
these clocks. This binding is only useful for Tegra20; the set of clocks that exists on Tegra30 is sufficiently different to merit its own binding. Signed-off-by: Stephen Warren Acked-by: Simon Glass [pgaikwad: Added mux clk ids and sorted CAR node] Signed-off-by: Prashant Gaikwad --- .../bindings

[PATCH v4 6/9] clk: tegra: add clock support for tegra20

2013-01-10 Thread Prashant Gaikwad
Add tegra20 clock support based on common clock framework. Signed-off-by: Prashant Gaikwad --- drivers/clk/tegra/Makefile |2 + drivers/clk/tegra/clk-tegra20.c | 1255 +++ drivers/clk/tegra/clk.h |6 + 3 files changed, 1263 insertions

[PATCH v4 3/9] arm: tegra: Move tegra_cpu_car.h to linux/clk/tegra.h

2013-01-10 Thread Prashant Gaikwad
tegra_cpu_car_ops struct is going to be accessed from drivers/clk/tegra. Move the tegra_cpu_car_ops to include/linux/clk/tegra.h. Signed-off-by: Prashant Gaikwad --- arch/arm/mach-tegra/clock.c|2 +- arch/arm/mach-tegra/cpuidle-tegra30.c |2 +- arch

[PATCH v4 8/9] arm: tegra: Migrate to new clock code

2013-01-10 Thread Prashant Gaikwad
of mach/clk.h Signed-off-by: Prashant Gaikwad --- arch/arm/mach-tegra/board-dt-tegra20.c | 30 - arch/arm/mach-tegra/board-dt-tegra30.c | 31 -- arch/arm/mach-tegra/clock.c| 19 - arch/arm/mach-tegra/common.c | 44

[PATCH v4 5/9] ARM: Tegra: Define Tegra30 CAR binding

2013-01-10 Thread Prashant Gaikwad
The device tree binding models Tegra30 CAR (Clock And Reset) as a single monolithic clock provider. Signed-off-by: Prashant Gaikwad --- .../bindings/clock/nvidia,tegra30-car.txt | 262 arch/arm/boot/dts/tegra30.dtsi |6 + 2 files changed

[PATCH v4 0/9] Migrate Tegra to common clock framework

2013-01-10 Thread Prashant Gaikwad
. Fixed some issues reported by Joseph Lo. Added function to read chip id revision register. Changes from v1: Rebased on linux-next for 20121224. Prashant Gaikwad (8): ARM: tegra: Add function to read chipid clk: tegra: Add tegra specific clocks arm: tegra: Move tegra_cpu_car.h to linux/clk

[PATCH v4 1/9] ARM: tegra: Add function to read chipid

2013-01-10 Thread Prashant Gaikwad
Add function to read chip id from APB MISC registers. This function will also get called from clock driver to flush write operations on apb bus. Signed-off-by: Prashant Gaikwad --- arch/arm/mach-tegra/fuse.c |8 +++- include/linux/tegra-soc.h | 22 ++ 2 files

Re: [PATCH 1/7] clk: add common of_clk_init() function

2013-01-10 Thread Prashant Gaikwad
On Friday 11 January 2013 01:23 AM, Josh Cartwright wrote: * PGP Signed by an unknown key On Fri, Jan 04, 2013 at 12:30:52PM +0530, Prashant Gaikwad wrote: Modify of_clk_init function so that it will determine which driver to initialize based on device tree instead of each driver registering

Re: [PATCH 1/7] clk: add common of_clk_init() function

2013-01-10 Thread Prashant Gaikwad
On Friday 11 January 2013 01:23 AM, Josh Cartwright wrote: * PGP Signed by an unknown key On Fri, Jan 04, 2013 at 12:30:52PM +0530, Prashant Gaikwad wrote: Modify of_clk_init function so that it will determine which driver to initialize based on device tree instead of each driver registering

[PATCH v4 0/9] Migrate Tegra to common clock framework

2013-01-10 Thread Prashant Gaikwad
. Fixed some issues reported by Joseph Lo. Added function to read chip id revision register. Changes from v1: Rebased on linux-next for 20121224. Prashant Gaikwad (8): ARM: tegra: Add function to read chipid clk: tegra: Add tegra specific clocks arm: tegra: Move tegra_cpu_car.h to linux/clk

[PATCH v4 1/9] ARM: tegra: Add function to read chipid

2013-01-10 Thread Prashant Gaikwad
Add function to read chip id from APB MISC registers. This function will also get called from clock driver to flush write operations on apb bus. Signed-off-by: Prashant Gaikwad pgaik...@nvidia.com --- arch/arm/mach-tegra/fuse.c |8 +++- include/linux/tegra-soc.h | 22

[PATCH v4 5/9] ARM: Tegra: Define Tegra30 CAR binding

2013-01-10 Thread Prashant Gaikwad
The device tree binding models Tegra30 CAR (Clock And Reset) as a single monolithic clock provider. Signed-off-by: Prashant Gaikwad pgaik...@nvidia.com --- .../bindings/clock/nvidia,tegra30-car.txt | 262 arch/arm/boot/dts/tegra30.dtsi |6

[PATCH v4 8/9] arm: tegra: Migrate to new clock code

2013-01-10 Thread Prashant Gaikwad
of mach/clk.h Signed-off-by: Prashant Gaikwad pgaik...@nvidia.com --- arch/arm/mach-tegra/board-dt-tegra20.c | 30 - arch/arm/mach-tegra/board-dt-tegra30.c | 31 -- arch/arm/mach-tegra/clock.c| 19 - arch/arm/mach-tegra/common.c

[PATCH v4 3/9] arm: tegra: Move tegra_cpu_car.h to linux/clk/tegra.h

2013-01-10 Thread Prashant Gaikwad
tegra_cpu_car_ops struct is going to be accessed from drivers/clk/tegra. Move the tegra_cpu_car_ops to include/linux/clk/tegra.h. Signed-off-by: Prashant Gaikwad pgaik...@nvidia.com --- arch/arm/mach-tegra/clock.c|2 +- arch/arm/mach-tegra/cpuidle-tegra30.c

[PATCH v4 6/9] clk: tegra: add clock support for tegra20

2013-01-10 Thread Prashant Gaikwad
Add tegra20 clock support based on common clock framework. Signed-off-by: Prashant Gaikwad pgaik...@nvidia.com --- drivers/clk/tegra/Makefile |2 + drivers/clk/tegra/clk-tegra20.c | 1255 +++ drivers/clk/tegra/clk.h |6 + 3 files changed

[PATCH v4 4/9] ARM: tegra: Define Tegra20 CAR binding

2013-01-10 Thread Prashant Gaikwad
] Signed-off-by: Prashant Gaikwad pgaik...@nvidia.com --- .../bindings/clock/nvidia,tegra20-car.txt | 205 arch/arm/boot/dts/tegra20.dtsi |6 + 2 files changed, 211 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree

Re: [PATCH 2/2] clk: tegra30: Convert clk out to composite clk

2013-01-04 Thread Prashant Gaikwad
On Friday 04 January 2013 09:55 PM, Stephen Warren wrote: On 01/03/2013 10:51 PM, Prashant Gaikwad wrote: Convert clk out to composite clock type which removes the mux clock. Signed-off-by: Prashant Gaikwad --- This patch is rebased on ccf-rework for Tegra patch series. It is just to show how

Re: [PATCH 1/2] clk: Add composite clock type

2013-01-04 Thread Prashant Gaikwad
On Saturday 05 January 2013 03:48 AM, Stephen Boyd wrote: On 01/03/13 21:51, Prashant Gaikwad wrote: diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile index f0b269a..baf7608 100644 --- a/drivers/clk/Makefile +++ b/drivers/clk/Makefile @@ -2,7 +2,8 @@ obj-$(CONFIG_HAVE_CLK

Re: [PATCH 2/7] clk: tegra: Use common of_clk_init() function

2013-01-04 Thread Prashant Gaikwad
On Friday 04 January 2013 10:00 PM, Stephen Warren wrote: On 01/04/2013 12:00 AM, Prashant Gaikwad wrote: Use common of_clk_init() function for clocks initialization. drivers/clk/tegra/clk-tegra20.c |3 ++- drivers/clk/tegra/clk-tegra30.c |3 ++- Oh, so this series is written

[PATCH 3/7] ASoC: tegra: remove auxdata

2013-01-04 Thread Prashant Gaikwad
Configlink clock information is added to device tree. Get the clocks using device node. Remove AUXDATA. Signed-off-by: Prashant Gaikwad --- sound/soc/tegra/tegra30_ahub.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) diff --git a/sound/soc/tegra/tegra30_ahub.c b

[PATCH 7/7] clk: tegra30: remove unused TEGRA_CLK_DUPLICATE()s

2013-01-04 Thread Prashant Gaikwad
With device tree support added for Tegra clocks look up is done from device tree, remove unused TEGRA_CLK_DUPLICATE()s. Signed-off-by: Prashant Gaikwad --- drivers/clk/tegra/clk-tegra30.c | 34 -- 1 files changed, 0 insertions(+), 34 deletions(-) diff --git

[PATCH 5/7] arm: tegra30: remove auxdata

2013-01-04 Thread Prashant Gaikwad
Remove AUXDATA as clocks are initialized from device node. Signed-off-by: Prashant Gaikwad --- arch/arm/mach-tegra/board-dt-tegra30.c | 31 +-- 1 files changed, 1 insertions(+), 30 deletions(-) diff --git a/arch/arm/mach-tegra/board-dt-tegra30.c b/arch/arm/mach

[PATCH 2/7] ARM: dt: tegra30: Add clock information

2013-01-04 Thread Prashant Gaikwad
Add clock information to device nodes. Signed-off-by: Prashant Gaikwad --- arch/arm/boot/dts/tegra30.dtsi | 52 +++- 1 files changed, 51 insertions(+), 1 deletions(-) diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi index

[PATCH 6/7] clk: tegra20: remove unused TEGRA_CLK_DUPLICATE()s

2013-01-04 Thread Prashant Gaikwad
With device tree support added for Tegra clocks look up is done from device tree, remove unused TEGRA_CLK_DUPLICATE()s. Signed-off-by: Prashant Gaikwad --- drivers/clk/tegra/clk-tegra20.c | 17 - 1 files changed, 0 insertions(+), 17 deletions(-) diff --git a/drivers/clk/tegra

[PATCH 4/7] arm: tegra20: remove auxdata

2013-01-04 Thread Prashant Gaikwad
Remove AUXDATA as clock are initialized from device node. Signed-off-by: Prashant Gaikwad --- arch/arm/mach-tegra/board-dt-tegra20.c | 24 1 files changed, 0 insertions(+), 24 deletions(-) diff --git a/arch/arm/mach-tegra/board-dt-tegra20.c b/arch/arm/mach-tegra

[PATCH 1/7] ARM: dt: tegra20: Add clock information

2013-01-04 Thread Prashant Gaikwad
Add clock information to device nodes. Signed-off-by: Prashant Gaikwad --- Tested on Ventana (Tegra20) and Cardhu (Tegra30). This series depends on ccf-rework patch series. --- arch/arm/boot/dts/tegra20.dtsi | 41 1 files changed, 41 insertions(+), 0

  1   2   3   >