Re: [PATCH v2] arm64: fix unwind_frame() for filtered out fn for function graph tracing

2017-09-12 Thread Pratyush Anand
On Wednesday 13 September 2017 08:12 AM, Will Deacon wrote: On Tue, Sep 12, 2017 at 10:54:28AM +0100, James Morse wrote: Hi Pratyush, On 01/09/17 06:48, Pratyush Anand wrote: do_task_stat() calls get_wchan(), which further does unbind_frame(). unbind_frame() restores frame->pc to origi

Re: [PATCH v2] arm64: fix unwind_frame() for filtered out fn for function graph tracing

2017-09-12 Thread Pratyush Anand
On Wednesday 13 September 2017 08:12 AM, Will Deacon wrote: On Tue, Sep 12, 2017 at 10:54:28AM +0100, James Morse wrote: Hi Pratyush, On 01/09/17 06:48, Pratyush Anand wrote: do_task_stat() calls get_wchan(), which further does unbind_frame(). unbind_frame() restores frame->pc to origi

[PATCH v2] arm64: fix unwind_frame() for filtered out fn for function graph tracing

2017-08-31 Thread Pratyush Anand
[] SyS_read+0x60/0xc0 [] __sys_trace_return+0x0/0x4 fixes: 20380bb390a4 (arm64: ftrace: fix a stack tracer's output under function graph tracer) Signed-off-by: Pratyush Anand <pan...@redhat.com> --- v1 -> v2: - improved commit log - now index is restored and thereafter f

[PATCH v2] arm64: fix unwind_frame() for filtered out fn for function graph tracing

2017-08-31 Thread Pratyush Anand
[] SyS_read+0x60/0xc0 [] __sys_trace_return+0x0/0x4 fixes: 20380bb390a4 (arm64: ftrace: fix a stack tracer's output under function graph tracer) Signed-off-by: Pratyush Anand --- v1 -> v2: - improved commit log - now index is restored and thereafter frame->pc as well. arch/arm

Re: [PATCH 03/14] resource: add walk_system_ram_res_rev()

2017-08-30 Thread Pratyush Anand
On Thursday 24 August 2017 01:48 PM, AKASHI Takahiro wrote: This function, being a variant of walk_system_ram_res() introduced in commit 8c86e70acead ("resource: provide new functions to walk through resources"), walks through a list of all the resources of System RAM in reversed order, i.e.,

Re: [PATCH 03/14] resource: add walk_system_ram_res_rev()

2017-08-30 Thread Pratyush Anand
On Thursday 24 August 2017 01:48 PM, AKASHI Takahiro wrote: This function, being a variant of walk_system_ram_res() introduced in commit 8c86e70acead ("resource: provide new functions to walk through resources"), walks through a list of all the resources of System RAM in reversed order, i.e.,

Re: [PATCH] arm64: fix unwind_frame() for filtered out fn via set_graph_notrace

2017-08-30 Thread Pratyush Anand
fixed it. I hope, it won't miss from next time. On 28/08/17 13:53, Pratyush Anand wrote: Testcase: cd /sys/kernel/debug/tracing/ echo schedule > set_graph_notrace echo 1 > options/display-graph echo wakeup > current_tracer ps -ef | grep -i agent Above commands result in PANIC: "Un

Re: [PATCH] arm64: fix unwind_frame() for filtered out fn via set_graph_notrace

2017-08-30 Thread Pratyush Anand
fixed it. I hope, it won't miss from next time. On 28/08/17 13:53, Pratyush Anand wrote: Testcase: cd /sys/kernel/debug/tracing/ echo schedule > set_graph_notrace echo 1 > options/display-graph echo wakeup > current_tracer ps -ef | grep -i agent Above commands result in PANIC: "Un

[PATCH] arm64: fix unwind_frame() for filtered out fn via set_graph_notrace

2017-08-28 Thread Pratyush Anand
milar problem we can have with calling of walk_stackframe() from save_stack_trace_tsk() or dump_backtrace(). This patch fixes unwind_frame() to not to manipulate frame->pc for function graph tracer if the function has been marked in set_graph_notrace. This patch fixes: 20380bb390a4 (arm64: ftrace

[PATCH] arm64: fix unwind_frame() for filtered out fn via set_graph_notrace

2017-08-28 Thread Pratyush Anand
e->pc for function graph tracer if the function has been marked in set_graph_notrace. This patch fixes: 20380bb390a4 (arm64: ftrace: fix a stack tracer's output under function graph tracer) Signed-off-by: Pratyush Anand --- arch/arm64/kernel/stacktrace.c | 3 ++- 1 file changed, 2 insertions(+), 1 del

Re: [PATCH v3 0/5] ARM64: disable irq between breakpoint and step exception

2017-08-25 Thread Pratyush Anand
July 2017 04:10 PM, Pratyush Anand wrote: v2 -> v3 - Moved step_needed from uapi structure to kernel only structure - Re-enable interrupt if stepped instruction faults - Modified register_wide_hw_breakpoint() to accept step_needed arg v2 was here: http://marc.info/?l=linux-arm-kernel=149942910730

Re: [PATCH v3 0/5] ARM64: disable irq between breakpoint and step exception

2017-08-25 Thread Pratyush Anand
July 2017 04:10 PM, Pratyush Anand wrote: v2 -> v3 - Moved step_needed from uapi structure to kernel only structure - Re-enable interrupt if stepped instruction faults - Modified register_wide_hw_breakpoint() to accept step_needed arg v2 was here: http://marc.info/?l=linux-arm-kernel=149942910730

[PATCH] tracer: hwlat: allow to be default bootup tracer

2017-08-11 Thread Pratyush Anand
. Signed-off-by: Pratyush Anand <pan...@redhat.com> --- kernel/trace/trace_hwlat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_hwlat.c b/kernel/trace/trace_hwlat.c index d7c8e4ec3d9d..09f8f0950b6c 100644 --- a/kernel/trace/trace_hwlat.c +++ b/kernel

[PATCH] tracer: hwlat: allow to be default bootup tracer

2017-08-11 Thread Pratyush Anand
. Signed-off-by: Pratyush Anand --- kernel/trace/trace_hwlat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_hwlat.c b/kernel/trace/trace_hwlat.c index d7c8e4ec3d9d..09f8f0950b6c 100644 --- a/kernel/trace/trace_hwlat.c +++ b/kernel/trace/trace_hwlat.c @@ -630,4

Re: RCU stall when using function_graph

2017-08-09 Thread Pratyush Anand
On Sunday 06 August 2017 10:32 PM, Paul E. McKenney wrote: On Sat, Aug 05, 2017 at 02:24:21PM +0900, 김동현 wrote: Dear All As for me, after configuring function_graph as below, crash disappears. "echo 0 > d/tracing/tracing_on" "sleep 1" "echo function_graph > d/tracing/current_tracer" "sleep

Re: RCU stall when using function_graph

2017-08-09 Thread Pratyush Anand
On Sunday 06 August 2017 10:32 PM, Paul E. McKenney wrote: On Sat, Aug 05, 2017 at 02:24:21PM +0900, 김동현 wrote: Dear All As for me, after configuring function_graph as below, crash disappears. "echo 0 > d/tracing/tracing_on" "sleep 1" "echo function_graph > d/tracing/current_tracer" "sleep

Re: rcu_sched stall while waiting in csd_lock_wait()

2017-08-02 Thread Pratyush Anand
Hi Peter, On Wednesday 02 August 2017 01:44 PM, Peter Zijlstra wrote: On Wed, Aug 02, 2017 at 09:01:19AM +0530, Pratyush Anand wrote: Hi, I am observing following rcu_sched stall while executing `perf record -a -- sleep 1` with one of the arm64 platform. It looks like that stalled cpu

Re: rcu_sched stall while waiting in csd_lock_wait()

2017-08-02 Thread Pratyush Anand
Hi Peter, On Wednesday 02 August 2017 01:44 PM, Peter Zijlstra wrote: On Wed, Aug 02, 2017 at 09:01:19AM +0530, Pratyush Anand wrote: Hi, I am observing following rcu_sched stall while executing `perf record -a -- sleep 1` with one of the arm64 platform. It looks like that stalled cpu

Re: rcu_sched stall while waiting in csd_lock_wait()

2017-08-02 Thread Pratyush Anand
Hi Marc, On Wednesday 02 August 2017 02:14 PM, Marc Zyngier wrote: On 02/08/17 09:08, Will Deacon wrote: Hi Pratyush, On Wed, Aug 02, 2017 at 09:01:19AM +0530, Pratyush Anand wrote: I am observing following rcu_sched stall while executing `perf record -a -- sleep 1` with one of the arm64

Re: rcu_sched stall while waiting in csd_lock_wait()

2017-08-02 Thread Pratyush Anand
Hi Marc, On Wednesday 02 August 2017 02:14 PM, Marc Zyngier wrote: On 02/08/17 09:08, Will Deacon wrote: Hi Pratyush, On Wed, Aug 02, 2017 at 09:01:19AM +0530, Pratyush Anand wrote: I am observing following rcu_sched stall while executing `perf record -a -- sleep 1` with one of the arm64

Re: rcu_sched stall while waiting in csd_lock_wait()

2017-08-02 Thread Pratyush Anand
Hi Will, On Wednesday 02 August 2017 01:38 PM, Will Deacon wrote: Hi Pratyush, On Wed, Aug 02, 2017 at 09:01:19AM +0530, Pratyush Anand wrote: I am observing following rcu_sched stall while executing `perf record -a -- sleep 1` with one of the arm64 platform. It looks like that stalled cpu

Re: rcu_sched stall while waiting in csd_lock_wait()

2017-08-02 Thread Pratyush Anand
Hi Will, On Wednesday 02 August 2017 01:38 PM, Will Deacon wrote: Hi Pratyush, On Wed, Aug 02, 2017 at 09:01:19AM +0530, Pratyush Anand wrote: I am observing following rcu_sched stall while executing `perf record -a -- sleep 1` with one of the arm64 platform. It looks like that stalled cpu

Re: [PATCH v3 0/5] ARM64: disable irq between breakpoint and step exception

2017-08-02 Thread Pratyush Anand
Hi James, Thanks for your analysis. On Wednesday 02 August 2017 10:43 PM, James Morse wrote: Hi Pratyush, On 01/08/17 05:18, Pratyush Anand wrote: On Monday 31 July 2017 10:45 PM, James Morse wrote: On 31/07/17 11:40, Pratyush Anand wrote: samples/hw_breakpoint/data_breakpoint.c passes

Re: [PATCH v3 0/5] ARM64: disable irq between breakpoint and step exception

2017-08-02 Thread Pratyush Anand
Hi James, Thanks for your analysis. On Wednesday 02 August 2017 10:43 PM, James Morse wrote: Hi Pratyush, On 01/08/17 05:18, Pratyush Anand wrote: On Monday 31 July 2017 10:45 PM, James Morse wrote: On 31/07/17 11:40, Pratyush Anand wrote: samples/hw_breakpoint/data_breakpoint.c passes

Query: rcu_sched detected stalls with function_graph tracer

2017-08-02 Thread Pratyush Anand
Hi Steve, I am using a 3.10 based kernel, and when I enable function_graph with one particular x86_64 machine, I encounter rcu_sched stall. echo function_graph > /sys/kernel/debug/tracing/current_tracer echo 1 > /sys/kernel/debug/tracing/tracing_on If I use 4.13-rc2, then its better, but

Query: rcu_sched detected stalls with function_graph tracer

2017-08-02 Thread Pratyush Anand
Hi Steve, I am using a 3.10 based kernel, and when I enable function_graph with one particular x86_64 machine, I encounter rcu_sched stall. echo function_graph > /sys/kernel/debug/tracing/current_tracer echo 1 > /sys/kernel/debug/tracing/tracing_on If I use 4.13-rc2, then its better, but

rcu_sched stall while waiting in csd_lock_wait()

2017-08-01 Thread Pratyush Anand
Hi, I am observing following rcu_sched stall while executing `perf record -a -- sleep 1` with one of the arm64 platform. It looks like that stalled cpu was waiting in csd_lock_wait() from where it never came out,and so the stall. Any help/pointer for further debugging would be very helpful.

rcu_sched stall while waiting in csd_lock_wait()

2017-08-01 Thread Pratyush Anand
Hi, I am observing following rcu_sched stall while executing `perf record -a -- sleep 1` with one of the arm64 platform. It looks like that stalled cpu was waiting in csd_lock_wait() from where it never came out,and so the stall. Any help/pointer for further debugging would be very helpful.

Re: [PATCH v3 0/5] ARM64: disable irq between breakpoint and step exception

2017-08-01 Thread Pratyush Anand
Hi Takahiro, On Tuesday 01 August 2017 01:44 PM, AKASHI Takahiro wrote: Hi Pratyush, On Mon, Jul 31, 2017 at 04:10:28PM +0530, Pratyush Anand wrote: v2 -> v3 - Moved step_needed from uapi structure to kernel only structure - Re-enable interrupt if stepped instruction faults - Modif

Re: [PATCH v3 0/5] ARM64: disable irq between breakpoint and step exception

2017-08-01 Thread Pratyush Anand
Hi Takahiro, On Tuesday 01 August 2017 01:44 PM, AKASHI Takahiro wrote: Hi Pratyush, On Mon, Jul 31, 2017 at 04:10:28PM +0530, Pratyush Anand wrote: v2 -> v3 - Moved step_needed from uapi structure to kernel only structure - Re-enable interrupt if stepped instruction faults - Modif

Re: [PATCH v3 0/5] ARM64: disable irq between breakpoint and step exception

2017-07-31 Thread Pratyush Anand
Hi James, On Monday 31 July 2017 10:45 PM, James Morse wrote: Hi Pratyush, On 31/07/17 11:40, Pratyush Anand wrote: samples/hw_breakpoint/data_breakpoint.c passes with x86_64 but fails with ARM64. Even though it has been NAKed previously on upstream [1, 2], I have tried to come up

Re: [PATCH v3 0/5] ARM64: disable irq between breakpoint and step exception

2017-07-31 Thread Pratyush Anand
Hi James, On Monday 31 July 2017 10:45 PM, James Morse wrote: Hi Pratyush, On 31/07/17 11:40, Pratyush Anand wrote: samples/hw_breakpoint/data_breakpoint.c passes with x86_64 but fails with ARM64. Even though it has been NAKed previously on upstream [1, 2], I have tried to come up

Re: [PATCH RFC] arm64: introduce mm_context_t flags

2017-07-31 Thread Pratyush Anand
On Monday 31 July 2017 08:18 PM, Yury Norov wrote: - If we start using TIF flags here, we cannot easily add new mm_context specific bits because they may mess with TIF ones. This one seems convincing argument. ATM do you have any mm_context flag which would you like to incorporate?

Re: [PATCH RFC] arm64: introduce mm_context_t flags

2017-07-31 Thread Pratyush Anand
On Monday 31 July 2017 08:18 PM, Yury Norov wrote: - If we start using TIF flags here, we cannot easily add new mm_context specific bits because they may mess with TIF ones. This one seems convincing argument. ATM do you have any mm_context flag which would you like to incorporate?

[PATCH v3 2/5] arm64: use hw_breakpoint_needs_single_step() to decide if step is needed

2017-07-31 Thread Pratyush Anand
fault step handler. hw_breakpoint_needs_single_step() will be true if any hw_breakpoint user wants to use default step handler and sets step_needed in hw_perf_event. Signed-off-by: Pratyush Anand <pan...@redhat.com> --- arch/arm64/kernel/hw_breakpoint.c | 6 +++--- 1 file changed, 3 insertions

[PATCH v3 2/5] arm64: use hw_breakpoint_needs_single_step() to decide if step is needed

2017-07-31 Thread Pratyush Anand
fault step handler. hw_breakpoint_needs_single_step() will be true if any hw_breakpoint user wants to use default step handler and sets step_needed in hw_perf_event. Signed-off-by: Pratyush Anand --- arch/arm64/kernel/hw_breakpoint.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH v3 1/5] hw_breakpoint: Add step_needed event attribute

2017-07-31 Thread Pratyush Anand
introduces a flag 'step_needed' in struct hw_perf_event, so that arch specific code(specially on arm64) can make a decision to enable single stepping. Any architecture which is not using this field will not have any side effect. Signed-off-by: Pratyush Anand <pan...@redhat.com> --- include

[PATCH v3 1/5] hw_breakpoint: Add step_needed event attribute

2017-07-31 Thread Pratyush Anand
introduces a flag 'step_needed' in struct hw_perf_event, so that arch specific code(specially on arm64) can make a decision to enable single stepping. Any architecture which is not using this field will not have any side effect. Signed-off-by: Pratyush Anand --- include/linux/hw_breakpoint.h | 6

[PATCH v3 3/5] register_wide_hw_breakpoint(): modify to accept step_needed arg

2017-07-31 Thread Pratyush Anand
not use it so far. Signed-off-by: Pratyush Anand <pan...@redhat.com> --- arch/x86/kernel/kgdb.c | 2 +- include/linux/hw_breakpoint.h | 4 ++-- kernel/events/hw_breakpoint.c | 4 +++- samples/hw_breakpoint/data_breakpoint.c | 3 ++- 4 files changed, 8 inse

[PATCH v3 3/5] register_wide_hw_breakpoint(): modify to accept step_needed arg

2017-07-31 Thread Pratyush Anand
not use it so far. Signed-off-by: Pratyush Anand --- arch/x86/kernel/kgdb.c | 2 +- include/linux/hw_breakpoint.h | 4 ++-- kernel/events/hw_breakpoint.c | 4 +++- samples/hw_breakpoint/data_breakpoint.c | 3 ++- 4 files changed, 8 insertions(+), 5 deletions

[PATCH v3 4/5] arm64: disable irq between breakpoint and step exception

2017-07-31 Thread Pratyush Anand
breakpoint. Interrupt will be disabled if kgdb or kprobe breakpoint handler requires a single stepping. Signed-off-by: Pratyush Anand <pan...@redhat.com> --- arch/arm64/kernel/debug-monitors.c | 3 +++ arch/arm64/kernel/hw_breakpoint.c | 4 ++-- arch/arm64/mm/fault.c

[PATCH v3 5/5] arm64: fault: re-enable irq if it was disabled for single stepping

2017-07-31 Thread Pratyush Anand
stepping. Signed-off-by: Pratyush Anand <pan...@redhat.com> --- arch/arm64/mm/fault.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c index ce5290dacba3..2b88807eb964 100644 --- a/arch/arm64/mm/fault.c +++ b/arch/ar

[PATCH v3 4/5] arm64: disable irq between breakpoint and step exception

2017-07-31 Thread Pratyush Anand
breakpoint. Interrupt will be disabled if kgdb or kprobe breakpoint handler requires a single stepping. Signed-off-by: Pratyush Anand --- arch/arm64/kernel/debug-monitors.c | 3 +++ arch/arm64/kernel/hw_breakpoint.c | 4 ++-- arch/arm64/mm/fault.c | 22 ++ 3 files

[PATCH v3 5/5] arm64: fault: re-enable irq if it was disabled for single stepping

2017-07-31 Thread Pratyush Anand
stepping. Signed-off-by: Pratyush Anand --- arch/arm64/mm/fault.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c index ce5290dacba3..2b88807eb964 100644 --- a/arch/arm64/mm/fault.c +++ b/arch/arm64/mm/fault.c @@ -589,6

[PATCH v3 0/5] ARM64: disable irq between breakpoint and step exception

2017-07-31 Thread Pratyush Anand
ux-arm-kernel/2016-April/425266.html Pratyush Anand (5): hw_breakpoint: Add step_needed event attribute arm64: use hw_breakpoint_needs_single_step() to decide if step is needed register_wide_hw_breakpoint(): modify to accept step_needed arg arm64: disable irq between breakpoint an

[PATCH v3 0/5] ARM64: disable irq between breakpoint and step exception

2017-07-31 Thread Pratyush Anand
ux-arm-kernel/2016-April/425266.html Pratyush Anand (5): hw_breakpoint: Add step_needed event attribute arm64: use hw_breakpoint_needs_single_step() to decide if step is needed register_wide_hw_breakpoint(): modify to accept step_needed arg arm64: disable irq between breakpoint an

Re: [PATCH V2 1/4] hw_breakpoint: Add step_needed event attribute

2017-07-25 Thread Pratyush Anand
On Tuesday 25 July 2017 06:57 PM, Will Deacon wrote: On Fri, Jul 07, 2017 at 05:33:57PM +0530, Pratyush Anand wrote: Architecture like ARM64 currently allows to use default hw breakpoint single step handler only to perf. However, some other users like few systemtap tests or kernel test

Re: [PATCH V2 1/4] hw_breakpoint: Add step_needed event attribute

2017-07-25 Thread Pratyush Anand
On Tuesday 25 July 2017 06:57 PM, Will Deacon wrote: On Fri, Jul 07, 2017 at 05:33:57PM +0530, Pratyush Anand wrote: Architecture like ARM64 currently allows to use default hw breakpoint single step handler only to perf. However, some other users like few systemtap tests or kernel test

Re: [PATCH V2 4/4] arm64: disable irq between breakpoint and step exception

2017-07-25 Thread Pratyush Anand
Hi Will, Thanks for your review. On Tuesday 25 July 2017 06:55 PM, Will Deacon wrote: On Fri, Jul 07, 2017 at 05:34:00PM +0530, Pratyush Anand wrote: If an interrupt is generated between breakpoint and step handler then step handler can not get correct step address. This situation can easily

Re: [PATCH V2 4/4] arm64: disable irq between breakpoint and step exception

2017-07-25 Thread Pratyush Anand
Hi Will, Thanks for your review. On Tuesday 25 July 2017 06:55 PM, Will Deacon wrote: On Fri, Jul 07, 2017 at 05:34:00PM +0530, Pratyush Anand wrote: If an interrupt is generated between breakpoint and step handler then step handler can not get correct step address. This situation can easily

Re: [PATCH V2 0/4] ARM64: Fix irq generation between breakpoint and step exception

2017-07-16 Thread Pratyush Anand
On Friday 07 July 2017 05:33 PM, Pratyush Anand wrote: v1 was here http://marc.info/?l=linux-arm-kernel=149910958418708=2 v1 -> v2: - patch 1 of v1 has been modified to patch 1-3 of v2. - Introduced a new event attribute step_needed and implemented hw_breakpoint_needs_single_step() (patc

Re: [PATCH V2 0/4] ARM64: Fix irq generation between breakpoint and step exception

2017-07-16 Thread Pratyush Anand
On Friday 07 July 2017 05:33 PM, Pratyush Anand wrote: v1 was here http://marc.info/?l=linux-arm-kernel=149910958418708=2 v1 -> v2: - patch 1 of v1 has been modified to patch 1-3 of v2. - Introduced a new event attribute step_needed and implemented hw_breakpoint_needs_single_step() (patc

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

2017-07-13 Thread Pratyush Anand
Hi Felipe, On Friday 09 June 2017 03:58 PM, Felipe Balbi wrote: Felipe Balbi writes: Allow for ftrace data to be exported over a USB Gadget Controller. With this, we have a potentially very fast pipe for transmitting ftrace data to a Host PC for further

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

2017-07-13 Thread Pratyush Anand
Hi Felipe, On Friday 09 June 2017 03:58 PM, Felipe Balbi wrote: Felipe Balbi writes: Allow for ftrace data to be exported over a USB Gadget Controller. With this, we have a potentially very fast pipe for transmitting ftrace data to a Host PC for further analysis. Note that in order to

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

2017-07-13 Thread Pratyush Anand
Hi Felipe, On Friday 09 June 2017 11:43 AM, Felipe Balbi wrote: +static void notrace ftrace_write(struct trace_export *ftrace, const void *buf, +unsigned int len) +{ + struct usb_ftrace *trace = ftrace_to_trace(ftrace); + struct

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

2017-07-13 Thread Pratyush Anand
Hi Felipe, On Friday 09 June 2017 11:43 AM, Felipe Balbi wrote: +static void notrace ftrace_write(struct trace_export *ftrace, const void *buf, +unsigned int len) +{ + struct usb_ftrace *trace = ftrace_to_trace(ftrace); + struct

[PATCH V2 2/4] arm64: use hw_breakpoint_needs_single_step() to decide if step is needed

2017-07-07 Thread Pratyush Anand
fault step handler. hw_breakpoint_needs_single_step() will be true if any hw_breakpoint user wants to use default step handler and sets step_needed in attribute. Signed-off-by: Pratyush Anand <pan...@redhat.com> --- arch/arm64/kernel/hw_breakpoint.c | 6 +++--- 1 file changed, 3 insertions

[PATCH V2 3/4] hw-breakpoint: sample test: set step_needed bit field

2017-07-07 Thread Pratyush Anand
arch like ARM64 expects 'step_needed == true' in order to use default single step handler. Therefore, set the bit field in the test case. Other arch will not have any affect as they do not use it so far. Signed-off-by: Pratyush Anand <pan...@redhat.com> --- samples/hw_brea

[PATCH V2 2/4] arm64: use hw_breakpoint_needs_single_step() to decide if step is needed

2017-07-07 Thread Pratyush Anand
fault step handler. hw_breakpoint_needs_single_step() will be true if any hw_breakpoint user wants to use default step handler and sets step_needed in attribute. Signed-off-by: Pratyush Anand --- arch/arm64/kernel/hw_breakpoint.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --

[PATCH V2 3/4] hw-breakpoint: sample test: set step_needed bit field

2017-07-07 Thread Pratyush Anand
arch like ARM64 expects 'step_needed == true' in order to use default single step handler. Therefore, set the bit field in the test case. Other arch will not have any affect as they do not use it so far. Signed-off-by: Pratyush Anand --- samples/hw_breakpoint/data_breakpoint.c | 1 + 1 file

[PATCH V2 0/4] ARM64: Fix irq generation between breakpoint and step exception

2017-07-07 Thread Pratyush Anand
set attempts to resolve both the issue. Please review. [1] http://marc.info/?l=linux-arm-kernel=149580777524910=2 [2] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-April/425266.html Pratyush Anand (4): hw_breakpoint: Add step_needed event attribute arm64:

[PATCH V2 4/4] arm64: disable irq between breakpoint and step exception

2017-07-07 Thread Pratyush Anand
in do_debug_exception() that whether a step exception will be followed or not. If there will a step exception then disable irq. Re-enable it after single step handling. Signed-off-by: Pratyush Anand <pan...@redhat.com> --- arch/arm64/kernel/debug-monitors.c | 3 +++ arch/arm64/kernel/hw_breakpoint.c

[PATCH V2 0/4] ARM64: Fix irq generation between breakpoint and step exception

2017-07-07 Thread Pratyush Anand
set attempts to resolve both the issue. Please review. [1] http://marc.info/?l=linux-arm-kernel=149580777524910=2 [2] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-April/425266.html Pratyush Anand (4): hw_breakpoint: Add step_needed event attribute arm64:

[PATCH V2 4/4] arm64: disable irq between breakpoint and step exception

2017-07-07 Thread Pratyush Anand
in do_debug_exception() that whether a step exception will be followed or not. If there will a step exception then disable irq. Re-enable it after single step handling. Signed-off-by: Pratyush Anand --- arch/arm64/kernel/debug-monitors.c | 3 +++ arch/arm64/kernel/hw_breakpoint.c | 4 ++-- arch/arm64/mm/fault.c

[PATCH V2 1/4] hw_breakpoint: Add step_needed event attribute

2017-07-07 Thread Pratyush Anand
. Signed-off-by: Pratyush Anand <pan...@redhat.com> --- include/linux/hw_breakpoint.h | 6 ++ include/uapi/linux/perf_event.h | 3 ++- kernel/events/core.c | 2 ++ tools/include/uapi/linux/perf_event.h | 3 ++- 4 files changed, 12 insertions(+), 2 deletions(-)

[PATCH V2 1/4] hw_breakpoint: Add step_needed event attribute

2017-07-07 Thread Pratyush Anand
. Signed-off-by: Pratyush Anand --- include/linux/hw_breakpoint.h | 6 ++ include/uapi/linux/perf_event.h | 3 ++- kernel/events/core.c | 2 ++ tools/include/uapi/linux/perf_event.h | 3 ++- 4 files changed, 12 insertions(+), 2 deletions(-) diff --git a/include/linux

Re: [RFC, 2/2] kallsyms: Do not display SyS_foo() syscall aliases in kallsyms

2017-06-15 Thread Pratyush Anand
On Thursday 15 June 2017 08:00 PM, Steven Rostedt wrote: On Thu, 15 Jun 2017 19:56:40 +0530 Pratyush Anand <pan...@redhat.com> wrote: From: Steven Rostedt <rost...@goodmis.org> Hi Steve, Is there any plan for next revision of this patchset. Heh, I forgot about this. Actual

Re: [RFC, 2/2] kallsyms: Do not display SyS_foo() syscall aliases in kallsyms

2017-06-15 Thread Pratyush Anand
On Thursday 15 June 2017 08:00 PM, Steven Rostedt wrote: On Thu, 15 Jun 2017 19:56:40 +0530 Pratyush Anand wrote: From: Steven Rostedt Hi Steve, Is there any plan for next revision of this patchset. Heh, I forgot about this. Actually, I didn't. I was just thinking about the issue

Re: [RFC, 2/2] kallsyms: Do not display SyS_foo() syscall aliases in kallsyms

2017-06-15 Thread Pratyush Anand
On Thursday 15 June 2017 07:56 PM, Pratyush Anand wrote: From: Steven Rostedt <rost...@goodmis.org> Sorry, Please ignore this. I did not had this patch in my inbox and replied through patchwork mailbox. Forgot to change the "from" field. Here is the patch link, which coul

Re: [RFC, 2/2] kallsyms: Do not display SyS_foo() syscall aliases in kallsyms

2017-06-15 Thread Pratyush Anand
On Thursday 15 June 2017 07:56 PM, Pratyush Anand wrote: From: Steven Rostedt Sorry, Please ignore this. I did not had this patch in my inbox and replied through patchwork mailbox. Forgot to change the "from" field. Here is the patch link, which could resolve issues with trace

[RFC, 2/2] kallsyms: Do not display SyS_foo() syscall aliases in kallsyms

2017-06-15 Thread Pratyush Anand
From: Steven Rostedt Hi Steve, Is there any plan for next revision of this patchset. Regards Pratyush

[RFC, 2/2] kallsyms: Do not display SyS_foo() syscall aliases in kallsyms

2017-06-15 Thread Pratyush Anand
From: Steven Rostedt Hi Steve, Is there any plan for next revision of this patchset. Regards Pratyush

[PATCH] mei: make sysfs modalias format similar as uevent modalias

2017-05-24 Thread Pratyush Anand
uevent modalias as mei:S:uuid:N:*, however sysfs modalias is still in formmat mei:S:uuid:*. This patch equates format of uevent and sysfs modalias so that modprobe is able to resolve the aliases. Signed-off-by: Pratyush Anand <pan...@redhat.com> --- drivers/misc/mei/bus.c | 4 +++- 1 file c

[PATCH] mei: make sysfs modalias format similar as uevent modalias

2017-05-24 Thread Pratyush Anand
uevent modalias as mei:S:uuid:N:*, however sysfs modalias is still in formmat mei:S:uuid:*. This patch equates format of uevent and sysfs modalias so that modprobe is able to resolve the aliases. Signed-off-by: Pratyush Anand --- drivers/misc/mei/bus.c | 4 +++- 1 file changed, 3 insertions(+), 1

Re: [PATCH v2] kexec/kdump: Minor Documentation updates for arm64 and Image

2017-05-22 Thread Pratyush Anand
ch is used for ARM64. Signed-off-by: Bharat Bhushan <bharat.bhus...@nxp.com> --- v1->v2 - "a uncompressed" replaced with "an uncompressed" Reviewed-by: Pratyush Anand <pan...@redhat.com> Documentation/kdump/kdump.txt | 12 +--- 1 file changed

Re: [PATCH v2] kexec/kdump: Minor Documentation updates for arm64 and Image

2017-05-22 Thread Pratyush Anand
ch is used for ARM64. Signed-off-by: Bharat Bhushan --- v1->v2 - "a uncompressed" replaced with "an uncompressed" Reviewed-by: Pratyush Anand Documentation/kdump/kdump.txt | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/Documentation/kdum

Re: [PATCH] kexec/kdump: Minor Documentation updates for arm64 and Image

2017-05-22 Thread Pratyush Anand
On Monday 22 May 2017 12:19 PM, Bharat Bhushan wrote: On Friday 19 May 2017 09:15 AM, AKASHI Takahiro wrote: +to load dump-capture kernel. + + kexec -p \ + --initrd= \ + --append="root= " For uncompressed Image, dtb is not necessary? Just for clarification, dtb is optional for both

Re: [PATCH] kexec/kdump: Minor Documentation updates for arm64 and Image

2017-05-22 Thread Pratyush Anand
On Monday 22 May 2017 12:19 PM, Bharat Bhushan wrote: On Friday 19 May 2017 09:15 AM, AKASHI Takahiro wrote: +to load dump-capture kernel. + + kexec -p \ + --initrd= \ + --append="root= " For uncompressed Image, dtb is not necessary? Just for clarification, dtb is optional for both

Re: [PATCH] kexec/kdump: Minor Documentation updates for arm64 and Image

2017-05-22 Thread Pratyush Anand
On Friday 19 May 2017 09:15 AM, AKASHI Takahiro wrote: +to load dump-capture kernel. + + kexec -p \ + --initrd= \ + --append="root= " For uncompressed Image, dtb is not necessary? Just for clarification, dtb is optional for both vmlinux and Image on arm64. (This means you can specify

Re: [PATCH] kexec/kdump: Minor Documentation updates for arm64 and Image

2017-05-22 Thread Pratyush Anand
On Friday 19 May 2017 09:15 AM, AKASHI Takahiro wrote: +to load dump-capture kernel. + + kexec -p \ + --initrd= \ + --append="root= " For uncompressed Image, dtb is not necessary? Just for clarification, dtb is optional for both vmlinux and Image on arm64. (This means you can specify

Re: [PATCH 1/2] perf probe: Fix wrong register name for arm64

2017-05-03 Thread Pratyush Anand
Just noticed that this patch fixes commit e47392bf9c06 (v4.8+). So, Ccing sta...@vger.kernel.org [e47392bf9c06 perf uprobe: Skip prologue if program compiled without optimization] After e47392bf9c06 on ARM64: # cat > test.c << EOF > #include > > int main(int argc, void **argv) > { >

Re: [PATCH 1/2] perf probe: Fix wrong register name for arm64

2017-05-03 Thread Pratyush Anand
Just noticed that this patch fixes commit e47392bf9c06 (v4.8+). So, Ccing sta...@vger.kernel.org [e47392bf9c06 perf uprobe: Skip prologue if program compiled without optimization] After e47392bf9c06 on ARM64: # cat > test.c << EOF > #include > > int main(int argc, void **argv) > { >

Re: [trace-cmd Patch RFC] trace-cmd: top: A new interface to detect peak memory

2017-04-27 Thread Pratyush Anand
On Thursday 27 April 2017 10:19 PM, Steven Rostedt wrote: On Thu, 27 Apr 2017 19:32:43 +0530 Pratyush Anand <pan...@redhat.com> wrote: I will implement your review comments and will send next revision. However, I had couple of observation which I was unable to justify: # ./trace-cmd

Re: [trace-cmd Patch RFC] trace-cmd: top: A new interface to detect peak memory

2017-04-27 Thread Pratyush Anand
On Thursday 27 April 2017 10:19 PM, Steven Rostedt wrote: On Thu, 27 Apr 2017 19:32:43 +0530 Pratyush Anand wrote: I will implement your review comments and will send next revision. However, I had couple of observation which I was unable to justify: # ./trace-cmd top -s /tmp/test # ./trace

Re: [trace-cmd Patch RFC] trace-cmd: top: A new interface to detect peak memory

2017-04-27 Thread Pratyush Anand
Hi Steve, On Wednesday 26 April 2017 07:31 PM, Steven Rostedt wrote: Sorry for the late reply. I finally have time to start looking at trace-cmd again. Thanks a lot for your review :-) On Wed, 1 Mar 2017 20:32:37 +0530 Pratyush Anand <pan...@redhat.com> wrote: [...] This is a

Re: [trace-cmd Patch RFC] trace-cmd: top: A new interface to detect peak memory

2017-04-27 Thread Pratyush Anand
Hi Steve, On Wednesday 26 April 2017 07:31 PM, Steven Rostedt wrote: Sorry for the late reply. I finally have time to start looking at trace-cmd again. Thanks a lot for your review :-) On Wed, 1 Mar 2017 20:32:37 +0530 Pratyush Anand wrote: [...] This is as nice idea, but it needs

[trace-cmd Patch RFC] trace-cmd: top: A new interface to detect peak memory

2017-03-01 Thread Pratyush Anand
orkManager 15912 gnome-shell 114292 gnome-shell 186356 firefox 853244 bash5984 thunderbird 1896396 kworker/3:0 0 kworker/u16:1 0 trace-cmd 256 Signed-off-by: Pratyush Anand <pan.

[trace-cmd Patch RFC] trace-cmd: top: A new interface to detect peak memory

2017-03-01 Thread Pratyush Anand
orkManager 15912 gnome-shell 114292 gnome-shell 186356 firefox 853244 bash5984 thunderbird 1896396 kworker/3:0 0 kworker/u16:1 0 trace-cmd 256 Signed-off-by: Pratyush Anand ---

Re: [PATCH] /proc/kcore: Update physical address for kcore ram and text

2017-02-23 Thread Pratyush Anand
Hi Andrew/Kees, On Tuesday 14 February 2017 07:16 AM, Pratyush Anand wrote: Well, CONFIG_PROC_KCORE is a generalized root KASLR exposure (though there are lots of such exposures). Why is the actual physical address needed? Can this just report the virtual address instead? Then the tool can

Re: [PATCH] /proc/kcore: Update physical address for kcore ram and text

2017-02-23 Thread Pratyush Anand
Hi Andrew/Kees, On Tuesday 14 February 2017 07:16 AM, Pratyush Anand wrote: Well, CONFIG_PROC_KCORE is a generalized root KASLR exposure (though there are lots of such exposures). Why is the actual physical address needed? Can this just report the virtual address instead? Then the tool can

Re: [PATCH] /proc/kcore: Update physical address for kcore ram and text

2017-02-13 Thread Pratyush Anand
On Tuesday 14 February 2017 03:55 AM, Kees Cook wrote: On Mon, Jan 30, 2017 at 11:00 AM, Pratyush Anand <pan...@redhat.com> wrote: CCing Andrew and Kees for their review comments. On Wednesday 25 January 2017 10:14 AM, Pratyush Anand wrote: Currently all the p_paddr of PT_LOAD h

Re: [PATCH] /proc/kcore: Update physical address for kcore ram and text

2017-02-13 Thread Pratyush Anand
On Tuesday 14 February 2017 03:55 AM, Kees Cook wrote: On Mon, Jan 30, 2017 at 11:00 AM, Pratyush Anand wrote: CCing Andrew and Kees for their review comments. On Wednesday 25 January 2017 10:14 AM, Pratyush Anand wrote: Currently all the p_paddr of PT_LOAD headers are assigned to 0

Re: [PATCH] /proc/kcore: Update physical address for kcore ram and text

2017-01-24 Thread Pratyush Anand
Hi Dave, On Wednesday 25 January 2017 11:59 AM, Dave Young wrote: Hi Pratyush On 01/25/17 at 10:14am, Pratyush Anand wrote: Currently all the p_paddr of PT_LOAD headers are assigned to 0, which is not true and could be misleading, since 0 is a valid physical address. I do not know the history

Re: [PATCH] /proc/kcore: Update physical address for kcore ram and text

2017-01-24 Thread Pratyush Anand
Hi Dave, On Wednesday 25 January 2017 11:59 AM, Dave Young wrote: Hi Pratyush On 01/25/17 at 10:14am, Pratyush Anand wrote: Currently all the p_paddr of PT_LOAD headers are assigned to 0, which is not true and could be misleading, since 0 is a valid physical address. I do not know the history

[PATCH] /proc/kcore: Update physical address for kcore ram and text

2017-01-24 Thread Pratyush Anand
for such regions. It also sets an invalid paddr (-1) for other regions, so that user space tool can know whether a physical address provided in PT_LOAD is correct or not. Signed-off-by: Pratyush Anand <pan...@redhat.com> --- fs/proc/kcore.c | 5 - 1 file changed, 4 insertions(+), 1 de

[PATCH] /proc/kcore: Update physical address for kcore ram and text

2017-01-24 Thread Pratyush Anand
for such regions. It also sets an invalid paddr (-1) for other regions, so that user space tool can know whether a physical address provided in PT_LOAD is correct or not. Signed-off-by: Pratyush Anand --- fs/proc/kcore.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/proc

[PATCH V3 0/5] ARM64: More flexible HW watchpoint

2016-11-14 Thread Pratyush Anand
corresponding test case to test that functionality. Pavel Labath (1): arm64: hw_breakpoint: Handle inexact watchpoint addresses Pratyush Anand (4): hw_breakpoint: Allow watchpoint of length 3,5,6 and 7 arm64: Allow hw watchpoint at varied offset from base address arm64: Allow hw watchpoint

[PATCH V3 0/5] ARM64: More flexible HW watchpoint

2016-11-14 Thread Pratyush Anand
corresponding test case to test that functionality. Pavel Labath (1): arm64: hw_breakpoint: Handle inexact watchpoint addresses Pratyush Anand (4): hw_breakpoint: Allow watchpoint of length 3,5,6 and 7 arm64: Allow hw watchpoint at varied offset from base address arm64: Allow hw watchpoint

[PATCH V3 5/5] selftests: arm64: add test for unaligned/inexact watchpoint handling

2016-11-14 Thread Pratyush Anand
series and is passing now. Signed-off-by: Pavel Labath <lab...@google.com> Signed-off-by: Pratyush Anand <pan...@redhat.com> --- tools/testing/selftests/breakpoints/Makefile | 5 +- .../selftests/breakpoints/breakpoint_test_arm64.c | 236 + 2 files changed, 24

[PATCH V3 5/5] selftests: arm64: add test for unaligned/inexact watchpoint handling

2016-11-14 Thread Pratyush Anand
series and is passing now. Signed-off-by: Pavel Labath Signed-off-by: Pratyush Anand --- tools/testing/selftests/breakpoints/Makefile | 5 +- .../selftests/breakpoints/breakpoint_test_arm64.c | 236 + 2 files changed, 240 insertions(+), 1 deletion(-) create mode 100644

  1   2   3   4   5   6   7   >