Fixing checkpatch warning to add newline after declaration
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
security/keys/big_key.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/security/keys/big_key.c b/security/keys/big_key.c
index 835c1ab..bc4c6eb 100644
--- a/securit
Fixing checkpatch warning to add newline after declaration
Signed-off-by: Pushkar Jambhlekar
---
security/keys/big_key.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/security/keys/big_key.c b/security/keys/big_key.c
index 835c1ab..bc4c6eb 100644
--- a/security/keys/big_key.c
+++ b
crc32_init is using unnecessary else condition. Cleaningup this function
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_security.c | 42 +--
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/drivers/s
crc32_init is using unnecessary else condition. Cleaningup this function
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/rtl8188eu/core/rtw_security.c | 42 +--
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core
Code can be optimized more by making single exit point of function and calling
mutex_unlock at the end
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/iommu/tegra-smmu.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/iommu/tegra-
Code can be optimized more by making single exit point of function and calling
mutex_unlock at the end
Signed-off-by: Pushkar Jambhlekar
---
drivers/iommu/tegra-smmu.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra
Fix brace style of if-else case
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/staging/pi433/pi433_if.c | 162 +--
1 file changed, 54 insertions(+), 108 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging
Fix brace style of if-else case
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/pi433/pi433_if.c | 162 +--
1 file changed, 54 insertions(+), 108 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index
checkpath reports error for declaring the way code is handling pointer. Fixing
those errors
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
mm/highmem.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/highmem.c b/mm/highmem.c
index 50b4ca6..2
checkpath reports error for declaring the way code is handling pointer. Fixing
those errors
Signed-off-by: Pushkar Jambhlekar
---
mm/highmem.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/highmem.c b/mm/highmem.c
index 50b4ca6..20ffba3 100644
--- a/mm/highmem.c
Adding newline after declaration to follow coding guideline
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
mm/cleancache.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/cleancache.c b/mm/cleancache.c
index f7b9fdc..051c5d0 100644
--- a/mm/cleancache.c
++
Adding newline after declaration to follow coding guideline
Signed-off-by: Pushkar Jambhlekar
---
mm/cleancache.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/cleancache.c b/mm/cleancache.c
index f7b9fdc..051c5d0 100644
--- a/mm/cleancache.c
+++ b/mm/cleancache.c
@@ -305,6 +305,7
Function name is hardcoded. replacing with __func__
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/staging/media/cxd2099/cxd2099.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/cxd2099/cxd2099.c
b/drivers/staging
Function name is hardcoded. replacing with __func__
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/media/cxd2099/cxd2099.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/cxd2099/cxd2099.c
b/drivers/staging/media/cxd2099/cxd2099.c
index
Fixing 'checkpatch.pl' ERROR: code indent should use tabs where possible
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/staging/ccree/ssi_aead.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging
Fixing 'checkpatch.pl' ERROR: code indent should use tabs where possible
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/ccree/ssi_aead.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers
Fixing coding guideline errors reported by 'checkpatch.pl'
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/staging/ccree/ssi_cipher.c | 158 +++--
1 file changed, 80 insertions(+), 78 deletions(-)
diff --git a/drivers/staging
Fixing coding guideline errors reported by 'checkpatch.pl'
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/ccree/ssi_cipher.c | 158 +++--
1 file changed, 80 insertions(+), 78 deletions(-)
diff --git a/drivers/staging/ccree/ssi_cipher.c
b/drivers/staging
Fixing 'checkpatch.pl' warnings: Trailing whitespaces
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/staging/ccree/ssi_cipher.c | 110 ++---
1 file changed, 55 insertions(+), 55 deletions(-)
diff --git a/drivers/staging/ccree/ssi_ci
Fixing 'checkpatch.pl' warnings: Trailing whitespaces
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/ccree/ssi_cipher.c | 110 ++---
1 file changed, 55 insertions(+), 55 deletions(-)
diff --git a/drivers/staging/ccree/ssi_cipher.c
b/drivers/staging/ccree
, Joe Perches <j...@perches.com> wrote:
> On Thu, 2017-05-11 at 10:13 +0530, Pushkar Jambhlekar wrote:
>> Should I change my implementation, i.e. remove '!!'?
>
> That'd be up to Al.
>
> At least one implementation using similar bit comparisons
> in fs/*.c does not use
, Joe Perches wrote:
> On Thu, 2017-05-11 at 10:13 +0530, Pushkar Jambhlekar wrote:
>> Should I change my implementation, i.e. remove '!!'?
>
> That'd be up to Al.
>
> At least one implementation using similar bit comparisons
> in fs/*.c does not use !!
>
> fs/locks.c:sta
Fixing sparse warnings: 'symbol not declared. Should it be static?' Variables
need to be
static since they have not used outside of the files.
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
kernel/power/snapshot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Fixing sparse warnings: 'symbol not declared. Should it be static?' Variables
need to be
static since they have not used outside of the files.
Signed-off-by: Pushkar Jambhlekar
---
kernel/power/snapshot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/power
Should I change my implementation, i.e. remove '!!'?
On Thu, May 11, 2017 at 10:09 AM, Joe Perches <j...@perches.com> wrote:
> On Thu, 2017-05-11 at 09:57 +0530, Pushkar Jambhlekar wrote:
>> Fixing Sparse warning. It should return bool, instead it returns
>> int.
&g
Should I change my implementation, i.e. remove '!!'?
On Thu, May 11, 2017 at 10:09 AM, Joe Perches wrote:
> On Thu, 2017-05-11 at 09:57 +0530, Pushkar Jambhlekar wrote:
>> Fixing Sparse warning. It should return bool, instead it returns
>> int.
> []
>> diff --gi
Fixing Sparse warning. It should return bool, instead it returns
int.
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
fs/read_write.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/read_write.c b/fs/read_write.c
index 47c1d44..d672830 100644
--
Fixing Sparse warning. It should return bool, instead it returns
int.
Signed-off-by: Pushkar Jambhlekar
---
fs/read_write.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/read_write.c b/fs/read_write.c
index 47c1d44..d672830 100644
--- a/fs/read_write.c
+++ b/fs
unsigned_offsets function returns fmode_t but function definition returns int.
sparse generate warning.
Updating proper return type
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
fs/read_write.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/read_wri
unsigned_offsets function returns fmode_t but function definition returns int.
sparse generate warning.
Updating proper return type
Signed-off-by: Pushkar Jambhlekar
---
fs/read_write.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/read_write.c b/fs/read_write.c
index
This change is to handle sparse warning. Return type of function is a pointer
to the structure and
it returns 0. Instead it should return NULL.
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/crypto/ccp/ccp-platform.c | 4 ++--
1 file changed, 2 insertions(+), 2 del
This change is to handle sparse warning. Return type of function is a pointer
to the structure and
it returns 0. Instead it should return NULL.
Signed-off-by: Pushkar Jambhlekar
---
drivers/crypto/ccp/ccp-platform.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Thanks Dan!
On Tue, Apr 11, 2017 at 9:47 PM, Dan Williams <dan.j.willi...@intel.com> wrote:
> On Mon, Apr 10, 2017 at 10:26 PM, Pushkar Jambhlekar
> <pushkar@gmail.com> wrote:
>> dax_dev_huge_fault returning without releasing lock. Making code change to
>> avo
Thanks Dan!
On Tue, Apr 11, 2017 at 9:47 PM, Dan Williams wrote:
> On Mon, Apr 10, 2017 at 10:26 PM, Pushkar Jambhlekar
> wrote:
>> dax_dev_huge_fault returning without releasing lock. Making code change to
>> avoid this situation
>>
>> Signed-off-by: Pushkar Jamb
Sent out another patch to correct return value.
On Tue, Apr 11, 2017 at 10:25 AM, Dan Williams <dan.j.willi...@intel.com> wrote:
> On Mon, Apr 10, 2017 at 9:45 PM, Pushkar Jambhlekar
> <pushkar@gmail.com> wrote:
>> dax_dev_huge_fault returning without releasing
Sent out another patch to correct return value.
On Tue, Apr 11, 2017 at 10:25 AM, Dan Williams wrote:
> On Mon, Apr 10, 2017 at 9:45 PM, Pushkar Jambhlekar
> wrote:
>> dax_dev_huge_fault returning without releasing lock. Making code change to
>> avoid this situatio
Changing rc value from VM_FAULT_FALLBACK to VM_FAULT_SIGBUS for an unknown /
unsupported fault size.
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/dax/dax.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
Changing rc value from VM_FAULT_FALLBACK to VM_FAULT_SIGBUS for an unknown /
unsupported fault size.
Signed-off-by: Pushkar Jambhlekar
---
drivers/dax/dax.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
index fd9c4db..6156fdc 100644
dax_dev_huge_fault returning without releasing lock. Making code change to
avoid this situation
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/dax/dax.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
index 0
dax_dev_huge_fault returning without releasing lock. Making code change to
avoid this situation
Signed-off-by: Pushkar Jambhlekar
---
drivers/dax/dax.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
index 0d1ca24..fd9c4db 100644
Changing rc value from VM_FAULT_FALLBACK to VM_FAULT_SIGBUS for an unknown /
unsupported fault size.
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/dax/dax.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
dax_dev_huge_fault returning without releasing lock. Making code change to
avoid this situation
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/dax/dax.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
index 0
Changing rc value from VM_FAULT_FALLBACK to VM_FAULT_SIGBUS for an unknown /
unsupported fault size.
Signed-off-by: Pushkar Jambhlekar
---
drivers/dax/dax.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
index fd9c4db..6156fdc 100644
dax_dev_huge_fault returning without releasing lock. Making code change to
avoid this situation
Signed-off-by: Pushkar Jambhlekar
---
drivers/dax/dax.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
index 0d1ca24..fd9c4db 100644
dax_dev_huge_fault returning without releasing lock. Making code change to
avoid this situation
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/dax/dax.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
index 0
dax_dev_huge_fault returning without releasing lock. Making code change to
avoid this situation
Signed-off-by: Pushkar Jambhlekar
---
drivers/dax/dax.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
index 0d1ca24..fd9c4db 100644
dax_dev_huge_fault returning without releasing lock. Making code change to
avoid this situation
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/dax/dax.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
index 0
dax_dev_huge_fault returning without releasing lock. Making code change to
avoid this situation
Signed-off-by: Pushkar Jambhlekar
---
drivers/dax/dax.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
index 0d1ca24..fd9c4db 100644
Handling checkpatch.pl warning for if block. For single if statement block,
braces are not neccessary. Making code consistent with linux kernel coding
guidelines.
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/staging/iio/accel/adis16203.c | 4 ++--
1 file chan
Handling checkpatch.pl warning for if block. For single if statement block,
braces are not neccessary. Making code consistent with linux kernel coding
guidelines.
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/iio/accel/adis16203.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
((void)sizeof !!(exp)) => I believe it is for compiler to unflag
"unused variable" warning.
On Tue, Apr 4, 2017 at 3:08 PM, Dan Carpenter <dan.carpen...@oracle.com> wrote:
> On Tue, Apr 04, 2017 at 02:45:26PM +0530, Pushkar Jambhlekar wrote:
>> diff --git a/drivers/st
((void)sizeof !!(exp)) => I believe it is for compiler to unflag
"unused variable" warning.
On Tue, Apr 4, 2017 at 3:08 PM, Dan Carpenter wrote:
> On Tue, Apr 04, 2017 at 02:45:26PM +0530, Pushkar Jambhlekar wrote:
>> diff --git a/drivers/staging/lustre/lustre/obdclass/c
Replacing 'unsigned' with 'unsigned int'
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/staging/lustre/lustre/llite/namei.c | 2 +-
drivers/staging/lustre/lustre/llite/rw26.c | 2 +-
drivers/staging/lustre/lustre/llite/vvp_dev.c
Replacing 'unsigned' with 'unsigned int'
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/lustre/lustre/llite/namei.c | 2 +-
drivers/staging/lustre/lustre/llite/rw26.c | 2 +-
drivers/staging/lustre/lustre/llite/vvp_dev.c | 6 +++---
drivers/staging
Making references in single line
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 3 +--
drivers/staging/lustre/lustre/llite/llite_lib.c | 6 ++
drivers/staging/lustre/lustre/mgc/mgc_request.c | 3 +--
drivers/s
Making references in single line
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 3 +--
drivers/staging/lustre/lustre/llite/llite_lib.c | 6 ++
drivers/staging/lustre/lustre/mgc/mgc_request.c | 3 +--
drivers/staging/lustre/lustre/ptlrpc
Adding a blank line after declaration
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/staging/lustre/lustre/llite/dcache.c | 1 +
drivers/staging/lustre/lustre/llite/namei.c | 1 +
drivers/staging/lustre/lustre/llite/symlink.c| 1 +
drivers/staging/
Adding a blank line after declaration
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/lustre/lustre/llite/dcache.c | 1 +
drivers/staging/lustre/lustre/llite/namei.c | 1 +
drivers/staging/lustre/lustre/llite/symlink.c| 1 +
drivers/staging/lustre/lustre/llite/vvp_io.c
ftrace can be used to trace functions. Removing function tracing using
dev_dbg/info
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/staging/wilc1000/wilc_sdio.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_sdio.c
b/drivers/s
ftrace can be used to trace functions. Removing function tracing using
dev_dbg/info
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/wilc1000/wilc_sdio.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_sdio.c
b/drivers/staging/wilc1000/wilc_sdio.c
dev_err: replacing hardcoded function name with '%s' and __func__
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/staging/wilc1000/wilc_sdio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_sdio.c
b/drivers/s
dev_err: replacing hardcoded function name with '%s' and __func__
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/wilc1000/wilc_sdio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_sdio.c
b/drivers/staging/wilc1000/wilc_sdio.c
index
Function definition argument should have identifier name.
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
include/linux/migrate.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/linux/migrate.h b/include/linux/migrate.h
index fa76b51..48e2484
Function definition argument should have identifier name.
Signed-off-by: Pushkar Jambhlekar
---
include/linux/migrate.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/linux/migrate.h b/include/linux/migrate.h
index fa76b51..48e2484 100644
--- a/include/linux
Removing hardcoded function name as code is already using __func__
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/at
Removing hardcoded function name as code is already using __func__
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
b/drivers
Fixing coding guidelines error reported by 'checkpatch.pl'
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/video/fbdev/acornfb.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/video/fbdev/acornfb.c b/drivers/video/fbdev/aco
Fixing coding guidelines error reported by 'checkpatch.pl'
Signed-off-by: Pushkar Jambhlekar
---
drivers/video/fbdev/acornfb.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/video/fbdev/acornfb.c b/drivers/video/fbdev/acornfb.c
index fb75b7e..0c325b4
dev_err: replacing function name with '%s' and __func__
dev_dbg: Removing calls which are used for tracing a function.
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/staging/wilc1000/wilc_sdio.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff
dev_err: replacing function name with '%s' and __func__
dev_dbg: Removing calls which are used for tracing a function.
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/wilc1000/wilc_sdio.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000
Current implementation manually traces function using 'dev_dbg'. This way is
not needed because of ftrace, making these calls redundant.
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/staging/dgnc/dgnc_tty.c | 4
1 file changed, 4 deletions(-)
diff --git a/d
Current implementation manually traces function using 'dev_dbg'. This way is
not needed because of ftrace, making these calls redundant.
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/dgnc/dgnc_tty.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c
Making use of __func__ instead of using function name directly in dev_dbg.
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/staging/dgnc/dgnc_tty.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/stagin
Making use of __func__ instead of using function name directly in dev_dbg.
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/dgnc/dgnc_tty.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index
Any comment?
On Wed, Mar 15, 2017 at 12:01 PM, Pushkar Jambhlekar
<pushkar@gmail.com> wrote:
> Fixing 'if' block coding style. '{' should follow 'if' for multiline block
>
> Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
> ---
> drivers/staging/vc04_s
Any comment?
On Wed, Mar 15, 2017 at 12:01 PM, Pushkar Jambhlekar
wrote:
> Fixing 'if' block coding style. '{' should follow 'if' for multiline block
>
> Signed-off-by: Pushkar Jambhlekar
> ---
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 3 +--
>
Fixing 'if' block coding style. '{' should follow 'if' for multiline block
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/s
Fixing 'if' block coding style. '{' should follow 'if' for multiline block
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm
Thanks. I will rewrite patch according to the suggestions.
On Tue, Mar 14, 2017 at 9:52 PM, Greg Kroah-Hartman
<gre...@linuxfoundation.org> wrote:
> On Tue, Mar 14, 2017 at 06:39:04PM +0530, Pushkar Jambhlekar wrote:
>> Description:
>
> No need for that line.
>
>&
Thanks. I will rewrite patch according to the suggestions.
On Tue, Mar 14, 2017 at 9:52 PM, Greg Kroah-Hartman
wrote:
> On Tue, Mar 14, 2017 at 06:39:04PM +0530, Pushkar Jambhlekar wrote:
>> Description:
>
> No need for that line.
>
>> in file 'vc04_services/interfac
Description:
in file 'vc04_services/interface/vchiq_arm/vchiq_shim.c', making changes to
make code according to 'checkpath.pl'.
Also, fixing logical issue, i.e. removing break after goto statement.
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
.../vc04_services/int
Description:
in file 'vc04_services/interface/vchiq_arm/vchiq_shim.c', making changes to
make code according to 'checkpath.pl'.
Also, fixing logical issue, i.e. removing break after goto statement.
Signed-off-by: Pushkar Jambhlekar
---
.../vc04_services/interface/vchiq_arm/vchiq_shim.c
Your concerns were valid. Since 'do' is defined on the new-line, git
did not include it in diff.
On Tue, Mar 14, 2017 at 5:22 PM, Alexander Kapshuk
<alexander.kaps...@gmail.com> wrote:
> On Tue, Mar 14, 2017 at 1:44 PM, Pushkar Jambhlekar
> <pushkar@gmail.com> wrot
Your concerns were valid. Since 'do' is defined on the new-line, git
did not include it in diff.
On Tue, Mar 14, 2017 at 5:22 PM, Alexander Kapshuk
wrote:
> On Tue, Mar 14, 2017 at 1:44 PM, Pushkar Jambhlekar
> wrote:
>> Hi Alexander,
>>
>> It is not needed for a
) ^ TE1(s##0) ^ TE2(s##1) ^ TE3(s##2) ^ rk[4 * i + 3]; \
} while (0)
On Tue, Mar 14, 2017 at 5:02 PM, Alexander Kapshuk
<alexander.kaps...@gmail.com> wrote:
> On Tue, Mar 14, 2017 at 1:26 PM, Pushkar Jambhlekar
> <pushkar@gmail.com> wrote:
>> Description:
>> Th
) ^ TE1(s##0) ^ TE2(s##1) ^ TE3(s##2) ^ rk[4 * i + 3]; \
} while (0)
On Tue, Mar 14, 2017 at 5:02 PM, Alexander Kapshuk
wrote:
> On Tue, Mar 14, 2017 at 1:26 PM, Pushkar Jambhlekar
> wrote:
>> Description:
>> There should not be ';' after do ... while(0) in macro definatio
Description:
There should not be ';' after do ... while(0) in macro defination
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_security.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188e
Description:
There should not be ';' after do ... while(0) in macro defination
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/rtl8188eu/core/rtw_security.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c
b/drivers
Hi Dan,
I am trying to fix warnings by "checkpatch.pl". Even though it is not
super exciting, no harm to follow correct way.
On Tue, Mar 14, 2017 at 2:43 AM, Dan Carpenter <dan.carpen...@oracle.com> wrote:
> On Tue, Mar 14, 2017 at 11:12:42AM +0530, Pushkar Jambhlekar wr
Hi Dan,
I am trying to fix warnings by "checkpatch.pl". Even though it is not
super exciting, no harm to follow correct way.
On Tue, Mar 14, 2017 at 2:43 AM, Dan Carpenter wrote:
> On Tue, Mar 14, 2017 at 11:12:42AM +0530, Pushkar Jambhlekar wrote:
>> Description:
>>
Description:
In driver module ks7010, "checkpatch.pl" flags error for adding parenthesis
around macro params.
Also, removing extra line.
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/staging/ks7010/ks7010_sdio.c | 13 ++---
1 file changed, 6
Description:
In driver module ks7010, "checkpatch.pl" flags error for adding parenthesis
around macro params.
Also, removing extra line.
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/ks7010/ks7010_sdio.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
Replacing 'unsigned' with 'unsigned int' in vvp_pgcache_id.
Checkpath.pl passed.
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/staging/lustre/lustre/llite/vvp_dev.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/lustre/
Replacing 'unsigned' with 'unsigned int' in vvp_pgcache_id.
Checkpath.pl passed.
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/lustre/lustre/llite/vvp_dev.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/vvp_dev.c
b
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com>
---
drivers/staging/lustre/lustre/llite/vvp_dev.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/vvp_dev.c
b/drivers/staging/lustre/lustre/llite/vvp_dev.c
index 12c
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/lustre/lustre/llite/vvp_dev.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/vvp_dev.c
b/drivers/staging/lustre/lustre/llite/vvp_dev.c
index 12c129f7e..8d78755 100644
96 matches
Mail list logo
