threshold, and 1 means smaller.
Signed-off-by: Qi Liu
---
MAINTAINERS|6 +
drivers/perf/Kconfig |2 +
drivers/perf/Makefile |1 +
drivers/perf/pci/Kconfig | 16 +
drivers/perf/pci
PCIe PMU Root Complex Integrated End Point(RCiEP) device is supported on
HiSilicon HIP09 platform. Document it to provide guidance on how to
use it.
Signed-off-by: Qi Liu
---
Documentation/admin-guide/perf/hisi-pcie-pmu.rst | 104 +++
1 file changed, 104 insertions
the internal Reviewed-by tag.
- Fix some build warnings when W=1.
- Link:
https://lore.kernel.org/linux-arm-kernel/1617788943-52722-1-git-send-email-liuqi...@huawei.com/
Qi Liu (2):
docs: perf: Add description for HiSilicon PCIe PMU driver
drivers/perf: hisi: Add driver for HiSilicon PCIe PMU
threshold, and 1 means smaller.
Signed-off-by: Qi Liu
---
MAINTAINERS|6 +
drivers/perf/Kconfig |2 +
drivers/perf/Makefile |1 +
drivers/perf/pci/Kconfig | 16 +
drivers/perf/pci
PCIe PMU Root Complex Integrated End Point(RCiEP) device is supported on
HiSilicon HIP09 platform. Document it to provide guidance on how to
use it.
Signed-off-by: Qi Liu
---
Documentation/admin-guide/perf/hisi-pcie-pmu.rst | 104 +++
1 file changed, 104 insertions
to collect performance data of PCIe bus,
such as: bandwidth, latency etc.
Changes since v1:
- Drop the internal Reviewed-by tag.
- Fix some build warnings when W=1.
Qi Liu (2):
drivers/perf: hisi: Add driver for HiSilicon PCIe PMU
docs: perf: Add description for HiSilicon PCIe PMU driver
to collect performance data of PCIe bus,
such as: bandwidth, latency etc.
Qi Liu (2):
drivers/perf: hisi: Add driver for HiSilicon PCIe PMU
docs: perf: Add description for HiSilicon PCIe PMU driver
Documentation/admin-guide/perf/hisi-pcie-pmu.rst | 103 +++
MAINTAINERS
threshold, and 1 means smaller.
Reviewed-by: Jonathan Cameron
Signed-off-by: Qi Liu
---
MAINTAINERS|6 +
drivers/perf/Kconfig |2 +
drivers/perf/Makefile |1 +
drivers/perf/pci/Kconfig
PCIe PMU Root Complex Integrated End Point(RCiEP) device is supported on
HiSilicon HIP09 platform, and document it to provide guidance on how to
use it.
Reviewed-by: John Garry
Signed-off-by: Qi Liu
---
Documentation/admin-guide/perf/hisi-pcie-pmu.rst | 103 +++
1 file
Remove duplicate check of pasids in amd_iommu_domain_enable_v2(), as it
has been guaranteed in amd_iommu_init_device().
Signed-off-by: Qi Liu
---
drivers/iommu/amd/iommu.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
index 107316e
The initialization of value in function armv8pmu_read_hw_counter()
and armv8pmu_read_counter() seem redundant, as they are soon updated.
So, We can remove them.
Signed-off-by: Qi Liu
---
arch/arm64/kernel/perf_event.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch
U
v2")
Reported-by: Stephen Rothwell
Signed-off-by: Qi Liu
---
Documentation/admin-guide/perf/hisi-pmu.rst | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/Documentation/admin-guide/perf/hisi-pmu.rst
b/Documentation/admin-guide/perf/hisi-pmu.rst
index 3b3120
Fix the following checkpatch warning:
WARNING: 'compoment' may be misspelled - perhaps 'component'?
Fixes: 8e264c52e1da ("coresight: core: Allow the coresight core driver to be
built as a module")
Signed-off-by: Qi Liu
---
drivers/hwtracing/coresight/coresight-core.c | 2 +-
1 file
Fix up one typo: compoment->component.
Fixes: 8e264c52e1da ("coresight: core: Allow the coresight core driver to be
built as a module")
Signed-off-by: Qi Liu
---
drivers/hwtracing/coresight/coresight-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driv
:528:8-16: WARNING: use scnprintf or sprintf.
./drivers/perf/arm-cci.c:309:8-16: WARNING: use scnprintf or sprintf.
Signed-off-by: Zihao Tang
Signed-off-by: Qi Liu
---
drivers/perf/arm-cci.c | 12 ++--
drivers/perf/arm-ccn.c | 4 ++--
drivers/perf/arm
Use the generic sysfs_emit() and sysfs_emit_at() function to take
place of sprintf/snprintf/scnprintf, to avoid buffer overrun.
Qi Liu (2):
drivers/perf: convert sysfs scnprintf family to sysfs_emit_at() and
sysfs_emit()
drivers/perf: convert sysfs sprintf family to sysfs_emit
Zihao Tang (1
Use the generic sysfs_emit_at() and sysfs_emit() function to take place
of scnprintf()
Signed-off-by: Qi Liu
---
drivers/perf/arm-ccn.c | 27 +++
1 file changed, 11 insertions(+), 16 deletions(-)
diff --git a/drivers/perf/arm-ccn.c b/drivers/perf/arm-ccn.c
index 3a2ddc0
sprintf does not know the PAGE_SIZE maximum of the temporary buffer
used for sysfs content and it's possible to overrun the buffer length.
Use sysfs_emit() function to ensures that no overrun is done.
Signed-off-by: Qi Liu
---
drivers/perf/arm_dmc620_pmu.c| 2 +-
drivers/perf
sprintf does not know the PAGE_SIZE maximum of the temporary buffer
used for sysfs content and it's possible to overrun the buffer length.
Use sysfs_emit() function to ensures that no overrun is done.
Signed-off-by: Qi Liu
---
drivers/perf/arm_dmc620_pmu.c| 2 +-
drivers/perf
:528:8-16: WARNING: use scnprintf or sprintf.
./drivers/perf/arm-cci.c:309:8-16: WARNING: use scnprintf or sprintf.
Signed-off-by: Zihao Tang
Signed-off-by: Qi Liu
---
drivers/perf/arm-cci.c | 12 ++--
drivers/perf/arm-ccn.c | 4 ++--
drivers/perf/arm
Use the generic sysfs_emit() and sysfs_emit_at() function to take
place of sprintf/snprintf/scnprintf, to avoid buffer overrun.
Zihao Tang (1)
drivers/perf: convert sysfs snprintf family to sysfs_emit
Qi Liu (2):
drivers/perf: convert sysfs scnprintf family to sysfs_emit_at
drivers/perf
Use the generic sysfs_emit_at() function take place of scnprintf()
Signed-off-by: Qi Liu
---
drivers/perf/arm-ccn.c | 24 ++--
1 file changed, 10 insertions(+), 14 deletions(-)
diff --git a/drivers/perf/arm-ccn.c b/drivers/perf/arm-ccn.c
index 3a2ddc0..0588f29 100644
There is no need to do spin_lock_irqsave in context of hard IRQ, so
replace them with spin_lock.
Signed-off-by: Qi Liu
---
drivers/perf/arm-cci.c | 5 ++---
drivers/perf/xgene_pmu.c | 5 ++---
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/perf/arm-cci.c b/drivers/perf
For each PMU event, there is a SMMU_EVENT_ATTR(xx, XX) and
_event_attr_xx.attr.attr. Let's redefine the SMMU_EVENT_ATTR
to simplify the smmu_pmu_events.
Signed-off-by: Qi Liu
---
drivers/perf/arm_smmuv3_pmu.c | 32 +---
1 file changed, 13 insertions(+), 19 deletions
Set "suppress_bind_attrs" to true, so that bind/unbind can be
disabled via sysfs and prevent unbinding ARM_DMC620_PMU drivers
during perf sampling.
Signed-off-by: Qi Liu
---
drivers/perf/arm_dmc620_pmu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/perf/arm_dmc620_pmu.c
Remove duplicate included header files, as coresight-priv.h is included in
these coresight drivers.
Signed-off-by: Qi Liu
---
drivers/hwtracing/coresight/coresight-catu.c | 2 --
drivers/hwtracing/coresight/coresight-core.c | 3 ---
drivers/hwtracing/coresight/coresight-cpu
to avoid ETM
overflow.
Reviewed-by: Suzuki K Poulose
Signed-off-by: Qi Liu
---
Change since v1:
- add CONFIG_ETM4X_IMPDEF_FEATURE and CONFIG_ETM4X_IMPDEF_HISILICON
to keep specific feature off platforms which don't use it.
Change since v2:
- remove some unused variable.
Change since v3:
- use
On 2020/12/7 19:27, Suzuki K Poulose wrote:
> On 12/7/20 11:21 AM, Qi Liu wrote:
>>
>> Hi Suzuki,
>> On 2020/12/7 18:38, Suzuki K Poulose wrote:
>>> On 12/7/20 2:08 AM, Qi Liu wrote:
>>>> Hi Mathieu,
>>>>
>>>> On 2020/12/5 2:5
Hi Suzuki,
On 2020/12/7 18:38, Suzuki K Poulose wrote:
> On 12/7/20 2:08 AM, Qi Liu wrote:
>> Hi Mathieu,
>>
>> On 2020/12/5 2:55, Mathieu Poirier wrote:
>>> On Thu, Nov 26, 2020 at 09:34:30PM +0800, Qi Liu wrote:
>>>> The ETM device can't ke
Hi Mathieu,
On 2020/12/5 2:55, Mathieu Poirier wrote:
> On Thu, Nov 26, 2020 at 09:34:30PM +0800, Qi Liu wrote:
>> The ETM device can't keep up with the core pipeline when cpu core
>> is at full speed. This may cause overflow within core and its ETM.
>> This is a common phen
On 2020/11/23 22:12, Suzuki K Poulose wrote:
> Hi Qi
>
> Thanks for the changes. Mostly looks good to me, except for the
> name of the call back.
>
>
Hi Suzuki,
ok, I'll send a new patch to change the name of call back.
Thanks
Qi
> On 11/23/20 1:29 PM, Qi Liu wrote:
&g
to avoid ETM
overflow.
Signed-off-by: Qi Liu
---
Change since v1:
- add CONFIG_ETM4X_IMPDEF_FEATURE and CONFIG_ETM4X_IMPDEF_HISILICON
to keep specific feature off platforms which don't use it.
Change since v2:
- remove some unused variable.
Change since v3:
- use read/write_sysreg_s() to access
to avoid ETM
overflow.
Signed-off-by: Qi Liu
---
Change since v1:
- add CONFIG_ETM4X_IMPDEF_FEATURE and CONFIG_ETM4X_IMPDEF_HISILICON
to keep specific feature off platforms which don't use it.
Change since v2:
- remove some unused variable.
Change since v3:
- use read/write_sysreg_s() to access
On 2020/11/12 22:03, Suzuki K Poulose wrote:
> On 11/12/20 1:09 PM, Qi Liu wrote:
>>
>>
>> On 2020/11/12 1:03, Mathieu Poirier wrote:
>>> On Wed, Nov 11, 2020 at 04:58:23PM +0800, Qi Liu wrote:
>>>> Hi Mathieu,
>>>>
>>>> On 2020/
On 2020/11/12 1:03, Mathieu Poirier wrote:
> On Wed, Nov 11, 2020 at 04:58:23PM +0800, Qi Liu wrote:
>> Hi Mathieu,
>>
>> On 2020/9/10 0:26, Mathieu Poirier wrote:
>>> On Wed, Sep 09, 2020 at 12:30:02PM +0100, Mike Leach wrote:
>>>> Hi,
>>>&
As THIS_MODULE has been set in platform_driver_register(), so remove it
from static funnel driver and static replicator driver to avoid set it
twice.
Signed-off-by: Qi Liu
---
drivers/hwtracing/coresight/coresight-funnel.c | 2 +-
drivers/hwtracing/coresight/coresight-replicator.c | 2 +-
2
Hi Mathieu,
On 2020/11/3 1:23, Mathieu Poirier wrote:
> Hi Liu,
>
> On Sat, Oct 31, 2020 at 06:12:30PM +0800, Qi Liu wrote:
>> As driver.owner has been set in platform_driver_register(), it is
>> unnecessary to set it in static funnel driver, so remove it from
>>
As driver.owner has been set in platform_driver_register(), it is
unnecessary to set it in static funnel driver, so remove it from
struct static_funnel_driver.
Signed-off-by: Qi Liu
---
drivers/hwtracing/coresight/coresight-funnel.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers
As driver.owner has been set in platform_driver_register(), it is
unnecessary to set it in static funnel driver, so remove it from
struct static_funnel_driver.
Signed-off-by: Qi Liu
---
drivers/hwtracing/coresight/coresight-funnel.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers
Hi Suzuki,
On 2020/10/23 18:40, Suzuki Poulose wrote:
> On 10/23/20 11:23 AM, Qi Liu wrote:
>> The ETM device can't keep up with the core pipeline when cpu core
>> is at full speed. This may cause overflow within core and its ETM.
>> This is a common phenomenon on ETM device
to avoid ETM
overflow.
Signed-off-by: Qi Liu
---
Change since v1:
- add CONFIG_ETM4X_IMPDEF_FEATURE and CONFIG_ETM4X_IMPDEF_HISILICON
to keep specific feature off platforms which don't use it.
Change since v2:
- remove some unused variable.
drivers/hwtracing/coresight/Kconfig| 18
Fix up typo in function hisi_ddrc_pmu_write_evtype(), and the whitespace
in function hisi_ddrc_pmu_module_exit()
Signed-off-by: Qi Liu
---
drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/perf/hisilicon
to avoid ETM
overflow.
Signed-off-by: Qi Liu
---
Change since v1:
- add CONFIG_ETM4X_IMPDEF_FEATURE and CONFIG_ETM4X_IMPDEF_HISILICON
to keep specific feature off platforms which don't use it.
drivers/hwtracing/coresight/Kconfig | 13 ++
drivers/hwtracing/coresight/coresight
he accesses" seems better.
The comments of L1-icache, dTLB cache, iTLB cache and LL-cache are
fixed in the same way.
Signed-off-by: Qi Liu
Reviewed-by: Andi Kleen
---
tools/perf/util/stat-shadow.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/tools/p
Variable zone is unused in function madvise_inject_error, let's remove it.
Signed-off-by: Qi Liu
---
mm/madvise.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/madvise.c b/mm/madvise.c
index 460e19d..94b9d17 100644
--- a/mm/madvise.c
+++ b/mm/madvise.c
@@ -879,7 +879,6 @@ static long
When there is no output port, coresight_alloc_conns() still do the following
copy connection information to pdata->conns, and this may cause kernel panic.
Let's fix it.
Signed-off-by: Qi Liu
---
drivers/hwtracing/coresight/coresight-platform.c | 13 +++--
1 file changed, 7 inserti
event_idx is obtained from armv8pmu_get_event_idx(), and this idx must be
between ARMV8_IDX_CYCLE_COUNTER and cpu_pmu->num_events. So it's unnecessary
to do this check. Let's remove it.
Signed-off-by: Qi Liu
---
arch/arm64/kernel/perf_event.c | 20 ++--
1 file changed
to avoid ETM
overflow.
Signed-off-by: Qi Liu
---
link of the RFC patch:
https://lore.kernel.org/linux-arm-kernel/1597824397-29894-1-git-send-email-liuqi...@huawei.com/
drivers/hwtracing/coresight/coresight-etm4x.c | 46 +++
1 file changed, 46 insertions(+)
diff --git
Hi Mathieu,
Thanks for your review.
On 2020/9/1 6:13, Mathieu Poirier wrote:
> Following Al's comment I have the following recommendations...
>
> On Wed, Aug 19, 2020 at 04:06:37PM +0800, Qi Liu wrote:
>> When too much trace information is generated on-chip, the ETM will
>>
Hi Al,
On 2020/8/28 17:00, Al Grant wrote:
> Hi Mathieu and CS maintainers,
>
>> Hi Liu,
>>
>> On Wed, Aug 19, 2020 at 04:06:37PM +0800, Qi Liu wrote:
>>> When too much trace information is generated on-chip, the ETM will
>>> overflow, and cause dat
of ETM.
Signed-off-by: Qi Liu
---
Changes since v1:
- ETM on HiSilicon Hip09 platform supports backpressure, so does
not need to modify core commit.
drivers/hwtracing/coresight/coresight-etm4x.c | 43 +++
1 file changed, 43 insertions(+)
diff --git a/drivers/hwtracing
Add ETMv4 periperhal ID for HiSilicon Hip08 and Hip09 platform. Hip08
contains ETMv4.2 device and Hip09 contains ETMv4.5 device.
Signed-off-by: Qi Liu
---
drivers/hwtracing/coresight/coresight-etm4x.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hwtracing/coresight/coresight
Hi Suzuki,
Thanks for your review.
On 2020/8/4 18:47, Suzuki K Poulose wrote:
> Hi Qi
>
> On 08/03/2020 02:35 PM, Qi Liu wrote:
>> Add ETMv4 periperhal ID for HiSilicon Hip08 and Hip09 platform. Hip08
>> contains ETMv4.2 device and Hip09 contains ETMv4.5 device.
>
&g
the overflow of ETM.
Signed-off-by: Qi Liu
---
drivers/hwtracing/coresight/coresight-etm4x.c | 46 +++
1 file changed, 46 insertions(+)
diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c
b/drivers/hwtracing/coresight/coresight-etm4x.c
index 4a4f0bd..ca9fb11 100644
Add ETMv4 periperhal ID for HiSilicon Hip08 and Hip09 platform. Hip08
contains ETMv4.2 device and Hip09 contains ETMv4.5 device.
Signed-off-by: Qi Liu
---
drivers/hwtracing/coresight/coresight-etm4x.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hwtracing/coresight/coresight
unbinding PMU
drivers during perf sampling.
Signed-off-by: Qi Liu
Reviewed-by: John Garry
---
drivers/perf/arm-cci.c| 1 +
drivers/perf/arm-ccn.c| 1 +
drivers/perf/arm_dsu_pmu.c| 1 +
drivers/perf/arm_smmuv3_pmu.c
so that try_module_get() can be invoked when perf sampling starts. This
adds the reference counting of module and could prevent users from removing
modules during sampling.
Signed-off-by: Qi Liu
Reported-by: Haifeng Wang
Reviewed-by: John Garry
---
Kernel panic will also happen when users
Gentle ping ...
Hi Arnaldo,
If possible, could you give a look for this patch?
Thank you,
Qi Liu
On 2020/5/6 20:01, Qi Liu wrote:
> Perf stat displays miss ratio of L1-dcache, L1-icache, dTLB cache, iTLB cache
> and LL-cache. Take L1-dcache for example, its miss ratio is caculated as
58 matches
Mail list logo
