Re: [PATCH] drm/lima: Use delayed timer as default in devfreq profile

2021-02-07 Thread Qiang Yu
Applied to drm-misc-next. Regards, Qiang On Thu, Feb 4, 2021 at 10:24 PM Lukasz Luba wrote: > > > > On 2/4/21 1:39 PM, Robin Murphy wrote: > > On 2021-02-03 02:01, Qiang Yu wrote: > >> On Tue, Feb 2, 2021 at 10:02 PM Lukasz Luba wrote: > >>> > >>

Re: [PATCH v2] drm/lima: add governor data with pre-defined thresholds

2021-02-07 Thread Qiang Yu
Applied to drm-misc-next. Regards, Qiang On Tue, Feb 2, 2021 at 9:04 AM Qiang Yu wrote: > > OK, I see. Patch is also: > Reviewed-by: Qiang Yu > > Regards, > Qiang > > On Mon, Feb 1, 2021 at 5:59 PM Lukasz Luba wrote: > > > > > > > > On 1/30/2

Re: [PATCH] drm/lima: Use delayed timer as default in devfreq profile

2021-02-02 Thread Qiang Yu
On Tue, Feb 2, 2021 at 10:02 PM Lukasz Luba wrote: > > > > On 2/2/21 1:01 AM, Qiang Yu wrote: > > Hi Lukasz, > > > > Thanks for the explanation. So the deferred timer option makes a mistake > > that > > when GPU goes from idle to busy for only one p

Re: [PATCH v2] drm/lima: add governor data with pre-defined thresholds

2021-02-01 Thread Qiang Yu
OK, I see. Patch is also: Reviewed-by: Qiang Yu Regards, Qiang On Mon, Feb 1, 2021 at 5:59 PM Lukasz Luba wrote: > > > > On 1/30/21 1:57 PM, Qiang Yu wrote: > > This patch gets minor improvement on glmark2 (160->162). > > It has bigger impact when the load is

Re: [PATCH] drm/lima: Use delayed timer as default in devfreq profile

2021-02-01 Thread Qiang Yu
like phone suspend? Regards, Qiang On Mon, Feb 1, 2021 at 5:53 PM Lukasz Luba wrote: > > Hi Qiang, > > On 1/30/21 1:51 PM, Qiang Yu wrote: > > Thanks for the patch. But I can't observe any difference on glmark2 > > with or without this patch. > > Maybe you ca

Re: [PATCH v2] drm/lima: add governor data with pre-defined thresholds

2021-01-30 Thread Qiang Yu
This patch gets minor improvement on glmark2 (160->162). Seems there's no way for user to change this value, do we? Or there's work pending to expose it to sysfs? Regards, Qiang On Thu, Jan 28, 2021 at 3:40 AM Christian Hewitt wrote: > > This patch adapts the panfrost pre-defined thresholds

Re: [PATCH] drm/lima: Use delayed timer as default in devfreq profile

2021-01-30 Thread Qiang Yu
Thanks for the patch. But I can't observe any difference on glmark2 with or without this patch. Maybe you can provide other test which can benefit from it. Considering it will wake up CPU more frequently, and user may choose to change this by sysfs, I'd like to not apply it. Regards, Qiang On

Re: [PATCH] drm/lima: fix reference leak in lima_pm_busy

2021-01-30 Thread Qiang Yu
Thanks, applied to drm-misc-next. Regards, Qiang On Fri, Nov 27, 2020 at 5:42 PM Qinglang Miao wrote: > > pm_runtime_get_sync will increment pm usage counter even it > failed. Forgetting to putting operation will result in a > reference leak here. > > A new function pm_runtime_resume_and_get is

Re: [PATCH 5/7] drm/lima: dev_pm_opp_put_*() accepts NULL argument

2020-11-15 Thread Qiang Yu
Looks good for me, patch is: Reviewed-by: Qiang Yu Regards, Qiang On Fri, Nov 6, 2020 at 3:05 PM Viresh Kumar wrote: > > The dev_pm_opp_put_*() APIs now accepts a NULL opp_table pointer and so > there is no need for us to carry the extra check. Drop them. > > Signed-off-b

Re: [PATCH V2 Resend 1/2] drm/lima: Unconditionally call dev_pm_opp_of_remove_table()

2020-11-15 Thread Qiang Yu
remove_table() > unconditionally here. > > Reviewed-by: Qiang Yu > Signed-off-by: Viresh Kumar > > --- > V2: Applied Reviewed by tag. > --- > drivers/gpu/drm/lima/lima_devfreq.c | 6 +- > drivers/gpu/drm/lima/lima_devfreq.h | 1 - > 2 files changed, 1 insertion(+), 6 delet

Re: [PATCH 15/40] drm/lima/lima_drv: Demote kernel-doc formatting abuse

2020-11-15 Thread Qiang Yu
Applied to drm-misc-next. On Fri, Nov 13, 2020 at 9:50 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/lima/lima_drv.c:264: warning: cannot understand function > prototype: 'const struct drm_driver lima_drm_driver = ' > > Cc:

Re: [PATCH 23/40] drm/lima/lima_sched: Remove unused and unnecessary variable 'ret'

2020-11-15 Thread Qiang Yu
but > not used [-Wunused-but-set-variable] > > Cc: Qiang Yu > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: "Christian König" > Cc: dri-de...@lists.freedesktop.org > Cc: l...@lists.freedesktop.org > Cc: linux-me...@vger.kernel.org > Cc:

Re: [PATCH -next] drm/lima: simplify the return expression of lima_devfreq_target

2020-11-15 Thread Qiang Yu
Applied to drm-misc-next. On Sat, Sep 19, 2020 at 6:43 PM Qiang Yu wrote: > > Looks good for me, patch is: > Reviewed-by: Qiang Yu > > Regards, > Qiang > > On Sat, Sep 19, 2020 at 5:47 PM Liu Shixin wrote: > > > > Simplify the return expressio

Re: [PATCH -next] drm/lima: simplify the return expression of lima_devfreq_target

2020-09-19 Thread Qiang Yu
Looks good for me, patch is: Reviewed-by: Qiang Yu Regards, Qiang On Sat, Sep 19, 2020 at 5:47 PM Liu Shixin wrote: > > Simplify the return expression. > > Signed-off-by: Liu Shixin > --- > drivers/gpu/drm/lima/lima_devfreq.c | 7 +-- > 1 file changed, 1 inse

Re: [PATCH 2/8] drm/lima: Unconditionally call dev_pm_opp_of_remove_table()

2020-08-22 Thread Qiang Yu
Looks good for me, patch is: Reviewed-by: Qiang Yu Regards, Qiang On Thu, Aug 20, 2020 at 6:44 PM Viresh Kumar wrote: > > dev_pm_opp_of_remove_table() doesn't report any errors when it fails to > find the OPP table with error -ENODEV (i.e. OPP table not present for > the device)

[PATCH] arm64: dts: allwinner: h5: remove Mali GPU PMU module

2020-08-22 Thread Qiang Yu
: dts: allwinner: h5: Add device node for Mali-450 GPU") Signed-off-by: Qiang Yu --- arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.

Re: [PATCH] drm/lima: Expose job_hang_limit module parameter

2020-07-13 Thread Qiang Yu
Applied to drm-misc-next: https://cgit.freedesktop.org/drm/drm-misc/ Sorry for the late response. Regards, Qiang On Tue, Jul 7, 2020 at 12:17 AM Andrey Lebedev wrote: > > Hello guys, > > What is the status of this patch? Was this committed to any branch? Is > it pending for merge to the

Re: [PATCH] drm/lima: Expose job_hang_limit module parameter

2020-06-18 Thread Qiang Yu
On Thu, Jun 18, 2020 at 10:58 PM Andrey Lebedev wrote: > > From: Andrey Lebedev > > Some pp or gp jobs can be successfully repeated even after they time outs. > Introduce lima module parameter to specify number of times a job can hang > before being dropped. > > Signed-off-by: Andrey Lebedev >

Re: [PATCH] drm/lima: Expose job_hang_limit module parameter

2020-06-18 Thread Qiang Yu
ima/lima_drv.c > @@ -19,6 +19,7 @@ > int lima_sched_timeout_ms; > uint lima_heap_init_nr_pages = 8; > uint lima_max_error_tasks; > +int lima_job_hang_limit; Better be an "uint" to avoid negative check. With this fixed, patch is: Reviewed-by: Qiang Yu Regards, Qiang > >

Re: [PATCH v5 13/38] drm: lima: fix common struct sg_table related issues

2020-05-17 Thread Qiang Yu
Looks good for me, patch is: Reviewed-by: Qiang Yu Regards, Qiang On Wed, May 13, 2020 at 9:33 PM Marek Szyprowski wrote: > > The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function > returns the number of the created entries in the DMA address space. > However th

Re: [Lima] [PATCH -next] MAINTAINERS: mark lima mailing list as moderated

2019-04-08 Thread Qiang Yu
On Mon, Apr 8, 2019 at 8:00 PM Neil Armstrong wrote: > > On 08/04/2019 03:37, Qiang Yu wrote: > > Looks good for me, patch is: > > Reviewed-by: Qiang Yu > > Also: > Reviewed-by: Neil Armstrong > > > > > Should I apply this patch to drm-misc in this

[PATCH] drm/lima: adopt xa_alloc API change

2019-04-02 Thread Qiang Yu
Cc: Stephen Rothwell Cc: Matthew Wilcox Cc: Daniel Vetter Signed-off-by: Qiang Yu --- drivers/gpu/drm/lima/lima_ctx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/lima/lima_ctx.c b/drivers/gpu/drm/lima/lima_ctx.c index c8d12f7c6894..22fff6caa961 100644

Re: linux-next: build failure after merge of the drm-misc tree

2019-04-02 Thread Qiang Yu
On Tue, Apr 2, 2019 at 3:57 PM Daniel Vetter wrote: > > On Tue, Apr 02, 2019 at 01:55:03PM +0800, Qiang Yu wrote: > > Thanks, patch is: > > Reviewed-by: Qiang Yu > > Good time to get started with committing patches? In general it's kinda > confusing if the maintaine