Re: [PATCH 4/9] mfd: max8925: fix trivial build warning for non-dt

2013-02-14 Thread Qing Xu
': drivers/video/backlight/max8925_bl.c:177:3: warning: statement with no effect [-Wunused-value] A much nicer fix is to use the IS_ENABLED keyword to have the same effect of dropping the device tree specific function when it's not needed. Signed-off-by: Arnd Bergmann Cc: Qing Xu Cc: Haojian

Re: [PATCH 4/9] mfd: max8925: fix trivial build warning for non-dt

2013-02-14 Thread Qing Xu
/video/backlight/max8925_bl.c:177:3: warning: statement with no effect [-Wunused-value] A much nicer fix is to use the IS_ENABLED keyword to have the same effect of dropping the device tree specific function when it's not needed. Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Qing Xu qi

Re: [PATCH 1/6] mfd: max8925: add irqdomain for dt

2013-02-05 Thread Qing Xu
On 02/05/2013 04:19 PM, Samuel Ortiz wrote: Hi Haojian, On Mon, Feb 04, 2013 at 11:40:42PM +0800, Haojian Zhuang wrote: From: Qing Xu Add irqdomains for max8925's main irq, wrap irq register operations into irqdomain's map func. it is necessary for dt support. Also, add dt support

Re: [PATCH 1/6] mfd: max8925: add irqdomain for dt

2013-02-05 Thread Qing Xu
On 02/05/2013 04:19 PM, Samuel Ortiz wrote: Hi Haojian, On Mon, Feb 04, 2013 at 11:40:42PM +0800, Haojian Zhuang wrote: From: Qing Xu qi...@marvell.com Add irqdomains for max8925's main irq, wrap irq register operations into irqdomain's map func. it is necessary for dt support. Also, add dt

Re: [PATCH 2/4] mfd: 88pm80x: move to regmap irq base implementation

2012-12-11 Thread Qing Xu
On 12/03/2012 01:40 PM, Qing Xu wrote: From: Qing Xu get irq_base for mfd sub-device Signed-off-by: Qiao Zhou Signed-off-by: Qing Xu --- drivers/mfd/88pm800.c |2 +- drivers/mfd/88pm805.c |1 + include/linux/mfd/88pm80x.h |1 + 3 files changed, 3 insertions

Re: [PATCH] mfd: 88pm80x: fix no interrupt mask reg

2012-12-11 Thread Qing Xu
On 12/03/2012 04:11 PM, Qing Xu wrote: From: Qing Xu 1.88pm80x do not have interrupt mask registers and we use interrupt enable register. So we need to set mask_invert flag. 2.add support for D0 version Signed-off-by: Xiaofan Tian Signed-off-by: Qing Xu --- drivers/mfd/88pm800.c |4

Re: [PATCH v2 2/4] mfd: 88pm80x: move to regmap irq base implementation

2012-12-11 Thread Qing Xu
On 12/03/2012 01:45 PM, Qing Xu wrote: From: Qing Xu get irq_base for mfd sub-device Signed-off-by: Qiao Zhou Signed-off-by: Qing Xu --- drivers/mfd/88pm800.c |2 +- drivers/mfd/88pm805.c |1 + include/linux/mfd/88pm80x.h |1 + 3 files changed, 3 insertions

Re: [PATCH 4/4] rtc: 88pm80x: update irq base

2012-12-11 Thread Qing Xu
On 12/03/2012 01:43 PM, Qing Xu wrote: From: Qing Xu irq base is stored in 88pm80x's drv data, we need to add irq base to get the correct irq num Signed-off-by: Qiao Zhou Signed-off-by: Qing Xu --- drivers/rtc/rtc-88pm80x.c |7 --- 1 files changed, 4 insertions(+), 3 deletions

Re: [PATCH 3/4] onkey: 88pm80x: update irq base

2012-12-11 Thread Qing Xu
On 12/03/2012 01:42 PM, Qing Xu wrote: From: Qing Xu irq base is stored in 88pm80x's drv data, we need to add irq base to get the correct irq num Signed-off-by: Qiao Zhou Signed-off-by: Qing Xu --- drivers/input/misc/88pm80x_onkey.c |7 --- 1 files changed, 4 insertions(+), 3

Re: [PATCH 1/4] mfd: 88pm80x: fix regmap not init before used

2012-12-11 Thread Qing Xu
On 12/03/2012 01:38 PM, Qing Xu wrote: From: Qing Xu 1.put the pm800_page_init before 800_init, otherwise power and gpadc regmap handle are not inited before being used. 2.remove regmap exit, as it will be called in driver release 3.add lost "return 0" in probe() 4.update driver's na

Re: [PATCH 0/7] mfd: update on max8925 for DT support

2012-12-11 Thread Qing Xu
On 12/04/2012 03:11 PM, Haojian Zhuang wrote: On Thu, Nov 29, 2012 at 1:54 PM, Qing Xu wrote: On 11/23/2012 05:09 PM, Haojian Zhuang wrote: On Tue, Nov 6, 2012 at 3:35 PM, Qing Xu wrote: From: Qing Xu 1. add irqdomain for max8925, it is necessary for dt support 2. bug fix in max8925 mfd

Re: [PATCH 0/7] mfd: update on max8925 for DT support

2012-12-11 Thread Qing Xu
On 12/04/2012 03:11 PM, Haojian Zhuang wrote: On Thu, Nov 29, 2012 at 1:54 PM, Qing Xu qi...@marvell.com wrote: On 11/23/2012 05:09 PM, Haojian Zhuang wrote: On Tue, Nov 6, 2012 at 3:35 PM, Qing Xu qi...@marvell.com wrote: From: Qing Xu qi...@marvell.com 1. add irqdomain for max8925

Re: [PATCH 1/4] mfd: 88pm80x: fix regmap not init before used

2012-12-11 Thread Qing Xu
On 12/03/2012 01:38 PM, Qing Xu wrote: From: Qing Xu qi...@marvell.com 1.put the pm800_page_init before 800_init, otherwise power and gpadc regmap handle are not inited before being used. 2.remove regmap exit, as it will be called in driver release 3.add lost return 0 in probe() 4.update

Re: [PATCH 3/4] onkey: 88pm80x: update irq base

2012-12-11 Thread Qing Xu
On 12/03/2012 01:42 PM, Qing Xu wrote: From: Qing Xu qi...@marvell.com irq base is stored in 88pm80x's drv data, we need to add irq base to get the correct irq num Signed-off-by: Qiao Zhou zhouq...@marvell.com Signed-off-by: Qing Xu qi...@marvell.com --- drivers/input/misc/88pm80x_onkey.c

Re: [PATCH 4/4] rtc: 88pm80x: update irq base

2012-12-11 Thread Qing Xu
On 12/03/2012 01:43 PM, Qing Xu wrote: From: Qing Xu qi...@marvell.com irq base is stored in 88pm80x's drv data, we need to add irq base to get the correct irq num Signed-off-by: Qiao Zhou zhouq...@marvell.com Signed-off-by: Qing Xu qi...@marvell.com --- drivers/rtc/rtc-88pm80x.c |7

Re: [PATCH v2 2/4] mfd: 88pm80x: move to regmap irq base implementation

2012-12-11 Thread Qing Xu
On 12/03/2012 01:45 PM, Qing Xu wrote: From: Qing Xu qi...@marvell.com get irq_base for mfd sub-device Signed-off-by: Qiao Zhou zhouq...@marvell.com Signed-off-by: Qing Xu qi...@marvell.com --- drivers/mfd/88pm800.c |2 +- drivers/mfd/88pm805.c |1 + include/linux/mfd

Re: [PATCH] mfd: 88pm80x: fix no interrupt mask reg

2012-12-11 Thread Qing Xu
On 12/03/2012 04:11 PM, Qing Xu wrote: From: Qing Xu qi...@marvell.com 1.88pm80x do not have interrupt mask registers and we use interrupt enable register. So we need to set mask_invert flag. 2.add support for D0 version Signed-off-by: Xiaofan Tian tia...@marvell.com Signed-off-by: Qing Xu qi

Re: [PATCH 2/4] mfd: 88pm80x: move to regmap irq base implementation

2012-12-11 Thread Qing Xu
On 12/03/2012 01:40 PM, Qing Xu wrote: From: Qing Xu qi...@marvell.com get irq_base for mfd sub-device Signed-off-by: Qiao Zhou zhouq...@marvell.com Signed-off-by: Qing Xu qi...@marvell.com --- drivers/mfd/88pm800.c |2 +- drivers/mfd/88pm805.c |1 + include/linux/mfd

Re: [PATCH 2/2] Documentation: add docs for 88pm80x dt

2012-12-05 Thread Qing Xu
On 12/06/2012 06:55 AM, Grant Likely wrote: On Wed, 5 Dec 2012 13:42:00 +0800, Qing Xu wrote: From: Qing Xu Signed-off-by: Qing Xu No commit text? This patch needs to be squashed together with the patch that changes the driver. There is no value in separating them. --- Documentation

[PATCH] mfd: 88pm80x: add dt support

2012-12-05 Thread Qing Xu
From: Qing Xu add dt support for 88pm800 and 88pm805 Signed-off-by: Qing Xu --- Documentation/devicetree/bindings/mfd/88pm80x.txt | 52 + drivers/mfd/88pm800.c | 26 +- drivers/mfd/88pm805.c | 26

[PATCH] mfd: 88pm80x: add dt support

2012-12-05 Thread Qing Xu
From: Qing Xu qi...@marvell.com add dt support for 88pm800 and 88pm805 Signed-off-by: Qing Xu qi...@marvell.com --- Documentation/devicetree/bindings/mfd/88pm80x.txt | 52 + drivers/mfd/88pm800.c | 26 +- drivers/mfd/88pm805.c

Re: [PATCH 2/2] Documentation: add docs for 88pm80x dt

2012-12-05 Thread Qing Xu
On 12/06/2012 06:55 AM, Grant Likely wrote: On Wed, 5 Dec 2012 13:42:00 +0800, Qing Xu qi...@marvell.com wrote: From: Qing Xu qi...@marvell.com Signed-off-by: Qing Xu qi...@marvell.com No commit text? This patch needs to be squashed together with the patch that changes the driver

Re: [PATCH] mfd: 88pm80x: add dt support

2012-12-04 Thread Qing Xu
On 12/05/2012 10:28 AM, Haojian Zhuang wrote: On Wed, Dec 5, 2012 at 10:23 AM, Qing Xu wrote: From: Qing Xu add dt support for 88pm800 and 88pm805 Signed-off-by: Qing Xu --- drivers/mfd/88pm800.c | 26 +++--- drivers/mfd/88pm805.c | 26

[PATCH 2/2] Documentation: add docs for 88pm80x dt

2012-12-04 Thread Qing Xu
From: Qing Xu Signed-off-by: Qing Xu --- Documentation/devicetree/bindings/mfd/88pm80x.txt | 52 + 1 files changed, 52 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/mfd/88pm80x.txt diff --git a/Documentation/devicetree/bindings/mfd

[PATCH 1/2] mfd: 88pm80x: add dt support

2012-12-04 Thread Qing Xu
From: Qing Xu add dt support for 88pm800 and 88pm805 Signed-off-by: Qing Xu --- drivers/mfd/88pm800.c | 26 +++--- drivers/mfd/88pm805.c | 26 +++--- drivers/mfd/88pm80x.c | 32 include/linux/mfd

[PATCH] mfd: 88pm80x: add dt support

2012-12-04 Thread Qing Xu
From: Qing Xu add dt support for 88pm800 and 88pm805 Signed-off-by: Qing Xu --- drivers/mfd/88pm800.c | 26 +++--- drivers/mfd/88pm805.c | 26 +++--- drivers/mfd/88pm80x.c | 32 include/linux/mfd

[PATCH] mfd: 88pm80x: add dt support

2012-12-04 Thread Qing Xu
From: Qing Xu qi...@marvell.com add dt support for 88pm800 and 88pm805 Signed-off-by: Qing Xu qi...@marvell.com --- drivers/mfd/88pm800.c | 26 +++--- drivers/mfd/88pm805.c | 26 +++--- drivers/mfd/88pm80x.c | 32

[PATCH 1/2] mfd: 88pm80x: add dt support

2012-12-04 Thread Qing Xu
From: Qing Xu qi...@marvell.com add dt support for 88pm800 and 88pm805 Signed-off-by: Qing Xu qi...@marvell.com --- drivers/mfd/88pm800.c | 26 +++--- drivers/mfd/88pm805.c | 26 +++--- drivers/mfd/88pm80x.c | 32

[PATCH 2/2] Documentation: add docs for 88pm80x dt

2012-12-04 Thread Qing Xu
From: Qing Xu qi...@marvell.com Signed-off-by: Qing Xu qi...@marvell.com --- Documentation/devicetree/bindings/mfd/88pm80x.txt | 52 + 1 files changed, 52 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/mfd/88pm80x.txt diff --git

Re: [PATCH] mfd: 88pm80x: add dt support

2012-12-04 Thread Qing Xu
On 12/05/2012 10:28 AM, Haojian Zhuang wrote: On Wed, Dec 5, 2012 at 10:23 AM, Qing Xu qi...@marvell.com wrote: From: Qing Xu qi...@marvell.com add dt support for 88pm800 and 88pm805 Signed-off-by: Qing Xu qi...@marvell.com --- drivers/mfd/88pm800.c | 26

[PATCH] mfd: 88pm80x: fix no interrupt mask reg

2012-12-03 Thread Qing Xu
From: Qing Xu 1.88pm80x do not have interrupt mask registers and we use interrupt enable register. So we need to set mask_invert flag. 2.add support for D0 version Signed-off-by: Xiaofan Tian Signed-off-by: Qing Xu --- drivers/mfd/88pm800.c |4 +++- drivers/mfd/88pm805.c |1 + 2

[PATCH] mfd: 88pm80x: fix no interrupt mask reg

2012-12-03 Thread Qing Xu
From: Qing Xu qi...@marvell.com 1.88pm80x do not have interrupt mask registers and we use interrupt enable register. So we need to set mask_invert flag. 2.add support for D0 version Signed-off-by: Xiaofan Tian tia...@marvell.com Signed-off-by: Qing Xu qi...@marvell.com --- drivers/mfd/88pm800.c

[PATCH v2 2/4] mfd: 88pm80x: move to regmap irq base implementation

2012-12-02 Thread Qing Xu
From: Qing Xu get irq_base for mfd sub-device Signed-off-by: Qiao Zhou Signed-off-by: Qing Xu --- drivers/mfd/88pm800.c |2 +- drivers/mfd/88pm805.c |1 + include/linux/mfd/88pm80x.h |1 + 3 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/mfd

[PATCH 4/4] rtc: 88pm80x: update irq base

2012-12-02 Thread Qing Xu
From: Qing Xu irq base is stored in 88pm80x's drv data, we need to add irq base to get the correct irq num Signed-off-by: Qiao Zhou Signed-off-by: Qing Xu --- drivers/rtc/rtc-88pm80x.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-88pm80x.c b

[PATCH 3/4] onkey: 88pm80x: update irq base

2012-12-02 Thread Qing Xu
From: Qing Xu irq base is stored in 88pm80x's drv data, we need to add irq base to get the correct irq num Signed-off-by: Qiao Zhou Signed-off-by: Qing Xu --- drivers/input/misc/88pm80x_onkey.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/input/misc

[PATCH 2/4] mfd: 88pm80x: move to regmap irq base implementation

2012-12-02 Thread Qing Xu
From: Qing Xu get irq_base for mfd sub-device Signed-off-by: Qiao Zhou Signed-off-by: Qing Xu --- drivers/mfd/88pm800.c |2 +- drivers/mfd/88pm805.c |1 + include/linux/mfd/88pm80x.h |1 + 3 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/mfd

[PATCH 1/4] mfd: 88pm80x: fix regmap not init before used

2012-12-02 Thread Qing Xu
From: Qing Xu 1.put the pm800_page_init before 800_init, otherwise power and gpadc regmap handle are not inited before being used. 2.remove regmap exit, as it will be called in driver release 3.add lost "return 0" in probe() 4.update driver's name Signed-off-by: Qiao Zhou Signed-of

[PATCH 1/4] mfd: 88pm80x: fix regmap not init before used

2012-12-02 Thread Qing Xu
From: Qing Xu qi...@marvell.com 1.put the pm800_page_init before 800_init, otherwise power and gpadc regmap handle are not inited before being used. 2.remove regmap exit, as it will be called in driver release 3.add lost return 0 in probe() 4.update driver's name Signed-off-by: Qiao Zhou zhouq

[PATCH 2/4] mfd: 88pm80x: move to regmap irq base implementation

2012-12-02 Thread Qing Xu
From: Qing Xu qi...@marvell.com get irq_base for mfd sub-device Signed-off-by: Qiao Zhou zhouq...@marvell.com Signed-off-by: Qing Xu qi...@marvell.com --- drivers/mfd/88pm800.c |2 +- drivers/mfd/88pm805.c |1 + include/linux/mfd/88pm80x.h |1 + 3 files changed, 3

[PATCH 3/4] onkey: 88pm80x: update irq base

2012-12-02 Thread Qing Xu
From: Qing Xu qi...@marvell.com irq base is stored in 88pm80x's drv data, we need to add irq base to get the correct irq num Signed-off-by: Qiao Zhou zhouq...@marvell.com Signed-off-by: Qing Xu qi...@marvell.com --- drivers/input/misc/88pm80x_onkey.c |7 --- 1 files changed, 4

[PATCH 4/4] rtc: 88pm80x: update irq base

2012-12-02 Thread Qing Xu
From: Qing Xu qi...@marvell.com irq base is stored in 88pm80x's drv data, we need to add irq base to get the correct irq num Signed-off-by: Qiao Zhou zhouq...@marvell.com Signed-off-by: Qing Xu qi...@marvell.com --- drivers/rtc/rtc-88pm80x.c |7 --- 1 files changed, 4 insertions(+), 3

[PATCH v2 2/4] mfd: 88pm80x: move to regmap irq base implementation

2012-12-02 Thread Qing Xu
From: Qing Xu qi...@marvell.com get irq_base for mfd sub-device Signed-off-by: Qiao Zhou zhouq...@marvell.com Signed-off-by: Qing Xu qi...@marvell.com --- drivers/mfd/88pm800.c |2 +- drivers/mfd/88pm805.c |1 + include/linux/mfd/88pm80x.h |1 + 3 files changed, 3

Re: [PATCH 0/7] mfd: update on max8925 for DT support

2012-11-28 Thread Qing Xu
On 11/23/2012 05:09 PM, Haojian Zhuang wrote: On Tue, Nov 6, 2012 at 3:35 PM, Qing Xu wrote: From: Qing Xu 1. add irqdomain for max8925, it is necessary for dt support 2. bug fix in max8925 mfd devices'irq base and device registry failure 3. support DT for max8925 mfd devices Qing Xu (7

[PATCH] Documentation: add docs for max8925 dt

2012-11-28 Thread Qing Xu
From: Qing Xu add docs for dt of max8925-mfd, max8925-backlight, and max8925-battery Signed-off-by: Qing Xu --- Documentation/devicetree/bindings/mfd/max8925.txt | 64 .../bindings/power_supply/max8925_batter.txt | 18 ++ .../bindings/video/backlight

[PATCH v4 7/7] mfd: max8925: add dts

2012-11-28 Thread Qing Xu
From: Qing Xu add max8925 dts support into mmp2 brownstone platform Signed-off-by: Qing Xu --- arch/arm/boot/dts/mmp2-brownstone.dts | 158 + arch/arm/boot/dts/mmp2.dtsi |4 +- 2 files changed, 161 insertions(+), 1 deletions(-) diff --git a/arch

[PATCH] mfd: max8925: add dts

2012-11-28 Thread Qing Xu
From: Qing Xu add max8925 dts support into mmp2 brownstone platform Signed-off-by: Qing Xu --- arch/arm/boot/dts/mmp2-brownstone.dts | 158 + arch/arm/boot/dts/mmp2.dtsi |4 +- 2 files changed, 161 insertions(+), 1 deletions(-) diff --git a/arch

[PATCH v3 1/7] mfd: max8925: add irqdomain for dt

2012-11-28 Thread Qing Xu
From: Qing Xu Add irqdomains for max8925's main irq, wrap irq register operations into irqdomain's map func. it is necessary for dt support. Also, add dt support for max8925 driver. Signed-off-by: Qing Xu --- drivers/mfd/max8925-core.c | 69

[PATCH v3 1/7] mfd: max8925: add irqdomain for dt

2012-11-28 Thread Qing Xu
From: Qing Xu qi...@marvell.com Add irqdomains for max8925's main irq, wrap irq register operations into irqdomain's map func. it is necessary for dt support. Also, add dt support for max8925 driver. Signed-off-by: Qing Xu qi...@marvell.com --- drivers/mfd/max8925-core.c | 69

[PATCH] mfd: max8925: add dts

2012-11-28 Thread Qing Xu
From: Qing Xu qi...@marvell.com add max8925 dts support into mmp2 brownstone platform Signed-off-by: Qing Xu qi...@marvell.com --- arch/arm/boot/dts/mmp2-brownstone.dts | 158 + arch/arm/boot/dts/mmp2.dtsi |4 +- 2 files changed, 161 insertions

[PATCH v4 7/7] mfd: max8925: add dts

2012-11-28 Thread Qing Xu
From: Qing Xu qi...@marvell.com add max8925 dts support into mmp2 brownstone platform Signed-off-by: Qing Xu qi...@marvell.com --- arch/arm/boot/dts/mmp2-brownstone.dts | 158 + arch/arm/boot/dts/mmp2.dtsi |4 +- 2 files changed, 161 insertions

[PATCH] Documentation: add docs for max8925 dt

2012-11-28 Thread Qing Xu
From: Qing Xu qi...@marvell.com add docs for dt of max8925-mfd, max8925-backlight, and max8925-battery Signed-off-by: Qing Xu qi...@marvell.com --- Documentation/devicetree/bindings/mfd/max8925.txt | 64 .../bindings/power_supply/max8925_batter.txt | 18

Re: [PATCH 0/7] mfd: update on max8925 for DT support

2012-11-28 Thread Qing Xu
On 11/23/2012 05:09 PM, Haojian Zhuang wrote: On Tue, Nov 6, 2012 at 3:35 PM, Qing Xu qi...@marvell.com wrote: From: Qing Xu qi...@marvell.com 1. add irqdomain for max8925, it is necessary for dt support 2. bug fix in max8925 mfd devices'irq base and device registry failure 3. support DT

Re: [PATCH 6/7] mfd: max8925: support dt for backlight

2012-11-27 Thread Qing Xu
On 11/23/2012 05:08 PM, Haojian Zhuang wrote: On Tue, Nov 6, 2012 at 3:47 PM, Qing Xu wrote: From: Qing Xu Signed-off-by: Qing Xu --- drivers/video/backlight/max8925_bl.c | 31 ++- 1 files changed, 30 insertions(+), 1 deletions(-) diff --git a/drivers/video

[PATCH v3 7/7] mfd: max8925: add dts

2012-11-27 Thread Qing Xu
From: Qing Xu add max8925 dts support into mmp2 brownstone platform Signed-off-by: Qing Xu --- arch/arm/boot/dts/mmp2-brownstone.dts | 158 + arch/arm/boot/dts/mmp2.dtsi |4 +- 2 files changed, 161 insertions(+), 1 deletions(-) diff --git a/arch

[PATCH v2 6/7] mfd: max8925: support dt for backlight

2012-11-27 Thread Qing Xu
From: Qing Xu Signed-off-by: Qing Xu --- drivers/video/backlight/max8925_bl.c | 31 ++- 1 files changed, 30 insertions(+), 1 deletions(-) diff --git a/drivers/video/backlight/max8925_bl.c b/drivers/video/backlight/max8925_bl.c index f72ba54..1682d00 100644

Re: [PATCH 2/7] mfd: max8925: fix mfd device register failure

2012-11-27 Thread Qing Xu
On 11/23/2012 04:41 PM, Haojian Zhuang wrote: On Tue, Nov 6, 2012 at 3:38 PM, Qing Xu wrote: From: Qing Xu we encounter rtc/power/touch driver registry failure, root cause it is resources confilict in insert_resouce, solved by changing mfd_add_devices 5th parameter to NULL Since resources

Re: [PATCH 2/7] mfd: max8925: fix mfd device register failure

2012-11-27 Thread Qing Xu
On 11/23/2012 04:41 PM, Haojian Zhuang wrote: On Tue, Nov 6, 2012 at 3:38 PM, Qing Xu qi...@marvell.com wrote: From: Qing Xu qi...@marvell.com we encounter rtc/power/touch driver registry failure, root cause it is resources confilict in insert_resouce, solved by changing mfd_add_devices 5th

[PATCH v2 6/7] mfd: max8925: support dt for backlight

2012-11-27 Thread Qing Xu
From: Qing Xu qi...@marvell.com Signed-off-by: Qing Xu qi...@marvell.com --- drivers/video/backlight/max8925_bl.c | 31 ++- 1 files changed, 30 insertions(+), 1 deletions(-) diff --git a/drivers/video/backlight/max8925_bl.c b/drivers/video/backlight/max8925_bl.c

[PATCH v3 7/7] mfd: max8925: add dts

2012-11-27 Thread Qing Xu
From: Qing Xu qi...@marvell.com add max8925 dts support into mmp2 brownstone platform Signed-off-by: Qing Xu qi...@marvell.com --- arch/arm/boot/dts/mmp2-brownstone.dts | 158 + arch/arm/boot/dts/mmp2.dtsi |4 +- 2 files changed, 161 insertions

Re: [PATCH 6/7] mfd: max8925: support dt for backlight

2012-11-27 Thread Qing Xu
On 11/23/2012 05:08 PM, Haojian Zhuang wrote: On Tue, Nov 6, 2012 at 3:47 PM, Qing Xu qi...@marvell.com wrote: From: Qing Xu qi...@marvell.com Signed-off-by: Qing Xu qi...@marvell.com --- drivers/video/backlight/max8925_bl.c | 31 ++- 1 files changed, 30

Re: [PATCH 1/7] mfd: max8925: add irqdomain for dt

2012-11-26 Thread Qing Xu
On 11/23/2012 05:05 PM, Haojian Zhuang wrote: On Tue, Nov 6, 2012 at 3:37 PM, Qing Xu wrote: From: Qing Xu Add irqdomains for max8925's main irq, and touch irq. Wrap irq register operations into irqdomain's map func. it is necessary for dt support. Also, add dt support for max8925 driver

[PATCH v2 7/7] mfd: max8925: add dts

2012-11-26 Thread Qing Xu
From: Qing Xu add max8925 dts support into mmp2 brownstone platform Signed-off-by: Qing Xu --- arch/arm/boot/dts/mmp2-brownstone.dts | 158 + arch/arm/boot/dts/mmp2.dtsi |4 +- 2 files changed, 161 insertions(+), 1 deletions(-) diff --git a/arch

[PATCH v2 1/7] mfd: max8925: add irqdomain for dt

2012-11-26 Thread Qing Xu
From: Qing Xu Add irqdomains for max8925's main irq, wrap irq register operations into irqdomain's map func. it is necessary for dt support. Also, add dt support for max8925 driver. Signed-off-by: Qing Xu --- drivers/mfd/max8925-core.c | 69

[PATCH v2 1/7] mfd: max8925: add irqdomain for dt

2012-11-26 Thread Qing Xu
From: Qing Xu qi...@marvell.com Add irqdomains for max8925's main irq, wrap irq register operations into irqdomain's map func. it is necessary for dt support. Also, add dt support for max8925 driver. Signed-off-by: Qing Xu qi...@marvell.com --- drivers/mfd/max8925-core.c | 69

[PATCH v2 7/7] mfd: max8925: add dts

2012-11-26 Thread Qing Xu
From: Qing Xu qi...@marvell.com add max8925 dts support into mmp2 brownstone platform Signed-off-by: Qing Xu qi...@marvell.com --- arch/arm/boot/dts/mmp2-brownstone.dts | 158 + arch/arm/boot/dts/mmp2.dtsi |4 +- 2 files changed, 161 insertions

Re: [PATCH 1/7] mfd: max8925: add irqdomain for dt

2012-11-26 Thread Qing Xu
On 11/23/2012 05:05 PM, Haojian Zhuang wrote: On Tue, Nov 6, 2012 at 3:37 PM, Qing Xu qi...@marvell.com wrote: From: Qing Xu qi...@marvell.com Add irqdomains for max8925's main irq, and touch irq. Wrap irq register operations into irqdomain's map func. it is necessary for dt support. Also, add

Re: [PATCH] regulator: max8925: fix compiler warnings

2012-11-25 Thread Qing Xu
On 11/25/2012 01:55 AM, Mark Brown wrote: On Fri, Nov 23, 2012 at 10:27:12AM +0800, Qing Xu wrote: But, in fact, it is not necessary to initialize regulator_idx. for (i = 0; i < ARRAY_SIZE(max8925_regulator_info); i++) { ri = _regulator_inf

Re: [PATCH] regulator: max8925: fix compiler warnings

2012-11-25 Thread Qing Xu
On 11/25/2012 01:55 AM, Mark Brown wrote: On Fri, Nov 23, 2012 at 10:27:12AM +0800, Qing Xu wrote: But, in fact, it is not necessary to initialize regulator_idx. for (i = 0; i ARRAY_SIZE(max8925_regulator_info); i++) { ri = max8925_regulator_info[i

Re: [PATCH 7/7] mfd: max8925: add dts

2012-11-22 Thread Qing Xu
On 11/06/2012 03:49 PM, Qing Xu wrote: From: Qing Xu add max8925 dts support into mmp2 brownstone platform Signed-off-by: Qing Xu --- arch/arm/boot/dts/mmp2-brownstone.dts | 166 + arch/arm/boot/dts/mmp2.dtsi |4 +- 2 files changed, 169

Re: [PATCH 6/7] mfd: max8925: support dt for backlight

2012-11-22 Thread Qing Xu
On 11/06/2012 03:47 PM, Qing Xu wrote: From: Qing Xu Signed-off-by: Qing Xu --- drivers/video/backlight/max8925_bl.c | 31 ++- 1 files changed, 30 insertions(+), 1 deletions(-) Hi Richard, Florian, Could you help to review this patch, thanks a lot! -Qing

Re: [PATCH 6/7] mfd: max8925: support dt for backlight

2012-11-22 Thread Qing Xu
On 11/06/2012 03:47 PM, Qing Xu wrote: From: Qing Xu Signed-off-by: Qing Xu --- drivers/video/backlight/max8925_bl.c | 31 ++- 1 files changed, 30 insertions(+), 1 deletions(-) diff --git a/drivers/video/backlight/max8925_bl.c b/drivers/video/backlight

Re: [PATCH 3/7] mfd: max8925: fix onkey driver irq base

2012-11-22 Thread Qing Xu
On 11/06/2012 03:39 PM, Qing Xu wrote: From: Qing Xu update onkey driver's irq base, it should get from max8925, but not save in a private value Signed-off-by: Qing Xu --- drivers/input/misc/max8925_onkey.c |3 --- drivers/mfd/max8925-core.c |2 +- 2 files changed, 1

Re: [PATCH 2/7] mfd: max8925: fix mfd device register failure

2012-11-22 Thread Qing Xu
On 11/06/2012 03:38 PM, Qing Xu wrote: From: Qing Xu we encounter rtc/power/touch driver registry failure, root cause it is resources confilict in insert_resouce, solved by changing mfd_add_devices 5th parameter to NULL Signed-off-by: Qing Xu --- drivers/mfd/max8925-core.c | 22

Re: [PATCH 1/7] mfd: max8925: add irqdomain for dt

2012-11-22 Thread Qing Xu
On 11/06/2012 03:37 PM, Qing Xu wrote: From: Qing Xu Add irqdomains for max8925's main irq, and touch irq. Wrap irq register operations into irqdomain's map func. it is necessary for dt support. Also, add dt support for max8925 driver. Signed-off-by: Qing Xu --- drivers/mfd/max8925-core.c

Re: [PATCH 0/7] mfd: update on max8925 for DT support

2012-11-22 Thread Qing Xu
On 11/06/2012 03:35 PM, Qing Xu wrote: From: Qing Xu 1. add irqdomain for max8925, it is necessary for dt support 2. bug fix in max8925 mfd devices'irq base and device registry failure 3. support DT for max8925 mfd devices Qing Xu (7): mfd: max8925: add irqdomain for dt mfd: max8925

Re: [PATCH] regulator: max8925: fix compiler warnings

2012-11-22 Thread Qing Xu
On 11/23/2012 09:41 AM, Mark Brown wrote: On Thu, Nov 22, 2012 at 10:11:06AM +0800, Qing Xu wrote: - int i, regulator_idx; + int i; + int regulator_idx = 0; This sort of fix is rarely good without some analysis as to why this is a sensible initialisation to do, just

[PATCH] regulator: max8925: fix compiler warnings

2012-11-22 Thread Qing Xu
From: Qing Xu Fixed following compiler warning: - drivers/regulator/max8925-regulator.c:269:51: warning: 'regulator_idx' may be used uninitialized in this function [-Wmaybe-uninitialized] Signed-off-by: Qing Xu --- drivers/regulator/max8925-regulator.c |3 ++- 1 files changed, 2

[PATCH] regulator: max8925: fix compiler warnings

2012-11-22 Thread Qing Xu
From: Qing Xu qi...@marvell.com Fixed following compiler warning: - drivers/regulator/max8925-regulator.c:269:51: warning: 'regulator_idx' may be used uninitialized in this function [-Wmaybe-uninitialized] Signed-off-by: Qing Xu qi...@marvell.com --- drivers/regulator/max8925-regulator.c

Re: [PATCH] regulator: max8925: fix compiler warnings

2012-11-22 Thread Qing Xu
On 11/23/2012 09:41 AM, Mark Brown wrote: On Thu, Nov 22, 2012 at 10:11:06AM +0800, Qing Xu wrote: - int i, regulator_idx; + int i; + int regulator_idx = 0; This sort of fix is rarely good without some analysis as to why this is a sensible initialisation to do, just

Re: [PATCH 0/7] mfd: update on max8925 for DT support

2012-11-22 Thread Qing Xu
On 11/06/2012 03:35 PM, Qing Xu wrote: From: Qing Xu qi...@marvell.com 1. add irqdomain for max8925, it is necessary for dt support 2. bug fix in max8925 mfd devices'irq base and device registry failure 3. support DT for max8925 mfd devices Qing Xu (7): mfd: max8925: add irqdomain for dt

Re: [PATCH 1/7] mfd: max8925: add irqdomain for dt

2012-11-22 Thread Qing Xu
On 11/06/2012 03:37 PM, Qing Xu wrote: From: Qing Xu qi...@marvell.com Add irqdomains for max8925's main irq, and touch irq. Wrap irq register operations into irqdomain's map func. it is necessary for dt support. Also, add dt support for max8925 driver. Signed-off-by: Qing Xu qi...@marvell.com

Re: [PATCH 2/7] mfd: max8925: fix mfd device register failure

2012-11-22 Thread Qing Xu
On 11/06/2012 03:38 PM, Qing Xu wrote: From: Qing Xu qi...@marvell.com we encounter rtc/power/touch driver registry failure, root cause it is resources confilict in insert_resouce, solved by changing mfd_add_devices 5th parameter to NULL Signed-off-by: Qing Xu qi...@marvell.com --- drivers

Re: [PATCH 3/7] mfd: max8925: fix onkey driver irq base

2012-11-22 Thread Qing Xu
On 11/06/2012 03:39 PM, Qing Xu wrote: From: Qing Xu qi...@marvell.com update onkey driver's irq base, it should get from max8925, but not save in a private value Signed-off-by: Qing Xu qi...@marvell.com --- drivers/input/misc/max8925_onkey.c |3 --- drivers/mfd/max8925-core.c

Re: [PATCH 6/7] mfd: max8925: support dt for backlight

2012-11-22 Thread Qing Xu
On 11/06/2012 03:47 PM, Qing Xu wrote: From: Qing Xu qi...@marvell.com Signed-off-by: Qing Xu qi...@marvell.com --- drivers/video/backlight/max8925_bl.c | 31 ++- 1 files changed, 30 insertions(+), 1 deletions(-) diff --git a/drivers/video/backlight

Re: [PATCH 6/7] mfd: max8925: support dt for backlight

2012-11-22 Thread Qing Xu
On 11/06/2012 03:47 PM, Qing Xu wrote: From: Qing Xu qi...@marvell.com Signed-off-by: Qing Xu qi...@marvell.com --- drivers/video/backlight/max8925_bl.c | 31 ++- 1 files changed, 30 insertions(+), 1 deletions(-) Hi Richard, Florian, Could you help to review

Re: [PATCH 7/7] mfd: max8925: add dts

2012-11-22 Thread Qing Xu
On 11/06/2012 03:49 PM, Qing Xu wrote: From: Qing Xu qi...@marvell.com add max8925 dts support into mmp2 brownstone platform Signed-off-by: Qing Xu qi...@marvell.com --- arch/arm/boot/dts/mmp2-brownstone.dts | 166 + arch/arm/boot/dts/mmp2.dtsi

[PATCH v3 4/7] mfd: max8925: support dt for power supply

2012-11-18 Thread Qing Xu
From: Qing Xu Signed-off-by: Qing Xu --- drivers/power/max8925_power.c | 50 - 1 files changed, 49 insertions(+), 1 deletions(-) diff --git a/drivers/power/max8925_power.c b/drivers/power/max8925_power.c index daa333b..2d77107 100644 --- a/drivers

Re: [PATCH v2 4/7] mfd: max8925: support dt for power supply

2012-11-18 Thread Qing Xu
On 11/19/2012 03:06 PM, Anton Vorontsov wrote: On Mon, Nov 19, 2012 at 02:52:24PM +0800, Qing Xu wrote: From: Qing Xu Signed-off-by: Qing Xu --- drivers/power/max8925_power.c | 61 +--- 1 files changed, 56 insertions(+), 5 deletions(-) diff --git

Re: [PATCH 4/7] mfd: max8925: support dt for power supply

2012-11-18 Thread Qing Xu
On 11/19/2012 08:24 AM, Anton Vorontsov wrote: On Tue, Nov 06, 2012 at 03:42:44PM +0800, Qing Xu wrote: From: Qing Xu Signed-off-by: Qing Xu --- W/ this patch I'm getting this warning: CC drivers/power/max8925_power.o drivers/power/max8925_power.c: In function

[PATCH v2 4/7] mfd: max8925: support dt for power supply

2012-11-18 Thread Qing Xu
From: Qing Xu Signed-off-by: Qing Xu --- drivers/power/max8925_power.c | 61 +--- 1 files changed, 56 insertions(+), 5 deletions(-) diff --git a/drivers/power/max8925_power.c b/drivers/power/max8925_power.c index daa333b..aca3f68 100644 --- a/drivers

[PATCH v2 4/7] mfd: max8925: support dt for power supply

2012-11-18 Thread Qing Xu
From: Qing Xu qi...@marvell.com Signed-off-by: Qing Xu qi...@marvell.com --- drivers/power/max8925_power.c | 61 +--- 1 files changed, 56 insertions(+), 5 deletions(-) diff --git a/drivers/power/max8925_power.c b/drivers/power/max8925_power.c index daa333b

Re: [PATCH 4/7] mfd: max8925: support dt for power supply

2012-11-18 Thread Qing Xu
On 11/19/2012 08:24 AM, Anton Vorontsov wrote: On Tue, Nov 06, 2012 at 03:42:44PM +0800, Qing Xu wrote: From: Qing Xu qi...@marvell.com Signed-off-by: Qing Xu qi...@marvell.com --- W/ this patch I'm getting this warning: CC drivers/power/max8925_power.o drivers/power

Re: [PATCH v2 4/7] mfd: max8925: support dt for power supply

2012-11-18 Thread Qing Xu
On 11/19/2012 03:06 PM, Anton Vorontsov wrote: On Mon, Nov 19, 2012 at 02:52:24PM +0800, Qing Xu wrote: From: Qing Xu qi...@marvell.com Signed-off-by: Qing Xu qi...@marvell.com --- drivers/power/max8925_power.c | 61 +--- 1 files changed, 56 insertions

[PATCH v3 4/7] mfd: max8925: support dt for power supply

2012-11-18 Thread Qing Xu
From: Qing Xu qi...@marvell.com Signed-off-by: Qing Xu qi...@marvell.com --- drivers/power/max8925_power.c | 50 - 1 files changed, 49 insertions(+), 1 deletions(-) diff --git a/drivers/power/max8925_power.c b/drivers/power/max8925_power.c index daa333b

Re: [PATCH v4 5/7] mfd: max8925: support dt for regulator

2012-11-07 Thread Qing Xu
On 11/07/2012 10:20 PM, Mark Brown wrote: On Wed, Nov 07, 2012 at 06:09:53PM +0800, Qing Xu wrote: From: Qing Xu Signed-off-by: Qing Xu Applied, thanks. +max8925 regulator device register is still handled by mfd_add_devices, not by +of_xxx, so, it is not necessary to add compatible name

[PATCH] mfd: max8925: update dt regulator binding doc

2012-11-07 Thread Qing Xu
From: Qing Xu remove linux specific references, enumerates all supported regulators Signed-off-by: Qing Xu --- .../bindings/regulator/max8925-regulator.txt | 51 1 files changed, 31 insertions(+), 20 deletions(-) diff --git a/Documentation/devicetree/bindings

[PATCH v4 5/7] mfd: max8925: support dt for regulator

2012-11-07 Thread Qing Xu
From: Qing Xu Signed-off-by: Qing Xu --- .../bindings/regulator/max8925-regulator.txt | 29 drivers/regulator/max8925-regulator.c | 72 +++- 2 files changed, 98 insertions(+), 3 deletions(-) create mode 100644 Documentation/devicetree/bindings

[PATCH v3 5/7] mfd: max8925: support dt for regulator

2012-11-07 Thread Qing Xu
From: Qing Xu Signed-off-by: Qing Xu --- .../bindings/regulator/max8925-regulator.txt | 29 drivers/regulator/max8925-regulator.c | 72 +++- 2 files changed, 98 insertions(+), 3 deletions(-) create mode 100644 Documentation/devicetree/bindings

Re: [PATCH 5/7] mfd: max8925: support dt for regulator

2012-11-07 Thread Qing Xu
On 11/06/2012 05:01 PM, Mark Brown wrote: On Tue, Nov 06, 2012 at 03:44:52PM +0800, Qing Xu wrote: From: Qing Xu Signed-off-by: Qing Xu --- drivers/regulator/max8925-regulator.c | 35 - 1 files changed, 34 insertions(+), 1 deletions

[PATCH v2 5/7] mfd: max8925: support dt for regulator

2012-11-07 Thread Qing Xu
From: Qing Xu Signed-off-by: Qing Xu --- drivers/regulator/max8925-regulator.c | 72 +++- 1 files changed, 69 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/max8925-regulator.c b/drivers/regulator/max8925-regulator.c index 9bb0be3..5e84921 100644

  1   2   >