Re: [PATCH -next] mm/page_alloc: remove duplicated include from page_alloc.c

the mass of header includes' you mentioned, could you please offer more details? Because I didn't find pagemap.h in net/ipv4/tcp.c in -next like what you said. 在 2021/3/26 11:42, Matthew Wilcox 写道: On Fri, Mar 26, 2021 at 10:55:42AM +0800, Qinglang Miao wrote: Remove duplicated include

[PATCH -next] mm/page_alloc: remove duplicated include from page_alloc.c

Remove duplicated include. Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- mm/page_alloc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index c53fe4fa10bf..e51826c87a0b 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -72,7 +72,6

[PATCH v2] ACPI: configfs: add missing check after configfs_register_default_group

) Reported-by: Hulk Robot Suggested-by: Hanjun Guo Signed-off-by: Qinglang Miao --- v1->v2: fix 'register' to 'unregister' which is typo. drivers/acpi/acpi_configfs.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/acpi_configfs.c b/drivers/acpi/acpi_con

[PATCH] can: mcp251xfd: fix wrong check in mcp251xfd_handle_rxif_one

If alloc_canfd_skb returns NULL, 'cfg' is an uninitialized variable, so we should check 'skb' rather than 'cfd' after calling alloc_canfd_skb(priv->ndev, ). Fixes: 55e5b97f003e ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN") Signed-off-by: Qinglang Miao --- driver

[PATCH] ACPI: configfs: add missing check after configfs_register_default_group

) Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/acpi/acpi_configfs.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/acpi_configfs.c b/drivers/acpi/acpi_configfs.c index cf91f4910..25512ab0e 100644 --- a/drivers/acpi/acpi_configfs.c +++

Re: [v2] net: qrtr: fix null pointer dereference in qrtr_ns_remove

在 2021/1/6 16:09, Markus Elfring 写道: A null-ptr-deref bug is reported by Hulk Robot like this: Can it be clearer to use the term “null pointer dereference” for the final commit message? This advice is too detailed for 'null-ptr-deref' is known as a general phrase This key word was

Re: [PATCH v2] net: qrtr: fix null pointer dereference in qrtr_ns_remove

Hi Markus, I'd like to take some of your advice in this patch, but I noticed that this one has been applied. Some of your advice would be considered kindly on my future work. Thanks. 在 2021/1/5 21:14, Markus Elfring 写道: A null-ptr-deref bug is reported by Hulk Robot like this: Can it be

Re: [PATCH] net: qrtr: fix null-ptr-deref in qrtr_ns_remove

I sent a v2 on this one because of the redundant braces in qrtr_proto_init, sorry for the noise. 在 2021/1/5 10:40, Qinglang Miao 写道: A null-ptr-deref bug is reported by Hulk Robot like this: -- KASAN: null-ptr-deref in range [0x0128-0x012f] Call Trace

[PATCH v2] net: qrtr: fix null-ptr-deref in qrtr_ns_remove

in qrtr_proto_init. Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- v1->v2: remove redundant braces for single statement blocks. net/qrtr/ns.c | 7 --- net/qrtr/qrtr.c | 16 +++- net/qrtr/qrtr.h | 2 +- 3 files changed, 16 insertions(+), 9 deletions(-) diff --git a/net/q

[PATCH] net: qrtr: fix null-ptr-deref in qrtr_ns_remove

in qrtr_proto_init. Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- net/qrtr/ns.c | 7 --- net/qrtr/qrtr.c | 14 +++--- net/qrtr/qrtr.h | 2 +- 3 files changed, 16 insertions(+), 7 deletions(-) diff --git a/net/qrtr/ns.c b/net/qrtr/ns.c index 56aaf8cb6..8d00dfe81 100644

Re: [PATCH] PCI: fix use-after-free in pci_register_host_bridge

在 2020/12/11 23:46, Rob Herring 写道: On Fri, Nov 20, 2020 at 03:48:48PM +0800, Qinglang Miao wrote: When put_device(>dev) being called, kfree(bridge) is inside of release function, so the following device_del would cause a use-after-free bug. Fixes: 37d6a0a6f470 ("

[PATCH v2] cgroup: Fix memory leak when parsing multiple source parameters

t+0xee1/0x1820 [<04756de2>] do_mount+0xea/0x100 [<94cafb0a>] __x64_sys_mount+0x14b/0x1f0 Fix this bug by permitting a single source parameter and rejecting with an error all subsequent ones. Fixes: 8d2451f4994f ("cgroup1: switch to option-by-option pars

[PATCH] cgroup: Fix memory leak when parsing multiple source parameters

t+0xee1/0x1820 [<04756de2>] do_mount+0xea/0x100 [<94cafb0a>] __x64_sys_mount+0x14b/0x1f0 Fix this bug by permitting a single source parameter and rejecting with an error all subsequent ones. Fixes: 8d2451f4994f ("cgroup1: switch to option-by-option pars

[PATCH] drm/v3d: fix reference leak when pm_runtime_get_sync fails

it with pm_runtime_resume_and_get to keep usage counter balanced. Fixes: 57692c94dcbe ("drm/v3d: Introduce a new DRM driver for Broadcom V3D V3.x+") Fixes: 935f3d88434b ("drm/v3d: Make sure the GPU is on when measuring clocks.") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao ---

[PATCH] drm/tegra: fix reference leak when pm_runtime_get_sync fails

usage counter balanced. Fixes: fd67e9c6ed5a ("drm/tegra: Do not implement runtime PM") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/tegra/dc.c | 2 +- drivers/gpu/drm/tegra/dsi.c | 2 +- drivers/gpu/drm/tegra/hdmi.c | 2 +- drivers/gpu/drm/tegra/hub.c | 2 +

[PATCH 1/3] drm/rockchip: cdn-dp: fix reference leak when pm_runtime_get_sync fails

counter balanced. Fixes: efe0220fc2d2 ("drm/rockchip: cdn-dp: Fix error handling") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c

[PATCH 2/3] drm/rockchip: vop: fix reference leak when pm_runtime_get_sync fails

it with pm_runtime_resume_and_get to keep usage counter balanced. Fixes: 5e570373c015 ("drm/rockchip: vop: Enable pm domain before vop_initial") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 3/3] drm/rockchip: lvds: fix reference leak when pm_runtime_get_sync fails

it with pm_runtime_resume_and_get to keep usage counter balanced. Fixes: cca1705c3d89 ("drm/rockchip: lvds: Add PX30 support") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/rockchip/rockchip_lvds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

[PATCH 0/3] drm/rockchip: fix reference leak when pm_runtime_get_sync fails

ot;PM: runtime: Add pm_runtime_resume_and_get to dealwith usage counter") Qinglang Miao (3): drm/rockchip: cdn-dp: fix reference leak when pm_runtime_get_sync fails drm/rockchip: vop: fix reference leak when pm_runtime_get_sync fails drm/rockchip: lvds: fix reference

[PATCH 2/8] i2c: img-scb: fix reference leak when pm_runtime_get_sync fails

it with pm_runtime_resume_and_get to keep usage counter balanced. Fixes: 93222bd9b966 ("i2c: img-scb: Add runtime PM") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/i2c/busses/i2c-img-scb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-img-scb.c

[PATCH 8/8] i2c: xiic: fix reference leak when pm_runtime_get_sync fails

to keep usage counter balanced. Fixes: 10b17004a74c ("i2c: xiic: Fix the clocking across bind unbind") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/i2c/busses/i2c-xiic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2

[PATCH 6/8] i2c: sprd: fix reference leak when pm_runtime_get_sync fails

it with pm_runtime_resume_and_get to keep usage counter balanced. Fixes: 8b9ec0719834 ("i2c: Add Spreadtrum I2C controller driver") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/i2c/busses/i2c-sprd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/

[PATCH 7/8] i2c: stm32f7: fix reference leak when pm_runtime_get_sync fails

it with pm_runtime_resume_and_get to keep usage counter balanced. Fixes: ea6dd25deeb5 ("i2c: stm32f7: add PM_SLEEP suspend/resume support") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/i2c/busses/i2c-stm32f7.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/d

[PATCH 3/8] i2c: imx-lpi2c: fix reference leak when pm_runtime_get_sync fails

usage counter balanced. Fixes: 13d6eb20fc79 ("i2c: imx-lpi2c: add runtime pm support") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/i2c/busses/i2c-imx-lpi2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/d

[PATCH 5/8] i2c: omap: fix reference leak when pm_runtime_get_sync fails

dc4 ("I2C: OMAP: Handle error check for pm runtime") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/i2c/busses/i2c-omap.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c in

[PATCH 4/8] i2c: imx: fix reference leak when pm_runtime_get_sync fails

to keep usage counter balanced. Fixes: 3a5ee18d2a32 ("i2c: imx: implement master_xfer_atomic callback") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/i2c/busses/i2c-imx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i

[PATCH 1/8] i2c: cadence: fix reference leak when pm_runtime_get_sync fails

it with pm_runtime_resume_and_get to keep usage counter balanced. Fixes: 7fa32329ca03 ("i2c: cadence: Move to sensible power management") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/i2c/busses/i2c-cadence.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH 0/8] i2c: fix reference leak when pm_runtime_get_sync fails

ot;PM: runtime: Add pm_runtime_resume_and_get to dealwith usage counter") Qinglang Miao (8): i2c: cadence: fix reference leak when pm_runtime_get_sync fails i2c: img-scb: fix reference leak when pm_runtime_get_sync fails i2c: imx-lpi2c: fix reference leak when pm_runtime_get_sync fails

Re: [PATCH] s390: cio: fix two use-after-free bugs in device.c

在 2020/11/20 15:55, Cornelia Huck 写道: On Fri, 20 Nov 2020 15:48:49 +0800 Qinglang Miao wrote: put_device calls release function which do kfree() inside. So following use of sch would cause use-after-free bugs. Fix these by simply adjusting the position of put_device. Fixes: 37db8985b211

[PATCH] s390: cio: fix use-after-free in ccw_device_destroy_console

Suggested-by: Cornelia Huck Signed-off-by: Qinglang Miao --- This patch is indeed a v2 of older one. Considering that the patch's name has changed, I think a normal prefix 'PATCH' is better. drivers/s390/cio/device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

Re: [PATCH] scsi: zfcp: fix use-after-free in zfcp_unit_remove

在 2020/11/27 17:21, Steffen Maier 写道: On 11/26/20 4:12 PM, Benjamin Block wrote: On Thu, Nov 26, 2020 at 08:07:32PM +0800, Qinglang Miao wrote: 在 2020/11/26 17:42, Benjamin Block 写道: On Thu, Nov 26, 2020 at 09:13:53AM +0100, Cornelia Huck wrote: On Thu, 26 Nov 2020 09:27:41 +0800 Qinglang

[PATCH v2] scsi: zfcp: move the position of put_device

-by: Steffen Maier Suggested-by: Benjamin Block Signed-off-by: Qinglang Miao --- v2: add comments after put_device as Steffen suggested. drivers/s390/scsi/zfcp_sysfs.c | 4 ++-- drivers/s390/scsi/zfcp_unit.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/s390

Re: [PATCH] gpio: zynq: fix reference leak in zynq_gpio functions

在 2020/12/1 0:44, Bartosz Golaszewski 写道: On Fri, Nov 27, 2020 at 10:40 AM Qinglang Miao wrote: pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in a reference leak here. A new function pm_runtime_resume_and_get is introduced

[PATCH 2/3] drm/rockchip: vop: fix reference leak when pm_runtime_get_sync fails

) Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index c80f7d9fd..006988

[PATCH 0/3] drm/rockchip: fix reference leak of pm_runtime_get_sync

Replace pm_runtime_get_sync with pm_runtime_resume_and_get to keep usage counter balanced. Qinglang Miao (3): drm/rockchip: cdn-dp: fix reference leak when pm_runtime_get_sync fails drm/rockchip: vop: fix reference leak when pm_runtime_get_sync fails drm/rockchip: lvds: fix reference

[PATCH 3/3] drm/rockchip: lvds: fix reference leak when pm_runtime_get_sync fails

Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/rockchip/rockchip_lvds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/rockchip/rockchip_lvds.c index f292c6a6e..c3b1ac484 100644 --- a/drivers/gpu/dr

[PATCH 1/3] drm/rockchip: cdn-dp: fix reference leak when pm_runtime_get_sync fails

d-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c index a4a45daf9..9b4406191 100644 --- a/drivers/gpu/drm/rockc

Re: [PATCH] hwrng: exynos - fix reference leak in exynos_trng_probe

在 2020/11/27 22:26, Lukasz Stelmach 写道: It was <2020-11-27 pią 17:44>, when Qinglang Miao wrote: pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in a reference leak here. A new function pm_runtime_resume_and_get is intr

Re: [PATCH] hwrng: exynos - fix reference leak in exynos_trng_probe

在 2020/11/27 17:44, Krzysztof Kozlowski 写道: On Fri, Nov 27, 2020 at 05:44:46PM +0800, Qinglang Miao wrote: pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in a reference leak here. A new function pm_runtime_resume_and_get

[PATCH v2] hwrng: exynos - fix reference leak in exynos_trng_probe

msung Exynos True RNG driver") Reported-by: Hulk Robot Suggested-by: Lukasz Stelmach Signed-off-by: Qinglang Miao --- v2: remobe useless label as Lukasz suggested. drivers/char/hw_random/exynos-trng.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/dr

Re: [PATCH] drm/panfrost: fix reference leak in panfrost_job_hw_submit

在 2020/11/27 18:06, Steven Price 写道: On 27/11/2020 09:44, Qinglang Miao wrote: pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in a reference leak here. A new function pm_runtime_resume_and_get is introduced in [0] to keep

[PATCH] scsi: zfcp: move the position of put_device

Have the `put_device()` call after `device_unregister()` in both `zfcp_unit_remove()` and `zfcp_sysfs_port_remove_store()` to make it more natural, for put_device() ought to be the last time we touch the object in both functions. Suggested-by: Benjamin Block Signed-off-by: Qinglang Miao

[PATCH] scsi: zfcp: move the position of put_device

Have the `put_device()` call after `device_unregister()` in both `zfcp_unit_remove()` and `zfcp_sysfs_port_remove_store()` to make it more natural, for put_device() ought to be the last time we touch the object in both functions. Suggested-by: Benjamin Block Signed-off-by: Qinglang Miao

Re: [PATCH 2/3] powerpc/pseries/hotplug-cpu: fix memleak in dlpar_cpu_add_by_count

在 2020/11/30 9:51, Michael Ellerman 写道: Qinglang Miao writes: kfree(cpu_drcs) should be called when it fails to perform of_find_node_by_path("/cpus") in dlpar_cpu_add_by_count, otherwise there would be a memleak. In fact, the patch a0ff72f9f5a7 ought to re

[PATCH 1/3] dm ioctl: fix error return code in target_message

Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 2ca4c92f58f9 ("dm ioctl: prevent empty message") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/md/dm-ioctl.c | 1 + 1 file changed, 1 insertio

[PATCH 3/3] media: xilinx: fix error return code in xvip_graph_init

Fix to return a negative error code(-ENODEV) from the error handling case instead of 0, as done elsewhere in this function. Fixes: df3305156f98 ("[media] v4l: xilinx: Add Xilinx Video IP core") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/media/platform/xilinx/xil

[PATCH 2/3] powerpc/pseries/hotplug-cpu: fix memleak in dlpar_cpu_add_by_count

here might be a mistake when apply that one. Fixes: a0ff72f9f5a7 ("powerpc/pseries/hotplug-cpu: Remove double free in error path") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- arch/powerpc/platforms/pseries/hotplug-cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/power

[PATCH 1/3] crypto: sun4i - fix reference leak in sun4i-ss

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c | 2 +- drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c | 2 +- drivers/crypto

[PATCH 2/3] crypto: sun8i - fix reference leak in sun8i-ce

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto

[PATCH 3/3] crypto: sun8i - fix reference leak in sun8i-ss

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c | 2 +- drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 2 +- 2 files

[PATCH 0/3] crypto: sun - fix reference leak

pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in a reference leak here. Use pm_runtime_resume_and_get to fix it. Qinglang Miao (3): crypto: sun4i - fix reference leak in sun4i-ss crypto: sun8i - fix reference leak in sun8i-ce

[PATCH 1/2] crypto: stm32/cryp - fix reference leak in stm32_cryp_remove

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: 65f9aa36ee47 ("crypto: stm32/cryp - Add power management support") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/crypto/stm32/stm32-cryp.c | 2 +- 1 file

[PATCH 0/2] crypto: stm32 - fix reference leak

pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in a reference leak here. Use pm_runtime_resume_and_get to fix it. Qinglang Miao (2): crypto: stm32/cryp - fix reference leak in stm32_cryp_remove crypto: stm32/hash - fix

[PATCH 2/2] crypto: stm32/hash - fix reference leak in stm32_hash_remove

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: 8b4d566de6a5 ("crypto: stm32/hash - Add power management support") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/crypto/stm32/stm32-hash.c | 2 +- 1 file

[PATCH] dmaengine: tegra-apb: fix reference leak in tegra_dma_issue_pending and tegra_dma_synchronize

g of DMA synchronization") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/dma/tegra20-apb-dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c index 71827d9b0..b7260749e 100644 --- a/drivers/dma/t

[PATCH 3/3] dmaengine: stm32-mdma: fix reference leak in stm32-mdma

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: 7cb819c856d9 ("dmaengine: stm32-mdma: add suspend/resume power management support") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/dma/stm32-mdma.c | 4 ++-

[PATCH 2/3] dmaengine: stm32-dmamux: fix reference leak in stm32_dmamux

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: f65c2e14b096 ("dmaengine: stm32-dmamux: add suspend/resume power management support") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/dma/stm32-dmamux.c | 6 ++

[PATCH 0/3] dmaengine: stm32: fix reference leak

pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in a reference leak here. Use pm_runtime_resume_and_get to fix it. Qinglang Miao (3): dmaengine: stm32-dma: fix reference leak in stm32_dma dmaengine: stm32-dmamux: fix reference

[PATCH 1/3] dmaengine: stm32-dma: fix reference leak in stm32_dma

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: 05f8740a0e6f ("dmaengine: stm32-dma: add suspend/resume power management support") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/dma/stm32-dma.c | 4 ++-

[PATCH] dmaengine: sprd: fix reference leak in sprd_dma_probe and sprd_dma_remove

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: 9b3b8171f7f4 ("dmaengine: sprd: Add Spreadtrum DMA driver") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/dma/sprd-dma.c | 4 ++-- 1 file changed, 2 insert

[PATCH] drm/panfrost: fix reference leak in panfrost_job_hw_submit

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: f3ba91228e8e ("drm/panfrost: Add initial panfrost driver") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/panfrost/panfrost_job.c | 2 +- 1 file change

[PATCH] drm/mediatek: fix reference leak in mtk_crtc_ddp_hw_init

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +

[PATCH] drm/lima: fix reference leak in lima_pm_busy

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: 50de2e9ebbc0 ("drm/lima: enable runtime pm") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/lima/lima_sched.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH] gpio: zynq: fix reference leak in zynq_gpio functions

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: c2df3de0d07e ("gpio: zynq: properly support runtime PM for GPIO used as interrupts") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpio/gpio-zynq.c | 4 ++-

[PATCH] drm/bridge: cdns: fix reference leak in cdns_dsi_transfer

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/bridge/cdns-dsi.c | 2 +- 1 file changed, 1 inse

[PATCH] hwrng: exynos - fix reference leak in exynos_trng_probe

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: 6cd225cc5d8a ("hwrng: exynos - add Samsung Exynos True RNG driver") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/char/hw_random/exynos-trng.c | 2 +- 1 file

[PATCH] drm: rcar-du: fix reference leak in amdgpu_debugfs_gfxoff_read

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: e08e934d6c28 ("drm: rcar-du: Add support for CMM") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +- 1 file change

[PATCH] drm: rcar-du: fix reference leak in rcar_cmm_enable

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: e08e934d6c28 ("drm: rcar-du: Add support for CMM") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/rcar-du/rcar_cmm.c | 2 +- 1 file changed, 1 inse

[PATCH] drm: bridge: cdns-mhdp8546: fix reference leak in cdns_mhdp_probe

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: fb43aa0acdfd ("drm: bridge: Add support for Cadence MHDP8546 DPI/DP bridge") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/bridge/cadence/cdns-mhdp8

[PATCH] dmaengine: usb-mac: fix reference leak in usb_dmac_probe

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: 0c1c8ff32fa2 ("dmaengine: usb-dmac: Add Renesas USB DMA Controller (USB-DMAC) driver") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/dma/sh/usb-dmac.c | 2 +

[PATCH] dmaengine: zynqmp_dma: fix reference leak in zynqmp_dma_alloc_chan_resources

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: 64c6f7da8c2c ("dmaengine: zynqmp_dma: Add runtime pm support") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/dma/xilinx/zynqmp_dma.c | 2 +- 1 file change

[PATCH] dmaengine: rcar-dmac: fix reference leak in rcar_dmac_probe

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: 87244fe5abdf ("dmaengine: rcar-dmac: Add Renesas R-Car Gen2 DMA Controller (DMAC) driver") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/dma/sh/rcar-d

[PATCH] crypto: sa2ul - fix reference leak in sa_ul_probe()

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/crypto/sa2ul.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH] drm/dev: Fix NULL pointer dereference in drm_minor_alloc

92b ("drm: manage drm_minor cleanup with drmm_") Signed-off-by: Qinglang Miao --- drivers/gpu/drm/drm_drv.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index cd162d406..c253d3cd4 100644 --- a/driver

Re: [PATCH] scsi: zfcp: fix use-after-free in zfcp_unit_remove

在 2020/11/26 17:42, Benjamin Block 写道: On Thu, Nov 26, 2020 at 09:13:53AM +0100, Cornelia Huck wrote: On Thu, 26 Nov 2020 09:27:41 +0800 Qinglang Miao wrote: 在 2020/11/26 1:06, Benjamin Block 写道: On Fri, Nov 20, 2020 at 03:48:54PM +0800, Qinglang Miao wrote: kfree(port) is called

Re: [PATCH] xfs: check the return value of krealloc() in xfs_uuid_mount

在 2020/11/26 10:16, Gao Xiang 写道: Hi Qinglang, On Thu, Nov 26, 2020 at 09:21:11AM +0800, Qinglang Miao wrote: 在 2020/11/25 23:55, Eric Sandeen 写道: On 11/25/20 12:50 AM, Qinglang Miao wrote: krealloc() may fail to expand the memory space. Even with __GFP_NOFAIL? * ``GFP_KERNEL

Re: [PATCH] scsi: zfcp: fix use-after-free in zfcp_unit_remove

在 2020/11/26 1:06, Benjamin Block 写道: On Fri, Nov 20, 2020 at 03:48:54PM +0800, Qinglang Miao wrote: kfree(port) is called in put_device(>dev) so that following use would cause use-after-free bug. The former put_device is redundant for device_unregister contains put_device already. So j

Re: [PATCH] xfs: check the return value of krealloc() in xfs_uuid_mount

在 2020/11/25 23:55, Eric Sandeen 写道: On 11/25/20 12:50 AM, Qinglang Miao wrote: krealloc() may fail to expand the memory space. Even with __GFP_NOFAIL? * ``GFP_KERNEL | __GFP_NOFAIL`` - overrides the default allocator behavior and all allocation requests will loop endlessly until

Re: [PATCH] fpga: dfl: add missing platform_device_put in build_info_create_dev

're right Hao. build_info_create_dev is performed in parse_feature_list which follows build_info_free. So please ignore this patch. Thanks! Fixes: 543be3d8c999 ("fpga: add device feature list support") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/f

[PATCH] soc: qcom: pdr: Fix error return code in pdr_register_listener

Fix to return the error code -EREMOTEIO from pdr_register_listener rather than 0. Fixes: fbe639b44a82 ("soc: qcom: Introduce Protection Domain Restart helpers") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/soc/qcom/pdr_interface.c | 1 + 1 file changed, 1 insertio

[PATCH] soundwire: Fix error return code in sdw_compute_port_params

Fix to return the error code -EINVAL in sdw_compute_port_params instead of 0. Fixes: 9026118f20e2 ("soundwire: Add generic bandwidth allocation algorithm") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/soundwire/generic_bandwidth_allocation.c | 4 +++- 1 file

[PATCH] platform/x86: dell-smbios-base: Fix error return code in dell_smbios_init

Fix to return the error code -ENODEV when fails to init wmi and smm. Fixes: 41e36f2f85af ("platform/x86: dell-smbios: Link all dell-smbios-* modules together") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/platform/x86/dell-smbios-base.c | 1 + 1 file changed, 1

[PATCH] fpga: dfl: add missing platform_device_put in build_info_create_dev

platform_device_put is missing when it fails to set fdev->id. Set a temp value to do sanity check. Fixes: 543be3d8c999 ("fpga: add device feature list support") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/fpga/dfl.c | 9 ++--- 1 file changed, 6 ins

[PATCH] xfs: check the return value of krealloc() in xfs_uuid_mount

krealloc() may fail to expand the memory space. Add sanity checks to it, and WARN() if that really happened. Fixes: 771915c4f688 ("xfs: remove kmem_realloc()") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- fs/xfs/xfs_mount.c | 6 +- 1 file changed, 5 insertions(+),

[PATCH] scsi: aic94xx: Fix error return code in asd_process_ms

Fix to return the error code -EINVAL when size == 0 after asd_find_flash_de instead of zero. Fixes: 2908d778ab3e ("[SCSI] aic94xx: new driver") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/scsi/aic94xx/aic94xx_sds.c | 8 ++-- 1 file changed, 6 insertions(+), 2

[PATCH] s390: cmf: fix use-after-free in enable_cmf

e in cmb processing") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/s390/cio/cmf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/s390/cio/cmf.c b/drivers/s390/cio/cmf.c index 72dd2471e..e95ca476f 100644 --- a/drivers/s390/cio/cmf.c +++ b/dri

[PATCH] PCI: fix use-after-free in pci_register_host_bridge

When put_device(>dev) being called, kfree(bridge) is inside of release function, so the following device_del would cause a use-after-free bug. Fixes: 37d6a0a6f470 ("PCI: Add pci_register_host_bridge() interface") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/pc

[PATCH] memstick: fix a double-free bug in memstick_check

kfree(host->card) has been called in put_device so that another kfree would raise cause a double-free bug. Fixes: 0193383a5833 ("memstick: core: fix device_register() error handling") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/memstick/core/memstick.c

[PATCH] s390: cio: fix two use-after-free bugs in device.c

o: fix unlocked access of online member") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/s390/cio/device.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/s390/cio/device.c b/drivers/s390/cio/device.c index b29fe8d50..69492417b 100644 --

[PATCH] scsi: zfcp: fix use-after-free in zfcp_unit_remove

ot;) Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/s390/scsi/zfcp_unit.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/s390/scsi/zfcp_unit.c b/drivers/s390/scsi/zfcp_unit.c index e67bf7388..664b77853 100644 --- a/drivers/s390/scsi/zfcp_unit.c +++ b/drivers/s390/scs

[PATCH] scsi: zfcp: fix use-after-free in zfcp_sysfs_port_remove_store

ot;) Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/s390/scsi/zfcp_sysfs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/s390/scsi/zfcp_sysfs.c b/drivers/s390/scsi/zfcp_sysfs.c index 8d9662e8b..06285e452 100644 --- a/drivers/s390/scsi/zfcp_sysfs.c +++ b/driv

[PATCH] mips: cdmm: fix use-after-free in mips_cdmm_bus_discover

kfree(dev) has been called inside put_device so anther kfree would cause a use-after-free bug/ Fixes: 8286ae03308c ("MIPS: Add CDMM bus support") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/bus/mips_cdmm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/d

[PATCH] scsi: iscsi: fix inappropriate use of put_device

Robot Signed-off-by: Qinglang Miao --- drivers/scsi/scsi_transport_iscsi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c index 2eb3e4f93..2e68c0a87 100644 --- a/drivers/scsi/scsi_transport_iscsi.c

[PATCH] drivers: visorbus: fix use-after free bugs

use device_unregister contains put_device already. Fixes: 93d3ad90c2d4 ("drivers: visorbus: move driver out of staging") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/visorbus/visorbus_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dri

Re: [PATCH] leds: lp50xx: add missing fwnode_handle_put in error handling case

在 2020/11/11 21:27, Dan Murphy 写道: Hello On 11/10/20 9:21 PM, Qinglang Miao wrote: Fix to goto child_out to do fwnode_handle_put(child) from the error handling case rather than simply return, as done elsewhere in this function. Fixes: 242b81170fb8 ("leds: lp50xx: Add the LP50XX f

[PATCH] stm class: Fix a double vfree in stm_register_device()

Fix this problem by simply return err after put_device(). Fixes: b5e2ced9bf81 ("stm class: Use vmalloc for the master map") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/hwtracing/stm/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/hwtracing

[PATCH] ipmi: msghandler: Suppress suspicious RCU usage warning

RIP: 0033:0x468ded - It is safe because smi_watchers_mutex is locked and srcu_read_lock has been used, so simply pass lockdep_is_held() to the list_for_each_entry_rcu() to suppress this warning. Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/char/ipmi/ipmi_msghandler.c

[PATCH v2] leds: lp50xx: add missing fwnode_handle_put in error handling case

ek Signed-off-by: Qinglang Miao --- v2: forget to set ret on v1 drivers/leds/leds-lp50xx.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c index 5fb4f24ae..f13117eed 100644 --- a/drivers/leds/leds-lp50xx.c +++ b/dr

[PATCH] net: cw1200: fix missing destroy_workqueue() on error in cw1200_init_common

Add the missing destroy_workqueue() before return from cw1200_init_common in the error handling case. Fixes:a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/net/wireless/st/cw1200/ma

[PATCH] samples: vfio-mdev: fix return value of error branch in mdpy_fb_probe()

pci_release_regions() should be called in these error branches, so I set ret and use goto err_release_regions intead of simply return -EINVAL. Fixes: cacade1946a4 ("sample: vfio mdev display - guest driver") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- samples/vfio-mdev

  1   2   3   4   >