The first two parameters should be reduced to one, as @tr is simply
@dir->tr.
Signed-off-by: Qiujun Huang
---
kernel/trace/trace_events_filter.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/kernel/trace/trace_events_filter.c
b/kernel/trace/trace_events_filte
commit f306cc82a93d ("tracing: Update event filters for multibuffer")
added the parameter @tr for create_system_filter().
commit bb9ef1cb7d86 ("tracing: Change apply_subsystem_event_filter()
paths to
check file->system == dir")
changed the parameter from @system to @dir.
On Thu, Mar 25, 2021 at 8:56 AM Steven Rostedt wrote:
>
> On Sat, 20 Mar 2021 11:39:16 +0000
> Qiujun Huang wrote:
>
> > commit f306cc82a93d ("tracing: Update event filters for multibuffer")
> > added the parameter @tr for create_system_filter().
> >
&
r.
commit 1e144d73f729 ("tracing: Add trace_array parameter to
create_event_filter()")
added the parameter @tr for create_filter().
Signed-off-by: Qiujun Huang
---
kernel/trace/trace_events_filter.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/trac
We should compile this driver only if we enable PHY_INGENIC_USB.
Signed-off-by: Qiujun Huang
---
v2:
Add a Fixes:tag and Cc linux-stable
---
drivers/phy/ingenic/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/ingenic/Makefile b/drivers/phy/ingenic
We should compile this driver only if we opened PHY_INGENIC_USB.
Signed-off-by: Qiujun Huang
---
drivers/phy/ingenic/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/ingenic/Makefile b/drivers/phy/ingenic/Makefile
index 65d5ea00fc9d..a00306651423 100644
Update kernel-doc parameter after
commit b3b1e6ededa4 ("ftrace: Create set_ftrace_notrace_pid to not trace
tasks")
added @filtered_no_pids.
Signed-off-by: Qiujun Huang
---
kernel/trace/trace.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/trace/trace.
s/raw_processor_id/raw_smp_processor_id/
Signed-off-by: Qiujun Huang
---
include/linux/smp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/smp.h b/include/linux/smp.h
index 70c6f6284dcf..081a9d98e1e3 100644
--- a/include/linux/smp.h
+++ b/include/linux/smp.h
Since commit b6f11df26fdc ("trace: Call tracing_reset_online_cpus before
tracer->init()"), get/put_cpu() are not needed anymore.
We can use raw_smp_processor_id() instead.
Signed-off-by: Qiujun Huang
---
v2:
Use raw_smp_processor_id() instead of smp_processor_id()
---
Sorry, please ignore the patch
[trace] 2158a32526: BUG:using_smp_processor_id()in_preemptible
Thanks
On Fri, Dec 25, 2020 at 10:24 PM Qiujun Huang wrote:
>
> Since commit b6f11df26fdc ("trace: Call tracing_reset_online_cpus before
> tracer->init()"), get/put_cpu() are no
Since commit b6f11df26fdc ("trace: Call tracing_reset_online_cpus before
tracer->init()"), get/put_cpu() are not needed anymore.
We can use smp_processor_id() instead.
Signed-off-by: Qiujun Huang
---
kernel/trace/trace_functions.c | 3 +--
1 file changed, 1 insertion(+), 2 delet
The cpu_buffer argument is not used inside the rb_inc_page() after
commit 3adc54fa82a6 ("ring-buffer: make the buffer a true circular link
list").
And cpu_buffer argument is not used inside the two functions too,
rb_is_head_page/rb_set_list_to_head.
Signed-off-by: Qiujun Huang
---
ke
Remove the cpumask check, as we has done it at the beginning of
the function.
Also fix a typo. s/also the on the/also on the/
Signed-off-by: Qiujun Huang
---
kernel/trace/ring_buffer.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/kernel/trace/ring_buffer.c b/kernel
The following commit has been merged into the x86/cleanups branch of tip:
Commit-ID: 72ebb5ff806f9a421a2a53cdfe6c4ebbab243bd5
Gitweb:
https://git.kernel.org/tip/72ebb5ff806f9a421a2a53cdfe6c4ebbab243bd5
Author:Qiujun Huang
AuthorDate:Thu, 03 Dec 2020 22:50:20 +08:00
The function changed at some point, but the description was not
updated.
Signed-off-by: Qiujun Huang
---
arch/x86/kernel/alternative.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
index 2400ad62f330
s/ring_buffer_commit_discard/ring_buffer_discard_commit/
Signed-off-by: Qiujun Huang
---
kernel/trace/ring_buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index dc83b3fa9fe7..27a7caf4e203 100644
--- a/kernel
The array size is FTRACE_KSTACK_NESTING, so the index FTRACE_KSTACK_NESTING
is illegal too. And fix two typos by the way.
Signed-off-by: Qiujun Huang
---
kernel/trace/trace.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
The subscript should be nesting - 1, as nesting had self-added.
Fixes: 3d9622c12c887 ("tracing: Add barrier to trace_printk() buffer nesting
modification")
Signed-off-by: Qiujun Huang
---
v4:
Find the right patch which cause the problem.
v3:
Modify the way of array reference instea
The subscript should be nesting - 1, as nesting had self-added.
Fixes: e2ace001176dc ("tracing: Choose static tp_printk buffer by explicit
nesting count")
Signed-off-by: Qiujun Huang
---
v3:
Modify the way of array reference instead.
v2:
Fix a typo in the title.
---
kernel/trace/t
The boundary condition should be 3 as we access
buffer[buffer->nesting][0].
Fixes: e2ace001176dc ("tracing: Choose static tp_printk buffer by explicit
nesting count")
Signed-off-by: Qiujun Huang
---
v2:
Fix a typo in the title.
---
kernel/trace/trace.c | 2 +-
1 file changed, 1 in
The boundary condition should be 3 as we access
buffer[buffer->nesting][0].
Fixes: e2ace001176dc ("tracing: Choose static tp_printk buffer by explicit
nesting count")
Signed-off-by: Qiujun Huang
---
kernel/trace/trace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
/heuristic/
s/assocated/associated/
s/otherwides/otherwise/
s/specfied/specified/
s/seaching/searching/
s/hierachry/hierarchy/
s/internel/internal/
s/Thise/This/
Signed-off-by: Qiujun Huang
---
kernel/trace/blktrace.c| 4 ++--
kernel/trace/bpf_trace.c | 2 +-
kernel/trace
trace_buf->data, cpu_id)->entries =
per_cpu_ptr(size_buf->data, cpu_id)->entries;
...
Signed-off-by: Qiujun Huang
---
kernel/trace/ring_buffer.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/trace/ring_buffer.c b/kernel/trac
The function changed at some point, but the description was not
updated.
Signed-off-by: Qiujun Huang
---
kernel/trace/ring_buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index b2c6f2546d69..598c388d6436 100644
It may be better to check each page is aligned by 4 bytes. The 2
least significant bits of the address will be used as flags.
Signed-off-by: Qiujun Huang
---
v2:
remove passing the int cpu to __rb_allocate_pages.
---
kernel/trace/ring_buffer.c | 19 +++
1 file changed, 11
On Thu, Oct 15, 2020 at 12:11 AM Steven Rostedt wrote:
>
> On Wed, 14 Oct 2020 23:48:05 +0800
> Qiujun Huang wrote:
>
> > On Wed, Oct 14, 2020 at 11:38 PM Steven Rostedt wrote:
> > >
> > > On Wed, 14 Oct 2020 23:16:14 +0800
> > > Qiujun Huang wrote:
On Wed, Oct 14, 2020 at 11:38 PM Steven Rostedt wrote:
>
> On Wed, 14 Oct 2020 23:16:14 +0800
> Qiujun Huang wrote:
>
> > It may be better to check each page is aligned by 4 bytes. The 2
> > least significant bits of the address will be used as flags.
> >
&
s/inerrupting/interrupting/
s/beween/between/
Signed-off-by: Qiujun Huang
---
kernel/trace/ring_buffer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index 93ef0ab6ea20..87bfc59679fb 100644
--- a/kernel/trace
It may be better to check each page is aligned by 4 bytes. The 2
least significant bits of the address will be used as flags.
Signed-off-by: Qiujun Huang
---
kernel/trace/ring_buffer.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/kernel/trace/ring_buffer.c b
s/wihin/within/
s/retrieven/retrieved/
s/suppport/support/
s/wil/will/
s/accidently/accidentally/
s/if the if the/if the/
Signed-off-by: Qiujun Huang
---
kernel/trace/trace.c | 4 ++--
kernel/trace/trace.h | 8
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/kernel/trace
s/coorditate/coordinate/
s/emty/empty/
s/preeptive/preemptive/
s/succes/success/
s/carefule/careful/
Signed-off-by: Qiujun Huang
---
kernel/trace/ftrace.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index
The following commit has been merged into the locking/kcsan branch of tip:
Commit-ID: e7b34100500733f7e052ce3dee94e6338b86e6bc
Gitweb:
https://git.kernel.org/tip/e7b34100500733f7e052ce3dee94e6338b86e6bc
Author:Qiujun Huang
AuthorDate:Thu, 05 Mar 2020 15:21:07 +01:00
On Sat, Sep 21, 2019 at 9:19 AM John Hubbard wrote:
>
> On 9/20/19 5:33 PM, Qiujun Huang wrote:
> >> On 9/20/19 8:51 AM, Qiujun Huang wrote:
> ...
> >> It would be nice if this spelled out a little more clearly what's
> >> wrong. I think you and Aneesh
>On 9/20/19 8:51 AM, Qiujun Huang wrote:
>> __get_user_pages_fast try to walk the page table but the
>> hugepage pte is replace by hwpoison swap entry by mca path.
>
>I expect you mean MCE (machine check exception), rather than mca?
Yeah
>
>> ...
>> [15798.1774
: [] gup_pud_range+
0x13e/0x1e0
...
We need to skip the hwpoison entry in gup_pud_range.
Signed-off-by: Qiujun Huang
---
mm/gup.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/mm/gup.c b/mm/gup.c
index 98f13ab..6157ed9 100644
--- a/mm/gup.c
+++ b/mm/gup.c
3aebda
#9 [880006823650] scrup at 81442600
...
the cpu23 wait for the same blk queue_lock
Signed-off-by: Qiujun Huang
---
drivers/tty/vt/vt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
index 34aa39d..cd32d66 100644
--- a/drivers/tty/vt/
36 matches
Mail list logo
