Re: [PATCH v3 1/4] dt-bindings: mfd: Add bindings for Ampere Altra SMPro drivers

On 14/04/2021 15:28, Quan Nguyen wrote: On 13/04/2021 20:49, Rob Herring wrote: On Fri, Apr 09, 2021 at 10:13:29AM +0700, Quan Nguyen wrote: Adds device tree bindings for SMPro drivers found on the Mt.Jade hardware reference platform with Ampere's Altra Processor family. Signed-off-by: Quan

Re: [PATCH v3 2/4] mfd: simple-mfd-i2c: Adds Ampere's Altra SMpro support

On 14/04/2021 19:21, Guenter Roeck wrote: On Fri, Apr 09, 2021 at 10:13:30AM +0700, Quan Nguyen wrote: Adds an MFD driver for SMpro found on the Mt.Jade hardware reference platform with Ampere's Altra processor family. Signed-off-by: Quan Nguyen Reported-by: kernel test robot --- drivers

Re: [PATCH v3 3/4] hwmon: smpro: Add Ampere's Altra smpro-hwmon driver

On 14/04/2021 19:33, Guenter Roeck wrote: On Fri, Apr 09, 2021 at 10:13:31AM +0700, Quan Nguyen wrote: This commit adds support for Ampere SMpro hwmon driver. This driver supports accessing various CPU sensors provided by the SMpro co-processor including temperature, power, voltages

Re: [PATCH v3 1/4] dt-bindings: mfd: Add bindings for Ampere Altra SMPro drivers

On 13/04/2021 20:49, Rob Herring wrote: On Fri, Apr 09, 2021 at 10:13:29AM +0700, Quan Nguyen wrote: Adds device tree bindings for SMPro drivers found on the Mt.Jade hardware reference platform with Ampere's Altra Processor family. Signed-off-by: Quan Nguyen --- .../bindings/hwmon/ampere

[PATCH v3 4/4] docs: hwmon: (smpro-hwmon) Add documentation

Add documentation for the Ampere(R)'s Altra(R) SMpro hwmon driver. Signed-off-by: Thu Nguyen Signed-off-by: Quan Nguyen --- Documentation/hwmon/index.rst | 1 + Documentation/hwmon/smpro-hwmon.rst | 101 2 files changed, 102 insertions(+) create mode

[PATCH v3 3/4] hwmon: smpro: Add Ampere's Altra smpro-hwmon driver

This commit adds support for Ampere SMpro hwmon driver. This driver supports accessing various CPU sensors provided by the SMpro co-processor including temperature, power, voltages, and current. Signed-off-by: Quan Nguyen --- drivers/hwmon/Kconfig | 8 + drivers/hwmon/Makefile

[PATCH v3 2/4] mfd: simple-mfd-i2c: Adds Ampere's Altra SMpro support

Adds an MFD driver for SMpro found on the Mt.Jade hardware reference platform with Ampere's Altra processor family. Signed-off-by: Quan Nguyen --- drivers/mfd/Kconfig | 10 ++ drivers/mfd/simple-mfd-i2c.c | 6 ++ 2 files changed, 16 insertions(+) diff --git a/drivers/mfd

[PATCH v3 1/4] dt-bindings: mfd: Add bindings for Ampere Altra SMPro drivers

Adds device tree bindings for SMPro drivers found on the Mt.Jade hardware reference platform with Ampere's Altra Processor family. Signed-off-by: Quan Nguyen --- .../bindings/hwmon/ampere,ac01-hwmon.yaml | 28 + .../devicetree/bindings/mfd/ampere,smpro.yaml | 105 ++ 2

[PATCH v3 0/4] Add Ampere's Altra SMPro hwmon driver

sary error message when dev register fail [Guenter] + Removed Socket TDP sensor [Quan] + Changed "ampere,ac01-smpro" to "ampere,smpro" [Quan] + Included sensor type and channel in labels [Quan] + Refactorized code to fix checkpatch.pl --strict complaint [Quan] Quan Nguyen

Re: [PATCH v2 3/4] hwmon: smpro: Add Ampere's Altra smpro-hwmon driver

On 07/04/2021 19:11, Guenter Roeck wrote: On 4/7/21 12:41 AM, Quan Nguyen wrote: [ ... ] But then why don't you just use reg_ext to store SOC_VR_HOT_THRESHOLD_REG or MEM_HOT_THRESHOLD_REG ? It is already available, after all, and with it the code could be simplified to     ret

Re: [PATCH v2 0/3] Add Aspeed SSIF BMC driver

Hi Corey, Thank you for reviewing I'll put my respond inline below. -Quan On 02/04/2021 21:21, Corey Minyard wrote: On Tue, Mar 30, 2021 at 09:10:26PM +0700, Quan Nguyen wrote: This series add support for the Aspeed specific SSIF BMC driver which is to perform in-band IPMI communication

Re: [PATCH v2 1/4] dt-bindings: mfd: Add bindings for Ampere Altra SMPro drivers

Hi Rob, Thank you for reviewing On 31/03/2021 04:14, Rob Herring wrote: On Mon, Mar 29, 2021 at 08:52:35AM +0700, Quan Nguyen wrote: Adds device tree bindings for SMPro drivers found on the Mt.Jade hardware reference platform with Ampere's Altra Processor family. Signed-off-by: Quan Nguyen

Re: [PATCH v2 3/4] hwmon: smpro: Add Ampere's Altra smpro-hwmon driver

On 30/03/2021 08:43, Guenter Roeck wrote: On 3/28/21 6:52 PM, Quan Nguyen wrote: This commit adds support for Ampere SMpro hwmon driver. This driver supports accessing various CPU sensors provided by the SMpro co-processor including temperature, power, voltages, and current. Signed-off

Re: [PATCH v2 2/3] drivers: char: ipmi: Add Aspeed SSIF BMC driver

On 02/04/2021 19:01, Philipp Zabel wrote: Hi Quan, On Tue, Mar 30, 2021 at 09:10:28PM +0700, Quan Nguyen wrote: The SMBus system interface (SSIF) IPMI BMC driver can be used to perform in-band IPMI communication with their host in management (BMC) side. This commits adds support specifically

Re: [PATCH v1 2/3] drivers: char: ipmi: Add Aspeed SSIF BMC driver

On 31/03/2021 14:21, Joel Stanley wrote: On Mon, 29 Mar 2021 at 12:18, Quan Nguyen wrote: The SMBus system interface (SSIF) IPMI BMC driver can be used to perform in-band IPMI communication with their host in management (BMC) side. This commits adds support specifically for Aspeed AST2500

Re: [PATCH v2 3/3] bindings: ipmi: Add binding for Aspeed SSIF BMC driver

On 02/04/2021 00:09, Rob Herring wrote: On Tue, Mar 30, 2021 at 09:10:29PM +0700, Quan Nguyen wrote: Add device tree binding document for the Aspeed SSIF BMC driver. Signed-off-by: Quan Nguyen --- .../bindings/ipmi/aspeed-ssif-bmc.txt | 18 ++ 1 file changed, 18

[PATCH v2 3/3] bindings: ipmi: Add binding for Aspeed SSIF BMC driver

Add device tree binding document for the Aspeed SSIF BMC driver. Signed-off-by: Quan Nguyen --- .../bindings/ipmi/aspeed-ssif-bmc.txt | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 Documentation/devicetree/bindings/ipmi/aspeed-ssif-bmc.txt diff --git

[PATCH v2 2/3] drivers: char: ipmi: Add Aspeed SSIF BMC driver

The SMBus system interface (SSIF) IPMI BMC driver can be used to perform in-band IPMI communication with their host in management (BMC) side. This commits adds support specifically for Aspeed AST2500 which commonly used as Board Management Controllers. Signed-off-by: Quan Nguyen --- drivers

[PATCH v2 1/3] i2c: i2c-core-smbus: Expose PEC calculate function for generic use

Expose the PEC calculation i2c_smbus_pec() for generic use. Signed-off-by: Quan Nguyen --- drivers/i2c/i2c-core-smbus.c | 12 ++-- include/linux/i2c.h | 1 + 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/i2c-core-smbus.c b/drivers/i2c/i2c-core

[PATCH v2 0/3] Add Aspeed SSIF BMC driver

This series add support for the Aspeed specific SSIF BMC driver which is to perform in-band IPMI communication with the host in management (BMC) side. v2: + Fixed compiling error with COMPILE_TEST for arc Quan Nguyen (3): i2c: i2c-core-smbus: Expose PEC calculate function for generic use

Re: [PATCH v1 0/3] Add Aspeed SSIF BMC driver

Please ignore this series as I have missed an important audience. Going to resend another series. My apology. - Quan On 29/03/2021 19:09, Quan Nguyen wrote: This series add support for the Aspeed specific SSIF BMC driver which is to perform in-band IPMI communication with the host

[PATCH v1 3/3] bindings: ipmi: Add binding for Aspeed SSIF BMC driver

Add device tree binding document for the Aspeed SSIF BMC driver. Signed-off-by: Quan Nguyen --- .../bindings/ipmi/aspeed-ssif-bmc.txt | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 Documentation/devicetree/bindings/ipmi/aspeed-ssif-bmc.txt diff --git

[PATCH v1 2/3] drivers: char: ipmi: Add Aspeed SSIF BMC driver

The SMBus system interface (SSIF) IPMI BMC driver can be used to perform in-band IPMI communication with their host in management (BMC) side. This commits adds support specifically for Aspeed AST2500 which commonly used as Board Management Controllers. Signed-off-by: Quan Nguyen --- drivers

[PATCH v1 1/3] i2c: i2c-core-smbus: Expose PEC calculate function for generic use

Expose the PEC calculation i2c_smbus_pec() for generic use. Signed-off-by: Quan Nguyen --- drivers/i2c/i2c-core-smbus.c | 12 ++-- include/linux/i2c.h | 1 + 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/i2c-core-smbus.c b/drivers/i2c/i2c-core

[PATCH v1 0/3] Add Aspeed SSIF BMC driver

This series add support for the Aspeed specific SSIF BMC driver which is to perform in-band IPMI communication with the host in management (BMC) side. Quan Nguyen (3): i2c: i2c-core-smbus: Expose PEC calculate function for generic use drivers: char: ipmi: Add Aspeed SSIF BMC driver bindings

[PATCH v1 0/3] Add Aspeed SSIF BMC driver

This series add support for the Aspeed specific SSIF BMC driver which is to perform in-band IPMI communication with the host in management (BMC) side. Quan Nguyen (3): i2c: i2c-core-smbus: Expose PEC calculate function for generic use drivers: char: ipmi: Add Aspeed SSIF BMC driver bindings

[PATCH v1 2/3] drivers: char: ipmi: Add Aspeed SSIF BMC driver

The SMBus system interface (SSIF) IPMI BMC driver can be used to perform in-band IPMI communication with their host in management (BMC) side. This commits adds support specifically for Aspeed AST2500 which commonly used as Board Management Controllers. Signed-off-by: Quan Nguyen --- drivers

[PATCH v1 1/3] i2c: i2c-core-smbus: Expose PEC calculate function for generic use

Expose the PEC calculation i2c_smbus_pec() for generic use. Signed-off-by: Quan Nguyen --- drivers/i2c/i2c-core-smbus.c | 12 ++-- include/linux/i2c.h | 1 + 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/i2c-core-smbus.c b/drivers/i2c/i2c-core

[PATCH v1 3/3] bindings: ipmi: Add binding for Aspeed SSIF BMC driver

Add device tree binding document for the Aspeed SSIF BMC driver. Signed-off-by: Quan Nguyen --- .../bindings/ipmi/aspeed-ssif-bmc.txt | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 Documentation/devicetree/bindings/ipmi/aspeed-ssif-bmc.txt diff --git

[PATCH v2 3/4] hwmon: smpro: Add Ampere's Altra smpro-hwmon driver

This commit adds support for Ampere SMpro hwmon driver. This driver supports accessing various CPU sensors provided by the SMpro co-processor including temperature, power, voltages, and current. Signed-off-by: Quan Nguyen --- drivers/hwmon/Kconfig | 8 + drivers/hwmon/Makefile

[PATCH v2 4/4] docs: hwmon: (smpro-hwmon) Add documentation

Add documentation for the Ampere(R)'s Altra(R) SMpro hwmon driver. Signed-off-by: Thu Nguyen Signed-off-by: Quan Nguyen --- Documentation/hwmon/index.rst | 1 + Documentation/hwmon/smpro-hwmon.rst | 101 2 files changed, 102 insertions(+) create mode

[PATCH v2 2/4] mfd: simple-mfd-i2c: Adds Ampere's Altra SMpro support

Adds an MFD driver for SMpro found on the Mt.Jade hardware reference platform with Ampere's Altra processor family. Signed-off-by: Quan Nguyen --- drivers/mfd/Kconfig | 10 ++ drivers/mfd/simple-mfd-i2c.c | 6 ++ 2 files changed, 16 insertions(+) diff --git a/drivers/mfd

[PATCH v2 0/4] Add Ampere's Altra SMPro hwmon driver

t; to "ampere,smpro" [Quan] + Included sensor type and channel in labels [Quan] + Refactorized code to fix checkpatch.pl --strict complaint [Quan] Quan Nguyen (4): dt-bindings: mfd: Add bindings for Ampere Altra SMPro drivers mfd: simple-mfd-i2c: Adds Ampere's Altra SMpro support hwmon: s

[PATCH v2 1/4] dt-bindings: mfd: Add bindings for Ampere Altra SMPro drivers

Adds device tree bindings for SMPro drivers found on the Mt.Jade hardware reference platform with Ampere's Altra Processor family. Signed-off-by: Quan Nguyen --- .../bindings/hwmon/ampere,ac01-hwmon.yaml | 27 ++ .../devicetree/bindings/mfd/ampere,smpro.yaml | 82 +++ 2

Re: [PATCH 1/4] dt-bindings: mfd: Add bindings for Ampere Altra SMPro drivers

On 07/03/2021 03:58, Rob Herring wrote: On Thu, Feb 25, 2021 at 05:18:51PM +0700, Quan Nguyen wrote: Adds device tree bindings for SMPro drivers found on the Mt.Jade hardware reference platform with Ampere's Altra Processor family. Signed-off-by: Quan Nguyen --- .../bindings/hwmon/ampere

Re: [PATCH 2/4] mfd: simple-mfd-i2c: Adds Ampere's Altra SMpro support

On 26/02/2021 15:31, Lee Jones wrote: On Thu, 25 Feb 2021, Quan Nguyen wrote: Adds an MFD driver for SMpro found on the Mt.Jade hardware reference platform with Ampere's Altra processor family. Signed-off-by: Quan Nguyen --- drivers/mfd/Kconfig | 10 ++ drivers/mfd/simple

Re: [PATCH 4/4] docs: hwmon: (smpro-hwmon) Add documentation

On 25/02/2021 23:42, Guenter Roeck wrote: On 2/25/21 2:18 AM, Quan Nguyen wrote: Add documentation for the Ampere(R)'s Altra(R) SMpro hwmon driver. Signed-off-by: Thu Nguyen Signed-off-by: Quan Nguyen --- Documentation/hwmon/index.rst | 1 + Documentation/hwmon/smpro-hwmon.rst

Re: [PATCH 1/4] dt-bindings: mfd: Add bindings for Ampere Altra SMPro drivers

On 25/02/2021 23:47, Guenter Roeck wrote: On 2/25/21 2:18 AM, Quan Nguyen wrote: Adds device tree bindings for SMPro drivers found on the Mt.Jade hardware reference platform with Ampere's Altra Processor family. Signed-off-by: Quan Nguyen --- .../bindings/hwmon/ampere,ac01-hwmon.yaml

Re: [PATCH 3/4] hwmon: smpro: Add Ampere's Altra smpro-hwmon driver

On 25/02/2021 23:08, Guenter Roeck wrote: On 2/25/21 2:18 AM, Quan Nguyen wrote: This commit adds support for Ampere SMpro hwmon driver. This driver supports accessing various CPU sensors provided by the SMpro co-processor including temperature, power, voltages, and current. Signed-off

[PATCH 2/4] mfd: simple-mfd-i2c: Adds Ampere's Altra SMpro support

Adds an MFD driver for SMpro found on the Mt.Jade hardware reference platform with Ampere's Altra processor family. Signed-off-by: Quan Nguyen --- drivers/mfd/Kconfig | 10 ++ drivers/mfd/simple-mfd-i2c.c | 15 +-- 2 files changed, 23 insertions(+), 2 deletions

[PATCH 4/4] docs: hwmon: (smpro-hwmon) Add documentation

Add documentation for the Ampere(R)'s Altra(R) SMpro hwmon driver. Signed-off-by: Thu Nguyen Signed-off-by: Quan Nguyen --- Documentation/hwmon/index.rst | 1 + Documentation/hwmon/smpro-hwmon.rst | 100 2 files changed, 101 insertions(+) create mode

[PATCH 3/4] hwmon: smpro: Add Ampere's Altra smpro-hwmon driver

This commit adds support for Ampere SMpro hwmon driver. This driver supports accessing various CPU sensors provided by the SMpro co-processor including temperature, power, voltages, and current. Signed-off-by: Quan Nguyen --- drivers/hwmon/Kconfig | 8 + drivers/hwmon/Makefile

[PATCH 0/4] Add Ampere's Altra SMPro hwmon driver

This patch series adds support for Ampere SMpro hwmon driver. This driver supports accessing various CPU sensors provided by the SMpro co-processor including temperature, power, voltages, and current found on Ampere Altra processor family. Quan Nguyen (4): dt-bindings: mfd: Add bindings

[PATCH 1/4] dt-bindings: mfd: Add bindings for Ampere Altra SMPro drivers

Adds device tree bindings for SMPro drivers found on the Mt.Jade hardware reference platform with Ampere's Altra Processor family. Signed-off-by: Quan Nguyen --- .../bindings/hwmon/ampere,ac01-hwmon.yaml | 27 ++ .../bindings/mfd/ampere,ac01-smpro.yaml | 82 +++ 2

[PATCH 2/2] ARM: dts: aspeed: Add device tree for Ampere's Mt. Jade BMC

The Mt. Jade BMC is an ASPEED AST2500-based BMC for the Mt. Jade hardware reference platform with Ampere's Altra Processor Family. Reviewed-by: Andrew Jeffery Reviewed-by: Joel Stanley Signed-off-by: Quan Nguyen Signed-off-by: Phong Vo Signed-off-by: Thang Q. Nguyen --- arch/arm/boot/dts

[PATCH 1/2] dt-bindings: vendor-prefixes: Add an entry for AmpereComputing.com

Add "ampere" entry for Ampere Computing LLC: amperecomputing.com Reviewed-by: Andrew Jeffery Reviewed-by: Joel Stanley Signed-off-by: Quan Nguyen Signed-off-by: Phong Vo Signed-off-by: Thang Q. Nguyen --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file

[PATCH 0/2] ARM: dts: aspeed: Add Ampere Mt. Jade BMC device

The Mt. Jade BMC is an ASPEED AST2500-based BMC for the Mt. Jade hardware reference platform with Ampere's Altra Processor Family. Quan Nguyen (2): dt-bindings: vendor-prefixes: Add an entry for AmpereComputing.com ARM: dts: aspeed: Add device tree for Ampere's Mt. Jade BMC .../devicetree

Re: [PATCH] net: phy: xgene: disable clk on error paths

On Sat, Dec 16, 2017 at 4:52 AM, Alexey Khoroshilov wrote: > > There are several error paths in xgene_mdio_probe(), > where clk is left undisabled. The patch fixes them. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov

Re: [PATCH] net: phy: xgene: disable clk on error paths

On Sat, Dec 16, 2017 at 4:52 AM, Alexey Khoroshilov wrote: > > There are several error paths in xgene_mdio_probe(), > where clk is left undisabled. The patch fixes them. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov > --- >

[tip:irq/core] genirq: Export IRQ functions for module use

Commit-ID: 52b2a05fa7c8cfceebb59117a95decd68cf7e465 Gitweb: http://git.kernel.org/tip/52b2a05fa7c8cfceebb59117a95decd68cf7e465 Author: Quan Nguyen <qngu...@apm.com> AuthorDate: Thu, 3 Mar 2016 21:56:52 +0700 Committer: Thomas Gleixner <t...@linutronix.de> CommitDate: Thu, 10

[tip:irq/core] genirq: Export IRQ functions for module use

Commit-ID: 52b2a05fa7c8cfceebb59117a95decd68cf7e465 Gitweb: http://git.kernel.org/tip/52b2a05fa7c8cfceebb59117a95decd68cf7e465 Author: Quan Nguyen AuthorDate: Thu, 3 Mar 2016 21:56:52 +0700 Committer: Thomas Gleixner CommitDate: Thu, 10 Mar 2016 16:00:35 +0100 genirq: Export IRQ

Re: [PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller

q_domain_set_hwirq_and_chip" [drivers/gpio/gpio-xgene-sb.ko] >>> undefined! >>> ERROR: "irq_domain_reset_irq_data" [drivers/gpio/gpio-xgene-sb.ko] >>> undefined! >>> >>> This patch changes the kconfig so that the gpio controller can only be >>

Re: [PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller

ned! >>> ERROR: "irq_chip_set_type_parent" [drivers/gpio/gpio-xgene-sb.ko] >>> undefined! >>> ERROR: "irq_domain_alloc_irqs_parent" [drivers/gpio/gpio-xgene-sb.ko] >>> undefined! >>> ERROR: "irq_domain_set_hwirq_and_chip" [drivers/gpio/gpio-xgene-s

Re: [PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller

> make[2]: *** [drivers/gpio/gpio-xgene-sb.o] Error 1 > > Fixes: 1013fc41 "gpio: xgene: Enable X-Gene standby GPIO as interrupt > controller" > Signed-off-by: Matthias Brugger <mbrug...@suse.com> > --- > drivers/gpio/Kconfig | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Quan Nguyen <qngu...@apm.com>

Re: [PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller

rs/gpio/gpio-xgene-sb.o] Error 1 > > Fixes: 1013fc41 "gpio: xgene: Enable X-Gene standby GPIO as interrupt > controller" > Signed-off-by: Matthias Brugger > --- > drivers/gpio/Kconfig | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Quan Nguyen

[PATCH] genirq: Export IRQ functions for module use

Export list of functions below to build gpio-xgene-sb driver as module + irq_chip_*_parent() + irq_domain_create_hierarchy(), + irq_domain_set_hwirq_and_chip(), + irq_domain_reset_irq_data(), + irq_domain_alloc/free_irqs_parent() Signed-off-by: Quan Nguyen <qngu...@apm.com> Link: https://li

[PATCH] genirq: Export IRQ functions for module use

Export list of functions below to build gpio-xgene-sb driver as module + irq_chip_*_parent() + irq_domain_create_hierarchy(), + irq_domain_set_hwirq_and_chip(), + irq_domain_reset_irq_data(), + irq_domain_alloc/free_irqs_parent() Signed-off-by: Quan Nguyen Link: https://lists.01.org/pipermail