Re: [PATCH bpf-next 1/2] bpf: Remove bpf_jit_enable=2 debugging mode

2021-04-15 16:37 UTC+0200 ~ Daniel Borkmann > On 4/15/21 11:32 AM, Jianlin Lv wrote: >> For debugging JITs, dumping the JITed image to kernel log is discouraged, >> "bpftool prog dump jited" is much better way to examine JITed dumps. >> This patch get rid of the code related to bpf_jit_enable=2

Re: [RFC PATCH] bpf: preload: Fix build error when O= is set

2020-11-21 17:48 UTC+0800 ~ David Gow > On Sat, Nov 21, 2020 at 3:38 PM Andrii Nakryiko > wrote: >> >> On Thu, Nov 19, 2020 at 12:51 AM David Gow wrote: >>> >>> If BPF_PRELOAD is enabled, and an out-of-tree build is requested with >>> make O=, compilation seems to fail with: >>> >>>

Re: [PATCH bpf] tools: bpftool: Add missing close before bpftool net attach exit

On 09/11/2020 07:04, Wang Hai wrote: > progfd is created by prog_parse_fd(), before 'bpftool net attach' exit, > it should be closed. > > Fixes: 04949ccc273e ("tools: bpftool: add net attach command to attach XDP on > interface") > Signed-off-by: Wang Hai Reviewed

Re: [PATCH] tools/bpftool: Fix error return code in do_skeleton()

2020-07-15 11:13 UTC+0800 ~ YueHaibing > The error return code should be PTR_ERR(obj) other than > PTR_ERR(NULL). > > Fixes: 5dc7a8b21144 ("bpftool, selftests/bpf: Embed object file inside > skeleton") > Signed-off-by: YueHaibing Reviewed-by: Quentin Monnet Thanks!

Re: [PATCH] checkpatch: prevent reporting C99_COMMENTS error for SPDX tag in .c file

On Tue, 30 Jun 2020 at 18:20, Vadim Bendebury wrote: > > On Tue, Jun 30, 2020 at 7:47 AM Joe Perches wrote: > > > > (adding Vadem Bendebury who added the tolerance test) > > > > On Tue, 2020-06-30 at 15:35 +0100, Quentin Monnet wrote: > > > When

[PATCH] checkpatch: prevent reporting C99_COMMENTS error for SPDX tag in .c file

h tags are commented with the double-slash on purpose, and should not trigger errors from checkpatch. Let's ignore them when searching for C99-style comments to report. Signed-off-by: Quentin Monnet --- scripts/checkpatch.pl | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/che

[PATCH v3] checkpatch: fix CONST_STRUCT when const_structs.checkpatch is missing

ce we modify the read_words() function a little bit, update the checks for $typedefsfile/$typeOtherTypedefs as well. Signed-off-by: Quentin Monnet --- v3: - Remove comparison to empty string in read_words() and update checks on $typedefsfile/$typeOtherTypedefs in a similar way. v2: - Check i

Re: [PATCH v2] checkpatch: fix CONST_STRUCT when const_structs.checkpatch is missing

On Tue, 23 Jun 2020 at 17:48, Joe Perches wrote: > > Hi again. > > On Tue, 2020-06-23 at 11:37 +0100, Quentin Monnet wrote: > > Checkpatch reports warnings when some specific structs are not declared > > as const in the code. The list of structs to consider w

[PATCH v2] checkpatch: fix CONST_STRUCT when const_structs.checkpatch is missing

ot;, matches all structs found in the code, thus reporting a number of false positives. Let's fix the first item by skipping scripts/const_structs.checkpatch processing if "CONST_STRUCT" checks are ignored, and the second one by skipping the test if $const_structs is not defined. Signe

Re: [PATCH] checkpatch: fix CONST_STRUCT when const_structs.checkpatch is missing

2020-06-22 14:24 UTC-0700 ~ Joe Perches > On Mon, 2020-06-22 at 21:48 +0100, Quentin Monnet wrote: >> Checkpatch reports warnings when some specific structs are not declared >> as const in the code. The list of structs to consider was initially >> defined in the checkp

[PATCH] checkpatch: fix CONST_STRUCT when const_structs.checkpatch is missing

ves. Let's fix the first item by skipping scripts/const_structs.checkpatch processing if "CONST_STRUCT" checks are ignored, and the second one by skipping the test if $const_structs is an empty string. Fixes: bf1fa1dae68e ("checkpatch: externalize the structs that should be const") Signed-of

Re: linux-next: Fixes tag needs some work in the bpf-next tree

2019-08-16 23:46 UTC+1000 ~ Stephen Rothwell > Hi all, > > In commit > > ed4a3983cd3e ("tools: bpftool: fix argument for p_err() in BTF do_dump()") > > Fixes tag > > Fixes: c93cc69004dt ("bpftool: add ability to dump BTF types") > > has these problem(s): > > - missing space between

Re: [BPF v1] tools: bpftool: Fix JSON output when lookup fails

erwise it is an invalid JSON. This > commit fixes this, so the output now is: > > [{ > "key": ["0x0a","0x41","0x00","0x02","0x1f","0x78","0x00","0x00" > ], > "

Re: [PATCH bpf-next v1 5/7] tools: bpftool: support loading map by fd from parent process

2019-03-20 18:33 UTC+0100 ~ Alban Crequy > From: Alban Crequy > > Using a file descriptor passed by the parent process enables > applications to fork a bpftool command to inspect a map they know by > file descriptor even when they don't support bpffs or map ids. > > Documentation and bash

Re: [PATCH bpf-next v1 7/7] tools: bpftool: add error message on map pinning failure

2019-03-20 18:33 UTC+0100 ~ Alban Crequy > From: Alban Crequy > > Symptoms, when "dir" does not exist: > > $ sudo bpftool map create /sys/fs/bpf/dir/fooB type hash key 8 value 8 > entries 8 name fooB flags 1 > $ echo $? > 255 > > This patch prints an error message when the map pinning fails.

Re: [PATCH bpf-next v1 4/7] tools: bpftool: implement map exec command

2019-03-20 18:33 UTC+0100 ~ Alban Crequy > From: Alban Crequy > > The map exec commands allows to open an existing map and pass the file > descriptor to a child process. This enables applications to use an > existing BPF map even when they don't support bpffs. > > Example of usage: > #

Re: [PATCH bpf-next v1 6/7] tools: bpftool: fix bpffs mount when pinning subdirectories

sage about the mount. > > Fixes: 3fc27b71b894 ("tools: bpftool: try to mount bpffs if required for > pinning objects") > Cc: Quentin Monnet > Signed-off-by: Alban Crequy > --- > tools/bpf/bpftool/common.c | 20 > tools/bpf/bpftool/main.h

Re: [PATCH bpf-next v1] tools/bpftool: create map of maps

2019-03-05 17:38 UTC+0100 ~ Alban Crequy > From: Alban Crequy > > Before this patch, there was no way to fill attr.inner_map_fd, necessary > for array_of_maps or hash_of_maps. > > This patch adds keyword 'innermap' to pass the innermap, either as an id > or as a pinned map. > > Example of

Re: [PATCH bpf-next v2] bpf: bpftool, fix documentation for attach types

ban Crequy > > --- > > Changes v1 to v2: > - fix man pages & bash completion (from Quentin's review) Thanks a lot! Reviewed-by: Quentin Monnet

Re: [PATCH] bpf: bpftool, fix documentation for attach types

2019-02-11 13:54 UTC+0100 ~ Alban Crequy > From: Alban Crequy > > bpftool has support for attach types "stream_verdict" and > "stream_parser" but the documentation was referring to them with > "skb_verdict" and "skb_parse". The inconsistency comes from commit > b7d3826c2ed6 ("bpf: bpftool, add

Re: [PATCH] bpftool: Fix prog dump by tag

so it gets cleaned before each query. > > Reported-by: Lance Digby > Signed-off-by: Jiri Olsa Thanks for the fix! Reviewed-by: Quentin Monnet

Re: [PATCH v3 2/2] bpf: add selftest for rawir_event type program

2018-05-18 14:33 UTC+0100 ~ Sean Young <s...@mess.org> > On Fri, May 18, 2018 at 11:13:07AM +0100, Quentin Monnet wrote: >> 2018-05-17 22:01 UTC+0100 ~ Sean Young <s...@mess.org> >>> On Thu, May 17, 2018 at 10:17:59AM -0700, Y Song wrote: >>>> On W

Re: [PATCH v3 2/2] bpf: add selftest for rawir_event type program

2018-05-18 14:33 UTC+0100 ~ Sean Young > On Fri, May 18, 2018 at 11:13:07AM +0100, Quentin Monnet wrote: >> 2018-05-17 22:01 UTC+0100 ~ Sean Young >>> On Thu, May 17, 2018 at 10:17:59AM -0700, Y Song wrote: >>>> On Wed, May 16, 2018 at 2:04 PM, Sean Young wrote:

Re: [PATCH v3 2/2] bpf: add selftest for rawir_event type program

2018-05-17 22:01 UTC+0100 ~ Sean Young > On Thu, May 17, 2018 at 10:17:59AM -0700, Y Song wrote: >> On Wed, May 16, 2018 at 2:04 PM, Sean Young wrote: >>> This is simple test over rc-loopback. >>> >>> Signed-off-by: Sean Young >>> --- >>>

Re: [PATCH v3 2/2] bpf: add selftest for rawir_event type program

2018-05-17 22:01 UTC+0100 ~ Sean Young > On Thu, May 17, 2018 at 10:17:59AM -0700, Y Song wrote: >> On Wed, May 16, 2018 at 2:04 PM, Sean Young wrote: >>> This is simple test over rc-loopback. >>> >>> Signed-off-by: Sean Young >>> --- >>> tools/bpf/bpftool/prog.c | 1 +

Re: [PATCH v3 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-16 22:04 UTC+0100 ~ Sean Young > Add support for BPF_PROG_RAWIR_EVENT. This type of BPF program can call > rc_keydown() to reported decoded IR scancodes, or rc_repeat() to report > that the last key should be repeated. > > The bpf program can be attached to using the

Re: [PATCH v3 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-16 22:04 UTC+0100 ~ Sean Young > Add support for BPF_PROG_RAWIR_EVENT. This type of BPF program can call > rc_keydown() to reported decoded IR scancodes, or rc_repeat() to report > that the last key should be repeated. > > The bpf program can be attached to using the bpf(BPF_PROG_ATTACH)

Re: [PATCH 0/2] bpf: Change print_bpf_insn interface

"Reviewed-by" tags when resubmitting new versions of your patch sets :) For the series: Reviewed-by: Quentin Monnet <quentin.mon...@netronome.com>

Re: [PATCH 0/2] bpf: Change print_bpf_insn interface

resubmitting new versions of your patch sets :) For the series: Reviewed-by: Quentin Monnet

Re: [PATCH 1/2] bpf: Remove struct bpf_verifier_env argument from print_bpf_insn

2018-03-22 14:32 UTC+0100 ~ Jiri Olsa <jo...@redhat.com> > On Thu, Mar 22, 2018 at 10:34:18AM +0100, Daniel Borkmann wrote: >> On 03/21/2018 07:37 PM, Jiri Olsa wrote: >>> On Wed, Mar 21, 2018 at 05:25:33PM +, Quentin Monnet wrote: >>>> 2018-03-21 16:02 UT

Re: [PATCH 1/2] bpf: Remove struct bpf_verifier_env argument from print_bpf_insn

2018-03-22 14:32 UTC+0100 ~ Jiri Olsa > On Thu, Mar 22, 2018 at 10:34:18AM +0100, Daniel Borkmann wrote: >> On 03/21/2018 07:37 PM, Jiri Olsa wrote: >>> On Wed, Mar 21, 2018 at 05:25:33PM +0000, Quentin Monnet wrote: >>>> 2018-03-21 16:02 UTC+0100 ~ Jiri Olsa >&

Re: [PATCHv2 2/2] bpftool: Adjust to new print_bpf_insn interface

; > thanks, > jirka > > > --- > Change bpftool to skip the removed struct bpf_verifier_env > argument in print_bpf_insn. It was passed as NULL anyway. > > No functional change intended. > > Signed-off-by: Jiri Olsa <jo...@kernel.org> > --- > tools/b

Re: [PATCHv2 2/2] bpftool: Adjust to new print_bpf_insn interface

gt; jirka > > > --- > Change bpftool to skip the removed struct bpf_verifier_env > argument in print_bpf_insn. It was passed as NULL anyway. > > No functional change intended. > > Signed-off-by: Jiri Olsa > --- > tools/bpf/bpftool/xlated_dumper.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > Thank you! Reviewed-by: Quentin Monnet

Re: [PATCH 1/2] bpf: Remove struct bpf_verifier_env argument from print_bpf_insn

2018-03-21 16:02 UTC+0100 ~ Jiri Olsa > We use print_bpf_insn in user space (bpftool and soon perf), > so it'd be nice to keep it generic and strip it off the kernel > struct bpf_verifier_env argument. > > This argument can be safely removed, because its users can > use the

Re: [PATCH 1/2] bpf: Remove struct bpf_verifier_env argument from print_bpf_insn

2018-03-21 16:02 UTC+0100 ~ Jiri Olsa > We use print_bpf_insn in user space (bpftool and soon perf), > so it'd be nice to keep it generic and strip it off the kernel > struct bpf_verifier_env argument. > > This argument can be safely removed, because its users can > use the struct

Re: [PATCH 2/2] bpftool: Adjust to new print_bpf_insn interface

2018-03-21 16:02 UTC+0100 ~ Jiri Olsa > Change bpftool to skip the removed struct bpf_verifier_env > argument in print_bpf_insn. It was passed as NULL anyway. > > No functional change intended. > > Signed-off-by: Jiri Olsa > --- > tools/bpf/bpftool/prog.c |

Re: [PATCH 2/2] bpftool: Adjust to new print_bpf_insn interface

2018-03-21 16:02 UTC+0100 ~ Jiri Olsa > Change bpftool to skip the removed struct bpf_verifier_env > argument in print_bpf_insn. It was passed as NULL anyway. > > No functional change intended. > > Signed-off-by: Jiri Olsa > --- > tools/bpf/bpftool/prog.c | 8 > 1 file changed, 4

Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs

2018-01-19 14:17 UTC+ ~ Roman Gushchin <g...@fb.com> > On Mon, Jan 15, 2018 at 07:32:01PM +, Quentin Monnet wrote: [...] >> Looks good, thanks Roman! >> Would you mind updating the map names as well? It seems the >> BPF_MAP_TYPE_CPUMAP is missing from th

Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs

2018-01-19 14:17 UTC+ ~ Roman Gushchin > On Mon, Jan 15, 2018 at 07:32:01PM +0000, Quentin Monnet wrote: [...] >> Looks good, thanks Roman! >> Would you mind updating the map names as well? It seems the >> BPF_MAP_TYPE_CPUMAP is missing from the list in map.c

Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs

ted 105B memlock 4096B > > Signed-off-by: Roman Gushchin <g...@fb.com> > Cc: Jakub Kicinski <jakub.kicin...@netronome.com> > Cc: Quentin Monnet <quentin.mon...@netronome.com> > Cc: Daniel Borkmann <dan...@iogearbox.net> > Cc: Alexei Starovoitov <a...@kernel.

Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs

6B > > Signed-off-by: Roman Gushchin > Cc: Jakub Kicinski > Cc: Quentin Monnet > Cc: Daniel Borkmann > Cc: Alexei Starovoitov > --- > tools/bpf/bpftool/prog.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool

Re: [PATCH v2 bpf-next 2/2] tools/bpftool: fix bpftool build with bintutils >= 2.8

Hi Roman, 2017-12-22 16:11 UTC+ ~ Roman Gushchin > Bpftool build is broken with binutils version 2.28 and later. Could you check the binutils version? I believe it changed in 2.29 instead of 2.28. Could you update your commit log and subject accordingly, please? > The cause is

Re: [PATCH v2 bpf-next 2/2] tools/bpftool: fix bpftool build with bintutils >= 2.8

Hi Roman, 2017-12-22 16:11 UTC+ ~ Roman Gushchin > Bpftool build is broken with binutils version 2.28 and later. Could you check the binutils version? I believe it changed in 2.29 instead of 2.28. Could you update your commit log and subject accordingly, please? > The cause is commit

Re: [RFC PATCH net-next] tools/bpf: fix build with binutils >= 2.28

2017-12-20 18:32 UTC+ ~ Roman Gushchin <g...@fb.com> > On Tue, Dec 19, 2017 at 04:22:51PM +, Quentin Monnet wrote: >> 2017-12-19 16:10 UTC+ ~ Roman Gushchin <g...@fb.com> >>> On Tue, Dec 19, 2017 at 03:57:02PM +, Quentin Monnet wrote: >

Re: [RFC PATCH net-next] tools/bpf: fix build with binutils >= 2.28

2017-12-20 18:32 UTC+ ~ Roman Gushchin > On Tue, Dec 19, 2017 at 04:22:51PM +0000, Quentin Monnet wrote: >> 2017-12-19 16:10 UTC+ ~ Roman Gushchin >>> On Tue, Dec 19, 2017 at 03:57:02PM +0000, Quentin Monnet wrote: >>>> Hi Roman, thanks for working on th

Re: [RFC PATCH net-next] tools/bpf: fix build with binutils >= 2.28

2017-12-19 16:10 UTC+ ~ Roman Gushchin <g...@fb.com> > On Tue, Dec 19, 2017 at 03:57:02PM +, Quentin Monnet wrote: >> Hi Roman, thanks for working on this! >> >> 2017-12-19 14:38 UTC+ ~ Roman Gushchin <g...@fb.com> >>> Bpftool build is b

Re: [RFC PATCH net-next] tools/bpf: fix build with binutils >= 2.28

2017-12-19 16:10 UTC+ ~ Roman Gushchin > On Tue, Dec 19, 2017 at 03:57:02PM +0000, Quentin Monnet wrote: >> Hi Roman, thanks for working on this! >> >> 2017-12-19 14:38 UTC+ ~ Roman Gushchin >>> Bpftool build is broken with binutils version 2.28 and

Re: [RFC PATCH net-next] tools/bpf: fix build with binutils >= 2.28

Hi Roman, thanks for working on this! 2017-12-19 14:38 UTC+ ~ Roman Gushchin > Bpftool build is broken with binutils version 2.28 and later. > The cause is commit 003ca0fd2286 ("Refactor disassembler selection") > in the binutils repo, which changed the disassembler() function >

Re: [RFC PATCH net-next] tools/bpf: fix build with binutils >= 2.28

Hi Roman, thanks for working on this! 2017-12-19 14:38 UTC+ ~ Roman Gushchin > Bpftool build is broken with binutils version 2.28 and later. > The cause is commit 003ca0fd2286 ("Refactor disassembler selection") > in the binutils repo, which changed the disassembler() function > signature. >

Re: [PATCH v4 net-next 0/4] bpftool: cgroup bpf operations

out creating additional dependencies. And bpftool seems to be > a right tool to extend with such functionality. Thank you Roman for this series, and for documenting the new commands and flags! Reviewed-by: Quentin Monnet <quentin.mon...@netronome.com>

Re: [PATCH v4 net-next 0/4] bpftool: cgroup bpf operations

ependencies. And bpftool seems to be > a right tool to extend with such functionality. Thank you Roman for this series, and for documenting the new commands and flags! Reviewed-by: Quentin Monnet

Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations

2017-12-08 14:12 UTC+ ~ Roman Gushchin <g...@fb.com> > On Fri, Dec 08, 2017 at 10:34:16AM +, Quentin Monnet wrote: >> 2017-12-07 18:39 UTC+ ~ Roman Gushchin <g...@fb.com> >>> This patch adds basic cgroup bpf operations to bpftool: >>>

Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations

2017-12-08 14:12 UTC+ ~ Roman Gushchin > On Fri, Dec 08, 2017 at 10:34:16AM +0000, Quentin Monnet wrote: >> 2017-12-07 18:39 UTC+ ~ Roman Gushchin >>> This patch adds basic cgroup bpf operations to bpftool: >>> cgroup list, attach and detach commands.

Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations

x.net> > Cc: Jakub Kicinski <jakub.kicin...@netronome.com> > Cc: Martin KaFai Lau <ka...@fb.com> > Cc: Quentin Monnet <quentin.mon...@netronome.com> > Cc: David Ahern <dsah...@gmail.com> > --- > tools/bpf/bpftool/Documentation/bpftool-cgroup.rst | 92 +

Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations

GROUP > $ bpftool cgroup attach CGROUP ATTACH_TYPE PROG [ATTACH_FLAGS] > $ bpftool cgroup detach CGROUP ATTACH_TYPE PROG > > Signed-off-by: Roman Gushchin > Cc: Alexei Starovoitov > Cc: Daniel Borkmann > Cc: Jakub Kicinski > Cc: Martin KaFai Lau > Cc: Quentin Mo

Re: [PATCH v2 net-next 3/4] bpftool: implement prog load command

ool prog load SOURCE_FILE FILE > > FILE is a non-existing file on bpffs. > > Signed-off-by: Roman Gushchin <g...@fb.com> > Cc: Alexei Starovoitov <a...@kernel.org> > Cc: Daniel Borkmann <dan...@iogearbox.net> > Cc: Jakub Kicinski <jakub.kicin...@netronome.com&

Re: [PATCH v2 net-next 1/4] libbpf: add ability to guess program type based on section name

pe. In first order it will be used by bpftool. > > Signed-off-by: Roman Gushchin <g...@fb.com> > Cc: Alexei Starovoitov <a...@kernel.org> > Cc: Daniel Borkmann <dan...@iogearbox.net> > Cc: Jakub Kicinski <jakub.kicin...@netronome.com> > Cc: Martin KaFai Lau <k

Re: [PATCH v2 net-next 3/4] bpftool: implement prog load command

FILE > > FILE is a non-existing file on bpffs. > > Signed-off-by: Roman Gushchin > Cc: Alexei Starovoitov > Cc: Daniel Borkmann > Cc: Jakub Kicinski > Cc: Martin KaFai Lau > Cc: Quentin Monnet > Cc: David Ahern > --- > tools/bpf/bpftool/Documentation/b

Re: [PATCH v2 net-next 1/4] libbpf: add ability to guess program type based on section name

will be used by bpftool. > > Signed-off-by: Roman Gushchin > Cc: Alexei Starovoitov > Cc: Daniel Borkmann > Cc: Jakub Kicinski > Cc: Martin KaFai Lau > Cc: Quentin Monnet > Cc: David Ahern > --- > tools/lib/bpf/libbpf.c | 51 > +++

Re: [PATCH net-next 1/5] libbpf: add ability to guess program type based on section name

2017-12-04 12:34 UTC+ ~ Roman Gushchin <g...@fb.com> > On Fri, Dec 01, 2017 at 02:46:06PM -0800, Jakub Kicinski wrote: >> On Fri, 1 Dec 2017 10:22:57 +, Quentin Monnet wrote: >>> Thanks Roman! >>> One comment in-line. >>> >>> 2017

Re: [PATCH net-next 1/5] libbpf: add ability to guess program type based on section name

2017-12-04 12:34 UTC+ ~ Roman Gushchin > On Fri, Dec 01, 2017 at 02:46:06PM -0800, Jakub Kicinski wrote: >> On Fri, 1 Dec 2017 10:22:57 +, Quentin Monnet wrote: >>> Thanks Roman! >>> One comment in-line. >>> >>> 2017-11-30 13:42 UTC+ ~ Roma

Re: [PATCH net-next 4/5] bpftool: implement cgdetach command

2017-11-30 13:43 UTC+ ~ Roman Gushchin > Implement cgdetach command, which allows to detach the bpf > program from a cgroup. It takes program id and attach type > as arguments. > > Example: > $ ./bpftool cgdetach /sys/fs/cgroup/user.slice/ device 1 > > Signed-off-by: Roman

Re: [PATCH net-next 4/5] bpftool: implement cgdetach command

2017-11-30 13:43 UTC+ ~ Roman Gushchin > Implement cgdetach command, which allows to detach the bpf > program from a cgroup. It takes program id and attach type > as arguments. > > Example: > $ ./bpftool cgdetach /sys/fs/cgroup/user.slice/ device 1 > > Signed-off-by: Roman Gushchin > Cc:

Re: [PATCH net-next 1/5] libbpf: add ability to guess program type based on section name

Thanks Roman! One comment in-line. 2017-11-30 13:42 UTC+ ~ Roman Gushchin > The bpf_prog_load() function will guess program type if it's not > specified explicitly. This functionality will be used to implement > loading of different programs without asking a user to specify >

Re: [PATCH net-next 1/5] libbpf: add ability to guess program type based on section name

Thanks Roman! One comment in-line. 2017-11-30 13:42 UTC+ ~ Roman Gushchin > The bpf_prog_load() function will guess program type if it's not > specified explicitly. This functionality will be used to implement > loading of different programs without asking a user to specify > the program