This patch fixes a typo in RDMA cgroup documentation.
Signed-off-by: Rami Rosen
---
Documentation/cgroup-v1/rdma.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/cgroup-v1/rdma.txt b/Documentation/cgroup-v1/rdma.txt
index af618171e0eb..9bdb7fd03f83 100644
This patch fixes a typo in RDMA cgroup documentation.
Signed-off-by: Rami Rosen
---
Documentation/cgroup-v1/rdma.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/cgroup-v1/rdma.txt b/Documentation/cgroup-v1/rdma.txt
index af618171e0eb..9bdb7fd03f83 100644
Signed-off-by: Rami Rosen
This patch fixes a typo in lib/devres.c.
---
lib/devres.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/devres.c b/lib/devres.c
index faccf1a..f64cc21 100644
--- a/lib/devres.c
+++ b/lib/devres.c
@@ -290,7 +290,7 @@ static void
Signed-off-by: Rami Rosen
This patch fixes a typo in lib/devres.c.
---
lib/devres.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/devres.c b/lib/devres.c
index faccf1a..f64cc21 100644
--- a/lib/devres.c
+++ b/lib/devres.c
@@ -290,7 +290,7 @@ static void
This patch fixes a typo in i40e_pf object documentation; num_req_vfs
refers to the number of VFs requested for the PF.
Signed-off-by: Rami Rosen <rami.ro...@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drive
This patch fixes a typo in i40e_pf object documentation; num_req_vfs
refers to the number of VFs requested for the PF.
Signed-off-by: Rami Rosen
---
drivers/net/ethernet/intel/i40e/i40e.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e.h
This patch removes the definition and the single assignement of the
"done" variable in accounting/getdelays.c, as it is not used anywhere.
Signed-off-by: Rami Rosen <rami.ro...@intel.com>
---
tools/accounting/getdelays.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/
This patch removes the definition and the single assignement of the
"done" variable in accounting/getdelays.c, as it is not used anywhere.
Signed-off-by: Rami Rosen
---
tools/accounting/getdelays.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/accounting/getdelays
Thanks, Sunil.
>with network stack: 0.32 Mpps
>with XDP (XDP_TX): 3 Mpps
>and XDP_DROP: 3.8 Mpps
Interesting; May I ask - which packet size did you use ?
Regards,
Rami Rosen
Thanks, Sunil.
>with network stack: 0.32 Mpps
>with XDP (XDP_TX): 3 Mpps
>and XDP_DROP: 3.8 Mpps
Interesting; May I ask - which packet size did you use ?
Regards,
Rami Rosen
id : don't care
> +interrupt_pin : Should be 1 - INTA, 2 - INTB, 3 - INTC, 4 -INTD
> +msi_interrupts : Should be 1 to 32 depending on the number of msi
Regards,
Rami Rosen
id : don't care
> +interrupt_pin : Should be 1 - INTA, 2 - INTB, 3 - INTC, 4 -INTD
> +msi_interrupts : Should be 1 to 32 depending on the number of msi
Regards,
Rami Rosen
v_err(>pdev->dev,
> + "invalid rcv-sequencer firmware size %zu\n",
> fw->size);
> + err = -EINVAL;
Again, in the release label, always 0 is returned:
> + goto release;
> + }
> +
>
> +release:
> + release_firmware(fw);
> +
> + return 0;
> +}
> +
Regards,
Rami Rosen
v_err(>pdev->dev,
> + "invalid rcv-sequencer firmware size %zu\n",
> fw->size);
> + err = -EINVAL;
Again, in the release label, always 0 is returned:
> + goto release;
> + }
> +
>
> +release:
> + release_firmware(fw);
> +
> + return 0;
> +}
> +
Regards,
Rami Rosen
> + u64 tx_used_desc;
> + u64 napi_schedule;
> + u64 napi_underflow;
> +};
> +
Trivial: typo, should be: can transfer
> +/* The datasheet said that each descriptor can transfers up to 4096bytes
> + * But latter, a register documentation reduce that value to 2048
Regards,
Rami Rosen
> + u64 tx_used_desc;
> + u64 napi_schedule;
> + u64 napi_underflow;
> +};
> +
Trivial: typo, should be: can transfer
> +/* The datasheet said that each descriptor can transfers up to 4096bytes
> + * But latter, a register documentation reduce that value to 2048
Regards,
Rami Rosen
of RDMA resources.
"of of" should be only a single "of"
> + mlx4_1 uctx=1 ah=0 pd=1 cq=4 qp=4 mr=100 srq=0 flow=10
> + ocrdma1 uctx=2 pd=2 ah=2 mr=20 mw=max cq=1 srq=1 qp=10 flow=10
Seems to be inconsistency here: in the first line you have qp=4
*before* srq=0, but in the seco
of RDMA resources.
"of of" should be only a single "of"
> + mlx4_1 uctx=1 ah=0 pd=1 cq=4 qp=4 mr=100 srq=0 flow=10
> + ocrdma1 uctx=2 pd=2 ah=2 mr=20 mw=max cq=1 srq=1 qp=10 flow=10
Seems to be inconsistency here: in the first line you have qp=4
*before* srq=0, but in the seco
commit aa2110cb1a7510f9b834adfb39b05d4843a35d35
("ACPI: add boot option acpi=copy_dsdt to fix corrupt DSDT") added
copy_dsdt as an ACPI boot option, but did not add it to ACPI format options in
Documentation/kernel-parameters.txt. This patch fixes it.
Signed-off-by:
commit aa2110cb1a7510f9b834adfb39b05d4843a35d35
("ACPI: add boot option acpi=copy_dsdt to fix corrupt DSDT") added
copy_dsdt as an ACPI boot option, but did not add it to ACPI format options in
Documentation/kernel-parameters.txt. This patch fixes it.
Signed-off-by: Rami Ro
This patch removes a broken link in drivers/pci/quirks.c.
Signed-off-by: Rami Rosen
---
drivers/pci/quirks.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index c6dc1df..f78bcc0 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
This patch removes a broken link in drivers/pci/quirks.c.
Signed-off-by: Rami Rosen ramir...@gmail.com
---
drivers/pci/quirks.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index c6dc1df..f78bcc0 100644
--- a/drivers/pci/quirks.c
+++ b/drivers
%d)\n", priv->irq);
+ return 0;
+
+out_netif_api:
+ netif_napi_del(>napi);
+out_netdev:
+ if (err)
+ free_netdev(ndev);
+
+ return err;
+}
Regards,
Rami Rosen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
);
+out_netdev:
+ if (err)
+ free_netdev(ndev);
+
+ return err;
+}
Regards,
Rami Rosen
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
Please read the FAQ at http://www.tux.org/lkml/
This patch fixes various typos in Documentation/edac.txt.
Signed-off-by: Rami Rosen
---
Documentation/edac.txt | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/Documentation/edac.txt b/Documentation/edac.txt
index 73fff13..4df786e 100644
--- a/Documentation
This patch fixes various typos in Documentation/edac.txt.
Signed-off-by: Rami Rosen ramir...@gmail.com
---
Documentation/edac.txt | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/Documentation/edac.txt b/Documentation/edac.txt
index 73fff13..4df786e 100644
This patch Fixes a typo in Documentation/edac.txt.
Signed-off-by: Rami Rosen
---
Documentation/edac.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/edac.txt b/Documentation/edac.txt
index 73fff13..9679433 100644
--- a/Documentation/edac.txt
+++ b
This patch Fixes a typo in Documentation/edac.txt.
Signed-off-by: Rami Rosen ramir...@gmail.com
---
Documentation/edac.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/edac.txt b/Documentation/edac.txt
index 73fff13..9679433 100644
--- a/Documentation
Hi,
BTW, this is not the only NAPI issue here. When looking into cleanup
of resources in this driver, a call to netif_napi_del() is missing
(though there is a call to napi_disable(), which is not enough for
proper cleanup).
Best,
Rami Rosen
http://ramirose.wix.com/ramirosen
On Tue, Aug 13, 2013
Hi,
BTW, this is not the only NAPI issue here. When looking into cleanup
of resources in this driver, a call to netif_napi_del() is missing
(though there is a call to napi_disable(), which is not enough for
proper cleanup).
Best,
Rami Rosen
http://ramirose.wix.com/ramirosen
On Tue, Aug 13, 2013
uld look at the rest of the patch of Patrick McHardy ("add
802.1ad support"), it does not appear in the latest git tree of
iproute2.
Please look for example in ip/iplink_vlan.c b/ip/iplink_vlan.c
in the explain() method and compare to the above mentioned patch.
Regards,
Rami Rosen
htt
should look at the rest of the patch of Patrick McHardy (add
802.1ad support), it does not appear in the latest git tree of
iproute2.
Please look for example in ip/iplink_vlan.c b/ip/iplink_vlan.c
in the explain() method and compare to the above mentioned patch.
Regards,
Rami Rosen
http
This patch removes sysfs_sb declaration from fs/sysfs/inode.c
(due to 0f4288ec6fcc1a47d1fa0241ec1c6dacd5a09e96,
"Kill unused sysfs_sb variable").
Signed-off-by: Rami Rosen
---
fs/sysfs/inode.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/sysfs/inode.c b/fs/sysfs/ino
This patch removes sysfs_sb declaration from fs/sysfs/inode.c
(due to 0f4288ec6fcc1a47d1fa0241ec1c6dacd5a09e96,
Kill unused sysfs_sb variable).
Signed-off-by: Rami Rosen ramir...@gmail.com
---
fs/sysfs/inode.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/sysfs/inode.c b/fs/sysfs
In devcgroup_css_alloc(), there is no longer need for parent_cgroup.
bd2953ebbb("devcg: propagate local changes down the hierarchy") made
the variable parent_cgroup redundant. This patch removes parent_cgroup
from devcgroup_css_alloc().
Signed-off-by: Rami Rosen
---
security/device_cg
In devcgroup_css_alloc(), there is no longer need for parent_cgroup.
bd2953ebbb(devcg: propagate local changes down the hierarchy) made
the variable parent_cgroup redundant. This patch removes parent_cgroup
from devcgroup_css_alloc().
Signed-off-by: Rami Rosen ramir...@gmail.com
---
security
/msg221168.html
probably this patch, which was applied to net, was not pulled yet.
I believe that since the commit above was not to net-next, this
problem is not observed in your tree.
Rami Rosen
http://ramirose.wix.com/ramirosen
On Fri, Jan 4, 2013 at 9:27 PM, Stephen Hemminger wrote:
> O
.html
probably this patch, which was applied to net, was not pulled yet.
I believe that since the commit above was not to net-next, this
problem is not observed in your tree.
Rami Rosen
http://ramirose.wix.com/ramirosen
On Fri, Jan 4, 2013 at 9:27 PM, Stephen Hemminger shemmin...@vyatta.com wrote
[=y])│
-> Wireless (WIRELESS [=y])
Regards,
Rami Rosen
On Tue, Oct 2, 2012 at 1:06 AM, Kevin Cruz wrote:
> Hey Johannes,
> None of this should be too much of an effort for me. Thankfully I
> don't find terminals to be daunting.
>
])│
- Wireless (WIRELESS [=y])
Regards,
Rami Rosen
On Tue, Oct 2, 2012 at 1:06 AM, Kevin Cruz skate_...@yahoo.com wrote:
Hey Johannes,
None of this should be too much of an effort for me. Thankfully I
don't find terminals to be daunting.
Yeah ... we saw
Hi,
This patch removes some unused definitions and one method typedef
declaration (f_pnode)
in include/net/ip6_fib.h, as they are not used in the kernel.
Regards,
Rami Rosen
Signed-off-by: Rami Rosen <[EMAIL PROTECTED]>
diff --git a/include/net/ip6_fib.h b/include/net/ip6_fib.h
index d
Hi,
Remove IP6_RT_PRIO_FW and IP6_RT_FLOW_MASK definitions in
include/net/ip6_route.h, as they are not used in the kernel.
Regards,
Rami Rosen
Signed-off-by: Rami Rosen <[EMAIL PROTECTED]>
diff --git a/include/net/ip6_route.h b/include/net/ip6_route.h
index faac0ee..f99e4f0 100644
--- a/i
Hi,
This patch removes some unused definitions and one method typedef
declaration (f_pnode)
in include/net/ip6_fib.h, as they are not used in the kernel.
Regards,
Rami Rosen
Signed-off-by: Rami Rosen [EMAIL PROTECTED]
diff --git a/include/net/ip6_fib.h b/include/net/ip6_fib.h
index d8d85b1
Hi,
Remove IP6_RT_PRIO_FW and IP6_RT_FLOW_MASK definitions in
include/net/ip6_route.h, as they are not used in the kernel.
Regards,
Rami Rosen
Signed-off-by: Rami Rosen [EMAIL PROTECTED]
diff --git a/include/net/ip6_route.h b/include/net/ip6_route.h
index faac0ee..f99e4f0 100644
--- a/include
appropriate #ifdef.
Regards,
Rami Rosen
Signed-off-by: Rami Rosen <[EMAIL PROTECTED]>
diff --git a/drivers/net/pppol2tp.c b/drivers/net/pppol2tp.c
index 1b51bb6..5aa0a80 100644
--- a/drivers/net/pppol2tp.c
+++ b/drivers/net/pppol2tp.c
@@ -2468,9 +2468,10 @@ static int __init pppol2tp_ini
appropriate #ifdef.
Regards,
Rami Rosen
Signed-off-by: Rami Rosen [EMAIL PROTECTED]
diff --git a/drivers/net/pppol2tp.c b/drivers/net/pppol2tp.c
index 1b51bb6..5aa0a80 100644
--- a/drivers/net/pppol2tp.c
+++ b/drivers/net/pppol2tp.c
@@ -2468,9 +2468,10 @@ static int __init pppol2tp_init(void
Hello,
I had sent a patch recently (which is currently pending) which
solves this problem.
see:
http://www.spinics.net/lists/netdev/msg54455.html
Regards,
Rami Rosen
On Feb 5, 2008 1:25 AM, Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Mon, 04 Feb 2008 23:32:49 +0100
> Ti
Hello,
I had sent a patch recently (which is currently pending) which
solves this problem.
see:
http://www.spinics.net/lists/netdev/msg54455.html
Regards,
Rami Rosen
On Feb 5, 2008 1:25 AM, Andrew Morton [EMAIL PROTECTED] wrote:
On Mon, 04 Feb 2008 23:32:49 +0100
Tilman Schmidt [EMAIL
.
When CONFIG_NET_EMATCH is defined, the tcf_ematch_tree structure indeed holds
a struct tcf_ematch_tree_hdr (hdr) as flow_dump() expects.
This patch adds #ifdef CONFIG_NET_EMATCH in flow_dump to avoid this.
The patch was build against latest 2.6 git net tree.
Regards,
Rami Rosen
Signed-off
.
When CONFIG_NET_EMATCH is defined, the tcf_ematch_tree structure indeed holds
a struct tcf_ematch_tree_hdr (hdr) as flow_dump() expects.
This patch adds #ifdef CONFIG_NET_EMATCH in flow_dump to avoid this.
The patch was build against latest 2.6 git net tree.
Regards,
Rami Rosen
Signed-off
Hi,
It seems that PACKET_FASTROUTE definition should be removed due to that
fastroute is no longer supported.
Regards,
Rami Rosen
--
Signed-off-by: Rami Rosen <[EMAIL PROTECTED]>
--- linux-2.6.23-rc1-clean/include/linux/if_packet.h2007-05-03
12:07:59.000
Hi,
It seems that PACKET_FASTROUTE definition should be removed due to that
fastroute is no longer supported.
Regards,
Rami Rosen
--
Signed-off-by: Rami Rosen [EMAIL PROTECTED]
--- linux-2.6.23-rc1-clean/include/linux/if_packet.h2007-05-03
12:07:59.0
52 matches
Mail list logo
