Re: [Kernel-BR] Re: [PATCH] sound: pci: emu10k1: code refactoring and casting removal

2013-10-17 Thread Raphael S Carvalho
l in order not to introduce regressions. And yes, he could improve something here and there. As long as changes improve the maintainability and legibility of the code, there is no reason to refuse them. -- Raphael S. Carvalho -- To unsubscribe from this list: send the line "unsubscribe linux-

Fwd: [PATCH 1/1] staging/speakup/kobjects.c: Code improvement.

2013-09-08 Thread Raphael S Carvalho
, var_data->u.n.low, var_data->u.n.high); } > > > if (param->var_id == VOICE && ret != -ERANGE) { > > Or possibly better: > if (param->var_id == VOICE && ret == 0) { > > I'd say please res

[PATCH 1/1] staging/speakup/kobjects.c: Code improvement.

2013-06-21 Thread Raphael S. Carvalho
tween using cp and buf in VAR_STRING case. Besides, buf is a const char and those changes remove one uneeded line. I created the function spk_reset_default_value because it clarifies the code and allows code reusing. Signed-off-by: Raphael S. Carvalho --- drivers/staging/speakup/ko

[PATCH 1/1] kernel/pid.c: Moving statement.

2013-06-10 Thread Raphael S. Carvalho
Moving statement to static initilization of init_pid_ns. Signed-off-by: Raphael S. Carvalho --- kernel/pid.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/pid.c b/kernel/pid.c index 0db3e79..c577d3c 100644 --- a/kernel/pid.c +++ b/kernel/pid.c @@ -75,6 +75,7

[PATCH 1/1] kernel/pid.c: Masking the flag out to get the actual value.

2013-06-10 Thread Raphael S. Carvalho
This patch shouldn't be applied if those branches must only be taken when the pid_allocation(PIDNS_HASH_ADDING) flag was turned off. Otherwise, we must turn the PIDNS_HASH_ADDING flag (1U << 31) off before getting into the switch-cases. Signed-off-by: Raphael S. Carvalho --- kernel/p

[PATCH 1/1] kernel/auditfilter.c: Fixing a warning. GCC warning message: kernel/auditfilter.c:426: warning: this decimal constant is unsigned only in ISO C90

2013-05-22 Thread Raphael S. Carvalho
Signed-off-by: Raphael S. Carvalho --- kernel/auditfilter.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c index 83a2970..3f3f837 100644 --- a/kernel/auditfilter.c +++ b/kernel/auditfilter.c @@ -423,7 +423,7 @@ static struct

Re: [PATCH 1/1] kernel/pid.c: Improve flow of a loop inside alloc_pidmap.

2013-03-11 Thread Raphael S Carvalho
On Mon, Mar 11, 2013 at 6:57 PM, Andrew Morton wrote: > On Mon, 11 Mar 2013 18:18:56 -0300 "Raphael S. Carvalho" > wrote: > >> From: Raphael S.Carvalho >> >> Notes: find_next_offset searches for an available "cleaned bit" >> in the respect

[PATCH 1/1] kernel/pid.c: Improve flow of a loop inside alloc_pidmap.

2013-03-11 Thread Raphael S. Carvalho
led again afterwards. Signed-off-by: Raphael S. Carvalho --- kernel/pid.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/pid.c b/kernel/pid.c index 047dc62..7ecb09a 100644 --- a/kernel/pid.c +++ b/kernel/pid.c @@ -190,8 +190,8 @@ static int alloc

[PATCH 1/1] scripts/gen_sendmail.py: Script Added: Generate git send-email arguments automatically!

2013-03-08 Thread Raphael S. Carvalho
send-email --from "Raphael S. Carvalho " --to "Eric W. Biederman " --to "Andrew Morton " --to "Serge E. Hallyn " --to "Serge Hallyn " --to "David S. Miller " --cc "linux-kernel@vger.kernel.org" 0001-kernel-pid.c-Improve-flow-o

Re: [PATCH 1/1] kernel/pid_namespace.c: Fixing a lack of cleanup (Probable resources leak).

2013-03-04 Thread Raphael S Carvalho
On Tue, Mar 5, 2013 at 12:51 AM, Gao feng wrote: > On 2013/03/05 11:26, Eric W. Biederman wrote: >> From: Raphael S.Carvalho >> >> Starting point: create_pid_namespace() >> >> Suppose create_pid_cachep() was executed sucessfully, thus: >> pcache was allocated by kmalloc(). >> cachep received a ca

About namespaces and unshare() syscall.

2013-03-03 Thread Raphael S Carvalho
Hi Eric W. Biederman and Serge Hallyn, I'm a newcomer to Linux kernel Development, and I really like the way Linux manages namespaces. By the way, I'm studying how copy_process() deals with it. I mean, sharing namespaces by default and duplicating namespaces on demand. I would appreciate if you ca

[PATCH 1/1] arch/x86/kvm/cpuid.c: cpuid_maxphyaddr "bad" handling.

2012-11-30 Thread Raphael S Carvalho
Well, the below function reports the physical-address width supported by the processor. It does its work very well, though I found a detail which it doesn't handle at all. PS: The following function is not a patch. int cpuid_maxphyaddr(struct kvm_vcpu *vcpu) { struct kvm_cpuid_entry2 *best

[PATCH 1/1] arch/x86/kvm/cpuid.c: cpuid_maxphyaddr "bad" handling.

2012-11-29 Thread Raphael S Carvalho
Well, the below function reports the physical-address width supported by the processor. It does its work very well, though I found a detail which it doesn't handle at all. PS: The following function is not a patch. int cpuid_maxphyaddr(struct kvm_vcpu *vcpu) { struct kvm_cpuid_entry2 *best