Re: [PATCH v3] lib: Convert test_printf.c to KUnit

2020-11-04 Thread Rasmus Villemoes
On 03/11/2020 17.11, Petr Mladek wrote: > On Tue 2020-11-03 12:52:23, Greg KH wrote: >> On Tue, Nov 03, 2020 at 01:33:53PM +0200, Andy Shevchenko wrote: >>> On Tue, Nov 03, 2020 at 04:40:49PM +0530, Arpitha Raghunandan wrote: Convert test lib/test_printf.c to KUnit. More information about

Re: [EXT] Re: [v2 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A external interrupt

2020-11-03 Thread Rasmus Villemoes
On 02/11/2020 22.22, Leo Li wrote: >>> >>> Where did you get this information that the register on LS1043 and >>> LS1046 is bit reversed? I cannot find such information in the RM. >>> And does this mean all other SCFG registers are also bit reversed? If >>> this is some information that is not

Re: [PATCH 0/4] deterministic random testing

2020-10-30 Thread Rasmus Villemoes
On 26/10/2020 11.59, Andy Shevchenko wrote: > On Sun, Oct 25, 2020 at 10:48:38PM +0100, Rasmus Villemoes wrote: >> This is a bit of a mixed bag. >> >> The background is that I have some sort() and list_sort() rework >> planned, but as part of that series I want to extend

Re: [PATCH] seqlock: avoid -Wshadow warnings

2020-10-28 Thread Rasmus Villemoes
On 28/10/2020 00.34, Arnd Bergmann wrote: > On Mon, Oct 26, 2020 at 5:58 PM Peter Zijlstra wrote: >> >> On Mon, Oct 26, 2020 at 05:50:38PM +0100, Arnd Bergmann wrote: >> >>> - unsigned seq; \ >>> + unsigned __seq;

Re: [PATCH] printf: fix Woverride-init warning for EDEADLK errno

2020-10-27 Thread Rasmus Villemoes
On 27/10/2020 10.12, Petr Mladek wrote: > On Tue 2020-10-27 09:46:28, Arnd Bergmann wrote: >> On Tue, Oct 27, 2020 at 8:23 AM Rasmus Villemoes >> wrote: >>> On 26/10/2020 22.49, Arnd Bergmann wrote: >>>> From: Arnd Bergmann >>> >>&g

Re: [v2 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A external interrupt

2020-10-27 Thread Rasmus Villemoes
> index 4d1179fed77c..9587bc2607fc 100644 > --- a/drivers/irqchip/irq-ls-extirq.c > +++ b/drivers/irqchip/irq-ls-extirq.c > @@ -1,5 +1,8 @@ > // SPDX-License-Identifier: GPL-2.0 > - > +/* > + * Author: Rasmus Villemoes If I wanted my name splattered all over the files

Re: [PATCH] printf: fix Woverride-init warning for EDEADLK errno

2020-10-27 Thread Rasmus Villemoes
On 27/10/2020 08.23, Rasmus Villemoes wrote: > How about we do this instead? > > From: Rasmus Villemoes Missed: Subject: lib/errname.o: disable -Woverride-init > > The table of errno value->name contains a few duplicate entries since > e.g. EDEADLK == EDEADLOCK

Re: [PATCH] printf: fix Woverride-init warning for EDEADLK errno

2020-10-27 Thread Rasmus Villemoes
spite EDEADLK being the by far the most used symbol. See the comments and original commit log, the placement of these is deliberate. How about we do this instead? From: Rasmus Villemoes The table of errno value->name contains a few duplicate entries since e.g. EDEADLK == EDEADLOCK on most architectures

Re: [RESEND 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A external interrupt

2020-10-26 Thread Rasmus Villemoes
On 26/10/2020 09.44, Marc Zyngier wrote: > On 2020-10-26 08:01, Biwen Li wrote: >> From: Hou Zhiqiang >> >> Add an new IRQ chip declaration for LS1043A and LS1088A >> - compatible "fsl,ls1043a-extirq" for LS1043A, LS1046A >> - compatible "fsl,ls1088a-extirq" for LS1088A, LS208xA, LX216xA > >

[PATCH 2/4] kselftest_module.h: unconditionally expand the KSTM_MODULE_GLOBALS() macro

2020-10-25 Thread Rasmus Villemoes
by the time the compiler parses kstm_report(). Signed-off-by: Rasmus Villemoes --- Documentation/dev-tools/kselftest.rst | 2 -- lib/test_bitmap.c | 3 --- lib/test_printf.c | 2 -- lib/test_strscpy.c | 2 -- tools

[PATCH 1/4] prandom.h: add *_state variant of prandom_u32_max

2020-10-25 Thread Rasmus Villemoes
in a given range. Signed-off-by: Rasmus Villemoes --- include/linux/prandom.h | 29 + 1 file changed, 29 insertions(+) diff --git a/include/linux/prandom.h b/include/linux/prandom.h index aa16e6468f91e79e1f31..58ffcd56c705be34fb98 100644 --- a/include/linux/prandom.h +++ b

[PATCH 3/4] kselftest_module.h: add struct rnd_state and seed parameter

2020-10-25 Thread Rasmus Villemoes
t one test failing. Signed-off-by: Rasmus Villemoes --- tools/testing/selftests/kselftest_module.h | 35 -- 1 file changed, 32 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/kselftest_module.h b/tools/testing/selftests/kselftest_module.h index c81c0b0c05

[PATCH 4/4] lib/test_printf.c: use deterministic sequence of random numbers

2020-10-25 Thread Rasmus Villemoes
ed used was 0x9f72eee1c9dc02e5 modprobe: ERROR: could not insert 'test_printf': Invalid argument Signed-off-by: Rasmus Villemoes --- lib/test_printf.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/lib/test_printf.c b/lib/test_printf.c index 1ed4a27390cb621715a

[PATCH 0/4] deterministic random testing

2020-10-25 Thread Rasmus Villemoes
113710.GA26290@alley/ Rasmus Villemoes (4): prandom.h: add *_state variant of prandom_u32_max kselftest_module.h: unconditionally expand the KSTM_MODULE_GLOBALS() macro kselftest_module.h: add struct rnd_state and seed parameter lib/test_printf.c: use deterministic sequence of random num

[PATCH] watchdog: sbc_fitpc2_wdt: add __user annotations

2020-10-25 Thread Rasmus Villemoes
the prototype of file_operations::write. Reported-by: kernel test robot Signed-off-by: Rasmus Villemoes --- drivers/watchdog/sbc_fitpc2_wdt.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/watchdog/sbc_fitpc2_wdt.c b/drivers/watchdog/sbc_fitpc2_wdt.c index

[PATCH] kernel/sys.c: fix prototype of prctl_get_tid_address()

2020-10-23 Thread Rasmus Villemoes
tid_addr is not a "pointer to (pointer to int in userspace)"; it is in fact a "pointer to (pointer to int in userspace) in userspace". So sparse rightfully complains about passing a kernel pointer to put_user(). Reported-by: kernel test robot Signed-off-by: Rasmus Villemoe

[PATCH] drm/ttm: add __user annotation in radeon_ttm_vram_read

2020-10-23 Thread Rasmus Villemoes
Keep sparse happy by preserving the __user annotation when casting. Reported-by: kernel test robot Signed-off-by: Rasmus Villemoes --- kernel test robot has already started spamming me due to 9c5743dff. If I don't fix those warnings I'll keep getting those emails for months, so let me do

[PATCH 4.9-stable] scripts/setlocalversion: make git describe output more reliable

2020-10-23 Thread Rasmus Villemoes
d upstream.] Signed-off-by: Rasmus Villemoes Signed-off-by: Masahiro Yamada --- scripts/setlocalversion | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/scripts/setlocalversion b/scripts/setlocalversion index aa28c3f29809314bfa58..0c8741b795d0c82a3

[PATCH 4.4-stable] scripts/setlocalversion: make git describe output more reliable

2020-10-23 Thread Rasmus Villemoes
d upstream.] Signed-off-by: Rasmus Villemoes Signed-off-by: Masahiro Yamada --- scripts/setlocalversion | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/scripts/setlocalversion b/scripts/setlocalversion index aa28c3f29809314bfa58..0c8741b795d0c82a3

[PATCH] x86/uaccess: fix code generation in put_user()

2020-10-23 Thread Rasmus Villemoes
l_pu must be the last thing computed before the asm() is entered. Cc: Sean Christopherson Reported-by: Naresh Kamboju Tested-by: Naresh Kamboju Fixes: d55564cfc222 ("x86: Make __put_user() generate an out-of-line call") Signed-off-by: Rasmus Villemoes --- I tried to put together a

Re: [PATCH v2] lib: Convert test_printf.c to KUnit

2020-10-23 Thread Rasmus Villemoes
On 22/10/2020 21.16, Andy Shevchenko wrote: > On Thu, Oct 22, 2020 at 08:43:49PM +0530, Arpitha Raghunandan wrote: >> Convert test lib/test_printf.c to KUnit. More information about >> KUnit can be found at: >> https://www.kernel.org/doc/html/latest/dev-tools/kunit/index.html. >> KUnit provides a

Re: [LTP] mmstress[1309]: segfault at 7f3d71a36ee8 ip 00007f3d77132bdf sp 00007f3d71a36ee8 error 4 in libc-2.27.so[7f3d77058000+1aa000]

2020-10-23 Thread Rasmus Villemoes
On 23/10/2020 07.02, Sean Christopherson wrote: > On Thu, Oct 22, 2020 at 08:05:05PM -0700, Linus Torvalds wrote: >> On Thu, Oct 22, 2020 at 6:36 PM Daniel Díaz wrote: >>> >>> The kernel Naresh originally referred to is here: >>> https://builds.tuxbuild.com/SCI7Xyjb7V2NbfQ2lbKBZw/ >> >> Thanks.

[PATCH] Kbuild.include: remove leftover comment for filechk utility

2020-10-16 Thread Rasmus Villemoes
After commit 43fee2b23895 ("kbuild: do not redirect the first prerequisite for filechk"), the rule is no longer automatically passed $< as stdin, so remove the stale comment. Fixes: 43fee2b23895 ("kbuild: do not redirect the first prerequisite for filechk") Signed-o

Re: [GIT PULL] printk for 5.10 (includes lockless ringbuffer)

2020-10-14 Thread Rasmus Villemoes
On 14/10/2020 16.16, Geert Uytterhoeven wrote: > Hi Petr, > > On Mon, Oct 12, 2020 at 4:50 PM Petr Mladek wrote: >> - Fully lockless ringbuffer implementation, including the support for >> continuous lines. It will allow to store and read messages in any >> situation wihtout the risk of

Re: using one gpio for multiple dht22 sensors

2020-10-14 Thread Rasmus Villemoes
On 14/10/2020 11.12, Peter Rosin wrote: > Hi Rasnus, > > On 2020-10-13 23:34, Rasmus Villemoes wrote: >> Hi Peter >> >> I'm going to hook up a bunch of dht22 humidity (and temperature) sensors >> [1] (drivers/iio/humidity/dht11.c), but partly due to limited numbe

Re: [PATCH 1/2] fs, close_range: add flag CLOSE_RANGE_CLOEXEC

2020-10-14 Thread Rasmus Villemoes
On 13/10/2020 23.09, Al Viro wrote: > On Tue, Oct 13, 2020 at 04:06:08PM +0200, Giuseppe Scrivano wrote: >> +spin_lock(_fds->file_lock); >> +fdt = files_fdtable(cur_fds); >> +cur_max = fdt->max_fds - 1; >> +max_fd = min(max_fd, cur_max); >> +

using one gpio for multiple dht22 sensors

2020-10-14 Thread Rasmus Villemoes
Hi Peter Since you're the author of io-channel-mux.txt, gpio-mux.txt and mux-controller.txt, I hope you don't mind me asking some perhaps silly questions. I'm going to hook up a bunch of dht22 humidity (and temperature) sensors [1] (drivers/iio/humidity/dht11.c), but partly due to limited number

Re: [PATCH 1/2] fs, close_range: add flag CLOSE_RANGE_CLOEXEC

2020-10-13 Thread Rasmus Villemoes
On 13/10/2020 22.54, Christian Brauner wrote: > On Tue, Oct 13, 2020 at 04:06:08PM +0200, Giuseppe Scrivano wrote: > > Hey Guiseppe, > > Thanks for the patch! > >> When the flag CLOSE_RANGE_CLOEXEC is set, close_range doesn't >> immediately close the files but it sets the close-on-exec bit. >

Re: [GIT PULL] io_uring updates for 5.10-rc1

2020-10-13 Thread Rasmus Villemoes
On 13/10/2020 21.49, Jens Axboe wrote: > On 10/13/20 1:46 PM, Linus Torvalds wrote: >> On Mon, Oct 12, 2020 at 6:46 AM Jens Axboe wrote: >>> >>> Here are the io_uring updates for 5.10. >> >> Very strange. My clang build gives a warning I've never seen before: >> >>

Re: [PATCH] kcmp: add separate Kconfig symbol for kcmp syscall

2020-10-13 Thread Rasmus Villemoes
On 10/07/2020 17.57, Matthew Wilcox wrote: > On Fri, Jul 10, 2020 at 09:56:31AM +0200, Rasmus Villemoes wrote: >> The ability to check open file descriptions for equality (without >> resorting to unreliable fstat() and fcntl(F_GETFL) comparisons) can be >> useful outside of t

Re: [PATCH] lib: Convert test_printf.c to KUnit

2020-10-13 Thread Rasmus Villemoes
On 12/10/2020 22.46, Brendan Higgins wrote: > On Fri, Aug 21, 2020 at 03:28:49PM +0300, Andy Shevchenko wrote: >> On Fri, Aug 21, 2020 at 01:37:10PM +0200, Petr Mladek wrote: >>> On Mon 2020-08-17 09:06:32, Rasmus Villemoes wrote: >>>> On 17/08/2020 06.30, Arpitha Rag

Re: [PATCH] bcache: Use #ifdef instead of boolean variable

2020-10-09 Thread Rasmus Villemoes
On 09/10/2020 20.34, Alex Dewar wrote: > The variable async_registration is used to indicate whether or not > CONFIG_BCACHE_ASYNC_REGISTRATION is enabled, triggering a (false) > warning in Coverity about unreachable code. However, it seems clearer in > this case just to use an #ifdef, so let's do

Re: [PATCH printk 3/5] printk: use buffer pool for sprint buffers

2020-10-01 Thread Rasmus Villemoes
On 30/09/2020 15.35, Steven Rostedt wrote: > On Wed, 30 Sep 2020 10:06:24 +0200 > Rasmus Villemoes wrote: > >> True. But remember that printk is called from _everywhere_, with all >> sorts of locks held and/or preemption disabled or whatnot, and every >> cycle spent in

Re: [PATCH printk 3/5] printk: use buffer pool for sprint buffers

2020-09-30 Thread Rasmus Villemoes
On 25/09/2020 10.28, Petr Mladek wrote: > On Thu 2020-09-24 14:32:49, Rasmus Villemoes wrote: >> On 24/09/2020 11.54, Rasmus Villemoes wrote: >>> On 23/09/2020 17.11, Petr Mladek wrote: >>>> On Tue 2020-09-22 17:44:14, John Ogness wrote: >>>>> vp

Re: [PATCH v1 0/6] seccomp: Implement constant action bitmaps

2020-09-24 Thread Rasmus Villemoes
On 24/09/2020 15.58, YiFei Zhu wrote: > On Thu, Sep 24, 2020 at 8:46 AM Rasmus Villemoes > wrote: >> But one thing I'm wondering about and I haven't seen addressed anywhere: >> Why build the bitmap on the kernel side (with all the complexity of >> having to emulate the

Re: [PATCH v1 0/6] seccomp: Implement constant action bitmaps

2020-09-24 Thread Rasmus Villemoes
On 24/09/2020 01.29, Kees Cook wrote: > rfc: > https://lore.kernel.org/lkml/20200616074934.1600036-1-keesc...@chromium.org/ > alternative: > https://lore.kernel.org/containers/cover.1600661418.git.yifei...@illinois.edu/ > v1: > - rebase to for-next/seccomp > - finish X86_X32 support for both

Re: [PATCH printk 3/5] printk: use buffer pool for sprint buffers

2020-09-24 Thread Rasmus Villemoes
On 24/09/2020 11.54, Rasmus Villemoes wrote: > On 23/09/2020 17.11, Petr Mladek wrote: >> On Tue 2020-09-22 17:44:14, John Ogness wrote: >>> vprintk_store() is using a single static buffer as a temporary >>> sprint buffer for the message text. This will not work once

Re: [PATCH printk 3/5] printk: use buffer pool for sprint buffers

2020-09-24 Thread Rasmus Villemoes
On 23/09/2020 17.11, Petr Mladek wrote: > On Tue 2020-09-22 17:44:14, John Ogness wrote: >> vprintk_store() is using a single static buffer as a temporary >> sprint buffer for the message text. This will not work once >> @logbuf_lock is removed. Replace the single static buffer with a >> pool of

Re: [PATCH printk 3/5] printk: use buffer pool for sprint buffers

2020-09-24 Thread Rasmus Villemoes
On 24/09/2020 10.53, Sergey Senozhatsky wrote: > On (20/09/24 10:45), Petr Mladek wrote: >> On Thu 2020-09-24 14:40:58, Sergey Senozhatsky wrote: >>> On (20/09/23 17:11), Petr Mladek wrote: AFAIK, there is one catch. We need to use va_copy() around the 1st call because va_format can

Re: WARNING in ex_handler_uaccess

2020-09-21 Thread Rasmus Villemoes
On 19/09/2020 02.17, Al Viro wrote: > On Fri, Sep 18, 2020 at 05:07:43PM -0700, Andy Lutomirski wrote: >> On Fri, Sep 18, 2020 at 4:55 PM Al Viro wrote: >>> >>> On Fri, Sep 18, 2020 at 04:31:33PM -0700, Andy Lutomirski wrote: >>> check_zeroed_user() looks buggy. It does: if

Re: [PATCH printk 2/3] printk: move dictionary keys to dev_printk_info

2020-09-18 Thread Rasmus Villemoes
On 18/09/2020 14.13, Petr Mladek wrote: > On Fri 2020-09-18 08:16:37, Rasmus Villemoes wrote: >> On 17/09/2020 15.16, John Ogness wrote: >> >>> if (dev->class) >>> subsys = dev->class->name; >>> else if (dev->bus)

Re: [PATCH printk 2/3] printk: move dictionary keys to dev_printk_info

2020-09-18 Thread Rasmus Villemoes
On 17/09/2020 15.16, John Ogness wrote: > if (dev->class) > subsys = dev->class->name; > else if (dev->bus) > subsys = dev->bus->name; > else > - return 0; > + return; > > - pos += snprintf(hdr + pos, hdrlen - pos,

Re: [PATCH v2] scripts/setlocalversion: make git describe output more reliable

2020-09-17 Thread Rasmus Villemoes
On 17/09/2020 14.22, Nico Schottelius wrote: > > Thanks for the patch Rasmus. Overall it looks good to me, be aligned to > the stable patch submission rules makes sense. A tiny thing though: > > I did not calculate the exact collision probability with 12 characters For reference, the math is

[PATCH v2] scripts/setlocalversion: make git describe output more reliable

2020-09-17 Thread Rasmus Villemoes
rrent rule for -stable patches, and is almost always enough to identify the head commit unambigously - in the few cases where it does not, the v5.4.3-00021- prefix would certainly nail it down. Signed-off-by: Rasmus Villemoes --- v2: use 12 instead of 15, and ensure that the result does have exac

Re: [PATCH] scripts/setlocalversion: make git describe output more reliable

2020-09-16 Thread Rasmus Villemoes
On 16/09/2020 16.28, Masahiro Yamada wrote: > On Fri, Sep 11, 2020 at 5:28 PM Rasmus Villemoes > wrote: >> >> On 10/09/2020 21.05, Brian Norris wrote: >>> On Thu, Sep 10, 2020 at 7:35 AM Masahiro Yamada >>> wrote: >>>> On Thu, Sep 10, 2020 a

Re: [PATCH] scripts/setlocalversion: make git describe output more reliable

2020-09-16 Thread Rasmus Villemoes
On 16/09/2020 20.01, Masahiro Yamada wrote: > On Thu, Sep 17, 2020 at 12:23 AM Rasmus Villemoes > wrote: >> >> On 16/09/2020 16.28, Masahiro Yamada wrote: >>> On Fri, Sep 11, 2020 at 5:28 PM Rasmus Villemoes >>> wrote: >>>> >>> Why do

Re: [PATCH] scripts/setlocalversion: make git describe output more reliable

2020-09-16 Thread Rasmus Villemoes
On 10/09/2020 16.34, Masahiro Yamada wrote: > On Thu, Sep 10, 2020 at 8:57 PM Rasmus Villemoes > wrote: >> ... >> >> So in order to avoid `uname -a` output relying on such random details >> of the build environment which are rather hard to ensure are >> consist

Re: [PATCH] scripts/setlocalversion: make git describe output more reliable

2020-09-11 Thread Rasmus Villemoes
On 10/09/2020 21.05, Brian Norris wrote: > On Thu, Sep 10, 2020 at 7:35 AM Masahiro Yamada wrote: >> On Thu, Sep 10, 2020 at 8:57 PM Rasmus Villemoes >> wrote: >>> So in order to avoid `uname -a` output relying on such random details >>> of the build environmen

[PATCH] scripts/setlocalversion: make git describe output more reliable

2020-09-10 Thread Rasmus Villemoes
with some other object in the first 15 hex chars is less than 1e-10, and currently a git repo tracking Linus', -stable and -rt only has around 10M objects. Signed-off-by: Rasmus Villemoes --- I could probably fix things by adding a 'git config --local core.abbrev 15' step to the Yocto build pro

Re: [PATCH] /dev/zero: also implement ->read

2020-09-07 Thread Rasmus Villemoes
On 07/09/2020 08.20, Christoph Hellwig wrote: > On Mon, Sep 07, 2020 at 12:34:37AM +0200, Rasmus Villemoes wrote: >> On 03/09/2020 17.59, Christoph Hellwig wrote: > >>> +static ssize_t read_zero(struct file *file, char __user *buf, >>> +

Re: [PATCH] /dev/zero: also implement ->read

2020-09-06 Thread Rasmus Villemoes
On 03/09/2020 17.59, Christoph Hellwig wrote: > Christophe reported a major speedup due to avoiding the iov_iter > overhead, so just add this trivial function. Note that /dev/zero > already implements both an iter and non-iter writes so this just > makes it more symmetric. > > Christophe Leroy

Re: [PATCH rdma-next 2/4] gcov: Use proper duplication routine for const pointer

2020-09-03 Thread Rasmus Villemoes
On 02/09/2020 10.55, Leon Romanovsky wrote: > From: Leon Romanovsky > > The filename is a const pointer, so use the proper string duplication > routine that takes into account const identifier. This commit log makes no sense at all. kstrdup_const is merely an optimization that can be used when

Re: [PATCH 2/2] mtd: spi-nor: enable lock interface for macronix chips

2020-08-31 Thread Rasmus Villemoes
On 12/08/2020 17.18, Ivan Mikhaylov wrote: > Add locks for whole macronix chip series with BP0-2 and BP0-3 bits. > > Tested with mx25l51245g(BP0-3). Hmm. I've tried adding support for locking on Macronix to U-Boot

Re: [PATCH] linux/kernel.h: add container_from()

2020-08-27 Thread Rasmus Villemoes
On 27/08/2020 03.36, Allen Pais wrote: > Introduce container_from() as a generic helper instead of > sub-systems defining a private from_* API > (Eg: from_tasklets recently introduced in > 12cc923f1ccc: Tasklet: Introduce new initialization API) > > The helper is similar to container_of() in

Re: [PATCH] usb: atm: don't use snprintf() for sysfs attrs

2020-08-27 Thread Rasmus Villemoes
On 27/08/2020 15.18, Alex Dewar wrote: > On Thu, Aug 27, 2020 at 09:15:37AM +0200, Greg Kroah-Hartman wrote: >> On Thu, Aug 27, 2020 at 08:42:06AM +0200, Rasmus Villemoes wrote: >>> On 25/08/2020 00.23, Alex Dewar wrote: >>>> kernel/cpu.c: don't use snprintf() fo

Re: [PATCH] usb: atm: don't use snprintf() for sysfs attrs

2020-08-27 Thread Rasmus Villemoes
On 25/08/2020 00.23, Alex Dewar wrote: > kernel/cpu.c: don't use snprintf() for sysfs attrs > > As per the documentation (Documentation/filesystems/sysfs.rst), > snprintf() should not be used for formatting values returned by sysfs. > Sure. But then the security guys come along and send a patch

Re: [PATCH] checkpatch: Allow not using -f with files that are in git

2020-08-25 Thread Rasmus Villemoes
On 25/08/2020 02.09, Joe Perches wrote: > If a file exists in git and checkpatch is used without the -f > flag for scanning a file, then checkpatch will scan the file > assuming it's a patch and emit: > > ERROR: Does not appear to be a unified-diff format patch > > Change the behavior to assume

Re: [PATCH] lib: Convert test_printf.c to KUnit

2020-08-21 Thread Rasmus Villemoes
On 21/08/2020 13.37, Petr Mladek wrote: > On Mon 2020-08-17 09:06:32, Rasmus Villemoes wrote: >> On 17/08/2020 06.30, Arpitha Raghunandan wrote: >>> Converts test lib/test_printf.c to KUnit. >>> More information about KUnit can be found at >>> https://www.kernel

Re: [PATCH 0/4] -ffreestanding/-fno-builtin-* patches

2020-08-21 Thread Rasmus Villemoes
On 20/08/2020 19.56, Arvind Sankar wrote: > On Thu, Aug 20, 2020 at 04:56:02PM +0200, Rasmus Villemoes wrote: >> On 18/08/2020 23.41, Arvind Sankar wrote: >>> >>> Note that -fno-builtin-foo seems to mean slightly different things in >>> clang and gcc. From

Re: [PATCH 0/4] -ffreestanding/-fno-builtin-* patches

2020-08-20 Thread Rasmus Villemoes
On 18/08/2020 23.41, Arvind Sankar wrote: > On Tue, Aug 18, 2020 at 01:58:51PM -0700, Nick Desaulniers wrote: >> On Tue, Aug 18, 2020 at 1:27 PM Nick Desaulniers >> wrote: >>> >>> On Tue, Aug 18, 2020 at 1:24 PM Arvind Sankar wrote: On Tue, Aug 18, 2020 at 12:13:22PM -0700, Linus

Re: [PATCH v2] overflow: Add __must_check attribute to check_*() helpers

2020-08-17 Thread Rasmus Villemoes
On 17/08/2020 11.08, David Sterba wrote: > On Sat, Aug 15, 2020 at 10:09:24AM -0700, Kees Cook wrote: >> >> +/* >> + * Allows for effectively applying __must_check to a macro so we can have >> + * both the type-agnostic benefits of the macros while also being able to >> + * enforce that the

Re: [PATCH 08/30] net: wireless: ath: carl9170: Mark 'ar9170_qmap' as __maybe_unused

2020-08-17 Thread Rasmus Villemoes
On 14/08/2020 17.14, Christian Lamparter wrote: > On 2020-08-14 13:39, Lee Jones wrote: >> 'ar9170_qmap' is used in some source files which include carl9170.h, >> but not all of them.  Mark it as __maybe_unused to show that this is >> not only okay, it's expected. >> >> Fixes the following W=1

Re: [PATCH] lib: Convert test_printf.c to KUnit

2020-08-17 Thread Rasmus Villemoes
On 17/08/2020 06.30, Arpitha Raghunandan wrote: > Converts test lib/test_printf.c to KUnit. > More information about KUnit can be found at > https://www.kernel.org/doc/html/latest/dev-tools/kunit/index.html. > KUnit provides a common framework for unit tests in the kernel. So I can continue to

Re: [PATCH] overflow: Add __must_check attribute to check_*() helpers

2020-08-13 Thread Rasmus Villemoes
On 13/08/2020 13.23, Matthew Wilcox wrote: > On Wed, Aug 12, 2020 at 02:51:52PM -0700, Kees Cook wrote: >> +/* >> + * Allows to effectively us apply __must_check to a macro so we can have >> + * both the type-agnostic benefits of the macros while also being able to >> + * enforce that the return

Re: [PATCH RT 1/6] signal: Prevent double-free of user struct

2020-08-13 Thread Rasmus Villemoes
On 13/08/2020 03.45, Steven Rostedt wrote: > 5.4.54-rt33-rc1 stable review patch. > If anyone has any objections, please let me know. > No objections, quite the contrary. I think this should also be applied to 4.19-rt: Commit fda31c50292a is also in 4.19.y (as 797479da0ae9), since 4.19.112 and

Re: [PATCH] overflow: Add __must_check attribute to check_*() helpers

2020-08-13 Thread Rasmus Villemoes
tatic inline that is marked with __must_check. This means > the macros can continue to have their type-agnostic behavior while gaining > the function attribute (that cannot be applied directly to macros). > > Suggested-by: Rasmus Villemoes > Signed-off-by: Kees Cook > --- &g

Re: [PATCH linux-5.2.y-rt only] hrtimer: correct the logic for grab expiry lock

2020-08-12 Thread Rasmus Villemoes
On 12/08/2020 12.50, zhantao.t...@windriver.com wrote: > From: Zhantao Tang > > In commit: 47b6de0b7f22 ("hrtimer: Add a missing bracket and hide > `migration_base' on !SMP") > a inline function is_migration_base() is introduced. But > the logic of the hrtimer_grab_expiry_lock was changed. > >

Re: [RFC] saturate check_*_overflow() output?

2020-08-05 Thread Rasmus Villemoes
On 04/08/2020 21.23, Kees Cook wrote: > On Tue, Aug 04, 2020 at 08:11:45AM +0200, Rasmus Villemoes wrote: >> What we might do, to deal with the "caller fails to check the result", >> is to add a >> >> static inline bool __must_check must_check_ov

Re: [RFC] saturate check_*_overflow() output?

2020-08-04 Thread Rasmus Villemoes
On 03/08/2020 20.29, Kees Cook wrote: > Hi, > > I wonder if we should explicitly saturate the output of the overflow > helpers as a side-effect of overflow detection? Please no. (That way the output > is never available with a "bad" value, if the caller fails to check the > result or forgets

Re: [PATCH] kcmp: add separate Kconfig symbol for kcmp syscall

2020-07-10 Thread Rasmus Villemoes
On 10/07/2020 10.30, Cyrill Gorcunov wrote: > On Fri, Jul 10, 2020 at 09:56:31AM +0200, Rasmus Villemoes wrote: >> The ability to check open file descriptions for equality (without >> resorting to unreliable fstat() and fcntl(F_GETFL) comparisons) can be >> useful outside of t

[PATCH] kcmp: add separate Kconfig symbol for kcmp syscall

2020-07-10 Thread Rasmus Villemoes
to have the kcmp() syscall without the full CONFIG_CHECKPOINT_RESTORE. Signed-off-by: Rasmus Villemoes --- I deliberately drop the ifdef in the eventpoll.h header rather than replace with KCMP_SYSCALL; it's harmless to declare a function that isn't defined anywhere. fs/eventpoll.c| 4

Re: printk of non NULL terminated strings ?

2020-07-09 Thread Rasmus Villemoes
On 09/07/2020 15.26, Joakim Tjernlund wrote: > On Thu, 2020-07-09 at 14:56 +0200, Andreas Schwab wrote: >> CAUTION: This email originated from outside of the organization. Do not >> click links or open attachments unless you recognize the sender and know the >> content is safe. >> >> >> On Jul

Re: [sched] c3a340f7e7: invalid_opcode:#[##]

2020-06-30 Thread Rasmus Villemoes
On 30/06/2020 14.46, Peter Zijlstra wrote: > On Mon, Jun 29, 2020 at 08:31:27AM +0800, kernel test robot wrote: >> Greeting, >> >> FYI, we noticed the following commit (built with gcc-4.9): >> >> commit: c3a340f7e7eadac7662ab104ceb16432e5a4c6b2 ("sched: Have >> sched_class_highest define by

Re: [PATCH v3 bpf-next 4/8] printk: add type-printing %pT format specifier which uses BTF

2020-06-23 Thread Rasmus Villemoes
On 23/06/2020 14.07, Alan Maguire wrote: > diff --git a/include/linux/printk.h b/include/linux/printk.h > index fc8f03c..8f8f5d2 100644 > --- a/include/linux/printk.h > +++ b/include/linux/printk.h > @@ -618,4 +618,20 @@ static inline void print_hex_dump_debug(const char > *prefix_str, int

Re: [PATCH v3 00/21] dynamic_debug cleanups, query features, export

2020-06-17 Thread Rasmus Villemoes
On 17/06/2020 18.25, Jim Cromie wrote: > this is v3, changes from previous: > - moved non-controversial commits up front, refactors to help this. > - a few more minor cleanups > - left out the WIP patches > - export ddebug_exec_queries() > - accept file=foo:func only, not module:foo > -

Re: WIP generic module->debug_flags and dynamic_debug

2020-06-11 Thread Rasmus Villemoes
On 10/06/2020 20.32, jim.cro...@gmail.com wrote: > so Ive got a WIP / broken / partial approach to giving all modules a > u32 flagset, > and enabling pr_debug based upon it. I leave out the "pr_debug_typed( > bitpos )" for now. For Stanimir, bits 1,2,3 could be high, middle, > low. > > ATM its

must populate_rootfs be synchronous?

2020-06-10 Thread Rasmus Villemoes
I have worked on several boards where there is a rather "aggressive" external (gpio) watchdog, with timeouts between 250 and 800 ms. Combined with a rather slow CPU and memory, these boards often fail to make it through populate_rootfs, since unpacking the initramfs is rather time-consuming, and

Re: [PATCH resend] fs/namei.c: micro-optimize acl_permission_check

2020-06-08 Thread Rasmus Villemoes
On 07/06/2020 21.48, Linus Torvalds wrote: > On Sun, Jun 7, 2020 at 9:37 AM Linus Torvalds > wrote: >> >>> That will kinda work, except you do that mask &= MAY_RWX before >>> check_acl(), which cares about MAY_NOT_BLOCK and who knows what other bits. >> >> Good catch. > > With the change to not

Re: [PATCH resend] fs/namei.c: micro-optimize acl_permission_check

2020-06-07 Thread Rasmus Villemoes
On 05/06/2020 22.18, Linus Torvalds wrote: > On Fri, Jun 5, 2020 at 7:23 AM Rasmus Villemoes > wrote: >> >> + /* >> +* If the "group" and "other" permissions are the same, >> +* the

[PATCH resend] fs/namei.c: micro-optimize acl_permission_check

2020-06-05 Thread Rasmus Villemoes
groups array and in_group_p() .text into the cpu cache. Signed-off-by: Rasmus Villemoes --- fs/namei.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/namei.c b/fs/namei.c index d81f73ff1a8b..c6f0c6643db5 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -303,7 +303,12 @

Re: [RFC][PATCH 0/4] x86/entry: disallow #DB more

2020-05-25 Thread Rasmus Villemoes
On 23/05/2020 23.32, Peter Zijlstra wrote: > On Sat, May 23, 2020 at 02:59:40PM +0200, Peter Zijlstra wrote: >> On Fri, May 22, 2020 at 03:13:57PM -0700, Andy Lutomirski wrote: > >> Good point, so the trivial optimization is below. I couldn't find >> instruction latency numbers for DRn

Re: [PATCH] sched/fair: Return true,false in voluntary_active_balance()

2020-05-08 Thread Rasmus Villemoes
On 08/05/2020 10.16, Peter Zijlstra wrote: > On Thu, May 07, 2020 at 07:06:25PM +0800, Jason Yan wrote: >> Fix the following coccicheck warning: >> >> kernel/sched/fair.c:9375:9-10: WARNING: return of 0/1 in function >> 'voluntary_active_balance' with return type bool > > That's not a warning,

Re: [PATCH 5/5] rtc: pcf2127: report battery switch over

2020-05-05 Thread Rasmus Villemoes
On 05/05/2020 22.13, Alexandre Belloni wrote: > Add support for the RTC_VL_BACKUP_SWITCH flag to report battery switch over > events. > > Signed-off-by: Alexandre Belloni > --- > drivers/rtc/rtc-pcf2127.c | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git

Re: battery switch-over detection on pcf2127

2020-05-05 Thread Rasmus Villemoes
On 05/05/2020 22.38, Bruno Thomsen wrote: > Hi Rasmus > > Den tir. 5. maj 2020 kl. 22.07 skrev Alexandre Belloni > : >> >> On 05/05/2020 21:54:47+0200, Rasmus Villemoes wrote: >>> Hi Bruno >>> >>> I just noticed your "rtc: pcf2127:

battery switch-over detection on pcf2127

2020-05-05 Thread Rasmus Villemoes
Hi Bruno I just noticed your "rtc: pcf2127: add tamper detection support" (03623b4b04) from 5.4. Unfortunately, clearing the BTSE bit breaks a use case of ours: We rely on the battery switch-over detection to distinguish a powerfail during boot from a PORESET by the external watchdog (in the

Re: [PATCH v4 14/18] static_call: Add static_cond_call()

2020-05-05 Thread Rasmus Villemoes
On 04/05/2020 22.14, Peter Zijlstra wrote: > On Mon, May 04, 2020 at 09:20:03AM +0200, Rasmus Villemoes wrote: > >> >> Indeed, that is horrible. And it "fixes" the argument evaluation by >> changing the !HAVE_STATIC_CALL case to match the HAVE_STATIC

Re: [PATCH v4 14/18] static_call: Add static_cond_call()

2020-05-04 Thread Rasmus Villemoes
On 03/05/2020 14.58, Peter Zijlstra wrote: > On Sat, May 02, 2020 at 03:08:00PM +0200, Rasmus Villemoes wrote: >> On 01/05/2020 22.29, Peter Zijlstra wrote: >>> +#define static_cond_call(name) >>> \ >>>

Re: [PATCH v4 14/18] static_call: Add static_cond_call()

2020-05-02 Thread Rasmus Villemoes
On 01/05/2020 22.29, Peter Zijlstra wrote: > Extend the static_call infrastructure to optimize the following common > pattern: > > if (func_ptr) > func_ptr(args...) > > + > #define static_call(name)__static_call(name) > +#define static_cond_call(name)

Re: [PATCH RT 0/2] Linux v4.19.115-rt50-rc1

2020-04-30 Thread Rasmus Villemoes
On 28/04/2020 21.52, zanu...@kernel.org wrote: > From: Tom Zanussi > > Dear RT Folks, > > This is the RT stable review cycle of patch 4.19.115-rt50-rc1. > > Please scream at me if I messed something up. Please test the patches > too. For good measure, the customer reports that

Re: [RFC PATCH bpf-next 0/6] bpf, printk: add BTF-based type printing

2020-04-29 Thread Rasmus Villemoes
On 20/04/2020 18.32, Joe Perches wrote: > On Mon, 2020-04-20 at 16:29 +0100, Alan Maguire wrote: struct sk_buff *skb = alloc_skb(64, GFP_KERNEL); pr_info("%pTN", skb); >>> >>> why follow "TN" convention? >>> I think "%p" is much more obvious, unambiguous, and >>> equally easy

Re: [RFC PATCH bpf-next 5/6] printk: add type-printing %pT format specifier which uses BTF

2020-04-29 Thread Rasmus Villemoes
On 17/04/2020 12.42, Alan Maguire wrote: > printk supports multiple pointer object type specifiers (printing > netdev features etc). Extend this support using BTF to cover > arbitrary types. "%pT" specifies the typed format, and a suffix > enclosed specifies the type, for example, specifying >

[PATCH -rt] hrtimer: fix logic for when grabbing softirq_expiry_lock can be elided

2020-04-28 Thread Rasmus Villemoes
using hrtimer_grab_expiry_lock() on migration_base") fixes that lockup. Fixes: 40aae5708e7a (hrtimer: Add a missing bracket and hide `migration_base' on !SMP) # 4.19-rt Fixes: 47b6de0b7f22 (hrtimer: Add a missing bracket and hide `migration_base' on !SMP) # 5.2-rt Signed-off-by: Rasmus

Re: [PATCH RT 10/30] hrtimer: Prevent using hrtimer_grab_expiry_lock() on migration_base

2020-04-28 Thread Rasmus Villemoes
On 28/04/2020 14.59, Tom Zanussi wrote: > On Tue, 2020-04-28 at 09:03 +0200, Rasmus Villemoes wrote: >> Hold on a second. This patch (hrtimer: Prevent using >> hrtimer_grab_expiry_lock() on migration_base) indeed seems to >> implement >> the optimization implied

Re: [PATCH RT 10/30] hrtimer: Prevent using hrtimer_grab_expiry_lock() on migration_base

2020-04-28 Thread Rasmus Villemoes
On 23/01/2020 21.39, Steven Rostedt wrote: > 4.19.94-rt39-rc2 stable review patch. > If anyone has any objections, please let me know. > > -- > > From: Julien Grall > > [ Upstream commit cef1b87f98823af923a386f3f69149acb212d4a1 ] > > As tglx puts it: > |If base ==

Re: [PATCH RT 10/30] hrtimer: Prevent using hrtimer_grab_expiry_lock() on migration_base

2020-04-28 Thread Rasmus Villemoes
On 27/04/2020 21.26, Tom Zanussi wrote: > On Mon, 2020-04-27 at 15:06 -0400, Steven Rostedt wrote: >> On Mon, 27 Apr 2020 15:10:00 +0200 >> Rasmus Villemoes wrote: >> >>> Reverting >>> >>> b1a471ec4df1 - hrtimer: Prevent using hrtimer_grab_expi

Re: [PATCH v4] string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers

2019-10-23 Thread Rasmus Villemoes
out space savings to make it less fluffy > based on Rasmus' feedback. Thanks, it looks good to me. FWIW, Acked-by: Rasmus Villemoes

[PATCH] powerpc/85xx: remove mostly pointless mpc85xx_qe_init()

2019-10-23 Thread Rasmus Villemoes
-off-by: Rasmus Villemoes --- arch/powerpc/platforms/85xx/common.c | 23 --- arch/powerpc/platforms/85xx/corenet_generic.c | 2 -- arch/powerpc/platforms/85xx/mpc85xx.h | 2 -- arch/powerpc/platforms/85xx/mpc85xx_mds.c | 1 - arch/powerpc/platforms/85xx

Re: [PATCH 3/7] soc: fsl: qe: avoid ppc-specific io accessors

2019-10-23 Thread Rasmus Villemoes
On 22/10/2019 17.01, Christophe Leroy wrote: > > > On 10/18/2019 12:52 PM, Rasmus Villemoes wrote: >> In preparation for allowing to build QE support for architectures >> other than PPC, replace the ppc-specific io accessors. Done via >> > > This patch is not tr

Re: [PATCH 0/7] towards QE support on ARM

2019-10-22 Thread Rasmus Villemoes
On 22/10/2019 04.24, Qiang Zhao wrote: > On Mon, Oct 22, 2019 at 6:11 AM Leo Li wrote >> Right. I'm really interested in getting this applied to my tree and make it >> upstream. Zhao Qiang, can you help to review Rasmus's patches and >> comment? > > As you know, I maintained a similar patchset

Re: [PATCH 0/7] towards QE support on ARM

2019-10-22 Thread Rasmus Villemoes
On 22/10/2019 00.11, Li Yang wrote: > On Mon, Oct 21, 2019 at 3:46 AM Rasmus Villemoes > wrote: >> >>> Can you try the 4.14 branch from a newer LSDK release? LS1021a should >>> be supported platform on LSDK. If it is broken, something is wrong. >> >

<    1   2   3   4   5   6   7   8   9   10   >