iable used in
tracing_mark_raw_write().
Finally, for the two runs of spaces, just use variables initialized with
string literals; the linker (at least for x86) will reuse the tail of
the longer for the shorter string.
Signed-off-by: Rasmus Villemoes
---
kernel/trace/ftrace.c | 2 +-
kernel/tra
[trimming cc list]
On 2018-11-01 23:57, Kees Cook wrote:
> On Thu, Nov 1, 2018 at 3:06 PM, Rasmus Villemoes
> wrote:
>> referring to an anonymous object in .rodata; one gets code gen like
>>
>> +: 31 c0 xor%eax,%eax
>> +:
[trimming cc list]
On 2018-11-01 23:57, Kees Cook wrote:
> On Thu, Nov 1, 2018 at 3:06 PM, Rasmus Villemoes
> wrote:
>> referring to an anonymous object in .rodata; one gets code gen like
>>
>> +: 31 c0 xor%eax,%eax
>> +:
This field is never used, might as well remove it.
Signed-off-by: Rasmus Villemoes
---
drivers/char/random.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/char/random.c b/drivers/char/random.c
index 320108df04c1..1b2e1580b4b5 100644
--- a/drivers/char
This field is never used, might as well remove it.
Signed-off-by: Rasmus Villemoes
---
drivers/char/random.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/char/random.c b/drivers/char/random.c
index 320108df04c1..1b2e1580b4b5 100644
--- a/drivers/char
Since the definition of struct crng_state is private to random.c, and
primary_crng is neither declared or used elsewhere, there's no reason
for that symbol to have external linkage.
Signed-off-by: Rasmus Villemoes
---
drivers/char/random.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Never modified, might as well be put in .rodata.
Signed-off-by: Rasmus Villemoes
---
drivers/char/random.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/random.c b/drivers/char/random.c
index 2eb70e76ed35..320108df04c1 100644
--- a/drivers/char/random.c
+++ b
Since the definition of struct crng_state is private to random.c, and
primary_crng is neither declared or used elsewhere, there's no reason
for that symbol to have external linkage.
Signed-off-by: Rasmus Villemoes
---
drivers/char/random.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Never modified, might as well be put in .rodata.
Signed-off-by: Rasmus Villemoes
---
drivers/char/random.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/random.c b/drivers/char/random.c
index 2eb70e76ed35..320108df04c1 100644
--- a/drivers/char/random.c
+++ b
On 2018-11-02 11:36, Miguel Ojeda wrote:
> Hi Rasmus,
>
> On Sat, Oct 27, 2018 at 2:06 PM Miguel Ojeda
> wrote:
>>
>> I did quick check and gcc >= 4.1, clang >= 3.0, icc >= 13 compilers
>> seem to support it (or at least recognize it, even if they just ignore
>> it), so we do not need to make it
On 2018-11-02 11:36, Miguel Ojeda wrote:
> Hi Rasmus,
>
> On Sat, Oct 27, 2018 at 2:06 PM Miguel Ojeda
> wrote:
>>
>> I did quick check and gcc >= 4.1, clang >= 3.0, icc >= 13 compilers
>> seem to support it (or at least recognize it, even if they just ignore
>> it), so we do not need to make it
On 2018-10-27 21:47, Alexey Dobriyan wrote:
> On Fri, Oct 26, 2018 at 11:20:34PM +0200, Rasmus Villemoes wrote:
>> +#include
>
>> +#define linux_proc_banner \
>> +"%s version %s" \
>> +" (" LINUX_COMPILE_BY "@" LINUX_COMPILE_
On 2018-10-27 21:47, Alexey Dobriyan wrote:
> On Fri, Oct 26, 2018 at 11:20:34PM +0200, Rasmus Villemoes wrote:
>> +#include
>
>> +#define linux_proc_banner \
>> +"%s version %s" \
>> +" (" LINUX_COMPILE_BY "@" LINUX_COMPILE_
These two functions are nearly identical, so we can avoid some code
duplication by moving the conditional into a common implementation.
Signed-off-by: Rasmus Villemoes
---
kernel/trace/trace_output.c | 34 +++---
1 file changed, 7 insertions(+), 27 deletions(-)
diff
These two functions are nearly identical, so we can avoid some code
duplication by moving the conditional into a common implementation.
Signed-off-by: Rasmus Villemoes
---
kernel/trace/trace_output.c | 34 +++---
1 file changed, 7 insertions(+), 27 deletions(-)
diff
eclaration of the str buffer inside the CONFIG_KALLSYMS guard,
which in turn will make gcc inline the function for !CONFIG_KALLSYMS (it
only has a single caller, but the huge stack frame seems to make gcc not
inline it for CONFIG_KALLSYMS).
Signed-off-by: Rasmus Villemoes
---
kernel/trace/trace_ou
eclaration of the str buffer inside the CONFIG_KALLSYMS guard,
which in turn will make gcc inline the function for !CONFIG_KALLSYMS (it
only has a single caller, but the huge stack frame seems to make gcc not
inline it for CONFIG_KALLSYMS).
Signed-off-by: Rasmus Villemoes
---
kernel/trace/trace_ou
a single caller which passes "%s" as fmt, so
we might as well just use that directly. That also paves the way for
further cleanups that will actually make that format string go away
entirely.
Signed-off-by: Rasmus Villemoes
---
kernel/trace/trace_output.c | 9 -
1 file changed, 4
-> offset.
Rasmus Villemoes (3):
tracing: merge seq_print_sym_short() and seq_print_sym_offset()
tracing: avoid -Wformat-nonliteral warning
tracing: simplify printf'ing in seq_print_sym
kernel/trace/trace_output.c | 38 -
1 file changed, 8 insertions(+),
a single caller which passes "%s" as fmt, so
we might as well just use that directly. That also paves the way for
further cleanups that will actually make that format string go away
entirely.
Signed-off-by: Rasmus Villemoes
---
kernel/trace/trace_output.c | 9 -
1 file changed, 4
-> offset.
Rasmus Villemoes (3):
tracing: merge seq_print_sym_short() and seq_print_sym_offset()
tracing: avoid -Wformat-nonliteral warning
tracing: simplify printf'ing in seq_print_sym
kernel/trace/trace_output.c | 38 -
1 file changed, 8 insertions(+),
Commit-ID: 2022cceb4e30f1bb4c84d40ffa705aa8d8d68adb
Gitweb: https://git.kernel.org/tip/2022cceb4e30f1bb4c84d40ffa705aa8d8d68adb
Author: Rasmus Villemoes
AuthorDate: Sat, 27 Oct 2018 00:20:04 +0200
Committer: Ingo Molnar
CommitDate: Mon, 29 Oct 2018 07:19:26 +0100
x86/traps: Use format
Commit-ID: 2022cceb4e30f1bb4c84d40ffa705aa8d8d68adb
Gitweb: https://git.kernel.org/tip/2022cceb4e30f1bb4c84d40ffa705aa8d8d68adb
Author: Rasmus Villemoes
AuthorDate: Sat, 27 Oct 2018 00:20:04 +0200
Committer: Ingo Molnar
CommitDate: Mon, 29 Oct 2018 07:19:26 +0100
x86/traps: Use format
On 2018-10-27 14:06, Miguel Ojeda wrote:
> Hi Rasmus,
>
> On Sat, Oct 27, 2018 at 1:24 AM Rasmus Villemoes
> wrote:
>>
>> +/*
>> + * Optional
>
> I did quick check and gcc >= 4.1, clang >= 3.0, icc >= 13 compilers
> seem to support it (or
On 2018-10-27 14:06, Miguel Ojeda wrote:
> Hi Rasmus,
>
> On Sat, Oct 27, 2018 at 1:24 AM Rasmus Villemoes
> wrote:
>>
>> +/*
>> + * Optional
>
> I did quick check and gcc >= 4.1, clang >= 3.0, icc >= 13 compilers
> seem to support it (or
One is supposed to pass in a format string containing (at most) one %u
instance. Use fmtcheck() to enforce that at runtime, WARNing and falling
back to a harmless "kthread/%u" in case verification fails.
Signed-off-by: Rasmus Villemoes
---
kernel/kthread.c | 4 ++--
1 file changed, 2
n linux) contain a fmtcheck() function; I took the
name and return semantics from that.
Signed-off-by: Rasmus Villemoes
---
include/linux/kernel.h | 18
lib/Kconfig.debug | 9 ++
lib/vsprintf.c | 65 ++
3 files changed, 92
mpiler cannot do any type checking.
Even a static inline fmtcheck() that just returns its first argument
would provide documentation for which specifiers what->ever is supposed
to contain, but we'll implement an actual run-time check later.
Signed-off-by: Rasmus Villemoes
---
include/linux/co
eck of fmt to ensure it doesn't contain odd printf
specifiers that would make snprintf go off into the weeds. The lack of
the FMTCHECK_NO_EXTRA_ARGS flag (i.e., the last 0 argument) means we
allow either no specifiers or precisely one occurrence of %s in tmp.
Signed-off-by: Rasmus Villemoes
-
It should be trivial to add more test cases, once we figure out the
exact rules for being compatible or not. Perhaps we'll have to extend
the struct test with a flags element if we add flags that affect the
return value.
Signed-off-by: Rasmus Villemoes
---
lib/test_printf.c | 43
One is supposed to pass in a format string containing (at most) one %u
instance. Use fmtcheck() to enforce that at runtime, WARNing and falling
back to a harmless "kthread/%u" in case verification fails.
Signed-off-by: Rasmus Villemoes
---
kernel/kthread.c | 4 ++--
1 file changed, 2
n linux) contain a fmtcheck() function; I took the
name and return semantics from that.
Signed-off-by: Rasmus Villemoes
---
include/linux/kernel.h | 18
lib/Kconfig.debug | 9 ++
lib/vsprintf.c | 65 ++
3 files changed, 92
mpiler cannot do any type checking.
Even a static inline fmtcheck() that just returns its first argument
would provide documentation for which specifiers what->ever is supposed
to contain, but we'll implement an actual run-time check later.
Signed-off-by: Rasmus Villemoes
---
include/linux/co
eck of fmt to ensure it doesn't contain odd printf
specifiers that would make snprintf go off into the weeds. The lack of
the FMTCHECK_NO_EXTRA_ARGS flag (i.e., the last 0 argument) means we
allow either no specifiers or precisely one occurrence of %s in tmp.
Signed-off-by: Rasmus Villemoes
-
It should be trivial to add more test cases, once we figure out the
exact rules for being compatible or not. Perhaps we'll have to extend
the struct test with a flags element if we add flags that affect the
return value.
Signed-off-by: Rasmus Villemoes
---
lib/test_printf.c | 43
Some users may prefer to check a "user-supplied" string upfront and
return EINVAL rather than using the the template as a fallback for
printf'ing later. fmtmatch() is simply a shorthand for
fmtcheck(a, b, c | FMTCHECK_SILENT) == a.
Signed-off-by: Rasmus Villemoes
---
include/linu
Some users may prefer to check a "user-supplied" string upfront and
return EINVAL rather than using the the template as a fallback for
printf'ing later. fmtmatch() is simply a shorthand for
fmtcheck(a, b, c | FMTCHECK_SILENT) == a.
Signed-off-by: Rasmus Villemoes
---
include/linu
with a string not
containing format specifiers, but we might as well silence this warning
using "%s" as format string.
Signed-off-by: Rasmus Villemoes
---
arch/x86/kernel/traps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/traps.c b/arch/x86/kern
with a string not
containing format specifiers, but we might as well silence this warning
using "%s" as format string.
Signed-off-by: Rasmus Villemoes
---
arch/x86/kernel/traps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/traps.c b/arch/x86/kern
to complain in the unlikely case one of the
LINUX_* strings ended up containing a %. This also avoids compiling it
in for !CONFIG_PROC_FS.
Signed-off-by: Rasmus Villemoes
---
fs/proc/version.c | 6 ++
include/linux/printk.h | 1 -
init/version.c | 5 -
3 files changed, 6 insertions
to complain in the unlikely case one of the
LINUX_* strings ended up containing a %. This also avoids compiling it
in for !CONFIG_PROC_FS.
Signed-off-by: Rasmus Villemoes
---
fs/proc/version.c | 6 ++
include/linux/printk.h | 1 -
init/version.c | 5 -
3 files changed, 6 insertions
eclaration of the str buffer inside the CONFIG_KALLSYMS guard,
which in turn will make gcc inline the function for !CONFIG_KALLSYMS (it
only has a single caller, but the huge stack frame seems to make gcc not
inline it for CONFIG_KALLSYMS).
Signed-off-by: Rasmus Villemoes
---
kernel/trace/trace_ou
These two functions are nearly identical, so we can avoid some code
duplication by moving the conditional into a common implementation.
Signed-off-by: Rasmus Villemoes
---
kernel/trace/trace_output.c | 34 +++---
1 file changed, 7 insertions(+), 27 deletions(-)
diff
a single caller which passes "%s" as fmt, so
we might as well just use that directly. That also paves the way for
further cleanups that will actually make that format string go away
entirely.
Signed-off-by: Rasmus Villemoes
---
kernel/trace/trace_output.c | 9 -
1 file changed, 4
eclaration of the str buffer inside the CONFIG_KALLSYMS guard,
which in turn will make gcc inline the function for !CONFIG_KALLSYMS (it
only has a single caller, but the huge stack frame seems to make gcc not
inline it for CONFIG_KALLSYMS).
Signed-off-by: Rasmus Villemoes
---
kernel/trace/trace_ou
These two functions are nearly identical, so we can avoid some code
duplication by moving the conditional into a common implementation.
Signed-off-by: Rasmus Villemoes
---
kernel/trace/trace_output.c | 34 +++---
1 file changed, 7 insertions(+), 27 deletions(-)
diff
a single caller which passes "%s" as fmt, so
we might as well just use that directly. That also paves the way for
further cleanups that will actually make that format string go away
entirely.
Signed-off-by: Rasmus Villemoes
---
kernel/trace/trace_output.c | 9 -
1 file changed, 4
On 2018-10-25 16:17, Sasha Levin wrote:
> From: Rasmus Villemoes
>
> [ Upstream commit e87c3f80ad0490d26ffe04754b7d094463b40f30 ]
>
> !strncmp(buf, "force host", 9) is true if and only if buf starts with
> "force hos". This was obviously not what was intend
On 2018-10-25 16:17, Sasha Levin wrote:
> From: Rasmus Villemoes
>
> [ Upstream commit e87c3f80ad0490d26ffe04754b7d094463b40f30 ]
>
> !strncmp(buf, "force host", 9) is true if and only if buf starts with
> "force hos". This was obviously not what was intend
the state of close_on_exec in the new
bits when we expand the fdtable, we don't need to clear close_on_exec[i]
in do_close_on_exec, and since we may have quite a few bits set in
close_on_exec[i] without an actual open file, mask the set with
open_fds[i].
Signed-off-by: Rasmus Villemoes
---
fs
the state of close_on_exec in the new
bits when we expand the fdtable, we don't need to clear close_on_exec[i]
in do_close_on_exec, and since we may have quite a few bits set in
close_on_exec[i] without an actual open file, mask the set with
open_fds[i].
Signed-off-by: Rasmus Villemoes
---
fs
.
Reviewed-by: Bryan O'Donoghue
Signed-off-by: Rasmus Villemoes
---
Sending as a proper patch. Marked v2 since this replaces earlier 2/3
and 3/3 patches. Applies on top of
b4fc4e8340784e30c5a59bf0791f9c3ce15e (staging: greybus:
loopback.c: remove unused gb_loopback::lbid).
drivers/staging
.
Reviewed-by: Bryan O'Donoghue
Signed-off-by: Rasmus Villemoes
---
Sending as a proper patch. Marked v2 since this replaces earlier 2/3
and 3/3 patches. Applies on top of
b4fc4e8340784e30c5a59bf0791f9c3ce15e (staging: greybus:
loopback.c: remove unused gb_loopback::lbid).
drivers/staging
On 2018-10-11 01:03, Bryan O'Donoghue wrote:
> On 05/10/2018 15:28, Rasmus Villemoes wrote:
>> Signed-off-by: Rasmus Villemoes
>> ---
>> I have no idea if the performance matters (it probably doesn't). Feel
>> free to ignore this and the followup cleanup.
>
> What
On 2018-10-11 01:03, Bryan O'Donoghue wrote:
> On 05/10/2018 15:28, Rasmus Villemoes wrote:
>> Signed-off-by: Rasmus Villemoes
>> ---
>> I have no idea if the performance matters (it probably doesn't). Feel
>> free to ignore this and the followup cleanup.
>
> What
cache miss is hardly noticable.
Comments? Flames?
Signed-off-by: Rasmus Villemoes
---
include/linux/rai.h | 83 +
1 file changed, 83 insertions(+)
create mode 100644 include/linux/rai.h
diff --git a/include/linux/rai.h b/include/linux/rai.h
new
cache miss is hardly noticable.
Comments? Flames?
Signed-off-by: Rasmus Villemoes
---
include/linux/rai.h | 83 +
1 file changed, 83 insertions(+)
create mode 100644 include/linux/rai.h
diff --git a/include/linux/rai.h b/include/linux/rai.h
new
t;cat /proc/rai" continues to print
"one: 1, two: 2, three: 3".
Signed-off-by: Rasmus Villemoes
---
arch/x86/include/asm/rai.S | 42 +-
arch/x86/include/asm/rai.h | 30 ++-
arch/x86/kernel/rai.c | 18
t;cat /proc/rai" continues to print
"one: 1, two: 2, three: 3".
Signed-off-by: Rasmus Villemoes
---
arch/x86/include/asm/rai.S | 42 +-
arch/x86/include/asm/rai.h | 30 ++-
arch/x86/kernel/rai.c | 18
This avoids a cacheline access to get the value of the inode_cachep
pointer in the places that do a kmem_cache_*(inode_cachep, ...);
Signed-off-by: Rasmus Villemoes
---
fs/inode.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/inode.c b/fs/inode.c
index
This just sets things up so that the ARCH_HAS_RAI symbol gets selected,
and prepare the arch-specific headers and support functions.
Signed-off-by: Rasmus Villemoes
---
arch/x86/Kconfig | 1 +
arch/x86/include/asm/rai.S | 18 ++
arch/x86/include/asm/rai.h | 25
This avoids a cacheline access to get the value of the dentry_cache
pointer in the places that do a kmem_cache_*(dentry_cache, ...);
Signed-off-by: Rasmus Villemoes
---
fs/dcache.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/dcache.c b/fs/dcache.c
index
This avoids a cacheline access to get the value of the inode_cachep
pointer in the places that do a kmem_cache_*(inode_cachep, ...);
Signed-off-by: Rasmus Villemoes
---
fs/inode.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/inode.c b/fs/inode.c
index
This just sets things up so that the ARCH_HAS_RAI symbol gets selected,
and prepare the arch-specific headers and support functions.
Signed-off-by: Rasmus Villemoes
---
arch/x86/Kconfig | 1 +
arch/x86/include/asm/rai.S | 18 ++
arch/x86/include/asm/rai.h | 25
This avoids a cacheline access to get the value of the dentry_cache
pointer in the places that do a kmem_cache_*(dentry_cache, ...);
Signed-off-by: Rasmus Villemoes
---
fs/dcache.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/dcache.c b/fs/dcache.c
index
Signed-off-by: Rasmus Villemoes
---
include/asm-generic/vmlinux.lds.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/asm-generic/vmlinux.lds.h
b/include/asm-generic/vmlinux.lds.h
index f09ee3c544bc..f38510c6bfcc 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm
Signed-off-by: Rasmus Villemoes
---
include/asm-generic/vmlinux.lds.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/asm-generic/vmlinux.lds.h
b/include/asm-generic/vmlinux.lds.h
index f09ee3c544bc..f38510c6bfcc 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm
or any other) and adjust the stack
pointer.
The patched code does need to do a shr, so I don't think there's a way
around the cc clobber.
Signed-off-by: Rasmus Villemoes
---
arch/x86/include/asm/rai.S | 59 ++
arch/x86/include/asm/rai.h | 21
Signed-off-by: Rasmus Villemoes
---
arch/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/Kconfig b/arch/Kconfig
index 9d329608913e..160893bd6a5c 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -275,6 +275,9 @@ config ARCH_THREAD_STACK_ALLOCATOR
config
or any other) and adjust the stack
pointer.
The patched code does need to do a shr, so I don't think there's a way
around the cc clobber.
Signed-off-by: Rasmus Villemoes
---
arch/x86/include/asm/rai.S | 59 ++
arch/x86/include/asm/rai.h | 21
Signed-off-by: Rasmus Villemoes
---
arch/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/Kconfig b/arch/Kconfig
index 9d329608913e..160893bd6a5c 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -275,6 +275,9 @@ config ARCH_THREAD_STACK_ALLOCATOR
config
f8902e9b1
0x8902e906: mov%r12,%rax
0x8902e909: mov%r12d,%r10d
0x8902e90c: mov%rdx,%r15
The shr $0x12, %eax is consistent with
[ 0.300676] Dentry cache hash table entries: 16384 (order: 5, 131072 bytes)
and nothing seems to explode.
Signed-off-
Signed-off-by: Rasmus Villemoes
---
arch/x86/kernel/rai.c | 12
1 file changed, 12 insertions(+)
diff --git a/arch/x86/kernel/rai.c b/arch/x86/kernel/rai.c
index e55e85f11a2e..c4284ce7478f 100644
--- a/arch/x86/kernel/rai.c
+++ b/arch/x86/kernel/rai.c
@@ -63,11 +63,21
f8902e9b1
0x8902e906: mov%r12,%rax
0x8902e909: mov%r12d,%r10d
0x8902e90c: mov%rdx,%r15
The shr $0x12, %eax is consistent with
[ 0.300676] Dentry cache hash table entries: 16384 (order: 5, 131072 bytes)
and nothing seems to explode.
Signed-off-
Signed-off-by: Rasmus Villemoes
---
arch/x86/kernel/rai.c | 12
1 file changed, 12 insertions(+)
diff --git a/arch/x86/kernel/rai.c b/arch/x86/kernel/rai.c
index e55e85f11a2e..c4284ce7478f 100644
--- a/arch/x86/kernel/rai.c
+++ b/arch/x86/kernel/rai.c
@@ -63,11 +63,21
Just to have a quick way of seeing that rai-patching works (i.e., once
we implement rai_load, we'd not expect the output to change). Also,
inside virtme we can do a quick "gdb vmlinux /proc/kcode" and
disassemble rai_proc_show to see how the patched function looks.
Signed-off-by: Rasmus
Just to have a quick way of seeing that rai-patching works (i.e., once
we implement rai_load, we'd not expect the output to change). Also,
inside virtme we can do a quick "gdb vmlinux /proc/kcode" and
disassemble rai_proc_show to see how the patched function looks.
Signed-off-by: Rasmus
, we will
live with that wasted space.
Signed-off-by: Rasmus Villemoes
---
init/main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/init/main.c b/init/main.c
index a664246450d1..39709ca33316 100644
--- a/init/main.c
+++ b/init/main.c
@@ -92,6 +92,7 @@
#include
#include
#include
, we will
live with that wasted space.
Signed-off-by: Rasmus Villemoes
---
init/main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/init/main.c b/init/main.c
index a664246450d1..39709ca33316 100644
--- a/init/main.c
+++ b/init/main.c
@@ -92,6 +92,7 @@
#include
#include
#include
On 2018-10-10 18:14, Laurent Vivier wrote:
> + /* create a new binfmt namespace
> + * if we are not in the first user namespace
> + * but the binfmt namespace is the first one
> + */
> + if (READ_ONCE(ns->binfmt_ns) == NULL) {
> + struct binfmt_namespace
On 2018-10-10 18:14, Laurent Vivier wrote:
> + /* create a new binfmt namespace
> + * if we are not in the first user namespace
> + * but the binfmt namespace is the first one
> + */
> + if (READ_ONCE(ns->binfmt_ns) == NULL) {
> + struct binfmt_namespace
On 2018-10-14 06:19, William Breathitt Gray wrote:
> a bit value of 0 in the
> bits array does not necessarily mean the input was not requested, but
> may instead mean that the value at the input is 0;
sure enough, but...
> therefore, the caller
> must keep track of the requested inputs rather
On 2018-10-14 06:19, William Breathitt Gray wrote:
> a bit value of 0 in the
> bits array does not necessarily mean the input was not requested, but
> may instead mean that the value at the input is 0;
sure enough, but...
> therefore, the caller
> must keep track of the requested inputs rather
On 2018-10-11 01:03, Bryan O'Donoghue wrote:
> On 05/10/2018 15:28, Rasmus Villemoes wrote:
>> Signed-off-by: Rasmus Villemoes
>> ---
>> I have no idea if the performance matters (it probably doesn't). Feel
>> free to ignore this and the followup cleanup.
>
> What
On 2018-10-11 01:03, Bryan O'Donoghue wrote:
> On 05/10/2018 15:28, Rasmus Villemoes wrote:
>> Signed-off-by: Rasmus Villemoes
>> ---
>> I have no idea if the performance matters (it probably doesn't). Feel
>> free to ignore this and the followup cleanup.
>
> What
-by: Greg Kroah-Hartman
Acked-by: Jason Baron
Signed-off-by: Rasmus Villemoes
---
include/linux/device.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/linux/device.h b/include/linux/device.h
index 0d8ed2adfc73..81108db013e4 100644
--- a/include/linux/device.h
+++ b
Signed-off-by: Rasmus Villemoes
---
include/linux/device.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/device.h b/include/linux/device.h
index 8f882549edee..0d8ed2adfc73 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -1503,7 +1503,7 @@ do
-by: Greg Kroah-Hartman
Acked-by: Jason Baron
Signed-off-by: Rasmus Villemoes
---
include/linux/device.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/linux/device.h b/include/linux/device.h
index 0d8ed2adfc73..81108db013e4 100644
--- a/include/linux/device.h
+++ b
Signed-off-by: Rasmus Villemoes
---
include/linux/device.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/device.h b/include/linux/device.h
index 8f882549edee..0d8ed2adfc73 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -1503,7 +1503,7 @@ do
.
Acked-by: Jason Baron
Signed-off-by: Rasmus Villemoes
---
include/linux/dynamic_debug.h | 22 +++---
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index 2fd8006153c3..0a643316597c 100644
--- a/include
.
Acked-by: Jason Baron
Signed-off-by: Rasmus Villemoes
---
include/linux/dynamic_debug.h | 22 +++---
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index 2fd8006153c3..0a643316597c 100644
--- a/include
core.c (incidentally, there is an in-tree module whose name
is core, but I just tested this with an out-of-tree trivial one).
Acked-by: Jason Baron
Signed-off-by: Rasmus Villemoes
---
lib/dynamic_debug.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/dynamic_debug.c b/lib
core.c (incidentally, there is an in-tree module whose name
is core, but I just tested this with an out-of-tree trivial one).
Acked-by: Jason Baron
Signed-off-by: Rasmus Villemoes
---
lib/dynamic_debug.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/dynamic_debug.c b/lib
-by: Petr Mladek
Acked-by: Jason Baron
Cc: Steven Rostedt
Signed-off-by: Rasmus Villemoes
---
include/linux/printk.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/linux/printk.h b/include/linux/printk.h
index d3ba3245531d..70df2c578d40 100644
--- a/include/linux
-by: Petr Mladek
Acked-by: Jason Baron
Cc: Steven Rostedt
Signed-off-by: Rasmus Villemoes
---
include/linux/printk.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/linux/printk.h b/include/linux/printk.h
index d3ba3245531d..70df2c578d40 100644
--- a/include/linux
Baron
Signed-off-by: Rasmus Villemoes
---
lib/dynamic_debug.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index ab81155f928d..f1de45a100fa 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -868,7 +868,6 @@ int ddebug_add_module(struct
- though the hex_dump case requires
a slight variant, since print_hex_dump does not take the _ddebug
descriptor. We'll also get to use that variant elsewhere (btrfs).
Acked-by: Jason Baron
Signed-off-by: Rasmus Villemoes
---
include/linux/dynamic_debug.h | 72 +--
1 file
Baron
Signed-off-by: Rasmus Villemoes
---
lib/dynamic_debug.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index ab81155f928d..f1de45a100fa 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -868,7 +868,6 @@ int ddebug_add_module(struct
- though the hex_dump case requires
a slight variant, since print_hex_dump does not take the _ddebug
descriptor. We'll also get to use that variant elsewhere (btrfs).
Acked-by: Jason Baron
Signed-off-by: Rasmus Villemoes
---
include/linux/dynamic_debug.h | 72 +--
1 file
the new _dynamic_func_call_no_desc helper macro from
dynamic_debug.h takes care of both of these.
Cc: linux-bt...@vger.kernel.org
Acked-by: David Sterba
Acked-by: Jason Baron
Signed-off-by: Rasmus Villemoes
---
fs/btrfs/ctree.h | 34 ++
1 file changed, 10
701 - 800 of 3339 matches
Mail list logo
