Hi
On Tue, Nov 03, 2020 at 12:37:54PM +0800, Yejune Deng wrote:
> devm_reset_control_array_get_exclusive() looks more readable
>
> Signed-off-by: Yejune Deng
Reviewed-by: Remi Pommarel for phy-meson-axg-pcie
Thanks.
der;
> - struct resource *res;
> struct phy_meson_gxl_usb2_priv *priv;
> struct phy *phy;
> void __iomem *base;
> @@ -242,8 +241,7 @@ static int phy_meson_gxl_usb2_probe(struct
> platform_device *pdev)
>
> platform_set_drvdata(pdev, priv);
>
> -
found in Meson AXG SoCs.
> diff --git a/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c
> b/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c
> index 1431cbf885e1..6eb21551bdd9 100644
> --- a/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c
> +++ b/drivers/phy/am
udp_sendmsg+0xaf0/0xcf0
[<5aabe255>] inet_sendmsg+0x5c/0x80
[<8651ea08>] __sys_sendto+0x15c/0x218
[<3505c99b>] __arm64_sys_sendto+0x74/0x90
[<263486ec>] el0_svc_handler+0xd0/0x1a0
[<05b5157d>] el0_svc+0x8/0xc
Fixes: 2bdaf3
t;] sys_sendmsg+0x354/0x3a0
[<e06bab0f>] ___sys_sendmsg+0xd8/0x120
[<37340728>] __sys_sendmsg+0xa4/0xf8
[<4fed9776>] __arm64_sys_sendmsg+0x44/0x58
[<1c1e5647>] el0_svc_handler+0xd0/0x1a0
Fixes: c80d545da3f7 (mac80211: L
On Mon, Oct 14, 2019 at 02:45:34PM +0100, Marc Zyngier wrote:
> Hi Remi,
>
> On 2019-10-14 14:06, Remi Pommarel wrote:
> > Hi Lorenzo, Marc,
> >
> > On Mon, Oct 14, 2019 at 11:01:29AM +0100, Lorenzo Pieralisi wrote:
> > > On Sun, Oct 13, 2019 at
on, Sep 30, 2019 at 06:52:30PM +0200, Remi Pommarel wrote:
> > > > On Mon, Sep 30, 2019 at 04:40:18PM +0100, Andrew Murray wrote:
> > > > > On Wed, May 22, 2019 at 11:33:51PM +0200, Remi Pommarel wrote:
> > > > > > Aardvark's PCI_EXP_LNKSTA_LT flag in its l
On Mon, Sep 30, 2019 at 04:40:18PM +0100, Andrew Murray wrote:
> On Wed, May 22, 2019 at 11:33:51PM +0200, Remi Pommarel wrote:
> > Aardvark's PCI_EXP_LNKSTA_LT flag in its link status register is not
> > implemented and does not reflect the actual link training state (the
> &g
.
This decrements a variable and wait instead of using jiffies.
Signed-off-by: Remi Pommarel
---
Changes since v1:
- Reduce polling delay
- Change size_t into int for loop counter
Changes since v2:
- Keep timeout to 1ms by increasing retry counter
---
drivers/pci/controller/pci-aardvark.c | 10
Hi Thomas,
On Fri, Sep 27, 2019 at 10:34:20AM +0200, Thomas Petazzoni wrote:
> Hello Remi,
>
> Thanks for the new iteration!
>
> On Fri, 27 Sep 2019 10:31:42 +0200
> Remi Pommarel wrote:
>
> > diff --git a/drivers/pci/controller/pci-aardvark.c
> > b/driv
.
This decrements a variable and wait instead of using jiffies.
Signed-off-by: Remi Pommarel
---
Changes since v1:
- Reduce polling delay
- Change size_t into int for loop counter
---
drivers/pci/controller/pci-aardvark.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
Hi Thomas,
Thanks for the review.
On Wed, Sep 25, 2019 at 11:33:51AM +0200, Thomas Petazzoni wrote:
> Hello Remi,
>
> Thanks for the patch, I have a few comments/questions below.
>
> On Sun, 1 Sep 2019 16:23:03 +0200
> Remi Pommarel wrote:
>
> > diff --git a
.
This decrements a variable and wait instead of using jiffies.
Signed-off-by: Remi Pommarel
---
drivers/pci/controller/pci-aardvark.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/pci/controller/pci-aardvark.c
b/drivers/pci/controller/pci-aardvark.c
index
s fake irq that
CONFIG_DEBUG_SHIRQ adds called the handler.
Reported-by: Elie Roudninski
Signed-off-by: Remi Pommarel
---
drivers/iio/adc/meson_saradc.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
On Wed, May 22, 2019 at 11:33:51PM +0200, Remi Pommarel wrote:
> Aardvark's PCI_EXP_LNKSTA_LT flag in its link status register is not
> implemented and does not reflect the actual link training state (the
> flag is always set to 0). In order to support link re-training feature
> t
On Wed, May 22, 2019 at 11:33:50PM +0200, Remi Pommarel wrote:
> When configuring pcie reset pin from gpio (e.g. initially set by
> u-boot) to pcie function this pin goes low for a brief moment
> asserting the PERST# signal. Thus connected device enters fundamental
> reset proc
ement emulated root PCI bridge config
space")
Signed-off-by: Remi Pommarel
---
Changes since v1:
* Improve code readability
* Fix mask polarity
* PME_MASK shift was off by one
Changes since v2:
* Modify patch title
* Change Fixes tag to commit that actually introduces the bug
---
d
Hello,
On Fri, Jun 14, 2019 at 10:58:54AM +0200, Thomas Petazzoni wrote:
> Hello,
>
> On Fri, 14 Jun 2019 08:42:25 +0200
> Remi Pommarel wrote:
>
> > PCI_EXP_RTCTL is used to activate PME interrupt only, so writing into it
> > should not modify other interrupts'
bits for managed host bridge
alloc")
Signed-off-by: Remi Pommarel
---
Changes since v1:
* Improve code readability
* Fix mask polarity
* PME_MASK shift was off by one
---
drivers/pci/controller/pci-aardvark.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git
On Thu, Jun 13, 2019 at 05:14:41PM +0100, Lorenzo Pieralisi wrote:
> On Wed, May 22, 2019 at 11:33:49PM +0200, Remi Pommarel wrote:
> > PCI_EXP_RTCTL is used to activate PME interrupt only, so writing into it
> > should not modify other interrupts' mask (such as ISR0).
> >
&g
Table 4-14
Signed-off-by: Remi Pommarel
---
Changes since v1:
- Rename retraining flag field
- Fix DEVCTL register writing
Changes since v2:
- Rewrite patch logic so it is more legible
Please note that I will unlikely be able to answer any comments from May
24th to June 10th.
---
drivers/pci/
s asserted */
...
drv->probe()
[1] "PCI Express Base Specification", REV. 4.0
PCI Express, February 19 2014, 6.6.1 Conventional Reset
Signed-off-by: Remi Pommarel
---
Changes since v1:
- Add a comment about pinctrl implicit pin configuration
- Use more legible msleep
- Use P
PCI_EXP_RTCTL is used to activate PME interrupt only, so writing into it
should not modify other interrupts' mask (such as ISR0).
Fixes: 6302bf3ef78d ("PCI: Init PCIe feature bits for managed host bridge
alloc")
Signed-off-by: Remi Pommarel
---
Please note that I will unlikely be able
Hi Lorenzo,
On Tue, Apr 30, 2019 at 12:34:27PM +0100, Lorenzo Pieralisi wrote:
> On Mon, Apr 29, 2019 at 05:32:35PM +0200, Remi Pommarel wrote:
> > Hi Lorenzo,
> >
> > Sorry for duplicates I forgot to include everyone.
> >
> > On Thu, Apr 25, 2019 at 04:06:40
On Mon, Apr 29, 2019 at 02:45:32PM -0500, Bjorn Helgaas wrote:
> On Fri, Apr 26, 2019 at 12:27:57AM +0200, Remi Pommarel wrote:
> > On Thu, Apr 25, 2019 at 04:04:39PM -0500, Bjorn Helgaas wrote:
> > > On Sat, Mar 16, 2019 at 05:12:43PM +0100, Remi Pommarel wrote:
>
> &g
Hi Lorenzo,
Sorry for duplicates I forgot to include everyone.
On Thu, Apr 25, 2019 at 04:06:40PM +0100, Lorenzo Pieralisi wrote:
> On Thu, Apr 25, 2019 at 04:23:53PM +0200, Remi Pommarel wrote:
> > Hi Lorenzo,
> >
> > On Thu, Apr 25, 2019 at 12:08:30PM +0100, Lo
Hi Bjorn,
On Thu, Apr 25, 2019 at 04:04:39PM -0500, Bjorn Helgaas wrote:
> Hi Remi,
>
> On Sat, Mar 16, 2019 at 05:12:43PM +0100, Remi Pommarel wrote:
> > The PCI_EXP_LNKSTA_LT flag in the emulated root device's PCI_EXP_LNKSTA
> > config register does not reflect the actua
On Wed, Apr 24, 2019 at 05:50:02PM +0100, Lorenzo Pieralisi wrote:
> On Wed, Apr 24, 2019 at 12:29:18AM +0200, Remi Pommarel wrote:
> > Hi,
> >
> > On Tue, Apr 23, 2019 at 05:32:15PM +0100, Lorenzo Pieralisi wrote:
> > > On Wed, Mar 13, 2019 at 10:37:52PM +0100, Rem
Hi Lorenzo,
On Thu, Apr 25, 2019 at 12:08:30PM +0100, Lorenzo Pieralisi wrote:
> On Sat, Mar 16, 2019 at 05:12:43PM +0100, Remi Pommarel wrote:
> > The PCI_EXP_LNKSTA_LT flag in the emulated root device's PCI_EXP_LNKSTA
> > config register does not reflect the actual link
Hi,
On Tue, Apr 23, 2019 at 05:32:15PM +0100, Lorenzo Pieralisi wrote:
> On Wed, Mar 13, 2019 at 10:37:52PM +0100, Remi Pommarel wrote:
> > When configuring pcie reset pin from gpio (e.g. initially set by
> > u-boot) to pcie function this pin goes low for a brief moment
> >
xc4/0xe0
[0.915424] pci_host_probe+0x14/0xa8
[0.915426] advk_pcie_probe+0x838/0x910
[...]
8< ---
[1] "PCI Express Base Specification", REV. 2.1
PCI Express, March 4 2009, Table 4-7
Signed-off-by: Remi Pommarel
-
Signed-off-by: Remi Pommarel
---
drivers/pci/controller/pci-aardvark.c | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/controller/pci-aardvark.c
b/drivers/pci/controller/pci-aardvark.c
index a30ae7cf8e7e..70a1023d0ef1 100644
--- a/drivers/pci/cont
xc4/0xe0
[0.915424] pci_host_probe+0x14/0xa8
[0.915426] advk_pcie_probe+0x838/0x910
[...]
8< ---
[1] "PCI Express Base Specification", REV. 2.1
PCI Express, March 4 2009, Table 4-7
Signed-off-by: Remi Pommarel
---
This patch has been included in patchset [1], please ignore this one.
[1] https://lkml.org/lkml/2019/1/28/1876
--
Remi
).
Signed-off-by: Remi Pommarel
---
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 2 ++
arch/arm64/boot/dts/marvell/armada-37xx.dtsi| 5 +
2 files changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
b/arch/arm64/boot/dts/marvell
support).
Signed-off-by: Remi Pommarel
---
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
index b60897edc885
/507
Remi Pommarel (2):
arm64: dts: armada-3720-espressobin: Configure RGMII and SMI pins
arm64: dts: armada-3720-espressobin: Set mv88e6341 cpu port as
RGMII-ID
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 7 +++
arch/arm64/boot/dts/marvell/armada-37xx.dtsi
).
Signed-off-by: Remi Pommarel
---
This should be applied along with pinctrl fixes from
https://lkml.org/lkml/2018/12/21/507 which have been merged in next branch of
linux-pinctrl tree.
---
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 2 ++
arch/arm64/boot/dts/marvell/armada-37xx.dtsi
://marc.info/?l=linux-mmc=154707415208716.
Signed-off-by: Remi Pommarel
---
Changes since v1:
- Fix it also in the error handling of probe callback
---
drivers/mmc/host/meson-gx-mmc.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/mmc/host/meson-gx-mmc.c b
On Thu, Jan 10, 2019 at 07:49:08PM +0100, Remi Pommarel wrote:
> Because the irq was requested through device managed resources API
> (devm_request_threaded_irq()) it was freed after meson_mmc_remove()
> completion, thus after mmc_free_host() has reclaimed meson_host memory.
>
.
Signed-off-by: Remi Pommarel
---
drivers/mmc/host/meson-gx-mmc.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index c2690c1a50ff..412cfd16bf15 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b
On Wed, Sep 12, 2018 at 03:35:19PM +0100, Alan Cox wrote:
> On Tue, 11 Sep 2018 22:23:55 +0200
> Remi Pommarel wrote:
>
> > This patchset adds a way to have a specific keyboard config (i.e.
> > keycode to keysym map) for a vt attached input.
>
> Who actually needs thi
On Wed, Sep 12, 2018 at 03:35:19PM +0100, Alan Cox wrote:
> On Tue, 11 Sep 2018 22:23:55 +0200
> Remi Pommarel wrote:
>
> > This patchset adds a way to have a specific keyboard config (i.e.
> > keycode to keysym map) for a vt attached input.
>
> Who actually needs thi
Hi,
On Tue, Sep 11, 2018 at 08:47:55PM +0200, Greg Kroah-Hartman wrote:
>
> Normally I do not review "RFC" patches as it implies the submitter does
> not think they are a valid solution. How about resending them as if you
> think this is something ready to be merged?
I had used "RFC" here
Hi,
On Tue, Sep 11, 2018 at 08:47:55PM +0200, Greg Kroah-Hartman wrote:
>
> Normally I do not review "RFC" patches as it implies the submitter does
> not think they are a valid solution. How about resending them as if you
> think this is something ready to be merged?
I had used "RFC" here
In order to ease the addition of the ability of an input to use a
different key configuration (keycode to keysym map), the operations of
getting and setting an entry in a key map is moved in respective
functions.
Signed-off-by: Remi Pommarel
Tested-by: Elie Roudninski
---
drivers/tty/vt
y be wrong ?
- kbd_detach_conf is a bit clumsy because it tries to copy a shared sparse
pointer array without using GFP_ATOMIC.
Remi Pommarel (4):
drivers/tty/vt/keyboard.c: refactor getting/setting a keymap entry
drivers/tty/vt/keyboard.c: add keyboard config for each vt's input
drivers/tty/vt/keyboa
In order to ease the addition of the ability of an input to use a
different key configuration (keycode to keysym map), the operations of
getting and setting an entry in a key map is moved in respective
functions.
Signed-off-by: Remi Pommarel
Tested-by: Elie Roudninski
---
drivers/tty/vt
y be wrong ?
- kbd_detach_conf is a bit clumsy because it tries to copy a shared sparse
pointer array without using GFP_ATOMIC.
Remi Pommarel (4):
drivers/tty/vt/keyboard.c: refactor getting/setting a keymap entry
drivers/tty/vt/keyboard.c: add keyboard config for each vt's input
drivers/tty/vt/keyboa
this array in each input allows to retrieve its associated
keymap.
Signed-off-by: Remi Pommarel
Tested-by: Elie Roudninski
---
drivers/tty/vt/keyboard.c | 46 +++
1 file changed, 32 insertions(+), 14 deletions(-)
diff --git a/drivers/tty/vt/keyboard.c b/drivers
this array in each input allows to retrieve its associated
keymap.
Signed-off-by: Remi Pommarel
Tested-by: Elie Roudninski
---
drivers/tty/vt/keyboard.c | 46 +++
1 file changed, 32 insertions(+), 14 deletions(-)
diff --git a/drivers/tty/vt/keyboard.c b/drivers
at global key_maps is used */
ret = ioctl(fd, KDSKBIRST, );
if(ret < 0)
/* Error handling */
- 8< -
Signed-off-by: Remi Pommarel
Tested-by: Elie Roudninski
---
drivers/tty/vt/keyboard.c | 126
at global key_maps is used */
ret = ioctl(fd, KDSKBIRST, );
if(ret < 0)
/* Error handling */
- 8< -
Signed-off-by: Remi Pommarel
Tested-by: Elie Roudninski
---
drivers/tty/vt/keyboard.c | 126
to detach a kbd_handle from
global config. Some new ioctl will be introduced to do so.
Signed-off-by: Remi Pommarel
Tested-by: Elie Roudninski
---
drivers/tty/vt/keyboard.c | 198 --
1 file changed, 171 insertions(+), 27 deletions(-)
diff --git a/drivers/tty/vt
to detach a kbd_handle from
global config. Some new ioctl will be introduced to do so.
Signed-off-by: Remi Pommarel
Tested-by: Elie Roudninski
---
drivers/tty/vt/keyboard.c | 198 --
1 file changed, 171 insertions(+), 27 deletions(-)
diff --git a/drivers/tty/vt
Hi,
Just a gentle ping.
Any comments on this patchset that adds a way to have multiple
keyboards with different keymap on a VT would be nice.
Thanks
--
Remi
Hi,
Just a gentle ping.
Any comments on this patchset that adds a way to have multiple
keyboards with different keymap on a VT would be nice.
Thanks
--
Remi
to detach a kbd_handle from
global config. Some new ioctl will be introduced to do so.
Signed-off-by: Remi Pommarel
Tested-by: Elie Roudninski
---
drivers/tty/vt/keyboard.c | 198 --
1 file changed, 171 insertions(+), 27 deletions(-)
diff --git a/drivers/tty/vt
In order to ease the addition of the ability of an input to use a
different key configuration (keycode to keysym map), the operations of
getting and setting an entry in a key map is moved in respective
functions.
Signed-off-by: Remi Pommarel
Tested-by: Elie Roudninski
---
drivers/tty/vt
to detach a kbd_handle from
global config. Some new ioctl will be introduced to do so.
Signed-off-by: Remi Pommarel
Tested-by: Elie Roudninski
---
drivers/tty/vt/keyboard.c | 198 --
1 file changed, 171 insertions(+), 27 deletions(-)
diff --git a/drivers/tty/vt
In order to ease the addition of the ability of an input to use a
different key configuration (keycode to keysym map), the operations of
getting and setting an entry in a key map is moved in respective
functions.
Signed-off-by: Remi Pommarel
Tested-by: Elie Roudninski
---
drivers/tty/vt
GFP_ATOMIC.
- Is this patchset even a sensible idea ?
Remi Pommarel (4):
drivers/tty/vt/keyboard.c: refactor getting/setting a keymap entry
drivers/tty/vt/keyboard.c: add keyboard config for each vt's input
drivers/tty/vt/keyboard.c: Make key_down[] bitmap input dependent
drivers/tty/vt: add ioctl to ma
at global key_maps is used */
ret = ioctl(fd, KDSKBIRST, );
if(ret < 0)
/* Error handling */
- 8< -
Signed-off-by: Remi Pommarel
Tested-by: Elie Roudninski
---
drivers/tty/vt/keyboard.c | 126
at global key_maps is used */
ret = ioctl(fd, KDSKBIRST, );
if(ret < 0)
/* Error handling */
- 8< -
Signed-off-by: Remi Pommarel
Tested-by: Elie Roudninski
---
drivers/tty/vt/keyboard.c | 126
GFP_ATOMIC.
- Is this patchset even a sensible idea ?
Remi Pommarel (4):
drivers/tty/vt/keyboard.c: refactor getting/setting a keymap entry
drivers/tty/vt/keyboard.c: add keyboard config for each vt's input
drivers/tty/vt/keyboard.c: Make key_down[] bitmap input dependent
drivers/tty/vt: add ioctl to ma
this array in each input allows to retrieve its associated
keymap.
Signed-off-by: Remi Pommarel
Tested-by: Elie Roudninski
---
drivers/tty/vt/keyboard.c | 46 +++
1 file changed, 32 insertions(+), 14 deletions(-)
diff --git a/drivers/tty/vt/keyboard.c b/drivers
this array in each input allows to retrieve its associated
keymap.
Signed-off-by: Remi Pommarel
Tested-by: Elie Roudninski
---
drivers/tty/vt/keyboard.c | 46 +++
1 file changed, 32 insertions(+), 14 deletions(-)
diff --git a/drivers/tty/vt/keyboard.c b/drivers
On Sun, Dec 06, 2015 at 05:22:45PM +0100, Remi Pommarel wrote:
> Hi,
>
> This patchset adds support for pwm clock. At boot, this clock does not have a
> default parent nor a default rate set. Thus we should be able to change its
> parent to get this clock working. The current clock
On Sun, Dec 06, 2015 at 05:22:45PM +0100, Remi Pommarel wrote:
> Hi,
>
> This patchset adds support for pwm clock. At boot, this clock does not have a
> default parent nor a default rate set. Thus we should be able to change its
> parent to get this clock working. The current clock
On Mon, Dec 07, 2015 at 08:09:47PM -0800, Eric Anholt wrote:
> Stefan Wahren writes:
>
> > Hi Remi,
> >
> > Am 07.12.2015 um 19:17 schrieb Remi Pommarel:
> >> Hi Stefan,
> >>
> >> On Sun, Dec 06, 2015 at 10:16:25PM +0100, Stefan Wahren wrote
On Mon, Dec 07, 2015 at 08:09:47PM -0800, Eric Anholt wrote:
> Stefan Wahren <i...@lategoodbye.de> writes:
>
> > Hi Remi,
> >
> > Am 07.12.2015 um 19:17 schrieb Remi Pommarel:
> >> Hi Stefan,
> >>
> >> On Sun, Dec 06, 201
recipent. Then the first 3 patches will eventually get pushed by a clock
subsystem maintainer. And finally this last patch will be pushed by a
devicetree maintainer.
Am I right here ?
>
> Am 06.12.2015 um 17:22 schrieb Remi Pommarel:
> >Signed-off-by: Remi Pommarel
> >---
>
recipent. Then the first 3 patches will eventually get pushed by a clock
subsystem maintainer. And finally this last patch will be pushed by a
devicetree maintainer.
Am I right here ?
>
> Am 06.12.2015 um 17:22 schrieb Remi Pommarel:
> >Signed-off-by: Remi Pommarel <r...@triple
t a mux clock
cannot be used because updating clock control register to select parent needs a
password to be xor'd with the parent index.
This patch get rid of mux clock and make these clocks handle their own parent,
allowing them to select the one to use.
Signed-off-by: Remi Pommarel
---
drivers
Signed-off-by: Remi Pommarel
---
arch/arm/boot/dts/bcm2835-rpi.dtsi | 4
arch/arm/boot/dts/bcm2835.dtsi | 9 +
2 files changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi
b/arch/arm/boot/dts/bcm2835-rpi.dtsi
index 3572f03..55801e0 100644
--- a/arch/arm
Make bcm2835_clock_choose_div to optionally round up the chosen MASH divisor
so that the resulting average rate will not be higher than the requested one.
Signed-off-by: Remi Pommarel
---
drivers/clk/bcm/clk-bcm2835.c | 22 --
1 file changed, 12 insertions(+), 10 deletions
Register the pwm clock for bcm2835.
Signed-off-by: Remi Pommarel
---
drivers/clk/bcm/clk-bcm2835.c | 13 +
include/dt-bindings/clock/bcm2835.h | 3 ++-
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c
variable and include
- Make bcm2835_clock_choose_div() divisor round up ability optional
- Set rate in bcm2835_determine_rate()
- Add device tree modification in a separate patch
Remi Pommarel (4):
clk: bcm2835: add a round up ability to the clock divisor
clk: bcm2835
variable and include
- Make bcm2835_clock_choose_div() divisor round up ability optional
- Set rate in bcm2835_determine_rate()
- Add device tree modification in a separate patch
Remi Pommarel (4):
clk: bcm2835: add a round up ability to the clock divisor
clk: bcm2835
Register the pwm clock for bcm2835.
Signed-off-by: Remi Pommarel <r...@triplefau.lt>
---
drivers/clk/bcm/clk-bcm2835.c | 13 +
include/dt-bindings/clock/bcm2835.h | 3 ++-
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/bcm/clk-bcm2835.c b/d
Make bcm2835_clock_choose_div to optionally round up the chosen MASH divisor
so that the resulting average rate will not be higher than the requested one.
Signed-off-by: Remi Pommarel <r...@triplefau.lt>
---
drivers/clk/bcm/clk-bcm2835.c | 22 --
1 file changed, 12 inse
t a mux clock
cannot be used because updating clock control register to select parent needs a
password to be xor'd with the parent index.
This patch get rid of mux clock and make these clocks handle their own parent,
allowing them to select the one to use.
Signed-off-by: Remi Pommarel <r...@tri
Signed-off-by: Remi Pommarel <r...@triplefau.lt>
---
arch/arm/boot/dts/bcm2835-rpi.dtsi | 4
arch/arm/boot/dts/bcm2835.dtsi | 9 +
2 files changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi
b/arch/arm/boot/dts/bcm2835-rpi.dtsi
index 3572f03..5
On Thu, Dec 03, 2015 at 04:37:07PM -0800, Eric Anholt wrote:
> Remi Pommarel writes:
>
> > On Wed, Nov 18, 2015 at 10:30:17AM -0800, Eric Anholt wrote:
> >
> > [...]
> >
> >> > +static int bcm2835_clock_determine_rate(struct clk_hw *hw,
> >&
On Thu, Dec 03, 2015 at 04:37:07PM -0800, Eric Anholt wrote:
> Remi Pommarel <r...@triplefau.lt> writes:
>
> > On Wed, Nov 18, 2015 at 10:30:17AM -0800, Eric Anholt wrote:
> >
> > [...]
> >
> >> > +static int bcm2835_clock_determine_rate(s
Hi Eric
On Wed, Nov 18, 2015 at 07:11:41PM -0100, Remi Pommarel wrote:
> On Wed, Nov 18, 2015 at 10:25:45AM -0800, Eric Anholt wrote:
> > Remi Pommarel writes:
> >
> > > Make bcm2835_clock_choose_div always round up the chosen MASH divisor so
> > > that
Hi Eric
On Wed, Nov 18, 2015 at 07:11:41PM -0100, Remi Pommarel wrote:
> On Wed, Nov 18, 2015 at 10:25:45AM -0800, Eric Anholt wrote:
> > Remi Pommarel <r...@triplefau.lt> writes:
> >
> > > Make bcm2835_clock_choose_div always round up the chosen MASH divisor so
On Sun, Nov 29, 2015 at 10:22:40PM +0100, Stefan Wahren wrote:
> Hi Remi,
>
> Am 29.11.2015 um 01:31 schrieb Remi Pommarel:
> >Hi Stefan,
> >
> >On Sat, Nov 28, 2015 at 09:52:07PM +0100, Stefan Wahren wrote:
> >>i applied the series including the devicetree m
On Sun, Nov 29, 2015 at 10:22:40PM +0100, Stefan Wahren wrote:
> Hi Remi,
>
> Am 29.11.2015 um 01:31 schrieb Remi Pommarel:
> >Hi Stefan,
> >
> >On Sat, Nov 28, 2015 at 09:52:07PM +0100, Stefan Wahren wrote:
> >>i applied the series including the devicetree m
Hi Stefan,
On Sat, Nov 28, 2015 at 09:52:07PM +0100, Stefan Wahren wrote:
> i applied the series including the devicetree modification, but it
> doesn't work for me.
>
> First of all i get an ugly division by zero warning from the pwm
> driver. The pwm driver still assume a fixed clock and
Hi Stefan,
On Sat, Nov 28, 2015 at 09:52:07PM +0100, Stefan Wahren wrote:
> i applied the series including the devicetree modification, but it
> doesn't work for me.
>
> First of all i get an ugly division by zero warning from the pwm
> driver. The pwm driver still assume a fixed clock and
On Wed, Nov 18, 2015 at 10:32:55AM -0800, Eric Anholt wrote:
> Remi Pommarel writes:
>
> > Register the pwm clock for bcm2835.
> >
> > Signed-off-by: Remi Pommarel
> > ---
> > drivers/clk/bcm/clk-bcm2835.c | 14 ++
> > include/dt-bind
On Wed, Nov 18, 2015 at 10:30:17AM -0800, Eric Anholt wrote:
[...]
> > +static int bcm2835_clock_determine_rate(struct clk_hw *hw,
> > + struct clk_rate_request *req)
> > +{
> > + struct bcm2835_clock *clock = bcm2835_clock_from_hw(hw);
> > + struct clk_hw *parent, *best_parent =
Hi,
On Wed, Nov 18, 2015 at 10:25:45AM -0800, Eric Anholt wrote:
> Remi Pommarel writes:
>
> > Make bcm2835_clock_choose_div always round up the chosen MASH divisor so
> > that
> > the resulting average rate will not be higher than the requested one.
> >
&g
Hi,
On Wed, Nov 18, 2015 at 10:25:45AM -0800, Eric Anholt wrote:
> Remi Pommarel <r...@triplefau.lt> writes:
>
> > Make bcm2835_clock_choose_div always round up the chosen MASH divisor so
> > that
> > the resulting average rate will not be higher than the req
On Wed, Nov 18, 2015 at 10:30:17AM -0800, Eric Anholt wrote:
[...]
> > +static int bcm2835_clock_determine_rate(struct clk_hw *hw,
> > + struct clk_rate_request *req)
> > +{
> > + struct bcm2835_clock *clock = bcm2835_clock_from_hw(hw);
> > + struct clk_hw *parent, *best_parent =
On Wed, Nov 18, 2015 at 10:32:55AM -0800, Eric Anholt wrote:
> Remi Pommarel <r...@triplefau.lt> writes:
>
> > Register the pwm clock for bcm2835.
> >
> > Signed-off-by: Remi Pommarel <r...@triplefau.lt>
> > ---
> > drivers/clk/bcm/clk-bcm2835.c
Register the pwm clock for bcm2835.
Signed-off-by: Remi Pommarel
---
drivers/clk/bcm/clk-bcm2835.c | 14 ++
include/dt-bindings/clock/bcm2835.h | 3 ++-
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835
Make bcm2835_clock_choose_div always round up the chosen MASH divisor so that
the resulting average rate will not be higher than the requested one.
Signed-off-by: Remi Pommarel
---
drivers/clk/bcm/clk-bcm2835.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git
divided rate
instead of the parent one
- bcm2835_clock_choose_div has been modified to produce an avarage rate
lower or equal to the requested one
- devicetree modifications have removed to be send in another patch
Remi Pommarel (3):
clk: bcm2835: Always round
1 - 100 of 123 matches
Mail list logo
