Re: [PATCH 6/7] UBI: Fix memory leak in ubi_attach_fastmap() error path

2013-09-30 Thread Richard Genoud
2013/9/28 Richard Weinberger : > On error we have to free all three temporary lists. > > Reported-by: Richard Genoud > Signed-off-by: Richard Weinberger > --- > drivers/mtd/ubi/fastmap.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/drivers/

[PATCH] UBI: fastmap: fix a mem leak on error path

2013-09-27 Thread Richard Genoud
If the scan_pool() function fails, the "free" list is not freed. This leads to destroy_ai(ai) complaining with: "kmem_cache_destroy ubi_ainf_peb_slab: Slab cache still has objects" Signed-off-by: Richard Genoud --- drivers/mtd/ubi/fastmap.c |4 1 file changed, 4

Re: [PATCH] UBI: fastmap: fix backward compatibility with image_seq

2013-09-27 Thread Richard Genoud
2013/9/27 Richard Weinberger : > Am 27.09.2013 15:16, schrieb Richard Genoud: >> 2013/9/27 Richard Weinberger : >>> Am 27.09.2013 14:51, schrieb Richard Genoud: >>>> Some old UBI implementations (e.g. U-Boot) have not implemented the image >>>> sequen

Re: [PATCH] UBI: fastmap: fix backward compatibility with image_seq

2013-09-27 Thread Richard Genoud
2013/9/27 Richard Weinberger : > Am 27.09.2013 14:51, schrieb Richard Genoud: >> Some old UBI implementations (e.g. U-Boot) have not implemented the image >> sequence feature. >> So, when erase blocks are written, the image sequence in the ec header >> is lost (se

[PATCH] UBI: fastmap: fix backward compatibility with image_seq

2013-09-27 Thread Richard Genoud
2eadaad67b2b6bd132eda105128d2d466298b8e3) But fastmap scan functions (ubi_scan_fastmap() and scan_pool()) didn't. This patch fixes the issue. Signed-off-by: Richard Genoud --- drivers/mtd/ubi/fastmap.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/driver

[PATCH] UBI: simplify image sequence test

2013-09-27 Thread Richard Genoud
The test: if (!a && b) a = b; can be symplified in: if (!a) a = b; And there's no need to test if ubi->image_seq is not null, because if it is, it is set to image_seq. So, we just test if image_seq is not null. Signed-off-by: Richard Genoud --- drivers/mtd/ubi/attach.c |

Re: [PATCH 1/2] UBI: Fix error path in scan_pool()

2013-09-27 Thread Richard Genoud
2013/9/27 Richard Weinberger : > Am 26.09.2013 11:25, schrieb Richard Genoud: >> I added some traces and I found that : (dumping ec_header after >> "ubi_io_read_ec_hdr(ubi, pnum, ech, 0); " in ubi_scan_fastmap()) >> [0.812500] UBI: default fastmap pool size: 95

Re: [PATCH 1/2] UBI: Fix error path in scan_pool()

2013-09-26 Thread Richard Genoud
2013/9/26 Richard Genoud : > 2013/9/26 Richard Weinberger : >> Am 26.09.2013 09:20, schrieb Richard Genoud: >>> On 25/09/2013 22:32, Richard Weinberger wrote: >>>> We have to set "ret", not "err" in case of an error. >>>> >>&g

Re: [PATCH 1/2] UBI: Fix error path in scan_pool()

2013-09-26 Thread Richard Genoud
2013/9/26 Richard Weinberger : > Am 26.09.2013 09:20, schrieb Richard Genoud: >> On 25/09/2013 22:32, Richard Weinberger wrote: >>> We have to set "ret", not "err" in case of an error. >>> >>> Reported-by: Richard Genoud >>>

Re: [PATCH 2/2] UBI: Call scan_all() with correct offset in error case

2013-09-26 Thread Richard Genoud
On 25/09/2013 22:32, Richard Weinberger wrote: > If we find an invalid fastmap we have to scan from the very beginning. > Otherwise we leak the first 64 PEBs. > > Reported-by: Richard Genoud > Signed-off-by: Richard Weinberger > --- > drivers/mtd/ubi/attach.c | 6 --

Re: [PATCH 1/2] UBI: Fix error path in scan_pool()

2013-09-26 Thread Richard Genoud
On 25/09/2013 22:32, Richard Weinberger wrote: > We have to set "ret", not "err" in case of an error. > > Reported-by: Richard Genoud > Signed-off-by: Richard Weinberger > --- > drivers/mtd/ubi/fastmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 dele

Re: sun4i_handle_irq: WARNING at net/ipv4/tcp_input.c:2711 tcp_fastretrans_alert

2013-08-26 Thread Richard Genoud
2013/8/23 Maxime Ripard : > Hi Richard, > > On Wed, Aug 21, 2013 at 11:47:20AM +0200, Richard GENOUD wrote: >> Hi Maxime, Stephan >> >> I just realise that, *sometimes*, I have some warnings on my cubieboard >> (6 since the 22 of july, and the board is runnning

sun4i_handle_irq: WARNING at net/ipv4/tcp_input.c:2711 tcp_fastretrans_alert

2013-08-21 Thread Richard GENOUD
Hi Maxime, Stephan I just realise that, *sometimes*, I have some warnings on my cubieboard (6 since the 22 of july, and the board is runnning 24/24). It has happened also on 3.10 + emac patches. Here it is: [27224.06] [ cut here ] [27224.07] WARNING: CPU: 0 PID: 0 a

Re: [PATCH 1/8] ARM: at91: move peripheral id definitions to dt-bindings include dir

2013-08-20 Thread Richard Genoud
finitions will be used inside dt to define interrupt ids and >>>> peripheral clk ids. >>>> >>>> Signed-off-by: Boris BREZILLON >>> >>> This seems counterproductive, why would you do that? >> >> >> This was requested by Jean-Christophe Pl

Re: [PATCH] proc: return on proc_readdir error

2013-08-19 Thread Richard Genoud
2013/8/20 Marc Dionne : > On Mon, Aug 19, 2013 at 7:49 PM, Linus Torvalds > wrote: >> On Mon, Aug 19, 2013 at 1:33 PM, Marc Dionne wrote: >>> >>> By my reading that commit (f0c3b5093add) also made proc_readdir always >>> return 0, so with this patch the effect I see is that no pid entries >>> are

[PATCH] proc: return on proc_readdir error

2013-08-19 Thread Richard Genoud
B, thus some proc entries are missing. (described more in details here: https://lkml.org/lkml/2013/8/12/288 ) Signed-off-by: Richard Genoud --- [added Linus Torvalds and Andrew Morton in CC since Al Viro seems to be on holidays and it's starting to getting late in the -rc cycles] fs/proc/root

Re: Regression V3.11-rc1 bisected: [readdir] convert procfs

2013-08-14 Thread Richard Genoud
2013/8/12 Richard Genoud : > Hi, > > I've found something peculiar while I was testing v3.11: > There's a lot of directory missing (actually hiding) in /proc : > > /proc/sys/, /proc/fs/, /proc/bus/ etc... > all the directories that are not PIDs are in "stealth m

Regression V3.11-rc1 bisected: [readdir] convert procfs

2013-08-12 Thread Richard Genoud
Hi, I've found something peculiar while I was testing v3.11: There's a lot of directory missing (actually hiding) in /proc : /proc/sys/, /proc/fs/, /proc/bus/ etc... all the directories that are not PIDs are in "stealth mode": they don't appear with an ls (nor a find), but I can list their conten

[PATCH 0/4] Add sound in SAM9x5 DTS

2013-08-12 Thread Richard Genoud
As the sam9x5-wm8731 machine driver has been merged, we have now to add the device tree nodes... And here they are ! (Based on next-20130812) Tested on at91sam9g35-ek [I didn't add the DT list, as far as there's no new binding, we don't have to bother themi, right ?] Richard Ge

[PATCH 2/4] ARM: AT91: DTS: sam9x5ek: add WM8731 codec

2013-08-12 Thread Richard Genoud
The WM8731 codec on sam9x5ek board is on i2c, address 1A Signed-off-by: Richard Genoud Acked-by: Mark Brown --- arch/arm/boot/dts/at91sam9x5ek.dtsi |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/at91sam9x5ek.dtsi b/arch/arm/boot/dts/at91sam9x5ek.dtsi index

[PATCH 1/4] ARM: AT91: DTS: sam9x5: add SSC DMA parameters

2013-08-12 Thread Richard Genoud
Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5.dtsi |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi index 57d45f5..cf78ac0 100644 --- a/arch/arm/boot/dts/at91sam9x5.dtsi +++ b/arch/arm/boot/dts

[PATCH 4/4] ARM: AT91: DTS: sam9x5ek: add sound configuration

2013-08-12 Thread Richard Genoud
The sam9x5ek board has 2 jacks: headphone wired on RHPOUT/LHPOUT of the wm8731 line in wired on LLINEIN/RLINEIN of the wm8731 Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5ek.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts

[PATCH 3/4] ARM: AT91: DTS: sam9x5ek: enable SSC

2013-08-12 Thread Richard Genoud
Enable the SSC needed for the WM8731 codec Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5ek.dtsi |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/at91sam9x5ek.dtsi b/arch/arm/boot/dts/at91sam9x5ek.dtsi index e6fb309..f3e83f7 100644 --- a/arch/arm

Re: [PATCH] trivial: convert comma to semicolon

2013-08-09 Thread Richard Genoud
- clk->set_next_event = metag_timer_set_next_event, > + clk->rating = 200; > + clk->shift = 12; > + clk->irq = tbisig_map(TBID_SIGNUM_TRT); > + clk->set_mode = metag_timer_set_mode; > + clk->set_next_event = metag_timer_set_next_event; &g

Re: [PATCH] ARM: at91/dt: split sam9x5 peripheral definitions

2013-08-07 Thread Richard Genoud
2013/8/7 boris brezillon : > Hello Richard, > > > On 07/08/2013 12:38, Richard Genoud wrote: >> >> 2013/8/7 Boris BREZILLON : >>> >>> This patch splits the sam9x5 peripheral definitions into: >>> - a common base for all sam9x5 SoCs (at91sam9x5.

Re: [PATCH] ARM: at91/dt: split sam9x5 peripheral definitions

2013-08-07 Thread Richard Genoud
2013/8/7 Boris BREZILLON : > This patch splits the sam9x5 peripheral definitions into: > - a common base for all sam9x5 SoCs (at91sam9x5.dtsi) > - several optional peripheral definitions which will be included by specific > sam9x5 SoCs (at91sam9x5_'periph name'.dtsi) > > This provides a better re

Re: [PATCH v6 2/8] ASoC: atmel: machine driver for at91sam9x5-wm8731 boards

2013-08-07 Thread Richard Genoud
2013/8/6 Mark Brown : > On Tue, Jul 30, 2013 at 12:32:03PM +0200, Richard Genoud wrote: >> From: Nicolas Ferre >> >> Description of the Asoc machine driver for an at91sam9x5 based board >> with a wm8731 audio DAC. Wm8731 is clocked by a crystal and used as a >>

Re: [PATCH 0/8] ARM: at91/dt: make use of periph id macros

2013-08-02 Thread Richard Genoud
On 02/08/2013 11:04, boris brezillon wrote: > Hello Richard, > > On 01/08/2013 09:37, Richard Genoud wrote: >> 2013/8/1 Boris BREZILLON : >>> Hello, >>> >>> This patch series move at91 SoCs peripheral id definitions from machine >>> specifi

Re: [PATCH 0/8] ARM: at91/dt: make use of periph id macros

2013-08-01 Thread Richard Genoud
2013/8/1 Richard Genoud : > 2013/8/1 Boris BREZILLON : >> Hello, >> >> This patch series move at91 SoCs peripheral id definitions from machine >> specific include dir to dt-bindings include dir. >> These macros are used to reference interrupts instead of periph

Re: [PATCH 0/8] ARM: at91/dt: make use of periph id macros

2013-08-01 Thread Richard Genoud
2013/8/1 Boris BREZILLON : > Hello, > > This patch series move at91 SoCs peripheral id definitions from machine > specific include dir to dt-bindings include dir. > These macros are used to reference interrupts instead of peripheral numbers. > > This makes dt definitions cleaner and easier to debug

[PATCH resend] MTD: atmel_nand: using a stronger ECC is not dangerous

2013-07-30 Thread Richard Genoud
We don't have to issue a warning when a stronger error correting capability is chosen. Signed-off-by: Richard Genoud Acked-by: Josh Wu --- It seems that this patch has been forgotten (even by me) for some months. (was already acked by Josh then) Reference of the discussion leading to this

Re: [PATCH v6 8/8] ASoC: sam9x5: get codec MCLK via device tree

2013-07-30 Thread Richard Genoud
2013/7/30 Mark Brown : > On Tue, Jul 30, 2013 at 12:32:09PM +0200, Richard Genoud wrote: > >> --- a/Documentation/devicetree/bindings/sound/atmel-sam9x5-wm8731-audio.txt >> +++ b/Documentation/devicetree/bindings/sound/atmel-sam9x5-wm8731-audio.txt >> @@ -8,6 +8,

[PATCH v6 2/8] ASoC: atmel: machine driver for at91sam9x5-wm8731 boards

2013-07-30 Thread Richard Genoud
from Nicolas that I forward ported and reworked to use only device tree] Signed-off-by: Nicolas Ferre Signed-off-by: Richard Genoud --- .../bindings/sound/atmel-sam9x5-wm8731-audio.txt | 35 Documentation/devicetree/bindings/sound/wm8731.txt |9 + sound/soc/atmel/Kconfig

[PATCH v6 1/8] ASoC: wm8731: add rates constraints

2013-07-30 Thread Richard Genoud
Depending on the mclk (or crystal) selected, the wm8731 codec have some constraints on its data sampling rates: e.g. with a 12.288MHz or 18.432MHz crystal, the authorized rates are 8KHz, 32KHz, 48KHz and 96KHz. Signed-off-by: Richard Genoud --- sound/soc/codecs/wm8731.c | 60

[PATCH v6 4/8] ARM: AT91: DTS: sam9x5: add SSC DMA parameters

2013-07-30 Thread Richard Genoud
Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5.dtsi |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi index 20b6423..d6c9895 100644 --- a/arch/arm/boot/dts/at91sam9x5.dtsi +++ b/arch/arm/boot/dts

[PATCH v6 3/8] Documentation: DT: update atmel SSC with DMA binding

2013-07-30 Thread Richard Genoud
As atmel-ssc can be used with DMA, the documentation should be updated. Also, a configuration DMA example is given. Signed-off-by: Richard Genoud --- .../devicetree/bindings/misc/atmel-ssc.txt | 23 +++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a

[PATCH v6 6/8] ARM: AT91: DTS: sam9x5ek: enable SSC

2013-07-30 Thread Richard Genoud
Enable the SSC needed for the WM8731 codec Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5ek.dtsi |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/at91sam9x5ek.dtsi b/arch/arm/boot/dts/at91sam9x5ek.dtsi index e6fb309..f3e83f7 100644 --- a/arch/arm

[PATCH v6 7/8] ARM: AT91: DTS: sam9x5ek: add sound configuration

2013-07-30 Thread Richard Genoud
The sam9x5ek board has 2 jacks: headphone wired on RHPOUT/LHPOUT of the wm8731 line in wired on LLINEIN/RLINEIN of the wm8731 Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5ek.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts

[PATCH v6 8/8] ASoC: sam9x5: get codec MCLK via device tree

2013-07-30 Thread Richard Genoud
Instead of having the clock rate hard coded, and thus, only compatible with one board, we can make it compatible with other implementations. Signed-off-by: Richard Genoud --- .../bindings/sound/atmel-sam9x5-wm8731-audio.txt |4 arch/arm/boot/dts/at91sam9x5ek.dtsi

[PATCH v6 5/8] ARM: AT91: DTS: sam9x5ek: add WM8731 codec

2013-07-30 Thread Richard Genoud
The WM8731 codec on sam9x5ek board is on i2c, address 1A Signed-off-by: Richard Genoud Acked-by: Mark Brown --- arch/arm/boot/dts/at91sam9x5ek.dtsi |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/at91sam9x5ek.dtsi b/arch/arm/boot/dts/at91sam9x5ek.dtsi index

[PATCH v6 0/8] Sound support for at91sam9x5-wm8731 based boards

2013-07-30 Thread Richard Genoud
ic snd_soc_card and snd_soc_dai_link structures. Best regards, Richard. Nicolas Ferre (1): ASoC: atmel: machine driver for at91sam9x5-wm8731 boards Richard Genoud (7): ASoC: wm8731: add rates constraints Documentation: DT: update atmel SSC with DMA binding ARM: AT91: DTS: sam9x5: add

Re: [PATCH v6 0/8] Sound support for at91sam9x5-wm8731 based boards

2013-07-30 Thread Richard Genoud
aggg... I forgot that the DT list has changed. I'll resend this with the correct address. Sorry for the noise. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordo

[PATCH v6 1/8] ASoC: wm8731: add rates constraints

2013-07-30 Thread Richard Genoud
Depending on the mclk (or crystal) selected, the wm8731 codec have some constraints on its data sampling rates: e.g. with a 12.288MHz or 18.432MHz crystal, the authorized rates are 8KHz, 32KHz, 48KHz and 96KHz. Signed-off-by: Richard Genoud --- sound/soc/codecs/wm8731.c | 60

[PATCH v6 0/8] Sound support for at91sam9x5-wm8731 based boards

2013-07-30 Thread Richard Genoud
ic snd_soc_card and snd_soc_dai_link structures. Best regards, Richard. Nicolas Ferre (1): ASoC: atmel: machine driver for at91sam9x5-wm8731 boards Richard Genoud (7): ASoC: wm8731: add rates constraints Documentation: DT: update atmel SSC with DMA binding ARM: AT91: DTS: sam9x5: add

[PATCH v6 6/8] ARM: AT91: DTS: sam9x5ek: enable SSC

2013-07-30 Thread Richard Genoud
Enable the SSC needed for the WM8731 codec Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5ek.dtsi |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/at91sam9x5ek.dtsi b/arch/arm/boot/dts/at91sam9x5ek.dtsi index e6fb309..f3e83f7 100644 --- a/arch/arm

[PATCH v6 3/8] Documentation: DT: update atmel SSC with DMA binding

2013-07-30 Thread Richard Genoud
As atmel-ssc can be used with DMA, the documentation should be updated. Also, a configuration DMA example is given. Signed-off-by: Richard Genoud --- .../devicetree/bindings/misc/atmel-ssc.txt | 23 +++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a

[PATCH v6 5/8] ARM: AT91: DTS: sam9x5ek: add WM8731 codec

2013-07-30 Thread Richard Genoud
The WM8731 codec on sam9x5ek board is on i2c, address 1A Signed-off-by: Richard Genoud Acked-by: Mark Brown --- arch/arm/boot/dts/at91sam9x5ek.dtsi |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/at91sam9x5ek.dtsi b/arch/arm/boot/dts/at91sam9x5ek.dtsi index

[PATCH v6 4/8] ARM: AT91: DTS: sam9x5: add SSC DMA parameters

2013-07-30 Thread Richard Genoud
Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5.dtsi |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi index 20b6423..d6c9895 100644 --- a/arch/arm/boot/dts/at91sam9x5.dtsi +++ b/arch/arm/boot/dts

[PATCH v6 8/8] ASoC: sam9x5: get codec MCLK via device tree

2013-07-30 Thread Richard Genoud
Instead of having the clock rate hard coded, and thus, only compatible with one board, we can make it compatible with other implementations. Signed-off-by: Richard Genoud --- .../bindings/sound/atmel-sam9x5-wm8731-audio.txt |4 arch/arm/boot/dts/at91sam9x5ek.dtsi

[PATCH v6 7/8] ARM: AT91: DTS: sam9x5ek: add sound configuration

2013-07-30 Thread Richard Genoud
The sam9x5ek board has 2 jacks: headphone wired on RHPOUT/LHPOUT of the wm8731 line in wired on LLINEIN/RLINEIN of the wm8731 Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5ek.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts

[PATCH v6 2/8] ASoC: atmel: machine driver for at91sam9x5-wm8731 boards

2013-07-30 Thread Richard Genoud
from Nicolas that I forward ported and reworked to use only device tree] Signed-off-by: Nicolas Ferre Signed-off-by: Richard Genoud --- .../bindings/sound/atmel-sam9x5-wm8731-audio.txt | 35 Documentation/devicetree/bindings/sound/wm8731.txt |9 + sound/soc/atmel/Kconfig

Re: [PATCH v2 00/42] ARM: at91: move to common clk framework

2013-07-29 Thread Richard Genoud
2013/7/29 boris brezillon : > On 29/07/2013 16:18, Richard Genoud wrote: >> >> 2013/7/29 boris brezillon : >>> >>> On 29/07/2013 10:00, Richard Genoud wrote: >>>> >>>> 2013/7/26 boris brezillon : >>>>> >>>>&

Re: [PATCH v2 00/42] ARM: at91: move to common clk framework

2013-07-29 Thread Richard Genoud
2013/7/29 boris brezillon : > On 29/07/2013 10:00, Richard Genoud wrote: >> >> 2013/7/26 boris brezillon : >>> >>> On 26/07/2013 17:44, boris brezillon wrote: >>> I found 2 bugs: >>> 1) the main frequency ready test in recalc_rate function is w

Re: [PATCH v2 00/42] ARM: at91: move to common clk framework

2013-07-29 Thread Richard Genoud
2013/7/26 boris brezillon : > On 26/07/2013 17:44, boris brezillon wrote: > I found 2 bugs: > 1) the main frequency ready test in recalc_rate function is wrong > 2) the common clk framework uses the first match for dt clk registration >and main clk has this compatible property: >compatible

Re: [PATCH v2 00/42] ARM: at91: move to common clk framework

2013-07-26 Thread Richard Genoud
On 17/07/2013 15:34, Boris BREZILLON wrote: > Hello, > > This patch series is a proposal to move at91 clock implementation > to common clk framework. > > Most of the clock provided by the PMC (Power Management Controller) are > implemented : > - main clock (main oscillator) > - pll clocks > - mas

Re: rtl8192cu: slow path warning

2013-07-23 Thread Richard Genoud
2013/7/23 Paul Rolland : > Hello Richard, > > If you still have the required HW and still would like a patch to remove > that warning on your machine, could you please try the attached one ? > > I slightly reworked the original patch by moving the function > rtl_lps_change_work_callback from pci.c

Re: [PATCH v5 2/7] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards

2013-07-15 Thread Richard Genoud
2013/7/12 Mark Brown : > On Thu, Jul 11, 2013 at 06:15:54PM +0200, Richard Genoud wrote: >> From: Nicolas Ferre >> >> Description of the Asoc machine driver for an at91sam9x5 based board > > ASoC. > >> +sam9x5 pins: >> + * LOUT >> + * ROUT >>

Re: [PATCH v5 1/7] sound: codec: wm8731: add rates constraints

2013-07-15 Thread Richard Genoud
2013/7/12 Mark Brown : > On Thu, Jul 11, 2013 at 06:15:53PM +0200, Richard Genoud wrote: > > Please always try to use commit logs that look like normal commit logs > for the subsystem. Ok, I'll pay attention to that. >> switch (freq) { >> - case 112

[PATCH v5 6/7] ARM: AT91: DTS: sam9x5ek: enable SSC

2013-07-11 Thread Richard Genoud
Enable the SSC needed for the WM8731 codec Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5ek.dtsi |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/at91sam9x5ek.dtsi b/arch/arm/boot/dts/at91sam9x5ek.dtsi index e6fb309..f3e83f7 100644 --- a/arch/arm

[PATCH v5 3/7] Documentation: DT: update atmel SSC with DMA binding

2013-07-11 Thread Richard Genoud
As atmel-ssc can be used with DMA, the documentation should be updated. Also, a configuration DMA example is given. Signed-off-by: Richard Genoud --- .../devicetree/bindings/misc/atmel-ssc.txt | 23 +++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a

[PATCH v5 7/7] ARM: AT91: DTS: sam9x5ek: add sound configuration

2013-07-11 Thread Richard Genoud
The sam9x5ek board has 2 jacks: headphone wired on RHPOUT/LHPOUT of the wm8731 line in wired on LLINEIN/RLINEIN of the wm8731 Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5ek.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts

[PATCH v5 4/7] ARM: AT91: DTS: sam9x5: add SSC DMA parameters

2013-07-11 Thread Richard Genoud
Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5.dtsi |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi index 57d45f5..cf78ac0 100644 --- a/arch/arm/boot/dts/at91sam9x5.dtsi +++ b/arch/arm/boot/dts

[PATCH v5 5/7] ARM: AT91: DTS: sam9x5ek: add WM8731 codec

2013-07-11 Thread Richard Genoud
The WM8731 codec on sam9x5ek board is on i2c, address 1A Signed-off-by: Richard Genoud Acked-by: Mark Brown --- arch/arm/boot/dts/at91sam9x5ek.dtsi |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/at91sam9x5ek.dtsi b/arch/arm/boot/dts/at91sam9x5ek.dtsi index

[PATCH v5 0/7] Sound support for at91sam9x5-wm8731 based boards

2013-07-11 Thread Richard Genoud
uctures. Best regards, Richard. Nicolas Ferre (1): sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards Richard Genoud (6): sound: codec: wm8731: add rates constraints Documentation: DT: update atmel SSC with DMA binding ARM: AT91: DTS: sam9x5: add SSC DMA parameters ARM:

[PATCH v5 1/7] sound: codec: wm8731: add rates constraints

2013-07-11 Thread Richard Genoud
Depending on the mclk (or crystal) selected, the wm8731 codec have some constraints on its data sampling rates: e.g. with a 12.288MHz or 18.432MHz crystal, the authorized rates are 8KHz, 32KHz, 48KHz and 96KHz. Signed-off-by: Richard Genoud --- sound/soc/codecs/wm8731.c | 57

[PATCH v5 2/7] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards

2013-07-11 Thread Richard Genoud
from Nicolas that I forward ported and reworked to use only device tree] Signed-off-by: Nicolas Ferre Signed-off-by: Uwe Kleine-König Signed-off-by: Richard Genoud --- .../bindings/sound/atmel-sam9x5-wm8731-audio.txt | 41 sound/soc/atmel/Kconfig| 10

Re: [PATCH v4 3/7] Documentation: DT: update atmel SSC with DMA binding

2013-07-10 Thread Richard Genoud
2013/7/9 Mark Brown : > On Tue, Jul 09, 2013 at 04:25:29PM +0200, Richard Genoud wrote: > >> - reg: Should contain SSC registers location and length >> - interrupts: Should contain SSC interrupt >> +For dma transfer: >> +- dmas: DMA specifier, consisting of a

Re: [PATCH v4 2/7] Documentation: DT: add sam9x5ek-wm8731 machine driver

2013-07-10 Thread Richard Genoud
2013/7/9 Mark Brown : > On Tue, Jul 09, 2013 at 04:25:28PM +0200, Richard Genoud wrote: >> This add the sound DT binding for sam9x5ek-wm8731 machine driver >> >> Signed-off-by: Richard Genoud >> --- >> .../bindings/sound/atmel-sam9x5-wm8731-audio.txt | 30 &g

Re: [PATCH v4 1/7] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards

2013-07-10 Thread Richard Genoud
2013/7/10 Bo Shen : > Hi Richard, Hi ! > On 7/9/2013 22:25, Richard Genoud wrote: > [snip] > > >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >

Re: [PATCH v4 1/7] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards

2013-07-10 Thread Richard Genoud
2013/7/9 Mark Brown : > On Tue, Jul 09, 2013 at 04:25:27PM +0200, Richard Genoud wrote: > >> +/* >> + * Authorized rates are: >> + * Rate = MCLK_RATE / (n * 2) >> + * Where n is in [1..4095] >> + * (cf register SSC_CMR) >> + */ >> +static unsign

Re: [PATCH v4 0/7] Sound support for at91sam9x5-wm8731 based boards

2013-07-09 Thread Richard Genoud
2013/7/9 Mark Brown : > On Tue, Jul 09, 2013 at 04:25:26PM +0200, Richard Genoud wrote: >> [I've just seen that I forgot to cc Uwe to the cover letter, sorry for that.] > > This is the second or third copy of this patch set I've been sent > *today*. Worse, everythi

[PATCH v4 4/7] ARM: AT91: DTS: sam9x5: add SSC DMA parameters

2013-07-09 Thread Richard Genoud
Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5.dtsi |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi index 57d45f5..cf78ac0 100644 --- a/arch/arm/boot/dts/at91sam9x5.dtsi +++ b/arch/arm/boot/dts

[PATCH v4 3/7] Documentation: DT: update atmel SSC with DMA binding

2013-07-09 Thread Richard Genoud
As atmel-ssc can be used with DMA, the documentation should be updated. Also, a configuration DMA example is given. Signed-off-by: Richard Genoud --- .../devicetree/bindings/misc/atmel-ssc.txt | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a

[PATCH v4 2/7] Documentation: DT: add sam9x5ek-wm8731 machine driver

2013-07-09 Thread Richard Genoud
This add the sound DT binding for sam9x5ek-wm8731 machine driver Signed-off-by: Richard Genoud --- .../bindings/sound/atmel-sam9x5-wm8731-audio.txt | 30 1 file changed, 30 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/atmel-sam9x5-wm8731

[PATCH v4 1/7] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards

2013-07-09 Thread Richard Genoud
from Nicolas that I forward ported and reworked to use only device tree] Signed-off-by: Nicolas Ferre Signed-off-by: Uwe Kleine-König Signed-off-by: Richard Genoud --- sound/soc/atmel/Kconfig | 10 ++ sound/soc/atmel/Makefile|2 + sound/soc/atmel/sam9x5_wm8731.c | 238

[PATCH v4 5/7] ARM: AT91: DTS: sam9x5ek: add WM8731 codec

2013-07-09 Thread Richard Genoud
The WM8731 codec on sam9x5ek board is on i2c, address 1A Signed-off-by: Richard Genoud Acked-by: Mark Brown --- arch/arm/boot/dts/at91sam9x5ek.dtsi |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/at91sam9x5ek.dtsi b/arch/arm/boot/dts/at91sam9x5ek.dtsi index

[PATCH v4 7/7] ARM: AT91: DTS: sam9x5ek: enable SSC

2013-07-09 Thread Richard Genoud
Enable the SSC needed for the WM8731 codec Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5ek.dtsi |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/at91sam9x5ek.dtsi b/arch/arm/boot/dts/at91sam9x5ek.dtsi index 2bf51cc..0534c58 100644 --- a/arch/arm

[PATCH v4 6/7] ARM: AT91: DTS: sam9x5ek: add sound configuration

2013-07-09 Thread Richard Genoud
The sam9x5ek board has 2 jacks: headphone wired on RHPOUT/LHPOUT of the wm8731 line in wired on LLINEIN/RLINEIN of the wm8731 Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5ek.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts

[PATCH v4 0/7] Sound support for at91sam9x5-wm8731 based boards

2013-07-09 Thread Richard Genoud
s Ferre (1): sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards Richard Genoud (6): Documentation: DT: add sam9x5ek-wm8731 machine driver Documentation: DT: update atmel SSC with DMA binding ARM: AT91: DTS: sam9x5: add SSC DMA parameters ARM: AT91: DTS: sam9x5ek: add WM8731 co

Re: [PATCH v3 3/7] Documentation: DT: update atmel SSC with DMA binding

2013-07-09 Thread Richard Genoud
2013/7/9 Nicolas Ferre : > On 09/07/2013 15:19, Richard Genoud : > >> 2013/7/9 Richard Genoud : >>> >>> As atmel-ssc can be used with DMA, the documentation should be updated. >>> Also, a configuration DMA example is given. >>> >>> Si

Re: [PATCH v3 3/7] Documentation: DT: update atmel SSC with DMA binding

2013-07-09 Thread Richard Genoud
2013/7/9 Richard Genoud : > As atmel-ssc can be used with DMA, the documentation should be updated. > Also, a configuration DMA example is given. > > Signed-off-by: Richard Genoud > --- > .../devicetree/bindings/misc/atmel-ssc.txt | 24 > ++--

[PATCH v3 0/7] Sound support for at91sam9x5-wm8731 based boards

2013-07-09 Thread Richard Genoud
unneeded SND_ATMEL_SOC_PDC config selection * use static snd_soc_card and snd_soc_dai_link structures. Best regards, Richard. Nicolas Ferre (1): sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards Richard Genoud (6): Documentation: DT: add sam9x5ek-wm8731 machine driver Do

[PATCH v3 7/7] ARM: AT91: DTS: sam9x5ek: enable SSC

2013-07-09 Thread Richard Genoud
Enable the SSC needed for the WM8731 codec Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5ek.dtsi |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/at91sam9x5ek.dtsi b/arch/arm/boot/dts/at91sam9x5ek.dtsi index 2bf51cc..0534c58 100644 --- a/arch/arm

[PATCH v3 2/7] Documentation: DT: add sam9x5ek-wm8731 machine driver

2013-07-09 Thread Richard Genoud
This add the sound DT binding for sam9x5ek-wm8731 machine driver Signed-off-by: Richard Genoud --- .../bindings/sound/atmel-sam9x5-wm8731-audio.txt | 30 1 file changed, 30 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/atmel-sam9x5-wm8731

[PATCH v3 4/7] ARM: AT91: DTS: sam9x5: add SSC DMA parameters

2013-07-09 Thread Richard Genoud
Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5.dtsi |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi index 57d45f5..cf78ac0 100644 --- a/arch/arm/boot/dts/at91sam9x5.dtsi +++ b/arch/arm/boot/dts

[PATCH v3 3/7] Documentation: DT: update atmel SSC with DMA binding

2013-07-09 Thread Richard Genoud
As atmel-ssc can be used with DMA, the documentation should be updated. Also, a configuration DMA example is given. Signed-off-by: Richard Genoud --- .../devicetree/bindings/misc/atmel-ssc.txt | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a

[PATCH v3 5/7] ARM: AT91: DTS: sam9x5ek: add WM8731 codec

2013-07-09 Thread Richard Genoud
The WM8731 codec on sam9x5ek board is on i2c, address 1A Signed-off-by: Richard Genoud Acked-by: Mark Brown --- arch/arm/boot/dts/at91sam9x5ek.dtsi |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/at91sam9x5ek.dtsi b/arch/arm/boot/dts/at91sam9x5ek.dtsi index

[PATCH v3 1/7] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards

2013-07-09 Thread Richard Genoud
from Nicolas that I forward ported and reworked to use only device tree] Signed-off-by: Nicolas Ferre Signed-off-by: Uwe Kleine-König Signed-off-by: Richard Genoud --- sound/soc/atmel/Kconfig | 10 ++ sound/soc/atmel/Makefile|2 + sound/soc/atmel/sam9x5_wm8731.c | 238

[PATCH v3 6/7] ARM: AT91: DTS: sam9x5ek: add sound configuration

2013-07-09 Thread Richard Genoud
The sam9x5ek board has 2 jacks: headphone wired on RHPOUT/LHPOUT of the wm8731 line in wired on LLINEIN/RLINEIN of the wm8731 Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5ek.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts

Re: [PATCH v2 1/5] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards

2013-07-09 Thread Richard Genoud
2013/7/9 Mark Brown : > On Tue, Jul 09, 2013 at 10:19:45AM +0200, Richard Genoud wrote: >> 2013/7/8 Mark Brown : > >> > The obvious question here is of course if we can use the same driver for >> > both of them. > >> I haven't got a g20 to test that, but

Re: [PATCH v2 2/5] ARM: AT91: DTS: sam9x5: add SSC DMA parameters

2013-07-09 Thread Richard Genoud
2013/7/9 Mark Brown : > On Tue, Jul 09, 2013 at 10:27:53AM +0200, Richard Genoud wrote: > >> The dma binding is documented here >> Documentation/devicetree/bindings/dma/atmel-dma.txt >> But you're right, I shoud update >> Documentation/devicetree/bindings/misc

Re: [PATCH v2 2/5] ARM: AT91: DTS: sam9x5: add SSC DMA parameters

2013-07-09 Thread Richard Genoud
2013/7/8 Mark Brown : > On Mon, Jul 08, 2013 at 03:29:50PM +0200, Richard Genoud wrote: >> Signed-off-by: Richard Genoud >> --- >> arch/arm/boot/dts/at91sam9x5.dtsi |3 +++ > > There was no binding document in your first patch - there should be one > for any ne

Re: [PATCH v2 1/5] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards

2013-07-09 Thread Richard Genoud
2013/7/8 Mark Brown : > On Mon, Jul 08, 2013 at 03:29:49PM +0200, Richard Genoud wrote: > >> + * Nicolas Ferre >> + * >> + * Based on sam9g20_wm8731.c by: >> + * Sedji Gaouaou > > The obvious question here is of course if we can use the same driver

Re: [alsa-devel] [PATCH v2 1/5] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards

2013-07-09 Thread Richard Genoud
2013/7/8 Lars-Peter Clausen : > On 07/08/2013 03:29 PM, Richard Genoud wrote: > [...] >> +/* >> + * Logic for a wm8731 as connected on a at91sam9x5 based board. >> + */ >> +static int at91sam9x5ek_wm8731_init(struct snd_soc_pcm_runtime *rtd) >> +{ > [...] >

[PATCH v2 1/5] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards

2013-07-08 Thread Richard Genoud
from Nicolas that I forward ported and reworked to use only device tree] Signed-off-by: Nicolas Ferre Signed-off-by: Uwe Kleine-König Signed-off-by: Richard Genoud --- sound/soc/atmel/Kconfig | 10 ++ sound/soc/atmel/Makefile|2 + sound/soc/atmel/sam9x5_wm8731.c | 206

[PATCH v2 0/5] Sound support for at91sam9x5-wm8731 based boards

2013-07-08 Thread Richard Genoud
ework * drop unneeded SND_ATMEL_SOC_PDC config selection * use static snd_soc_card and snd_soc_dai_link structures. Best regards, Richard. Nicolas Ferre (1): sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards Richard Genoud (4): ARM: AT91: DTS: sam9x5: add SSC DMA parameter

[PATCH v2 4/5] ARM: AT91: DTS: sam9x5ek: add sound configuration

2013-07-08 Thread Richard Genoud
The sam9x5ek board has 2 jacks: headphone wired on RHPOUT/LHPOUT of the wm8731 line in wired on LLINEIN/RLINEIN of the wm8731 Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5ek.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts

[PATCH v2 3/5] ARM: AT91: DTS: sam9x5ek: add WM8731 codec

2013-07-08 Thread Richard Genoud
The WM8731 codec on sam9x5ek board is on i2c, address 1A Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5ek.dtsi |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/at91sam9x5ek.dtsi b/arch/arm/boot/dts/at91sam9x5ek.dtsi index d107241..e6fb309 100644

[PATCH v2 5/5] ARM: AT91: DTS: sam9x5ek: enable SSC

2013-07-08 Thread Richard Genoud
Enable the SSC needed for the WM8731 codec Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5ek.dtsi |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/at91sam9x5ek.dtsi b/arch/arm/boot/dts/at91sam9x5ek.dtsi index bd0f7b8..6684d4b 100644 --- a/arch/arm

[PATCH v2 2/5] ARM: AT91: DTS: sam9x5: add SSC DMA parameters

2013-07-08 Thread Richard Genoud
Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5.dtsi |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi index 57d45f5..cf78ac0 100644 --- a/arch/arm/boot/dts/at91sam9x5.dtsi +++ b/arch/arm/boot/dts

<    1   2   3   4   5   >