Re: Tabs, spaces, indent and 80 character lines

Miles Bader wrote: Why do people even respond to these trolls...? -Miles Obviously, this must to have been discussed before, with a clear conclusion. Unfortunately, I have not, during my ~2 years on the list, seen anything of the sort and would like to, in that case, request a small

Re: Tabs, spaces, indent and 80 character lines

Krzysztof Halasa wrote: Richard Knutsson <[EMAIL PROTECTED]> writes: I guess we could use tabs only at the line start, for indentation only. Rather hard to implement, most text editors can't do that yet. You mean for split lines? Syntactic indentation vs ali

Re: Tabs, spaces, indent and 80 character lines

Benny Halevy wrote: On Feb. 24, 2008, 7:40 -0800, Richard Knutsson <[EMAIL PROTECTED]> wrote: Krzysztof Halasa wrote: Richard Knutsson <[EMAIL PROTECTED]> writes: Why hinder a developer who prefer 2, 4, 6 or any other != 8 width? I guess we co

Re: Tabs, spaces, indent and 80 character lines

Benny Halevy wrote: On Feb. 24, 2008, 7:40 -0800, Richard Knutsson [EMAIL PROTECTED] wrote: Krzysztof Halasa wrote: Richard Knutsson [EMAIL PROTECTED] writes: Why hinder a developer who prefer 2, 4, 6 or any other != 8 width? I guess we could use tabs only

Re: Tabs, spaces, indent and 80 character lines

Krzysztof Halasa wrote: Richard Knutsson [EMAIL PROTECTED] writes: I guess we could use tabs only at the line start, for indentation only. Rather hard to implement, most text editors can't do that yet. You mean for split lines? Syntactic indentation vs alignment (including

Re: Tabs, spaces, indent and 80 character lines

Miles Bader wrote: Why do people even respond to these trolls...? -Miles Obviously, this must to have been discussed before, with a clear conclusion. Unfortunately, I have not, during my ~2 years on the list, seen anything of the sort and would like to, in that case, request a small

Re: Tabs, spaces, indent and 80 character lines

Krzysztof Halasa wrote: Richard Knutsson <[EMAIL PROTECTED]> writes: Why hinder a developer who prefer 2, 4, 6 or any other != 8 width? I guess we could use tabs only at the line start, for indentation only. Rather hard to implement, most text editors can't do that yet. Yo

Re: Tabs, spaces, indent and 80 character lines

Krzysztof Halasa wrote: Richard Knutsson [EMAIL PROTECTED] writes: Why hinder a developer who prefer 2, 4, 6 or any other != 8 width? I guess we could use tabs only at the line start, for indentation only. Rather hard to implement, most text editors can't do that yet. You mean

Tabs, spaces, indent and 80 character lines

s, and changing the CodeStyle to be something like "maximum 80 characters-wide lines, with a tab-setting of 8 spaces", that is possible + easier to write code-checkers [2]. Or are we really that concerned about the disk-space? ;) 2 cents away... /Richard Knutsson [1] As has been p

Tabs, spaces, indent and 80 character lines

to be something like maximum 80 characters-wide lines, with a tab-setting of 8 spaces, that is possible + easier to write code-checkers [2]. Or are we really that concerned about the disk-space? ;) 2 cents away... /Richard Knutsson [1] As has been pointed out by many, it is the complexity that matters

Re: [PATCH] Silent compiler warning introduced by acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]: Move children of connection device to NULL before connection down.)

S.Çağlar Onur wrote: Hi; Following patch silents net/bluetooth/hci_sysfs.c: In function `del_conn': net/bluetooth/hci_sysfs.c:339: warning: suggest parentheses around assignment used as truth value compiler warning introduced by commit acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]:

Re: [PATCH] Silent compiler warning introduced by acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]: Move children of connection device to NULL before connection down.)

S.Çağlar Onur wrote: Hi; Following patch silents net/bluetooth/hci_sysfs.c: In function `del_conn': net/bluetooth/hci_sysfs.c:339: warning: suggest parentheses around assignment used as truth value compiler warning introduced by commit acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]:

Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl

Andre Noll wrote: On 17:40, Andi Kleen wrote: Here's a proposal for some useful code transformations the kernel janitors could do as opposed to running checkpatch.pl. Here's my take on drivers/scsi/sg.c. It's only compile-tested on x86-64. ... and x86 with all(yes|mod)config. :)

Re: [JANITOR PROPOSAL] Switch ioctl functions to -unlocked_ioctl

Andre Noll wrote: On 17:40, Andi Kleen wrote: Here's a proposal for some useful code transformations the kernel janitors could do as opposed to running checkpatch.pl. Here's my take on drivers/scsi/sg.c. It's only compile-tested on x86-64. ... and x86 with all(yes|mod)config. :)

[PATCH][SCSI] megaraid: Convert from "scsi.h" to (and friends)

Convert glue-include "scsi.h" to (and friends). (binary sizes) allyesconfig: before: 260132 after: 260048 allmodconfig: before: 261740 after: 261656 Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Do not have the hardware, but since it

Re: [patch 1/5] Introduce __WARN()

Arjan van de Ven wrote: On Sun, 06 Jan 2008 17:09:44 +0100 Richard Knutsson <[EMAIL PROTECTED]> wrote: (btw, wouldn't 'var != 0' actually be the proper semantic instead of playing with '!'s?) no because var could be a pointer for example... You mean b

Re: [patch 1/5] Introduce __WARN()

Arjan van de Ven wrote: On Sun, 06 Jan 2008 12:44:56 +0100 Richard Knutsson <[EMAIL PROTECTED]> wrote: Arjan van de Ven wrote: From: Olof Johansson <[EMAIL PROTECTED]> Introduce __WARN() in the generic case, so the generic WARN_ON() can use arch-specific code for when t

Re: [patch 1/5] Introduce __WARN()

Arjan van de Ven wrote: From: Olof Johansson <[EMAIL PROTECTED]> Introduce __WARN() in the generic case, so the generic WARN_ON() can use arch-specific code for when the condition is true. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton

Re: [patch 1/5] Introduce __WARN()

Arjan van de Ven wrote: From: Olof Johansson [EMAIL PROTECTED] Introduce __WARN() in the generic case, so the generic WARN_ON() can use arch-specific code for when the condition is true. Signed-off-by: Olof Johansson [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL

Re: [patch 1/5] Introduce __WARN()

Arjan van de Ven wrote: On Sun, 06 Jan 2008 17:09:44 +0100 Richard Knutsson [EMAIL PROTECTED] wrote: (btw, wouldn't 'var != 0' actually be the proper semantic instead of playing with '!'s?) no because var could be a pointer for example... You mean because

[PATCH][SCSI] megaraid: Convert from scsi.h to scsi.h (and friends)

Convert glue-include scsi.h to scsi.h (and friends). (binary sizes) allyesconfig: before: 260132 after: 260048 allmodconfig: before: 261740 after: 261656 Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Do not have the hardware, but since it compiles I hope

Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c

f (err) - ext4_journal_abort_handle(where, __FUNCTION__, bh, handle,err); + ext4_journal_abort_handle(where, __FUNCTION__, bh, handle, err); return err; } Hi Mathieu What about changing the __FUNCTION__ to __func__, while you are at it? Richard Knutsson -- To unsubscribe from this list

Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c

) - ext4_journal_abort_handle(where, __FUNCTION__, bh, handle,err); + ext4_journal_abort_handle(where, __FUNCTION__, bh, handle, err); return err; } Hi Mathieu What about changing the __FUNCTION__ to __func__, while you are at it? Richard Knutsson -- To unsubscribe from this list: send the line

Re: [PATCH 1/3] ipc: Convert handmade 'max' to max().

Sorry for the late response, have been away during the holidays. Andrew Morton wrote: On Mon, 17 Dec 2007 03:35:55 +0100 (MET) Richard Knutsson <[EMAIL PROTECTED]> wrote: Convert handmade 'max' to max(). ... --- a/ipc/msg.c +++ b/ipc/msg.c @@ -473,7 +473,7 @@ asmlinkage long sys_

Re: [PATCH 1/3] ipc: Convert handmade 'max' to max().

Sorry for the late response, have been away during the holidays. Andrew Morton wrote: On Mon, 17 Dec 2007 03:35:55 +0100 (MET) Richard Knutsson [EMAIL PROTECTED] wrote: Convert handmade 'max' to max(). ... --- a/ipc/msg.c +++ b/ipc/msg.c @@ -473,7 +473,7 @@ asmlinkage long sys_msgctl

[PATCH 3/3] ipc: Convert handmade 'min' to min().

Convert handmade 'min' to min(). Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Dependent on 'msg->m_ts' being changed from int to size_t. diff --git a/ipc/msg.c b/ipc/msg.c index fdf3db5..74d0709 100644 --- a/ipc/msg.c +++ b/ipc/msg.c @@ -920,7 +920,7 @@ out_unlock: i

[PATCH 1/3] ipc: Convert handmade 'max' to max().

Convert handmade 'max' to max(). Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- msg.c |2 +- sem.c |2 +- shm.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ipc/msg.c b/ipc/msg.c index fdf3db5..74d0709 100644 --- a/ipc/msg.c +++ b/ipc

[PATCH 2/3] msg.h: Convert m_ts from int to size_t.

Convert m_ts ("message text size") from int to size_t. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Remove some trailing spaces, since we are in the neighborhood. diff --git a/include/linux/msg.h b/include/linux/msg.h index 10a3d5a..7a61952 100644 --- a/include/l

[PATCH 1/3] ipc: Convert handmade 'max' to max().

Convert handmade 'max' to max(). Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- msg.c |2 +- sem.c |2 +- shm.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ipc/msg.c b/ipc/msg.c index fdf3db5..74d0709 100644 --- a/ipc/msg.c +++ b/ipc/msg.c @@ -473,7

[PATCH 2/3] msg.h: Convert m_ts from int to size_t.

Convert m_ts (message text size) from int to size_t. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Remove some trailing spaces, since we are in the neighborhood. diff --git a/include/linux/msg.h b/include/linux/msg.h index 10a3d5a..7a61952 100644 --- a/include/linux/msg.h +++ b/include

[PATCH 3/3] ipc: Convert handmade 'min' to min().

Convert handmade 'min' to min(). Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Dependent on 'msg-m_ts' being changed from int to size_t. diff --git a/ipc/msg.c b/ipc/msg.c index fdf3db5..74d0709 100644 --- a/ipc/msg.c +++ b/ipc/msg.c @@ -920,7 +920,7 @@ out_unlock: if (IS_ERR

Re: [PATCH 1/6] pcmcia/3c574_cs: Fix dubious bitfield warning

Alan Cox wrote: On Tue, 11 Dec 2007 05:32:38 +0100 (MET) Richard Knutsson <[EMAIL PROTECTED]> wrote: Fixing: CHECK drivers/net/pcmcia/3c574_cs.c drivers/net/pcmcia/3c574_cs.c:194:13: warning: dubious bitfield without explicit `signed' or `unsigned' drivers/net/pcmcia/3c574_cs.c:

Re: [PATCH 1/6] pcmcia/3c574_cs: Fix dubious bitfield warning

Alan Cox wrote: On Tue, 11 Dec 2007 05:32:38 +0100 (MET) Richard Knutsson [EMAIL PROTECTED] wrote: Fixing: CHECK drivers/net/pcmcia/3c574_cs.c drivers/net/pcmcia/3c574_cs.c:194:13: warning: dubious bitfield without explicit `signed' or `unsigned' drivers/net/pcmcia/3c574_cs.c:196:14

[PATCH 6/6] pcmcia/pcnet_cs: Fix 'shadow variable' warning

Fixing: CHECK drivers/net/pcmcia/pcnet_cs.c drivers/net/pcmcia/pcnet_cs.c:523:15: warning: symbol 'hw_info' shadows an earlier one drivers/net/pcmcia/pcnet_cs.c:148:18: originally declared here Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- diff --git a/drivers/net/

[PATCH 4/6] pcmcia/axnet_cs: Make use of 'max()' instead of handcrafted one

Use 'max(x,y)' instead of 'x < y ? y : x'. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- diff --git a/drivers/net/pcmcia/axnet_cs.c b/drivers/net/pcmcia/axnet_cs.c index 8d910a3..96931cc 100644 --- a/drivers/net/pcmcia/axnet_cs.c +++ b/drivers/net/pcmcia/axnet_cs.c @@ -1091,

[PATCH 5/6] pcmcia/fmvj18x_cs: Fix 'shadow variable' warning

Fixing: CHECK drivers/net/pcmcia/fmvj18x_cs.c drivers/net/pcmcia/fmvj18x_cs.c:1205:6: warning: symbol 'i' shadows an earlier one drivers/net/pcmcia/fmvj18x_cs.c:1179:9: originally declared here Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- diff --git a/drivers/net/

[PATCH 2/6] pcmcia/3c574_cs: Fix 'shadow variable' warning

Fixing: CHECK drivers/net/pcmcia/3c574_cs.c drivers/net/pcmcia/3c574_cs.c:695:7: warning: symbol 'i' shadows an earlier one drivers/net/pcmcia/3c574_cs.c:636:6: originally declared here Signed-off-by: Richard Knutson <[EMAIL PROTECTED]> --- diff --git a/drivers/net/pcmcia/3c574_cs.c

[PATCH 1/6] pcmcia/3c574_cs: Fix dubious bitfield warning

Fixing: CHECK drivers/net/pcmcia/3c574_cs.c drivers/net/pcmcia/3c574_cs.c:194:13: warning: dubious bitfield without explicit `signed' or `unsigned' drivers/net/pcmcia/3c574_cs.c:196:14: warning: dubious bitfield without explicit `signed' or `unsigned' Signed-off-by: Richard Knutsson <[EM

[PATCH 3/6] pcmcia/axnet_cs: Make functions static

Fixing: CHECK drivers/net/pcmcia/axnet_cs.c drivers/net/pcmcia/axnet_cs.c:994:5: warning: symbol 'ax_close' was not declared. Should it be static? drivers/net/pcmcia/axnet_cs.c:1017:6: warning: symbol 'ei_tx_timeout' was not declared. Should it be static? Signed-off-by: Richard Knutsson

Re: [PATCH] drivers/net/ipg: Remove local definition of TRUE/FALSE

Pekka Enberg wrote: Hi Richard, On Dec 10, 2007 9:29 PM, Richard Knutsson <[EMAIL PROTECTED]> wrote: Remove local definition of TRUE/FALSE. This is already fixed in Francois' tree: http://git.kernel.org/?p=linux/kernel/git/romieu/netdev-2.6.git;a=commit

[PATCH] drivers/net/ipg: Remove local definition of TRUE/FALSE

Remove local definition of TRUE/FALSE. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- diff --git a/drivers/net/ipg.h b/drivers/net/ipg.h index d5d092c..4484778 100644 --- a/drivers/net/ipg.h +++ b/drivers/net/ipg.h @@ -490,38 +490,34 @@ enum ipg_regs { *

[PATCH] drivers/net/ipg: Remove local definition of TRUE/FALSE

Remove local definition of TRUE/FALSE. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- diff --git a/drivers/net/ipg.h b/drivers/net/ipg.h index d5d092c..4484778 100644 --- a/drivers/net/ipg.h +++ b/drivers/net/ipg.h @@ -490,38 +490,34 @@ enum ipg_regs { * Tune

Re: [PATCH] drivers/net/ipg: Remove local definition of TRUE/FALSE

Pekka Enberg wrote: Hi Richard, On Dec 10, 2007 9:29 PM, Richard Knutsson [EMAIL PROTECTED] wrote: Remove local definition of TRUE/FALSE. This is already fixed in Francois' tree: http://git.kernel.org/?p=linux/kernel/git/romieu/netdev-2.6.git;a=commitdiff;h

[PATCH 2/6] pcmcia/3c574_cs: Fix 'shadow variable' warning

Fixing: CHECK drivers/net/pcmcia/3c574_cs.c drivers/net/pcmcia/3c574_cs.c:695:7: warning: symbol 'i' shadows an earlier one drivers/net/pcmcia/3c574_cs.c:636:6: originally declared here Signed-off-by: Richard Knutson [EMAIL PROTECTED] --- diff --git a/drivers/net/pcmcia/3c574_cs.c

[PATCH 1/6] pcmcia/3c574_cs: Fix dubious bitfield warning

Fixing: CHECK drivers/net/pcmcia/3c574_cs.c drivers/net/pcmcia/3c574_cs.c:194:13: warning: dubious bitfield without explicit `signed' or `unsigned' drivers/net/pcmcia/3c574_cs.c:196:14: warning: dubious bitfield without explicit `signed' or `unsigned' Signed-off-by: Richard Knutsson [EMAIL

[PATCH 3/6] pcmcia/axnet_cs: Make functions static

Fixing: CHECK drivers/net/pcmcia/axnet_cs.c drivers/net/pcmcia/axnet_cs.c:994:5: warning: symbol 'ax_close' was not declared. Should it be static? drivers/net/pcmcia/axnet_cs.c:1017:6: warning: symbol 'ei_tx_timeout' was not declared. Should it be static? Signed-off-by: Richard Knutsson

[PATCH 4/6] pcmcia/axnet_cs: Make use of 'max()' instead of handcrafted one

Use 'max(x,y)' instead of 'x y ? y : x'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- diff --git a/drivers/net/pcmcia/axnet_cs.c b/drivers/net/pcmcia/axnet_cs.c index 8d910a3..96931cc 100644 --- a/drivers/net/pcmcia/axnet_cs.c +++ b/drivers/net/pcmcia/axnet_cs.c @@ -1091,8 +1091,8

[PATCH 5/6] pcmcia/fmvj18x_cs: Fix 'shadow variable' warning

Fixing: CHECK drivers/net/pcmcia/fmvj18x_cs.c drivers/net/pcmcia/fmvj18x_cs.c:1205:6: warning: symbol 'i' shadows an earlier one drivers/net/pcmcia/fmvj18x_cs.c:1179:9: originally declared here Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- diff --git a/drivers/net/pcmcia

[PATCH 6/6] pcmcia/pcnet_cs: Fix 'shadow variable' warning

Fixing: CHECK drivers/net/pcmcia/pcnet_cs.c drivers/net/pcmcia/pcnet_cs.c:523:15: warning: symbol 'hw_info' shadows an earlier one drivers/net/pcmcia/pcnet_cs.c:148:18: originally declared here Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- diff --git a/drivers/net/pcmcia/pcnet_cs.c

[PATCH] ivtv: Some general fixes

Fix "warning: Using plain integer as NULL pointer". Convert 'x < y ? x : y' to use min() instead. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> Signed-off-by: Hans Verkuil <[EMAIL PROTECTED]> --- Compile-tested on i386 with "allyesconfig" and "allmod

[PATCH] kernel/params.c: Remove sparse-warning (different signedness).

Fixing: CHECK kernel/params.c kernel/params.c:329:41: warning: incorrect type in argument 8 (different signedness) kernel/params.c:329:41:expected int *num kernel/params.c:329:41:got unsigned int * Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on x86 wi

[PATCH] mm/mmap: Remove sparse-warning (NULL as 0).

Fixing: CHECK mm/mmap.c mm/mmap.c:1623:29: warning: Using plain integer as NULL pointer mm/mmap.c:1623:29: warning: Using plain integer as NULL pointer mm/mmap.c:1944:29: warning: Using plain integer as NULL pointer Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> ---

[PATCH] mm/mmap: Remove sparse-warning (NULL as 0).

Fixing: CHECK mm/mmap.c mm/mmap.c:1623:29: warning: Using plain integer as NULL pointer mm/mmap.c:1623:29: warning: Using plain integer as NULL pointer mm/mmap.c:1944:29: warning: Using plain integer as NULL pointer Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Added

[PATCH] kernel/params.c: Remove sparse-warning (different signedness).

Fixing: CHECK kernel/params.c kernel/params.c:329:41: warning: incorrect type in argument 8 (different signedness) kernel/params.c:329:41:expected int *num kernel/params.c:329:41:got unsigned int * Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Compile-tested on x86 with all

[PATCH] ivtv: Some general fixes

Fix warning: Using plain integer as NULL pointer. Convert 'x y ? x : y' to use min() instead. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] Signed-off-by: Hans Verkuil [EMAIL PROTECTED] --- Compile-tested on i386 with allyesconfig and allmodconfig. Resend, since the 'Remove a gcc-2.95

Re: [Patch] net/xfrm/xfrm_policy.c: Some small improvements

David Miller wrote: From: Richard Knutsson <[EMAIL PROTECTED]> Date: Thu, 06 Dec 2007 15:37:46 +0100 David Miller wrote: But this time I'll just let you know up front that I don't see much value in this patch. It is not a clear improvement to replace int's with bool's in m

Re: [Patch] net/xfrm/xfrm_policy.c: Some small improvements

David Miller wrote: From: Richard Knutsson [EMAIL PROTECTED] Date: Thu, 06 Dec 2007 15:37:46 +0100 David Miller wrote: But this time I'll just let you know up front that I don't see much value in this patch. It is not a clear improvement to replace int's with bool's in my mind

Re: [Patch] net/xfrm/xfrm_policy.c: Some small improvements

ome potential bugs like the 'if (i == TRUE)'... What is wrong with 'size_t' (since it is unsigned, compared to (some) 'int')? /Richard Knutsson -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [Patch] net/xfrm/xfrm_policy.c: Some small improvements

the 'if (i == TRUE)'... What is wrong with 'size_t' (since it is unsigned, compared to (some) 'int')? /Richard Knutsson -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] ivtv: Some general fixes

Fix "warning: Using plain integer as NULL pointer". Convert 'x < y ? x : y' to use min() instead. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> Signed-off-by: Hans Verkuil <[EMAIL PROTECTED]> --- Compile-tested on i386 with "allyesconfig" and "allmod

[PATCH] ivtv: Some general fixes

Fix warning: Using plain integer as NULL pointer. Convert 'x y ? x : y' to use min() instead. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] Signed-off-by: Hans Verkuil [EMAIL PROTECTED] --- Compile-tested on i386 with allyesconfig and allmodconfig. Resend, since the 'Remove a gcc-2.95

Re: [v4l-dvb-maintainer] [PATCH 1/2] ivtv: Some general fixes

Hans Verkuil wrote: On Sunday 02 December 2007 18:46, Richard Knutsson wrote: Fix "warning: Using plain integer as NULL pointer". Signed-off-by: Hans Verkuil <[EMAIL PROTECTED]> Remove a gcc-2.95 requirement. NACK! The main v4l-dvb repository that contains

[PATCH 2/2] ivtv: Remove a invalid shadow-variable

Remove the shadowing 'struct v4l2_chip_ident *chip', since it already exists and makes the if-statement useless. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with "allyesconfig" and "allmodconfig". diff --git a/drivers/media/video/iv

[PATCH 1/2] ivtv: Some general fixes

Fix "warning: Using plain integer as NULL pointer". Remove a gcc-2.95 requirement. Convert 'x < y ? x : y' to use min() instead. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with "allyesconfig" and "allmodconfig". ivtv-dri

[PATCH 1/2] ivtv: Some general fixes

Fix warning: Using plain integer as NULL pointer. Remove a gcc-2.95 requirement. Convert 'x y ? x : y' to use min() instead. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Compile-tested on i386 with allyesconfig and allmodconfig. ivtv-driver.c |2 +- ivtv-driver.h |4

[PATCH 2/2] ivtv: Remove a invalid shadow-variable

Remove the shadowing 'struct v4l2_chip_ident *chip', since it already exists and makes the if-statement useless. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Compile-tested on i386 with allyesconfig and allmodconfig. diff --git a/drivers/media/video/ivtv/ivtv-ioctl.c b/drivers/media

Re: [v4l-dvb-maintainer] [PATCH 1/2] ivtv: Some general fixes

Hans Verkuil wrote: On Sunday 02 December 2007 18:46, Richard Knutsson wrote: Fix warning: Using plain integer as NULL pointer. Signed-off-by: Hans Verkuil [EMAIL PROTECTED] Remove a gcc-2.95 requirement. NACK! The main v4l-dvb repository that contains this driver can also

Re: [RFC] kmemcheck: trap uses of uninitialized memory (v2)

Vegard Nossum wrote: Hi, On Nov 28, 2007 7:51 AM, Richard Knutsson <[EMAIL PROTECTED]> wrote: Vegard Nossum wrote: +static int Not 'static bool'? +page_is_tracked(struct page *page) Why not returning 'false' and 'true'? Sorry, I am not used to usin

Re: [RFC] kmemcheck: trap uses of uninitialized memory (v2)

Vegard Nossum wrote: Hi, On Nov 28, 2007 7:51 AM, Richard Knutsson [EMAIL PROTECTED] wrote: Vegard Nossum wrote: +static int Not 'static bool'? +page_is_tracked(struct page *page) Why not returning 'false' and 'true'? Sorry, I am not used to using bool

Re: [RFC] kmemcheck: trap uses of uninitialized memory (v2)

dow, unsigned int size) +{ +switch (size) { +case 8: +return *(uint8_t *) shadow == 0xff; +case 16: +return *(uint16_t *) shadow == 0x; +case 32: +return *(uint32_t *) shadow == 0x; +} + +BUG(); +return 0; 'return false;'? +} + cu

Re: [PATCH] [VIDEO]: Complement va_start() with va_end() + style fixes

Please ignore the previous patch. Have resent it, but since my mail-client (Thunderbird) seem to be having a bad day, I had to use 'sendpatchset' and it can't continue on a thread. Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

[PATCH] [VIDEO]: Complement va_start() with va_end() + style fixes

Complement va_start() with va_end() + minor style fixes in the same function. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with allyesconfig and allmodconfig. Thanks to WANG Cong for pointing out the missing 'style fix'-description. (Sorry about the

[PATCH] [VIDEO]: Complement va_start() with va_end() + style fixes

Complement va_start() with va_end() + minor style fixes in the same function. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with allyesconfig and allmodconfig. Thanks to WANG Cong for pointing out the missing 'style fix'-description. saa5246a.c

[PATCH] [VIDEO]: Complement va_start() with va_end() + style fixes

Complement va_start() with va_end() + minor style fixes in the same function. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Compile-tested on i386 with allyesconfig and allmodconfig. Thanks to WANG Cong for pointing out the missing 'style fix'-description. saa5246a.c | 10

[PATCH] [VIDEO]: Complement va_start() with va_end() + style fixes

Complement va_start() with va_end() + minor style fixes in the same function. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Compile-tested on i386 with allyesconfig and allmodconfig. Thanks to WANG Cong for pointing out the missing 'style fix'-description. (Sorry about the repost

Re: [PATCH] [VIDEO]: Complement va_start() with va_end() + style fixes

Please ignore the previous patch. Have resent it, but since my mail-client (Thunderbird) seem to be having a bad day, I had to use 'sendpatchset' and it can't continue on a thread. Richard Knutsson - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [RFC] kmemcheck: trap uses of uninitialized memory (v2)

) { +case 8: +return *(uint8_t *) shadow == 0xff; +case 16: +return *(uint16_t *) shadow == 0x; +case 32: +return *(uint32_t *) shadow == 0x; +} + +BUG(); +return 0; 'return false;'? +} + snip cu Richard Knutsson - To unsubscribe from

[PATCH] [VIDEO]: Complement va_start() with va_end().

Complement va_start() with va_end(). Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with allyesconfig and allmodconfig. diff --git a/drivers/media/video/saa5246a.c b/drivers/media/video/saa5246a.c index ad02329..996b494 100644 --- a/drivers/media/video/saa5

Re: [PATCH] [RESEND] crypto test: use print_hex_dump from kernel.h instead

hy use '0' instead of 'false'? } static void tcrypt_complete(struct crypto_async_request *req, int err) cu Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] [ACPI] utilities/: Compliment va_start() with va_end().

te messy. When it comes to va_end() and maintainers, they often seem positive to this. I guess the occasional lack off va_end() is usually an oversight. -Original Message- From: Richard Knutsson [mailto:[EMAIL PROTECTED] Sent: Monday, November 26, 2007 4:16 PM To: Moore, Robert Cc: Len Brown

Re: [PATCH] [ACPI] utilities/: Compliment va_start() with va_end().

t is how I found this one). I suppose some implementation could allocate memory at va_start, but in practice, does this happen? Not sure what you mean. Bob cu Richard Knutsson [1] http://www.cs.utah.edu/dept/old/texinfo/glibc-manual-0.02/library_28.html [2] The rest of [1]'s line. -

[PATCH] [REISERFS]: Complement va_start() with va_end().

Complement va_start() with va_end(). Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with allyesconfig and allmodconfig. BTW, the nested if()'s (lines above) may look better if unnested. diff --git a/fs/reiserfs/prints.c b/fs/reiserfs/prints.c index 5

[PATCH] [REISERFS]: Complement va_start() with va_end().

Complement va_start() with va_end(). Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Compile-tested on i386 with allyesconfig and allmodconfig. BTW, the nested if()'s (lines above) may look better if unnested. diff --git a/fs/reiserfs/prints.c b/fs/reiserfs/prints.c index 5e7388b..740bb8c

Re: [PATCH] [ACPI] utilities/: Compliment va_start() with va_end().

some implementation could allocate memory at va_start, but in practice, does this happen? Not sure what you mean. Bob cu Richard Knutsson [1] http://www.cs.utah.edu/dept/old/texinfo/glibc-manual-0.02/library_28.html [2] The rest of [1]'s line. - To unsubscribe from this list: send

Re: [PATCH] [ACPI] utilities/: Compliment va_start() with va_end().

to va_end() and maintainers, they often seem positive to this. I guess the occasional lack off va_end() is usually an oversight. -Original Message- From: Richard Knutsson [mailto:[EMAIL PROTECTED] Sent: Monday, November 26, 2007 4:16 PM To: Moore, Robert Cc: Len Brown; linux-kernel

Re: [PATCH] [RESEND] crypto test: use print_hex_dump from kernel.h instead

*req, int err) cu Richard Knutsson - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] [VIDEO]: Complement va_start() with va_end().

Complement va_start() with va_end(). Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Compile-tested on i386 with allyesconfig and allmodconfig. diff --git a/drivers/media/video/saa5246a.c b/drivers/media/video/saa5246a.c index ad02329..996b494 100644 --- a/drivers/media/video/saa5246a.c

Re: [PATCH] net/irda/parameters.c: Trivial fixes

Samuel Ortiz wrote: Hi Richard, On Sat, Nov 24, 2007 at 09:44:05PM +0100, Richard Knutsson wrote: Make a single va_start() -> va_end() path + fixing: Ok, this should be 2 separate patches then. Thought about it, but they were so simple, I believed they would better be mer

[PATCH] include/asm-m68k: Remove atari_joystick.h

Remove include/asm-m68k/atari_joystick.h and clean up. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Not compiled, but should be trivial. (if FIXED_ATARI_JOYSTICK is defined somehow, please tell how) b/arch/m68k/atari/atakeyb.c|8 b/arch/m68k/atari/atari_k

[PATCH] include/asm-m68k: Remove atari_joystick.h

Remove include/asm-m68k/atari_joystick.h and clean up. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Not compiled, but should be trivial. (if FIXED_ATARI_JOYSTICK is defined somehow, please tell how) b/arch/m68k/atari/atakeyb.c|8 b/arch/m68k/atari/atari_ksyms.c

Re: [PATCH] net/irda/parameters.c: Trivial fixes

Samuel Ortiz wrote: Hi Richard, On Sat, Nov 24, 2007 at 09:44:05PM +0100, Richard Knutsson wrote: Make a single va_start() - va_end() path + fixing: Ok, this should be 2 separate patches then. Thought about it, but they were so simple, I believed they would better be merged

[PATCH] kernel: Compliment va_copy with va_end()

Compliment va_copy() with va_end(). Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with allyesconfig & allmodconfig. diff --git a/kernel/audit.c b/kernel/audit.c index f93c271..836626c 100644 --- a/kernel/audit.c +++ b/kernel/audit.c @@ -1245,6 +1245,7

[PATCH] [MIPS]: Compliment va_start() with va_end().

Compliment va_start() with va_end(). Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- ieee754.c |2 ++ ieee754dp.c |2 ++ ieee754sp.c |2 ++ 3 files changed, 6 insertions(+) diff --git a/arch/mips/math-emu/ieee754.c b/arch/mips/math-emu/ieee754.c index 946aee3..c

[PATCH] net/irda/parameters.c: Trivial fixes

nel/src/net/irda/parameters.c:573:2: warning: Using plain integer as NULL pointer Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with allyesconfig and allmodconfig. diff --git a/net/irda/parameters.c b/net/irda/parameters.c index 2627dad..bf19071 100644 --- a

[PATCH] [ACPI] utilities/: Compliment va_start() with va_end().

Compliment va_start() with va_end(). Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with allyesconfig & allmodconfig. utdebug.c |2 ++ utmisc.c |4 2 files changed, 6 insertions(+) diff --git a/drivers/acpi/utilities/utdebug.c b/dr

[PATCH] [ACPI] utilities/: Compliment va_start() with va_end().

Compliment va_start() with va_end(). Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Compile-tested on i386 with allyesconfig allmodconfig. utdebug.c |2 ++ utmisc.c |4 2 files changed, 6 insertions(+) diff --git a/drivers/acpi/utilities/utdebug.c b/drivers/acpi

[PATCH] net/irda/parameters.c: Trivial fixes

/src/net/irda/parameters.c:573:2: warning: Using plain integer as NULL pointer Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Compile-tested on i386 with allyesconfig and allmodconfig. diff --git a/net/irda/parameters.c b/net/irda/parameters.c index 2627dad..bf19071 100644 --- a/net/irda

[PATCH] [MIPS]: Compliment va_start() with va_end().

Compliment va_start() with va_end(). Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- ieee754.c |2 ++ ieee754dp.c |2 ++ ieee754sp.c |2 ++ 3 files changed, 6 insertions(+) diff --git a/arch/mips/math-emu/ieee754.c b/arch/mips/math-emu/ieee754.c index 946aee3..cb1b682

[PATCH] kernel: Compliment va_copy with va_end()

Compliment va_copy() with va_end(). Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Compile-tested on i386 with allyesconfig allmodconfig. diff --git a/kernel/audit.c b/kernel/audit.c index f93c271..836626c 100644 --- a/kernel/audit.c +++ b/kernel/audit.c @@ -1245,6 +1245,7 @@ static

Re: [patch 02/13] dio: ARRAY_SIZE() cleanup

Geert Uytterhoeven wrote: -#define NUMNAMES (sizeof(names) / sizeof(struct dioname)) +#define NUMNAMES ARRAY_SIZE(names) Why not replace NUMNAMES? /Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTE

  1   2   3   4   >