Re: [PATCH v9 2/4] vcodec: mediatek: Add Mediatek JPEG Decoder Driver

2016-12-17 Thread Ricky Liang
+ > drivers/media/platform/mtk-jpeg/mtk_jpeg_hw.h| 91 ++ > drivers/media/platform/mtk-jpeg/mtk_jpeg_parse.c | 160 +++ > drivers/media/platform/mtk-jpeg/mtk_jpeg_parse.h | 25 + > drivers/media/platform/mtk-jpeg/mtk_jpeg_reg.h | 58 + > 10 files changed, 2215 insert

Re: [PATCH v8 2/4] vcodec: mediatek: Add Mediatek JPEG Decoder Driver

2016-12-13 Thread Ricky Liang
Hi Rick, Can you upload patchset v9 to address the issue? Thanks! On Mon, Dec 12, 2016 at 5:07 PM, Rick Chang wrote: > Hi Ricky, > > Thanks for your feedback. We will fix the problem in another patch. > > On Mon, 2016-12-12 at 12:34 +0800, Ricky Liang wrote: >> Hi Rick,

Re: [PATCH v8 2/4] vcodec: mediatek: Add Mediatek JPEG Decoder Driver

2016-12-11 Thread Ricky Liang
Hi Rick, On Wed, Nov 30, 2016 at 11:08 AM, Rick Chang wrote: > Add v4l2 driver for Mediatek JPEG Decoder > > Signed-off-by: Rick Chang > Signed-off-by: Minghsiu Tsai > +static bool mtk_jpeg_check_resolution_change(struct mtk_jpeg_ctx *ctx, > +struc

[PATCH] mwifiex: fix memory leak in mwifiex_save_hidden_ssid_channels()

2016-11-08 Thread Ricky Liang
_irqs+0xf8/0x160 [] sdio_irq_thread+0x9c/0x1a4 [] kthread+0xf4/0x100 [] ret_from_fork+0xc/0x50 [] 0x Signed-off-by: Ricky Liang --- drivers/net/wireless/marvell/mwifiex/scan.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/marvell/mwifiex

[PATCH v3] Bluetooth: btmrvl: fix slab-out-of-bounds access in btmrvl_sdio

2016-06-28 Thread Ricky Liang
CC: Wei-Ning Huang CC: Daniel Kurtz CC: Amitkumar Karwar Signed-off-by: Ricky Liang --- drivers/bluetooth/btmrvl_sdio.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c index f425ddf..b7c3928 100

[PATCH v2] Bluetooth: btmrvl: fix slab-out-of-bounds access in btmrvl_sdio

2016-06-26 Thread Ricky Liang
SIZE. We just need to make sure the relocation of memory for making the address BTSDIO_DMA_ALIGN-aligned does not cause out-of-bound access. CC: Wei-Ning Huang CC: Daniel Kurtz CC: Amitkumar Karwar Signed-off-by: Ricky Liang --- drivers/bluetooth/btmrvl_sdio.c | 9 ++--- 1 file ch

[PATCH] Bluetooth: btmrvl: fix slab-out-of-bounds access in btmrvl_sdio

2016-06-26 Thread Ricky Liang
SIZE. We just need to make sure the relocation of memory for making the address BTSDIO_DMA_ALIGN-aligned does not cause out-of-bound access. CC: Wei-Ning Huang CC: Daniel Kurtz CC: Amitkumar Karwar Signed-off-by: Ricky Liang --- drivers/bluetooth/btmrvl_sdio.c | 9 ++--- 1 file ch

[PATCH] Bluetooth: btmrvl: fix slab-out-of-bounds access in btmrvl_sdio

2016-06-20 Thread Ricky Liang
ion. Signed-off-by: Ricky Liang --- drivers/bluetooth/btmrvl_sdio.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c index f425ddf..0bfeb19 100644 --- a/drivers/bluetooth/btmrvl_sdio.c +++ b/drivers/blueto

Re: [PATCH] Input: uinput - handle compat ioctl for UI_SET_PHYS

2016-05-20 Thread Ricky Liang
Hi Dmitry, On Sat, May 21, 2016 at 12:32 AM, Dmitry Torokhov wrote: > Hi Ricky, > > On Tue, May 17, 2016 at 11:39:45PM +0800, Ricky Liang wrote: >> When running a 32-bit userspace on a 64-bit kernel, the UI_SET_PHYS >> ioctl needs to be treated with special care, as it ha

[PATCH v2] Input: uinput - handle compat ioctl for UI_SET_PHYS

2016-05-20 Thread Ricky Liang
When running a 32-bit userspace on a 64-bit kernel, the UI_SET_PHYS ioctl needs to be treated with special care, as it has the pointer size encoded in the command. Signed-off-by: Ricky Liang --- drivers/input/misc/uinput.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/input

[PATCH] Input: uinput - handle compat ioctl for UI_SET_PHYS

2016-05-17 Thread Ricky Liang
When running a 32-bit userspace on a 64-bit kernel, the UI_SET_PHYS ioctl needs to be treated with special care, as it has the pointer size encoded in the command. Signed-off-by: Ricky Liang --- drivers/input/misc/uinput.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers

Re: [PATCH] thermal: fix thermal_power_allocator trace event

2016-03-29 Thread Ricky Liang
Please ignore this patch. I found out that I missed out the patch that changed the second parameter of __print_array() to number of elements. On Tue, Mar 29, 2016 at 1:08 PM, Ricky Liang wrote: > Fix the dynamic array length in printing the thermal_power_allocator > trace event. > &

[PATCH] thermal: fix thermal_power_allocator trace event

2016-03-28 Thread Ricky Liang
Fix the dynamic array length in printing the thermal_power_allocator trace event. CC: Javi Merino CC: Daniel Kurtz Signed-off-by: Ricky Liang --- include/trace/events/thermal_power_allocator.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/trace/events

Re: [RFCv7 PATCH 04/10] sched/fair: add triggers for OPP change requests

2016-02-29 Thread Ricky Liang
Hi Steve, On Tue, Feb 23, 2016 at 9:22 AM, Steve Muckle wrote: > From: Juri Lelli > > Each time a task is {en,de}queued we might need to adapt the current > frequency to the new usage. Add triggers on {en,de}queue_task_fair() for > this purpose. Only trigger a freq request if we are effectively

Re: [RFCv6 PATCH 03/10] sched: scheduler-driven cpu frequency selection

2016-02-01 Thread Ricky Liang
Hi Steve, On Wed, Dec 9, 2015 at 2:19 PM, Steve Muckle wrote: [snip...] > +static int cpufreq_sched_policy_init(struct cpufreq_policy *policy) > +{ > + struct gov_data *gd; > + int cpu; > + > + for_each_cpu(cpu, policy->cpus) > + memset(&per_cpu(cpu_sched_capacit

Re: [RFCv6 PATCH 03/10] sched: scheduler-driven cpu frequency selection

2016-01-25 Thread Ricky Liang
Hi Steve, On Wed, Dec 9, 2015 at 2:19 PM, Steve Muckle wrote: [...] > +/* > + * we pass in struct cpufreq_policy. This is safe because changing out the > + * policy requires a call to __cpufreq_governor(policy, CPUFREQ_GOV_STOP), > + * which tears down all of the data structures and __cpufreq_g

Re: [RFC 08/14] sched/tune: add detailed documentation

2015-09-04 Thread Ricky Liang
Hi Patrick, Please find my replies inline. On Thu, Sep 3, 2015 at 5:18 PM, Patrick Bellasi wrote: > On Wed, Sep 02, 2015 at 07:49:58AM +0100, Ricky Liang wrote: >> Hi Patrick, > > Hi Ricky, > >> I wonder if this can replace the boost function in the interactive >>

Re: [RFC,08/14] sched/tune: add detailed documentation

2015-09-01 Thread Ricky Liang
Hi Patrick, I wonder if this can replace the boost function in the interactive governor [0], which is widely used in both Android and ChromeOS kernels. My understanding is that the boost in interactive governor is to simply raise the OPP on selected cores. The SchedTune boost works by adding a ma

Re: [PATCH v3 3/5] usb: phy: add usb3.0 phy driver for mt65xx SoCs

2015-07-27 Thread Ricky Liang
Hi Chungfeng, Comments inline. On Wed, Jul 22, 2015 at 10:05 PM, Chunfeng Yun wrote: > support usb3.0 phy of mt65xx SoCs > > Signed-off-by: Chunfeng Yun > --- > drivers/phy/Kconfig | 9 + > drivers/phy/Makefile | 1 + > drivers/phy/phy-mt65xx-usb3.c | 426 >

[PATCH v3] clk: mediatek: Initialize clk_init_data

2015-05-18 Thread Ricky Liang
The variable init (struct clk_init_data) is allocated on the stack. We weren't initializing the .flags field, so it contains random junk, which can cause all kinds of interesting issues when the flags are parsed by clk_register. Signed-off-by: Ricky Liang --- drivers/clk/mediatek/clk-gate.

Re: [PATCH v2] clk: mediatek: Initialize clk_init_data

2015-05-18 Thread Ricky Liang
Hi Sascha, Sure. I can fix clk-gate.c as well. New patch on the way... -Ricky On Mon, May 18, 2015 at 1:54 PM, Sascha Hauer wrote: > Hi Ricky, > > On Mon, May 18, 2015 at 11:41:49AM +0800, Ricky Liang wrote: >> The variable init (struct clk_init_data) is allocated on the stack

[PATCH v2] clk: mediatek: Initialize clk_init_data

2015-05-17 Thread Ricky Liang
The variable init (struct clk_init_data) is allocated on the stack. We weren't initializing the .flags field, so it contains random junk, which can cause all kinds of interesting issues when the flags are parsed by clk_register. Signed-off-by: Ricky Liang --- drivers/clk/mediatek/clk-pll.

[PATCH] clk: mediatek: Initialize clk flags

2015-05-14 Thread Ricky Liang
o our clk_register wrappers. Signed-off-by: Ricky Liang --- drivers/clk/mediatek/clk-pll.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/mediatek/clk-pll.c b/drivers/clk/mediatek/clk-pll.c index 66154ca..72fe307 100644 --- a/drivers/clk/mediatek/clk-pll.c +++ b/drivers/clk/mediate

Re: [PATCH v2] clk: mediatek: Export CPU mux clocks for CPU frequency control

2015-05-14 Thread Ricky Liang
On Mon, Apr 20, 2015 at 5:25 PM, pi-cheng.chen wrote: > This patch adds CPU mux clocks which are used by Mediatek cpufreq driver for > intermediate clock source switching. It is based on v11 of common clock > support > for Mediatek MT8135 and MT8173[1] > > [1] > http://lists.infradead.org/piperm

[PATCH] of/fdt: fix allocation size for device node path

2015-04-13 Thread Ricky Liang
The allocation size of device node path is off by one which drops the '\0' terminator. Signed-off-by: Ricky Liang --- drivers/of/fdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c index 3a896c9..98a9e6e 100644 --- a/driver