Re: [PATCH] hwmon: (pmbus/lm25066) Default coefficients for low current limit

On Mon, Nov 27, 2017 at 8:26 PM, Guenter Roeck wrote: > On 11/27/2017 04:28 PM, Robert Lippert wrote: >> >> There seems to be no way to detect the value of the CL/GAIN pin >> from the device using PMBus. >> >> Low current mode seems to be recommended (from LM5066 datasheet)

Re: [PATCH] hwmon: (pmbus/lm25066) Default coefficients for low current limit

On Mon, Nov 27, 2017 at 8:26 PM, Guenter Roeck wrote: > On 11/27/2017 04:28 PM, Robert Lippert wrote: >> >> There seems to be no way to detect the value of the CL/GAIN pin >> from the device using PMBus. >> >> Low current mode seems to be recommended (from LM5066 datasheet) for >> improved

Re: [PATCH] hwmon: (pmbus/lm25066) Swap low/high current coefficients for LM5066(i)

On Mon, Nov 27, 2017 at 2:08 PM, Guenter Roeck <li...@roeck-us.net> wrote: > On Mon, Nov 27, 2017 at 01:51:35PM -0800, Rob Lippert wrote: >> On Wed, Nov 22, 2017 at 5:17 PM, Guenter Roeck <li...@roeck-us.net> wrote: >> > Hi Rob, >> > >>

Re: [PATCH] hwmon: (pmbus/lm25066) Swap low/high current coefficients for LM5066(i)

On Mon, Nov 27, 2017 at 2:08 PM, Guenter Roeck wrote: > On Mon, Nov 27, 2017 at 01:51:35PM -0800, Rob Lippert wrote: >> On Wed, Nov 22, 2017 at 5:17 PM, Guenter Roeck wrote: >> > Hi Rob, >> > >> > On 11/22/2017 03:39 PM, Rob Lippert wrote: >> >>

Re: [PATCH v2] hwmon: (pmbus) Use 64bit math for DIRECT format values

On Mon, Nov 27, 2017 at 2:11 PM, Guenter Roeck wrote: > On Mon, Nov 27, 2017 at 01:39:14PM -0800, Robert Lippert wrote: >> Power values in the 100s of watt range can easily blow past >> 32bit math limits when processing everything in microwatts. >> >> Use 64bit math instead to

Re: [PATCH v2] hwmon: (pmbus) Use 64bit math for DIRECT format values

On Mon, Nov 27, 2017 at 2:11 PM, Guenter Roeck wrote: > On Mon, Nov 27, 2017 at 01:39:14PM -0800, Robert Lippert wrote: >> Power values in the 100s of watt range can easily blow past >> 32bit math limits when processing everything in microwatts. >> >> Use 64bit math instead to avoid these issues

Re: [PATCH] hwmon: (pmbus/lm25066) Swap low/high current coefficients for LM5066(i)

On Wed, Nov 22, 2017 at 5:17 PM, Guenter Roeck <li...@roeck-us.net> wrote: > Hi Rob, > > On 11/22/2017 03:39 PM, Rob Lippert wrote: >> >> On Wed, Nov 22, 2017 at 3:28 PM, Guenter Roeck <li...@roeck-us.net> wrote: >>> >>> >>> On

Re: [PATCH] hwmon: (pmbus/lm25066) Swap low/high current coefficients for LM5066(i)

On Wed, Nov 22, 2017 at 5:17 PM, Guenter Roeck wrote: > Hi Rob, > > On 11/22/2017 03:39 PM, Rob Lippert wrote: >> >> On Wed, Nov 22, 2017 at 3:28 PM, Guenter Roeck wrote: >>> >>> >>> On Wed, Nov 22, 2017 at 02:07:28PM -0800, Robert Lippert wrot

Re: [PATCH] hwmon: (pmbus) Use 64bit math for DIRECT format values

On Wed, Nov 22, 2017 at 2:28 PM, Guenter Roeck wrote: > On Wed, Nov 22, 2017 at 02:08:43PM -0800, Robert Lippert wrote: >> Power values in the 100s of watt range can easily blow past >> 32bit math limits when processing everything in microwatts. >> >> Use 64bit math instead to

Re: [PATCH] hwmon: (pmbus) Use 64bit math for DIRECT format values

On Wed, Nov 22, 2017 at 2:28 PM, Guenter Roeck wrote: > On Wed, Nov 22, 2017 at 02:08:43PM -0800, Robert Lippert wrote: >> Power values in the 100s of watt range can easily blow past >> 32bit math limits when processing everything in microwatts. >> >> Use 64bit math instead to avoid these issues

Re: [PATCH] hwmon: (pmbus/lm25066) Swap low/high current coefficients for LM5066(i)

On Wed, Nov 22, 2017 at 3:28 PM, Guenter Roeck wrote: > > On Wed, Nov 22, 2017 at 02:07:28PM -0800, Robert Lippert wrote: > > The _L low-current mode coefficient values should reference the > > datasheet rows with CL=VDD but it seems were mistakenly pulled from > > the rows

Re: [PATCH] hwmon: (pmbus/lm25066) Swap low/high current coefficients for LM5066(i)

On Wed, Nov 22, 2017 at 3:28 PM, Guenter Roeck wrote: > > On Wed, Nov 22, 2017 at 02:07:28PM -0800, Robert Lippert wrote: > > The _L low-current mode coefficient values should reference the > > datasheet rows with CL=VDD but it seems were mistakenly pulled from > > the rows with CL=GND. > > > >

Re: [PATCH linux dev-4.10] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

On Wed, Jul 5, 2017 at 10:48 AM, Patrick Venture <vent...@google.com> wrote: > On Wed, Jul 5, 2017 at 10:33 AM, Rob Lippert <rob...@gmail.com> wrote: >> I checked the datasheets when I wrote this and ast2400 does not have >> the (undocumented) HICRB register bits

Re: [PATCH linux dev-4.10] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

On Wed, Jul 5, 2017 at 10:48 AM, Patrick Venture wrote: > On Wed, Jul 5, 2017 at 10:33 AM, Rob Lippert wrote: >> I checked the datasheets when I wrote this and ast2400 does not have >> the (undocumented) HICRB register bits 14,15 that enables the BMC to >> actually re

Re: [PATCH linux dev-4.10] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

I checked the datasheets when I wrote this and ast2400 does not have the (undocumented) HICRB register bits 14,15 that enables the BMC to actually respond to the snoop'ed address. Without setting that bit in the ast2500 the transactions to that I/O port would timeout on the host side (although

Re: [PATCH linux dev-4.10] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

I checked the datasheets when I wrote this and ast2400 does not have the (undocumented) HICRB register bits 14,15 that enables the BMC to actually respond to the snoop'ed address. Without setting that bit in the ast2500 the transactions to that I/O port would timeout on the host side (although