Hey Neil,
Thanks for the quick respin.
Reviewed-by: Robert Foss
On Mon, 19 Apr 2021 at 09:12, Neil Armstrong wrote:
>
> From: Phong LE
>
> This commit is a simple driver for bridge HMDI it66121.
> The input format is RBG and there is no color conversion.
> A
: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic
to detect MHL")
Signed-off-by: Robert Foss
Reported-by: kernel test robot
---
LKP reported issue:
https://lore.kernel.org/lkml/202104040604.sste2cxf-...@intel.com/
Changes since v1:
- Fix typo on comment
Changes since v2
Merged for 5.13 in drm-misc-next-fixes
On Fri, 16 Apr 2021 at 10:41, Robert Foss wrote:
>
> Thanks Randy!
>
> Reviewed-by: Robert Foss
>
> On Thu, 15 Apr 2021 at 20:36, Randy Dunlap wrote:
> >
> > The Analogix DRM ANX7625 bridge driver uses mips_dsi_() functi
fe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge")
> > Fixes: 0cbbd5b1a012 ("drm: bridge: add support for lontium LT9611UXC
> > bridge")
> > Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge")
> > Signed-off-by: R
Thanks Randy!
Reviewed-by: Robert Foss
On Thu, 15 Apr 2021 at 20:36, Randy Dunlap wrote:
>
> The Analogix DRM ANX7625 bridge driver uses mips_dsi_() function
> interfaces so it should select DRM_MIPI_DSI to prevent build errors.
>
>
> ERROR: modpost: "mipi_dsi_atta
On Wed, 14 Apr 2021 at 08:13, Neil Armstrong wrote:
>
> Hi Rob,
>
> Le 13/04/2021 à 22:21, Robert Foss a écrit :
> > Hey Neil & Phong,
> >
> > Thanks for submitting this series!
> >
> >> +
> >> +static const struct drm_
Hey Neil & Phong,
Thanks for submitting this series!
> +
> +static const struct drm_bridge_funcs it66121_bridge_funcs = {
> + .attach = it66121_bridge_attach,
> + .enable = it66121_bridge_enable,
> + .disable = it66121_bridge_disable,
> + .mode_set =
NERS:9537:
+F: drivers/gpu/drm/bridge/ite-it66121.c
+T:git git://anongit.freedesktop.org/drm/drm-misc
With this warning silenced, feel free to add my r-b.
Reviewed-by: Robert Foss
> > +F: Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml
> > +
> > IVTV VIDEO4LINUX DRIVER
> > M: Andy Walls
> > L: linux-me...@vger.kernel.org
> >
>
Hey Randy,
Thanks for looking at this!
On Fri, 9 Apr 2021 at 18:38, Randy Dunlap wrote:
>
> On 4/8/21 6:07 AM, Robert Foss wrote:
> > The DRM_SIL_SII8620 kconfig has a weak `imply` dependency
> > on EXTCON, which causes issues when sii8620 is built
> > as a bui
Merged series.
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=6a3608eae6d33a478a29348eb5e9ca330a528ae6
On Sat, 10 Apr 2021 at 20:14, Parshuram Thombare wrote:
>
> This patch series enables HDCP in Cadence MHDP DPI/DP bridge driver.
>
> Changes since v1:
> - Move sapb reg block right after
r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[1]);
> ispif->base_clk_mux = devm_ioremap_resource(dev, r);
> - if (IS_ERR(ispif->base_clk_mux)) {
> - dev_err(dev, "could not map memory\n");
> + if (IS_ERR(ispif->base_clk_mux))
> return PTR_ERR(ispif->base_clk_mux);
> - }
>
> /* Interrupt */
>
Reviewed-by: Robert Foss
x->i2c.tx_p2_client, 0x08, 0x7f);
>
> ret |= anx7625_video_mute_control(ctx, 1);
> +
> + DRM_DEV_DEBUG_DRIVER(dev, "notify downstream enter into standby\n");
> +
> + /* Downstream monitor enter into standby mode */
> + data = 2;
> + ret |= anx7625_aux_dpcd_write(ctx, 0x00, 0x06, 0x00, 1, );
> if (ret < 0)
> DRM_DEV_ERROR(dev, "IO error : mute video fail\n");
> +
> + return;
> }
Reviewed-by: Robert Foss
-by: Robert Foss
Reported-by: kernel test robot
---
Changes since v1:
- Fix typo on comment
drivers/gpu/drm/bridge/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 22a467abd3e9..2289b44613af 100644
1: error: ‘GPIOD_OUT_HIGH’
> undeclared (first use in this function); did you mean ‘GPIOF_INIT_HIGH’?
> gp_reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
>^~
>
bridge/lontium-lt8912b.c
> index 61491615bad0..79845b3b19e1 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt8912b.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt8912b.c
> @@ -3,6 +3,7 @@
> * Copyright (c) 2018, The Linux Foundation. All rights reserved.
> */
>
> +#inc
Hey Zhang,
On Thu, 8 Apr 2021 at 09:10, zhangjianhua (E) wrote:
>
> Hello Robert
>
> I am sorry that I make a mistake about the compiling error of lt8912b,
>
> the reason is that lt8912b miss the header file .
>
> Although there are many files reference gpiod_set_value_cansleep() and
>
>
> Yes, you are right, there are many files reference
> gpiod_set_value_cansleep() and
>
> devm_gpiod_get_optional(). How about add config dependencies for all
> releated
I think this is the way to go and roughly half of the drm bridge
drivers seem to need this change.
Do you mind submitting a
Hey Zhang
On Tue, 6 Apr 2021 at 11:07, Zhang Jianhua wrote:
>
> If CONFIG_DRM_LONTIUM_LT8912B=y, the following errors will be seen while
> compiling lontium-lt8912b.c
>
> drivers/gpu/drm/bridge/lontium-lt8912b.c: In function
> ‘lt8912_hard_power_on’:
>
Reviewed-by: Robert Foss
On Tue, 30 Mar 2021 at 14:28, Robert Foss wrote:
>
> Hey Dafna,
>
> Thanks for submitting a cleanup patch, it is much appreciated. It
> looks good to me, feel free to add my r-b.
>
> I'm not going to merge this right away, but will let this pat
-by: Robert Foss
Reported-by: kernel test robot
---
LKP reported issue:
https://lore.kernel.org/lkml/202104040604.sste2cxf-...@intel.com/
drivers/gpu/drm/bridge/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
Hi Yang,
Thanks for the fix.
Reviewed-by: Robert Foss
On Fri, 2 Apr 2021 at 11:29, Yang Yingliang wrote:
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot
>
Hey Yang,
Thanks for the patch, feel free to add my r-b.
Reviewed-by: Robert Foss
On Thu, 1 Apr 2021 at 12:33, Yang Yingliang wrote:
>
> There is an error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Repor
Hey Xin,
This patch looks good to me, feel free to add my r-b.
Reviewed-by: Robert Foss
On Fri, 19 Mar 2021 at 07:34, Xin Ji wrote:
>
> Add MIPI rx DPI input support.
>
> Reported-by: kernel test robot
> Signed-off-by: Xin Ji
> ---
> drivers/gpu/drm/bridge/ana
Hey Julian,
Nice catch, this patch looks good to me. I've pushed it to drm-misc-next.
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=62066d3164467167fc27b2383f67d097e39bf176
On Mon, 22 Feb 2021 at 22:56, Julian Braha wrote:
>
> When DRM_TOSHIBA_TC358762 is enabled and DRM_KMS_HELPER is
Hey Xin,
This patch looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Mar 2021 at 07:35, Xin Ji wrote:
>
> Add audio HDMI codec function support, enable it through device true flag
> "analogix,audio-enable".
>
> Reported-by: kernel test robot
> Signed-off-by:
Hey Xin,
This series no longer applies to drm-misc/drm-misc-next, please rebase it.
On Wed, 24 Mar 2021 at 08:52, Xin Ji wrote:
>
> On Sun, Mar 21, 2021 at 02:00:38PM +0200, Laurent Pinchart wrote:
> > Hi Xin,
> >
> > Thank you for the patch.
> >
> > On Fri, Mar 19, 2021 at 02:32:39PM +0800,
RNG (Random Number Generator) in SM8350 features PRNG EE (Execution
Environment), hence add devicetree support for it.
Signed-off-by: Robert Foss
---
arch/arm64/boot/dts/qcom/sm8350.dtsi | 7 +++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi
b/arch
Hsin-Yi Wang
> Reviewed-by: Rob Herring
> Reviewed-by: Robert Foss
> ---
> v3->v4: rebase to drm-misc/for-linux-next
> ---
> .../bindings/display/bridge/analogix,anx7625.yaml | 15 +++
> 1 file changed, 15 insertions(+)
>
> diff --git
> a/Documentation/device
Hey Andy,
This patch looks good to me.
Reviewed-by: Robert Foss
On Wed, 31 Mar 2021 at 12:46, Andy Shevchenko
wrote:
>
> Since we have generic definitions for bus frequencies, let's use them.
>
> Cc: Wolfram Sang
> Signed-off-by: Andy Shevchenko
> Acked-by: Khalil Blaiech
On Wed, 31 Mar 2021 at 08:41, Liu Ying wrote:
>
> Hi Robert,
>
> On Tue, 2021-03-30 at 12:05 +0200, Robert Foss wrote:
> > Hey Liu,
> >
> > checkpatch --strict lists some nits for this patch with those and the
> > below warning fixed, feel free to ad
Hey Dafna,
Thanks for submitting a cleanup patch, it is much appreciated. It
looks good to me, feel free to add my r-b.
I'm not going to merge this right away, but will let this patch soak
for a while to let other people have a look at it.
On Tue, 30 Mar 2021 at 13:52, Dafna Hirschfeld
wrote:
Hey Lyude,
This patch looks good, but I have one question below. With it
addressed, feel free to add my r-b.
Reviewed-by: Robert Foss
>
> -static bool drm_dp_sideband_parse_req(struct drm_dp_sideband_msg_rx *raw,
> +static bool drm_dp_sideband_parse_req(const struct drm_dp_mst_top
Hey Lyude,
This patch looks good to me.
Reviewed-by: Robert Foss
On Fri, 26 Mar 2021 at 21:40, Lyude Paul wrote:
>
> Checkpatch was complaining about this - there's no need for us to print
> errors when kzalloc() fails, as kzalloc() will already WARN for us. So,
> let's fix
Hey Lyude,
Looks good to me.
Reviewed-by: Robert Foss
On Fri, 26 Mar 2021 at 21:40, Lyude Paul wrote:
>
> Now that we've added a back-pointer to drm_device to drm_dp_aux, made
> drm_dp_aux available to any functions in drm_dp_helper.c which need to
> print to the kernel log, and
Hey Lyude,
I'm seeing no issues with this patch and the reasoning behind the
patch is sound to me.
Reviewed-by: Robert Foss
On Fri, 26 Mar 2021 at 21:39, Lyude Paul wrote:
>
> Since we're about to move drm_dp_helper.c over to drm_dbg_*(), we'll want
> to make sure that we can
Hey Liu,
checkpatch --strict lists some nits for this patch with those and the
below warning fixed, feel free to add my r-b.
On Wed, 17 Mar 2021 at 04:57, Liu Ying wrote:
>
> This patch adds a drm bridge driver for i.MX8qm LVDS display bridge(LDB)
> which is officially named as pixel mapper.
Hey Liu,
checkpatch --strict lists some nits and a warning. I think the kconfig
warning can be ignored. With the rest fixed, feel free to add my r-b.
Reviewed-by: Robert Foss
On Wed, 17 Mar 2021 at 04:57, Liu Ying wrote:
>
> This patch adds a drm bridge driver for i.MX8qxp LVDS display
Hey Liu,
checkpatch --strict lists some nit and a warning. With those fixed
feel free to add my r-b.
On Wed, 17 Mar 2021 at 04:57, Liu Ying wrote:
>
> This patch adds a drm bridge driver for i.MX8qxp LVDS display bridge(LDB)
> which is officially named as pixel mapper. The LDB has two
Hey Liu,
Reviewed-by: Robert Foss
On Wed, 17 Mar 2021 at 04:57, Liu Ying wrote:
>
> Add myself as the maintainer of DRM bridge drivers for i.MX SoCs.
>
> Signed-off-by: Liu Ying
> ---
> v5->v6:
> * No change.
>
> v4->v5:
> * No change.
>
> v3->
Hey Liu,
checkpatch --strict is listing some nits for this patch, with those
fixed feel free to add my r-b.
Reviewed-by: Robert Foss
On Wed, 17 Mar 2021 at 04:57, Liu Ying wrote:
>
> This patch adds a helper to support LDB drm bridge drivers for
> i.MX SoCs. Helper functions
Hey Liu,
checkpatch --strict had some complaints, with those fixed feel free to
add my r-b.
Reviewed-by: Robert Foss
On Wed, 17 Mar 2021 at 04:57, Liu Ying wrote:
>
> This patch adds a drm bridge driver for i.MX8qxp pixel link to display
> pixel interface(PXL2DPI). The PXL2DPI i
Pushed:
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=3aa6031deefa9a2c056af2182af02d3dc5df1067
On Fri, 26 Mar 2021 at 13:20, Adrien Grassein wrote:
>
> Hi,
> this patch set adds the support of the Lontium lt8912 MIPI to HDMI
> bridge in the kernel.
>
> It's only support the video part,
signal input and
> produces RGB565, RGB666, RGB888 output format.
>
> Add dt-bingings for it.
>
> Signed-off-by: Jagan Teki
> Reviewed-by: Robert Foss
> Reviewed-by: Rob Herring
> ---
> Changes for v5:
> - rebase drm-misc-next
> - collect Rob, Robert review tags
Pushed to drm-misc-next
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=fffa69aa6b1c89853cd00dea969e4754633596d7
On Sun, 7 Feb 2021 at 10:12, Jiapeng Chong
wrote:
>
> Fix the following coccicheck warning:
>
> drivers/gpu/drm/bridge/lontium-lt9611uxc.c:858:8-16: WARNING: use
> scnprintf or
-off-by: Robert Foss
Acked-by: Neil Armstrong
Acked-by: Maxime Ripard
Acked-by: Laurent Pinchart
Acked-by: Andrzej Hajda
---
Add maintainer Acks.
Submitted to follow proper dim workflow.
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index
sm8350 has 29 thermal sensors split across two tsens controllers. Add
the thermal zones to expose them and wireup the cpus to throttle their
frequencies on crossing passive temperature thresholds.
Signed-off-by: Robert Foss
Reviewed-by: Vinod Koul
---
Changes since v1:
- Vinod: Remove comment
Add tsens bindings for sm8350.
Signed-off-by: Robert Foss
Reviewed-by: Vinod Koul
---
Changes since v1:
- Vinod: Remove comment
Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/thermal/qcom
-off-by: Robert Foss
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4b705ba51c54..16ace8f58649 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5902,6 +5902,7 @@ F:drivers/gpu/drm/atmel-hlcdc/
DRM DRIVERS FOR BRIDGE CHIPS
M: Andrzej
sm8350 has 29 thermal sensors split across two tsens controllers. Add
the thermal zones to expose them and wireup the cpus to throttle their
frequencies on crossing passive temperature thresholds.
Signed-off-by: Robert Foss
Reviewed-by: Vinod Koul
---
Changes since v1:
- Vinod: Remove comment
Add tsens bindings for sm8350.
Signed-off-by: Robert Foss
Reviewed-by: Vinod Koul
---
Changes since v2:
- Vinod: Add r-b
Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
b
Alright, I think the best way forward is to remove the polled HPD support.
Don't forget to update flags and function pointers.
With that, feel free to add my r-b.
Reviewed-by: Robert Foss
> > Are you saying that pin 63 never is high, or that an irq/isr routine
> > isn't getting executed?
> >
> > > When reading the value of the HPD pin, I always get 1 (and no
> > > transition occurs when plugging / unplugging a cable).
> > > The HPD IRQ is done on the HDMI connector driver [5].
> >
> > > >
> > > > > +static enum drm_connector_status lt8912_check_cable_status(struct
> > > > > lt8912 *lt)
> > > > > +{
> > > > > + int ret;
> > > > > + unsigned int reg_val;
> > > > > +
> > > > > + ret = regmap_read(lt->regmap[I2C_MAIN], 0xC1, _val);
> > > > > + if (ret)
On Tue, 23 Mar 2021 at 11:01, Adrien Grassein wrote:
>
> Hey Robert,
>
> Thanks for the update.
>
> Le mar. 23 mars 2021 à 10:10, Robert Foss a écrit :
> >
> > Hey Adrien,
> >
> > Sorry about the slow reply, but I just received the documentation from
Hey Adrien,
Sorry about the slow reply, but I just received the documentation from
the vendor. So let's dig in to the HPD issue.
> +static enum drm_connector_status lt8912_check_cable_status(struct lt8912 *lt)
> +{
> + int ret;
> + unsigned int reg_val;
> +
> + ret =
Hey Konrad,
Thanks for the review!
On Mon, 22 Mar 2021 at 18:27, Konrad Dybcio
wrote:
>
> Hi!
>
>
> > + tsens0: thermal-sensor@c222000 {
> > + compatible = "qcom,sm8350-tsens", "qcom,tsens-v2";
> > + reg = <0 0x0C263000 0 0x1ff>, /* TM */
> >
sm8350 has 29 thermal sensors split across two tsens controllers. Add
the thermal zones to expose them and wireup the cpus to throttle their
frequencies on crossing passive temperature thresholds.
Signed-off-by: Robert Foss
---
Changes since v1:
- Vinod: Remove comment
arch/arm64/boot/dts
Add tsens bindings for sm8350.
Signed-off-by: Robert Foss
---
Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
Hey Xin,
This patch looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Mar 2021 at 07:33, Xin Ji wrote:
>
> At some time, the original code may return non zero value, force return 0
> if operation finished.
>
> Signed-off-by: Xin Ji
> ---
> drivers/gpu/drm/bridge/a
Hey Sia,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 12 Mar 2021 at 10:09, Sia Jee Heng wrote:
>
> Support IEC958 encoded PCM format for ADV7511 so that ADV7511 HDMI
> audio driver can accept the IEC958 data from the I2S input.
>
> Signed-off-b
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:58, Lyude Paul wrote:
>
> Just another drive-by fix I noticed while going through the tree to cleanup
> DP aux adapter registration - make sure we unregister the D
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:58, Lyude Paul wrote:
>
> Another drive-by fix I found when fixing DP AUX adapter across the kernel
> tree - make sure we don't leak resources (and by proxy-AUX adapters) on
&
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:58, Lyude Paul wrote:
>
> Another case of linking an encoder to a connector after the connector's
> been registered. The proper place to do this is before connector
> regi
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:58, Lyude Paul wrote:
>
> Another driver I found that seems to forget to unregister it's DP AUX
> device. Let's fix this by adding anx6345_bridge_detach().
>
> Signed-off
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote:
>
> Just another issue I noticed while correcting usages of
> drm_dp_aux_init()/drm_dp_aux_register() around the tree. If any of the
> steps in anx78xx_b
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote:
>
> Since encoder mappings for connectors are exposed to userspace, we should
> be attaching the encoder before exposing the connector to userspace. Just
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote:
>
> Surprisingly, this bridge actually registers it's AUX adapter at the
> correct time already. Nice job! However, it does forget to actually
> unregi
Hey Lyude,
This patch looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote:
>
> Since this is a bridge, we don't start out with a respective DRM device.
> Likewise this means we don't have a connector, which also means that we
> should
Hey Lyude,
Thanks for the patch
On Fri, 19 Feb 2021 at 23:03, Lyude Paul wrote:
>
> And finally, convert all of the code in drm_dp_mst_topology.c over to using
> drm_err() and drm_dbg*(). Note that this refactor would have been a lot
> more complicated to have tried writing a coccinelle script
Hey Lyude,
Thanks for the patch.
On Fri, 19 Feb 2021 at 23:03, Lyude Paul wrote:
>
> Now that we've added a back-pointer to drm_device to drm_dp_aux, made
> drm_dp_aux available to any functions in drm_dp_helper.c which need to
> print to the kernel log, and ensured all of our logging uses a
Hey Lyude,
Thanks for the patch.
On Fri, 19 Feb 2021 at 23:03, Lyude Paul wrote:
>
> Since this is one of the few functions in drm_dp_mst_topology.c that
> doesn't have any way of getting access to a drm_device, let's pass the
> drm_dp_mst_topology_mgr down to this function so that it can use
>
Hey Lyude,
Thanks for the patch,
On Fri, 19 Feb 2021 at 22:59, Lyude Paul wrote:
>
> Since we're about to move drm_dp_helper.c over to drm_dbg_*(), we'll want
> to make sure that we can also add ratelimited versions of these macros in
> order to retain some of the previous debugging output
On Fri, 19 Mar 2021 at 11:49, Robert Foss wrote:
>
> sm8350 has 29 thermal sensors split across two tsens controllers. Add
> the thermal zones to expose them and wireup the cpus to throttle their
> frequencies on crossing passive temperature thresholds.
>
> Signed-o
sm8350 has 29 thermal sensors split across two tsens controllers. Add
the thermal zones to expose them and wireup the cpus to throttle their
frequencies on crossing passive temperature thresholds.
Signed-off-by: Robert Foss
---
arch/arm64/boot/dts/qcom/sm8350.dtsi | 829
Add tsens bindings for sm8350.
Signed-off-by: Robert Foss
---
Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
Enable support for SDM845 based Titan 170 ISPs.
Signed-off-by: Robert Foss
Reviewed-by: Andrey Konovalov
---
Changes since v5:
- Andrey: Add r-b
drivers/media/platform/qcom/camss/camss.c | 17 +
drivers/media/platform/qcom/camss/camss.h | 6 --
2 files changed, 21
the CSI decoder receives
from the sensor.
For example will a sensor outputting YUV pixel format frames, only
allow the VFE to dump those frames as they are received by the ISP
to memory through the RDI interface.
Signed-off-by: Robert Foss
Reviewed-by: Andrey Konovalov
---
Changes since v1
Add regulator to camss device tree node.
Signed-off-by: Robert Foss
Reviewed-by: Andrey Konovalov
---
Changes since v5:
- Andrey: Add r-b
arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
b/arch
Add bindings for qcom,msm8916-camss in order to support the camera
subsystem on MSM8916.
Signed-off-by: Robert Foss
Reviewed-by: Rob Herring
---
Changes since v2:
- Remove redundant descriptions
- Add power domain description
- Make clock-lanes a constant
- Add max & minItems to
Enable camss & ov8856 DT nodes.
Signed-off-by: Robert Foss
Reviewed-by: Andrey Konovalov
---
Changes since v5:
- Andrey: Add r-b
- Change CSI clock & data pins
arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 19 +--
1 file changed, 17 insertions(+), 2 deletions(
Add the camss dt node for sdm845.
Signed-off-by: Robert Foss
Reviewed-by: Andrey Konovalov
---
Changes since v1:
- Laurent: Fix subject
- Laurent: Remove redundant regulator labels
- Laurent: Remove empty line
Changes since v3:
- Fixed ordering of IRQs
- Add newlines for better
This documentation has been incorporated in dtschema dt-bindings
for the devices supported by CAMSS and is no longer helpful.
Signed-off-by: Robert Foss
Reviewed-by: Rob Herring
---
Changes since v4:
- Rob: Added r-b
.../devicetree/bindings/media/qcom,camss.txt | 236
Due to the complexity of describing multiple hardware generations
in one document, switch to using separate dt-bindings.
Signed-off-by: Robert Foss
Reviewed-by: Rob Herring
---
Changes since v4
- Rob: Added r-b
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Add bindings for qcom,sdm845-camss in order to support the camera
subsystem for SDM845.
Signed-off-by: Robert Foss
Reviewed-by: Rob Herring
---
Changes since v2:
- Rob: Removed extra empty lines at end of file
- Rob: Add new line at end of file
- Rob: Remove redundant descriptions
- Rob
Add bindings for qcom,sdm660-camss in order to support the camera
subsystem on SDM630/660 and SDA variants.
Signed-off-by: Robert Foss
Reviewed-by: Rob Herring
---
Changes since v2:
- Rob: Add new line at end of file
- Rob: Remove redundant descriptions
- Rob: Add power domain description
Add bindings for qcom,msm8996-camss in order to support the camera
subsystem on MSM8996.
Signed-off-by: Robert Foss
Reviewed-by: Rob Herring
---
Changes since v2
- Rob: Add new line at end of file
- Rob: Remove redundant descriptions
- Rob: Add power domain description
- Rob: Make clock
ific identifiers differ between hardware
generations, split them out into separate headers.
Signed-off-by: Robert Foss
Reviewed-by: Andrey Konovalov
---
Changes since v5
- Andrey: Gen 1 & Gen2 devices have different decode/encode/plain
format definitions, list in separate headers
Add register definitions for version 170 of the Titan architecture
and implement support for the CSIPHY subdevice.
Signed-off-by: Robert Foss
Reviewed-by: Andrey Konovalov
---
Changes since v3:
- Sakari: Make variable const
Changes since v4:
- kernel test robot: Fix warning related
, refactor
the power domain management into hardware version specific
code paths.
Signed-off-by: Robert Foss
Reviewed-by: Andrey Konovalov
---
Changes since v5:
- Andrey: Bifurcated PD support into Gen1 & Gen2 paths
Changes since v6:
- Andrey: Add r-b
- Improved commit msg
.../m
Add register definitions for version 170 of the Titan architecture
and implement support for the CSID subdevice.
Signed-off-by: Robert Foss
Reviewed-by: Andrey Konovalov
---
Changes since v5:
- Andrey: Fix test pattern selection logic
- Andrey: Add r-b
- Move Titan 170 specific test modes
In order to support Qualcomm ISP hardware architectures that diverge
from older architectures, the CSID subdevice drivers needs to be refactored
to better abstract the different ISP hardware architectures.
Signed-off-by: Robert Foss
Reviewed-by: Andrey Konovalov
---
Changes since v1
trace_printk() should not be used in production code,
since extra memory is used for special buffers whenever
trace_puts() is used.
Replace it with dev_dbg() which provides all of the desired
debugging functionality.
Signed-off-by: Robert Foss
Suggested-by: Nicolas Boichat
Reviewed-by: Nicolas
, will be referred to as Gen2.
Signed-off-by: Robert Foss
Reviewed-by: Andrey Konovalov
---
Changes since v1:
- kernel test robot: Re-add chunk missing from
vfe_output_update_pong_addr
- Andrey: Fix file name error
- Andrey: Change hardware version number in comment
- Changed copyright year
to support the Titan generation, make the
ISPIF an optional subdevice.
Signed-off-by: Robert Foss
Reviewed-by: Andrey Konovalov
---
Changes since v1:
- Björn: Improved commit message
- Björn: Use local 'dev' ptr instead of 'camss->dev'
- Björn: Remove res/ispif NULL checks
- Björn: Rem
Add enum representing the SDM845 SOC, which incorporates version
170 of the Titan architecture ISP.
Signed-off-by: Robert Foss
Reviewed-by: Andrey Konovalov
---
Changes since v5:
- Andrey: Add r-b
drivers/media/platform/qcom/camss/camss.h | 1 +
1 file changed, 1 insertion(+)
diff --git
Comment refers to ISPIF, but this is incorrect. Only
the VFE interrupts are handled by this function.
Signed-off-by: Robert Foss
Reviewed-by: Bjorn Andersson
---
Changes since v1:
- Bjorn: Add r-b
drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 2 +-
drivers/media/platform/qcom/camss
ss/linux.git/log/?h=camss_sdm845_v8
- https://git.linaro.org/people/robert.foss/linux.git/log/?h=camss_sdm845_v9
Robert Foss (22):
media: camss: Fix vfe_isr_comp_done() documentation
media: camss: Fix vfe_isr comment typo
media: camss: Replace trace_printk() with dev_dbg()
media: cams
Function name in comment is wrong, and was changed to be
the same as the actual function name.
The comment was changed to kerneldoc format.
Signed-off-by: Robert Foss
Reviewed-by: Andrey Konovalov
---
Changes since v1:
- Bjorn: Fix function doc name & use kerneldoc format
Changes sinc
Hey Hans,
Thanks for looking into this.
On Tue, 16 Mar 2021 at 10:36, Hans Verkuil wrote:
>
> On 15/03/2021 16:59, Robert Foss wrote:
> > In order to support Qualcomm ISP hardware architectures that diverge
> > from older architectures, the CSID subdevice drivers need
Hey Hans,
Thanks for having a look!
On Tue, 16 Mar 2021 at 10:41, Hans Verkuil wrote:
>
> On 15/03/2021 16:59, Robert Foss wrote:
> > In order to support Qualcomm ISP hardware architectures that diverge
> > from older architectures, the VFE subdevice driver needs to be refact
1 - 100 of 742 matches
Mail list logo
