On Fri, 19 Feb 2021 at 22:05, Nicolas Dufresne wrote:
>
> Hi Robert,
>
> not really a review, but I noticed
>
> Le mercredi 17 février 2021 à 12:21 +0100, Robert Foss a écrit :
> > Function name is comment is wrong, and was changed to be
>
> i
On Fri, 19 Feb 2021 at 16:01, Adrien Grassein wrote:
>
> Hey Robert,
>
> Le ven. 19 févr. 2021 à 14:27, Robert Foss a écrit :
> >
> > Hey Adrien,
> >
> >
> > Thanks for the quick update.
> No problem, I have some free time at the moment.
> >
Hey Adrien,
Thanks for the quick update.
On Thu, 18 Feb 2021 at 22:05, Adrien Grassein wrote:
>
> Lontium Lt8912 is a DSI to HDMI bridge.
>
> Signed-off-by: Adrien Grassein
> ---
> MAINTAINERS | 1 +
> drivers/gpu/drm/bridge/Kconfig | 14 +
>
On Thu, 18 Feb 2021 at 21:36, Adrien Grassein wrote:
>
> Hey Robert,
>
> Thank you for your time and for your review.
>
> Le mer. 17 févr. 2021 à 18:32, Robert Foss a écrit :
> >
> > Hey Adrien,
> >
> > Thanks for submitting this!
> >
> > On
Hey Adrien,
Thanks for submitting this!
On Mon, 15 Feb 2021 at 00:31, Adrien Grassein wrote:
>
> Lontium Lt8912 is a DSI to HDMI bridge.
>
> Signed-off-by: Adrien Grassein
> ---
> MAINTAINERS | 1 +
> drivers/gpu/drm/bridge/Kconfig | 14 +
>
This documentation has been incorporated in dtschema dt-bindings
for the devices supported by CAMSS and is no longer helpful.
Signed-off-by: Robert Foss
Reviewed-by: Rob Herring
---
.../devicetree/bindings/media/qcom,camss.txt | 236 --
1 file changed, 236 deletions(-)
delete
Due to the complexity of describing multiple hardware generations
in one document, switch to using separate dt-bindings.
Signed-off-by: Robert Foss
Reviewed-by: Rob Herring
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index
Enable camss & ov8856 DT nodes.
Signed-off-by: Robert Foss
---
Changes since v1
- Laurent: Fix subject
- Laurent: Remove redundant regulator labels
- Laurent: Remove empty line
Changes since v3
- Fixed ordering of IRQs
- Add newlines for better readability
arch/arm64/boot/dts/
Add regulator to camss device tree node.
Signed-off-by: Robert Foss
---
arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
index a943b3f353ce..5842ab65789c
Add the camss dt node for sdm845.
Signed-off-by: Robert Foss
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 135 +++
1 file changed, 135 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index bcf888381f14..4fe93c69908a
Add bindings for qcom,sdm845-camss in order to support the camera
subsystem for SDM845.
Signed-off-by: Robert Foss
Reviewed-by: Rob Herring
---
Changes since v2
- Rob: Removed extra empty lines at end of file
- Rob: Add new line at end of file
- Rob: Remove redundant descriptions
- Rob
Add bindings for qcom,msm8916-camss in order to support the camera
subsystem on MSM8916.
Signed-off-by: Robert Foss
Reviewed-by: Rob Herring
---
Changes since v2:
- Remove redundant descriptions
- Add power domain description
- Make clock-lanes a constant
- Add max & minItems to data-l
Add bindings for qcom,sdm660-camss in order to support the camera
subsystem on SDM630/660 and SDA variants.
Signed-off-by: Robert Foss
Reviewed-by: Rob Herring
---
Changes since v2
- Rob: Add new line at end of file
- Rob: Remove redundant descriptions
- Rob: Add power domain description
Add bindings for qcom,msm8996-camss in order to support the camera
subsystem on MSM8996.
Signed-off-by: Robert Foss
Reviewed-by: Rob Herring
---
Changes since v2
- Rob: Add new line at end of file
- Rob: Remove redundant descriptions
- Rob: Add power domain description
- Rob: Make clock
For Titan ISPs clocks fail to re-enable during vfe_get()
after any vfe has been halted and its corresponding power
domain power has been detached.
Since all of the clocks depend on all of the PDs, per
VFE PD detaching is no option for this generation of HW.
Signed-off-by: Robert Foss
Enable support for SDM845 based Titan 170 ISPs.
Signed-off-by: Robert Foss
---
drivers/media/platform/qcom/camss/camss.c | 17 +
drivers/media/platform/qcom/camss/camss.h | 6 --
2 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/qcom
Add register definitions for version 170 of the Titan architecture
and implement support for the CSIPHY subdevice.
Signed-off-by: Robert Foss
---
Changes since v3
- Sakari: Make variable const
Changes since v4
- kernel test robot: Fix warning related to const
.../qcom/camss/camss-csiphy
Add register definitions for version 170 of the Titan architecture
and implement support for the CSID subdevice.
Signed-off-by: Robert Foss
---
drivers/media/platform/qcom/camss/Makefile| 1 +
.../platform/qcom/camss/camss-csid-170.c | 602 ++
.../media/platform/qcom
In order to support Qualcomm ISP hardware architectures that diverge
from older architectures, the CSID subdevice drivers needs to be refactored
to better abstract the different ISP hardware architectures.
Signed-off-by: Robert Foss
---
Changes since v1
- kernel test robot: Add missing include
the CSI decoder receives
from the sensor.
For example will a sensor outputting YUV pixel format frames, only
allow the VFE to dump those frames as they are received by the ISP
to memory through the RDI interface.
Signed-off-by: Robert Foss
---
Changes since v1:
- Andrey: Remove commented out chunk
to support the Titan generation, make the
ISPIF an optional subdevice.
Signed-off-by: Robert Foss
---
Changes since v1:
- Björn: Improved commit message
- Björn: Use local 'dev' ptr instead of 'camss->dev'
- Björn: Remove res/ispif NULL checks
- Björn: Remove ispif NULL checks before call
Add enum representing the SDM845 SOC, which incorporates version
170 of the Titan architecture ISP.
Signed-off-by: Robert Foss
---
drivers/media/platform/qcom/camss/camss.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/qcom/camss/camss.h
b/drivers/media/platform
is the
appropriate one to use.
Signed-off-by: Robert Foss
---
.../media/platform/qcom/camss/camss-csid.h| 50 +++
1 file changed, 50 insertions(+)
diff --git a/drivers/media/platform/qcom/camss/camss-csid.h
b/drivers/media/platform/qcom/camss/camss-csid.h
index 1824b3745e10..02fc34ee8a41
, will be referred to as Gen2.
Signed-off-by: Robert Foss
---
Changes since v1
- kernel test robot: Re-add chunk missing from
vfe_output_update_pong_addr
- Andrey: Fix file name error
- Andrey: Change hardware version number in comment
- Changed copyright year to 2021 for camss-vfe-4-8.c
Changes
trace_printk() should not be used in production code,
since extra memory is used for special buffers whenever
trace_puts() is used.
Replace it with dev_dbg() which provides all of the desired
debugging functionality.
Signed-off-by: Robert Foss
Suggested-by: Nicolas Boichat
Reviewed-by: Nicolas
Comment refers to ISPIF, but this is incorrect. Only
the VFE interrupts are handled by this function.
Signed-off-by: Robert Foss
Reviewed-by: Bjorn Andersson
---
Changes since v1
- Bjorn: Add r-b
drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 2 +-
drivers/media/platform/qcom/camss
Function name is comment is wrong, and was changed to be
the same as the actual function name.
The comment was changed to kerneldoc format.
Signed-off-by: Robert Foss
---
Changes since v1
- Bjorn: Fix function doc name & use kerneldoc format
drivers/media/platform/qcom/camss/camss-v
ontrollers
https://patchwork.kernel.org/project/linux-arm-msm/list/?series=366077
Robert Foss (22):
media: camss: Fix vfe_isr_comp_done() documentation
media: camss: Fix vfe_isr comment typo
media: camss: Replace trace_printk() with dev_dbg()
media: camss: Add CAMSS_845 camss version
media: camss: Make
On Wed, 10 Feb 2021 at 21:14, Andrey Konovalov
wrote:
>
> Hi Robert,
>
> On 05.02.2021 13:43, Robert Foss wrote:
> > This series implements support for the camera subsystem found in
> > the SDM845 SOCs and the Titan 170 ISP. The support is partial
> > in t
X related interrupt status bits is correct (provided that
> the driver doesn't try to really process them, and just clears these bits if
> they happen to be set for some reason). But the rest should be removed.
>
> One more comment inline below.
>
> On 05.02.2021 13:43, Robert Foss
r-b.
Reviewed-by: Robert Foss
On Sun, 14 Feb 2021 at 18:55, Jagan Teki wrote:
>
> ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone.
WARNING: 'Convertor' may be misspelled - perhaps 'Converter'?
#6:
ICN6211 is MIPI-DSI to RGB Convertor bridge fro
Hey Jagan,
Thanks for submitting this.
checkpatch.pl threw some typ-o warnings, and I listed them below. I
think either spelling is correct, but 'spelling.txt' does list this as
a typ-o explicitly, so I would suggest conforming to that just to
silence the checkpatch warning.
This patch also
On Mon, 15 Feb 2021 at 12:27, Robert Foss wrote:
>
> Hey Andrey,
>
> Thanks for sending out this series and picking up Vladimirs patch.
>
> With the below issues fixed feel free to add my r-b.
> Reviewed-by: Robert Foss
Actually, make that an Acked-by.
Acked-by: Robert Foss
Hey Andrey,
Thanks for sending out this series and picking up Vladimirs patch.
With the below issues fixed feel free to add my r-b.
Reviewed-by: Robert Foss
On Sun, 14 Feb 2021 at 22:34, Andrey Konovalov
wrote:
>
> There are places in the camss driver where camss_get_pixel_clock() is
&g
Thanks Andrey!
On Thu, 11 Feb 2021 at 09:59, Andrey Konovalov
wrote:
>
> Hi Robert,
>
> Thank you for your patch!
>
> On 05.02.2021 13:44, Robert Foss wrote:
> > In order to support Qualcomm ISP hardware architectures that diverge
> > from older architectures, th
Hey Nicolas,
Thanks for submitting this, making these flags more intuitive is really nice.
This looks good to me, feel free to add my r-b.
Reviewed-by: Robert Foss
On Thu, 11 Feb 2021 at 04:34, Nicolas Boichat wrote:
>
> Many of the DSI flags have names opposite to their actual effects,
Hey Vladimir,
This patch looks good to me, thanks for the submission.
Acked-by: Robert Foss
On Wed, 10 Feb 2021 at 13:51, Vladimir Lypak wrote:
>
> Because of u32 type being used to store pixel clock rate, expression used
> to calculate pipeline clocks (pixel_clock * bpp) produces wr
Hey Andrey,
Thanks for starting this review!
On Tue, 9 Feb 2021 at 21:59, Andrey Konovalov
wrote:
>
> Hi Robert,
>
> Thank you for your patch!
>
> On 05.02.2021 13:43, Robert Foss wrote:
> > This driver supports multiple architecture versions of the Qualcomm ISP.
> &g
Hey Andrey,
On Mon, 8 Feb 2021 at 19:02, Andrey Konovalov
wrote:
>
> Hi Robert,
>
> Thank you for your patchset!
>
> On 05.02.2021 13:44, Robert Foss wrote:
> > Add register definitions for version 170 of the Titan architecture
> > and implement support for the CS
Hey Jiapeng,
Thanks for the patch. Feel free to add my r-b.
Reviewed-by: Robert Foss
On Sun, 7 Feb 2021 at 10:12, Jiapeng Chong
wrote:
>
> Fix the following coccicheck warning:
>
> drivers/gpu/drm/bridge/lontium-lt9611uxc.c:858:8-16: WARNING: use
> scnprintf or sprintf.
>
&g
trace_printk() should not be used in production code,
since extra memory is used for special buffers whenever
trace_puts() is used.
Replace it with dev_dbg() which provides all of the desired
debugging functionality.
Signed-off-by: Robert Foss
Suggested-by: Nicolas Boichat
---
Changes since
Function name is comment is wrong, and was changed to be
the same as the actual function name.
The comment was changed to kerneldoc format.
Signed-off-by: Robert Foss
---
Changes since v1
- Bjorn: Fix function doc name & use kerneldoc format
drivers/media/platform/qcom/camss/camss-v
to support the Titan generation, make the
ISPIF an optional subdevice.
Signed-off-by: Robert Foss
---
Changes since v1:
- Björn: Improved commit message
- Björn: Use local 'dev' ptr instead of 'camss->dev'
- Björn: Remove res/ispif NULL checks
- Björn: Remove ispif NULL checks before call
s series depends
the sdm660 clock driver being upstreamed. I've linked this series below.
SDM630/660 Multimedia and GPU clock controllers
https://lkml.org/lkml/2020/9/26/166
Robert Foss (22):
media: camss: Fix vfe_isr_comp_done() documentation
media: camss: Fix vfe_isr comment typo
media
Add register definitions for version 170 of the Titan architecture
and implement support for the CSID subdevice.
Signed-off-by: Robert Foss
---
Changes since v3
- Sakari: Make variable const
drivers/media/platform/qcom/camss/Makefile| 1 +
.../platform/qcom/camss/camss-csid-170.c
Add register definitions for version 170 of the Titan architecture
and implement support for the CSIPHY subdevice.
Signed-off-by: Robert Foss
---
.../qcom/camss/camss-csiphy-3ph-1-0.c | 182 --
.../media/platform/qcom/camss/camss-csiphy.c | 66 +--
drivers/media
Add bindings for qcom,sdm660-camss in order to support the camera
subsystem on SDM630/660 and SDA variants.
Signed-off-by: Robert Foss
Reviewed-by: Rob Herring
---
Changes since v2
- Rob: Add new line at end of file
- Rob: Remove redundant descriptions
- Rob: Add power domain description
Comment refers to ISPIF, but this is incorrect. Only
the VFE interrupts are handled by this function.
Signed-off-by: Robert Foss
Reviewed-by: Bjorn Andersson
---
Changes since v1
- Bjorn: Add r-b
drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 2 +-
drivers/media/platform/qcom/camss
the CSI decoder receives
from the sensor.
For example will a sensor outputting YUV pixel format frames, only
allow the VFE to dump those frames as they are received by the ISP
to memory through the RDI interface.
Signed-off-by: Robert Foss
---
Changes since v1:
- Andrey: Removed commented out chunk
Hey Xin,
On Thu, 28 Jan 2021 at 04:12, Xin Ji wrote:
>
> Add MIPI rx DPI input support
>
> Reported-by: kernel test robot
> Signed-off-by: Xin Ji
> ---
> drivers/gpu/drm/bridge/analogix/anx7625.c | 326
> --
> drivers/gpu/drm/bridge/analogix/anx7625.h | 20 +-
>
Add the camss dt node for sdm845.
Signed-off-by: Robert Foss
---
Changes since v1
- Laurent: Fix subject
- Laurent: Remove redundant regulator labels
- Laurent: Remove empty line
Changes since v3
- Fixed ordering of IRQs
- Add newlines for better readability
arch/arm64/boot/dts/qcom
Add regulator to camss device tree node.
Signed-off-by: Robert Foss
---
arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
index a943b3f353ce..5842ab65789c
This documentation has been incorporated in dtschema dt-bindings
for the devices supported by CAMSS and is no longer helpful.
Signed-off-by: Robert Foss
---
.../devicetree/bindings/media/qcom,camss.txt | 236 --
1 file changed, 236 deletions(-)
delete mode 100644 Documentation
Enable camss & ov8856 DT nodes.
Signed-off-by: Robert Foss
---
arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
i
Add bindings for qcom,sdm845-camss in order to support the camera
subsystem for SDM845.
Signed-off-by: Robert Foss
---
Changes since v2
- Rob: Removed extra empty lines at end of file
- Rob: Add new line at end of file
- Rob: Remove redundant descriptions
- Rob: Add power domain description
Due to the complexity of describing multiple hardware generations
in one document, switch to using separate dt-bindings.
Signed-off-by: Robert Foss
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index cdf1556c6007..7c5a494d9113
For Titan ISPs clocks fail to re-enable during vfe_get()
after any vfe has been halted and its corresponding power
domain power has been detached.
Since all of the clocks depend on all of the PDs, per
VFE PD detaching is no option for this generation of HW.
Signed-off-by: Robert Foss
Add bindings for qcom,msm8996-camss in order to support the camera
subsystem on MSM8996.
Signed-off-by: Robert Foss
---
Changes since v2
- Rob: Add new line at end of file
- Rob: Remove redundant descriptions
- Rob: Add power domain description
- Rob: Make clock-lanes a constant
- Rob
Add bindings for qcom,msm8916-camss in order to support the camera
subsystem on MSM8916.
Signed-off-by: Robert Foss
---
Changes since v2:
- Remove redundant descriptions
- Add power domain description
- Make clock-lanes a constant
- Add max & minItems to data-lanes
- Remove p
Enable support for SDM845 based Titan 170 ISPs.
Signed-off-by: Robert Foss
---
drivers/media/platform/qcom/camss/camss.c | 17 +
drivers/media/platform/qcom/camss/camss.h | 6 --
2 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/qcom
In order to support Qualcomm ISP hardware architectures that diverge
from older architectures, the CSID subdevice drivers needs to be refactored
to better abstract the different ISP hardware architectures.
Signed-off-by: Robert Foss
---
Changes since v1
- kernel test robot: Add missing include
, will be referred to as Gen2.
Signed-off-by: Robert Foss
---
Changes since v1
- kernel test robot: Re-add chunk missing from
vfe_output_update_pong_addr
- Andrey: Fix file name error
- Andrey: Change hardware version number in comment
- Changed copyright year to 2021 for camss-vfe-4-8.c
Changes
Add enum representing the SDM845 SOC, which incorporates version
170 of the Titan architecture ISP.
Signed-off-by: Robert Foss
---
drivers/media/platform/qcom/camss/camss.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/qcom/camss/camss.h
b/drivers/media/platform
is the
appropriate one to use.
Signed-off-by: Robert Foss
---
.../media/platform/qcom/camss/camss-csid.h| 50 +++
1 file changed, 50 insertions(+)
diff --git a/drivers/media/platform/qcom/camss/camss-csid.h
b/drivers/media/platform/qcom/camss/camss-csid.h
index 1824b3745e10..02fc34ee8a41
On Thu, 4 Feb 2021 at 23:25, Nicolas Boichat wrote:
>
> On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda wrote:
> >
> >
> > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze:
> > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss wrote:
> > >&g
Hey Xin,
On Thu, 28 Jan 2021 at 04:10, Xin Ji wrote:
>
> Add 'bus-type' and 'data-lanes' define for port0, add HDCP support
> flag and DP tx lane0 and lane1 swing register array define.
>
> Signed-off-by: Xin Ji
> ---
> .../bindings/display/bridge/analogix,anx7625.yaml | 54
>
Hi Xin,
On Thu, 28 Jan 2021 at 04:12, Xin Ji wrote:
>
> At some time, the original code may return non zero value, force return 0
> if operation finished
Missing "." at end of line.
Other than that, this patch looks fine. Feel free to add my r-b.
Reviewed-by: Robert Fo
Hey Bernard,
Thanks for the patch.
With the below fixed, feel free to add my r-b.
Reviewed-by: Robert Foss
On Tue, 2 Feb 2021 at 13:09, Bernard Zhao wrote:
>
> Line 1590 DRM_ERROR is redundant because devm_kzalloc() already
> prints an error.
The line number will not be s
Hi Xin,
Thanks for the patch.
On Thu, 28 Jan 2021 at 12:17, Xin Ji wrote:
>
> Enable DSI EOTP feature for fixing some panel screen constance
> shift issue.
> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
I don't think I quite understand how removing the
On Sat, 30 Jan 2021 at 18:23, Rob Herring wrote:
>
> On Wed, 27 Jan 2021 15:49:23 +0100, Robert Foss wrote:
> > Add bindings for qcom,sdm660-camss in order to support the camera
> > subsystem on SDM630/660 and SDA variants.
> >
> > Signed-off-by: Robert Foss
&g
Hey Sakari,
On Mon, 1 Feb 2021 at 14:40, Sakari Ailus wrote:
>
> Hi Robert,
>
> On Wed, Jan 27, 2021 at 03:49:18PM +0100, Robert Foss wrote:
> > Add register definitions for version 170 of the Titan architecture
> > and implement support for the CSIPHY subdevice.
>
Hey Bjorn,
On Tue, 2 Feb 2021 at 23:44, Bjorn Andersson wrote:
>
> On Wed 27 Jan 08:49 CST 2021, Robert Foss wrote:
>
> > Build camera ISP driver as a module.
> >
>
> Isn't this enabled since b47c5fc15d88 ("arm64: defconfig: Enable
> Qualcomm CAMCC, CAMS
Ping. I think this patch is ready to be merged.
On Wed, 20 Jan 2021 at 13:09, Robert Foss wrote:
>
> The previously added modes 3264x2448 & 1632x1224 are actually
> configuring the sensor for BGGR mode, this is an issue since
> the mode that is exposed through V4L incorrectl
Hey Nicolas,
Thanks for the review!
On Thu, 28 Jan 2021 at 01:19, Nicolas Boichat wrote:
>
> On Wed, Jan 27, 2021 at 10:56 PM Robert Foss wrote:
> >
> > In order to support Qualcomm ISP hardware architectures that diverge
> > from older architectures, the VF
In order to support Qualcomm ISP hardware architectures that diverge
from older architectures, the CSID subdevice drivers needs to be refactored
to better abstract the different ISP hardware architectures.
Signed-off-by: Robert Foss
---
Changes since v1
- kernel test robot: Add missing include
Add bindings for qcom,msm8996-camss in order to support the camera
subsystem on MSM8996.
Signed-off-by: Robert Foss
---
Changes since v2
- Rob: Add new line at end of file
- Rob: Remove redundant descriptions
- Rob: Add power domain description
- Rob: Make clock-lanes a constant
- Rob
Add bindings for qcom,sdm660-camss in order to support the camera
subsystem on SDM630/660 and SDA variants.
Signed-off-by: Robert Foss
---
Changes since v2
- Rob: Add new line at end of file
- Rob: Remove redundant descriptions
- Rob: Add power domain description
- Rob: Make clock-lanes
Add bindings for qcom,msm8916-camss in order to support the camera
subsystem on MSM8916.
Signed-off-by: Robert Foss
---
Changes since v2:
- Remove redundant descriptions
- Add power domain description
- Make clock-lanes a constant
- Add max & minItems to data-lanes
- Remove p
Add bindings for qcom,sdm845-camss in order to support the camera
subsystem for SDM845.
Signed-off-by: Robert Foss
---
Changes since v2
- Rob: Removed extra empty lines at end of file
- Rob: Add new line at end of file
- Rob: Remove redundant descriptions
- Rob: Add power domain description
Enable camss & ov8856 DT nodes.
Signed-off-by: Robert Foss
---
arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
i
Add regulator to camss device tree node.
Signed-off-by: Robert Foss
---
arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
index a943b3f353ce..5842ab65789c
Build camera ISP driver as a module.
Signed-off-by: Robert Foss
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 838301650a79..cb224d2af6a0 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch
Add the camss dt node for sdm845.
Signed-off-by: Robert Foss
---
Changes since v1
- Laurent: Fix subject
- Laurent: Remove redundant regulator labels
- Laurent: Remove empty line
arch/arm64/boot/dts/qcom/sdm845.dtsi | 130 +++
1 file changed, 130 insertions
This documentation has been incorporated in dtschema dt-bindings
for the devices supported by CAMSS and is no longer helpful.
Signed-off-by: Robert Foss
---
.../devicetree/bindings/media/qcom,camss.txt | 236 --
1 file changed, 236 deletions(-)
delete mode 100644 Documentation
Add register definitions for version 170 of the Titan architecture
and implement support for the CSID subdevice.
Signed-off-by: Robert Foss
---
drivers/media/platform/qcom/camss/Makefile| 1 +
.../platform/qcom/camss/camss-csid-170.c | 602 ++
.../media/platform/qcom
Due to the complexity of describing multiple hardware generations
in one document, switch to using separate dt-bindings.
Signed-off-by: Robert Foss
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index cdf1556c6007..7c5a494d9113
Enable support for SDM845 based Titan 170 ISPs.
Signed-off-by: Robert Foss
---
drivers/media/platform/qcom/camss/camss.c | 17 +
drivers/media/platform/qcom/camss/camss.h | 6 --
2 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/qcom
Add register definitions for version 170 of the Titan architecture
and implement support for the CSIPHY subdevice.
Signed-off-by: Robert Foss
---
.../qcom/camss/camss-csiphy-3ph-1-0.c | 182 --
.../media/platform/qcom/camss/camss-csiphy.c | 66 +--
drivers/media
For Titan ISPs clocks fail to re-enable during vfe_get()
after any vfe has been halted and its corresponding power
domain power has been detached.
Since all of the clocks depend on all of the PDs, per
VFE PD detaching is no option for this generation of HW.
Signed-off-by: Robert Foss
the CSI decoder receives
from the sensor.
For example will a sensor outputting YUV pixel format frames, only
allow the VFE to dump those frames as they are received by the ISP
to memory through the RDI interface.
Signed-off-by: Robert Foss
---
Changes since v1:
- Andrey: Removed commented out chunk
is the
appropriate one to use.
Signed-off-by: Robert Foss
---
.../media/platform/qcom/camss/camss-csid.h| 50 +++
1 file changed, 50 insertions(+)
diff --git a/drivers/media/platform/qcom/camss/camss-csid.h
b/drivers/media/platform/qcom/camss/camss-csid.h
index 1824b3745e10..02fc34ee8a41
, will be referred to as Gen2.
Signed-off-by: Robert Foss
---
Changes since v1
- kernel test robot: Re-add chunk missing from
vfe_output_update_pong_addr
- Andrey: Fix file name error
- Andrey: Change hardware version number in comment
- Changed copyright year to 2021 for camss-vfe-4-8.c
drivers
to support the Titan generation, make the
ISPIF an optional subdevice.
Signed-off-by: Robert Foss
---
Changes since v1:
- Björn: Improved commit message
- Björn: Use local 'dev' ptr instead of 'camss->dev'
- Björn: Remove res/ispif NULL checks
- Björn: Remove ispif NULL checks before call
Add enum representing the SDM845 SOC, which incorporates version
170 of the Titan architecture ISP.
Signed-off-by: Robert Foss
---
drivers/media/platform/qcom/camss/camss.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/qcom/camss/camss.h
b/drivers/media/platform
Comment refers to ISPIF, but this is incorrect. Only
the VFE interrupts are handled by this function.
Signed-off-by: Robert Foss
Reviewed-by: Bjorn Andersson
---
Changes since v1
- Bjorn: Add r-b
drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 2 +-
drivers/media/platform/qcom/camss
Function name is comment is wrong, and was changed to be
the same as the actual function name.
The comment was changed to kerneldoc format.
Signed-off-by: Robert Foss
---
Changes since v1
- Bjorn: Fix function doc name & use kerneldoc format
drivers/media/platform/qcom/camss/camss-vfe.c
s series depends
the sdm660 clock driver being upstreamed. I've linked this series below.
SDM630/660 Multimedia and GPU clock controllers
https://lkml.org/lkml/2020/9/26/166
Robert Foss (22):
media: camss: Fix vfe_isr_comp_done() documentation
media: camss: Fix vfe_isr comment typo
m
Thanks Rob!
On Fri, 22 Jan 2021 at 17:34, Rob Herring wrote:
>
> On Wed, Jan 20, 2021 at 02:43:50PM +0100, Robert Foss wrote:
> > Add bindings for qcom,sdm660-camss in order to support the camera
> > subsystem on SDM630/660 and SDA variants.
> >
> &
Silence indentation level warning reported by dt_binding_check in
order to reduce noise during routine checks.
$ make dt_binding_check
mt8192-mt6359-rt1015-rt5682.yaml:10:4: [warning] wrong indentation:
expected 2 but found 3 (indentation)
Signed-off-by: Robert Foss
---
.../devicetree/bindings
Silence indentation level warning reported by dt_binding_check in
order to reduce noise during routine checks.
$ make dt_binding_check
mt8192-mt6359-rt1015-rt5682.yaml:10:4: [warning] wrong indentation:
expected 2 but found 3 (indentation)
Signed-off-by: Robert Foss
---
.../bindings/sound
201 - 300 of 742 matches
Mail list logo
