[PATCH v1 2/4] dt-bindings: regulator: add pca9450 regulator yaml

2020-05-19 Thread Robin Gong
Add device binding doc for pca9450 pmic driver. Signed-off-by: Robin Gong --- .../bindings/regulator/nxp,pca9450-regulator.yaml | 190 + 1 file changed, 190 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml diff --git

[PATCH v1 1/4] regulator: pca9450: add pca9450 pmic driver

2020-05-19 Thread Robin Gong
Add NXP pca9450 pmic driver. Signed-off-by: Robin Gong --- drivers/regulator/Kconfig | 8 + drivers/regulator/Makefile| 1 + drivers/regulator/pca9450-regulator.c | 859 ++ include/linux/regulator/pca9450.h | 219 + 4 files

[PATCH v1 3/4] arm64: dts: imx8mn-evk: add pca9450 for i.mx8mn-evk board

2020-05-19 Thread Robin Gong
Add pca9450 pmic driver for i.mx8mn-evk board. Signed-off-by: Robin Gong --- arch/arm64/boot/dts/freescale/imx8mn-evk.dts | 96 +++ arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 6 ++ 2 files changed, 102 insertions(+) diff --git a/arch/arm64/boot/dts/freescale

RE: [PATCH v7 RESEND 13/13] dmaengine: imx-sdma: add uart rom script

2020-05-13 Thread Robin Gong
On 2020/05/14 5:07 Fabio Estevam wrote: > Hi Robin, > > On Mon, May 11, 2020 at 6:33 AM Robin Gong wrote: > > > Please get latest sdma firmware from the below and put them into the > > path > > (/lib/firmware/imx/sdma/): > > https://eur01.safelinks.pro

RE: [PATCH v7 RESEND 07/13] spi: imx: fix ERR009165

2020-05-13 Thread Robin Gong
On 2020/05/13 Sascha Hauer wrote: > On Wed, May 13, 2020 at 08:52:39AM +0000, Robin Gong wrote: > > On 2020/05/13 16:48 Sascha Hauer wrote: > > > On Wed, May 13, 2020 at 08:38:26AM +, Robin Gong wrote: > > > > On 2020/05/13 Sascha Hauer wrote: > > &

RE: [PATCH v7 RESEND 07/13] spi: imx: fix ERR009165

2020-05-13 Thread Robin Gong
On 2020/05/13 Sascha Hauer wrote: > On Wed, May 13, 2020 at 09:05:33AM +0000, Robin Gong wrote: > > On 2020/05/13 Sascha Hauer wrote:d > > > > drivers/spi/spi-imx.c | 16 > > > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > &g

RE: [PATCH v7 RESEND 07/13] spi: imx: fix ERR009165

2020-05-13 Thread Robin Gong
On 2020/05/13 Sascha Hauer wrote:d > > drivers/spi/spi-imx.c | 16 > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index > > f4f28a4..70df8e6 100644 > > --- a/drivers/spi/spi-imx.c > > +++

RE: [PATCH v7 RESEND 07/13] spi: imx: fix ERR009165

2020-05-13 Thread Robin Gong
On 2020/05/13 16:48 Sascha Hauer wrote: > On Wed, May 13, 2020 at 08:38:26AM +0000, Robin Gong wrote: > > On 2020/05/13 Sascha Hauer wrote: > > > This patch is the one bisecting will end up with when somebody uses > > > an older SDMA firmware or the ROM scrip

RE: [PATCH v7 RESEND 07/13] spi: imx: fix ERR009165

2020-05-13 Thread Robin Gong
se, hence, maybe we can fall back it to pio always. > > > > Signed-off-by: Robin Gong > > Acked-by: Mark Brown > > --- > > drivers/spi/spi-imx.c | 16 > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/driver

RE: [PATCH v7 RESEND 00/13] add ecspi ERR009165 for i.mx6/7 soc family

2020-05-13 Thread Robin Gong
On 2020/05/13 Sascha Hauer wrote: > On Tue, May 12, 2020 at 01:32:23AM +0800, Robin Gong wrote: > > There is ecspi ERR009165 on i.mx6/7 soc family, which cause FIFO > > transfer to be send twice in DMA mode. Please get more information from: > > https://eur01.safelinks.protec

RE: [PATCH v7 RESEND 03/13] Revert "dmaengine: imx-sdma: fix context cache"

2020-05-13 Thread Robin Gong
On 2020/05/13 Fuzzey, Martin wrote: > On Wed, 13 May 2020 at 08:07, Sascha Hauer > wrote: > > > > On Tue, May 12, 2020 at 01:32:26AM +0800, Robin Gong wrote: > > > This reverts commit d288bddd8374e0a043ac9dde64a1ae6a09411d74, since > > > 'context_loaded' fin

RE: [PATCH v7 RESEND 05/13] dmaengine: imx-sdma: remove dupilicated sdma_load_context

2020-05-13 Thread Robin Gong
On 2020/05/13 14:06 Sascha Hauer wrote: > Subject: Re: [PATCH v7 RESEND 05/13] dmaengine: imx-sdma: remove > dupilicated sdma_load_context > > In the subject: s/dupilicated/duplicated/ Will fix typo in v8.

[PATCH v7 RESEND 10/13] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul

2020-05-11 Thread Robin Gong
ECSPI issue fixed from i.mx6ul at hardware level, no need ERR009165 anymore on those chips such as i.mx8mq. Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/dma

[PATCH v7 RESEND 11/13] dma: imx-sdma: add i.mx6ul compatible name

2020-05-11 Thread Robin Gong
Add i.mx6ul compatible name in binding doc. Signed-off-by: Robin Gong Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt b/Documentation/devicetree

[PATCH v7 RESEND 12/13] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm

2020-05-11 Thread Robin Gong
only in case DEV_TO_DEV. Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 22f9f20..9d49aaf 100644 --- a/drivers/dma/imx-sdma.c

[PATCH v7 RESEND 09/13] spi: imx: add new i.mx6ul compatible name in binding doc

2020-05-11 Thread Robin Gong
ERR009165 fixed from i.mx6ul, add its compatible name in binding doc. Signed-off-by: Robin Gong Acked-by: Mark Brown Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/spi

[PATCH v7 RESEND 08/13] spi: imx: remove ERR009165 workaround on i.mx6ul

2020-05-11 Thread Robin Gong
ERR009165 fixed on i.mx6ul/6ull/6sll. All other i.mx6/7 and i.mx8m/8mm still need this errata. Please refer to nxp official errata document from https://www.nxp.com/ . For removing workaround on those chips. Add new i.mx6ul type. Signed-off-by: Robin Gong Acked-by: Mark Brown --- drivers/spi

[PATCH v7 RESEND 13/13] dmaengine: imx-sdma: add uart rom script

2020-05-11 Thread Robin Gong
the below and put them into the path (/lib/firmware/imx/sdma/): https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git /tree/imx/sdma Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 4 ++-- include/linux/platform_data/dma-imx-sdma.h

[PATCH v7 RESEND 05/13] dmaengine: imx-sdma: remove dupilicated sdma_load_context

2020-05-11 Thread Robin Gong
Since sdma_transfer_init() will do sdma_load_context before any sdma transfer, no need once more in sdma_config_channel(). Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/dma/imx-sdma.c b

[PATCH v7 RESEND 01/13] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core"

2020-05-11 Thread Robin Gong
litch can cause the current FIFO transfer to be sent twice So revert commit 'df07101e1c4a' firstly. Signed-off-by: Robin Gong --- arch/arm/boot/dts/imx6q.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6q.dtsi b/arch/arm/boot/dts/imx6q.dtsi inde

[PATCH v7 RESEND 03/13] Revert "dmaengine: imx-sdma: fix context cache"

2020-05-11 Thread Robin Gong
This reverts commit d288bddd8374e0a043ac9dde64a1ae6a09411d74, since 'context_loaded' finally removed. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 4d4477d..3d4aac9 100644

[PATCH v7 RESEND 04/13] Revert "dmaengine: imx-sdma: refine to load context only once"

2020-05-11 Thread Robin Gong
This reverts commit ad0d92d7ba6aecbe2705907c38ff8d8be4da1e9c, because in spi-imx case, burst length may be changed dynamically. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index

[PATCH v7 RESEND 07/13] spi: imx: fix ERR009165

2020-05-11 Thread Robin Gong
Change to XCH mode even in dma mode, please refer to the below errata: https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf Signed-off-by: Robin Gong Acked-by: Mark Brown --- drivers/spi/spi-imx.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/spi/spi

[PATCH v7 RESEND 02/13] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores"

2020-05-11 Thread Robin Gong
can cause the current FIFO transfer to be sent twice So revert commit 'dd4b487b32a3' firstly. Signed-off-by: Robin Gong --- arch/arm/boot/dts/imx6qdl.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx

[PATCH v7 RESEND 06/13] dmaengine: imx-sdma: add mcu_2_ecspi script

2020-05-11 Thread Robin Gong
Add mcu_2_ecspi script to fix ecspi errata ERR009165. Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 69ea44d..e034375 100644 --- a/drivers/dma/imx-sdma.c

[PATCH v7 RESEND 00/13] add ecspi ERR009165 for i.mx6/7 soc family

2020-05-11 Thread Robin Gong
51 and taking care SMC bit for PIO. 3.Add back missing 'Reviewed-by' tag on 08/15(v5):09/13(v7) 'spi: imx: add new i.mx6ul compatible name in binding doc' Robin Gong (13): Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" Revert "ARM: dts: imx6: Use correct S

RE: [PATCH v1] dmaengine: imx-sdma: fix kernel hangs with SLUB slab allocator

2019-10-14 Thread Robin Gong
On 2019-10-14 Vinod Koul wrote: > On 14-10-19, 13:32, Vinod Koul wrote: > > On 24-09-19, 09:49, Robin Gong wrote: > > > Illegal memory will be touch if SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V3 > > > (41) exceed the size of structure sdma_script_start_addrs(40), thus > > &g

RE: [PATCH v5 11/15] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm

2019-09-26 Thread Robin Gong
On 2019-9-25 22:53 Schrempf Frieder wrote: > On 25.09.19 13:26, Robin Gong wrote: > > On 2019-9-24 21:28 Schrempf Frieder > wrote: > >> > >> Hi Robin, > >> > >>> From: Robin Gong > >>> > >>> Because the number of ecs

RE: [PATCH v5 11/15] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm

2019-09-25 Thread Robin Gong
On 2019-9-24 21:28 Schrempf Frieder wrote: > > Hi Robin, > > > From: Robin Gong > > > > Because the number of ecspi1 rx event on i.mx8mm is 0, the condition > > check ignore such special case without dma channel enabled, which > > caused > > ecspi

RE: [PATCH v5 12/15] ARM: dts: imx6ul: add dma support on ecspi

2019-09-24 Thread Robin Gong
Ping Sacha... On 2019-7-24 9:53 Robin Gong wrote: > On 2019-7-24 at 08:49 Shawn Guo wrote: > > On Tue, Jul 23, 2019 at 09:39:38AM +0000, Robin Gong wrote: > > > On 2019-7-17 at 14:42 Shawn Guo wrote: > > > > On Mon, Jun 10, 2019 at 04:17:50PM +0800, yibin.g...@n

[PATCH v1] dmaengine: imx-sdma: fix kernel hangs with SLUB slab allocator

2019-09-24 Thread Robin Gong
3 (38->41 3 scripts added) not align with script number added in sdma_script_start_addrs(2 scripts). Fixes: a572460be9cf ("dmaengine: imx-sdma: Add support for version 3 firmware") Cc: stable@vger.kernel Link: https://www.spinics.net/lists/arm-kernel/msg754895.html Signed-off-by: Robin Gon

RE: [PATCH v5 2/3] dmaengine: imx-sdma: fix dma freezes

2019-09-23 Thread Robin Gong
On 2019-9-23 21:58 Philipp Puschmann wrote: > For some years and since many kernel versions there are reports that the RX > UART SDMA channel stops working at some point. The workaround was to > disable DMA for RX. This commit fixes the problem itself. Cyclic DMA transfers > are used by uart and

RE: [PATCH v4 2/3] dmaengine: imx-sdma: fix dma freezes

2019-09-23 Thread Robin Gong
On 2019-9-19 22:30 Philipp Puschmann wrote > For some years and since many kernel versions there are reports that the RX > UART SDMA channel stops working at some point. The workaround was to > disable DMA for RX. This commit tries to fix the problem itself. > > Due to its license i wasn't

RE: [PATCH 0/4] Fix UART DMA freezes for iMX6

2019-09-16 Thread Robin Gong
On 2019/9/11 Philipp Puschmann wrote: > For some years and since many kernel versions there are reports that RX > UART DMA channel stops working at one point. So far the usual workaround > was to disable RX DMA. This patches try to fix the underlying problem. > > When a running sdma script does

RE: [PATCH v3] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

2019-09-16 Thread Robin Gong
; + if (lp_status & SNVS_LPSR_SPO) { > >> + if (pdata->minor_rev > 0) > >> + expire = jiffies + msecs_to_jiffies(DEBOUNCE_TIME); > >> + mod_timer(>check_timer, expire); > > > > Why do we even need to fire the timer

RE: [PATCH v2 1/2] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

2019-08-29 Thread Robin Gong
On 2019-08-29 16:17, Marco Felsch wrote: > > > While reading the rm it seems that > > > the snvs block has a dedicated version register. IMHO this could be > > > a better way to apply the change also to existing devices with old > > > firmware. > > > > I thought the same thing, and fully agree

RE: [PATCH] input: keyboard: snvs_pwrkey: Send press and release event for i.MX6 S,DL and Q

2019-08-27 Thread Robin Gong
On Fri, Aug 23, 2019 at 02:30:02PM +0200, Robin van der Gracht wrote:> > The older generation i.MX6 processors send a powerdown request interrupt > if the powerkey is released before a hard shutdown (5 second press). This > should allow software to bring down the SoC safely. > > For this driver

[RESEND PATCH v7] dmaengine: fsl-edma: add i.mx7ulp edma2 version support

2019-07-24 Thread Robin Gong
Add edma2 for i.mx7ulp by version v3, since v2 has already been used by mcf-edma. The big changes based on v1 are belows: 1. only one dmamux. 2. another clock dma_clk except dmamux clk. 3. 16 independent interrupts instead of only one interrupt for all channels. Signed-off-by: Robin Gong

RE: [PATCH v5 12/15] ARM: dts: imx6ul: add dma support on ecspi

2019-07-23 Thread Robin Gong
On 2019-7-24 at 08:49 Shawn Guo wrote: > On Tue, Jul 23, 2019 at 09:39:38AM +0000, Robin Gong wrote: > > On 2019-7-17 at 14:42 Shawn Guo wrote: > > > On Mon, Jun 10, 2019 at 04:17:50PM +0800, yibin.g...@nxp.com wrote: > > > > From: Robin Gong > >

RE: [PATCH v5 12/15] ARM: dts: imx6ul: add dma support on ecspi

2019-07-23 Thread Robin Gong
On 2019-7-17 at 14:42 Shawn Guo wrote: > On Mon, Jun 10, 2019 at 04:17:50PM +0800, yibin.g...@nxp.com wrote: > > From: Robin Gong > > > > Add dma support on ecspi. > > > > Signed-off-by: Robin Gong > > Applied, thanks. Thanks Shawn, but how about other d

[RESEND PATCH v6] dmaengine: fsl-edma: add i.mx7ulp edma2 version support

2019-07-23 Thread Robin Gong
Add edma2 for i.mx7ulp by version v3, since v2 has already been used by mcf-edma. The big changes based on v1 are belows: 1. only one dmamux. 2. another clock dma_clk except dmamux clk. 3. 16 independent interrupts instead of only one interrupt for all channels. Signed-off-by: Robin Gong

RE: linux-next: build failure after merge of the slave-dma tree

2019-07-07 Thread Robin Gong
On 2019/7/8 12:17 Vinod Koul wrote: > On 08-07-19, 11:06, zhangfei wrote: > > Hi, Robin > > > > On 2019/7/8 上午9:22, Robin Gong wrote: > > > Hi Stephen, > > > That's caused by 'of_irq_count' NOT export to global symbol, and > > > I'm curious why i

RE: linux-next: build failure after merge of the slave-dma tree

2019-07-07 Thread Robin Gong
On 2019/7/8 11:06 AM, zhangfei wrote: > Hi, Robin > > On 2019/7/8 上午9:22, Robin Gong wrote: > > Hi Stephen, > > That's caused by 'of_irq_count' NOT export to global symbol, and I'm > > curious why it has been here for so long since Zhangfei found it in

RE: linux-next: build failure after merge of the slave-dma tree

2019-07-07 Thread Robin Gong
On 06-07-19, 22:43, Vinod Koul wrote: > > That's caused by 'of_irq_count' NOT export to global symbol, and I'm > > curious why it has been here for so long since Zhangfei found it in > > 2015. > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc > > >

RE: linux-next: build failure after merge of the slave-dma tree

2019-07-07 Thread Robin Gong
Hi Stephen, That's caused by 'of_irq_count' NOT export to global symbol, and I'm curious why it has been here for so long since Zhangfei found it in 2015. https://patchwork.kernel.org/patch/7404681/ Hi Rob, Is there something I miss so that Zhangfei's patch not accepted finally?

RE: linux-next: build failure after merge of the slave-dma tree

2019-07-06 Thread Robin Gong
Hi Stephen, That's caused by 'of_irq_count' NOT export to global symbol, and I'm curious why it has been here for so long since Zhangfei found it in 2015. https://patchwork.kernel.org/patch/7404681/ Hi Rob, Is there something I miss so that Zhangfei's patch not accepted finally?

RE: [PATCH v5 00/15] add ecspi ERR009165 for i.mx6/7 soc family

2019-06-25 Thread Robin Gong
. > -Original Message- > From: Shawn Guo > Sent: 2019年6月24日 8:17 > Subject: Re: [PATCH v5 00/15] add ecspi ERR009165 for i.mx6/7 soc family > > On Fri, Jun 21, 2019 at 08:42:48AM +, Robin Gong wrote: > > Hello Shawn/Will, > >   Do you have comments for this

RE: [PATCH] dmaengine: imx-sdma: fix use-after-free on probe error path

2019-06-25 Thread Robin Gong
Reviewed-by: Robin Gong > -Original Message- > From: Sven Van Asbroeck > Subject: [PATCH] dmaengine: imx-sdma: fix use-after-free on probe error path > > If probe() fails anywhere beyond the point where > sdma_get_firmware() is called, then a kernel oops may occur

RE: [PATCH v4 1/6] dmaengine: fsl-edma: add drvdata for fsl-edma

2019-06-25 Thread Robin Gong
Okay, will correct it and send v5 after rebase. >On 25-06-19, 16:17, Vinod Koul wrote: > On 14-06-19, 16:17, yibin.g...@nxp.com wrote: > > From: Robin Gong > > > > There are some differences between vf610 and next i.mx7ulp. Put such > > differences into static dri

Re: [PATCH v5 00/15] add ecspi ERR009165 for i.mx6/7 soc family

2019-06-21 Thread Robin Gong
Hello Shawn/Will,   Do you have comments for this V5 patch set? I got tags from Mark, Vinod and Rob. On 2019-06-10 at 08:17 +, yibin.g...@nxp.com wrote: > From: Robin Gong > >   There is ecspi ERR009165 on i.mx6/7 soc family, which cause FIFO > transfer to be send twice in DMA

Re: [PATCH v5 10/15] dma: imx-sdma: add i.mx6ul/6sx compatible name

2019-06-11 Thread Robin Gong
On 2019-06-11 at 22:35 +, Rob Herring wrote: > On Mon, 10 Jun 2019 16:17:48 +0800, yibin.g...@nxp.com wrote: > > > > From: Robin Gong > > > > Add i.mx6ul and i.mx6sx compatible name in binding doc. > > > > Signed-off-by: Robin Gong > > --- &

Re: [PATCH v5 15/15] dmaengine: imx-sdma: add uart rom script

2019-06-10 Thread Robin Gong
On 2019-06-10 at 12:55 +, Vinod Koul wrote: > On 10-06-19, 16:17, yibin.g...@nxp.com wrote: > > > > From: Robin Gong > > > > For the compatibility of NXP internal legacy kernel before 4.19 > > which > > is based on uart ram script and upstreaming kerne

Re: [PATCH v3 7/8] dmaengine: fsl-edma: add i.mx7ulp edma2 version support

2019-06-04 Thread Robin Gong
On 2019-06-04 at 12:37 +, Vinod Koul wrote: > On 29-05-19, 17:08, yibin.g...@nxp.com wrote: > > > > From: Robin Gong > > > >   Add edma2 for i.mx7ulp by version v3, since v2 has already > Why leading spaces at start of line? Sorry for the typo, will fix in next

Re: [PATCH v3 5/8] dmaengine: fsl-edma: add drvdata for vf610

2019-06-04 Thread Robin Gong
On 二, 2019-06-04 at 18:03 +0530, Vinod Koul wrote: > On 29-05-19, 17:08, yibin.g...@nxp.com wrote: > > > > > @@ -205,8 +228,9 @@ static int fsl_edma_probe(struct > > platform_device *pdev) > >   if (!fsl_edma) > >   return -ENOMEM; > >   > > - fsl_edma->version = v1; > > -

Re: [PATCH v2 6/7] dmaengine: fsl-edma: add i.mx7ulp edma2 version support

2019-05-27 Thread Robin Gong
On 2019-05-27 at 11:05 +0200, Sascha Hauer wrote: > On Mon, May 27, 2019 at 04:51:17PM +0800, yibin.g...@nxp.com wrote: > > > > From: Robin Gong > > > > +static const struct of_device_id fsl_edma_dt_ids[] = { > > + { .compatible = "fsl,vf610-edma",

Re: [PATCH v2 4/7] dmaengine: fsl-edma-common: version check for v2 instead

2019-05-27 Thread Robin Gong
On 2019-05-27 at 09:08 +, Sascha Hauer wrote: > On Mon, May 27, 2019 at 04:51:15PM +0800, yibin.g...@nxp.com wrote: > > > > From: Robin Gong > > > > The next v3 i.mx7ulp edma is based on v1, so change version > > check logic for v2 instead. &

Re: [PATCH v1 4/6] dmaengine: fsl-edma: add i.mx7ulp edma2 version support

2019-05-27 Thread Robin Gong
On 2019-05-27 at 06:34 +, Vinod Koul wrote: > On 10-05-19, 10:14, Robin Gong wrote: > > > >   > > + if (of_device_is_compatible(np, "fsl,imx7ulp-edma")) { > > + fsl_edma->dmamux_nr = 1; > > + fsl_edma->version = v3; > w

RE:Re: [PATCH v4 00/14] add ecspi ERR009165 for i.mx6/7 soc family

2019-05-22 Thread Robin Gong
> -Original Message- > From: Lucas Stach > Sent: 2019年5月22日 18:10 > Hi Robin, > > Am Mittwoch, den 22.05.2019, 09:59 +0000 schrieb Robin Gong: > > There is ecspi ERR009165 on i.mx6/7 soc family, which cause FIFO > > transfer to be send twice in DMA mod

RE: [EXT] Re: [PATCH v4 10/14] dma: imx-sdma: add i.mx6ul/6sx compatible name

2019-05-22 Thread Robin Gong
> Sent: 2019年5月22日 21:51> > On Wed, 22 May 2019 10:00:38 +0000, Robin Gong wrote: > > Add i.mx6ul and i.mx6sx compatible name in binding doc. > > > > Signed-off-by: Robin Gong > > --- > > Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt | 2 ++ > &g

[PATCH v4 11/14] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm

2019-05-22 Thread Robin Gong
only in case DEV_TO_DEV. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index a495c7f..b692783 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx

[PATCH v4 12/14] ARM: dts: imx6ul: add dma support on ecspi

2019-05-22 Thread Robin Gong
Add dma support on ecspi. Signed-off-by: Robin Gong --- arch/arm/boot/dts/imx6ul.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi index bbf010c..880b9ee 100644 --- a/arch/arm/boot/dts/imx6ul.dtsi +++ b/arch/arm/boot

[PATCH v4 13/14] ARM: dts: imx6sll: correct sdma compatible

2019-05-22 Thread Robin Gong
Correct sdma compatible since ecspi errata ERR009165 has been fixed on i.mx6sll as i.mx6ul. Signed-off-by: Robin Gong --- arch/arm/boot/dts/imx6sll.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6sll.dtsi b/arch/arm/boot/dts/imx6sll.dtsi index

[PATCH v4 14/14] arm64: defconfig: Enable SDMA on i.mx8mq/8mm

2019-05-22 Thread Robin Gong
Enable SDMA support on i.mx8mq/8mm chips, including enabling CONFIG_FW_LOADER_USER_HELPER/CONFIG_FW_LOADER_USER_HELPER_FALLBACK for firmware loaded by udev. Signed-off-by: Robin Gong --- arch/arm64/configs/defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/configs

[PATCH v4 05/14] dmaengine: imx-sdma: add mcu_2_ecspi script

2019-05-22 Thread Robin Gong
Add mcu_2_ecspi script to fix ecspi errata ERR009165. Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 3 +++ include/linux/platform_data/dma-imx-sdma.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx

[PATCH v4 06/14] spi: imx: fix ERR009165

2019-05-22 Thread Robin Gong
Change to XCH mode even in dma mode, please refer to the below errata: https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf Signed-off-by: Robin Gong Acked-by: Mark Brown --- drivers/spi/spi-imx.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/spi

[PATCH v4 10/14] dma: imx-sdma: add i.mx6ul/6sx compatible name

2019-05-22 Thread Robin Gong
Add i.mx6ul and i.mx6sx compatible name in binding doc. Signed-off-by: Robin Gong --- Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt b/Documentation/devicetree/bindings/dma/fsl

[PATCH v4 07/14] spi: imx: remove ERR009165 workaround on i.mx6ul

2019-05-22 Thread Robin Gong
ERR009165 fixed on i.mx6ul/6ull/6sll. All other i.mx6/7 and i.mx8m/8mm still need this errata. Please refer to nxp official errata document from https://www.nxp.com/ . For removing workaround on those chips. Add new i.mx6ul type. Signed-off-by: Robin Gong Acked-by: Mark Brown --- drivers/spi

[PATCH v4 02/14] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores"

2019-05-22 Thread Robin Gong
litch can cause the current FIFO transfer to be sent twice So revert commit 'dd4b487b32a3' firstly. Signed-off-by: Robin Gong --- arch/arm/boot/dts/imx6qdl.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx

[PATCH v4 04/14] dmaengine: imx-sdma: remove dupilicated sdma_load_context

2019-05-22 Thread Robin Gong
Since sdma_transfer_init() will do sdma_load_context before any sdma transfer, no need once more in sdma_config_channel(). Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/dma/imx-sdma.c b

[PATCH v4 08/14] spi: imx: add new i.mx6ul compatible name in binding doc

2019-05-22 Thread Robin Gong
ERR009165 fixed from i.mx6ul, add its compatible name in binding doc. Signed-off-by: Robin Gong Acked-by: Mark Brown --- Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt b

[PATCH v4 03/14] Revert "dmaengine: imx-sdma: refine to load context only once"

2019-05-22 Thread Robin Gong
This reverts commit ad0d92d7ba6aecbe2705907c38ff8d8be4da1e9c, because in spi-imx case, burst length may be changed dynamically. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index

[PATCH v4 09/14] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul

2019-05-22 Thread Robin Gong
ECSPI issue fixed from i.mx6ul at hardware level, no need ERR009165 anymore on those chips such as i.mx8mq. Add i.mx6sx from where i.mx6ul source. Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 51 +- 1 file changed

[PATCH v4 01/14] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core"

2019-05-22 Thread Robin Gong
litch can cause the current FIFO transfer to be sent twice So revert commit 'df07101e1c4a' firstly. Signed-off-by: Robin Gong --- arch/arm/boot/dts/imx6q.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6q.dtsi b/arch/arm/boot/dts/imx6q.dtsi inde

[PATCH v4 00/14] add ecspi ERR009165 for i.mx6/7 soc family

2019-05-22 Thread Robin Gong
tx_wml set to 0 in the errata workaroud, thus improve performance as possible. v4: 1. add Ack tag from Mark and Vinod 2. remove checking 'event_id1' zero as 'event_id0'. Robin Gong (14): Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" Revert "ARM: dts: im

RE: Re: Re: [PATCH v3 11/14] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm

2019-05-20 Thread Robin Gong
> -Original Message- > From: Vinod Koul > Sent: 2019年5月21日 13:13 > > On 21-05-19, 04:58, Robin Gong wrote: > > > -Original Message- > > > From: Vinod Koul > > > Sent: 2019年5月21日 12:18 > > > > > > On 07-05-19, 09:16, Rob

RE: Re: [PATCH v3 11/14] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm

2019-05-20 Thread Robin Gong
> -Original Message- > From: Vinod Koul > Sent: 2019年5月21日 12:18 > > On 07-05-19, 09:16, Robin Gong wrote: > > Because the number of ecspi1 rx event on i.mx8mm is 0, the condition > > check ignore such special case without dma channel enabled, which > >

Re: [EXT] Re: [PATCH v3 00/14] add ecspi ERR009165 for i.mx6/7 soc family

2019-05-17 Thread Robin Gong
not fixed on i.mx8m/8mm and other i.mx6/7 legacy > > chips. > >   Correct dts related dts patch in v2. > >   2. clean eratta information in binding doc and new > > 'tx_glitch_fixed' flag > >   in spi-imx driver to state ERR009165 fixed or not. > >   3. Enlarge bur

[PATCH v1 6/6] ARM: dts: imx7ulp: add edma device node

2019-05-10 Thread Robin Gong
Add edma device node in dts. Signed-off-by: Robin Gong --- arch/arm/boot/dts/imx7ulp.dtsi | 28 1 file changed, 28 insertions(+) diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi index d6b7110..b4f7adf 100644 --- a/arch/arm/boot/dts

[PATCH v1 3/6] dmaengine: fsl-edma-common: move dmamux register to another single function

2019-05-10 Thread Robin Gong
Prepare for edmav2 on i.mx7ulp whose dmamux register is 32bit. No function impacted. Signed-off-by: Robin Gong --- drivers/dma/fsl-edma-common.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c

[PATCH v1 1/6] dmaengine: fsl-edma: add dmamux_nr for next version

2019-05-10 Thread Robin Gong
Next version of edma such as edmav2 on i.mx7ulp has only one dmamux. Add dmamux_nr instead of static macro define 'DMAMUX_NR'. No any function change here. Signed-off-by: Robin Gong --- drivers/dma/fsl-edma-common.h | 1 + drivers/dma/fsl-edma.c| 11 ++- 2 files changed, 7

[PATCH v1 4/6] dmaengine: fsl-edma: add i.mx7ulp edma2 version support

2019-05-10 Thread Robin Gong
Add edma2 for i.mx7ulp by version v3, since v2 has already been used by mcf-edma. The big changes based on v1 are belows: 1. only one dmamux. 2. another clock dma_clk except dmamux clk. 3. 16 independent interrupts instead of only one interrupt for all channels. Signed-off-by: Robin Gong

[PATCH v1 5/6] dt-bindings: dma: fsl-edma: add new i.mx7ulp-edma

2019-05-10 Thread Robin Gong
More channel interrupts, one more clock, and only one dmamux on i.mx7ulp-edma. Signed-off-by: Robin Gong --- Documentation/devicetree/bindings/dma/fsl-edma.txt | 44 +++--- 1 file changed, 39 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/dma/fsl

[PATCH v1 2/6] dmaengine: mcf-edma: update to 'dmamux_nr'

2019-05-10 Thread Robin Gong
Update to 'dmamux_nr' instead of static macro DMAMUX_NR since new version edma only has one dmamux. Signed-off-by: Robin Gong --- drivers/dma/fsl-edma-common.c | 2 +- drivers/dma/mcf-edma.c| 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/dma/fsl-edma

[PATCH v1 0/6] add edma2 for i.mx7ulp

2019-05-10 Thread Robin Gong
request irq without IRQF_SHARED flag, since 16 channels are enough on i.mx7ulp whose M4 domain own some peripherals. Robin Gong (6): dmaengine: fsl-edma: add dmamux_nr for next version dmaengine: mcf-edma: update to 'dmamux_nr' dmaengine: fsl-edma-common: move dmamux register to another single

RE: [EXT] Re: [PATCH v3 10/14] dt-bindings: dma: imx-sdma: add i.mx6ul/6sx compatible name

2019-05-08 Thread Robin Gong
> On Wed, 8 May 2019 09:16:38 +, Rob Herring wrote: > On Tue, 7 May 2019 09:16:38 +, Robin Gong wrote: > > Add i.mx6ul and i.mx6sx compatible name. > > > > Signed-off-by: Robin Gong > > --- > > Documentation/devicetree/bindings/dma/fsl-imx-sd

[PATCH v3 14/14] arm64: defconfig: Enable SDMA on i.mx8mq/8mm

2019-05-07 Thread Robin Gong
Enable SDMA support on i.mx8mq/8mm chips, including enabling CONFIG_FW_LOADER_USER_HELPER/CONFIG_FW_LOADER_USER_HELPER_FALLBACK for firmware loaded by udev. Signed-off-by: Robin Gong --- arch/arm64/configs/defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/configs

[PATCH v3 12/14] ARM: dts: imx6ul: add dma support on ecspi

2019-05-07 Thread Robin Gong
Add dma support on ecspi. Signed-off-by: Robin Gong --- arch/arm/boot/dts/imx6ul.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi index bbf010c..880b9ee 100644 --- a/arch/arm/boot/dts/imx6ul.dtsi +++ b/arch/arm/boot

[PATCH v3 10/14] dt-bindings: dma: imx-sdma: add i.mx6ul/6sx compatible name

2019-05-07 Thread Robin Gong
Add i.mx6ul and i.mx6sx compatible name. Signed-off-by: Robin Gong --- Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt b/Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt

[PATCH v3 11/14] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm

2019-05-07 Thread Robin Gong
be 0. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index a495c7f..86594fc 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -1370,8 +1370,8

[PATCH v3 08/14] dt-bindings: spi: imx: add new i.mx6ul compatible name

2019-05-07 Thread Robin Gong
ERR009165 fixed from i.mx6ul, add its compatible name. Signed-off-by: Robin Gong --- Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt b/Documentation/devicetree/bindings/spi/fsl-imx

[PATCH v3 06/14] spi: imx: fix ERR009165

2019-05-07 Thread Robin Gong
Change to XCH mode even in dma mode, please refer to the below errata: https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf Signed-off-by: Robin Gong --- drivers/spi/spi-imx.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-imx.c b/drivers/spi

[PATCH v3 13/14] ARM: dts: imx6sll: correct sdma compatible

2019-05-07 Thread Robin Gong
Correct sdma compatible since ecspi errata ERR009165 has been fixed on i.mx6sll as i.mx6ul. Signed-off-by: Robin Gong --- arch/arm/boot/dts/imx6sll.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6sll.dtsi b/arch/arm/boot/dts/imx6sll.dtsi index

[PATCH v3 09/14] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul

2019-05-07 Thread Robin Gong
ECSPI issue fixed from i.mx6ul at hardware level, no need ERR009165 anymore on those chips such as i.mx8mq. Add i.mx6sx from where i.mx6ul source. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 51 +- 1 file changed, 50 insertions(+), 1

[PATCH v3 07/14] spi: imx: remove ERR009165 workaround on i.mx6ul

2019-05-07 Thread Robin Gong
ERR009165 fixed on i.mx6ul/6ull/6sll. All other i.mx6/7 and i.mx8m/8mm still need this errata. Please refer to nxp official errata document from https://www.nxp.com/ . For removing workaround on those chips. Add new i.mx6ul type. Signed-off-by: Robin Gong --- drivers/spi/spi-imx.c | 50

[PATCH v3 05/14] dmaengine: imx-sdma: add mcu_2_ecspi script

2019-05-07 Thread Robin Gong
Add mcu_2_ecspi script to fix ecspi errata ERR009165. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 3 +++ include/linux/platform_data/dma-imx-sdma.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 86a31b4

[PATCH v3 04/14] dmaengine: imx-sdma: remove dupilicated sdma_load_context

2019-05-07 Thread Robin Gong
Since sdma_transfer_init() will do sdma_load_context before any sdma transfer, no need once more in sdma_config_channel(). Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c

[PATCH v3 01/14] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core"

2019-05-07 Thread Robin Gong
litch can cause the current FIFO transfer to be sent twice So revert commit 'df07101e1c4a' firstly. Signed-off-by: Robin Gong --- arch/arm/boot/dts/imx6q.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6q.dtsi b/arch/arm/boot/dts/imx6q.dtsi inde

[PATCH v3 03/14] Revert "dmaengine: imx-sdma: refine to load context only once"

2019-05-07 Thread Robin Gong
This reverts commit ad0d92d7ba6aecbe2705907c38ff8d8be4da1e9c, because in spi-imx case, burst length may be changed dynamically. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index

[PATCH v3 02/14] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores"

2019-05-07 Thread Robin Gong
litch can cause the current FIFO transfer to be sent twice So revert commit 'dd4b487b32a3' firstly. Signed-off-by: Robin Gong --- arch/arm/boot/dts/imx6qdl.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx

[PATCH v3 00/14] add ecspi ERR009165 for i.mx6/7 soc family

2019-05-07 Thread Robin Gong
tx_wml set to 0 in the errata workaroud, thus improve performance as possible. Robin Gong (14): Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores" Revert "dmaengine: imx-sdma: refine

<    1   2   3   4   5   6   7   8   9   >