RE: [EXT] Re: [PATCH v2 08/15] dt-bindings: spi: imx: add i.mx6ul to state errata fixed

> On Fri, Apr 26, 2019 at 08:05:51AM +0000, Robin Gong wrote: > > ERR009165 fixed from i.mx6ul, add it to show the errata fixed. > > > > Signed-off-by: Robin Gong > > --- > > Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt | 2 ++ > > 1 file chan

RE: [EXT] Re: [PATCH v2 08/15] dt-bindings: spi: imx: add i.mx6ul to state errata fixed

> On Fri, Apr 26, 2019 at 08:05:51AM +0000, Robin Gong wrote: > > ERR009165 fixed from i.mx6ul, add it to show the errata fixed. > > > > Signed-off-by: Robin Gong > > --- > > Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt | 2 ++ > > 1 file chan

Re: [EXT] Re: [PATCH v2 06/15] spi: imx: fix ERR009165

On 2019-04-26 at 11:37 +0200, Lucas Stach wrote: > Am Freitag, den 26.04.2019, 09:22 + schrieb Robin Gong: > > > > On 2019-04-26 at 11:07 +0200, Lucas Stach wrote: > > > > > > > > > Am Freitag, den 26.04.2019, 08:05 + schrieb Robin Gong: &g

Re: [EXT] Re: [PATCH v2 07/15] spi: imx: remove ERR009165 workaround on i.mx6ul

On 2019-04-26 at 11:09 +0200, Lucas Stach wrote: >  > >  static inline int is_imx53_ecspi(struct spi_imx_data *d) > > @@ -585,9 +587,16 @@ static int mx51_ecspi_prepare_transfer(struct > > spi_imx_data *spi_imx, > >   ctrl |= mx51_ecspi_clkdiv(spi_imx, t->speed_hz, ); > >   

Re: [EXT] Re: [PATCH v2 06/15] spi: imx: fix ERR009165

On 2019-04-26 at 11:07 +0200, Lucas Stach wrote: > > Am Freitag, den 26.04.2019, 08:05 + schrieb Robin Gong: > >  static void mx51_setup_wml(struct spi_imx_data *spi_imx) > >  { > > + u32 tx_wml = 0; > > + > With a wml of 0 you might set the maxburst of

Re: [EXT] Re: [PATCH v2 00/15] add ecspi ERR009165 for i.mx6/7 soc family

On 2019-04-26 at 08:19 +, Lucas Stach wrote: > Caution: EXT Email > > Hi Robin, > > Am Freitag, den 26.04.2019, 08:05 +0000 schrieb Robin Gong: > > > >   There is ecspi ERR009165 on i.mx6/7 soc family, which cause FIFO > > transfer to be send twice in DMA

[PATCH v2 15/15] arm64: defconfig: Enable SDMA on i.mx8mq/8mm

Enable SDMA support on i.mx8mq/8mm chips, including enabling CONFIG_FW_LOADER_USER_HELPER/CONFIG_FW_LOADER_USER_HELPER_FALLBACK for firmware loaded by udev. Signed-off-by: Robin Gong --- arch/arm64/configs/defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/configs

[PATCH v2 11/15] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm

be 0. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 3e912b6..4b2b7ca 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -1371,8 +1371,8

[PATCH v2 07/15] spi: imx: remove ERR009165 workaround on i.mx6ul

ERR009165 fix on i.mx6ul and next chip, such as i.mx6ull/i.mx8mq/i.mx8mm. Remove workaround on those chips. Add new i.mx6ul type for that. Signed-off-by: Robin Gong --- drivers/spi/spi-imx.c | 39 +++ 1 file changed, 35 insertions(+), 4 deletions(-) diff

[PATCH v2 12/15] ARM64: dts: freescale: imx8mm/8mq: update new compatible name for ecspi and sdma

Add new 'imx6ul-ecspi' compatible name for ecspi and new 'imx8mq-sdma' name for sdma since on i.mx8mm/mq chip fix ecspi errata. Signed-off-by: Robin Gong --- arch/arm64/boot/dts/freescale/imx8mm.dtsi | 14 +++--- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 6 +++--- 2 files changed, 10

[PATCH v2 10/15] dt-bindings: dma: imx-sdma: add i.mx6ul/6sx compatible name

Add i.mx6ul and i.mx6sx compatible name. Signed-off-by: Robin Gong --- Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt b/Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt

[PATCH v2 14/15] ARM: dts: imx6sll: correct ecspi/sdma compatible

Correct ecspi/sdma compatible since ecspi errata ERR009165 which is not fixed on i.mx6sll chip. Signed-off-by: Robin Gong --- arch/arm/boot/dts/imx6sll.dtsi | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/imx6sll.dtsi b/arch/arm/boot/dts

[PATCH v2 05/15] dmaengine: imx-sdma: add mcu_2_ecspi script

Add mcu_2_ecspi script to fix ecspi errata ERR009165. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 3 +++ include/linux/platform_data/dma-imx-sdma.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 86a31b4

[PATCH v2 09/15] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul

ECSPI issue fixed from i.mx6ul at hardware level, no need ERR009165 anymore on those chips such as i.mx8mq. Add i.mx6sx from where i.mx6ul source. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 52 +- 1 file changed, 51 insertions(+), 1

[PATCH v2 06/15] spi: imx: fix ERR009165

Change to XCH mode even in dma mode, please refer to the below errata: https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf Signed-off-by: Robin Gong --- drivers/spi/spi-imx.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi

[PATCH v2 13/15] ARM: dts: imx6ul: add dma support on ecspi

Add dma support on ecspi. Signed-off-by: Robin Gong --- arch/arm/boot/dts/imx6ul.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi index bbf010c..880b9ee 100644 --- a/arch/arm/boot/dts/imx6ul.dtsi +++ b/arch/arm/boot

[PATCH v2 08/15] dt-bindings: spi: imx: add i.mx6ul to state errata fixed

ERR009165 fixed from i.mx6ul, add it to show the errata fixed. Signed-off-by: Robin Gong --- Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt b/Documentation/devicetree/bindings

[PATCH v2 02/15] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores"

litch can cause the current FIFO transfer to be sent twice So revert commit 'dd4b487b32a3' firstly. Signed-off-by: Robin Gong --- arch/arm/boot/dts/imx6qdl.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx

[PATCH v2 04/15] dmaengine: imx-sdma: remove dupilicated sdma_load_context

Since sdma_transfer_init() will do sdma_load_context before any sdma transfer, no need once more in sdma_config_channel(). Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c

[PATCH v2 01/15] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core"

litch can cause the current FIFO transfer to be sent twice So revert commit 'df07101e1c4a' firstly. Signed-off-by: Robin Gong --- arch/arm/boot/dts/imx6q.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6q.dtsi b/arch/arm/boot/dts/imx6q.dtsi inde

[PATCH v2 00/15] add ecspi ERR009165 for i.mx6/7 soc family

. add commit log for reverted patches. 2. add comment for 'ecspi_fixed' in sdma driver. 3. add 'fsl,imx6sll-ecspi' compatible instead of 'fsl,imx6ul-ecspi' rather than remove. Robin Gong (15): Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" Revert "ARM:

[PATCH v2 03/15] Revert "dmaengine: imx-sdma: refine to load context only once"

This reverts commit ad0d92d7ba6aecbe2705907c38ff8d8be4da1e9c, because in spi-imx case, burst length may be changed dynamically. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index

Re: [EXT] Re: [PATCH v1 14/15] ARM: dts: imx6sll: correct ecspi/sdma compatible

On 2019-04-24 at 08:37 +0200, s.ha...@pengutronix.de wrote: > On Tue, Apr 23, 2019 at 01:51:45PM +0000, Robin Gong wrote: > > > > Correct ecspi/sdma compatible since ecspi errata ERR009165 > > not fixed on i.mx6sll chip. > > > > Signed-off-by: Robin Gon

Re: [EXT] Re: [PATCH v1 01/15] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core"

On 2019-04-23 at 11:02 -0300, Fabio Estevam wrote: > Hi Robin, > > On Tue, Apr 23, 2019 at 10:50 AM Robin Gong > wrote: > > > > > > This reverts commit df07101e1c4a29e820df02f9989a066988b160e6. > You need to provide a detailed explanation in the commit log a

[PATCH v1 15/15] arm64: defconfig: Enable SDMA on i.mx8mq/8mm

Enable SDMA support on i.mx8mq/8mm chips, including enabling CONFIG_FW_LOADER_USER_HELPER/CONFIG_FW_LOADER_USER_HELPER_FALLBACK for firmware loaded by udev. Signed-off-by: Robin Gong --- arch/arm64/configs/defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/configs

[PATCH v1 13/15] ARM: dts: imx6ul: add dma support on ecspi

Add dma support on ecspi. Signed-off-by: Robin Gong --- arch/arm/boot/dts/imx6ul.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi index bbf010c..880b9ee 100644 --- a/arch/arm/boot/dts/imx6ul.dtsi +++ b/arch/arm/boot

[PATCH v1 14/15] ARM: dts: imx6sll: correct ecspi/sdma compatible

Correct ecspi/sdma compatible since ecspi errata ERR009165 not fixed on i.mx6sll chip. Signed-off-by: Robin Gong --- arch/arm/boot/dts/imx6sll.dtsi | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/imx6sll.dtsi b/arch/arm/boot/dts/imx6sll.dtsi

[PATCH v1 12/15] ARM64: dts: freescale: imx8mm/8mq: update new compatible name for ecspi and sdma

Add new 'imx6ul-ecspi' compatible name for ecspi and new 'imx8mq-sdma' name for sdma since on i.mx8mm/mq chip fix ecspi errata. Signed-off-by: Robin Gong --- arch/arm64/boot/dts/freescale/imx8mm.dtsi | 14 +++--- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 6 +++--- 2 files changed, 10

[PATCH v1 10/15] dt-bindings: dma: imx-sdma: add i.mx6ul/6sx compatible name

Add i.mx6ul and i.mx6sx compatible name. Signed-off-by: Robin Gong --- Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt b/Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt

[PATCH v1 11/15] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm

be 0. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 99c44a5..d87a8f9 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -1363,8 +1363,8

[PATCH v1 09/15] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul

ECSPI issue fixed from i.mx6ul at hardware level, no need ERR009165 anymore on those chips such as i.mx8mq. Add i.mx6sx from where i.mx6ul source. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 43 ++- 1 file changed, 42 insertions(+), 1 deletion

[PATCH v1 08/15] dt-bindings: spi: imx: add i.mx6ul to state errata fixed

ERR009165 fixed from i.mx6ul, add it to show the errata fixed. Signed-off-by: Robin Gong --- Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt b/Documentation/devicetree/bindings

[PATCH v1 06/15] spi: imx: fix ERR009165

Change to XCH mode even in dma mode, please refer to the below errata: https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf Signed-off-by: Robin Gong --- drivers/spi/spi-imx.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi

[PATCH v1 07/15] spi: imx: remove ERR009165 workaround on i.mx6ul

ERR009165 fix on i.mx6ul and next chip, such as i.mx6ull/i.mx8mq/i.mx8mm. Remove workaround on those chips. Add new i.mx6ul type for that. Signed-off-by: Robin Gong --- drivers/spi/spi-imx.c | 39 +++ 1 file changed, 35 insertions(+), 4 deletions(-) diff

[PATCH v1 05/15] dma: engine: imx-sdma: add mcu_2_ecspi script

Add mcu_2_ecspi script to fix ecspi errata ERR009165. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 3 +++ include/linux/platform_data/dma-imx-sdma.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 8a8ce98a

[PATCH v1 04/15] dmaengine: imx-sdma: remove dupilicated sdma_load_context

Since sdma_transfer_init() will do sdma_load_context before any sdma transfer, no need once more in sdma_config_channel(). Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 407a56e

[PATCH v1 03/15] Revert "dmaengine: imx-sdma: refine to load context only once"

This reverts commit ad0d92d7ba6aecbe2705907c38ff8d8be4da1e9c, because in spi-imx case, burst length may be changed dynamically. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index

[PATCH v1 02/15] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores"

This reverts commit dd4b487b32a3571fdcc66062e661e3a3e360e35b. Signed-off-by: Robin Gong --- arch/arm/boot/dts/imx6qdl.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index b3a77bc..a90f217 100644

[PATCH v1 01/15] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core"

This reverts commit df07101e1c4a29e820df02f9989a066988b160e6. Signed-off-by: Robin Gong --- arch/arm/boot/dts/imx6q.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6q.dtsi b/arch/arm/boot/dts/imx6q.dtsi index d038f41..7175898 100644 --- a/arch/arm

[PATCH v1 00/15] add ecspi ERR009165 for i.mx6/7 soc family

support for i.mx8mm/8mq and fix ecspi1 not work on i.mx8mm because the event id is zero. PS: Please get sdma firmware from below linux-firmware and copy it to your local rootfs /lib/firmware/imx/sdma. https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/imx/sdma Robin

Re: [PATCH v2 2/3] dmaengine: imx-sdma: Only check ratio on parts that support 1:1

Acked-by: Robin Gong On 2019-03-29 at 15:21 +, Angus Ainslie (Purism) wrote: > On imx8mq B0 chip, AHB/SDMA clock ratio 2:1 can't be supported, > since SDMA clock ratio has to be increased to 250Mhz, AHB can't reach > to 500Mhz, so use 1:1 instead. > > To limit this chang

Re: Issues with i.MX SPI DMA transfers

send out patch set to review, hope you could have chance to try. > > -- > > Igor Plyatov > > > > > > > > > -Original Message- > > > From: Robin Gong > > > Sent: April 9, 2019 11:26> > > > Hi Igor, > > >  Plea

RE: Issues with i.MX SPI DMA transfers

Hi Igor, Did you meet any issue with my latest patch? > -Original Message- > From: Robin Gong > Sent: April 9, 2019 11:26> > Hi Igor, > Please have a try with the attached patches, and revert 25aaa75df1e6, > ad0d92d7ba6a , dd4b487b32a3, df07101e1c4a

RE: Issues with i.MX SPI DMA transfers

Hi Igor, Please have a try with the attached patches, and revert 25aaa75df1e6, ad0d92d7ba6a , dd4b487b32a3, df07101e1c4a before apply. Besides XCH, tx thresh should be set to 0 , now no failure caught on ecspi5. > -Original Message- > From: Robin Gong > Sent: 2019年4

RE: Issues with i.MX SPI DMA transfers

> -Original Message- > From: Igor Plyatov > Sent: 2019年4月3日 23:51 > To: Robin Gong > Cc: Uwe Kleine-König ; > linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > linux-...@vger.kernel.org; dl-linux-imx ; Fabio Estevam > ; Pengutronix Kernel Team

RE: Issues with i.MX SPI DMA transfers

> -Original Message- > From: Igor Plyatov > Sent: 2019年4月2日 20:15 > To: Robin Gong > Cc: Uwe Kleine-König ; > linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > linux-...@vger.kernel.org; dl-linux-imx ; Fabio Estevam > ; Pengutronix Kernel Team

RE: Issues with i.MX SPI DMA transfers

> -Original Message- > From: Igor Plyatov > Sent: 2019年4月2日 15:20 > To: Robin Gong ; Uwe Kleine-König > > Cc: linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > linux-...@vger.kernel.org; dl-linux-imx ; Fabio Estevam > ; Pengutronix Kernel Team

RE: Issues with i.MX SPI DMA transfers

> -Original Message- > From: Igor Plyatov > Sent: 2019年3月28日 19:06 > To: Robin Gong ; Uwe Kleine-König > > Cc: linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > linux-...@vger.kernel.org; dl-linux-imx ; Fabio Estevam > ; Pengutronix Kern

RE: Issues with i.MX SPI DMA transfers

l ; Dan Williams > ; Andy Duan ; Han Xu > ; Robin Gong ; Clark Wang > > Subject: Re: Issues with i.MX SPI DMA transfers > > Dear Uwe, > > > > Hello Igor, > > > > On Wed, Mar 27, 2019 at 08:40:00PM +0300, Igor Plyatov wrote: > >> please, help to r

RE: Issues with i.MX SPI DMA transfers

Sascha Hauer ; Shawn Guo > ; Mark Brown ; > dmaeng...@vger.kernel.org; Vinod Koul ; Dan Williams > ; Andy Duan ; Han Xu > ; Robin Gong ; Clark Wang > > Subject: Re: Issues with i.MX SPI DMA transfers > > Dear Uwe, > > > > Hello Igor, > > > > On Wed,

RE: [PATCH] dma: imx-sdma: pass ->dev to dma_alloc_coherent() API

Reviewed-by: Robin Gong > -Original Message- > From: Daniel Baluta > Sent: 2019年1月11日 22:30 > To: vk...@kernel.org; dmaeng...@vger.kernel.org > Cc: dl-linux-imx ; ker...@pengutronix.de; > dan.j.willi...@intel.com; linux-kernel@vger.kernel.org; S.j. Wang > ; A

RE: [PATCH v1] dmaengine: imx-sdma: refine to load context only once

Hi Vinod, I have sent v2 after rebase. Please have a try. > -Original Message- > From: Vinod Koul > Sent: 2019年1月4日 23:15 > To: Robin Gong > Cc: dan.j.willi...@intel.com; ker...@pengutronix.de; > dmaeng...@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linu

[PATCH v2] dmaengine: imx-sdma: refine to load context only once

The context loaded only one time before channel running,but currently sdma_config_channel() and dma_prep_* duplicated with sdma_load_context(), so refine it to load context only one time before channel running and reload after the channel terminated. Signed-off-by: Robin Gong --- drivers/dma

[PATCH v1] dmaengine: imx-sdma: refine to load context only once

The context loaded only one time before channel running,but currently sdma_config_channel() and dma_prep_* duplicated with sdma_load_context(), so refine it to load context only one time before channel running and reload after the channel terminated. Signed-off-by: Robin Gong --- drivers/dma

[PATCH v1] dmaengine: imx-sdma: refine to load context only once

The context loaded only one time before channel running,but currently sdma_config_channel() and dma_prep_* duplicated with sdma_load_context(), so refine it to load context only one time before channel running and reload after the channel terminated. Signed-off-by: Robin Gong --- drivers/dma

RE: [PATCH v3 0/4] Correct dma pool for imx-sdma

Hello Vinod, This patch set test by Lucas and no any other comment received yet, do you have comments and help to push it on 4.19 stable tree? > -Original Message- > From: Robin Gong > Sent: 2018年11月20日 17:09 > To: 'Lucas Stach' ; vk...@kernel.org > Cc: dmaeng...@

RE: [PATCH v3 0/4] Correct dma pool for imx-sdma

Hello Vinod, This patch set test by Lucas and no any other comment received yet, do you have comments and help to push it on 4.19 stable tree? > -Original Message- > From: Robin Gong > Sent: 2018年11月20日 17:09 > To: 'Lucas Stach' ; vk...@kernel.org > Cc: dmaeng...@

RE: [PATCH v3 0/4] Correct dma pool for imx-sdma

> -Original Message- > From: Lucas Stach > Sent: 2018年11月12日 23:56 > To: Robin Gong ; vk...@kernel.org > Cc: dmaeng...@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx > > Subject: Re: [PATCH v3 0/4] Correct dma pool for imx-sdma > > Hi R

RE: [PATCH v3 0/4] Correct dma pool for imx-sdma

> -Original Message- > From: Lucas Stach > Sent: 2018年11月12日 23:56 > To: Robin Gong ; vk...@kernel.org > Cc: dmaeng...@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx > > Subject: Re: [PATCH v3 0/4] Correct dma pool for imx-sdma > > Hi R

[PATCH v3 4/4] dmaengine: imx-sdma: use GFP_NOWAIT for dma descriptor allocations

From: Lucas Stach DMA buffer descriptors aren't allocated from atomic context, so they can use the less heavyweigth GFP_NOWAIT. Signed-off-by: Lucas Stach Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/imx

[PATCH v3 2/4] Revert "dmaengine: imx-sdma: alloclate bd memory from dma pool"

in question is broken as it only allocates memory for a single descriptor, without looking at the number of descriptors required for the transfer, leading to out-of-bounds accesses when the descriptors are written. Signed-off-by: Lucas Stach Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 18

[PATCH v3 3/4] dmaengine: imx-sdma: implement channel termination via worker

async, we need to implement the device_synchronize dma engine function which simply waits for the worker to finish its execution. Signed-off-by: Lucas Stach Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 51 +- 1 file changed, 38 insertions

[PATCH v3 4/4] dmaengine: imx-sdma: use GFP_NOWAIT for dma descriptor allocations

From: Lucas Stach DMA buffer descriptors aren't allocated from atomic context, so they can use the less heavyweigth GFP_NOWAIT. Signed-off-by: Lucas Stach Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/imx

[PATCH v3 2/4] Revert "dmaengine: imx-sdma: alloclate bd memory from dma pool"

in question is broken as it only allocates memory for a single descriptor, without looking at the number of descriptors required for the transfer, leading to out-of-bounds accesses when the descriptors are written. Signed-off-by: Lucas Stach Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 18

[PATCH v3 3/4] dmaengine: imx-sdma: implement channel termination via worker

async, we need to implement the device_synchronize dma engine function which simply waits for the worker to finish its execution. Signed-off-by: Lucas Stach Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 51 +- 1 file changed, 38 insertions

[PATCH v3 0/4] Correct dma pool for imx-sdma

This patch set to correct dma pool used in the commit fe5b85c656bc ("dmaengine: imx-sdma: alloclate bd memory from dma pool") because all bds should be contiguous in memory in multi bds case for sdma, but dma pool can't statify it and cause transfer failure then.Thank Lucas for the making things

[PATCH v3 0/4] Correct dma pool for imx-sdma

This patch set to correct dma pool used in the commit fe5b85c656bc ("dmaengine: imx-sdma: alloclate bd memory from dma pool") because all bds should be contiguous in memory in multi bds case for sdma, but dma pool can't statify it and cause transfer failure then.Thank Lucas for the making things

[PATCH v3 1/4] Revert "dmaengine: imx-sdma: Use GFP_NOWAIT for dma allocations"

From: Lucas Stach This reverts commit c1199875d327, as this depends on another commit that is going to be reverted. Signed-off-by: Lucas Stach Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/imx-sdma.c b

[PATCH v3 1/4] Revert "dmaengine: imx-sdma: Use GFP_NOWAIT for dma allocations"

From: Lucas Stach This reverts commit c1199875d327, as this depends on another commit that is going to be reverted. Signed-off-by: Lucas Stach Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/imx-sdma.c b

[PATCH v1 1/3] spi: imx: move wml setting to later than setup_transfer

, thus, the next patch could get the right last sg length for wml setting. This patch is a preparation one, no any function change involved. Signed-off-by: Robin Gong --- drivers/spi/spi-imx.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/spi

[PATCH v1 2/3] spi: imx: correct wml as the last sg length

timed out Signed-off-by: Robin Gong --- drivers/spi/spi-imx.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index e861157..037abbb 100644 --- a/drivers/spi/spi-imx.c +++ b/drivers/spi/spi-imx.c

[PATCH v1 3/3] spi: imx: use PIO mode if size is small

Use PIO mode instead if size is smaller than fifo size, since dma may be less efficient. Signed-off-by: Robin Gong --- drivers/spi/spi-imx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index 037abbb..dd1ce12 100644 --- a/drivers/spi/spi

[PATCH v1 0/3] Correct wml setting for spi-imx in dma mode

: -110 spi_master spi0: failed to transfer one message from queue mtd_test: error: read failed at 0x20c267 mtd_stresstest: error -110 occurred = insmod: ERROR: could not insert module mtd_stresstest.ko: Connection timed out Robin Gong (3): spi: imx

[PATCH v1 0/3] Correct wml setting for spi-imx in dma mode

: -110 spi_master spi0: failed to transfer one message from queue mtd_test: error: read failed at 0x20c267 mtd_stresstest: error -110 occurred = insmod: ERROR: could not insert module mtd_stresstest.ko: Connection timed out Robin Gong (3): spi: imx

[PATCH v1 1/3] spi: imx: move wml setting to later than setup_transfer

, thus, the next patch could get the right last sg length for wml setting. This patch is a preparation one, no any function change involved. Signed-off-by: Robin Gong --- drivers/spi/spi-imx.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/spi

[PATCH v1 2/3] spi: imx: correct wml as the last sg length

timed out Signed-off-by: Robin Gong --- drivers/spi/spi-imx.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index e861157..037abbb 100644 --- a/drivers/spi/spi-imx.c +++ b/drivers/spi/spi-imx.c

[PATCH v1 3/3] spi: imx: use PIO mode if size is small

Use PIO mode instead if size is smaller than fifo size, since dma may be less efficient. Signed-off-by: Robin Gong --- drivers/spi/spi-imx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index 037abbb..dd1ce12 100644 --- a/drivers/spi/spi

RE: [PATCH v1] tty: serial: imx: enable IDDMAEN for the last tail data

> -Original Message- > From: Uwe Kleine-König > Sent: 2018年9月20日 15:55 > To: Robin Gong > Cc: jsl...@suse.com; Andy Duan ; > linux-ser...@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx > ; ker...@pengutronix.de > Subject: Re: [PATCH v1] tty: ser

RE: [PATCH v1] tty: serial: imx: enable IDDMAEN for the last tail data

> -Original Message- > From: Uwe Kleine-König > Sent: 2018年9月20日 15:55 > To: Robin Gong > Cc: jsl...@suse.com; Andy Duan ; > linux-ser...@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx > ; ker...@pengutronix.de > Subject: Re: [PATCH v1] tty: ser

[PATCH v1] tty: serial: imx: enable IDDMAEN for the last tail data

. Signed-off-by: Robin Gong --- drivers/tty/serial/imx.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 239c0fa..bbb1693 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -1278,7 +1278,7

[PATCH v1] tty: serial: imx: enable IDDMAEN for the last tail data

. Signed-off-by: Robin Gong --- drivers/tty/serial/imx.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 239c0fa..bbb1693 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -1278,7 +1278,7

RE: [PATCH v2 3/4] dmaengine: imx-sdma: implement channel termination via worker

> -Original Message- > From: Lucas Stach > Sent: 2018年9月17日 19:04 > To: Robin Gong ; Vinod Koul > Cc: dmaeng...@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx > ; ker...@pengutronix.de; > patchwork-...@pengutronix.de > Subject: Re: [PATCH v2

RE: [PATCH v2 3/4] dmaengine: imx-sdma: implement channel termination via worker

> -Original Message- > From: Lucas Stach > Sent: 2018年9月17日 19:04 > To: Robin Gong ; Vinod Koul > Cc: dmaeng...@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx > ; ker...@pengutronix.de; > patchwork-...@pengutronix.de > Subject: Re: [PATCH v2

RE: [PATCH v2 3/4] dmaengine: imx-sdma: implement channel termination via worker

> -Original Message- > From: Lucas Stach > Sent: 2018年9月15日 1:06 > To: Vinod Koul > Cc: dmaeng...@vger.kernel.org; linux-kernel@vger.kernel.org; Robin Gong > ; dl-linux-imx ; > ker...@pengutronix.de; patchwork-...@pengutronix.de > Subject: [PATCH v2 3/4] dmaeng

RE: [PATCH v2 3/4] dmaengine: imx-sdma: implement channel termination via worker

> -Original Message- > From: Lucas Stach > Sent: 2018年9月15日 1:06 > To: Vinod Koul > Cc: dmaeng...@vger.kernel.org; linux-kernel@vger.kernel.org; Robin Gong > ; dl-linux-imx ; > ker...@pengutronix.de; patchwork-...@pengutronix.de > Subject: [PATCH v2 3/4] dmaeng

[PATCH v1] ARM: arm: configs: imx_v6_v7: add CONFIG_FW_LOADER_USER_HELPER

-firmware.git/tree/imx/sdma Signed-off-by: Robin Gong --- arch/arm/configs/imx_v6_v7_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index e2c1276..5e35d7e2 100644 --- a/arch/arm/configs/imx_v6_v7_defconfig

[PATCH v1] ARM: arm: configs: imx_v6_v7: add CONFIG_FW_LOADER_USER_HELPER

-firmware.git/tree/imx/sdma Signed-off-by: Robin Gong --- arch/arm/configs/imx_v6_v7_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index e2c1276..5e35d7e2 100644 --- a/arch/arm/configs/imx_v6_v7_defconfig

RE: [PATCH v3 3/3] dmaengine: imx-sdma: allocate max 20 bds for one transfer

Hello Lucas, Any comment for my reply? > -Original Message- > From: Robin Gong > Sent: 2018年7月25日 9:25 > To: 'Lucas Stach' ; vk...@kernel.org; > dan.j.willi...@intel.com; s.ha...@pengutronix.de; li...@armlinux.org.uk > Cc: dmaeng...@vger.kernel.org; dl

RE: [PATCH v3 3/3] dmaengine: imx-sdma: allocate max 20 bds for one transfer

Hello Lucas, Any comment for my reply? > -Original Message- > From: Robin Gong > Sent: 2018年7月25日 9:25 > To: 'Lucas Stach' ; vk...@kernel.org; > dan.j.willi...@intel.com; s.ha...@pengutronix.de; li...@armlinux.org.uk > Cc: dmaeng...@vger.kernel.org; dl

RE: [PATCH v8 5/6] regulator: pfuze100-regulator: provide pm_power_off_prepare handler

> >> +static struct pfuze_chip *syspm_pfuze_chip; > >> + > >> +static void pfuze_power_off_prepare(void) > >> + dev_info(syspm_pfuze_chip->dev, "Configure standy mode for power > >> +off"); > > Add 'if (syspm_pfuze_chip ->chip_id == PFUZE100))' here is easy for > > extend Support on

RE: [PATCH v8 5/6] regulator: pfuze100-regulator: provide pm_power_off_prepare handler

> >> +static struct pfuze_chip *syspm_pfuze_chip; > >> + > >> +static void pfuze_power_off_prepare(void) > >> + dev_info(syspm_pfuze_chip->dev, "Configure standy mode for power > >> +off"); > > Add 'if (syspm_pfuze_chip ->chip_id == PFUZE100))' here is easy for > > extend Support on

RE: [PATCH v8 1/6] ARM: imx6q: provide documentation for new fsl,pmic-stby-poweroff property

> >> Not all boards follow the reference design, that's a fact of life. > >> > >> Please look at the i.MX6Q reference manual. The sequence implemented > >> in this patchset can be found as a valid way to power off the system > >> in > >> "60.4.3 Power mode transitions" "Normal ON to OFF with

RE: [PATCH v8 1/6] ARM: imx6q: provide documentation for new fsl,pmic-stby-poweroff property

> >> Not all boards follow the reference design, that's a fact of life. > >> > >> Please look at the i.MX6Q reference manual. The sequence implemented > >> in this patchset can be found as a valid way to power off the system > >> in > >> "60.4.3 Power mode transitions" "Normal ON to OFF with

RE: [PATCH v8 6/6] ARM: dts: imx6: RIoTboard provide standby on power off option

nfradead.org; > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Andrew Morton > ; Liam Girdwood ; > Leonard Crestez ; Rob Herring > ; Mark Rutland ; Michael > Turquette ; Stephen Boyd > ; Fabio Estevam ; Russell > King ; dl-linux-imx ; Robin Gong > ; A.s. Dong > Subject:

RE: [PATCH v8 6/6] ARM: dts: imx6: RIoTboard provide standby on power off option

nfradead.org; > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Andrew Morton > ; Liam Girdwood ; > Leonard Crestez ; Rob Herring > ; Mark Rutland ; Michael > Turquette ; Stephen Boyd > ; Fabio Estevam ; Russell > King ; dl-linux-imx ; Robin Gong > ; A.s. Dong > Subject:

RE: [PATCH v8 5/6] regulator: pfuze100-regulator: provide pm_power_off_prepare handler

nfradead.org; > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Andrew Morton > ; Liam Girdwood ; > Leonard Crestez ; Rob Herring > ; Mark Rutland ; Michael > Turquette ; Stephen Boyd > ; Fabio Estevam ; Russell > King ; dl-linux-imx ; Robin Gong > ; A.s. Dong > Subje

RE: [PATCH v8 5/6] regulator: pfuze100-regulator: provide pm_power_off_prepare handler

nfradead.org; > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Andrew Morton > ; Liam Girdwood ; > Leonard Crestez ; Rob Herring > ; Mark Rutland ; Michael > Turquette ; Stephen Boyd > ; Fabio Estevam ; Russell > King ; dl-linux-imx ; Robin Gong > ; A.s. Dong > Subje

RE: [PATCH v8 2/6] ARM: imx6: register pm_power_off handler if "fsl,pmic-stby-poweroff" is set

nfradead.org; > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Andrew Morton > ; Liam Girdwood ; > Leonard Crestez ; Rob Herring > ; Mark Rutland ; Michael > Turquette ; Stephen Boyd > ; Fabio Estevam ; Russell > King ; dl-linux-imx ; Robin Gong > ; A.s. Dong > Subject:

RE: [PATCH v8 2/6] ARM: imx6: register pm_power_off handler if "fsl,pmic-stby-poweroff" is set

nfradead.org; > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Andrew Morton > ; Liam Girdwood ; > Leonard Crestez ; Rob Herring > ; Mark Rutland ; Michael > Turquette ; Stephen Boyd > ; Fabio Estevam ; Russell > King ; dl-linux-imx ; Robin Gong > ; A.s. Dong > Subject:

RE: [PATCH v8 1/6] ARM: imx6q: provide documentation for new fsl,pmic-stby-poweroff property

> -Original Message- > From: Lucas Stach [mailto:l.st...@pengutronix.de] > Sent: 2018年7月27日 16:30 > To: Robin Gong ; Oleksij Rempel > ; Shawn Guo ; Mark > Brown ; Rafael J. Wysocki > Cc: Mark Rutland ; devicet...@vger.kernel.org; > Michael Turquette ; Steph

<    1   2   3   4   5   6   7   8   9   >